From nobody Sun Feb 8 22:18:37 2026 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AEB3430C371; Thu, 8 Jan 2026 18:16:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.177.32 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767896183; cv=none; b=hCaIihlXVX0Rs2deTZgr5Gm/yeiNEn/Q8Ex9KptVImLR+sLohX3un4RTbDr1etgyjErCDdZYbMTbhSyVIMpuyAEbgIr+A9oL9TiaxovRns4WPZAffPsVw9RYaqF//HHsqLpwrpVuMTpBAXQLL+e80DNpaO/cq1/l6L+hRoDhZrg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767896183; c=relaxed/simple; bh=V9OCKVz7rCMpPtkmNbku6EfWqpAr31tlmTRMYXbda38=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=MkWcowDE7sYvDHLCqJdzIbF2dlsM2RB7UZWmuSMFvDp4AOM3EKrjbhCaTd+ropmgm14rMOIfku7d+bQUCc/EbE0RwBK47mkViVAUg4gPMHitUqTlFiDvPNbQgtfGieoGyCJAcxyuRA9Lkdmt7aRcnrBcxQr8VH3jzA5iLYRgmb0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com; spf=pass smtp.mailfrom=oracle.com; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b=OTt2FzJ0; arc=none smtp.client-ip=205.220.177.32 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oracle.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="OTt2FzJ0" Received: from pps.filterd (m0333520.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 608Ho1RN1207540; Thu, 8 Jan 2026 18:16:14 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=corp-2025-04-25; bh=MQK/v Osv3/GV9PcnK5rJ5mGGpzPaZ9CjB59HA/3M/QQ=; b=OTt2FzJ02J/mzBNzxlOto MynOk/3golpcLKbKcXom5/pAg/CpFKStNS4HSUaSRtJ8mXBIhHb9yvbpB6pZup2l 64JoWxMF9VhKUCsH/QbU3NIhFZVmZwMVSF+o9fvL0g2lrmSuJQfPVvnvORiM4BYG 9ooeUd9KmVTc+d5uYoEKKsIKyiYTfIDlX8O4mj9B1l0haRlNK2Fk1j9YAMlLDweD YPD9cPq6+VQTx8bECR35AIYmjH1Bvaxyyts14BEAXxFtcGeCXhSuv7F+EV+MhRYu t2KAIIP9HDM50E85hIjCClW+UkVr/jt+Nn77twyykjDTYLP4UGuSkoOpMfzwZwS3 A== Received: from phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta01.appoci.oracle.com [138.1.114.2]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 4bjhb181bg-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 08 Jan 2026 18:16:14 +0000 (GMT) Received: from pps.filterd (phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 608GYJ0d019956; Thu, 8 Jan 2026 18:16:13 GMT Received: from ca-dev112.us.oracle.com (ca-dev112.us.oracle.com [10.129.136.47]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTP id 4besjb58a9-2; Thu, 08 Jan 2026 18:16:13 +0000 From: Samasth Norway Ananda To: dan.carpenter@linaro.org, gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 1/3] staging: rtl8723bs: fix firmware memory leak on error Date: Thu, 8 Jan 2026 10:16:09 -0800 Message-ID: <20260108181612.2340796-2-samasth.norway.ananda@oracle.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260108181612.2340796-1-samasth.norway.ananda@oracle.com> References: <20260108181612.2340796-1-samasth.norway.ananda@oracle.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-08_03,2026-01-08_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 suspectscore=0 spamscore=0 mlxlogscore=999 phishscore=0 malwarescore=0 adultscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2512120000 definitions=main-2601080135 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTA4MDEzNSBTYWx0ZWRfX7xqQnS4aWHtK I5Gi3kgrwRt0CLzZVx0UlP9tJkD4oNfUcfE/z8v7m7yGFtkba1NBxfma51az5O/4Rao31F5Hg7w Cc0GaUlMoUuf5HIy+vrNAVPFSuFCSPX/W9tuxGgpTCSvwdw8cf8AkUvKhr0TT1jiFnlrkTAQxsa DKJTTZXp3RwRNt6dsdUSGXm3Nj5qPQbXG3a+RGzhqS/OVaGGAF4EpAnLRZdboEGTJhmJVhqXh2X du3X5ltNbO10QXpoTJ3K83Ti2Lxu1x/GQRfPAC5R3LCJqUU1gk1TozsehGODJARBXzTvQA1tvyF qayWVB6S935aOW3+6Zu1idiHJE46136sqAsp6nifnFOsGubxcVUMJDx1X27M6mmySEDSJEaeAXk LHd2h3oeEepr70ejqQNQpxK1u52EDeG2JsGBm11w4aUjeRTNrNTFryy9nasHjBrHySyH94Pv3wY w5en2lHXzyzBe8CM/2w== X-Proofpoint-ORIG-GUID: On_ILZZYdaHPezV6YL8CzuZ2rGn31BBT X-Proofpoint-GUID: On_ILZZYdaHPezV6YL8CzuZ2rGn31BBT X-Authority-Analysis: v=2.4 cv=S4PUAYsP c=1 sm=1 tr=0 ts=695ff46e cx=c_pps a=XiAAW1AwiKB2Y8Wsi+sD2Q==:117 a=XiAAW1AwiKB2Y8Wsi+sD2Q==:17 a=vUbySO9Y5rIA:10 a=VkNPw1HP01LnGYTKEx00:22 a=yPCof4ZbAAAA:8 a=uo-a5Ro3onDdK20lcsEA:9 Content-Type: text/plain; charset="utf-8" After successfully calling request_firmware(), if the firmware size check fails or if kmemdup() fails, the code jumps to the exit label without calling release_firmware(), causing a memory leak. Call release_firmware() directly in each error path before jumping to cleanup label. Signed-off-by: Samasth Norway Ananda Reviewed-by: Dan Carpenter --- drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c b/drivers/st= aging/rtl8723bs/hal/rtl8723b_hal_init.c index 57c83f332e74..56ceedd5a26a 100644 --- a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c @@ -346,12 +346,14 @@ s32 rtl8723b_FirmwareDownload(struct adapter *padapte= r, bool bUsedWoWLANFw) =20 if (fw->size > FW_8723B_SIZE) { rtStatus =3D _FAIL; + release_firmware(fw); goto exit; } =20 pFirmware->fw_buffer_sz =3D kmemdup(fw->data, fw->size, GFP_KERNEL); if (!pFirmware->fw_buffer_sz) { rtStatus =3D _FAIL; + release_firmware(fw); goto exit; } =20 --=20 2.50.1 From nobody Sun Feb 8 22:18:37 2026 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C232930BB83; Thu, 8 Jan 2026 18:16:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.165.32 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767896183; cv=none; b=QpKvz+uOG+RjfMR/jEiqI8jj+K01rquNsfOkU2Y8f4frixuFhSZCQzWLxKPakux9Hw0SmWZf9gz+vC0oQO9R26T+PB2Ljk9GrenBtbj+JVfXWNDgvciH+YxpSU6lfbnrUUXOKKuXx3RsNW1PHwVsI4CBOM1oNvzux2BO9dXNTAI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767896183; c=relaxed/simple; bh=EW56otuXZvN4lMmy44nU/ZLsNRlFl9KPRI9408Hthac=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=sc7K1OnVZIVn8TGIvmAg3jlHRMenciebrm7A9bT1SJMoxY1Igg2DBGqDmeNFxKwFFh93QK4NVeRXROJCkJR0VyjfQNQB/06DsXo5bJEyMqX9dW7ZfO16hkvXBTYTBe2jhbIIgGko92i1lLd+Hpf21ndkr1e9WYug14T/B7AQ7NM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com; spf=pass smtp.mailfrom=oracle.com; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b=NkyciEL1; arc=none smtp.client-ip=205.220.165.32 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oracle.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="NkyciEL1" Received: from pps.filterd (m0246627.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 608HaCNB804604; Thu, 8 Jan 2026 18:16:14 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=corp-2025-04-25; bh=dVOFp N1ANTfLITaCz7gEuTC/kjtkKEPRAWzo0EVCm1Y=; b=NkyciEL1NesawEqWY6aTF 6dGAWH0mlPitJTa9d/z8P2pYISBNBdT/s2GFXDfhEgJizTf3D3KmHr3sEjGA1Sjq MxX2TVs31KBS4r4qneC9ivybhm9+gjG39z26MPkFTcf8Qqxwmkj80CVT9JbeTaao SeKyWoP2uNVFhPdYc31+x8TheBcR9Ntfxrb+Wfg7cOwUyB4NVGZ74WczBCbI0KOL 5iRF25/pcFpO48TYH9PChYlhP0mqcvw9Fp8Sa4rs+dU3HZN9C14c4CBdQ4RghVlz YsFdCK5tfB76oSRqc+8HQHsNmt7G6O3KXR9kxT2ng14flOtVCzwacml463hBhTYy A== Received: from phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta01.appoci.oracle.com [138.1.114.2]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 4bjh4hr25e-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 08 Jan 2026 18:16:14 +0000 (GMT) Received: from pps.filterd (phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 608GYJ0e019956; Thu, 8 Jan 2026 18:16:13 GMT Received: from ca-dev112.us.oracle.com (ca-dev112.us.oracle.com [10.129.136.47]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTP id 4besjb58a9-3; Thu, 08 Jan 2026 18:16:13 +0000 From: Samasth Norway Ananda To: dan.carpenter@linaro.org, gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 2/3] staging: rtl8723bs: fix memory leak in rtw_cfg80211_inform_bss() Date: Thu, 8 Jan 2026 10:16:10 -0800 Message-ID: <20260108181612.2340796-3-samasth.norway.ananda@oracle.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260108181612.2340796-1-samasth.norway.ananda@oracle.com> References: <20260108181612.2340796-1-samasth.norway.ananda@oracle.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-08_03,2026-01-08_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 suspectscore=0 spamscore=0 mlxlogscore=999 phishscore=0 malwarescore=0 adultscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2512120000 definitions=main-2601080135 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTA4MDEzNSBTYWx0ZWRfX43sZFD46YDJZ KsU6+FNA3qd5HpUmj6Kd5UNfJ/6LBk/9QyT2TbL9llt25vE2XG103znI27hNjFGf5UWJ02foVDk 6ZCOyQbEvA7ebrENatuSf3pwiSj8Y2uPM5TMFiDmAEzp6gVYyQFT7M/3cuOu97VjIDK9G5r9eBf 2KG03GSMUyvsSL1MI89ZhbwWl6kMHxjTsv43SmydU1OysoJ8AJ68et0JFU3yG/oW+4l8nOXfvhp GIPs4ZYhLIGXT0+y49i0WjjTVqSK1mGbprS8IXIPt/PU2O2EKRtP6PVs96i5/5Md8/QvQmYJDhc SFiyf3Gt8Zo8O6dMXguRMvdUOhAqY5lVFsrTtnEc8dtRrgwUUCCi+SeqnWwvp3+XLQpgIzvt1Qw WWGIo+r1SSQk8/J/huZ1vKLmP1G0kzhRA75MOZzDiKS2jv6utLomIC5dahjkm61zFbY4I2VPkIr xsVh149oh0Wx6hjrtpg== X-Proofpoint-ORIG-GUID: 0THlW4sSNXnLzm57eshixu-NxZfaunx3 X-Proofpoint-GUID: 0THlW4sSNXnLzm57eshixu-NxZfaunx3 X-Authority-Analysis: v=2.4 cv=T+CBjvKQ c=1 sm=1 tr=0 ts=695ff46e cx=c_pps a=XiAAW1AwiKB2Y8Wsi+sD2Q==:117 a=XiAAW1AwiKB2Y8Wsi+sD2Q==:17 a=vUbySO9Y5rIA:10 a=VkNPw1HP01LnGYTKEx00:22 a=yPCof4ZbAAAA:8 a=lX7pHSL-l9_-PgaVgB0A:9 Content-Type: text/plain; charset="utf-8" After successfully allocating buf with kzalloc(), if cfg80211_inform_bss_frame() returns NULL, the code jumps to the exit label without freeing buf, causing a memory leak. Add kfree(buf) before the goto to properly free the buffer in this error case. Signed-off-by: Samasth Norway Ananda Reviewed-by: Dan Carpenter --- drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c b/drivers/st= aging/rtl8723bs/os_dep/ioctl_cfg80211.c index 60edeae1cffe..d80e23cfdf8d 100644 --- a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c +++ b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c @@ -314,8 +314,10 @@ struct cfg80211_bss *rtw_cfg80211_inform_bss(struct ad= apter *padapter, struct wl bss =3D cfg80211_inform_bss_frame(wiphy, notify_channel, (struct ieee8021= 1_mgmt *)buf, len, notify_signal, GFP_ATOMIC); =20 - if (unlikely(!bss)) + if (unlikely(!bss)) { + kfree(buf); goto exit; + } =20 cfg80211_put_bss(wiphy, bss); kfree(buf); --=20 2.50.1 From nobody Sun Feb 8 22:18:37 2026 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 22D783090F5; Thu, 8 Jan 2026 18:16:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.177.32 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767896182; cv=none; b=ln4Kq7/J1X/DoNsv9pNMp/q7FGhZng9fy8Hv5LHX7qIQY6bn84dJ7sGxBMmVcgmC1Ja3BF3kuzUPFqCruNVO9QeLlJ0fFS9Cl3bBaktFBuC5YJWxnNQFpV38QlHKX3fAzTbfk2NIDn/Ej0rwSdLdLnv7df1kJtdLpJiAhY46W6M= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767896182; c=relaxed/simple; bh=yYAlt6Wec9Vi1J7KODs8VqCjNE+ngcL+M0x2Ukmdyu0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=EqrEQ+XYZitP+N4qQJ4BRzTsDypfZC/gsqeQICeAmuz2ZSGZeSwWI6uccr43bJmIOFE+UpsZZtWZPtj3a4OgJ/GBGfBSwgRuyMHiQxnS2mPLv7YIZvRiskDYm1LCSPq2uTWXb/QEyuuxgJjEyMYPBBEFfkT9x3VDc/q5u6AY3hw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com; spf=pass smtp.mailfrom=oracle.com; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b=ZaPCg7As; arc=none smtp.client-ip=205.220.177.32 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oracle.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="ZaPCg7As" Received: from pps.filterd (m0246631.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 608FnVW2425571; Thu, 8 Jan 2026 18:16:15 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=corp-2025-04-25; bh=wPu8M xHBDyWWNqLG9PORAsEoDBF9GHetvqkS05GaYXY=; b=ZaPCg7AskxsvyzBgld3Oa THDBePO0t9msPqF62rA9NNs4vXtoeR9/Qu4vGUln461I1Mv8uLW+LWBRqUDT34rc 4Hh5oKj4DO/i9e+qRKC5Fxznk0DyY0GLHoumB+Wlrdht3cNIS0Xuq5FTYLubS8t/ WaKq5qKN1XeUKyOEe4WNkCwgqhiWhottvKE5XlEFqa3NSPK2G3G5EzipbQmiFtZQ K/N+sjrJDhVh4G51AVi3BvWIcs5SSgtKfHRY97P06NBAoVt0BJP8tq5foToq5VNo FG1jyaC7WIvBfzzHFRnjPsBMJ8U+gApJA+d5Yjckpr2mh9ZRbsHJq38YggYhStUy g== Received: from phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta01.appoci.oracle.com [138.1.114.2]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 4bjfjd87mq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 08 Jan 2026 18:16:15 +0000 (GMT) Received: from pps.filterd (phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 608GYJ0f019956; Thu, 8 Jan 2026 18:16:14 GMT Received: from ca-dev112.us.oracle.com (ca-dev112.us.oracle.com [10.129.136.47]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTP id 4besjb58a9-4; Thu, 08 Jan 2026 18:16:14 +0000 From: Samasth Norway Ananda To: dan.carpenter@linaro.org, gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 3/3] staging: rtl8723bs: add IS_ERR() check for kthread_run() Date: Thu, 8 Jan 2026 10:16:11 -0800 Message-ID: <20260108181612.2340796-4-samasth.norway.ananda@oracle.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260108181612.2340796-1-samasth.norway.ananda@oracle.com> References: <20260108181612.2340796-1-samasth.norway.ananda@oracle.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-08_03,2026-01-08_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 suspectscore=0 spamscore=0 mlxlogscore=999 phishscore=0 malwarescore=0 adultscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2512120000 definitions=main-2601080135 X-Proofpoint-ORIG-GUID: -Lb4BfXSEnrHVBX5O5hijPTs0BOFsghE X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTA4MDEzNSBTYWx0ZWRfX731fN4vAZJZW 5Q9kgkJ+WLPctbAUKoInXQUX3ymfDV0rYX65yyH2UDJWWL4uzLYmClYOnBwJXF+/x1pqHvaKOLh Zy2oDgy3ABdX5drFxolnygzwF19fbm0JlQ5IOimd5pf/cZXM07av2sGRb22NhU9EPtUdrZB6k6D C8C4EUnXEb0kds/xVJIYhD/rQe4E2hSYa/RfeWWD6vq7zbbByHHaSqE9T2qH2BR2qsOoagQSdQG CQhwOqf5+KEW3B3AoR7noFf5MKqjbFQr6clz9fU35R7yCMe4N7lru+/wj9aYjfthaq+VfglOeiA XX68fsy4bwRUAPH3g3HOZV7OZyGzJ4qZdFWmv2sDceFKxtJ2XKbBc8CJqN3zMgEU8z/F/M/ujuo Oc5AtFmC3z7H/vsQPC0C6dkKayqhWQv/eIlHrjzh0lZ7hADaH4xTVHfL53kb7dv3P+d2oA05jT4 m3m3IbjL4/ApDQrv50g== X-Authority-Analysis: v=2.4 cv=MOJtWcZl c=1 sm=1 tr=0 ts=695ff46f cx=c_pps a=XiAAW1AwiKB2Y8Wsi+sD2Q==:117 a=XiAAW1AwiKB2Y8Wsi+sD2Q==:17 a=vUbySO9Y5rIA:10 a=VkNPw1HP01LnGYTKEx00:22 a=yPCof4ZbAAAA:8 a=imfE7q7joczNGZVoPxsA:9 X-Proofpoint-GUID: -Lb4BfXSEnrHVBX5O5hijPTs0BOFsghE Content-Type: text/plain; charset="utf-8" kthread_run() returns an ERR_PTR on failure, not NULL. Without this check, rtl8723b_stop_thread() would later check "if (xmitpriv->SdioXmitThread)" which evaluates to true for error pointers, potentially causing issues when trying to complete or wait on an invalid thread. Set the pointer to NULL on failure to prevent later code from attempting to use an invalid thread pointer. Signed-off-by: Samasth Norway Ananda --- drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c b/drivers/st= aging/rtl8723bs/hal/rtl8723b_hal_init.c index 56ceedd5a26a..27d490204fcc 100644 --- a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c @@ -2922,6 +2922,8 @@ void rtl8723b_start_thread(struct adapter *padapter) struct xmit_priv *xmitpriv =3D &padapter->xmitpriv; =20 xmitpriv->SdioXmitThread =3D kthread_run(rtl8723bs_xmit_thread, padapter,= "RTWHALXT"); + if (IS_ERR(xmitpriv->SdioXmitThread)) + xmitpriv->SdioXmitThread =3D NULL } =20 void rtl8723b_stop_thread(struct adapter *padapter) --=20 2.50.1