From: Ionut Nechita <ionut_n2001@yahoo.com>

This series adds support for the Fn+F5 fan control key on Asus ROG
laptops and addresses spurious HID vendor codes that cause kernel log
spam on these devices.

The series introduces:
1. Code cleanup by replacing a magic number with an existing constant
2. Filtering of spurious HID vendor usage codes on ROG laptops
3. Infrastructure for HID-to-WMI communication
4. Fn+F5 fan control key handler with userspace fallback support

The Fn+F5 key handler attempts to forward events to asus-wmi when
available. If asus-wmi is unavailable or fails, the event is passed
to userspace via evdev, allowing userspace fan control implementations.

Tested on Asus ROG series laptops.

Changes in v5:
- Removed IS_REACHABLE(CONFIG_ASUS_WMI) guards from patch 3 as
  asus_wmi_evaluate_method() already returns -ENODEV when asus-wmi
  is not available, and the warning is helpful for users (Mario's feedback)
- Updated commit message for patch 3 to reflect the removal of
  conditional compilation guards

Changes in v4:
- Added Reviewed-by tag from Mario Limonciello (AMD) to all patches

Changes in v3:
- Added IS_REACHABLE(CONFIG_ASUS_WMI) conditional compilation guards
  to prevent build failures when asus-wmi is not compiled (patch 3)
- Modified Fn+F5 handler to pass events to userspace when asus-wmi is
  unavailable or fails, enabling userspace fan control (patch 4)
- Updated comments and commit message to reflect that spurious codes
  affect all ROG laptops, not just G14/G15, and occur during normal
  operation, not just on keypresses (patch 2)
- Simplified commit message for WMI infrastructure patch (patch 3)
- Added Reviewed-by tag from Denis Benato
- Removed Change-Id tags

Changes in v2:
- Split the original patch into a logical series of 4 patches
- Improved code organization and commit messages

Ionut Nechita (4):
  HID: asus: Replace magic number with HID_UP_ASUSVENDOR constant
  HID: asus: Filter spurious HID vendor codes on ROG laptops
  HID: asus: Add WMI communication infrastructure
  HID: asus: Implement Fn+F5 fan control key handler

 drivers/hid/hid-asus.c                     | 73 +++++++++++++++++++++-
 include/linux/platform_data/x86/asus-wmi.h |  1 +
 2 files changed, 73 insertions(+), 1 deletion(-)

--
2.52.0

Hello,

I hope this email finds you well. I wanted to follow up on my v5 patch
series for Fn+F5 fan control key support on Asus ROG laptops, which I
submitted on January 7th.

The series has received Reviewed-by tags from both Mario Limonciello
(AMD) and Denis Benato, and I've addressed all the feedback from
previous versions, including the removal of IS_REACHABLE guards as
suggested by Mario.

I wanted to check if there are any additional changes or improvements
you'd like me to make before this series can be considered for merging
into mainline. I'm happy to address any further feedback.

Also, if you could let me know what the next steps are in the process,
I would appreciate it.

Thank you for your time and guidance.

Best regards,
Ionut

On Thu, 8 Jan 2026, Ionut Nechita (Sunlight Linux) wrote:

> I hope this email finds you well. I wanted to follow up on my v5 patch
> series for Fn+F5 fan control key support on Asus ROG laptops, which I
> submitted on January 7th.
> 
> The series has received Reviewed-by tags from both Mario Limonciello
> (AMD) and Denis Benato, and I've addressed all the feedback from
> previous versions, including the removal of IS_REACHABLE guards as
> suggested by Mario.
> 
> I wanted to check if there are any additional changes or improvements
> you'd like me to make before this series can be considered for merging
> into mainline. I'm happy to address any further feedback.
> 
> Also, if you could let me know what the next steps are in the process,
> I would appreciate it.

It took me some time to go through the iterations, feedback and review the 
patch, now applied to hid.git#for-6.20/asus, thanks.

-- 
Jiri Kosina
SUSE Labs