From nobody Sun Feb 8 21:46:33 2026 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6303F38B99A for ; Wed, 7 Jan 2026 15:42:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767800562; cv=none; b=TSqR26PIkFmjKy51nbUA2oC9AwbIv2EhN/HWZ21paIoL3qA+n7qxvrWLcGcnJiPXiC3XwHHhB/AnV8yyYDLaz6/+UPnAKHTYb+smN5wz2ZD2UqEqAJCWc/8LPXYsaT+YSfsiK8u1fh2x1Ih3Z2h89otePQymwr2so3R/Md0DS5g= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767800562; c=relaxed/simple; bh=nS6pktisk1hD3TU7J6j1xKmwIjoYqBmyrao11F/mGbc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=GkP0fEvtGCX78asGMC7UUqhACRu90ZwR0b1d+FRpKRUcHQqvC/fG1+a2sWNueKU2xQdaomIxjgzjQFtdEU1JDkstYmcDkXP9gHlmmwF08HH+qAg3RsRqOHNSls0zzpQYXTIyp8ESSGO4ZjL6giNMM8ooXP9395ycMF+YSZ8GUnY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=mhaW/JjJ; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mhaW/JjJ" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-47d3ffb0f44so14771135e9.3 for ; Wed, 07 Jan 2026 07:42:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1767800560; x=1768405360; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Q1iAxTFSQoTWeJxaL1NW0AepzE1fhDVEkVj9Fn+hGno=; b=mhaW/JjJEgncpb2EtHM6aUrI1FsbJDSFMB6o2JpLx8PRr1PdmgSMMEwY4K4K7tpnmE RZ+4YGdZjXP1PfnZSGRXfGIICRLF8gXsKcNACWAxwa6tO6vOL5ya32QYvbte3CJVGd4l IBdJoUQ9HJyo8WqPiGXZax58XleGnfE2/o80CVaWK2rbZud+s52QjY2miM6r+s8q3wIP AZres6aL+i81e9mu929JmZVl7X097EGc78kreDY4UhcUksaxYxF78ZDw93UXoQ5GNNn2 uL/hAmWKEsqXL2WkdL3BgT1/ZsIT4mgUlWn6wSahqgIXvxCk1LM9nblOF1MO+0MN5Lqk hqGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767800560; x=1768405360; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Q1iAxTFSQoTWeJxaL1NW0AepzE1fhDVEkVj9Fn+hGno=; b=TF+FiaeZLri58RwKFk6eaNAO9OsRYVAuK762ZhYY2cPzrMmCBx4IKqE1e0FmaV7FGV 4YoK0womJYLJG+1t/44jA434WmBV/G/X3csSxYJX+dZnqGM833xAQr7oRLrfmdPYyq+Y E+wDnMyVrmrDLvAahCaZ1NXg0wa6ttio0MUkClbF0FOCRk06sgRivCK8CRa7A6252LjM UbTI5rD9Iq98ZUsYJPfvHh5rk3WECIaoEo4LVko8wDB2Fe3usrZLg3ZnyO1/zNIpY0/F SHsUNjD93c/JZaL+Td8TlLSIsENhc9ja8UDiP1qOpKkamqVjuWc7JISrA2Z2EpPGWVwg OhhQ== X-Forwarded-Encrypted: i=1; AJvYcCVGOygKFE32cRT7Z1Ui+Ec6MuCtk/1gvf32aZngwqQeGaxVfFg1jOwtHJ7YofIjQ2n8ORFZH51nEP1C5Bk=@vger.kernel.org X-Gm-Message-State: AOJu0YwEiXbcYMKpLWehpY9Z88UhqvxUAFyhOwzxNScM9GyKfboYjHwo 4gkaAxkjNBz5d1P3B3RFzW33XniIwqS72vmTH/HZ6aQZM6inpW5IyeVA X-Gm-Gg: AY/fxX6r2PGZNmr9LGb6dhMODQUiCZGjhFINHsAkOazRCJPjRuX48QytPIZhiLu54uZ kBFCJitMUP4U81lkYwtf+SG8fEEaKbV2dGnsGcD3Z6QqYgIp4btQIqn4aU1hdbY6bJP70JWhIq4 EBNls2V9H1PQkz50zijuxPxtvyBxahpeJ5RmRnqEeE3aFVrCO5AdSmCQnvTJdMs1GMaO/rJ0KCy Wt9QHUYmrj6lacgFnIHCwWFddJYN2fmwrKOKKnoapGTDjXXfMbRVEGj4n3cB++NYlIeKIpw+Tjg +P68Ec/r2yhPAF5DzYCJc4aV2IbXd74Er7ACzlLgqjLHdmjyrBRSkMwo6K6bgWCF9SCIGVVEHe+ Hb3Z6KAWvfrYv1+Sdd2PX8C0THV4GqVLU62Q9EmwuC11udi80CCr+Vp6M+wlrGhWK1gWaV/Wglb P8jHIPdtSrD47nXsdMkGZWeV8Xmj2Mg+Suxgls62A= X-Google-Smtp-Source: AGHT+IHh42IGnipWJP03g++e9iDVeFqh1L0/fP1w53Z7LZVenjO5qsb70T0wsEsiWCzhWLqMbCV5Qw== X-Received: by 2002:a05:600c:3556:b0:477:6374:6347 with SMTP id 5b1f17b1804b1-47d84b3bb18mr35807725e9.22.1767800559530; Wed, 07 Jan 2026 07:42:39 -0800 (PST) Received: from ionutnechita-arz2022.local ([2a02:2f0e:ca09:7000:33fc:5cce:3767:6b22]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-432bd5ee243sm10897704f8f.31.2026.01.07.07.42.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Jan 2026 07:42:38 -0800 (PST) From: "Ionut Nechita (Sunlight Linux)" To: benato.denis96@gmail.com, jikos@kernel.org, bentiss@kernel.org Cc: ionut_n2001@yahoo.com, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, sunlightlinux@gmail.com, superm1@kernel.org Subject: [PATCH v5 1/4] HID: asus: Replace magic number with HID_UP_ASUSVENDOR constant Date: Wed, 7 Jan 2026 17:42:18 +0200 Message-ID: <20260107154219.164514-4-sunlightlinux@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260107154219.164514-2-sunlightlinux@gmail.com> References: <20260107154219.164514-2-sunlightlinux@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Ionut Nechita Use the existing HID_UP_ASUSVENDOR constant instead of the magic number 0xff310000 for better code clarity and maintainability. Reviewed-by: Denis Benato Reviewed-by: Mario Limonciello (AMD) Signed-off-by: Ionut Nechita --- drivers/hid/hid-asus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hid/hid-asus.c b/drivers/hid/hid-asus.c index 472bca54642b9..eb14b9d13823b 100644 --- a/drivers/hid/hid-asus.c +++ b/drivers/hid/hid-asus.c @@ -317,7 +317,7 @@ static int asus_e1239t_event(struct asus_drvdata *drvda= t, u8 *data, int size) static int asus_event(struct hid_device *hdev, struct hid_field *field, struct hid_usage *usage, __s32 value) { - if ((usage->hid & HID_USAGE_PAGE) =3D=3D 0xff310000 && + if ((usage->hid & HID_USAGE_PAGE) =3D=3D HID_UP_ASUSVENDOR && (usage->hid & HID_USAGE) !=3D 0x00 && (usage->hid & HID_USAGE) !=3D 0xff && !usage->type) { hid_warn(hdev, "Unmapped Asus vendor usagepage code 0x%02x\n", --=20 2.52.0 From nobody Sun Feb 8 21:46:33 2026 Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9C92338B997 for ; Wed, 7 Jan 2026 15:42:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767800571; cv=none; b=OaCbECiPYI9ZcfnqKI2ClFv5f9kAr0ul3hXHaOQXxcdRv//tLmD0yxMXdb1Yr6WDBX8tzhVxiEC2Ug1nolww1Kc1NT71ktcL2o7q0jDSfQYqC0pXcXV1omZ0qqZa6x0U6zziXFMrux1kdeLNyFbny9LkNRbHmZoPIt7joD4a/dk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767800571; c=relaxed/simple; bh=QA1UL/S5jJ1ZUknddi/FOJm1WzobzTiZU88KEGULpt8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=qd5Y/qiq3EkFB3U6ZjWrBw3LGvhqhlFAlGPoCGeaGAz0flH79rsaCnbQuhYfEfavRukwVPsIQyOS06nQK7zv0V22rG+rS1aNO5kOVqC79BXDUSs0dEKms01wk3vhr7n0vsePv7vPhVHiIx4jVhyIDj9H2EiP0OpB1esvarj33zI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=TR6BiNHZ; arc=none smtp.client-ip=209.85.221.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TR6BiNHZ" Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-42fb4eeb482so1220797f8f.0 for ; Wed, 07 Jan 2026 07:42:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1767800568; x=1768405368; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=aUF3d7YHbibnTwOkio7fbPwxM6xch+CyKh0nAQoNa8g=; b=TR6BiNHZwW+dmfSFk0wXjWwawH/qTHxl6LoHOKFjo3jDrlx4VW9eXBDgAIxjfrrQRj TDQZUdn5CnVIpixFt0rC7mc2WbK3tjryfXRFsoHRWZXJHcPf1DihiVkuGhwyqGnIYzr0 A80JjwRgguvWpWaqEmzpVgdgLMxlNTkR+4ghR00IhniNxvs8tRJRPdsPtvsPnHiKaOK4 V7UFBtYPrtpXXG212NhEA6Vl6v7ikSKj71TsG7OJjfpa3h89lY0XwfuGFTGi8PEN/hbe j9zIYtBt2GSFeSE+7YIMhnhrpZ8HP2DTg/1oDRUKldaIJIQzWKOo8UQw6+pPYpJBo0dX ck3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767800568; x=1768405368; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=aUF3d7YHbibnTwOkio7fbPwxM6xch+CyKh0nAQoNa8g=; b=AOGS12nhbC9CxuD9qumGaJdefwfPDXNZw3yVhqobrLJxiCrcNi41h4ZOHjD3nxrKpq RP6C2ejQ6j5Sjj82Z7eOSxhUOabNgT9qtJY514hSPsZkzaMqOdW/FU41P5TE2Ly+ik6x 9EvqpSGEir4rLcPhWS70rrOgtZZ/YEf3KV6FzI17N+8roSUdvERbUIGi01oJFAFYv/JH 8/Ci/VihLUsFiyYB8vSdkkDh/7vP7j8f42L69t96ISyvk+IcCHXStEPh8j6eHB/MXzJI G+8lEeojom1lzVUXD8D+Fz3Q2W6pbHB8N0YEY1L1S0dCZP8wgrMwh8f7TelkXf4wz5Tt ujxQ== X-Forwarded-Encrypted: i=1; AJvYcCWKXSrpHDrx0Q0tS/F7CbjnScRdTRSPg/QNJtoX4NTBWIHPtCF4PN34IiyccJEKem07aXaCKXCBTdkq9nA=@vger.kernel.org X-Gm-Message-State: AOJu0YydsFp4wwuPRinVkPu4ZZ3z52q3fcPAMh57m2PEkl8CuJUGzexv dyN6ZYF40MR8C/nG72D7DHa1UZei93nBbhUIDQb83OAQTJPZIzK4c1pk X-Gm-Gg: AY/fxX4hNhOVxt/ODjmkLGc7flcCeZeka6cnQ7FtKIhMRErmpjZ1f0gZe3Rg9o590X+ Ttmd7Fv+WsnFgexobCk8rtALeX4PnL6yzFIDJi40p1xAM7KTjbJYZGtT+kq4U8KuYTQxs2nuz7+ ONK+xpkIgiUHg16Z5kcio10L3Wb8klVINmpbGsySKrXPjL5LIU2w8vSoa8gazY5OnrKCEPxQSno PU8D3Sb76l16QLZZDwmE0skdzBlApIg6eNX2sSCFuynK6EKiwQ6MXHkMh7f8NYlCIEfMxESsQsP OnPrLDDX7NDdQ5DS+MSRXzGZZDa3Y0iwq+q0n/IxxEeKhlYPmcQugI4YNT06lAZfT1uIl+rl8MV YiWFSYCqjGA7xL4EROWyQ7/qlTzcW64GjlJj/Frb0UrgeYHGyvEldADITC7YT+MRuL9DDPMBBKt LDOyJxre+MNdRxO5U23ElNE4+Jq/u35cGMkFRz/lE= X-Google-Smtp-Source: AGHT+IFgjsof+vom+8Br6bX47ERmFdf62CBu0rmdTxo0GwiSnw/e03sCNN3LYXHNwfIDpxQZkCLs7g== X-Received: by 2002:a5d:64c7:0:b0:431:5ca:c1b0 with SMTP id ffacd0b85a97d-432c3628fd3mr3666484f8f.4.1767800567817; Wed, 07 Jan 2026 07:42:47 -0800 (PST) Received: from ionutnechita-arz2022.local ([2a02:2f0e:ca09:7000:33fc:5cce:3767:6b22]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-432bd5ee243sm10897704f8f.31.2026.01.07.07.42.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Jan 2026 07:42:46 -0800 (PST) From: "Ionut Nechita (Sunlight Linux)" To: benato.denis96@gmail.com, jikos@kernel.org, bentiss@kernel.org Cc: ionut_n2001@yahoo.com, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, sunlightlinux@gmail.com, superm1@kernel.org Subject: [PATCH v5 2/4] HID: asus: Filter spurious HID vendor codes on ROG laptops Date: Wed, 7 Jan 2026 17:42:20 +0200 Message-ID: <20260107154219.164514-6-sunlightlinux@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260107154219.164514-2-sunlightlinux@gmail.com> References: <20260107154219.164514-2-sunlightlinux@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Ionut Nechita On Asus ROG laptops, several HID vendor usage codes (0xea, 0xec, 0x02, 0x8a, 0x9e) are sent during normal operation without a clear purpose, generating unwanted "Unmapped Asus vendor usagepage code" warnings in dmesg. Add definitions for these codes and filter them out in asus_raw_event() to prevent kernel log spam. Tested on Asus ROG series laptops. Reviewed-by: Denis Benato Reviewed-by: Mario Limonciello (AMD) Signed-off-by: Ionut Nechita --- drivers/hid/hid-asus.c | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) diff --git a/drivers/hid/hid-asus.c b/drivers/hid/hid-asus.c index eb14b9d13823b..15c24d5812763 100644 --- a/drivers/hid/hid-asus.c +++ b/drivers/hid/hid-asus.c @@ -57,6 +57,13 @@ MODULE_DESCRIPTION("Asus HID Keyboard and TouchPad"); #define ROG_ALLY_X_MIN_MCU 313 #define ROG_ALLY_MIN_MCU 319 =20 +/* Spurious HID codes sent by QUIRK_ROG_NKEY_KEYBOARD devices */ +#define ASUS_SPURIOUS_CODE_0XEA 0xea +#define ASUS_SPURIOUS_CODE_0XEC 0xec +#define ASUS_SPURIOUS_CODE_0X02 0x02 +#define ASUS_SPURIOUS_CODE_0X8A 0x8a +#define ASUS_SPURIOUS_CODE_0X9E 0x9e + #define SUPPORT_KBD_BACKLIGHT BIT(0) =20 #define MAX_TOUCH_MAJOR 8 @@ -348,6 +355,21 @@ static int asus_raw_event(struct hid_device *hdev, if (report->id =3D=3D FEATURE_KBD_LED_REPORT_ID1 || report->id =3D=3D FEA= TURE_KBD_LED_REPORT_ID2) return -1; if (drvdata->quirks & QUIRK_ROG_NKEY_KEYBOARD) { + /* + * ASUS ROG laptops send these codes during normal operation + * with no discernable reason. Filter them out to avoid + * unmapped warning messages. + */ + if (report->id =3D=3D FEATURE_KBD_REPORT_ID) { + if (data[1] =3D=3D ASUS_SPURIOUS_CODE_0XEA || + data[1] =3D=3D ASUS_SPURIOUS_CODE_0XEC || + data[1] =3D=3D ASUS_SPURIOUS_CODE_0X02 || + data[1] =3D=3D ASUS_SPURIOUS_CODE_0X8A || + data[1] =3D=3D ASUS_SPURIOUS_CODE_0X9E) { + return -1; + } + } + /* * G713 and G733 send these codes on some keypresses, depending on * the key pressed it can trigger a shutdown event if not caught. --=20 2.52.0 From nobody Sun Feb 8 21:46:33 2026 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 339D838B99A for ; Wed, 7 Jan 2026 15:42:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767800578; cv=none; b=h7nVRvZv/qqbE/Vkh9D5tGS8ei7ZyOz9jf5qpunolbFNNN4lAz5Req2oXG634mdJuS87p9KUWIgHXfb7DWMLs8JyRV5k98Rd3t9kcvz8YQnsTGV1dvKPjU/jAQyammQB/+cz3Y0wxpfgKOuUV4NGcFd/ChjXJXAarKUZmo/grl0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767800578; c=relaxed/simple; bh=m2LVWd9zY2sr7dLTXt464SmzH9m5DeaA++ZT17Hi3XY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=VujpK0ak/LbquANT3GfBR7plvXhW154N3GzI7ei7OnYAregcBIyaSJgsDcIcD05d+mshJtOWXE+ByknsDMML5o2SCJjt4rJwaHsr/6DmY/fnuIIRm0Mbm+5gvYx3M2G4vpGBnJ6e+ArRoGxUzwyAWGx9fmELtVTcNCJEBVpEo/U= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=QSe9CH09; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QSe9CH09" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-4775895d69cso11065135e9.0 for ; Wed, 07 Jan 2026 07:42:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1767800575; x=1768405375; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=B9oErkAI0lNt2KxcklIPRCVSSCk5fQX4NqQ5cL9hG/s=; b=QSe9CH09HdO9XYvC/2A68XV1CMvo1IQCKjRzguZ6Ildt2mwxIBZOkVZmqNpKfzIMh/ eT5Fl6JZ4PAi7yZIBVOSKr69GvLi+nU9bzedphil94csk9uFS8n7r3tktNHMqo/MxfhV p8AGTM1m+qw+WrK2GOyWypAZIrUesOGQ5kqKbhVxeY4ZIF0VB55Tb/KRTs9TgO0nv11T 70UA0z0RKnhaHKE48dlB2xFzKy4lQHFetwutcMOc6upmh7KdcRh2N2qfxA1wcTMLJ251 a/4EMyZrOgG2rjUkzlCrmF462COHuP5Ph9tKB2LQqNd3Ev4ylJ4kJp9Pn0qjv+ypRjyG Lweg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767800575; x=1768405375; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=B9oErkAI0lNt2KxcklIPRCVSSCk5fQX4NqQ5cL9hG/s=; b=dsrL5BmPHp7n6J+E+cYwYnQxLZ7junbpsXyPOzz+4M9qQg64KOHZRiQr3q1faUAK7t fh46L4dfPA5oUprZFj8l2wrqfa3GLUxoQRYrVUaVVCU0wdCDk1uFBdrolOJpKGtF/mLI FJcLj+XDjXAK9l3Rfm6vXpY6ricvsO3LUk4XAGwT2gVW71/AlQvSPfA2mFL1mg0OIiQs QuhLfjcF4qxU4NaM0mRmH+aRUskKdOUOJJWwgv7ReLmK16/e+/O7FGaUBrPnsB1b7MoQ tScZQeyPZbjEZIgW/Fd7qjwG9sjkGhVAYsP+ixnD7pCK8jM9Ljn+TvuYtNSxxj9BO3fL bL0A== X-Forwarded-Encrypted: i=1; AJvYcCWK6+98PEniFsVskGRwAuwmczNgeYhaHYGeIVo77UtQ7zfxwuxBP+zxp5FUDL2q5Ds9r+VQc8ugWRf9t8o=@vger.kernel.org X-Gm-Message-State: AOJu0Yy/nVSTGiE+Mkuv7DjreWXG9AT9DfW/rjgt+HK+8oLR7LaGm6Pf A0GR6blQQQyZiJY/4aqfslgtSTwTO8HznJfoBXTz9amMfahlyO6LUCIZ X-Gm-Gg: AY/fxX4YSbRzlrQWLq8qT1UBN3q4DatqtWlE2v5JDUtfZ9TJtkE6AHC9m9RILG63qM3 O/sFlwyHDhb2dKQr2CtFwcaodK7/3vCEKi4eTzX/7zhHQVBvHIbfuYccJjdxtOHyXA4UNrQfG47 kMLLXIoCt/TukWUSq4cQDYmW77Z1Dr+WCnUiRAe5iWGgoDmZ2HxbNHaif1c5Um+kukDa5PU240f pzr2NUAoi13OZR41jbMSdtRhW4X2RO2S1/wyXzebggMxYrZM0NUWT7Q03Cf4dfDIY9z1Pbep+FG RDsRqbdfG4JWOaFFq3uWDMwaHlkceJId1NDaBwVg0YeasowySp6mbxtqIFSJvbzDDJqlhmL7bNG cdaNKKDLFOiYl8pWZ2OY1FCaO/tSDCmkD64jfELQOyO2g/iwBieTOlXRnezVOSJRJysSOivu2/s Fhpy0cxSd2m1KnAtOnnVHv95Puf//IimVtmhUA+nuuz+hOVDKBMA== X-Google-Smtp-Source: AGHT+IEk4YurJaQSGJH4R73CW4Txmfc19dzFpNkcy5aJloEEHwBnUBh9/Km94tklRW1e4lrcvR1y7Q== X-Received: by 2002:a05:6000:4287:b0:432:5c34:fb22 with SMTP id ffacd0b85a97d-432c377c54dmr3691324f8f.22.1767800575390; Wed, 07 Jan 2026 07:42:55 -0800 (PST) Received: from ionutnechita-arz2022.local ([2a02:2f0e:ca09:7000:33fc:5cce:3767:6b22]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-432bd5ee243sm10897704f8f.31.2026.01.07.07.42.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Jan 2026 07:42:54 -0800 (PST) From: "Ionut Nechita (Sunlight Linux)" To: benato.denis96@gmail.com, jikos@kernel.org, bentiss@kernel.org Cc: ionut_n2001@yahoo.com, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, sunlightlinux@gmail.com, superm1@kernel.org Subject: [PATCH v5 3/4] HID: asus: Add WMI communication infrastructure Date: Wed, 7 Jan 2026 17:42:22 +0200 Message-ID: <20260107154219.164514-8-sunlightlinux@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260107154219.164514-2-sunlightlinux@gmail.com> References: <20260107154219.164514-2-sunlightlinux@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Ionut Nechita Add infrastructure for the HID driver to communicate with the asus-wmi driver for handling special keys that require WMI communication. This includes: - Define ASUS_WMI_METHODID_NOTIF method ID in asus-wmi.h - Implement asus_wmi_send_event() function to send events to asus-wmi Reviewed-by: Denis Benato Reviewed-by: Mario Limonciello (AMD) Signed-off-by: Ionut Nechita --- drivers/hid/hid-asus.c | 24 ++++++++++++++++++++++ include/linux/platform_data/x86/asus-wmi.h | 1 + 2 files changed, 25 insertions(+) diff --git a/drivers/hid/hid-asus.c b/drivers/hid/hid-asus.c index 15c24d5812763..6fcd3213857cf 100644 --- a/drivers/hid/hid-asus.c +++ b/drivers/hid/hid-asus.c @@ -23,6 +23,7 @@ /* */ =20 +#include #include #include #include @@ -321,6 +322,29 @@ static int asus_e1239t_event(struct asus_drvdata *drvd= at, u8 *data, int size) return 0; } =20 +/* + * Send events to asus-wmi driver for handling special keys + */ +static int asus_wmi_send_event(struct asus_drvdata *drvdata, u8 code) +{ + int err; + u32 retval; + + err =3D asus_wmi_evaluate_method(ASUS_WMI_METHODID_DEVS, + ASUS_WMI_METHODID_NOTIF, code, &retval); + if (err) { + pr_warn("Failed to notify asus-wmi: %d\n", err); + return err; + } + + if (retval !=3D 0) { + pr_warn("Failed to notify asus-wmi (retval): 0x%x\n", retval); + return -EIO; + } + + return 0; +} + static int asus_event(struct hid_device *hdev, struct hid_field *field, struct hid_usage *usage, __s32 value) { diff --git a/include/linux/platform_data/x86/asus-wmi.h b/include/linux/pla= tform_data/x86/asus-wmi.h index 419491d4abca1..516538b5a527e 100644 --- a/include/linux/platform_data/x86/asus-wmi.h +++ b/include/linux/platform_data/x86/asus-wmi.h @@ -29,6 +29,7 @@ #define ASUS_WMI_METHODID_KBFT 0x5446424B /* KeyBoard FilTer */ #define ASUS_WMI_METHODID_INIT 0x54494E49 /* INITialize */ #define ASUS_WMI_METHODID_HKEY 0x59454B48 /* Hot KEY ?? */ +#define ASUS_WMI_METHODID_NOTIF 0x00100021 /* Notify method */ =20 #define ASUS_WMI_UNSUPPORTED_METHOD 0xFFFFFFFE =20 --=20 2.52.0 From nobody Sun Feb 8 21:46:33 2026 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3CA0438B9B5 for ; Wed, 7 Jan 2026 15:43:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767800593; cv=none; b=BtAPlmUzHuDRhdyQJGPut+3UEfs9T9m4qdgWIkfeeKFyPXqe9VEDYSJOouyQFp7R+NKPWoXXQZD3lnmRIJ+tGdKzkj5TVz037DFQNYaOp4cjM0PvwDqdy3w/Yz+hkYJ8Cr2pJK5QSbMkRubCjtYXKlJYmT9vwNnWlcpPhirLfvU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767800593; c=relaxed/simple; bh=Ufj9J+ZlCwFGFrNBtdLhRA4Pm49DeqcyMm4VMAOYlm4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=oTtfDtrCkezFLjlcHJI8P7M5dpG1O8N3MeI4f23kLKn9MpAjbmjaadrOw+yC0RVe6cPzRjrmMGcj1csh2NyDvE/R+vP9aReIvR6OmPtCe2BrigXRZFV2F9GhXG9vi4ZA7mYn9zEUTNp8xcUl/N+p5d3NPcN/M/HzHaL8hhmP8jc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=RnPclQV+; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RnPclQV+" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-477619f8ae5so18165895e9.3 for ; Wed, 07 Jan 2026 07:43:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1767800589; x=1768405389; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=LWcjT0u5z34/kb7Qe+H5E0kwqGCVYd2l01+VUnZbj/8=; b=RnPclQV+q9GbTwR26TJyKkssnz52u5hEgZN7hqPkUYJKkJ3LKjZOVZcg0EV+FijjOY CcAEHrthtU+GgWWs/pjH9zTWxMnljv3gI5L2NdrNBox93p0g3NYkNsThC5zaJuyyir5+ Pl6AnUdPPLgh48r6KBqlNry4Bd8Dj7REODbNn62SJcIGhPSpa14KCJYGMt80UsvGaRRy ctN212puQxsnr+Xg/casU1OAHxXIH/vxr5PAuotFCI0jZa2BIoT/5cIbsuc0Gwxfj38Q 27OL6OAnweYekrioBOugJSC+HhuRYF7IrTQE1Mj5O+zzm5F72LfbcQsGQiPqMZ5BBmyW p32g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767800589; x=1768405389; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=LWcjT0u5z34/kb7Qe+H5E0kwqGCVYd2l01+VUnZbj/8=; b=YZv6lzC+vLruk5AyeYxEvbA1NFP2RgluXsBHd/lVXfD7q5LwBm2QyjZeAeaAhSVR6q 0rn1tXW/liiKXxfYvtXatcHItdTxK1nqAZYdm1c1PzegsgX/WdJkOCnVLpouWdOyWgRf S9/YfsI18Mgh7cLnQb8yzrEd2UZIkrLjLVUkq82xnDaqptWshwFz0HJmR7lk1UZRUHos ik35kh5RjA7ujqqjrXcGC6gtNrR5Fu1tLjtsVgHTLch/F7IAGlmV11JP6fHcjMsLiCOa 5tCMC2FtI2fctIDnpXFTPh364Bjf1xsbC5oUG+1vdUwwuXJsJ2HQoqx1S4IQ50Q09Xl3 bKhQ== X-Forwarded-Encrypted: i=1; AJvYcCWWJBLtHff5IY+cJuujzJRp10N+29VTDIzV/Rc43EKDtxmtfYNr1VuTalQEMO0canVSB/0Sq9pFTyRKcQ4=@vger.kernel.org X-Gm-Message-State: AOJu0YxDmk0pxGBFHppdO6DMObWidfAZdqoSRuOgtllfp2ODZGREZ2/8 fTRP5ld2NlKhfuxbWct3iXG/7gqdthMKrgi9C811od2EJyNphR5OZiuO X-Gm-Gg: AY/fxX6qKZuC82KWKaCADfi2ZlI/ux+CYHka/wVdYXUJIyhZKIINaVAD0awuPvyat80 laLElT8VcqHavmAORDUC0o/gaINVQsEUSOtJvdZb/8n7hbTR5pBHILS37elW2kgWBAMmXUR9dPN 5pPPRoTYh6jtTEji5HF1vf/FpMKp2LlZWcGeNjeCjsTW8DBCGYecApL2ZuOh0WsgRleaakDD4hi P/1lNSJJ5OMccd+jeukIJpsY4polFS5gaKJvO7c50rx70XCcNQU41x3MAqSo5NGpzxM+XP4heX+ YUyalK70KuPXgTADc01GQMoDvNrCW0EMqU6dqGAUi6uxHgtdyj4zkFBR6Q8I5zhNxyioFwMsW6i FRIUiIatGo0JwqMdiqlbQRHVcb9nEoSTTcqiPg5mEYQu6spVRxCstZ45+7KvV0PJvitVO6bPqqZ Gy2XEt/bQ5FrXLP0akbrJbvkr+dMdM+7Altdkodmk= X-Google-Smtp-Source: AGHT+IFpf2LzcsxARVLcwohJ3nsYKzlej0OLE5M0q63SVWJgq05KEyIXF6Z5wAEIb8+uglN38BG8iA== X-Received: by 2002:a5d:5f54:0:b0:431:c60:c5ed with SMTP id ffacd0b85a97d-432c36282admr3814141f8f.13.1767800589326; Wed, 07 Jan 2026 07:43:09 -0800 (PST) Received: from ionutnechita-arz2022.local ([2a02:2f0e:ca09:7000:33fc:5cce:3767:6b22]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-432bd5ee243sm10897704f8f.31.2026.01.07.07.43.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Jan 2026 07:43:08 -0800 (PST) From: "Ionut Nechita (Sunlight Linux)" To: benato.denis96@gmail.com, jikos@kernel.org, bentiss@kernel.org Cc: ionut_n2001@yahoo.com, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, sunlightlinux@gmail.com, superm1@kernel.org Subject: [PATCH v5 4/4] HID: asus: Implement Fn+F5 fan control key handler Date: Wed, 7 Jan 2026 17:42:24 +0200 Message-ID: <20260107154219.164514-10-sunlightlinux@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260107154219.164514-2-sunlightlinux@gmail.com> References: <20260107154219.164514-2-sunlightlinux@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Ionut Nechita On Asus ROG laptops, the Fn+F5 key (HID code 0xae) is used to cycle through fan modes. This key press needs to be forwarded to the asus-wmi driver to actually change the fan mode. Add ASUS_FAN_CTRL_KEY_CODE define and implement the handler in asus_raw_event() to send WMI events when this key is pressed. When asus-wmi successfully handles the event, it is blocked from reaching userspace. If asus-wmi is unavailable or fails, the event is passed to userspace via evdev, allowing userspace implementations of fan control. Tested on Asus ROG G14/G15 series laptops. Reviewed-by: Denis Benato Reviewed-by: Mario Limonciello (AMD) Signed-off-by: Ionut Nechita --- drivers/hid/hid-asus.c | 35 ++++++++++++++++++++++++++++++----- 1 file changed, 30 insertions(+), 5 deletions(-) diff --git a/drivers/hid/hid-asus.c b/drivers/hid/hid-asus.c index 6fcd3213857cf..06f32a39c0cf7 100644 --- a/drivers/hid/hid-asus.c +++ b/drivers/hid/hid-asus.c @@ -65,6 +65,9 @@ MODULE_DESCRIPTION("Asus HID Keyboard and TouchPad"); #define ASUS_SPURIOUS_CODE_0X8A 0x8a #define ASUS_SPURIOUS_CODE_0X9E 0x9e =20 +/* Special key codes */ +#define ASUS_FAN_CTRL_KEY_CODE 0xae + #define SUPPORT_KBD_BACKLIGHT BIT(0) =20 #define MAX_TOUCH_MAJOR 8 @@ -379,12 +382,34 @@ static int asus_raw_event(struct hid_device *hdev, if (report->id =3D=3D FEATURE_KBD_LED_REPORT_ID1 || report->id =3D=3D FEA= TURE_KBD_LED_REPORT_ID2) return -1; if (drvdata->quirks & QUIRK_ROG_NKEY_KEYBOARD) { - /* - * ASUS ROG laptops send these codes during normal operation - * with no discernable reason. Filter them out to avoid - * unmapped warning messages. - */ if (report->id =3D=3D FEATURE_KBD_REPORT_ID) { + /* + * Fn+F5 fan control key - try to send WMI event to toggle fan mode. + * If successful, block the event from reaching userspace. + * If asus-wmi is unavailable or the call fails, let the event + * pass to userspace so it can implement its own fan control. + */ + if (data[1] =3D=3D ASUS_FAN_CTRL_KEY_CODE) { + int ret =3D asus_wmi_send_event(drvdata, ASUS_FAN_CTRL_KEY_CODE); + + if (ret =3D=3D 0) { + /* Successfully handled by asus-wmi, block event */ + return -1; + } + + /* + * Warn if asus-wmi failed (but not if it's unavailable). + * Let the event reach userspace in all failure cases. + */ + if (ret !=3D -ENODEV) + hid_warn(hdev, "Failed to notify asus-wmi: %d\n", ret); + } + + /* + * ASUS ROG laptops send these codes during normal operation + * with no discernable reason. Filter them out to avoid + * unmapped warning messages. + */ if (data[1] =3D=3D ASUS_SPURIOUS_CODE_0XEA || data[1] =3D=3D ASUS_SPURIOUS_CODE_0XEC || data[1] =3D=3D ASUS_SPURIOUS_CODE_0X02 || --=20 2.52.0