1. Patchew
  2. linux
  3. View series

[PATCH v2] PCI: dw-rockchip: Add runtime PM support to Rockchip PCIe

Anand Moon posted 1 patch 1 month ago 
drivers/pci/controller/dwc/pcie-dw-rockchip.c | 17 +++++++++++++++++
1 file changed, 17 insertions(+)
[PATCH v2] PCI: dw-rockchip: Add runtime PM support to Rockchip PCIe
Posted by Anand Moon 1 month ago 
Add runtime powwe manageement functionality into the Rockchip DesignWare
PCIe controller driver. Calling devm_pm_runtime_enable() during device
probing allows the controller to report its runtime PM status, enabling
power management controls to be applied consistently across the entire
connected PCIe hierarchy.

Signed-off-by: Anand Moon <linux.amoon@gmail.com>
---
v2:
   improve the commit message
   Drop the .remove patch
   Drop the disable_pm_runtime
v1:
 https://lore.kernel.org/all/20251027145602.199154-3-linux.amoon@gmail.com/
---
 drivers/pci/controller/dwc/pcie-dw-rockchip.c | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

diff --git a/drivers/pci/controller/dwc/pcie-dw-rockchip.c b/drivers/pci/controller/dwc/pcie-dw-rockchip.c
index f8605fe61a415..2498ff5146a5a 100644
--- a/drivers/pci/controller/dwc/pcie-dw-rockchip.c
+++ b/drivers/pci/controller/dwc/pcie-dw-rockchip.c
@@ -20,6 +20,7 @@
 #include <linux/of_irq.h>
 #include <linux/phy/phy.h>
 #include <linux/platform_device.h>
+#include <linux/pm_runtime.h>
 #include <linux/regmap.h>
 #include <linux/reset.h>
 
@@ -709,6 +710,20 @@ static int rockchip_pcie_probe(struct platform_device *pdev)
 	if (ret)
 		goto deinit_phy;
 
+	ret = pm_runtime_set_suspended(dev);
+	if (ret)
+		goto deinit_clk;
+
+	ret = devm_pm_runtime_enable(dev);
+	if (ret) {
+		ret = dev_err_probe(dev, ret, "Failed to enable runtime PM\n");
+		goto deinit_clk;
+	}
+
+	ret = pm_runtime_resume_and_get(dev);
+	if (ret)
+		goto deinit_clk;
+
 	switch (data->mode) {
 	case DW_PCIE_RC_TYPE:
 		ret = rockchip_pcie_configure_rc(pdev, rockchip);
@@ -730,6 +745,8 @@ static int rockchip_pcie_probe(struct platform_device *pdev)
 
 deinit_clk:
 	clk_bulk_disable_unprepare(rockchip->clk_cnt, rockchip->clks);
+	pm_runtime_disable(dev);
+	pm_runtime_no_callbacks(dev);
 deinit_phy:
 	rockchip_pcie_phy_deinit(rockchip);
 

base-commit: b69053dd3ffbc0d2dedbbc86182cdef6f641fe1b
-- 
2.50.1
Re: [PATCH v2] PCI: dw-rockchip: Add runtime PM support to Rockchip PCIe
Posted by Manivannan Sadhasivam 1 month ago 
On Fri, Jan 02, 2026 at 06:47:50PM +0530, Anand Moon wrote:
> Add runtime powwe manageement functionality into the Rockchip DesignWare
> PCIe controller driver. Calling devm_pm_runtime_enable() during device
> probing allows the controller to report its runtime PM status, enabling
> power management controls to be applied consistently across the entire
> connected PCIe hierarchy.
> 
> Signed-off-by: Anand Moon <linux.amoon@gmail.com>
> ---
> v2:
>    improve the commit message
>    Drop the .remove patch
>    Drop the disable_pm_runtime
> v1:
>  https://lore.kernel.org/all/20251027145602.199154-3-linux.amoon@gmail.com/
> ---
>  drivers/pci/controller/dwc/pcie-dw-rockchip.c | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
> 
> diff --git a/drivers/pci/controller/dwc/pcie-dw-rockchip.c b/drivers/pci/controller/dwc/pcie-dw-rockchip.c
> index f8605fe61a415..2498ff5146a5a 100644
> --- a/drivers/pci/controller/dwc/pcie-dw-rockchip.c
> +++ b/drivers/pci/controller/dwc/pcie-dw-rockchip.c
> @@ -20,6 +20,7 @@
>  #include <linux/of_irq.h>
>  #include <linux/phy/phy.h>
>  #include <linux/platform_device.h>
> +#include <linux/pm_runtime.h>
>  #include <linux/regmap.h>
>  #include <linux/reset.h>
>  
> @@ -709,6 +710,20 @@ static int rockchip_pcie_probe(struct platform_device *pdev)
>  	if (ret)
>  		goto deinit_phy;
>  
> +	ret = pm_runtime_set_suspended(dev);
> +	if (ret)
> +		goto deinit_clk;

Seriously? Why do you need this? Default PM status is 'suspended'.

> +
> +	ret = devm_pm_runtime_enable(dev);
> +	if (ret) {
> +		ret = dev_err_probe(dev, ret, "Failed to enable runtime PM\n");
> +		goto deinit_clk;
> +	}
> +
> +	ret = pm_runtime_resume_and_get(dev);
> +	if (ret)
> +		goto deinit_clk;
> +
>  	switch (data->mode) {
>  	case DW_PCIE_RC_TYPE:
>  		ret = rockchip_pcie_configure_rc(pdev, rockchip);
> @@ -730,6 +745,8 @@ static int rockchip_pcie_probe(struct platform_device *pdev)
>  
>  deinit_clk:
>  	clk_bulk_disable_unprepare(rockchip->clk_cnt, rockchip->clks);
> +	pm_runtime_disable(dev);

You used devm_ for enable.

> +	pm_runtime_no_callbacks(dev);

Why? Where is pm_runtime_put()? Please read Documentation/power/runtime_pm.rst.

- Mani

-- 
மணிவண்ணன் சதாசிவம்
Re: [PATCH v2] PCI: dw-rockchip: Add runtime PM support to Rockchip PCIe
Posted by Anand Moon 1 month ago 
Hi Manivannan,

Thanks for your review comments.

On Tue, 6 Jan 2026 at 19:06, Manivannan Sadhasivam <mani@kernel.org> wrote:
>
> On Fri, Jan 02, 2026 at 06:47:50PM +0530, Anand Moon wrote:
> > Add runtime powwe manageement functionality into the Rockchip DesignWare
> > PCIe controller driver. Calling devm_pm_runtime_enable() during device
> > probing allows the controller to report its runtime PM status, enabling
> > power management controls to be applied consistently across the entire
> > connected PCIe hierarchy.
> >
> > Signed-off-by: Anand Moon <linux.amoon@gmail.com>
> > ---
> > v2:
> >    improve the commit message
> >    Drop the .remove patch
> >    Drop the disable_pm_runtime
> > v1:
> >  https://lore.kernel.org/all/20251027145602.199154-3-linux.amoon@gmail.com/
> > ---
> >  drivers/pci/controller/dwc/pcie-dw-rockchip.c | 17 +++++++++++++++++
> >  1 file changed, 17 insertions(+)
> >
> > diff --git a/drivers/pci/controller/dwc/pcie-dw-rockchip.c b/drivers/pci/controller/dwc/pcie-dw-rockchip.c
> > index f8605fe61a415..2498ff5146a5a 100644
> > --- a/drivers/pci/controller/dwc/pcie-dw-rockchip.c
> > +++ b/drivers/pci/controller/dwc/pcie-dw-rockchip.c
> > @@ -20,6 +20,7 @@
> >  #include <linux/of_irq.h>
> >  #include <linux/phy/phy.h>
> >  #include <linux/platform_device.h>
> > +#include <linux/pm_runtime.h>
> >  #include <linux/regmap.h>
> >  #include <linux/reset.h>
> >
> > @@ -709,6 +710,20 @@ static int rockchip_pcie_probe(struct platform_device *pdev)
> >       if (ret)
> >               goto deinit_phy;
> >
> > +     ret = pm_runtime_set_suspended(dev);
> > +     if (ret)
> > +             goto deinit_clk;
>
> Seriously? Why do you need this? Default PM status is 'suspended'.
These changes were part of my work on suspend/resume capabilities
>
> > +
> > +     ret = devm_pm_runtime_enable(dev);
> > +     if (ret) {
> > +             ret = dev_err_probe(dev, ret, "Failed to enable runtime PM\n");
> > +             goto deinit_clk;
> > +     }
> > +
> > +     ret = pm_runtime_resume_and_get(dev);
> > +     if (ret)
> > +             goto deinit_clk;
> > +
> >       switch (data->mode) {
> >       case DW_PCIE_RC_TYPE:
> >               ret = rockchip_pcie_configure_rc(pdev, rockchip);
> > @@ -730,6 +745,8 @@ static int rockchip_pcie_probe(struct platform_device *pdev)
> >
> >  deinit_clk:
> >       clk_bulk_disable_unprepare(rockchip->clk_cnt, rockchip->clks);
> > +     pm_runtime_disable(dev);
>
> You used devm_ for enable.
>
> > +     pm_runtime_no_callbacks(dev);
>
> Why? Where is pm_runtime_put()? Please read Documentation/power/runtime_pm.rst.
>
Ok, I will study and update the changes.
> - Mani
>
> --
> மணிவண்ணன் சதாசிவம்

Thanks
-Anand
Re: [PATCH v2] PCI: dw-rockchip: Add runtime PM support to Rockchip PCIe
Posted by Anand Moon 1 month ago 
Hi All

On Fri, 2 Jan 2026 at 18:48, Anand Moon <linux.amoon@gmail.com> wrote:
>
> Add runtime powwe manageement functionality into the Rockchip DesignWare
There is a small typo over here,
 s/runtime powwe manageement/runtime power management/
If you need it, I will send an updated version.
> PCIe controller driver. Calling devm_pm_runtime_enable() during device
> probing allows the controller to report its runtime PM status, enabling
> power management controls to be applied consistently across the entire
> connected PCIe hierarchy.
>
> Signed-off-by: Anand Moon <linux.amoon@gmail.com>

Thanks
-Anand

Patchew 2.1-devel-b67e4c2

© 2016 - 2026 Red Hat, Inc.