[v2] platform/x86: yogabook: Clean up code style

[PATCH v2] platform/x86: yogabook: Clean up code style

Posted by Benjamin Philip 1 month, 1 week ago

This commit cleans up the following checks flagged by checkpatch in
yogabook.c:

- CHECK: Prefer kernel type 'u8' over 'uint8_t'
- CHECK: Comparison to NULL could be written "!data"
- CHECK: line length of ... exceeds 100 columns

Signed-off-by: Benjamin Philip <benjamin.philip495@gmail.com>
---
Changes in v2:
  - Drop cleanup for "CHECK: Unnecessary parentheses around '...'" 

 drivers/platform/x86/lenovo/yogabook.c | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

diff --git a/drivers/platform/x86/lenovo/yogabook.c b/drivers/platform/x86/lenovo/yogabook.c
index 31b298dc5046..69887de36c9b 100644
--- a/drivers/platform/x86/lenovo/yogabook.c
+++ b/drivers/platform/x86/lenovo/yogabook.c
@@ -57,7 +57,7 @@ struct yogabook_data {
 	struct work_struct work;
 	struct led_classdev kbd_bl_led;
 	unsigned long flags;
-	uint8_t brightness;
+	u8 brightness;
 };
 
 static void yogabook_work(struct work_struct *work)
@@ -338,16 +338,18 @@ static int yogabook_wmi_probe(struct wmi_device *wdev, const void *context)
 	int r;
 
 	data = devm_kzalloc(dev, sizeof(*data), GFP_KERNEL);
-	if (data == NULL)
+	if (!data)
 		return -ENOMEM;
 
 	data->kbd_adev = acpi_dev_get_first_match_dev("GDIX1001", NULL, -1);
 	if (!data->kbd_adev)
-		return dev_err_probe(dev, -ENODEV, "Cannot find the touchpad device in ACPI tables\n");
+		return dev_err_probe(dev, -ENODEV,
+				     "Cannot find the touchpad device in ACPI tables\n");
 
 	data->dig_adev = acpi_dev_get_first_match_dev("WCOM0019", NULL, -1);
 	if (!data->dig_adev) {
-		r = dev_err_probe(dev, -ENODEV, "Cannot find the digitizer device in ACPI tables\n");
+		r = dev_err_probe(dev, -ENODEV,
+				  "Cannot find the digitizer device in ACPI tables\n");
 		goto error_put_devs;
 	}
 
@@ -453,7 +455,7 @@ static int yogabook_pdev_probe(struct platform_device *pdev)
 	int r;
 
 	data = devm_kzalloc(dev, sizeof(*data), GFP_KERNEL);
-	if (data == NULL)
+	if (!data)
 		return -ENOMEM;
 
 	data->kbd_dev = bus_find_device_by_name(&i2c_bus_type, NULL, "i2c-goodix_ts");
-- 
2.52.0

Re: [PATCH v2] platform/x86: yogabook: Clean up code style

Posted by Ilpo Järvinen 1 month ago

On Thu, 01 Jan 2026 19:46:57 +0530, Benjamin Philip wrote:

> This commit cleans up the following checks flagged by checkpatch in
> yogabook.c:
> 
> - CHECK: Prefer kernel type 'u8' over 'uint8_t'
> - CHECK: Comparison to NULL could be written "!data"
> - CHECK: line length of ... exceeds 100 columns
> 
> [...]

Thank you for your contribution, it has been applied to my local
review-ilpo-next branch. Note it will show up in the public
platform-drivers-x86/review-ilpo-next branch only once I've pushed my
local branch there, which might take a while.

The list of commits applied:
[1/1] platform/x86: yogabook: Clean up code style
      commit: 751e2ebf29a74c0e46144cbb35e5be478bcd7668

--
 i.

Re: [PATCH v2] platform/x86: yogabook: Clean up code style

Posted by Mark Pearson 1 month ago


On Thu, Jan 1, 2026, at 9:16 AM, Benjamin Philip wrote:
> This commit cleans up the following checks flagged by checkpatch in
> yogabook.c:
>
> - CHECK: Prefer kernel type 'u8' over 'uint8_t'
> - CHECK: Comparison to NULL could be written "!data"
> - CHECK: line length of ... exceeds 100 columns
>
> Signed-off-by: Benjamin Philip <benjamin.philip495@gmail.com>
> ---
> Changes in v2:
>   - Drop cleanup for "CHECK: Unnecessary parentheses around '...'" 
>
>  drivers/platform/x86/lenovo/yogabook.c | 12 +++++++-----
>  1 file changed, 7 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/platform/x86/lenovo/yogabook.c 
> b/drivers/platform/x86/lenovo/yogabook.c
> index 31b298dc5046..69887de36c9b 100644
> --- a/drivers/platform/x86/lenovo/yogabook.c
> +++ b/drivers/platform/x86/lenovo/yogabook.c
> @@ -57,7 +57,7 @@ struct yogabook_data {
>  	struct work_struct work;
>  	struct led_classdev kbd_bl_led;
>  	unsigned long flags;
> -	uint8_t brightness;
> +	u8 brightness;
>  };
> 
>  static void yogabook_work(struct work_struct *work)
> @@ -338,16 +338,18 @@ static int yogabook_wmi_probe(struct wmi_device 
> *wdev, const void *context)
>  	int r;
> 
>  	data = devm_kzalloc(dev, sizeof(*data), GFP_KERNEL);
> -	if (data == NULL)
> +	if (!data)
>  		return -ENOMEM;
> 
>  	data->kbd_adev = acpi_dev_get_first_match_dev("GDIX1001", NULL, -1);
>  	if (!data->kbd_adev)
> -		return dev_err_probe(dev, -ENODEV, "Cannot find the touchpad device 
> in ACPI tables\n");
> +		return dev_err_probe(dev, -ENODEV,
> +				     "Cannot find the touchpad device in ACPI tables\n");
> 
>  	data->dig_adev = acpi_dev_get_first_match_dev("WCOM0019", NULL, -1);
>  	if (!data->dig_adev) {
> -		r = dev_err_probe(dev, -ENODEV, "Cannot find the digitizer device in 
> ACPI tables\n");
> +		r = dev_err_probe(dev, -ENODEV,
> +				  "Cannot find the digitizer device in ACPI tables\n");
>  		goto error_put_devs;
>  	}
> 
> @@ -453,7 +455,7 @@ static int yogabook_pdev_probe(struct platform_device *pdev)
>  	int r;
> 
>  	data = devm_kzalloc(dev, sizeof(*data), GFP_KERNEL);
> -	if (data == NULL)
> +	if (!data)
>  		return -ENOMEM;
> 
>  	data->kbd_dev = bus_find_device_by_name(&i2c_bus_type, NULL, "i2c-goodix_ts");
> -- 
> 2.52.0

Looks good to me. Thanks!
Reviewed-by: Mark Pearson <mpearson-lenovo@squebb.ca>

Mark

Re: [PATCH v2] platform/x86: yogabook: Clean up code style

Posted by Hans de Goede 1 month ago

Hi,

On 1-Jan-26 15:16, Benjamin Philip wrote:
> This commit cleans up the following checks flagged by checkpatch in
> yogabook.c:
> 
> - CHECK: Prefer kernel type 'u8' over 'uint8_t'
> - CHECK: Comparison to NULL could be written "!data"
> - CHECK: line length of ... exceeds 100 columns
> 
> Signed-off-by: Benjamin Philip <benjamin.philip495@gmail.com>
> ---
> Changes in v2:
>   - Drop cleanup for "CHECK: Unnecessary parentheses around '...'" 

Thanks, patch looks good to me:

Reviewed-by: Hans de Goede <johannes.goede@oss.qualcomm.com>

Regards,

Hans



> 
>  drivers/platform/x86/lenovo/yogabook.c | 12 +++++++-----
>  1 file changed, 7 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/platform/x86/lenovo/yogabook.c b/drivers/platform/x86/lenovo/yogabook.c
> index 31b298dc5046..69887de36c9b 100644
> --- a/drivers/platform/x86/lenovo/yogabook.c
> +++ b/drivers/platform/x86/lenovo/yogabook.c
> @@ -57,7 +57,7 @@ struct yogabook_data {
>  	struct work_struct work;
>  	struct led_classdev kbd_bl_led;
>  	unsigned long flags;
> -	uint8_t brightness;
> +	u8 brightness;
>  };
>  
>  static void yogabook_work(struct work_struct *work)
> @@ -338,16 +338,18 @@ static int yogabook_wmi_probe(struct wmi_device *wdev, const void *context)
>  	int r;
>  
>  	data = devm_kzalloc(dev, sizeof(*data), GFP_KERNEL);
> -	if (data == NULL)
> +	if (!data)
>  		return -ENOMEM;
>  
>  	data->kbd_adev = acpi_dev_get_first_match_dev("GDIX1001", NULL, -1);
>  	if (!data->kbd_adev)
> -		return dev_err_probe(dev, -ENODEV, "Cannot find the touchpad device in ACPI tables\n");
> +		return dev_err_probe(dev, -ENODEV,
> +				     "Cannot find the touchpad device in ACPI tables\n");
>  
>  	data->dig_adev = acpi_dev_get_first_match_dev("WCOM0019", NULL, -1);
>  	if (!data->dig_adev) {
> -		r = dev_err_probe(dev, -ENODEV, "Cannot find the digitizer device in ACPI tables\n");
> +		r = dev_err_probe(dev, -ENODEV,
> +				  "Cannot find the digitizer device in ACPI tables\n");
>  		goto error_put_devs;
>  	}
>  
> @@ -453,7 +455,7 @@ static int yogabook_pdev_probe(struct platform_device *pdev)
>  	int r;
>  
>  	data = devm_kzalloc(dev, sizeof(*data), GFP_KERNEL);
> -	if (data == NULL)
> +	if (!data)
>  		return -ENOMEM;
>  
>  	data->kbd_dev = bus_find_device_by_name(&i2c_bus_type, NULL, "i2c-goodix_ts");