From nobody Sat Feb 7 18:28:43 2026 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 93C621A3029 for ; Thu, 1 Jan 2026 14:17:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767277040; cv=none; b=DdAfutPAnOuT/HO4kk3VsO5CYavETghS32k1sFMiB0+LE9k4dobHId5R43JYcqsXLbTxist3RwR4wJsUfFtsbH1rS7JS00BpmQdK5nelq8Prq1akhSh9tN0SwwndOuyLTPpFpiYbQbyVBDHfAE/BWgnc+eA7TWu93UOtFiVNZOg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767277040; c=relaxed/simple; bh=mkc+ryhQgFCsUO37Wjz+nZllxjZFroeJapa0eqhboVQ=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=EF9imkHtQzB1KyxutjrUf0lTmibeQrCxSy9lhpq7/HTQD1y1tO1vK4fMz7/Q2dNFEg3d/CmZmA6YT9TQ2KfaQwmNIuMVaO5za7TNsB4EY+kFq78SkZlCd6ZHQXk5xXaKzYzdvYikN2cMfMokb2I6Z80MvYuZSEQCPxppxetfyeI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=RAg0yOdT; arc=none smtp.client-ip=209.85.214.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RAg0yOdT" Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-29f1bc40b35so201937065ad.2 for ; Thu, 01 Jan 2026 06:17:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1767277038; x=1767881838; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=pVTX+GtTA7AL3KxZR+tY/E2IHW72ZkU1gmOsLX8Ik2E=; b=RAg0yOdT7hvxyJ9Te9kIFS6q/Of44vz2bXPERBBaTSEDXzLLNDskWsNtYqUtKVqe/e c4LJKuF5C4F8FdbkMXUevBAV+iMzOjcpH6k+J1YlGojjUMdfcI57vxiFvVT/7BI2m3Jt 6epVe8Cq4fVAQVPnUPL4kcDFK3K3HIzOyurK5BfA2dl1n1ybt0CJcntgeOdTI65GsTT1 r9NSG6g3W7RyOK978qxQH3tL3K/p361aqj4EzuHLjoeEYk0J75OSCX8PIJOV9HnydavC aZaHj2R/J7cmpUK5eUIMn3JYq8hHf83RgQTpA3c6eekEXpUq9RwTQ3nXqF4D4PUuB1ti pgZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767277038; x=1767881838; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=pVTX+GtTA7AL3KxZR+tY/E2IHW72ZkU1gmOsLX8Ik2E=; b=GRPXcAy1qBiwrxb/YCNGIIvcPsRwG3q7MRqMjps6fxFVf5i54xI7HfRg1kZUWIRjXp ZhZM3SMlGyUrCtXVnCk2ERM5bFltHkODWZrQS/zfw/yJwY4+hbAoFTFhjwyBlfBQHVLQ FAcdgr6HEiHly7qTLBnSnJYszb50E1YUeex/KLAi+wVkvq7LdQQoTM/LoQGh2+2QiVbM gyxV0bdsvVy+j3lMrq8a/sDf1X5FJL8VzTSZMe7WB2OILQRLwrh7UmbxSyFskCbuJxU1 JT50zWqHOBMHHOPBzJTthmLfgtB2cNDEZOVPfrm28P2+p0hv4JvUnhERdGogKjiRlC0O OMsA== X-Forwarded-Encrypted: i=1; AJvYcCV/AluZHCJjeUDJa3J71aEla4KL2vd8Vr3H04r2OpBOuxAziVP/noZ4BXw8I7xHQgR50yRShjGG+3NkhQc=@vger.kernel.org X-Gm-Message-State: AOJu0Yxc+tOt897ZNynKqfh8Tjwny7Y81LKgypybcjkgi8zMUlVZLxXg yOm4eO3qosBvd/OBVpdGNWwO1k1FcSeWV2VrKaAPPO4PL7Qh1TQTkXTe X-Gm-Gg: AY/fxX7pmuMljhNdej+2ltdXVbMTAGCzyOUif8fqMqJaKXt4rkjwBcRsgxnGmUpIOof Osd/pk2nvae521dImcLNXBcva9XDpIVRktU2gWTsWWvlILK1aW4FYV2hCOhZlIvyo2XAzaniN/s ChxbTPUfbQ/7goE1vBdmZyY1aMaruWytai5Wv6RnCFIHh4gaS4Gwo7eX8L0AgaUB9i3x2RGPpsE XNo6VTXvlgIzApj7PwrI1sVjRir0guWhdVtRbMnB8E/Rl6dkJ1NYHwJppz1XZ/ZHoqVzNeWumbm 7YhvtEbvQrGpSWgSu0Mupei8TzJa5ZSQI2M7v+EPFZ2NQVQpEV3LPuZ7usm5pua8DYt/1/ENcWW 8Ml9mdo604KdtO+iP11FFQF36+D+6UlPtWLsmQmhvOQdfKrgGIzFOOKEs5jBLqVyL0CaJ1XuwMB opatqYWnL6mEx3X0OZdg== X-Google-Smtp-Source: AGHT+IHiqbCwv8zP5RLWdsredRkFEGo/XQFDWKDywZPK8qLnCdf8f0OWsqF6zQrePbqEctUPWxGLDA== X-Received: by 2002:a17:902:e74c:b0:24b:270e:56c7 with SMTP id d9443c01a7336-2a2f22069e3mr418824975ad.7.1767277037655; Thu, 01 Jan 2026 06:17:17 -0800 (PST) Received: from rivendell ([101.0.62.159]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a39018dc8bsm105497475ad.43.2026.01.01.06.17.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Jan 2026 06:17:17 -0800 (PST) From: Benjamin Philip To: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Benjamin Philip , Mark Pearson , "Derek J. Clark" , Hans de Goede , =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= Subject: [PATCH v2] platform/x86: yogabook: Clean up code style Date: Thu, 1 Jan 2026 19:46:57 +0530 Message-ID: <20260101141657.54258-1-benjamin.philip495@gmail.com> X-Mailer: git-send-email 2.52.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" This commit cleans up the following checks flagged by checkpatch in yogabook.c: - CHECK: Prefer kernel type 'u8' over 'uint8_t' - CHECK: Comparison to NULL could be written "!data" - CHECK: line length of ... exceeds 100 columns Signed-off-by: Benjamin Philip Reviewed-by: Hans de Goede Reviewed-by: Mark Pearson --- Changes in v2: - Drop cleanup for "CHECK: Unnecessary parentheses around '...'"=20 drivers/platform/x86/lenovo/yogabook.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/platform/x86/lenovo/yogabook.c b/drivers/platform/x86/= lenovo/yogabook.c index 31b298dc5046..69887de36c9b 100644 --- a/drivers/platform/x86/lenovo/yogabook.c +++ b/drivers/platform/x86/lenovo/yogabook.c @@ -57,7 +57,7 @@ struct yogabook_data { struct work_struct work; struct led_classdev kbd_bl_led; unsigned long flags; - uint8_t brightness; + u8 brightness; }; =20 static void yogabook_work(struct work_struct *work) @@ -338,16 +338,18 @@ static int yogabook_wmi_probe(struct wmi_device *wdev= , const void *context) int r; =20 data =3D devm_kzalloc(dev, sizeof(*data), GFP_KERNEL); - if (data =3D=3D NULL) + if (!data) return -ENOMEM; =20 data->kbd_adev =3D acpi_dev_get_first_match_dev("GDIX1001", NULL, -1); if (!data->kbd_adev) - return dev_err_probe(dev, -ENODEV, "Cannot find the touchpad device in A= CPI tables\n"); + return dev_err_probe(dev, -ENODEV, + "Cannot find the touchpad device in ACPI tables\n"); =20 data->dig_adev =3D acpi_dev_get_first_match_dev("WCOM0019", NULL, -1); if (!data->dig_adev) { - r =3D dev_err_probe(dev, -ENODEV, "Cannot find the digitizer device in A= CPI tables\n"); + r =3D dev_err_probe(dev, -ENODEV, + "Cannot find the digitizer device in ACPI tables\n"); goto error_put_devs; } =20 @@ -453,7 +455,7 @@ static int yogabook_pdev_probe(struct platform_device *= pdev) int r; =20 data =3D devm_kzalloc(dev, sizeof(*data), GFP_KERNEL); - if (data =3D=3D NULL) + if (!data) return -ENOMEM; =20 data->kbd_dev =3D bus_find_device_by_name(&i2c_bus_type, NULL, "i2c-goodi= x_ts"); --=20 2.52.0