[PATCH] sh: maple: fix an api misuse in maple_attach_driver()

Haoxiang Li posted 1 patch 1 month, 3 weeks ago
drivers/sh/maple/maple.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] sh: maple: fix an api misuse in maple_attach_driver()
Posted by Haoxiang Li 1 month, 3 weeks ago
If device_register() fails, put_device() is the correct way
to drop the device_reference.

Found by code review.

Signed-off-by: Haoxiang Li <lihaoxiang@isrc.iscas.ac.cn>
---
 drivers/sh/maple/maple.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/sh/maple/maple.c b/drivers/sh/maple/maple.c
index 6dc0549f7900..20b7c2cd852b 100644
--- a/drivers/sh/maple/maple.c
+++ b/drivers/sh/maple/maple.c
@@ -393,7 +393,7 @@ static void maple_attach_driver(struct maple_device *mdev)
 		dev_warn(&mdev->dev, "could not register device at"
 			" (%d, %d), with error 0x%X\n", mdev->unit,
 			mdev->port, error);
-		maple_free_dev(mdev);
+		put_device(&mdev->dev);
 		mdev = NULL;
 		return;
 	}
-- 
2.25.1