From nobody Mon Feb 9 19:55:30 2026 Received: from cstnet.cn (smtp84.cstnet.cn [159.226.251.84]) (using TLSv1.2 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 73653279327; Fri, 19 Dec 2025 14:46:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=159.226.251.84 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766155573; cv=none; b=DuDQpAZpASS46AAcMam3vZA2/Ra6GdK6OZzrsv/blwnyGMvELZF2gvv8gASUWMjWI/+YWODf38RQntrLKdgaYJ3c+NiK72JMLvLMuzY1l0mTygK5iywYOTYh2Zjbk1JqzwDVR2iU7tEgkPD0o+joxlFe+qUvCUS2ko/mg/vqaYA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766155573; c=relaxed/simple; bh=ncw0luK/773+7JSgLJmoBwr7ZbgCtTvgNWvlC3Ph6sQ=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=qFBLp3XpYejYidwrUPVljX0nBVdm2980IjghiGAuFTstneGwDj9kC3sKlLXohDWQ/vA4PI7rvvI76pEKDeYgenH1CSZW4hTCO2VPKsT11AKdDaJn0okN1RD55q5cUhlazeOc1hkkeOBP7MBjwK3csuPTY4clJtvzQOZmOTJJ55w= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=isrc.iscas.ac.cn; spf=pass smtp.mailfrom=isrc.iscas.ac.cn; arc=none smtp.client-ip=159.226.251.84 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=isrc.iscas.ac.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=isrc.iscas.ac.cn Received: from localhost.localdomain (unknown [36.112.3.209]) by APP-05 (Coremail) with SMTP id zQCowACnPREmZUVpXaowAQ--.43934S2; Fri, 19 Dec 2025 22:45:58 +0800 (CST) From: Haoxiang Li To: ysato@users.sourceforge.jp, dalias@libc.org, glaubitz@physik.fu-berlin.de Cc: linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org, Haoxiang Li Subject: [PATCH] sh: maple: fix an api misuse in maple_attach_driver() Date: Fri, 19 Dec 2025 22:45:57 +0800 Message-Id: <20251219144557.638297-1-lihaoxiang@isrc.iscas.ac.cn> X-Mailer: git-send-email 2.25.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: zQCowACnPREmZUVpXaowAQ--.43934S2 X-Coremail-Antispam: 1UD129KBjvdXoWrKw18GryUXF1ftFWrury5twb_yoW3GwbEkr W8ursrWr1DGF1fGry5Gr1YvryYv3Wqg3yIgr1Iqr93CryUurWqgryYvrs3AryYqrWxAFnr J34qgr1jkw1akjkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUb4xFF20E14v26r1j6r4UM7CY07I20VC2zVCF04k26cxKx2IYs7xG 6r1S6rWUM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48ve4kI8w A2z4x0Y4vE2Ix0cI8IcVAFwI0_Jr0_JF4l84ACjcxK6xIIjxv20xvEc7CjxVAFwI0_Gr0_ Cr1l84ACjcxK6I8E87Iv67AKxVW8JVWxJwA2z4x0Y4vEx4A2jsIEc7CjxVAFwI0_Gr1j6F 4UJwAS0I0E0xvYzxvE52x082IY62kv0487Mc02F40EFcxC0VAKzVAqx4xG6I80ewAv7VC0 I7IYx2IY67AKxVWUGVWUXwAv7VC2z280aVAFwI0_Jr0_Gr1lOx8S6xCaFVCjc4AY6r1j6r 4UM4x0Y48IcxkI7VAKI48JM4x0x7Aq67IIx4CEVc8vx2IErcIFxwCY1x0262kKe7AKxVWU AVWUtwCF04k20xvY0x0EwIxGrwCFx2IqxVCFs4IE7xkEbVWUJVW8JwC20s026c02F40E14 v26r1j6r18MI8I3I0E7480Y4vE14v26r106r1rMI8E67AF67kF1VAFwI0_JF0_Jw1lIxkG c2Ij64vIr41lIxAIcVC0I7IYx2IY67AKxVWUJVWUCwCI42IY6xIIjxv20xvEc7CjxVAFwI 0_Gr0_Cr1lIxAIcVCF04k26cxKx2IYs7xG6r1j6r1xMIIF0xvEx4A2jsIE14v26r1j6r4U MIIF0xvEx4A2jsIEc7CjxVAFwI0_Gr0_Gr1UYxBIdaVFxhVjvjDU0xZFpf9x0JUBmhwUUU UU= X-CM-SenderInfo: 5olkt0x0ld0ww6lv2u4olvutnvoduhdfq/1tbiDAgBE2lFN+VvmQAAse Content-Type: text/plain; charset="utf-8" If device_register() fails, put_device() is the correct way to drop the device_reference. Found by code review. Signed-off-by: Haoxiang Li --- drivers/sh/maple/maple.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/sh/maple/maple.c b/drivers/sh/maple/maple.c index 6dc0549f7900..20b7c2cd852b 100644 --- a/drivers/sh/maple/maple.c +++ b/drivers/sh/maple/maple.c @@ -393,7 +393,7 @@ static void maple_attach_driver(struct maple_device *md= ev) dev_warn(&mdev->dev, "could not register device at" " (%d, %d), with error 0x%X\n", mdev->unit, mdev->port, error); - maple_free_dev(mdev); + put_device(&mdev->dev); mdev =3D NULL; return; } --=20 2.25.1