ASoC: drop bogus container_of() error handling

[PATCH 0/3] ASoC: drop bogus container_of() error handling

Posted by Johan Hovold 1 month, 2 weeks ago

The dev_to_sdw_dev() helper uses container_of() to return the containing
soundwire device structure of its pointer argument and will never
return NULL.

Johan


Johan (3):
  ASoC: codecs: pm4125: drop bogus container_of() error handling
  ASoC: codecs: wcd937x: drop bogus container_of() error handling
  ASoC: soc_sdw_utils: drop bogus container_of() error handling

 sound/soc/codecs/pm4125.c           | 6 ------
 sound/soc/codecs/wcd937x.c          | 5 -----
 sound/soc/sdw_utils/soc_sdw_utils.c | 4 ----
 3 files changed, 15 deletions(-)

-- 
2.51.2

Re: [PATCH 0/3] ASoC: drop bogus container_of() error handling

Posted by Dmitry Baryshkov 1 month, 2 weeks ago

On Fri, Dec 19, 2025 at 03:27:12PM +0100, Johan Hovold wrote:
> The dev_to_sdw_dev() helper uses container_of() to return the containing
> soundwire device structure of its pointer argument and will never
> return NULL.
> 
> Johan
> 

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>


-- 
With best wishes
Dmitry

Re: [PATCH 0/3] ASoC: drop bogus container_of() error handling

Posted by Mark Brown 1 month, 2 weeks ago

On Fri, 19 Dec 2025 15:27:12 +0100, Johan Hovold wrote:
> The dev_to_sdw_dev() helper uses container_of() to return the containing
> soundwire device structure of its pointer argument and will never
> return NULL.
> 
> Johan
> 
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/3] ASoC: codecs: pm4125: drop bogus container_of() error handling
      commit: 54fa71f5f965fa3ec8846cef9d1154bcb2ba2850
[2/3] ASoC: codecs: wcd937x: drop bogus container_of() error handling
      commit: 61a50d6f58b41e8a7e68d8fc8fc6bfbe30d790d8
[3/3] ASoC: soc_sdw_utils: drop bogus container_of() error handling
      commit: 870b10f61d527fec594e0888f18cc4f32c47433d

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark