From nobody Sat Feb 7 21:08:13 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9D55A329E75; Fri, 19 Dec 2025 14:27:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766154477; cv=none; b=M+ifDtqLsvckDt6xKPWDHuEhBmfstkzgdlauCSWNNKidDKHJbxmZNgzgzGQOqh95yXriss93hDEQZe8iEbq8Tgp8b+w8t7nJmj/9A3P3h6I5iGGFwwjX2taL5RtR8MK6XAQHtfP5JKCfs4sBxIYm0sXYZiF/zoMWrzynDoqrGAI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766154477; c=relaxed/simple; bh=eDtGYGTH17764v29Lss/qoa/UMzlKT7EjxFZXo4HF3w=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=c3asH0eqrnSBQW4d/ViSMba+zwOBnfnGongTEQGbRW3gHAknkFlCTDCiXKIxX8xgmFj9go0KOB2k+7E5V4SQUi30Rf9+TKASTODMT5x9pNLyHnM1j7IEWIyU31xLcQvATJLO5Q/mcQiHP5fisC1kPc9Mqe8Ns91FiPDzSDkCKxE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=NAvnL9Kk; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="NAvnL9Kk" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 493B9C116D0; Fri, 19 Dec 2025 14:27:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1766154477; bh=eDtGYGTH17764v29Lss/qoa/UMzlKT7EjxFZXo4HF3w=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=NAvnL9KkbaGEKDTWlsu32uqsds/vMsqmoKLkv/XJeNJePN63Q698MRPG273vy508h BM+7ay527lfzaTZyYMF3nY6a7IcFX7x1bua1wE9JRTXATLWYg5bNTdwLGPdyKPgmTq B/9DL5oKhHOPwzcXfYOdHMz5EszLdcp8EOhERetcud9INoOlbPWYCGgqfyrGMcFe+K WP85G0yn5qiOjj5FoFSA1SMshX2eEggg4geR1NuGvNGp9wXZcKJ6EA89NcyU8Mepbe 6cWn8vvsowYFNQ5/bcAx4U0p+UIhI81drwJxnOVFfZoqMai98AXZtLbSARGDTkIA0p mv2EWy+s5PwgQ== Received: from johan by xi.lan with local (Exim 4.98.2) (envelope-from ) id 1vWbSW-0000000051X-1TMm; Fri, 19 Dec 2025 15:27:56 +0100 From: Johan Hovold To: Srinivas Kandagatla , Mark Brown Cc: Liam Girdwood , linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold , Alexey Klimov Subject: [PATCH 1/3] ASoC: codecs: pm4125: drop bogus container_of() error handling Date: Fri, 19 Dec 2025 15:27:13 +0100 Message-ID: <20251219142715.19254-2-johan@kernel.org> X-Mailer: git-send-email 2.51.2 In-Reply-To: <20251219142715.19254-1-johan@kernel.org> References: <20251219142715.19254-1-johan@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The dev_to_sdw_dev() helper uses container_of() to return the containing soundwire device structure of its pointer argument and will never return NULL. Fixes: 8ad529484937 ("ASoC: codecs: add new pm4125 audio codec driver") Cc: Alexey Klimov Signed-off-by: Johan Hovold Acked-by: Alexey Klimov Reviewed-by: Dmitry Baryshkov --- sound/soc/codecs/pm4125.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/sound/soc/codecs/pm4125.c b/sound/soc/codecs/pm4125.c index 43dcafff6c77..1f0a3f5389f1 100644 --- a/sound/soc/codecs/pm4125.c +++ b/sound/soc/codecs/pm4125.c @@ -1533,13 +1533,7 @@ static int pm4125_bind(struct device *dev) =20 pm4125->sdw_priv[AIF1_CAP] =3D dev_get_drvdata(pm4125->txdev); pm4125->sdw_priv[AIF1_CAP]->pm4125 =3D pm4125; - pm4125->tx_sdw_dev =3D dev_to_sdw_dev(pm4125->txdev); - if (!pm4125->tx_sdw_dev) { - dev_err(dev, "could not get txslave with matching of dev\n"); - ret =3D -EINVAL; - goto error_put_tx; - } =20 /* * As TX is the main CSR reg interface, which should not be suspended fir= st. --=20 2.51.2 From nobody Sat Feb 7 21:08:13 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D374C32AAC3; Fri, 19 Dec 2025 14:27:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766154477; cv=none; b=o8E3ARHrpLwMvQHh1ZGqypoqFtjCkax92Zuc4hipTloV8Ey1HkvTxdolEgXguzLxNeCFA7QU2JJseN0UohDfNXieOpF/f6OCQEOHhyxf+s9p2w4IQpdATFSiO10a0LOl4AxhwQ6ciE3IHg3DaAp6KLMAqdRse+qoGdkvWj+umFI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766154477; c=relaxed/simple; bh=67Eabwf4Haq7pOJRL6UwOk2Tu2NXRhLIGQuWuOiVerc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=oOWGDwVmEAzNNb84CKf3c2R9A75bZP86Jf2tdRTmBx7HIVdh3neFGc6PwYvzrbjZDYQ2XlGfj52DGYiCkTieTCp95YJ1c7DRxMf0sMzLWpMbTjsFhpai7qg8hma0K07Q5pI98iGK6MAquoZ/El3R+OOhriW2/RgpaA4AT91MJd4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=g8bL1xas; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="g8bL1xas" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5C1D3C19421; Fri, 19 Dec 2025 14:27:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1766154477; bh=67Eabwf4Haq7pOJRL6UwOk2Tu2NXRhLIGQuWuOiVerc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=g8bL1xasgE/i+sH4uTofdRtlbmtxv7E3McqQ+iNBSXBXEl45AZpPJbrs4dKT2nDXg GfOZne6qN1uQ1HVM7lP1prd0eAp8dbwMy/MH+3u47HEBnpL7qyfBTY+o12tt2QP0A0 JrI9ScYNWbZHszzd3yQSwyHUSbrrTSOH0iDWo8ZGK4FulH6wxto2T/ww1m1nwp4Kij PSImf0B2Sur6YijhEmF7YlTq/lwnHewdVbIdVZ0KqTFkArHe4dHy6QfhliKsOS2ijw oyCM8GiswvRhq90w3osmLKJmBnlNYsw4KpbVNGbLUNK3XW5g7WDEUmqRpunpqTc2ie hp/i9acAfCQbg== Received: from johan by xi.lan with local (Exim 4.98.2) (envelope-from ) id 1vWbSW-0000000051Z-1tOB; Fri, 19 Dec 2025 15:27:56 +0100 From: Johan Hovold To: Srinivas Kandagatla , Mark Brown Cc: Liam Girdwood , linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold , Prasad Kumpatla Subject: [PATCH 2/3] ASoC: codecs: wcd937x: drop bogus container_of() error handling Date: Fri, 19 Dec 2025 15:27:14 +0100 Message-ID: <20251219142715.19254-3-johan@kernel.org> X-Mailer: git-send-email 2.51.2 In-Reply-To: <20251219142715.19254-1-johan@kernel.org> References: <20251219142715.19254-1-johan@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The dev_to_sdw_dev() helper uses container_of() to return the containing soundwire device structure of its pointer argument and will never return NULL. Fixes: 9be3ec196da4 ("ASoC: codecs: wcd937x: add wcd937x codec driver") Cc: Prasad Kumpatla Signed-off-by: Johan Hovold Reviewed-by: Dmitry Baryshkov --- sound/soc/codecs/wcd937x.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/sound/soc/codecs/wcd937x.c b/sound/soc/codecs/wcd937x.c index f4dbcf04be49..10a2d598caa7 100644 --- a/sound/soc/codecs/wcd937x.c +++ b/sound/soc/codecs/wcd937x.c @@ -2763,11 +2763,6 @@ static int wcd937x_bind(struct device *dev) wcd937x->sdw_priv[AIF1_CAP] =3D dev_get_drvdata(wcd937x->txdev); wcd937x->sdw_priv[AIF1_CAP]->wcd937x =3D wcd937x; wcd937x->tx_sdw_dev =3D dev_to_sdw_dev(wcd937x->txdev); - if (!wcd937x->tx_sdw_dev) { - dev_err(dev, "could not get txslave with matching of dev\n"); - ret =3D -EINVAL; - goto err_put_txdev; - } =20 /* * As TX is the main CSR reg interface, which should not be suspended fir= st. --=20 2.51.2 From nobody Sat Feb 7 21:08:13 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9D4DC329E66; Fri, 19 Dec 2025 14:27:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766154477; cv=none; b=gtehTMcA2lj0504GMzhi0q+B0VxCk10cllSgSUpc+pueDJDcFhqpvp/G1g7fzPLPPzvWJzSI9N+Scba7V/16g/3MWfqwBKFdDHK7xxrWYenWh7SLBVnnWh+SlYl252KFoTqnwRiX7hJISytctuwlUgd1a3VYGOupGqVvIIQBDDE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766154477; c=relaxed/simple; bh=FN2zfuLAXWM1lYAhAsms4o1qNUWJ9mz1PleMCxFH1zk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=dDoP5OIgFGOmFORtX8Cg1Epc+7N+0IGzX141S552H5pPlt+jrYEnyzHaz3DGbMG8sJ8OSjVsjaXUIeqesTbPHWYoitYA1v5a6pa42D/CeI1KbS2qJW/1ktrFQHQPsWVE+ouo96mTual3v4mF0IePHLqwoP6Y+WWBDMto/Z/jPn8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=mqlIa2hR; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="mqlIa2hR" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4105BC4CEF1; Fri, 19 Dec 2025 14:27:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1766154477; bh=FN2zfuLAXWM1lYAhAsms4o1qNUWJ9mz1PleMCxFH1zk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=mqlIa2hRLIPKtPXOMlvu+LPCJ6DghClGnwxfQO0gYKl3Kbb7kS6ATvKE+LgHH1ddQ U2lq3q43Sci0fqDslQ2CXezDw6ksU4G+PYYjpUt+gOMh3IkTZVHQu6VWRo+foSBZrm iGuPTcTthHJ+rA0NsR9uChWEwVlnZ/c3Rzev1wmVpgbrI1sHkm/Rzuxy0lZU+1LzgG GJdKdIVpk6U9hQvWAOeAQLGZRVdQjZHSdwJs3Bhya+Pg1ftBHzr4Pkcou3ZX3WJsns lBwTHNgu53CXFxV4+ruzjCUr5QqYPCM+MfdbSDJAa8xhAKVd6BV+g8ccBjg2EBJiP7 byXQ1NnpyDmfQ== Received: from johan by xi.lan with local (Exim 4.98.2) (envelope-from ) id 1vWbSW-0000000051c-2E0u; Fri, 19 Dec 2025 15:27:56 +0100 From: Johan Hovold To: Srinivas Kandagatla , Mark Brown Cc: Liam Girdwood , linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold , Bard Liao Subject: [PATCH 3/3] ASoC: soc_sdw_utils: drop bogus container_of() error handling Date: Fri, 19 Dec 2025 15:27:15 +0100 Message-ID: <20251219142715.19254-4-johan@kernel.org> X-Mailer: git-send-email 2.51.2 In-Reply-To: <20251219142715.19254-1-johan@kernel.org> References: <20251219142715.19254-1-johan@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The dev_to_sdw_dev() helper uses container_of() to return the containing soundwire device structure of its pointer argument and will never return NULL. Fixes: 4f8ef33dd44a ("ASoC: soc_sdw_utils: skip the endpoint that doesn't p= resent") Cc: Bard Liao Signed-off-by: Johan Hovold Reviewed-by: Dmitry Baryshkov Reviewed-by: Konrad Dybcio --- sound/soc/sdw_utils/soc_sdw_utils.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/sound/soc/sdw_utils/soc_sdw_utils.c b/sound/soc/sdw_utils/soc_= sdw_utils.c index 6c656b2f7f3a..f62e291c089f 100644 --- a/sound/soc/sdw_utils/soc_sdw_utils.c +++ b/sound/soc/sdw_utils/soc_sdw_utils.c @@ -1414,10 +1414,6 @@ static int is_sdca_endpoint_present(struct device *d= ev, } =20 slave =3D dev_to_sdw_dev(sdw_dev); - if (!slave) { - ret =3D -EINVAL; - goto put_device; - } =20 /* Make sure BIOS provides SDCA properties */ if (!slave->sdca_data.interface_revision) { --=20 2.51.2