[v2] ASoC: qcom: Constify few things in audioreach and topology

[PATCH v2 0/5] ASoC: qcom: Constify few things in audioreach and topology

Posted by Krzysztof Kozlowski 1 month, 3 weeks ago

Changes in v2:
- Drop first patch (one removing unused arguments)
- Rebase (new speaker_protection functions appear)
- Link to v1: https://patch.msgid.link/20251129-b4-container-of-const-asoc-qcom-v1-0-67a3d3320371@oss.qualcomm.com

Several functions do not modify the pointed memory they receive, so
marking them as pointers to const would serve as self-explanatory code.
Also safer a bit.

Best regards,
Krzysztof

---
Krzysztof Kozlowski (5):
      ASoC: qcom: topology: Constify pointed topology and vendor structs
      ASoC: qcom: topology: Constify pointed ar control structs
      ASoC: qcom: topology: Constify pointed DAPM widget structs
      ASoC: qcom: topology: Constify pointed snd_soc_tplg_dapm_widget
      ASoC: qcom: audioreach: Constify function arguments

 sound/soc/qcom/qdsp6/audioreach.c |  87 +++++++++++++++-------------
 sound/soc/qcom/qdsp6/audioreach.h |  16 +++---
 sound/soc/qcom/qdsp6/topology.c   | 118 +++++++++++++++++++-------------------
 3 files changed, 116 insertions(+), 105 deletions(-)
---
base-commit: b6624535ece4221e67a90b06a373bbefd833c2d1
change-id: 20251127-b4-container-of-const-asoc-qcom-cf4bba99b341

Best regards,
-- 
Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

Re: [PATCH v2 0/5] ASoC: qcom: Constify few things in audioreach and topology

Posted by Mark Brown 1 month, 2 weeks ago

On Fri, 19 Dec 2025 12:45:43 +0100, Krzysztof Kozlowski wrote:
> Changes in v2:
> - Drop first patch (one removing unused arguments)
> - Rebase (new speaker_protection functions appear)
> - Link to v1: https://patch.msgid.link/20251129-b4-container-of-const-asoc-qcom-v1-0-67a3d3320371@oss.qualcomm.com
> 
> Several functions do not modify the pointed memory they receive, so
> marking them as pointers to const would serve as self-explanatory code.
> Also safer a bit.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/5] ASoC: qcom: topology: Constify pointed topology and vendor structs
      commit: c4be067a7b67f616b9ec85423a20be6be9b8ec37
[2/5] ASoC: qcom: topology: Constify pointed ar control structs
      commit: 5e357c7e5e0920bd806a4e7c446c83715315f923
[3/5] ASoC: qcom: topology: Constify pointed DAPM widget structs
      commit: 61fc95c4e3b26b3d1259a87124bdc25e4f71a8df
[4/5] ASoC: qcom: topology: Constify pointed snd_soc_tplg_dapm_widget
      commit: 49675f5e750a2a5d530c56d130017d0337eed18f
[5/5] ASoC: qcom: audioreach: Constify function arguments
      commit: 4ab48cc63e15cb619d641d1edf9a15a0a98875b2

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark