From nobody Mon Feb 9 10:54:02 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 23FDE332911 for ; Fri, 19 Dec 2025 11:45:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766144758; cv=none; b=OpCUAiwN3+4g1fU4K2jciwfWM/wpzBn68VNROkgyrS5wGHKMe0azVcl/9zqzFsmlA1L+aTISPkTvlaI5Vyz2LTfraJWxvDNaMZGJ6JZMwnSZeFDeoCN99DS17mU4LrcKWHub31LNCyMJniChrInwiNZhoc7uLhhUxaLPmSJcBgA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766144758; c=relaxed/simple; bh=6iQcqoX6EI5dlA/DvhZnH1NTKtirFC7ZgIFkbryUzbY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=LDCMHYrBGeIudGLWRilwTB2CfH0T9aNSlPE10yvxuTUcAKJhGNks0wsKE89RdhEvB89WVz9d0dB+xOIdBrJEd0csCISKliiDNmf6e25EejAdKxV1CRDKvaB69nx01I/VU1SgtM8ABhWzDaWWjqxwxQlevgKNNj9LR49xOxI3vlA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=DVxYbzuI; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=REAUt2tW; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="DVxYbzuI"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="REAUt2tW" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BJBfJK93990905 for ; Fri, 19 Dec 2025 11:45:56 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 36PQfpvZIMXAADK9+hYs7pMJ/as3fZIUaaNgWdG/gSI=; b=DVxYbzuIF3Abdhb6 CRnlsPQaBmZ8B6k0EUIUsdpTSjCyjMSZ3Srrdw0s5UQG6PTnKP9KfaDX48zrA/pt 4W1wNoTpeMfuoLaXzzSaJGGTSSI4Pq6Cv4ukr4Wmoka4kE7j450ZhOB7h8sfb5M1 IG2qVCvKtH/Gokq4BiuW+bfnYRPEsSxzXiWZ4UlFW1l67gz/sbM4x5XQ+bcAE11t Q6VmHB9cV/p8cQ6sEosNhZVtS3qkdmQs6kyFL6Vx8ByFg1kwH3dj04LmMkbpDXns p6IzoJTVNScstutzxFuhP93tcc1vjpvi38Ae60zQhDB1G+/1Ppgq+vDSaGmNyUbU wqCDUA== Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4b4r2daf35-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 19 Dec 2025 11:45:56 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-8b1d8f56e24so400795185a.2 for ; Fri, 19 Dec 2025 03:45:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1766144755; x=1766749555; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=36PQfpvZIMXAADK9+hYs7pMJ/as3fZIUaaNgWdG/gSI=; b=REAUt2tW86QM7vKkZg56fwMN0qGl/YV8O3ObprurGsHtpECdTw1O4QtR3iqDHul+J2 fmYuWzZhjq1BvPtMPJVRxqFPUJmwU33h1gjjP3whWIzNZiPQUmS+lLKX/xIO0BB8gUbq mwJkrty3QfKUX8UAJCI3Bano0iyL28uYfFYAkVwPxamzQslDTdUfmVmZMTr+gkwj6bIn OO8/KtzviQQdsqAKqqN+mhnZCuWwF3QvOZwyVnivkFJO6iKCZBCgBhErOCp5ODWRPsDB egGiaQXdiEtwdgZxocmkRrSjBg3gzyKvLHL5Er7ch75PadaNvqW75P67+6mi77lmXiqB ORzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766144755; x=1766749555; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=36PQfpvZIMXAADK9+hYs7pMJ/as3fZIUaaNgWdG/gSI=; b=Hb7qI8nXvxDugthcGDpXNr4oIN90Ls01mSBntjEIHbp0gXz9/EeQi55TqWP5SXgtnR SApQB+SBBmdvcCU5zV+WlozWXUS15r4JvsmSK7nIZZMVTXn8A2ezc09Nhyr0woHlkuQF nsrFwXViK9pQoa38ekfKXaRGSilbiZfP40l8dOva/H1cR+I3PePwbcR97hpsQHDDoTfs wS7RtK2+4N0fSAtXnAgClT9o00g6uYgX7P2aNNgv7ffJHv5SUcbLRnzYA5kpa+oa458K pE+HPWoHuUUTuv6cfBO/ZWbIzxCahAqtUdlk3CMHID68sB44bXI39MmPhU+eRI+hPRM0 Xg/g== X-Forwarded-Encrypted: i=1; AJvYcCXZ46WTuPzyjwHB7tSjNwZ6TNZ3TUEZP+b8JYQzt43NuOR7iwoe50yfnIiWd22IdwDlpZs+RZ6lNFUn0bw=@vger.kernel.org X-Gm-Message-State: AOJu0YwZZGUy7+93ND/EmEP5ecrnoQRdOUMMH/yRJ6OqZxO7lhItZMRD Ya/ThwfnwgmBthgGNtRea+Lo6aQCoOABw45EycXeryrsjkYuzrmG6tkxQbqvVZRYd0W39EQtyDb sDHYHg/buJ9XulbT4VWWvMFRraAmWdGKAyRQ55bLlnDdyZQJY/djtKxTjxPtT5FEjIHk= X-Gm-Gg: AY/fxX7M87jeQmykgeno3WpASfvHrCxKl3dnt/4hP8UxxPUsAANciCT5c1VLhFs4+4n rPy/4p8smaEuATYSN1z3sPQGZ/tGtNQojyFu9dCQkT6pkK6y6mNXSDoi+ujoagFRkZqRG6qb+LB PHaa7n2aya0wKnGG8xVQaspM2RVJqY5VIFBJ7kKuPUW7Och68jgxj/7LmTNcPCH0TuIm9nZ6DqB mwJY3c1TABYhpsCUy7mZdO6HccsyxwalXPbMCvXk1QIeOtqStkfUPdV5Fy6EpQktqFJ/WLoMBGr hI49Y7dfuWiuUFcp+BcvvvQ+4r1xAwvizfR6/GLdPyyylXnCfZwmbkaZU9AAw/tUKzecADOmLKE oyLC8z8pDCOL9TvSk0MppgKhsb87v2kDzoRBNKEIySqe6Trx+gFW9Sz/RuBgkeBx3v3Ww X-Received: by 2002:a05:622a:90b:b0:4ee:1e28:acc5 with SMTP id d75a77b69052e-4f4abdb8a83mr34459341cf.61.1766144755262; Fri, 19 Dec 2025 03:45:55 -0800 (PST) X-Google-Smtp-Source: AGHT+IEj/wWg8UX4Lk00EwF/Tg7aeliCSqzdQO+EZ1nBaXedJue4tu12ePIdbTJEtt5WJGatpPxiEA== X-Received: by 2002:a05:622a:90b:b0:4ee:1e28:acc5 with SMTP id d75a77b69052e-4f4abdb8a83mr34459001cf.61.1766144754855; Fri, 19 Dec 2025 03:45:54 -0800 (PST) Received: from [127.0.1.1] (83.31.98.88.ipv4.supernova.orange.pl. [83.31.98.88]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-64b91599844sm1974465a12.25.2025.12.19.03.45.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Dec 2025 03:45:54 -0800 (PST) From: Krzysztof Kozlowski Date: Fri, 19 Dec 2025 12:45:44 +0100 Subject: [PATCH v2 1/5] ASoC: qcom: topology: Constify pointed topology and vendor structs Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251219-b4-container-of-const-asoc-qcom-v2-1-05fd2ecc06fe@oss.qualcomm.com> References: <20251219-b4-container-of-const-asoc-qcom-v2-0-05fd2ecc06fe@oss.qualcomm.com> In-Reply-To: <20251219-b4-container-of-const-asoc-qcom-v2-0-05fd2ecc06fe@oss.qualcomm.com> To: Srinivas Kandagatla , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=8790; i=krzysztof.kozlowski@oss.qualcomm.com; h=from:subject:message-id; bh=6iQcqoX6EI5dlA/DvhZnH1NTKtirFC7ZgIFkbryUzbY=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBpRTrr2vYzNesFQ+sK/Axv9hE7nGKF5leh2uV09 ezIYLvg2PaJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCaUU66wAKCRDBN2bmhouD 1zHYD/9JTgWW3uIaKU2bHDN80TmFDCOG9MBeVWwKfayeTqJ6a46I5HNESHwCAvkiaQU5nWyLOgI 1JnpgYwzXsIpMU/QgpLSC6ds5mLpfezbSkhtAxgzLgFJp6Q8HLTKrBsPz5olOeb7lbleyTxjBpZ /uOJ7NrJTvJxkyksDI28YOzIB6HqzQzL6BhN04KLaMooFmEthxOPm6mulAftuuQgRSKkxBicztk wrybho9rIp39ShwUoom0AljtMpMdvm/mqWi19njbSmy/vQVnWb7FL6kvub/tGXb1Xf6JqIBV2rd oFUEIyMbZZdD5cLmiCtTqkHeGF7s1Y8hjDXBvpTbIguVxkeGE/SiH2+mLE9ZYXYDfM16cpZaB1j 2UZLGv1toVYnB1uH7K9eJFEXVGs0Mq4bA1lSfV9g96Vq0NCa6cjyHGQHsCWEUNRgMqu3ctDwgwo 3LuFq1D7IVCZKuG44MW/IhXwFssMcK+EfrBMaNw+ZOmnvzQjGeuSJUDcPLQhU1CZHI+auC5UGtA LO/s1ZMaVRBedRBU6oPC8vjb1p5KzVarmKaswZM0xGsRQHoWAoJwetyvjdJoqIqiiFRPJTBxpn4 UTIryQ8923FBHY83+ycm97pfHDuIjdkY9oV7r4lUJ1QIL1Kr4HleiDRmweCy4t35sKM9wkrIbX/ zT/siaq0N8EvhtA== X-Developer-Key: i=krzysztof.kozlowski@oss.qualcomm.com; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B X-Authority-Analysis: v=2.4 cv=AcG83nXG c=1 sm=1 tr=0 ts=69453af4 cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=qe4J/qXhiWkb1JZGYKbLYA==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=Q5gdzY3N6a2DZr8aCz0A:9 a=QEXdDO2ut3YA:10 a=NFOGd7dJGGMPyQGDc5-O:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjE5MDA5NyBTYWx0ZWRfXyqfgxEkckPTP GaCKJ+zY/O36VNzSUUWr8aj3+w3OYrt5AE1VL6IXpWjvTivQXejhO74bJr3byR+RYITnqDM15PH FhhwnKr1GPMt02Fg0OHaHbW2xF2E3bkEpo6wIpPNB6t/27B9bfyNqH7JnGpT0uUEgpLyMBtcwxc J7yaiPw2pKxt+MLFMhv2y5wxbj2KH+fCaG3+3Yg16MRWtZfxl95RDkTelAtwo3ObgC03av9ETuk xN/xDZerOCGjhZbzLPfqCLQTRsk6a7iQ0PzN6hL1VkTahRMHgxjYfiowdnIsXZmrv278EkbSfO0 jDxSKe+ZmuHB2uButqHry90k7FHGl9+vZZeR4IZBaO2c1goyUW5iglf9aCXedbJfoi7A87gBOrG jhRH5c90092m2/58HX6lJYxNiCqXANM8QJE+cZfGSmf4ITbd41PJ7eFsel0dW7ewqFBLfryo5tJ jlPhjlwGZTppHKq44qw== X-Proofpoint-GUID: OH1DHhyxZfa75HF2xyvUZGCcFyRAH8hg X-Proofpoint-ORIG-GUID: OH1DHhyxZfa75HF2xyvUZGCcFyRAH8hg X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-19_03,2025-12-17_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 spamscore=0 impostorscore=0 lowpriorityscore=0 clxscore=1015 priorityscore=1501 adultscore=0 phishscore=0 bulkscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2512190097 Several functions in topology.c receive pointers to 'struct snd_soc_tplg_vendor_array' and 'struct snd_soc_tplg_private', and do not modify their contents. Constify the pointers for self-explanatory code (pointed memory is not modified by the function) and a bit safer code. Signed-off-by: Krzysztof Kozlowski --- sound/soc/qcom/qdsp6/topology.c | 70 ++++++++++++++++++++-----------------= ---- 1 file changed, 35 insertions(+), 35 deletions(-) diff --git a/sound/soc/qcom/qdsp6/topology.c b/sound/soc/qcom/qdsp6/topolog= y.c index 5ce6edf3305e..062eb01fc7a7 100644 --- a/sound/soc/qcom/qdsp6/topology.c +++ b/sound/soc/qcom/qdsp6/topology.c @@ -206,15 +206,15 @@ static struct audioreach_module *audioreach_tplg_allo= c_module(struct q6apm *apm, return mod; } =20 -static struct snd_soc_tplg_vendor_array *audioreach_get_sg_array( - struct snd_soc_tplg_private *private) +static const struct snd_soc_tplg_vendor_array * +audioreach_get_sg_array(const struct snd_soc_tplg_private *private) { - struct snd_soc_tplg_vendor_array *sg_array =3D NULL; + const struct snd_soc_tplg_vendor_array *sg_array =3D NULL; bool found =3D false; int sz; =20 for (sz =3D 0; !found && (sz < le32_to_cpu(private->size)); ) { - struct snd_soc_tplg_vendor_value_elem *sg_elem; + const struct snd_soc_tplg_vendor_value_elem *sg_elem; int tkn_count =3D 0; =20 sg_array =3D (struct snd_soc_tplg_vendor_array *)((u8 *)private->array += sz); @@ -239,15 +239,15 @@ static struct snd_soc_tplg_vendor_array *audioreach_g= et_sg_array( return NULL; } =20 -static struct snd_soc_tplg_vendor_array *audioreach_get_cont_array( - struct snd_soc_tplg_private *private) +static const struct snd_soc_tplg_vendor_array * +audioreach_get_cont_array(const struct snd_soc_tplg_private *private) { - struct snd_soc_tplg_vendor_array *cont_array =3D NULL; + const struct snd_soc_tplg_vendor_array *cont_array =3D NULL; bool found =3D false; int sz; =20 for (sz =3D 0; !found && (sz < le32_to_cpu(private->size)); ) { - struct snd_soc_tplg_vendor_value_elem *cont_elem; + const struct snd_soc_tplg_vendor_value_elem *cont_elem; int tkn_count =3D 0; =20 cont_array =3D (struct snd_soc_tplg_vendor_array *)((u8 *)private->array= + sz); @@ -272,15 +272,15 @@ static struct snd_soc_tplg_vendor_array *audioreach_g= et_cont_array( return NULL; } =20 -static struct snd_soc_tplg_vendor_array *audioreach_get_module_array( - struct snd_soc_tplg_private *private) +static const struct snd_soc_tplg_vendor_array * +audioreach_get_module_array(const struct snd_soc_tplg_private *private) { - struct snd_soc_tplg_vendor_array *mod_array =3D NULL; + const struct snd_soc_tplg_vendor_array *mod_array =3D NULL; bool found =3D false; int sz =3D 0; =20 for (sz =3D 0; !found && (sz < le32_to_cpu(private->size)); ) { - struct snd_soc_tplg_vendor_value_elem *mod_elem; + const struct snd_soc_tplg_vendor_value_elem *mod_elem; int tkn_count =3D 0; =20 mod_array =3D (struct snd_soc_tplg_vendor_array *)((u8 *)private->array = + sz); @@ -305,13 +305,13 @@ static struct snd_soc_tplg_vendor_array *audioreach_g= et_module_array( return NULL; } =20 -static struct audioreach_module_priv_data *audioreach_get_module_priv_data( - struct snd_soc_tplg_private *private) +static struct audioreach_module_priv_data * +audioreach_get_module_priv_data(const struct snd_soc_tplg_private *private) { int sz; =20 for (sz =3D 0; sz < le32_to_cpu(private->size); ) { - struct snd_soc_tplg_vendor_array *mod_array; + const struct snd_soc_tplg_vendor_array *mod_array; =20 mod_array =3D (struct snd_soc_tplg_vendor_array *)((u8 *)private->array = + sz); if (le32_to_cpu(mod_array->type) =3D=3D SND_SOC_AR_TPLG_MODULE_CFG_TYPE)= { @@ -334,10 +334,10 @@ static struct audioreach_module_priv_data *audioreach= _get_module_priv_data( } =20 static struct audioreach_sub_graph *audioreach_parse_sg_tokens(struct q6ap= m *apm, - struct snd_soc_tplg_private *private) + const struct snd_soc_tplg_private *private) { - struct snd_soc_tplg_vendor_value_elem *sg_elem; - struct snd_soc_tplg_vendor_array *sg_array; + const struct snd_soc_tplg_vendor_value_elem *sg_elem; + const struct snd_soc_tplg_vendor_array *sg_array; struct audioreach_graph_info *info =3D NULL; int graph_id, sub_graph_id, tkn_count =3D 0; struct audioreach_sub_graph *sg; @@ -392,10 +392,10 @@ static struct audioreach_sub_graph *audioreach_parse_= sg_tokens(struct q6apm *apm =20 static struct audioreach_container *audioreach_parse_cont_tokens(struct q6= apm *apm, struct audioreach_sub_graph *sg, - struct snd_soc_tplg_private *private) + const struct snd_soc_tplg_private *private) { - struct snd_soc_tplg_vendor_value_elem *cont_elem; - struct snd_soc_tplg_vendor_array *cont_array; + const struct snd_soc_tplg_vendor_value_elem *cont_elem; + const struct snd_soc_tplg_vendor_array *cont_array; struct audioreach_container *cont; int container_id, tkn_count =3D 0; bool found =3D false; @@ -437,7 +437,7 @@ static struct audioreach_container *audioreach_parse_co= nt_tokens(struct q6apm *a =20 static struct audioreach_module *audioreach_parse_common_tokens(struct q6a= pm *apm, struct audioreach_container *cont, - struct snd_soc_tplg_private *private, + const struct snd_soc_tplg_private *private, struct snd_soc_dapm_widget *w) { uint32_t max_ip_port =3D 0, max_op_port =3D 0; @@ -447,8 +447,8 @@ static struct audioreach_module *audioreach_parse_commo= n_tokens(struct q6apm *ap uint32_t src_mod_inst_id =3D 0; =20 int module_id =3D 0, instance_id =3D 0, tkn_count =3D 0; - struct snd_soc_tplg_vendor_value_elem *mod_elem; - struct snd_soc_tplg_vendor_array *mod_array; + const struct snd_soc_tplg_vendor_value_elem *mod_elem; + const struct snd_soc_tplg_vendor_array *mod_array; struct audioreach_module *mod =3D NULL; uint32_t token; bool found; @@ -622,8 +622,8 @@ static int audioreach_widget_load_enc_dec_cnv(struct sn= d_soc_component *componen int index, struct snd_soc_dapm_widget *w, struct snd_soc_tplg_dapm_widget *tplg_w) { - struct snd_soc_tplg_vendor_value_elem *mod_elem; - struct snd_soc_tplg_vendor_array *mod_array; + const struct snd_soc_tplg_vendor_value_elem *mod_elem; + const struct snd_soc_tplg_vendor_array *mod_array; struct audioreach_module *mod; struct snd_soc_dobj *dobj; int tkn_count =3D 0; @@ -660,9 +660,9 @@ static int audioreach_widget_load_enc_dec_cnv(struct sn= d_soc_component *componen } =20 static int audioreach_widget_log_module_load(struct audioreach_module *mod, - struct snd_soc_tplg_vendor_array *mod_array) + const struct snd_soc_tplg_vendor_array *mod_array) { - struct snd_soc_tplg_vendor_value_elem *mod_elem; + const struct snd_soc_tplg_vendor_value_elem *mod_elem; int tkn_count =3D 0; =20 mod_elem =3D mod_array->value; @@ -690,9 +690,9 @@ static int audioreach_widget_log_module_load(struct aud= ioreach_module *mod, } =20 static int audioreach_widget_dma_module_load(struct audioreach_module *mod, - struct snd_soc_tplg_vendor_array *mod_array) + const struct snd_soc_tplg_vendor_array *mod_array) { - struct snd_soc_tplg_vendor_value_elem *mod_elem; + const struct snd_soc_tplg_vendor_value_elem *mod_elem; int tkn_count =3D 0; =20 mod_elem =3D mod_array->value; @@ -719,9 +719,9 @@ static int audioreach_widget_dma_module_load(struct aud= ioreach_module *mod, } =20 static int audioreach_widget_i2s_module_load(struct audioreach_module *mod, - struct snd_soc_tplg_vendor_array *mod_array) + const struct snd_soc_tplg_vendor_array *mod_array) { - struct snd_soc_tplg_vendor_value_elem *mod_elem; + const struct snd_soc_tplg_vendor_value_elem *mod_elem; int tkn_count =3D 0; =20 mod_elem =3D mod_array->value; @@ -754,9 +754,9 @@ static int audioreach_widget_i2s_module_load(struct aud= ioreach_module *mod, } =20 static int audioreach_widget_dp_module_load(struct audioreach_module *mod, - struct snd_soc_tplg_vendor_array *mod_array) + const struct snd_soc_tplg_vendor_array *mod_array) { - struct snd_soc_tplg_vendor_value_elem *mod_elem; + const struct snd_soc_tplg_vendor_value_elem *mod_elem; int tkn_count =3D 0; =20 mod_elem =3D mod_array->value; @@ -780,7 +780,7 @@ static int audioreach_widget_load_buffer(struct snd_soc= _component *component, int index, struct snd_soc_dapm_widget *w, struct snd_soc_tplg_dapm_widget *tplg_w) { - struct snd_soc_tplg_vendor_array *mod_array; + const struct snd_soc_tplg_vendor_array *mod_array; struct audioreach_module *mod; struct snd_soc_dobj *dobj; int ret; --=20 2.51.0 From nobody Mon Feb 9 10:54:02 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 08A15332EBE for ; Fri, 19 Dec 2025 11:45:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766144760; cv=none; b=bR+PqOo/t/WMKCBiz/3fLP0VdEy9ReMcB+UqipcSow4u33W2bP+lHxfSwIYXqFICPKMNV38TAY+5xQ/Kt9+FZW/qCmCJY3OSjM8G7HJtHorJddItPCe8EvGzXWEoiV6gQgJ4rARq0BgmlTNh3rtuYq0G+Si80Fi8slqQwn3yZTA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766144760; c=relaxed/simple; bh=NyyDLjSfGMUENLbw8bS7UpVbLpd19bM1d/LGXzlZ0a8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=M6oXK3j07kIDFsNXmxQcmi68GuhNgn1ANRVEm2B75ku8j8pxxvNAIxgRwxWsXcyOmIXkcS3rTOLbeNW4KWMzSCRs0PMvY0TO7oI+TEJ9R8bzcSLn+C/amNMvGtBYG9CCSf7I7y6HtZ+5C3yio1Fa/8fS0bhtUIpvPTXuDqOXHzQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=M+7ljc7Y; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=g4F1Hue/; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="M+7ljc7Y"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="g4F1Hue/" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BJBAej53939666 for ; Fri, 19 Dec 2025 11:45:58 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= k/n9QKasXofpMA+jcZikeqyca2hnXEd/6lPYRNYCXv4=; b=M+7ljc7YHQLl4sx5 QW5HY0wQgpSxQik2HytzmnUFjbfktyUZz0guvUU/wPM44L7VPwQ+OhXT1GTPiJCq kFVYJkuX6Gd0il6/RKK6/yUuZZmHJx20hfCwd8ovGm3xWDk+3K9gzwMxtVhOg75t hbSHy3TmAMdWrLDOElpapJqaJBU3Zjpf8jYFi+/p+Z7m9eEFj0YAcT9qcD0byQOR KM5LEMZOmaKyFaP2mm5rndWptzw3iqwOOFTS0nWgotWKLKz6HIh1aGC3NxQOLpNq swDJp8yRVjnlzz/g1mPjLXOzD3pYqwDQbnQjWC/FVy3X2HqB8z55lnTNtZOrOFdP Eg1Znw== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4b4r2c2hcj-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 19 Dec 2025 11:45:58 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-8b4f267ba01so666239085a.1 for ; Fri, 19 Dec 2025 03:45:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1766144757; x=1766749557; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=k/n9QKasXofpMA+jcZikeqyca2hnXEd/6lPYRNYCXv4=; b=g4F1Hue/KmdYwERFOBlu6Apn2Br3zFIAIvXiK5aCkFRvLd5N0wG5bdfQly+nH6vulz u5S8Eo+UhQjgMZ9kMlPHF6fVQBuu95mSJMeYTDEuqRbPK//EeMugY2iOM4OIjsqpPJZA vWerHs/9w0lz42BvVQPISX4oRnMu7rr62xRk7hT1GxZnwZLmuH7F1s8wUqtsXYCyFGOb JHy1hltGPSyShTeqJQYJavmqJkhA9OoMQxgcsQmQFbRR8NC1tQtsdl9ghLsCUhv4z9YF Inj2Gt06eFmjnH1ynIfBaIQVINSj9VvceeYzgEUih225NaFUqDl/W8WiLsH8f8Dg6UNB cXLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766144757; x=1766749557; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=k/n9QKasXofpMA+jcZikeqyca2hnXEd/6lPYRNYCXv4=; b=URaGYhkjXV037ypm3J5CAnkH15bAz+2hy661JCPiTxOXbG4/C52IKluBFvJE2ca9Te BjCYIJtgfav0Lw0ij6IsMPN5d65B1SNTn8zKZ3cW8punTil0/zLOMlMxkve4TFh+sxq6 q7Ol6zsuSVurSf2NfB9YyCNyQ11G3zYXe5ASVWpCZ9RQqDEYCnoqZLrMrbWZhjeuU5Nz tc4vvah90hCxg0G+ohIoL+rNgN+rn3pHPWFAd/pioHCR24iwnO9D0fvjPn3QiDps8nxV i7DR3Of9F9/N1XZcG+BJmkcdIGs5TyejCafA/fOc4dQEDLVGFeyaBpLU2T0NlkJ3oWnT qUdw== X-Forwarded-Encrypted: i=1; AJvYcCWOQVvQofodBP/eACjOvRHMtWUH86zG6m7+d3fscKOBJVGNtTSnG+OnSSZiBNQiq97bPW5MuZNbR6WSoTI=@vger.kernel.org X-Gm-Message-State: AOJu0YzsXCQwDBeKidtBKNEhNes6+aMpJvzbwO/FyTIM5QwK0PIqpWjf Px+a8DY486kwkVhq0cO63SSxIJDmIzm1VP7PVrjr+tDZXly/VXWAFkv+oIXB0h1siSN1zSP5B1c BtxCJEoZawsmHVOPo0DsD/LNiCPy9YoVHkK8LQ4sKOuZGpseY/TuLibs+/tX80Jg/RBiVb81Lgn 4= X-Gm-Gg: AY/fxX6F91Xkpj85Rn/0gsiJZcFYx8sWst5sBr9jJeoQTPrm7ItXdZT2826f7KiBXS3 6aGP8PQNq8KOmzvjJ/c40q89FXGP+fsy2I6FdfukT7QGf3sZog5KBsNiSaN84YM+M0IKqzcXVWF lXcTKtiKUQ+ziriKF6kVuiiKQ75pcqCayyc2BiReGNlgS1Fgo+73LZbPQ6c+aYs59ymcCaQ4vpP IouXIvSoI487YiZfaei1gRrXIqC07hoA3fT0fFzFNvPo0JiiJ3Y0bv4cONhybiHM/FRTXty9hF/ 5tIhAtRIOlAWOXL9XqLwyqWapBnq+XSlnzaxzpGsV+ZVHzm6iU4IhbnbnSRRG76uah96p4mOP5U EFUDUvQNcmmq2xPOaueTbZKxVqV3oL6wT5kT4dRQebHGPf79iYquEp1QsVfZJpRsIoNdO X-Received: by 2002:ac8:5a4b:0:b0:4ed:3d24:9570 with SMTP id d75a77b69052e-4f35f481077mr75172171cf.37.1766144756947; Fri, 19 Dec 2025 03:45:56 -0800 (PST) X-Google-Smtp-Source: AGHT+IF2Qay+Fkz9w9/V4HcbS2VG8J/zzMCfFSu9UJ5VwWSLt8yl+iqgcay0FYPHFUsBhR9D3NQNsA== X-Received: by 2002:ac8:5a4b:0:b0:4ed:3d24:9570 with SMTP id d75a77b69052e-4f35f481077mr75171971cf.37.1766144756561; Fri, 19 Dec 2025 03:45:56 -0800 (PST) Received: from [127.0.1.1] (83.31.98.88.ipv4.supernova.orange.pl. [83.31.98.88]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-64b91599844sm1974465a12.25.2025.12.19.03.45.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Dec 2025 03:45:55 -0800 (PST) From: Krzysztof Kozlowski Date: Fri, 19 Dec 2025 12:45:45 +0100 Subject: [PATCH v2 2/5] ASoC: qcom: topology: Constify pointed ar control structs Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251219-b4-container-of-const-asoc-qcom-v2-2-05fd2ecc06fe@oss.qualcomm.com> References: <20251219-b4-container-of-const-asoc-qcom-v2-0-05fd2ecc06fe@oss.qualcomm.com> In-Reply-To: <20251219-b4-container-of-const-asoc-qcom-v2-0-05fd2ecc06fe@oss.qualcomm.com> To: Srinivas Kandagatla , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1999; i=krzysztof.kozlowski@oss.qualcomm.com; h=from:subject:message-id; bh=NyyDLjSfGMUENLbw8bS7UpVbLpd19bM1d/LGXzlZ0a8=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBpRTrsbgK2eb02MTt4oP6IN39AJpG1243+XIBph JpU0VwlHoSJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCaUU67AAKCRDBN2bmhouD 1+mID/wJmJk1sH48y7AgVzKwt/lWXdPgYsFRrvkHQzSfFJ9uJqWBUjTPUxlnOMVTAf+mwA2X+Gd APW9G25ZmIM5E1LEcXumLzyRg2c1AAa2Cv2iNZqnjn4eBfAms6dXwoHY24golyxz5SWDZZcWtOr 2VyRjLLrtGdLHdfmWWdigvPYhcqK1jcTlwZH79NncBhaV6ft1v5hD7mDMy9135ko3aJhazoVdWL WDX6tSDJ05WZpvGs3h06hHVlzJ4HD5pp7Bde/ErIctLGlZXR33xqyO0FTIfWUhoJAn+CXAH8jHa psx8MJbLfl5eFf6WvVLk8ApBevHwpTvkhy22cvQg18//HAWhiHL5WnP6MXJNTa+mG1c2Ffow1Nd LQeAFq+gdtwjdsTZq9USmrYrDGq71iruNo8WFXqcW5YqIMxm3VbVteCJ/M0r7H3UDtD50ly2Eqt r72Oe1ZfTZRXFwUViUGNQiL0a+tEo+AAxjK/qP1iMTdcVJqUInYjPMG2wPitVcvzncuXzuDe22j d5RfaexkdtKuM3AoZ/6WQBp2zI7i+FGnLYWPtlC/YD+sK71e5U02UsjFRqOPwf6uzfiv+wN7qj1 S7defSqaHsQKipBfgdd9kLPx1PU1O5ncag/a7CbEHxT49OVPbxG02GyrTze/FKoFtBhB1TDhJNs CE7AA7z5ZoogBsQ== X-Developer-Key: i=krzysztof.kozlowski@oss.qualcomm.com; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B X-Proofpoint-GUID: rSW2Br4q9Dkw5YQ7JtJ5LVV9JoFLMGOJ X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjE5MDA5NyBTYWx0ZWRfXz6IhvLzdpX9Y WoNwArm/XMKDI3ghdKYproTEYAe8Rs4I+gtjtU98UQzLvBcuspXXQupOpf8x5XRHC07zg5vHt2l rPscWheWndK43mt6x56pIch6QSM+o+9RjjdbH1QIWsMDbiTZxFfjrlnW630Wb8drE0AUrUwuZz5 rA7m0XE7XnUWzk2BJv+bu0lqakEMsGaczya3D/0uPk+NVnfhUsWqA41XvlPbEHQXla2/pVd5CJ3 yjcAx8w/SHnI3c3zCr7Zklmv86QXswcX69xKVXl8paxIKA4AopR4ofLL+BEyocaGmoaJ447cu+z d4eqM4PHnwpOCZ68cUiCjyD/4D3GcpHfOWwfc/QkKoeMYk5uaF99iE/IaXxJ1IifC93l8l2bgdO IZyAM2jhFchjQ0qj4qr5oa3/tNiSlmQrdthJIvG8vabFp8rs/ckRh9VXck3SkpsdfPHkPHfl2Rj MILqQbsxNZPxZXwGoxQ== X-Authority-Analysis: v=2.4 cv=feSgCkQF c=1 sm=1 tr=0 ts=69453af6 cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=qe4J/qXhiWkb1JZGYKbLYA==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=Eep4eOvNbGvhNPJmoRUA:9 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 X-Proofpoint-ORIG-GUID: rSW2Br4q9Dkw5YQ7JtJ5LVV9JoFLMGOJ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-19_03,2025-12-17_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 phishscore=0 priorityscore=1501 malwarescore=0 suspectscore=0 spamscore=0 lowpriorityscore=0 adultscore=0 bulkscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2512190097 audioreach_route_load() does not modify the pointed 'struct audioreach_module' and functions for connecting subgraphs do not change pointed 'struct snd_ar_control'. Constify the pointers for self-explanatory code (pointed memory is not modified by the function) and a bit safer code. Signed-off-by: Krzysztof Kozlowski --- sound/soc/qcom/qdsp6/topology.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/sound/soc/qcom/qdsp6/topology.c b/sound/soc/qcom/qdsp6/topolog= y.c index 062eb01fc7a7..9bde799146fa 100644 --- a/sound/soc/qcom/qdsp6/topology.c +++ b/sound/soc/qcom/qdsp6/topology.c @@ -1032,7 +1032,7 @@ static struct audioreach_module *audioreach_find_modu= le(struct snd_soc_component static int audioreach_route_load(struct snd_soc_component *scomp, int inde= x, struct snd_soc_dapm_route *route) { - struct audioreach_module *src_module, *sink_module; + const struct audioreach_module *src_module, *sink_module; struct snd_ar_control *control; struct snd_soc_dapm_widget *w; int i; @@ -1098,8 +1098,8 @@ static int audioreach_link_load(struct snd_soc_compon= ent *component, int index, } =20 static void audioreach_connect_sub_graphs(struct q6apm *apm, - struct snd_ar_control *m1, - struct snd_ar_control *m2, + const struct snd_ar_control *m1, + const struct snd_ar_control *m2, bool connect) { struct audioreach_graph_info *info; @@ -1123,10 +1123,10 @@ static void audioreach_connect_sub_graphs(struct q6= apm *apm, } =20 static bool audioreach_is_vmixer_connected(struct q6apm *apm, - struct snd_ar_control *m1, - struct snd_ar_control *m2) + const struct snd_ar_control *m1, + const struct snd_ar_control *m2) { - struct audioreach_graph_info *info; + const struct audioreach_graph_info *info; =20 mutex_lock(&apm->lock); info =3D idr_find(&apm->graph_info_idr, m2->graph_id); --=20 2.51.0 From nobody Mon Feb 9 10:54:02 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F08EC33372A for ; Fri, 19 Dec 2025 11:46:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766144762; cv=none; b=kXGuhzYMeyZ7na/X9gK1nbXNAW85W/qTu2nM5sVohK916lA7TG5rg1cIRJ29VeTi2RHKpmrCEK/JH3J4uvgsNm80Jf6jY0kA76wJbVuNDvYUm8vGnWk1q2yAl7hDck1KUL2z+dCJnHo4MOZLSTYfMCtb0u11W80P9Itazm+M96Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766144762; c=relaxed/simple; bh=Degls3YyxMyfY5Nqt3ik52p7vh9Q9ulviIfWRf+xnWg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=VDf1WT5shux8Byyv13N0NJ3E5hYLbfDmXEukRNqHLtr4MPYQmRNFAsMbgZ0KUV+m7rdm5CV4sPSXeJNhTEUZfhWHJqbyctoXM/C/RQNotE+pTaRI9V+Umpu9KvwlYR8NUfDtH8HiJ3RvmIfUeBhsRD+bXpXbwOz7xfNGpmykQhs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=cHkDi32t; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=jTFOSR9y; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="cHkDi32t"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="jTFOSR9y" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BJ4chpv3976809 for ; Fri, 19 Dec 2025 11:46:00 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= GsntXj2xs0vSWboav+9ejaf6M5WSMCuFplOnSmz12vc=; b=cHkDi32tgle3y2EJ PQTh7sMT231rVjiEmQeomTyJ/sUr0vJ0w919lEiCoxnmG4vEdCQ9sphVtwaW4KWy jhdj5MwaSGBBfKJzd/wfux5wYxeMU8jnBlX5BhkMj10JKMuRVaUteMJyBho8+CA7 34qJBIVWyPFR+KAk8WflmCKykNUXWKq7L8Y3fQT5VQeI7clVqI77xFt1D5UKg6cE eqWL57ufxlsjZOaFivhq9vHkYX+XqTVN56FWitVYru7YO44uSBNx7GFDRrq2x34X EOs7cKSuNgCTnBjDPf0EboqZ6wg6NTBZwhcI1ZOpVYaVhenedQTRkKwaWq2xHPQe AoQxBA== Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4b4r2fjer2-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 19 Dec 2025 11:45:59 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-4ed69f9ce96so51081731cf.3 for ; Fri, 19 Dec 2025 03:45:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1766144759; x=1766749559; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=GsntXj2xs0vSWboav+9ejaf6M5WSMCuFplOnSmz12vc=; b=jTFOSR9yNKbjYBsvjHwSTV6bNmkEjEwuGQwFPTBPfsecaaHluw0rSNnkTW3ZB2E432 NrELYhUPYtstiP0dvtXw1tesmPmS25Wgaq8p7yyZKeJS3Prc0IUtbHeXzR8nzYzkkw1g WWD9aNUz+N+Toz6j2pMDbkYQ9yn6PjTbqLoikAKnVoFQyEElrLS85O6P6cc3sJq0BkSV 3SezCE0Uc4ynr3c8UFgJmswkYM3V5EabUUkwq//pdpGVMV0m4tFfWLzU2KBJrArPsoFs WgX3DtSxb8Wp0Ni45dvod5reHwMTi38mvWv0JsRFeqWEC+u5xyq44LGrMuk8HAlc3rlF naPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766144759; x=1766749559; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=GsntXj2xs0vSWboav+9ejaf6M5WSMCuFplOnSmz12vc=; b=Mu9tKP6EEH/OECpF4JDjrrLo2pGHNnhIxC/LlWp5TDaEJQ77RfQUXvuWk1WnguqMXZ KfXWQriJvg1hJHr7SIpDs8FU3TQx0ZuaM92VjVjlEfdMMqnZ8kTBwDk7Q9PTRW8HI04T 3HTF0CuzcSuYmX35Hc3cx5T41heB8DXbhsfFhyDk5ogNw8qyqM+T2+qUAwV30XKGaeuO 5oMmEJ8xGWFUAv5FixFeZZMEBJ6tzr0nEGYrNBDKwdFDk1ti5sY9UOJYSAIks3xVleFN p0FsLIIYO4t5/bf7HbmS+kWWH3X4oj+dMkSBA0d0AkufxRQJORyw1JH6sXIvStQ19sWW U3hw== X-Forwarded-Encrypted: i=1; AJvYcCXxJ0NbTIWi8lauNueeg0uyppWaQAKeY/pDNu+ECT04UHfzUF0/hvgZfGzSNjHWr2BqtXDMNvRp9gNkgbs=@vger.kernel.org X-Gm-Message-State: AOJu0YxoCBQzcwcFaCi2YLQWP8wMkzl/nchtR8HUIN4T/n6I5zhA7j7L hJjO1m8OVQ5JvLI3ThN7pdDuPw2Tgyqzxvr0CB+NOuMEkb3fPyNBdivZtENnTkcErszWgPxLW9m O9KNCKD1xOHj3ffPCu5GxqBURjHYBGhoM8Vz2ReJV2hesR0edmTi5czkqLlSfj5RpGXg= X-Gm-Gg: AY/fxX7CWlYMNeXrm1i2dZjXphIkm+B00FVRUkxhGg3gdNdziyYFssuPw2WCRtxXNDt /1Ymy1QZ038E9EsldbP90CJjbM6iOBSuYjpJaGOJfZ2Xpxt2uBzN9OyHtn/RSc1vUiKH07bKmnt PvBkIq0ANjhKH8pNOLzI0ZiK6mb4h9XkXgePdZlI0OiVPe4mBQqHK1LBOESq7ZQc07WmtFT3nZs 03OeqHo8wb9bZOrAV6K1TdexF14PZiOb5Ps6MO/GVw+/bKZJg5/7UmsWHbDthcTMZggRz2FAtD3 IBe1a4vwHjBn1gdJufCs8UaLBNhG/I2MtkQ7vAYsPtIplp3t++IQJs56IeJMy0Q7x6RbxltoRtf Q5LvRvVna6W6cp6Lnx+YZm141FXffnnOmADfevfe+Gds60oWQrW2cXMalzEnl4VKtcqcw X-Received: by 2002:a05:622a:540c:b0:4ed:1948:a8af with SMTP id d75a77b69052e-4f4abd0dcc0mr32426061cf.36.1766144759398; Fri, 19 Dec 2025 03:45:59 -0800 (PST) X-Google-Smtp-Source: AGHT+IHmjQSEZmBvOVjyOK0uOW28Pz8FDz6PH8SP4Yl2gDZFbu33MXEK0ukDwGFNSYkrW/XA/r6oew== X-Received: by 2002:a05:622a:540c:b0:4ed:1948:a8af with SMTP id d75a77b69052e-4f4abd0dcc0mr32425861cf.36.1766144759035; Fri, 19 Dec 2025 03:45:59 -0800 (PST) Received: from [127.0.1.1] (83.31.98.88.ipv4.supernova.orange.pl. [83.31.98.88]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-64b91599844sm1974465a12.25.2025.12.19.03.45.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Dec 2025 03:45:57 -0800 (PST) From: Krzysztof Kozlowski Date: Fri, 19 Dec 2025 12:45:46 +0100 Subject: [PATCH v2 3/5] ASoC: qcom: topology: Constify pointed DAPM widget structs Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251219-b4-container-of-const-asoc-qcom-v2-3-05fd2ecc06fe@oss.qualcomm.com> References: <20251219-b4-container-of-const-asoc-qcom-v2-0-05fd2ecc06fe@oss.qualcomm.com> In-Reply-To: <20251219-b4-container-of-const-asoc-qcom-v2-0-05fd2ecc06fe@oss.qualcomm.com> To: Srinivas Kandagatla , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=3537; i=krzysztof.kozlowski@oss.qualcomm.com; h=from:subject:message-id; bh=Degls3YyxMyfY5Nqt3ik52p7vh9Q9ulviIfWRf+xnWg=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBpRTrt/kPDT4bOMogqhALmeXi5csaLRHkvUOOx0 ghQzeFut/mJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCaUU67QAKCRDBN2bmhouD 1xzfD/97MowV2KcXIPb0DC2OArh1iphmizBgoM6FOVqXqMZnKf4redDsc4AwMRhKE1BaIlQkiYp OkS/qhbac7ju7izGZyeRWBN0BamdEvC10DUGfvygklFiaNWJxTSiOgE5bY7y1cLjDIqpu2q8f2J eqg4toV3LPbQSCiYmbU5ekrMhouBOwap51sXFs5mbE8gogcenKckDdqDf943eUPAHayeRI/4ZOw jA3zDjo43jZ1F3+cwShU5++/nCoQd5LEiN+CzuQ3/xG7HPsDE9lLxgdxxh872I+E90MdWWKWyxA k+MsEFY9jFTZKYCZhge0o7q8CzVC0AYP3c05DBJDsIs+AypiThOHh5TIgJq3xxpjh5vDtnMkrL0 5KhCpQ4dNKzeUSZQ0SQ5SgEDkYmLuJU5oEYzObqsdkLOrHqB9xuqnrRio0yfmwfu2wBNiK8b3Y3 oDRDjaPzuRISGwGNTnN1EFGbvr3ZLkslvMT2xF6dAu/eI7iZLLsP1dxfj77r+qEXEfWvUEFpAig NWq3tLh5UlQkUz+i++KdnBJnmgJ5YOKcYs3iQGSSL2yQG4o9d/hLGbWQsHcO4IxpDXIJ2TRrCMG pZPFYB953xn4dhD8LvWUraypzr0uVt3/cZyltSYZioznSOXM7KTiCEB4y+TOYe6PcTLLp9sbmUY 2ZHkQwa4nlm89Pg== X-Developer-Key: i=krzysztof.kozlowski@oss.qualcomm.com; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B X-Authority-Analysis: v=2.4 cv=NODYOk6g c=1 sm=1 tr=0 ts=69453af7 cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=qe4J/qXhiWkb1JZGYKbLYA==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=p4u2xNunYncVunGlIlIA:9 a=QEXdDO2ut3YA:10 a=kacYvNCVWA4VmyqE58fU:22 X-Proofpoint-ORIG-GUID: xVrNonYdK2oJUfy145JFgd5G9CoGiYrX X-Proofpoint-GUID: xVrNonYdK2oJUfy145JFgd5G9CoGiYrX X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjE5MDA5NyBTYWx0ZWRfX4ldwOhJ7/fIg 5KTI31K7aIvvHTZp7HDRAgHuP+fBorCRuV5yGYdSI9zgaJSOwmyFjEKaLgHS8bvgcSLJTQadkG7 V45LTinxv+Jo389VAKGxaaSTYYWbFr44mYiJWRTI2uz2oQKtuy21Rm+/boODaY9aRBujfOBCWXM oVOfI8GzDOoYPw34HDB14wS8098jpGTqA/QH9Q6nGW3csE++4Nf51Ljbh4zYt3ctwLogmEvFq8f URvFbfHM4DDvdGZEasnZ1FmBNQXZTkR5YzIEpnGgSmJte9pKcUBcMjTwiZxgtLZlDktoScAsqyE V31R8K5MMnkYc/eJhJWxAOQQp8RWpDpLCg5/uvbR9n4buYhjfA8cuZ/OpPgrOUEJwoa77ciasD/ 4pXEPB2pQeBkgxUMmMOEoKTigLZFO+Bd+fefGdDhaNbC9T32c0LwkwTLt1WB8NLSo06Mop0Ev2d z40KdFeO4W3hluyBIPw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-19_03,2025-12-17_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 phishscore=0 suspectscore=0 impostorscore=0 bulkscore=0 adultscore=0 malwarescore=0 priorityscore=1501 lowpriorityscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2512190097 Few functions do not modify the pointed 'struct struct snd_soc_dapm_widget', so the pointers can be made as pointers to const for self-explanatory code (pointed memory is not modified by the function) and a bit safer code. Signed-off-by: Krzysztof Kozlowski --- sound/soc/qcom/qdsp6/topology.c | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/sound/soc/qcom/qdsp6/topology.c b/sound/soc/qcom/qdsp6/topolog= y.c index 9bde799146fa..fbba543bd976 100644 --- a/sound/soc/qcom/qdsp6/topology.c +++ b/sound/soc/qcom/qdsp6/topology.c @@ -947,7 +947,7 @@ static int audioreach_widget_ready(struct snd_soc_compo= nent *component, static int audioreach_widget_unload(struct snd_soc_component *scomp, struct snd_soc_dobj *dobj) { - struct snd_soc_dapm_widget *w =3D container_of(dobj, struct snd_soc_dapm_= widget, dobj); + const struct snd_soc_dapm_widget *w =3D container_of(dobj, struct snd_soc= _dapm_widget, dobj); struct q6apm *apm =3D dev_get_drvdata(scomp->dev); struct audioreach_container *cont; struct audioreach_module *mod; @@ -1144,10 +1144,10 @@ static int audioreach_get_audio_mixer(struct snd_kc= ontrol *kcontrol, { struct soc_mixer_control *mc =3D (struct soc_mixer_control *)kcontrol->pr= ivate_value; struct snd_soc_dapm_context *dapm =3D snd_soc_dapm_kcontrol_to_dapm(kcont= rol); - struct snd_soc_dapm_widget *dw =3D snd_soc_dapm_kcontrol_to_widget(kcontr= ol); + const struct snd_soc_dapm_widget *dw =3D snd_soc_dapm_kcontrol_to_widget(= kcontrol); struct snd_soc_component *c =3D snd_soc_dapm_to_component(dapm); - struct snd_ar_control *dapm_scontrol =3D dw->dobj.private; - struct snd_ar_control *scontrol =3D mc->dobj.private; + const struct snd_ar_control *dapm_scontrol =3D dw->dobj.private; + const struct snd_ar_control *scontrol =3D mc->dobj.private; struct q6apm *data =3D dev_get_drvdata(c->dev); bool connected; =20 @@ -1167,8 +1167,8 @@ static int audioreach_put_audio_mixer(struct snd_kcon= trol *kcontrol, struct snd_soc_dapm_context *dapm =3D snd_soc_dapm_kcontrol_to_dapm(kcont= rol); struct snd_soc_dapm_widget *dw =3D snd_soc_dapm_kcontrol_to_widget(kcontr= ol); struct snd_soc_component *c =3D snd_soc_dapm_to_component(dapm); - struct snd_ar_control *dapm_scontrol =3D dw->dobj.private; - struct snd_ar_control *scontrol =3D mc->dobj.private; + const struct snd_ar_control *dapm_scontrol =3D dw->dobj.private; + const struct snd_ar_control *scontrol =3D mc->dobj.private; struct q6apm *data =3D dev_get_drvdata(c->dev); =20 if (ucontrol->value.integer.value[0]) { @@ -1206,14 +1206,14 @@ static int audioreach_put_vol_ctrl_audio_mixer(stru= ct snd_kcontrol *kcontrol, static int audioreach_control_load_mix(struct snd_soc_component *scomp, struct snd_ar_control *scontrol, struct snd_kcontrol_new *kc, - struct snd_soc_tplg_ctl_hdr *hdr) + const struct snd_soc_tplg_ctl_hdr *hdr) { - struct snd_soc_tplg_vendor_value_elem *c_elem; - struct snd_soc_tplg_vendor_array *c_array; - struct snd_soc_tplg_mixer_control *mc; + const struct snd_soc_tplg_vendor_value_elem *c_elem; + const struct snd_soc_tplg_vendor_array *c_array; + const struct snd_soc_tplg_mixer_control *mc; int tkn_count =3D 0; =20 - mc =3D container_of(hdr, struct snd_soc_tplg_mixer_control, hdr); + mc =3D container_of_const(hdr, struct snd_soc_tplg_mixer_control, hdr); c_array =3D (struct snd_soc_tplg_vendor_array *)mc->priv.data; =20 c_elem =3D c_array->value; --=20 2.51.0 From nobody Mon Feb 9 10:54:02 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7B10433375D for ; Fri, 19 Dec 2025 11:46:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766144764; cv=none; b=BmootSt/9jFU6By6ZV7eAH4lK4UyfoPZKQtgedvnzGhE+RtNwxiRCLEP8TNxsindF1JMqIYUg+VSkkRL3Fo0UObKwxj12jGNh3/A6uXJjyQUnBwa5U+4OXnwiDDn7sjw0U5VgwrHjTjwpcxjVL0/Uq/IFccowUPXDBwAgKuXQLU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766144764; c=relaxed/simple; bh=1Bo4QM879pRwFDgFh7lx/5RlQhryehFM2iwSnps404Q=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=iQuUtuuykZPhb0kP8XJhpLT5scRPRvYPhQmY9qQqQvzgyBOzya7OL1/rohXj4+tZ4tRMaISngn3GV51hXwQ2DfjPmTKNx1JXXXGqLnf/7+54f8A9H5K9R9os8/ASvEsAnKfhnYw/GgMCue4IN2ahNAz3GMncKh2xoGWLAFmLqN0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=KMTNR4AI; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Fckq6jvd; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="KMTNR4AI"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Fckq6jvd" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BJBO9aV4145756 for ; Fri, 19 Dec 2025 11:46:01 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 1K7dFyjBDDvXEEj7LPdYw1TMzOZ0GDFEUk6AY1+lfKE=; b=KMTNR4AI/HmsWvw4 rRV0Lep32V7gEsl+1wdmGEKHVrT6/drfjO04JBf7p54uyjD55iNzA3PtnHkqmBmx Eu2W+VBKFCzdXRq+DUp7SMQaXyhajcN6vbV8DW9vFGNgeIzvDYgI4k36kw7J0aEI ZfiteX2/Z4FhmzgZw0ZObJNv+G+1UwDlbXvIglwOW61voxp6aLsAv//LQakhw1ad zHcVHFTQ63zlMP9Bf5cV4QzVovvuO8BoHmQkoRqVzabhq6J28Mb/B1rbS40JvzdP /xWRKA/3HlqS5AyV/fsfXjphHc8wHNSdTcgexHIPgh86h9A4V2Zz6FnPo3D3NzqE OgFkvA== Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4b4r2dthjs-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 19 Dec 2025 11:46:01 +0000 (GMT) Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-8804b991a54so51837026d6.2 for ; Fri, 19 Dec 2025 03:46:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1766144761; x=1766749561; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=1K7dFyjBDDvXEEj7LPdYw1TMzOZ0GDFEUk6AY1+lfKE=; b=Fckq6jvdsVOZrOaySPWymhpGkWu/bARXvhgIZrCXEMZPgPgnsHfPTfg75HTLjviH4X md2i673hxW9clDQgwksAEFMbkv3+BOuAUc2r1ILmvk+afhFsIYFzRiZ2n0+4VBqMEbPx WULTXuFRx7l106Fu3Cr5m00OheQ4K6bL6LpTuFjFO8z+DRzY1kz0hfV1wC3Npo85trJE dPjrc1QlWSGtNdnM/eXEyRoZrMmLkil0kF/0RQd0Gd4CJ5wbvL4j9yPDM/3WEptYzH9y qvM+ElbuUlK2iWtqkCxYtrRjDaL+xiAN4YLdVRVwiRPMt0yJvpOfz7PRnwgqrqzfvlhM 0BYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766144761; x=1766749561; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=1K7dFyjBDDvXEEj7LPdYw1TMzOZ0GDFEUk6AY1+lfKE=; b=Fo0oBxySi5hiI+h31dJF/H0VajJINIrUOLGy0GNe4zFGES+FhBwgUo2V+BNbM9YOfH AX1mFbFVIIoGay0NdDjCy+kpPmkWUvdYLrnclScU9750eGK4Xm4kcddFUmaz3gQvwSPs aJ/kvnmU0Ydb2tP2J+RF//07dROuuDUBUapkBlrdCJcIbBTMaHlrnRxPUyS5XCgJ1VnP TAkXy9UpHlAXaPlw6tuCKR4Xj+k34WeFx8zy0+NFDYcUUgs+TE9Y+dBH9WewiW5+qkib A4bli11JGRHto8Sor+o6dyBeFWbWmAKE2Or8ZbnSpefyR188gPpgfMkwJd2Kwr3ykjrd e/uw== X-Forwarded-Encrypted: i=1; AJvYcCVvyx84URuhdhfMT/JuDjIMhEzKryrF6cVrMyw+gkBah2YK5GNbkPHM75BY0BqtAug3+mPW2EAeIODudVs=@vger.kernel.org X-Gm-Message-State: AOJu0YwYwjHtwSsdf8u1uCwwSNAVrImVmIdJ8iLPDeMmzDJ1KELpfml/ uUgTLsZU01x7G2GEfCHNf3BuLyiBq7odBMwUz4AlF0oTQAcye+9O0UW8/iMT9vJ4e5UTmAIdZxQ 3uafG5GCvkYRajm61sGAy6dmRhXd0FZtg5/pLJ3rYOojRwR9GLrd0+D8EeFXQh7UUPk4= X-Gm-Gg: AY/fxX5fUB9QjhlPQbSiyIrzeK5VmtS4LRtag6N42kW6G07DzYkVrtkOJm5FsYMVJl2 zpH+cROUHZ8WkD6f4LGrMjtl327gfRKeoCx6PjaEPNAwyMycegsnzugy9yoOA50BtycZjAYC6VQ S0mMcDPzWcKhWbKZrwmk7JxxdJPzYUPfbYOR6voKLKETvB7Pz/3mp/pxI51ot8xKDC5r0K4QoBV gG8vQFIppXhHJrc5MnI4zz+c7XuHJGdr1iKj7ixBy7AwMSE+CybXxjJXqCythq+k4qPBPQKG7NV LM52UMCuRUE5oGp3PxV9Az/hX2tRtaO/i0t1NpET8cCUUrSTffoJI10EyYKBBfm16upFth9P8kV /B3veSs+IF+Qykqt9IJqFNCKX6NKsQthF6J+9uQZRry9deU2mAJh2Qj6wZZts6GL2K3RU X-Received: by 2002:a05:622a:4c0f:b0:4ee:2312:6059 with SMTP id d75a77b69052e-4f4abcd267cmr32695841cf.19.1766144761018; Fri, 19 Dec 2025 03:46:01 -0800 (PST) X-Google-Smtp-Source: AGHT+IHq4LdHooVKYVzQ6LVSsPFMLwmvR9seuLMTX398oj3vjYDv9c5OmKhrHRlmoobw5zM3SDyg7Q== X-Received: by 2002:a05:622a:4c0f:b0:4ee:2312:6059 with SMTP id d75a77b69052e-4f4abcd267cmr32695491cf.19.1766144760507; Fri, 19 Dec 2025 03:46:00 -0800 (PST) Received: from [127.0.1.1] (83.31.98.88.ipv4.supernova.orange.pl. [83.31.98.88]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-64b91599844sm1974465a12.25.2025.12.19.03.45.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Dec 2025 03:45:59 -0800 (PST) From: Krzysztof Kozlowski Date: Fri, 19 Dec 2025 12:45:47 +0100 Subject: [PATCH v2 4/5] ASoC: qcom: topology: Constify pointed snd_soc_tplg_dapm_widget Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251219-b4-container-of-const-asoc-qcom-v2-4-05fd2ecc06fe@oss.qualcomm.com> References: <20251219-b4-container-of-const-asoc-qcom-v2-0-05fd2ecc06fe@oss.qualcomm.com> In-Reply-To: <20251219-b4-container-of-const-asoc-qcom-v2-0-05fd2ecc06fe@oss.qualcomm.com> To: Srinivas Kandagatla , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=3065; i=krzysztof.kozlowski@oss.qualcomm.com; h=from:subject:message-id; bh=1Bo4QM879pRwFDgFh7lx/5RlQhryehFM2iwSnps404Q=; b=kA0DAAoBwTdm5oaLg9cByyZiAGlFOu6i7h0rXF1H25iffhJtU3DDNkvMHoWc+BEx5Bpo/70Aa okCMwQAAQoAHRYhBN3SYig9ERsjO264qME3ZuaGi4PXBQJpRTruAAoJEME3ZuaGi4PXYMoP/iz/ Js9GahNdaQBoHQ0hm2mdoUkQWp+npjkTHJeIrF+trXHEBpHB5j2AJoPISdU4r4UU3oveXRyUbWH ks1pL1nn/Lw89/r94VY6oWurapkUs+Qc2NhH87FS4ovQ7MBpNxVePkPMDszMd68qIhOr6Qyopom yC0xVZhBx2Ey4qVMxrCrdo43k0jTPAZkzRxRheGzrHbxZyNznbErM/uu2LwMVy/ax+bqD2o4oOP gTZrIWMU7U+tzoe71dUWNI5LqK9Sq6Y9FnzfUchCjj4F5dFexklWpEuL+I3e7ywapEPHx9GJoea Lj5V3MJI7o9deOZj3xRovyNea472Wc6U2cfqve3I5qmEUbAUAx5iutor4EFa3JUFgKId6wbxeZa 3e04KnujDlNctOrLInq+cqw64iC2rvcjjf9swJH8VOM2q7XdXosZlxAzp2/OeZ6out8XNll+Sv+ nonOT/49TRY6hT7hHJxEzMX2jnjfLKZ4iA0a2z4ZqYI5FiXgzUsHH0ocJP/ry10mhjnsxCVG6IG /DqrBLiGpSsSKZqh4mKvDeker0SHEMR/2YL1v2bPHmo6qkbOglpGMOm4G8W7CDtg63Y7vlOZOK3 2SlPxsuTtYphjZQnmjws0pp5eL8kp8It99ZkYDe/HyDmVHs+9MY8DvzVJnvJWMwaeCmBynM2I8n sqJgJ X-Developer-Key: i=krzysztof.kozlowski@oss.qualcomm.com; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B X-Proofpoint-ORIG-GUID: NLcUOUIKiON95KLwQwGIVfQCaXkuV4BL X-Authority-Analysis: v=2.4 cv=A7ph/qWG c=1 sm=1 tr=0 ts=69453af9 cx=c_pps a=oc9J++0uMp73DTRD5QyR2A==:117 a=qe4J/qXhiWkb1JZGYKbLYA==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=LmhyXBtnI0SQ4MprW8YA:9 a=QEXdDO2ut3YA:10 a=iYH6xdkBrDN1Jqds4HTS:22 X-Proofpoint-GUID: NLcUOUIKiON95KLwQwGIVfQCaXkuV4BL X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjE5MDA5NyBTYWx0ZWRfXyy/rp7I/7XXP SOYNxsY/QEsowB0LNaJAQOBvwEM7ufkqmsvU8UXVtK+YSOWuHYHjB8HXdyUAhTTU6gmuBsXIWXq 7Q5RBVO256ACjIpnnsQJlOkYz7msv3cmWoaOT3vxQ8psCvhgwr00NY0/G+v8IshGTT2u+vrvXVN JkcBQdlrx5VfVjOiWOeGdss6e+Kr7wUYrogD5Q5H2rZZWE/jKOLcWkf9t7+EzMMqzm0/icpBo9m HFLSOfOb1V2sBWgjevEVAhP0njKuL10TYmqBl17t8irRS66rJxXqVjmP1INEUY5qa+bGAfuwtrk p4A8Tf2ylkm/VTOsHdGOErQCZyxaGDvQvnE1jR8hvtqtJUxQq54pwcnFfT1Zx+OrA30yieiwTk/ jav8oTM2YlWdaPdQvx/HTOGqWRTFZsGvSz9J+NP2TiwwgifutObXXplQvJqoFwVHbMSJVqiezRZ D0OSiA5hdPMi6qR9MCg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-19_03,2025-12-17_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 priorityscore=1501 lowpriorityscore=0 impostorscore=0 spamscore=0 phishscore=0 suspectscore=0 malwarescore=0 clxscore=1015 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2512190097 Several functions in topology.c receive pointers to 'struct snd_soc_tplg_dapm_widget' and do not modify their contents. Constify the pointers for self-explanatory code (pointed memory is not modified by the function) and a bit safer code. Signed-off-by: Krzysztof Kozlowski --- sound/soc/qcom/qdsp6/topology.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/sound/soc/qcom/qdsp6/topology.c b/sound/soc/qcom/qdsp6/topolog= y.c index fbba543bd976..2e71eaa90441 100644 --- a/sound/soc/qcom/qdsp6/topology.c +++ b/sound/soc/qcom/qdsp6/topology.c @@ -590,7 +590,7 @@ static struct audioreach_module *audioreach_parse_commo= n_tokens(struct q6apm *ap =20 static int audioreach_widget_load_module_common(struct snd_soc_component *= component, int index, struct snd_soc_dapm_widget *w, - struct snd_soc_tplg_dapm_widget *tplg_w) + const struct snd_soc_tplg_dapm_widget *tplg_w) { struct q6apm *apm =3D dev_get_drvdata(component->dev); struct audioreach_container *cont; @@ -620,7 +620,7 @@ static int audioreach_widget_load_module_common(struct = snd_soc_component *compon =20 static int audioreach_widget_load_enc_dec_cnv(struct snd_soc_component *co= mponent, int index, struct snd_soc_dapm_widget *w, - struct snd_soc_tplg_dapm_widget *tplg_w) + const struct snd_soc_tplg_dapm_widget *tplg_w) { const struct snd_soc_tplg_vendor_value_elem *mod_elem; const struct snd_soc_tplg_vendor_array *mod_array; @@ -778,7 +778,7 @@ static int audioreach_widget_dp_module_load(struct audi= oreach_module *mod, =20 static int audioreach_widget_load_buffer(struct snd_soc_component *compone= nt, int index, struct snd_soc_dapm_widget *w, - struct snd_soc_tplg_dapm_widget *tplg_w) + const struct snd_soc_tplg_dapm_widget *tplg_w) { const struct snd_soc_tplg_vendor_array *mod_array; struct audioreach_module *mod; @@ -818,10 +818,10 @@ static int audioreach_widget_load_buffer(struct snd_s= oc_component *component, =20 static int audioreach_widget_load_mixer(struct snd_soc_component *componen= t, int index, struct snd_soc_dapm_widget *w, - struct snd_soc_tplg_dapm_widget *tplg_w) + const struct snd_soc_tplg_dapm_widget *tplg_w) { - struct snd_soc_tplg_vendor_value_elem *w_elem; - struct snd_soc_tplg_vendor_array *w_array; + const struct snd_soc_tplg_vendor_value_elem *w_elem; + const struct snd_soc_tplg_vendor_array *w_array; struct snd_ar_control *scontrol; struct q6apm *data =3D dev_get_drvdata(component->dev); struct snd_soc_dobj *dobj; @@ -886,7 +886,7 @@ static const struct snd_soc_tplg_widget_events audiorea= ch_widget_ops[] =3D { =20 static int audioreach_widget_load_pga(struct snd_soc_component *component, int index, struct snd_soc_dapm_widget *w, - struct snd_soc_tplg_dapm_widget *tplg_w) + const struct snd_soc_tplg_dapm_widget *tplg_w) { struct audioreach_module *mod; struct snd_soc_dobj *dobj; --=20 2.51.0 From nobody Mon Feb 9 10:54:02 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 51219334C1F for ; Fri, 19 Dec 2025 11:46:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766144766; cv=none; b=jr+MbN/UH70M7h1Qm30mbSA5YeO2xGLDHakWlEp8KfeCoGvS5kXkxUCthFNZaptz2N82DyoyQrkmrJc0I7HmcN4FtUdPaR9Hp/LbA2c5GWtJQazFKfPjeQYxJGc7ZlgQqJ36se17BFg1YU9TffCiu+eA7XRItT+KDcPdGWGUsUU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766144766; c=relaxed/simple; bh=51m58wrUvNztZ8MT0/cSt6uzg7b+F+0zxCibYMTfOi0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=bCyHg7VRfaoBZRzsnZ2/ysA2Gp+dbkxqjK65KQa1UsgZvtA+dK+8xwB+2wID1petwYNucXmQ8qjFiXotC9WS0fq8MVtf31ZwX2/in9GQ0Cn/4dy3oXcIHw8E+VK5dh3+cX4qLpf1BfJjzjdPmFCi4176QNqfAjSPfv3F1vjjcPU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=EdfaNgmm; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=C1LNA7re; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="EdfaNgmm"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="C1LNA7re" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BJBSBUS091968 for ; Fri, 19 Dec 2025 11:46:03 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= giYCXInr3PCxoTXokn2gBk5kNRjDWGpv297jdyI161g=; b=EdfaNgmm84N69zv0 5qkhCNsOWZYB6JEb0uSlzqzcOqkQ7rDijP74I3M9PzImGM95ZM3izUWy9HSpLSgP UfkkGkHC9UEt+S94SJrrWSX8GL4L7eKacyptBn8lhC1ixf155y6I8C/z2A6n4XdZ OdT6PGLfQMDIdxSdbj58h4zk3u/T7ZGw+rq0CIyaGHeSEyz3DrBMRHV3v7YIZf2/ Y3gWKdD5wR7bFCaeeKIZ1Bc7mYV/0R+tPSkUeqcJxjc107JZokj+4uK1ncthpKQd 0uAxCtm5jWFqqGgWB0Xyon5L2t1bKM2ugWMkyHYrq1zZy0oKyP5ROXpCwhwr231l cVV8mQ== Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4b4r2eagun-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 19 Dec 2025 11:46:03 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-4ee09211413so37787901cf.2 for ; Fri, 19 Dec 2025 03:46:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1766144762; x=1766749562; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=giYCXInr3PCxoTXokn2gBk5kNRjDWGpv297jdyI161g=; b=C1LNA7rebobLEmgBh3LrxNARg8SdUhjbH3Js1jenXcjOoEeD2OKPkMXOfC9gHhp5OK Pf/A6YnkrRhfuLGzBcX2LCsw+JtF1y74kAh5W0D+OGMTawSAQhukAnKFpjkS1KSF2TGK Oi8W2+rT6+G+ai8mTXYJG+5lKsUbU6QMiw9TNjAY/Yl819/tYEOWeMiZGeeK2/aIkcpr jnVSFNcAbyJ8/+hQCm9MogGSjD6sKcyHjx7ZXsmEtIABinxYGgnggYhveEtRgPfV1I8R NzT639t3aJfQYwtoWq9fSI/NYZ46sEADO9BbA4hoDEht6t0yPdFsW2PpwkI5tZau76eY Lwpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766144762; x=1766749562; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=giYCXInr3PCxoTXokn2gBk5kNRjDWGpv297jdyI161g=; b=nT5I+J4+ikYZKQkYlIEn2j1TxULVxJXgzUHsTfbROliPcnOwG6D8Jh6J81/unpjrlH eyWWPxrBj+F8wDTqoYexbXkS4QOskBgK1iyMmMgd9wHz/fna8n73McpgCOkP4cM9lsU8 pJhTP8SlPR1sh6qhLBlo3fbWlc4FxOmio58Nd9B3qooR3F/2msbtikkedtBOJJE94HxS lx9G0Q628YdH5al6taKThEbnqW5VloyQguqn+wqVgYCcL5/fU0+pqMTz6RqOASYMD9YN tNwV7CdBItIxO7+jI6JNBZ0TWflYAV/MabXx/EYZdtgjjtmS36ncIkfukvrClwcQ3lQL 5wwA== X-Forwarded-Encrypted: i=1; AJvYcCV+LSXijFXWnmtS7q/1wPjoB2dmfc05e+Iaca5wcPcg8Xq3S5iczQIUhCeRcHQP+QQ8Z7XTFaji6JJb7BY=@vger.kernel.org X-Gm-Message-State: AOJu0YxNHlTs0noBjlw19D/gdUESduPzub5CbbAd6Fh8+I8DeH3QRCGf O63qWo7+m0tUvgS6yo2BOL+d1pn8smXc2o04NnERRcmNfuBC5aIDAYXyb/6S3j4dnmUbau/1vBW /mbfSu2IG+o4HevUNmJa2NLYIPbiWv2PW7HQ21bf/FsOcDR0gFx6YO07/WKEGpZOZ40s= X-Gm-Gg: AY/fxX4Bi3+lsYD8UE9yTC/5e82qZal+R1AABn7PzlpjgV7NCR6XkMFau087e7aZ2sI xwnsRDJgIUvEtNSPK4UcDEFzQYeZfPoGnq6RdWTxX3Wghj0bhnChbpplrv8TJOXXAqDo6TDTPdF XWn95/h78Xx/wx3cI+KedJWZVdCMk1zU5zpWa6wH/KSqHTYT0PPb76p30Pjd5PB0enWWXGuSo7A uIKSBy7Q8JOTKWnw6AFrnRliIKlnJeoZwuHauyqTzli9Q38+RyC9UKi7IsciPe33ebfNsHOq4Pl th6vjW7Qol51LdbOd8MM+jVj2tSo+jbdq9837ErX7pIKLJvZ2p2+QajpSauLDwdIEAKYxhsJ4il eu3VnjWXkOzB94bIsAOSlQJIF+MW5Qo3DaPeF5D+IfmCP1UmKhR+cZpyDZz50CVEvD3PT X-Received: by 2002:a05:622a:5e11:b0:4ee:4a3a:bd00 with SMTP id d75a77b69052e-4f4abdc3b6cmr32569431cf.71.1766144762574; Fri, 19 Dec 2025 03:46:02 -0800 (PST) X-Google-Smtp-Source: AGHT+IHbh2GZ/6GRk+auDD2Q/R/Vd9bYqskXY/6+cE24kTZoZrCZOpa/TZKsOpMSMs/b+/9zZN0wNw== X-Received: by 2002:a05:622a:5e11:b0:4ee:4a3a:bd00 with SMTP id d75a77b69052e-4f4abdc3b6cmr32569081cf.71.1766144762100; Fri, 19 Dec 2025 03:46:02 -0800 (PST) Received: from [127.0.1.1] (83.31.98.88.ipv4.supernova.orange.pl. [83.31.98.88]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-64b91599844sm1974465a12.25.2025.12.19.03.46.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Dec 2025 03:46:01 -0800 (PST) From: Krzysztof Kozlowski Date: Fri, 19 Dec 2025 12:45:48 +0100 Subject: [PATCH v2 5/5] ASoC: qcom: audioreach: Constify function arguments Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251219-b4-container-of-const-asoc-qcom-v2-5-05fd2ecc06fe@oss.qualcomm.com> References: <20251219-b4-container-of-const-asoc-qcom-v2-0-05fd2ecc06fe@oss.qualcomm.com> In-Reply-To: <20251219-b4-container-of-const-asoc-qcom-v2-0-05fd2ecc06fe@oss.qualcomm.com> To: Srinivas Kandagatla , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=14150; i=krzysztof.kozlowski@oss.qualcomm.com; h=from:subject:message-id; bh=51m58wrUvNztZ8MT0/cSt6uzg7b+F+0zxCibYMTfOi0=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBpRTruMTzgiyGeDPofJoqPBy18Sf/2CwpjKnwYg mJyUpTYEdaJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCaUU67gAKCRDBN2bmhouD 13XzD/0T7v+Inrhk5oIiXcafOI4AptIrxeR8gdl7VcbXFTAY5WiML6UOGwfJ7j2JaI8r4ru7liI RQQXWKqTQVRQaNvnKlxfBqAr6rVZRbEB4Fu//WTarGiF9fvWbswuYbYzNyiULxgtRO/JLEzWVGM P398ErOgn4+rIowEfzkfztMdLmq+FOZsyLPLoTfS2iDIYm+pUsh6khteitZ4H3gKHNnYiHfCyRD 8XnLfAVk4KiZeo08uNS+vsb0HBgXNXAkIB3wSckSUZvBRgRsJcWlkgJv2d6xdR6WbPHYnQSZwts 6XsS/u5+ORFfpwd14Q00JfiDAN0cCghDt4LGq8xqOtDvqLZn2mb02/IVzUue3kn7iyk+iCFHRa1 jLqQNPTJqFGavF5/0sWDRTiDSaT1wvl9dPbM+yjXkMMBtof+D999xiM+9OxsE/ydpJKvuOXYZP4 Wk6t4+d/Ek7CbksgF1BDT1rKB0tWnc476f4Ga5mUP/So+EvfdGuhUW/D3WO7Zo9wWQdnHmKXkrN zYQTJFJgKvHppAVqc7UCZCb6LG10kkFso6A4AqqTjVTFniCxrOpb3QJWBJrfqnIGm+8bP1ZpPuI 73873XtdruGulNMSzH2eXfUMFIvYCwIaLyVtW7BQXWjOvXwx7UCP4IsS3u+BoyjxEAwaBXumFRJ OA2mAw8Wl3l+ByA== X-Developer-Key: i=krzysztof.kozlowski@oss.qualcomm.com; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjE5MDA5NyBTYWx0ZWRfX49D4CWDBT2fh QTGzM/XSKqrBK2kJagbbQktQ9s41vuQeVHzZN+SW6lq7i2evrwR1xjybDbWysgJmSGE/lW1bAYS i3YHDIzEOsMCXRhntduClLsrdmXXLhRsG7I+oWQnbtBVpaKVwSpbeky0sIyf2tudlUbJ+gzSdLK YYcSeO7SiELMRebKtnqkCjwo6MaJVFoaO35Ww45jWCAXWgR9dvka5BV0V+oIWxys3LUHlIoxiWE DXbjhnbiOZcWjZ/QVHKgXI8USln7i6l/5n8YREbChFQP+gVyzE4q0votAqPpq1fHz+EI5UQDzek hrqseoxqVtg4OoEF21RQ3BZDrQLNL+GxvB47Bx7YoXbCEv2Tnp1nztoszl+yKolTu3A0WAXN/k+ VYcuC2lHS9SUXtSOcL76POiVMfwl+ftyDoRKyWeOg5LkDAm0I6qiAa2Xxv3YiSRgNa3Eyd2t2yP dImrAu+j5yqJ+gJI1KQ== X-Authority-Analysis: v=2.4 cv=W+c1lBWk c=1 sm=1 tr=0 ts=69453afb cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=qe4J/qXhiWkb1JZGYKbLYA==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=VJuunSxf47HV0C6rKqEA:9 a=QEXdDO2ut3YA:10 a=uxP6HrT_eTzRwkO_Te1X:22 X-Proofpoint-ORIG-GUID: o_i4b-dV3ZPbECIYl0tnYMAqF8qGS7We X-Proofpoint-GUID: o_i4b-dV3ZPbECIYl0tnYMAqF8qGS7We X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-19_03,2025-12-17_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 lowpriorityscore=0 suspectscore=0 clxscore=1015 bulkscore=0 impostorscore=0 spamscore=0 adultscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2512190097 Several functions receive pointers to parsed Audioreach topology (e.g. 'struct audioreach_container', 'struct audioreach_module') and they do not modify their contents, but copy their data to send to the ADSP. Constify the pointers for self-explanatory code (pointed memory is not modified by the function) and a bit safer code. Signed-off-by: Krzysztof Kozlowski --- sound/soc/qcom/qdsp6/audioreach.c | 87 +++++++++++++++++++++--------------= ---- sound/soc/qcom/qdsp6/audioreach.h | 16 +++---- 2 files changed, 57 insertions(+), 46 deletions(-) diff --git a/sound/soc/qcom/qdsp6/audioreach.c b/sound/soc/qcom/qdsp6/audio= reach.c index b28451558974..241c3b4479c6 100644 --- a/sound/soc/qcom/qdsp6/audioreach.c +++ b/sound/soc/qcom/qdsp6/audioreach.c @@ -309,7 +309,7 @@ void audioreach_set_default_channel_mapping(u8 *ch_map,= int num_channels) EXPORT_SYMBOL_GPL(audioreach_set_default_channel_mapping); =20 static void apm_populate_container_config(struct apm_container_obj *cfg, - struct audioreach_container *cont) + const struct audioreach_container *cont) { =20 /* Container Config */ @@ -339,7 +339,7 @@ static void apm_populate_container_config(struct apm_co= ntainer_obj *cfg, } =20 static void apm_populate_sub_graph_config(struct apm_sub_graph_data *cfg, - struct audioreach_sub_graph *sg) + const struct audioreach_sub_graph *sg) { cfg->sub_graph_cfg.sub_graph_id =3D sg->sub_graph_id; cfg->sub_graph_cfg.num_sub_graph_prop =3D APM_SUB_GRAPH_CFG_NPROP; @@ -361,7 +361,7 @@ static void apm_populate_sub_graph_config(struct apm_su= b_graph_data *cfg, } =20 static void apm_populate_module_prop_obj(struct apm_mod_prop_obj *obj, - struct audioreach_module *module) + const struct audioreach_module *module) { =20 obj->instance_id =3D module->instance_id; @@ -373,7 +373,7 @@ static void apm_populate_module_prop_obj(struct apm_mod= _prop_obj *obj, } =20 static void apm_populate_module_list_obj(struct apm_mod_list_obj *obj, - struct audioreach_container *container, + const struct audioreach_container *container, int sub_graph_id) { struct audioreach_module *module; @@ -390,9 +390,10 @@ static void apm_populate_module_list_obj(struct apm_mo= d_list_obj *obj, } } =20 -static void audioreach_populate_graph(struct q6apm *apm, struct audioreach= _graph_info *info, +static void audioreach_populate_graph(struct q6apm *apm, + const struct audioreach_graph_info *info, struct apm_graph_open_params *open, - struct list_head *sg_list, + const struct list_head *sg_list, int num_sub_graphs) { struct apm_mod_conn_list_params *mc_data =3D open->mod_conn_list_data; @@ -464,7 +465,8 @@ static void audioreach_populate_graph(struct q6apm *apm= , struct audioreach_graph } } =20 -void *audioreach_alloc_graph_pkt(struct q6apm *apm, struct audioreach_grap= h_info *info) +void *audioreach_alloc_graph_pkt(struct q6apm *apm, + const struct audioreach_graph_info *info) { int payload_size, sg_sz, cont_sz, ml_sz, mp_sz, mc_sz; struct apm_module_param_data *param_data; @@ -477,7 +479,7 @@ void *audioreach_alloc_graph_pkt(struct q6apm *apm, str= uct audioreach_graph_info struct audioreach_module *module; struct audioreach_sub_graph *sgs; struct apm_mod_list_obj *mlobj; - struct list_head *sg_list; + const struct list_head *sg_list; int num_connections =3D 0; int num_containers =3D 0; int num_sub_graphs =3D 0; @@ -630,8 +632,8 @@ int audioreach_graph_send_cmd_sync(struct q6apm_graph *= graph, struct gpr_pkt *pk EXPORT_SYMBOL_GPL(audioreach_graph_send_cmd_sync); =20 static int audioreach_display_port_set_media_format(struct q6apm_graph *gr= aph, - struct audioreach_module *module, - struct audioreach_module_config *cfg) + const struct audioreach_module *module, + const struct audioreach_module_config *cfg) { struct apm_display_port_module_intf_cfg *intf_cfg; struct apm_module_frame_size_factor_cfg *fs_cfg; @@ -687,8 +689,8 @@ static int audioreach_display_port_set_media_format(str= uct q6apm_graph *graph, =20 /* LPASS Codec DMA port Module Media Format Setup */ static int audioreach_codec_dma_set_media_format(struct q6apm_graph *graph, - struct audioreach_module *module, - struct audioreach_module_config *cfg) + const struct audioreach_module *module, + const struct audioreach_module_config *cfg) { struct apm_codec_dma_module_intf_cfg *intf_cfg; struct apm_module_frame_size_factor_cfg *fs_cfg; @@ -753,7 +755,8 @@ static int audioreach_codec_dma_set_media_format(struct= q6apm_graph *graph, return q6apm_send_cmd_sync(graph->apm, pkt, 0); } =20 -int audioreach_send_u32_param(struct q6apm_graph *graph, struct audioreach= _module *module, +int audioreach_send_u32_param(struct q6apm_graph *graph, + const struct audioreach_module *module, uint32_t param_id, uint32_t param_val) { struct apm_module_param_data *param_data; @@ -782,36 +785,37 @@ int audioreach_send_u32_param(struct q6apm_graph *gra= ph, struct audioreach_modul EXPORT_SYMBOL_GPL(audioreach_send_u32_param); =20 static int audioreach_sal_limiter_enable(struct q6apm_graph *graph, - struct audioreach_module *module, bool enable) + const struct audioreach_module *module, + bool enable) { return audioreach_send_u32_param(graph, module, PARAM_ID_SAL_LIMITER_ENAB= LE, enable); } =20 static int audioreach_sal_set_media_format(struct q6apm_graph *graph, - struct audioreach_module *module, - struct audioreach_module_config *cfg) + const struct audioreach_module *module, + const struct audioreach_module_config *cfg) { return audioreach_send_u32_param(graph, module, PARAM_ID_SAL_OUTPUT_CFG, = cfg->bit_width); } =20 static int audioreach_module_enable(struct q6apm_graph *graph, - struct audioreach_module *module, + const struct audioreach_module *module, bool enable) { return audioreach_send_u32_param(graph, module, PARAM_ID_MODULE_ENABLE, e= nable); } =20 static int audioreach_gapless_set_media_format(struct q6apm_graph *graph, - struct audioreach_module *module, - struct audioreach_module_config *cfg) + const struct audioreach_module *module, + const struct audioreach_module_config *cfg) { return audioreach_send_u32_param(graph, module, PARAM_ID_EARLY_EOS_DELAY, EARLY_EOS_DELAY_MS); } =20 static int audioreach_set_module_config(struct q6apm_graph *graph, - struct audioreach_module *module, - struct audioreach_module_config *cfg) + const struct audioreach_module *module, + const struct audioreach_module_config *cfg) { int size =3D le32_to_cpu(module->data->size); void *p; @@ -828,8 +832,8 @@ static int audioreach_set_module_config(struct q6apm_gr= aph *graph, } =20 static int audioreach_mfc_set_media_format(struct q6apm_graph *graph, - struct audioreach_module *module, - struct audioreach_module_config *cfg) + const struct audioreach_module *module, + const struct audioreach_module_config *cfg) { struct apm_module_param_data *param_data; struct param_id_mfc_media_format *media_format; @@ -863,7 +867,8 @@ static int audioreach_mfc_set_media_format(struct q6apm= _graph *graph, } =20 static int audioreach_set_compr_media_format(struct media_format *media_fm= t_hdr, - void *p, struct audioreach_module_config *mcfg) + void *p, + const struct audioreach_module_config *mcfg) { struct payload_media_fmt_aac_t *aac_cfg; struct payload_media_fmt_pcm *mp3_cfg; @@ -944,7 +949,8 @@ static int audioreach_set_compr_media_format(struct med= ia_format *media_fmt_hdr, return 0; } =20 -int audioreach_compr_set_param(struct q6apm_graph *graph, struct audioreac= h_module_config *mcfg) +int audioreach_compr_set_param(struct q6apm_graph *graph, + const struct audioreach_module_config *mcfg) { struct media_format *header; int rc; @@ -969,8 +975,8 @@ int audioreach_compr_set_param(struct q6apm_graph *grap= h, struct audioreach_modu EXPORT_SYMBOL_GPL(audioreach_compr_set_param); =20 static int audioreach_i2s_set_media_format(struct q6apm_graph *graph, - struct audioreach_module *module, - struct audioreach_module_config *cfg) + const struct audioreach_module *module, + const struct audioreach_module_config *cfg) { struct apm_module_frame_size_factor_cfg *fs_cfg; struct apm_module_param_data *param_data; @@ -1037,7 +1043,7 @@ static int audioreach_i2s_set_media_format(struct q6a= pm_graph *graph, } =20 static int audioreach_logging_set_media_format(struct q6apm_graph *graph, - struct audioreach_module *module) + const struct audioreach_module *module) { struct apm_module_param_data *param_data; struct data_logging_config *cfg; @@ -1066,8 +1072,8 @@ static int audioreach_logging_set_media_format(struct= q6apm_graph *graph, } =20 static int audioreach_pcm_set_media_format(struct q6apm_graph *graph, - struct audioreach_module *module, - struct audioreach_module_config *mcfg) + const struct audioreach_module *module, + const struct audioreach_module_config *mcfg) { struct payload_pcm_output_format_cfg *media_cfg; uint32_t num_channels =3D mcfg->num_channels; @@ -1113,8 +1119,8 @@ static int audioreach_pcm_set_media_format(struct q6a= pm_graph *graph, } =20 static int audioreach_shmem_set_media_format(struct q6apm_graph *graph, - struct audioreach_module *module, - struct audioreach_module_config *mcfg) + const struct audioreach_module *module, + const struct audioreach_module_config *mcfg) { uint32_t num_channels =3D mcfg->num_channels; struct apm_module_param_data *param_data; @@ -1170,7 +1176,8 @@ static int audioreach_shmem_set_media_format(struct q= 6apm_graph *graph, return audioreach_graph_send_cmd_sync(graph, pkt, 0); } =20 -int audioreach_gain_set_vol_ctrl(struct q6apm *apm, struct audioreach_modu= le *module, int vol) +int audioreach_gain_set_vol_ctrl(struct q6apm *apm, + const struct audioreach_module *module, int vol) { struct param_id_vol_ctrl_master_gain *cfg; struct apm_module_param_data *param_data; @@ -1195,7 +1202,8 @@ int audioreach_gain_set_vol_ctrl(struct q6apm *apm, s= truct audioreach_module *mo } EXPORT_SYMBOL_GPL(audioreach_gain_set_vol_ctrl); =20 -static int audioreach_gain_set(struct q6apm_graph *graph, struct audioreac= h_module *module) +static int audioreach_gain_set(struct q6apm_graph *graph, + const struct audioreach_module *module) { struct apm_module_param_data *param_data; struct apm_gain_module_cfg *cfg; @@ -1218,7 +1226,7 @@ static int audioreach_gain_set(struct q6apm_graph *gr= aph, struct audioreach_modu } =20 static int audioreach_speaker_protection(struct q6apm_graph *graph, - struct audioreach_module *module, + const struct audioreach_module *module, uint32_t operation_mode) { return audioreach_send_u32_param(graph, module, PARAM_ID_SP_OP_MODE, @@ -1226,8 +1234,8 @@ static int audioreach_speaker_protection(struct q6apm= _graph *graph, } =20 static int audioreach_speaker_protection_vi(struct q6apm_graph *graph, - struct audioreach_module *module, - struct audioreach_module_config *mcfg) + const struct audioreach_module *module, + const struct audioreach_module_config *mcfg) { u32 num_channels =3D mcfg->num_channels; struct apm_module_sp_vi_op_mode_cfg *op_cfg; @@ -1304,8 +1312,9 @@ static int audioreach_speaker_protection_vi(struct q6= apm_graph *graph, return rc; } =20 -int audioreach_set_media_format(struct q6apm_graph *graph, struct audiorea= ch_module *module, - struct audioreach_module_config *cfg) +int audioreach_set_media_format(struct q6apm_graph *graph, + const struct audioreach_module *module, + const struct audioreach_module_config *cfg) { int rc; =20 diff --git a/sound/soc/qcom/qdsp6/audioreach.h b/sound/soc/qcom/qdsp6/audio= reach.h index 03cfd32f1d0c..89f172aab8c0 100644 --- a/sound/soc/qcom/qdsp6/audioreach.h +++ b/sound/soc/qcom/qdsp6/audioreach.h @@ -831,8 +831,8 @@ void *audioreach_alloc_apm_pkt(int pkt_size, uint32_t o= pcode, uint32_t token, void *audioreach_alloc_pkt(int payload_size, uint32_t opcode, uint32_t token, uint32_t src_port, uint32_t dest_port); -void *audioreach_alloc_graph_pkt(struct q6apm *apm, struct audioreach_grap= h_info - *info); +void *audioreach_alloc_graph_pkt(struct q6apm *apm, + const struct audioreach_graph_info *info); /* Topology specific */ int audioreach_tplg_init(struct snd_soc_component *component); =20 @@ -848,13 +848,15 @@ int audioreach_send_cmd_sync(struct device *dev, gpr_= device_t *gdev, struct gpr_ int audioreach_graph_send_cmd_sync(struct q6apm_graph *graph, struct gpr_p= kt *pkt, uint32_t rsp_opcode); int audioreach_set_media_format(struct q6apm_graph *graph, - struct audioreach_module *module, - struct audioreach_module_config *cfg); + const struct audioreach_module *module, + const struct audioreach_module_config *cfg); int audioreach_shared_memory_send_eos(struct q6apm_graph *graph); int audioreach_gain_set_vol_ctrl(struct q6apm *apm, - struct audioreach_module *module, int vol); -int audioreach_send_u32_param(struct q6apm_graph *graph, struct audioreach= _module *module, + const struct audioreach_module *module, int vol); +int audioreach_send_u32_param(struct q6apm_graph *graph, + const struct audioreach_module *module, uint32_t param_id, uint32_t param_val); -int audioreach_compr_set_param(struct q6apm_graph *graph, struct audioreac= h_module_config *mcfg); +int audioreach_compr_set_param(struct q6apm_graph *graph, + const struct audioreach_module_config *mcfg); =20 #endif /* __AUDIOREACH_H__ */ --=20 2.51.0