ALSA: vxpocket: Fix resource leak in vxpocket_probe error path

[PATCH] ALSA: vxpocket: Fix resource leak in vxpocket_probe error path

Posted by Haotian Zhang 2 days, 23 hours ago

When vxpocket_config() fails, vxpocket_probe() returns the error code
directly without freeing the sound card resources allocated by
snd_card_new(), which leads to a memory leak.

Add proper error handling to free the sound card and clear the
allocation bit when vxpocket_config() fails.

Fixes: 15b99ac17295 ("[PATCH] pcmcia: add return value to _config() functions")
Signed-off-by: Haotian Zhang <vulab@iscas.ac.cn>
---
 sound/pcmcia/vx/vxpocket.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/sound/pcmcia/vx/vxpocket.c b/sound/pcmcia/vx/vxpocket.c
index 2e09f2a513a6..9a5c9aa8eec4 100644
--- a/sound/pcmcia/vx/vxpocket.c
+++ b/sound/pcmcia/vx/vxpocket.c
@@ -284,7 +284,13 @@ static int vxpocket_probe(struct pcmcia_device *p_dev)
 
 	vxp->p_dev = p_dev;
 
-	return vxpocket_config(p_dev);
+	err = vxpocket_config(p_dev);
+	if (err < 0) {
+		card_alloc &= ~(1 << i);
+		snd_card_free(card);
+		return err;
+	}
+	return 0;
 }
 
 static void vxpocket_detach(struct pcmcia_device *link)
-- 
2.50.1.windows.1

Re: [PATCH] ALSA: vxpocket: Fix resource leak in vxpocket_probe error path

Posted by Takashi Iwai 2 days, 19 hours ago

On Mon, 15 Dec 2025 05:26:52 +0100,
Haotian Zhang wrote:
> 
> When vxpocket_config() fails, vxpocket_probe() returns the error code
> directly without freeing the sound card resources allocated by
> snd_card_new(), which leads to a memory leak.
> 
> Add proper error handling to free the sound card and clear the
> allocation bit when vxpocket_config() fails.
> 
> Fixes: 15b99ac17295 ("[PATCH] pcmcia: add return value to _config() functions")
> Signed-off-by: Haotian Zhang <vulab@iscas.ac.cn>

Applied now.  Thanks.

I guess a similar bug is present in
sound/pcmcia/pdaudiocf/pdaudiocf.c, too.
Care to fix it as well? ;)


Takashi