From nobody Thu Dec 18 13:41:04 2025 Received: from cstnet.cn (smtp81.cstnet.cn [159.226.251.81]) (using TLSv1.2 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 98D5C2C11CF; Mon, 15 Dec 2025 04:27:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=159.226.251.81 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765772873; cv=none; b=sEp8qC9F8OOs3wyPkt/YSfRxCHNlUfJtYkukGmZDCUxcXZXtLHoRw3rA/ttJr8TnN6Dm18zEXr50HOfMpcnIIPIpYL8mMIkNvjwCkOuBlvM2TgSN6AhKLBwinbhEqOYZ2SeY7VhAA/rltkSzjjh+GnpHcTLtAFYIn6Q8Hf9f9zw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765772873; c=relaxed/simple; bh=Opvt/kiYmKmxyRegtocmA/JaTozVgoVftHXU1vDJNB0=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=IktGKSWRWVBkWl2T4kMRfR6sDUDsEHeddpKNvl9ft5JA+8MNuYnq5QMZBnoloUvDi0bTKV5z4rCzRSSJE0Z/F/L6gAg83Ag037Y5KpyW9ikNqijOM1ll3Q2f1p/jPvvEBZTfBZoRcSTgOOvij/x5+DM9y1bpRaVeKKblwUcU+GU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn; spf=pass smtp.mailfrom=iscas.ac.cn; arc=none smtp.client-ip=159.226.251.81 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=iscas.ac.cn Received: from DESKTOP-L0HPE2S (unknown [124.16.141.245]) by APP-03 (Coremail) with SMTP id rQCowABXeuE_jj9pfwfEAA--.57538S2; Mon, 15 Dec 2025 12:27:44 +0800 (CST) From: Haotian Zhang To: perex@perex.cz, tiwai@suse.com Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, Haotian Zhang Subject: [PATCH] ALSA: vxpocket: Fix resource leak in vxpocket_probe error path Date: Mon, 15 Dec 2025 12:26:52 +0800 Message-ID: <20251215042652.695-1-vulab@iscas.ac.cn> X-Mailer: git-send-email 2.50.1.windows.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: rQCowABXeuE_jj9pfwfEAA--.57538S2 X-Coremail-Antispam: 1UD129KBjvdXoW7Jr4kGF17XrWxJrWDtw1DKFg_yoWDKrc_Gw 4IqrnrXFWqq3yFkw1rWw4kAFWftF40yr1FgFn5tr9Ik39rXFW2vr1DAr1DWrnrZ3y0yr1x Zw4UurWaqasxKjkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUbcAFF20E14v26r1j6r4UM7CY07I20VC2zVCF04k26cxKx2IYs7xG 6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48ve4kI8w A2z4x0Y4vE2Ix0cI8IcVAFwI0_Xr0_Ar1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI0_Gr0_ Cr1l84ACjcxK6I8E87Iv67AKxVW0oVCq3wA2z4x0Y4vEx4A2jsIEc7CjxVAFwI0_GcCE3s 1le2I262IYc4CY6c8Ij28IcVAaY2xG8wAqx4xG64xvF2IEw4CE5I8CrVC2j2WlYx0E2Ix0 cI8IcVAFwI0_Jr0_Jr4lYx0Ex4A2jsIE14v26r4j6F4UMcvjeVCFs4IE7xkEbVWUJVW8Jw ACjcxG0xvY0x0EwIxGrwACjI8F5VA0II8E6IAqYI8I648v4I1lc7CjxVAaw2AFwI0_JF0_ Jw1l42xK82IYc2Ij64vIr41l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr1lx2IqxVAqx4xG67AKxV WUJVWUGwC20s026x8GjcxK67AKxVWUGVWUWwC2zVAF1VAY17CE14v26r126r1DMIIYrxkI 7VAKI48JMIIF0xvE2Ix0cI8IcVAFwI0_Jr0_JF4lIxAIcVC0I7IYx2IY6xkF7I0E14v26r 1j6r4UMIIF0xvE42xK8VAvwI8IcIk0rVWUJVWUCwCI42IY6I8E87Iv67AKxVWUJVW8JwCI 42IY6I8E87Iv6xkF7I0E14v26r4j6r4UJbIYCTnIWIevJa73UjIFyTuYvjfU8miiUUUUU X-CM-SenderInfo: pyxotu46lvutnvoduhdfq/1tbiDAYRA2k-b0NpjAAAsH Content-Type: text/plain; charset="utf-8" When vxpocket_config() fails, vxpocket_probe() returns the error code directly without freeing the sound card resources allocated by snd_card_new(), which leads to a memory leak. Add proper error handling to free the sound card and clear the allocation bit when vxpocket_config() fails. Fixes: 15b99ac17295 ("[PATCH] pcmcia: add return value to _config() functio= ns") Signed-off-by: Haotian Zhang --- sound/pcmcia/vx/vxpocket.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/sound/pcmcia/vx/vxpocket.c b/sound/pcmcia/vx/vxpocket.c index 2e09f2a513a6..9a5c9aa8eec4 100644 --- a/sound/pcmcia/vx/vxpocket.c +++ b/sound/pcmcia/vx/vxpocket.c @@ -284,7 +284,13 @@ static int vxpocket_probe(struct pcmcia_device *p_dev) =20 vxp->p_dev =3D p_dev; =20 - return vxpocket_config(p_dev); + err =3D vxpocket_config(p_dev); + if (err < 0) { + card_alloc &=3D ~(1 << i); + snd_card_free(card); + return err; + } + return 0; } =20 static void vxpocket_detach(struct pcmcia_device *link) --=20 2.50.1.windows.1