drivers/clk/microchip/Kconfig | 2 +- drivers/clk/microchip/clk-core.c | 68 +++++++++++++++++++++------------------- 2 files changed, 36 insertions(+), 34 deletions(-)
Here's a series that fixes an issue with my round_rate conversion on
this PIC32 driver, fixes a minor bug, and allows building this driver
on other architectures with COMPILE_TEST enabled.
Changes in v3:
- Mock out cpu_nop5() in the case of COMPILE_TEST
- Don't return -EINVAL in *_get_parent()
- Link to v2: https://lore.kernel.org/r/20251201-clk-microchip-fixes-v2-0-9d5a0daadd98@redhat.com
Changes in v2:
- Add new patch to drop unused asm/traps.h
- Link to v1: https://lore.kernel.org/r/20251125-clk-microchip-fixes-v1-0-6c1f5573d1b9@redhat.com
Signed-off-by: Brian Masney <bmasney@redhat.com>
---
Brian Masney (4):
clk: microchip: core: remove duplicate determine_rate on pic32_sclk_ops
clk: microchip: core: correct return value on *_get_parent()
clk: microchip: core: remove unused include asm/traps.h
clk: microchip: core: allow driver to be compiled with COMPILE_TEST
drivers/clk/microchip/Kconfig | 2 +-
drivers/clk/microchip/clk-core.c | 68 +++++++++++++++++++++-------------------
2 files changed, 36 insertions(+), 34 deletions(-)
---
base-commit: b0db9cfd941e8ec63947e39ae29d9abc8be2559d
change-id: 20251125-clk-microchip-fixes-d0864e21ef0d
Best regards,
--
Brian Masney <bmasney@redhat.com>
On 12/5/25 21:46, Brian Masney wrote: > Brian Masney (4): > clk: microchip: core: remove duplicate determine_rate on pic32_sclk_ops > clk: microchip: core: correct return value on *_get_parent() > clk: microchip: core: remove unused include asm/traps.h Applied to clk-microchip, thanks!
Hi Stephen and Claudiu, On Fri, Dec 05, 2025 at 02:46:26PM -0500, Brian Masney wrote: > Here's a series that fixes an issue with my round_rate conversion on > this PIC32 driver, fixes a minor bug, and allows building this driver > on other architectures with COMPILE_TEST enabled. > > Changes in v3: > - Mock out cpu_nop5() in the case of COMPILE_TEST > - Don't return -EINVAL in *_get_parent() > - Link to v2: https://lore.kernel.org/r/20251201-clk-microchip-fixes-v2-0-9d5a0daadd98@redhat.com > > Changes in v2: > - Add new patch to drop unused asm/traps.h > - Link to v1: https://lore.kernel.org/r/20251125-clk-microchip-fixes-v1-0-6c1f5573d1b9@redhat.com > > Signed-off-by: Brian Masney <bmasney@redhat.com> > --- > Brian Masney (4): > clk: microchip: core: remove duplicate determine_rate on pic32_sclk_ops > clk: microchip: core: correct return value on *_get_parent() > clk: microchip: core: remove unused include asm/traps.h > clk: microchip: core: allow driver to be compiled with COMPILE_TEST Stephen: Can you just pick up the first 3 patches in this series? Let's drop patch 4 for now. I'm going to send to the MIPS maintainers a patch to move arch/mips/include/asm/mach-pic32/pic32.h to include/linux/platform_data, and update all of the drivers to use that new header. Once that's merged, I'll repost patch 4 from this series to enable COMPILE_TEST for this driver. Brian
Hi, all, On 1/9/26 01:15, Brian Masney wrote: > Hi Stephen and Claudiu, > > On Fri, Dec 05, 2025 at 02:46:26PM -0500, Brian Masney wrote: >> Here's a series that fixes an issue with my round_rate conversion on >> this PIC32 driver, fixes a minor bug, and allows building this driver >> on other architectures with COMPILE_TEST enabled. >> >> Changes in v3: >> - Mock out cpu_nop5() in the case of COMPILE_TEST >> - Don't return -EINVAL in *_get_parent() >> - Link to v2: https://lore.kernel.org/r/20251201-clk-microchip-fixes-v2-0-9d5a0daadd98@redhat.com >> >> Changes in v2: >> - Add new patch to drop unused asm/traps.h >> - Link to v1: https://lore.kernel.org/r/20251125-clk-microchip-fixes-v1-0-6c1f5573d1b9@redhat.com >> >> Signed-off-by: Brian Masney <bmasney@redhat.com> >> --- >> Brian Masney (4): >> clk: microchip: core: remove duplicate determine_rate on pic32_sclk_ops >> clk: microchip: core: correct return value on *_get_parent() >> clk: microchip: core: remove unused include asm/traps.h >> clk: microchip: core: allow driver to be compiled with COMPILE_TEST > > Stephen: Can you just pick up the first 3 patches in this series? Let's > drop patch 4 for now. I'm going to send to the MIPS maintainers a patch > to move arch/mips/include/asm/mach-pic32/pic32.h to > include/linux/platform_data, and update all of the drivers to use that > new header. I'm going to take those though clk-microchip tree if that's good for everybody. Thank you, Claudiu
On Fri, Jan 9, 2026 at 2:16 AM claudiu beznea <claudiu.beznea@tuxon.dev> wrote: > On 1/9/26 01:15, Brian Masney wrote: > > Hi Stephen and Claudiu, > > > > On Fri, Dec 05, 2025 at 02:46:26PM -0500, Brian Masney wrote: > >> Here's a series that fixes an issue with my round_rate conversion on > >> this PIC32 driver, fixes a minor bug, and allows building this driver > >> on other architectures with COMPILE_TEST enabled. > >> > >> Changes in v3: > >> - Mock out cpu_nop5() in the case of COMPILE_TEST > >> - Don't return -EINVAL in *_get_parent() > >> - Link to v2: https://lore.kernel.org/r/20251201-clk-microchip-fixes-v2-0-9d5a0daadd98@redhat.com > >> > >> Changes in v2: > >> - Add new patch to drop unused asm/traps.h > >> - Link to v1: https://lore.kernel.org/r/20251125-clk-microchip-fixes-v1-0-6c1f5573d1b9@redhat.com > >> > >> Signed-off-by: Brian Masney <bmasney@redhat.com> > >> --- > >> Brian Masney (4): > >> clk: microchip: core: remove duplicate determine_rate on pic32_sclk_ops > >> clk: microchip: core: correct return value on *_get_parent() > >> clk: microchip: core: remove unused include asm/traps.h > >> clk: microchip: core: allow driver to be compiled with COMPILE_TEST > > > > Stephen: Can you just pick up the first 3 patches in this series? Let's > > drop patch 4 for now. I'm going to send to the MIPS maintainers a patch > > to move arch/mips/include/asm/mach-pic32/pic32.h to > > include/linux/platform_data, and update all of the drivers to use that > > new header. > > I'm going to take those though clk-microchip tree if that's good for everybody. Sounds good. Thanks! I'll CC you on the MIPS changes to move the header file. Brian
On Fri, Jan 09, 2026 at 06:30:32AM -0500, Brian Masney wrote: > On Fri, Jan 9, 2026 at 2:16 AM claudiu beznea <claudiu.beznea@tuxon.dev> wrote: > > On 1/9/26 01:15, Brian Masney wrote: > > > On Fri, Dec 05, 2025 at 02:46:26PM -0500, Brian Masney wrote: > > >> Here's a series that fixes an issue with my round_rate conversion on > > >> this PIC32 driver, fixes a minor bug, and allows building this driver > > >> on other architectures with COMPILE_TEST enabled. > > >> > > >> Changes in v3: > > >> - Mock out cpu_nop5() in the case of COMPILE_TEST > > >> - Don't return -EINVAL in *_get_parent() > > >> - Link to v2: https://lore.kernel.org/r/20251201-clk-microchip-fixes-v2-0-9d5a0daadd98@redhat.com > > >> > > >> Changes in v2: > > >> - Add new patch to drop unused asm/traps.h > > >> - Link to v1: https://lore.kernel.org/r/20251125-clk-microchip-fixes-v1-0-6c1f5573d1b9@redhat.com > > >> > > >> Signed-off-by: Brian Masney <bmasney@redhat.com> > > >> --- > > >> Brian Masney (4): > > >> clk: microchip: core: remove duplicate determine_rate on pic32_sclk_ops > > >> clk: microchip: core: correct return value on *_get_parent() > > >> clk: microchip: core: remove unused include asm/traps.h > > >> clk: microchip: core: allow driver to be compiled with COMPILE_TEST > > > > > > Stephen: Can you just pick up the first 3 patches in this series? Let's > > > drop patch 4 for now. I'm going to send to the MIPS maintainers a patch > > > to move arch/mips/include/asm/mach-pic32/pic32.h to > > > include/linux/platform_data, and update all of the drivers to use that > > > new header. > > > > I'm going to take those though clk-microchip tree if that's good for everybody. > > Sounds good. Thanks! > > I'll CC you on the MIPS changes to move the header file. I posted a series to linux-mips to move the header file. It includes a variation of patch 4 from this series that enables COMPILE_TEST for this driver. https://lore.kernel.org/linux-mips/20260109-mips-pic32-header-move-v1-0-99859c55783d@redhat.com/T/#t Brian
© 2016 - 2026 Red Hat, Inc.