From nobody Tue Dec 16 07:44:47 2025 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0534133344D for ; Fri, 5 Dec 2025 19:46:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764964013; cv=none; b=jcLE7UNLYR0FlT3tNaF/nVG5pdnaMHVvuj3la+fia2LwX80KQondn00NfzSP9e/NBRwxPPNTzpzZM42NUAnM2w0LvD9d00bVz8cj3TqFXI84eX4Y/LBEo/iO/CLi4WVEF3m+InRDKhYxwCBVQAPmsQVvohbesntIAhfbIABPZp8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764964013; c=relaxed/simple; bh=z65zBnwhMmCjmLXWrNn9LKYrNxyaLvGh7xymTom1ePE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=n2sVVrkQR1l7GR4Sah+Y24h6x/qGATVrYjoHmNDoqHobJvCde8gHGhVNEOGni9kJZIdQNC2oaip48CBTL+MtiWjVKe3M4KFpQOxmii1jzGc3AOJHVtDkvJYXfRgcjYdneLfEXkSZYvFDwi9mUtZMRYi61Hs+WO1gJHvpWTh4z+8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Lgp6Kpf+; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=lpftIMb6; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Lgp6Kpf+"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="lpftIMb6" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1764964010; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BGaiOZiILglv5QY7owOlN6f8B2nrOEGJxkTHuhIhr8A=; b=Lgp6Kpf+wgligjAIpBuD292PuFM0tRiRRUC70eGB8ruRXcxh+1tm33+c9MtehrYM1/T11n ptyIg45dfSaRMBkPXbdgsEyDWS+ynkyby68mYmcK+D/Up7VVWMPboIJyMEvITcDNhlwXIn 8hu7B9es/i5nHek8ubxDb9ysjIE1Y3s= Received: from mail-yw1-f197.google.com (mail-yw1-f197.google.com [209.85.128.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-257-SuxIhSk9N-uH0AChYUouLA-1; Fri, 05 Dec 2025 14:46:49 -0500 X-MC-Unique: SuxIhSk9N-uH0AChYUouLA-1 X-Mimecast-MFC-AGG-ID: SuxIhSk9N-uH0AChYUouLA_1764964009 Received: by mail-yw1-f197.google.com with SMTP id 00721157ae682-7868061f373so33459107b3.2 for ; Fri, 05 Dec 2025 11:46:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1764964009; x=1765568809; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=BGaiOZiILglv5QY7owOlN6f8B2nrOEGJxkTHuhIhr8A=; b=lpftIMb6OpT/KEqhW08GJSzoDObGnoeSaZTgR+3rbdcahuoupHTd1AlJh1LascZ7nB vd+zFPMy83nG0/xTUrHIGAj/LVfWuA5QWwqnpDUMQSFiAaGDwhdvDuJSZsLhmUf4MQTu 1wLxssB8ojaUQl9172gjjr+nQDZAJh/WB+YwleFVTKIEYmHSZy+khnSKYcAyiK4T3E2c IHcs++anK8GUEqoMaflLlGmbHAL9OKBpfbW/6qfLfXdr/pObj5tR01f9/RXYE7Ii9GdX rxAXkRpUfyuxe4NqeMTdt5cVm4kDj5t3aDjnVXaNFAdSpz2e7t6VAjZWWlEYOZOOyE/R 7Jew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764964009; x=1765568809; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=BGaiOZiILglv5QY7owOlN6f8B2nrOEGJxkTHuhIhr8A=; b=ZvgCFZLGaIwQsgFxg+icCIRAi6oUrVDbbv+LCEg/HLhIsQphzLkxQCX+YulRcUkZwi +OT30dmyYiKAaEKiiPaXyDM9XOuQ4eIibndj/8VYZEV1zcjYWUbE8n0EyQ24Md+9FA/7 2hApSgssdIFWCxxltq+o3Kc1nGVNXh9QWAzipKscIiN8221aULDXZFErRtfHndheoaOE uwjqZXxX14kV8Bo8VyIni+U8jBFYhraFOeYJElj6icJKB0sCsrWeRRAoROZQPMbEa9kx cNxp82+81aO65bgSUitwRVXXoJNq2PCDsF5y8m54o/lBHIZjk4nOjgIm7QpoD70b5cP6 dKgQ== X-Forwarded-Encrypted: i=1; AJvYcCUqGr3yp6MgumIa0HZWLfwsJOnQ0BmY1l1qqE99HanWj4fPOtGnPN0TfSqohjDrYsyLAw/HzHWQ14agtJY=@vger.kernel.org X-Gm-Message-State: AOJu0YxF4i/eGitJyRQuCLKomEb/u1T7Hc+pZxV8mOX+b2YB+oTl+ECn bFJRJKlqLYyTw1n9+8CfPApIMPDQ3JWlsx8RAZEiimTJNjhCIAqcaS5DnkAr/PiPelHjIu7PNCN Rs+MEkXQXto4zzGTN+RelIfvZ5c1QASDdJgrbyb/DkxmUp1ps7ECF7HZnQVHwytnBLw== X-Gm-Gg: ASbGncvnQ62+hqfkXPFrEhF2sIt8Ycl18XHu/9nUMa/+ueVe/PMPTICmY8pdqlUoxxr MA0poTUlOzakka82mLh6Dr/fyqhHSBRS/CwQfzznp6J3nDRmOqP1Vy+SG7PC9/5w7plZ9kqd6B1 VFYPspGT2sCvM1mDSNeyZyyyuLGO90A7ged60tBbdFTrfmeQoQfbB06nb00WdBlsudNMAkWLmlv w6c3GIeNUuVwsTrEiw5BoftOHf+lSDuV4gKtt6mI0mFz80AAJ78i1z2BFlNTdYudrSy8jJPiqRZ JeJ97k4cQ2A9gtjnDaPit4Go925LCC9JltWtOsxn9GCjbXzo/eitS476/t8AxGYTPgFoQ9zR0X+ L49WW2d9fGlq8yLtYCijNLWQp6Sc/ppCKSj2h3xB4oxkCeApu X-Received: by 2002:a05:690e:1510:b0:644:4798:d6b6 with SMTP id 956f58d0204a3-6444e7f8cc4mr70509d50.85.1764964008974; Fri, 05 Dec 2025 11:46:48 -0800 (PST) X-Google-Smtp-Source: AGHT+IFRrPKQeyAGZ7gsH4A2HkvfFNoHbJ+jEXsogz+iQYBIjj4ujepqRNZJBRnmqQxR9q+IkBDA1A== X-Received: by 2002:a05:690e:1510:b0:644:4798:d6b6 with SMTP id 956f58d0204a3-6444e7f8cc4mr70495d50.85.1764964008627; Fri, 05 Dec 2025 11:46:48 -0800 (PST) Received: from [192.168.1.3] (c-73-183-52-120.hsd1.pa.comcast.net. [73.183.52.120]) by smtp.gmail.com with ESMTPSA id 956f58d0204a3-6443f2b80casm2151181d50.9.2025.12.05.11.46.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Dec 2025 11:46:47 -0800 (PST) From: Brian Masney Date: Fri, 05 Dec 2025 14:46:27 -0500 Subject: [PATCH v3 1/4] clk: microchip: core: remove duplicate determine_rate on pic32_sclk_ops Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251205-clk-microchip-fixes-v3-1-a02190705e47@redhat.com> References: <20251205-clk-microchip-fixes-v3-0-a02190705e47@redhat.com> In-Reply-To: <20251205-clk-microchip-fixes-v3-0-a02190705e47@redhat.com> To: Michael Turquette , Stephen Boyd , Maxime Ripard , Claudiu Beznea , Conor Dooley , Dan Carpenter Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Brian Masney , kernel test robot X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2011; i=bmasney@redhat.com; s=20250903; h=from:subject:message-id; bh=z65zBnwhMmCjmLXWrNn9LKYrNxyaLvGh7xymTom1ePE=; b=owGbwMvMwCW2/dJd9di6A+2Mp9WSGDKNzZZ4TfoyvWCL9QRtXoeVf+102S4tmrv007W3G5JWi udldi7R6ShlYRDjYpAVU2RZkmtUEJG6yvbeHU0WmDmsTCBDGLg4BWAiK6sZ/vD7qDhvO5O/NOdX scF/YctlCjIHo9x9JG9dDf/neuYSCzsjw1Gto0VFRzNs7i5j3HTtRqfYrK+tFn9dYitS/xc88HT N5wQA X-Developer-Key: i=bmasney@redhat.com; a=openpgp; fpr=A46D32705865AA3DDEDC2904B7D2DD275D7EC087 pic32_sclk_ops previously had a sclk_round_rate() member, and this was recently converted over to sclk_determine_rate() with the help of a Coccinelle semantic patch. pic32_sclk_ops now has two conflicting determine_rate ops members. Prior to the conversion, pic32_sclk_ops already had a determine_rate member that points to __clk_mux_determine_rate(). When both the round_rate() and determine_rate() ops are defined, the clk core only uses the determine_rate() op. Let's go ahead and drop the recently converted sclk_determine_rate() to match the previous functionality prior to the conversion. Fixes: e9f039c08cdc ("clk: microchip: core: convert from round_rate() to de= termine_rate()") Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202511222115.uvHrP95A-lkp@int= el.com/ Signed-off-by: Brian Masney Reviewed-by: Claudiu Beznea --- drivers/clk/microchip/clk-core.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/drivers/clk/microchip/clk-core.c b/drivers/clk/microchip/clk-c= ore.c index b34348d491f3e1b576b2b9a8a66bfddd8c2296ea..a0163441dfe5c1dfc27dae48e64= cf3cb3d6b764f 100644 --- a/drivers/clk/microchip/clk-core.c +++ b/drivers/clk/microchip/clk-core.c @@ -780,15 +780,6 @@ static unsigned long sclk_get_rate(struct clk_hw *hw, = unsigned long parent_rate) return parent_rate / div; } =20 -static int sclk_determine_rate(struct clk_hw *hw, - struct clk_rate_request *req) -{ - req->rate =3D calc_best_divided_rate(req->rate, req->best_parent_rate, - SLEW_SYSDIV, 1); - - return 0; -} - static int sclk_set_rate(struct clk_hw *hw, unsigned long rate, unsigned long parent_rate) { @@ -912,7 +903,6 @@ static int sclk_init(struct clk_hw *hw) const struct clk_ops pic32_sclk_ops =3D { .get_parent =3D sclk_get_parent, .set_parent =3D sclk_set_parent, - .determine_rate =3D sclk_determine_rate, .set_rate =3D sclk_set_rate, .recalc_rate =3D sclk_get_rate, .init =3D sclk_init, --=20 2.52.0 From nobody Tue Dec 16 07:44:47 2025 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 71D7C339701 for ; Fri, 5 Dec 2025 19:46:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764964016; cv=none; b=uu9Oa50jSMfiir5w0quQKwK0h3/BrlVDo4MawW7n96SzeesaZv0T4t1XIwNVKm5EXewJSWrkowU+lZ2LO9IXAGrY2loIirTvEs7ln+qIBRf7jnAMo1gjwhf4QzIX37YOc25MpviASp8TzYXqYk/WFjZStZy1A8j4R0UaGUZttS0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764964016; c=relaxed/simple; bh=z9S6zDYSq6RyfRn8B4HCTLbBL7NBL7L4ZkDAdn6b+S8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=MAF0c+39/pwFfJtob7S5zyTMvgIK13BG4WyMMh6oD87LT59CpFzTLu0+UbuK/joQTaBJD7HhXT6+VWS1i63YYKKQcrrJQAqrIayF1VJ0lb6FWNmRZVBWoAlhP/CTQQgPo+HsKVEDId93wEOHrw3Dtrr+aN172yLGIw/Ik7lrUls= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=X7KZ6pw9; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=e0PcRveS; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="X7KZ6pw9"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="e0PcRveS" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1764964013; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PCnk3SOexQlPSQvnYnFQ+FpFJGUp1UmIpL0d6S9c950=; b=X7KZ6pw9/WlYMZUkGTgjdIrDYvv7qy3r6dUvKy39zQ8tHhvngTW/ptnk7+EBJtIuWD7ph9 sce2XL1udiom5Vyl/T+/9adhKc4ADFfazKenWMNP1ZInwt9HOtUZE1EsDbNbdgP/xzHDib B/w7WZtl0Kc4FPFvM7oYbCFSERXpbHU= Received: from mail-yx1-f70.google.com (mail-yx1-f70.google.com [74.125.224.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-643-GSocQcW3MOawmsEQwvZuXw-1; Fri, 05 Dec 2025 14:46:51 -0500 X-MC-Unique: GSocQcW3MOawmsEQwvZuXw-1 X-Mimecast-MFC-AGG-ID: GSocQcW3MOawmsEQwvZuXw_1764964011 Received: by mail-yx1-f70.google.com with SMTP id 956f58d0204a3-64203afd866so4355578d50.0 for ; Fri, 05 Dec 2025 11:46:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1764964011; x=1765568811; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=PCnk3SOexQlPSQvnYnFQ+FpFJGUp1UmIpL0d6S9c950=; b=e0PcRveS3juyqvWVqdsibp43KK+kqdrodTRG48PlnGFVbdAHFkaFyzd4sn3YdcYyyv Uo2RmOb3UrRDsbxfYdE4OtCmQyFIYJ20mWZquffo5hh/dIvPDOk9cYPzIO0Ch1xWtkRr bNWdUzHWP19w0GR0KL9bJA+cR4GV9BamCz+DS3Uj1mvFQ3h63KL0v5OJgdgZEXKeyLpV T4WHJvNs0L0tcsHZqjMfPd1fnSJUqBILQMDgwjwtvQspycMQeGec8vQkp2tWYGQ7EnIm yq0VBbVsswAxthIJRt8THlUwGBopQzuV+vbXGdqR93hwtbDZ7Dh6uMdWDZ+P5hzySqHf 19Gg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764964011; x=1765568811; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=PCnk3SOexQlPSQvnYnFQ+FpFJGUp1UmIpL0d6S9c950=; b=M72JmGRXRlmPfjVKigCEWLsMPHh9qTti45vWlBwSk1j3dmGFEqE0v/5f3hiDHutTHI u2HUU8soSPSthSVzBT9DUgZx5dh2miyT9+wM1Cxn2Ti574QlXCOd5XaK4kEHu8PdG2Rc dBPX1ctf7C2kBBchE52eI2yq8A/4zJcwk5gu3OzT18yFV70cwgtQKeb5g2Bf7sIN6mAd 6jOpfHMUPC5YDyeRFNRu+F/lAZIqxdBmMorI7DsZVazJxEeudq7XimITxrKzr0gCHIrZ PoIT40Y8DBO+1aDHnhC9cKFc+KA1LsygNkkNU1K95YMFdcRUTV9CF9OsArUn+HeTyDra F9fg== X-Forwarded-Encrypted: i=1; AJvYcCWyOrsomqeLR+hSj8KaeY9xxm+M1/D/30/fwrzmKyeHmE370bnxzxy0G8XZGdOxJ4hcaYw69QKhLc6piLo=@vger.kernel.org X-Gm-Message-State: AOJu0Yz1ByXZMfuKMcpJ+tUdv6Ppabd1o1TzQp1C+T1lz9eULh1uhoLc LQUDkzbf0UrPFv1hHdbtBlRGIuA2vFgVkGK6WU8M1AlV2NF8hunb45589Bs4Q7/8M+cOpuU8eU+ I5bz0LX0Gk5yzYEi40OQiEN0d8Gynnz3JlrSn4n60/Qt/HOWOD6kMCvXjpsg/h6+olQ== X-Gm-Gg: ASbGncsUN6jI1kGXfNqiTcCTrqh9QbcCi2AqPInx8fV/3BMhmy8mLO1G+Ug5KM6MSPw TTYBs9T+XMgpmEQj8OgEwlaeFhlqFGP5xs3wFbiv3MsaPp4ZH0ZinjXB4cjr9lPQeIvaDZVDal2 PoHoD8x48VgAv9IYMkQ5ihWSrnYlYdQqbL6M5NSu1WnNglbthmmH7hxdbHrtnYk/BRAWkFHroBm uevRY9LprHfyB79VOTGybDiio668uBr31kl3mouoVi4Seq8j1T6wqlBWoOXz+joj4WXaEUF19Ue ExlVVf5O4Wj5Vf3vcdGOyFGf8W4+fSIRCyvMy4ZqiH1ud5pjvH6nlev/wtSLl3mVG5ANQfwlQ6T jJAZfqkoD4GDuQK9+qgbYhLSg0cTXaIAKsmaOt/wBw5MN429A X-Received: by 2002:a05:690e:2554:b0:63f:b353:8fb5 with SMTP id 956f58d0204a3-6444df9f5abmr277210d50.15.1764964011230; Fri, 05 Dec 2025 11:46:51 -0800 (PST) X-Google-Smtp-Source: AGHT+IFPCTnHwXvSA/0u8cdC7xQI4iIcuunv7o9haRn4g76piPssnlXwS/AvpPUROxj13yRu0IYpmw== X-Received: by 2002:a05:690e:2554:b0:63f:b353:8fb5 with SMTP id 956f58d0204a3-6444df9f5abmr277192d50.15.1764964010883; Fri, 05 Dec 2025 11:46:50 -0800 (PST) Received: from [192.168.1.3] (c-73-183-52-120.hsd1.pa.comcast.net. [73.183.52.120]) by smtp.gmail.com with ESMTPSA id 956f58d0204a3-6443f2b80casm2151181d50.9.2025.12.05.11.46.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Dec 2025 11:46:50 -0800 (PST) From: Brian Masney Date: Fri, 05 Dec 2025 14:46:28 -0500 Subject: [PATCH v3 2/4] clk: microchip: core: correct return value on *_get_parent() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251205-clk-microchip-fixes-v3-2-a02190705e47@redhat.com> References: <20251205-clk-microchip-fixes-v3-0-a02190705e47@redhat.com> In-Reply-To: <20251205-clk-microchip-fixes-v3-0-a02190705e47@redhat.com> To: Michael Turquette , Stephen Boyd , Maxime Ripard , Claudiu Beznea , Conor Dooley , Dan Carpenter Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Brian Masney , kernel test robot X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2161; i=bmasney@redhat.com; s=20250903; h=from:subject:message-id; bh=z9S6zDYSq6RyfRn8B4HCTLbBL7NBL7L4ZkDAdn6b+S8=; b=owGbwMvMwCW2/dJd9di6A+2Mp9WSGDKNzZb0hzaodfcG+l0WkzyQfe+hfyKX+LHOe7Exl9KK8 piWFDt0lLIwiHExyIopsizJNSqISF1le++OJgvMHFYmkCEMXJwCMBFJTYb/iS//Bu5YFDRty5bq tZsY/UtP2s4T+hH4Rsa/6HRlxPQXQgy/mISmFMjkzO8+Y/bgjNHCcob8HYcavIRXTvi1LGD5xHh vZgA= X-Developer-Key: i=bmasney@redhat.com; a=openpgp; fpr=A46D32705865AA3DDEDC2904B7D2DD275D7EC087 roclk_get_parent() and sclk_get_parent() has the possibility of returning -EINVAL, however the framework expects this call to always succeed since the return value is unsigned. If there is no parent map defined, then the current value programmed in the hardware is used. Let's use that same value in the case where -EINVAL is currently returned. This index is only used by clk_core_get_parent_by_index(), and it validates that it doesn't overflow the number of available parents. Reported-by: kernel test robot Reported-by: Dan Carpenter Closes: https://lore.kernel.org/r/202512050233.R9hAWsJN-lkp@intel.com/ Signed-off-by: Brian Masney Reported-by lines, with a single Closes. The warning goes away if I do Reviewed-by: Claudiu Beznea --- drivers/clk/microchip/clk-core.c | 25 ++++++++++++------------- 1 file changed, 12 insertions(+), 13 deletions(-) diff --git a/drivers/clk/microchip/clk-core.c b/drivers/clk/microchip/clk-c= ore.c index a0163441dfe5c1dfc27dae48e64cf3cb3d6b764f..82f62731fc0ed566b0c6b007381= c4f10a2a8a7e7 100644 --- a/drivers/clk/microchip/clk-core.c +++ b/drivers/clk/microchip/clk-core.c @@ -283,14 +283,13 @@ static u8 roclk_get_parent(struct clk_hw *hw) =20 v =3D (readl(refo->ctrl_reg) >> REFO_SEL_SHIFT) & REFO_SEL_MASK; =20 - if (!refo->parent_map) - return v; - - for (i =3D 0; i < clk_hw_get_num_parents(hw); i++) - if (refo->parent_map[i] =3D=3D v) - return i; + if (refo->parent_map) { + for (i =3D 0; i < clk_hw_get_num_parents(hw); i++) + if (refo->parent_map[i] =3D=3D v) + return i; + } =20 - return -EINVAL; + return v; } =20 static unsigned long roclk_calc_rate(unsigned long parent_rate, @@ -817,13 +816,13 @@ static u8 sclk_get_parent(struct clk_hw *hw) =20 v =3D (readl(sclk->mux_reg) >> OSC_CUR_SHIFT) & OSC_CUR_MASK; =20 - if (!sclk->parent_map) - return v; + if (sclk->parent_map) { + for (i =3D 0; i < clk_hw_get_num_parents(hw); i++) + if (sclk->parent_map[i] =3D=3D v) + return i; + } =20 - for (i =3D 0; i < clk_hw_get_num_parents(hw); i++) - if (sclk->parent_map[i] =3D=3D v) - return i; - return -EINVAL; + return v; } =20 static int sclk_set_parent(struct clk_hw *hw, u8 index) --=20 2.52.0 From nobody Tue Dec 16 07:44:47 2025 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DE2F6342531 for ; Fri, 5 Dec 2025 19:46:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764964019; cv=none; b=gAe/IVYGtfYWTGkS22UVE+iSmbRtU7KtTV3u1NsVbMRxR+1on3EbNmjoprTJVfS+ZHXLSYt642IBCcif9x+M+nSYD5afrY7vMInlqT13l/nHZ3jNM95jIdYAOixDOQf78ztNkSr+UhMsbH0k/82R8T9G9m8kPPoaAHFsSAWUlaA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764964019; c=relaxed/simple; bh=gtIs+PR6UbJDClojL+R4O3oXAPHfTqBt+4nRF134ciA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=q3oqBp3NKfjBLS9apm7X4+ju9FMnbZ4dSTm1+jDgYYug/KhtX942mkaa1vMZ30X7WEQIrY9DcmRH7YgaUzZ06rE1TkuyL7hbhYGEyWKOy/5Sse901Af4Au6gyoXjRtgDTVxgkzNnsok/EMn3dat082bbV0zzznEY9vP3owsxUMM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=WgUsNimt; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=iX46LfX+; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="WgUsNimt"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="iX46LfX+" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1764964017; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=q/LIFKf063d8yHzNm0uamjenhd6Ijw4cyeXSS0veBq0=; b=WgUsNimt10m8G74cqvUybh+AJTivAsHDXd/yD6ItL7zMu5KUNRgPitWYhCDKpf7KYo24S4 BrH7erosgFpUkQCHFmDYjdoiPEoI5MsRM0VJVJMZiAKwo9EUhh17/4Z8ld2WjNSJ2N4zzV wi4GttARFFtjX44xhF/Y1Msuj47sUFo= Received: from mail-yw1-f199.google.com (mail-yw1-f199.google.com [209.85.128.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-637-57mmgPnmPTmLF0iiG-Mp8g-1; Fri, 05 Dec 2025 14:46:53 -0500 X-MC-Unique: 57mmgPnmPTmLF0iiG-Mp8g-1 X-Mimecast-MFC-AGG-ID: 57mmgPnmPTmLF0iiG-Mp8g_1764964013 Received: by mail-yw1-f199.google.com with SMTP id 00721157ae682-787f7261b62so49899227b3.0 for ; Fri, 05 Dec 2025 11:46:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1764964013; x=1765568813; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=q/LIFKf063d8yHzNm0uamjenhd6Ijw4cyeXSS0veBq0=; b=iX46LfX+DJJiClekhftEsxQx7opmlT2Dhd94Dp9Il52AsDwtswFJn7k7+Br1hCP5KB bU1J31TuSg+Xd0H3c0N7bO7ehAIA3IJPeiTmkZIY7Unt3eoifFKHRXf1Qrzl9rGLGU+z EG2lQF0ZX5auDAkIOLGj+Eq6f3ZzfkVldxvFm0+YLQm6LEnSYS1mGg5YjjnlRT+83Dyh zBxNyN9fk2oNxgkvvs6zGfc72iaFFeMuKYtlzxE+QEZGD09hiyVvfF5Dewt4vHwKN422 VQWt1PThj5XzotrckpexSerUK/uiS7eJplUmlxkqRNwUfuIAajT9FxKOTgD8Rp2vvLUS bfEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764964013; x=1765568813; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=q/LIFKf063d8yHzNm0uamjenhd6Ijw4cyeXSS0veBq0=; b=nDkShUtl5sX1ZC5C+a0LL8hDR7y8NZOnFCiuj27bVHofXkmorOPLJ4BBPLYHKvbQX/ hef/XQU1sWocWLTJxr4+XG1OAPg5ghqriMe+xjjXDUgbo1+D1ZpAol870+x0h+7eEIbQ nhSwPzRHc+hMr9rowUHvdMMnOAIefCAmdcvuC9TNMnm5ZPP33ZKTbz13I6MIqDkWPLfZ tWemqqWXySWuU7S0BiIUoVsn0LNT1bBcjTz6ANFXRNE0p1UBiKmE79zvthRUS4DuAynD fM3gMjiJg8lWjvZbH2IDEphlHRh4I1+zzTmYYqTmnQRW6BsYP/lcEgzQi54aHe+CbeWC MuOw== X-Forwarded-Encrypted: i=1; AJvYcCVQo7emlSrvGtr3mFx5Z2MXIa98NVtLqq+OIKJ0QICM2SzyHkK0/rZB/Wce6ghzkS0Ke+lc+Xf+ylKXkb4=@vger.kernel.org X-Gm-Message-State: AOJu0YzGeN3TAINAqkpzMAhaFXvm25/PvTsmNbP/4nDQ4whSS62BdeSM /otV1x3eOca6ZCNUOtAFHU6qpwQSio2hycfQ/ghrMGFExMY91fWJjyPLeXQUv7ITHAxFtFCZGp9 4N5/7Qq/yjhN4tMr5hrXYCXNj25LEFWicS13zEde5r7QrFCJ8nJQOfuwzzb612WWleg== X-Gm-Gg: ASbGncvwEJ9SsPuHgi+14a59VfO8XuniOFspm2bpAO0juVGlesjVHXWNIvU6Tr0v6G9 hcUDimKFBRjpYBN+UsnY3bqA0QOxv1++DqofncKXE4pIQkA/fj31Am8s0IdVCHrmGm3s/T/9mT8 7Dlgqn46wftLdIEfWf3H3JuhS6s8kqOlpie8GIZ3EtiHNFlqP4Nlh3/SZfGui3wR/Y5EA2R5Lkw pNdPXbQsPeDQkdzONGhzS1+DThyNEJps64iAtBqUrpPLgrqWg5RR4iQ2F8hn2vQfEmwBBC0PoK1 YL4BL/flGabu8f98Xmw4gdmQVdpTFaZXgw6m9nbIEpSFuHDH3/Jl2Qz/1PZUR33DG/fIsoq94Fh snosgYz4CkcRxnnfs3P/sCRFbgePWruqqtq/7lkzv/ctlCEN9 X-Received: by 2002:a05:690e:e8c:b0:640:dcd7:3559 with SMTP id 956f58d0204a3-6443d6f10f3mr5658092d50.12.1764964013295; Fri, 05 Dec 2025 11:46:53 -0800 (PST) X-Google-Smtp-Source: AGHT+IEVhwkAjzFhnPyQio5oDm0owjJfqZu2F2EWU+zJpVLLPJDk+85YZ1y/IC5+tqCX2kYOxA7klQ== X-Received: by 2002:a05:690e:e8c:b0:640:dcd7:3559 with SMTP id 956f58d0204a3-6443d6f10f3mr5658077d50.12.1764964012868; Fri, 05 Dec 2025 11:46:52 -0800 (PST) Received: from [192.168.1.3] (c-73-183-52-120.hsd1.pa.comcast.net. [73.183.52.120]) by smtp.gmail.com with ESMTPSA id 956f58d0204a3-6443f2b80casm2151181d50.9.2025.12.05.11.46.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Dec 2025 11:46:51 -0800 (PST) From: Brian Masney Date: Fri, 05 Dec 2025 14:46:29 -0500 Subject: [PATCH v3 3/4] clk: microchip: core: remove unused include asm/traps.h Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251205-clk-microchip-fixes-v3-3-a02190705e47@redhat.com> References: <20251205-clk-microchip-fixes-v3-0-a02190705e47@redhat.com> In-Reply-To: <20251205-clk-microchip-fixes-v3-0-a02190705e47@redhat.com> To: Michael Turquette , Stephen Boyd , Maxime Ripard , Claudiu Beznea , Conor Dooley , Dan Carpenter Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Brian Masney X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=654; i=bmasney@redhat.com; s=20250903; h=from:subject:message-id; bh=gtIs+PR6UbJDClojL+R4O3oXAPHfTqBt+4nRF134ciA=; b=owGbwMvMwCW2/dJd9di6A+2Mp9WSGDKNzZZotcSHCQUVeOQ5XTt2WnvD8dXed77Pt+f887i6x kTsbOeSjlIWBjEuBlkxRZYluUYFEamrbO/d0WSBmcPKBDKEgYtTACbSP4GR4cmf1ZLJ1+fW+t5O yJ+3rqHlxt/CIhvLD2Hvz85p9uOZfJ2RoSHApEL8zul3kSKrp+343OcqeWONlfnM9d9SJ7+ok+3 dzAIA X-Developer-Key: i=bmasney@redhat.com; a=openpgp; fpr=A46D32705865AA3DDEDC2904B7D2DD275D7EC087 The asm/traps.h include file is not actually used, so let's go ahead and remove it. Signed-off-by: Brian Masney --- drivers/clk/microchip/clk-core.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/clk/microchip/clk-core.c b/drivers/clk/microchip/clk-c= ore.c index 82f62731fc0ed566b0c6b007381c4f10a2a8a7e7..f467d7bc28c87a50fb18dc52757= 4f973c4b7e615 100644 --- a/drivers/clk/microchip/clk-core.c +++ b/drivers/clk/microchip/clk-core.c @@ -10,7 +10,6 @@ #include #include #include -#include =20 #include "clk-core.h" =20 --=20 2.52.0 From nobody Tue Dec 16 07:44:47 2025 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DE26934252C for ; Fri, 5 Dec 2025 19:46:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764964019; cv=none; b=SubkpnI/XBXuuEkL0LRXQrfqTCr2n9kKvFWFerWA6N2NvvGXfTqjt8gHQ0WcPO4DS/bJOo35QySYc5KlLhct74xAzRiOUvTcRgO47DQ5AavQOM1WVicv2qbO26RboILr1LarvKJ3gBU1wpnC/CpgmZIKw4zlqhpY2xGmbBgZl2s= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764964019; c=relaxed/simple; bh=KPcvmdhFm9HlslOyuHv2lYXxtXtxadeQa7HuDvwARJc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ZI2Eym2BO96Y55TymWQ0w06S3CiLNmeD/moDnsqoqInHPTQDfSDWWUbj4Ff88slLhwOAYONOscvmicZcAnSnK4WOBmXDMRf9g2htT34fGw3N0OFvQqTflm1uNPqEJvYKFrnsyDl+daRrl5Ukt8YwTX0IcNtRjX79e7mC+Drxvc0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=VprMVLMy; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=FGw1wNiQ; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="VprMVLMy"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="FGw1wNiQ" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1764964017; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=30iJyQRBNkHN7TEjN+qByvx9czbGoxa7fRfCHkoySmo=; b=VprMVLMyN/wrfN5XPCqBLcUmtPb/BObejcfjmGPbsdS/u1hc0iaWdPzKhnjJlo62KhUoxC 5u0cEL8Jy+Jh7jLqCK9b2pRzY+yW5lZ+WtwN9WxszcamBaaX1KC6Tcf4sWOqfP/bbXKOLK uohBAqeMqjKTL/CSrcnfwAadNV4qEbk= Received: from mail-yx1-f70.google.com (mail-yx1-f70.google.com [74.125.224.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-625-yH1_3at9NYWNY7o7cB7Ugw-1; Fri, 05 Dec 2025 14:46:55 -0500 X-MC-Unique: yH1_3at9NYWNY7o7cB7Ugw-1 X-Mimecast-MFC-AGG-ID: yH1_3at9NYWNY7o7cB7Ugw_1764964015 Received: by mail-yx1-f70.google.com with SMTP id 956f58d0204a3-64308330c34so2934597d50.1 for ; Fri, 05 Dec 2025 11:46:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1764964015; x=1765568815; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=30iJyQRBNkHN7TEjN+qByvx9czbGoxa7fRfCHkoySmo=; b=FGw1wNiQeLod2sH+s1npjVPxH4sq70OBuxEMmnIFYl0ZH3EqjrbWEV0mfK2H5cS28g 8nvORUfjY4Vi/Hun2mvlp+cA2aLMHGGD2uj4RKcHU0Q9yljMM/HQlCb6CHohoR/3NpTX s13rsSaC0T6PEqlULQ8VeOqdUTsmH0aLJew4RaYmCrRpcKFKFCXr1w16BsVUcISygNDr 7kDXICWIz2obx87mdZyW+y0+FZCBxpDFi3y/By0DtHHFn1LN2L3CFtfJrs4FP8Qn3ULT OFqBwNmGj0agYMic4NpFyIR2Ev87OfwiP3WCANBUdfETkfA1ildj4SRr1CQHNNjvFqCC IGcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764964015; x=1765568815; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=30iJyQRBNkHN7TEjN+qByvx9czbGoxa7fRfCHkoySmo=; b=a87G0ZqK3o1vV5t3xcfJVIuKrGuNY4pw4TBbEfCEQ9FPsonnByh5sXru+EGQ+yDfj3 yjnBs8JqgWl/3WAxdoOhGXH13ddTpIS9v7F43EJF6lEjbvkqn6nhyRKf9Op/tcTEyznL xjS+FtSBVe52df/K+2mELFWPLz8qwU5Laq++Auw4C7/EnXPEcb7U1e7wTmU0wkTcsgPe yMpRssUPdNmF61XpUPZpiXtlUtcN5ebb3M97v04fObDAIyAAywFNkcFC21eSzGnTSIDy rg/jYgQEM+Cy/5Zq3CgK6JgecfAXJohRfLhAFEUEnY/AhugXxmuY4VDaL5PNLGIymltV GHpw== X-Forwarded-Encrypted: i=1; AJvYcCUCHro0mU3FQbkdMzYhncj7agmdTJEy5BaXT7qI+ryEzRgRfrUi20y2ExeH3duawS0Tjm5hZk3zDJ8PP8M=@vger.kernel.org X-Gm-Message-State: AOJu0YzHLPqVxcLNUHYyXNY9dWWBLoW9k1vIMPJtc81dh/0F/xwFYV0g n/efH1sioISyJ8t6Jm08FK0Vmz2iGlYPfXZaU1pdyOeJu1e20XJJmiKM9Ja5nc+GfaW9m0uPr2b 81IIqeowDnxcd6oxGBrIm/45JqKHiGEhzTaFBLwwrBnwP/Bjz/9/lFcW2uWZB70Znmw== X-Gm-Gg: ASbGncs+oHi8NP1h7vIG2jdJHaMznP3CKKNYCQTkSYojKpHUim3XKXCp6hkKhlvdWQA v9abWP90GsuGQ0bECAzxVtO5RdsZXrL4ruc8LFMqRR7XkBIvsaoezjzSFxb/UhogI2lkcZZIz/b CM/Lfh9fXdgTKu8r4nXjc4TQ0sc4EEld2i+Y6O2OJpBEj8vDbKerRDkdYZullugY/JtMOZSFTP2 +crKynVR4qWuj/nZ25ib9qF3zw+lC209elxGpTdC/DF0dhWo3/mH0roQdpy3unKkuLg/MiRm1E+ sucALET6goKfsvZoSXGTgbFo40VjhoUoztJd4XjlTTW5GhlJFAVF4Pp4NyyxC/1Rz2qJmlqZ98r 6S/HziQqi4o63D9vo4+Gptei4FcScAPaFt/sBra/cF/k1KK8q X-Received: by 2002:a05:690e:1911:b0:640:e021:ff6c with SMTP id 956f58d0204a3-6444e7a7333mr101897d50.38.1764964015242; Fri, 05 Dec 2025 11:46:55 -0800 (PST) X-Google-Smtp-Source: AGHT+IGCdcT2Dggo7CE8vnrB7QHeEj6BIJtQT/hMk5Hb2LD8xom0k7h+Vr1SgaTMh9MkR/K07FmBMg== X-Received: by 2002:a05:690e:1911:b0:640:e021:ff6c with SMTP id 956f58d0204a3-6444e7a7333mr101872d50.38.1764964014740; Fri, 05 Dec 2025 11:46:54 -0800 (PST) Received: from [192.168.1.3] (c-73-183-52-120.hsd1.pa.comcast.net. [73.183.52.120]) by smtp.gmail.com with ESMTPSA id 956f58d0204a3-6443f2b80casm2151181d50.9.2025.12.05.11.46.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Dec 2025 11:46:54 -0800 (PST) From: Brian Masney Date: Fri, 05 Dec 2025 14:46:30 -0500 Subject: [PATCH v3 4/4] clk: microchip: core: allow driver to be compiled with COMPILE_TEST Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251205-clk-microchip-fixes-v3-4-a02190705e47@redhat.com> References: <20251205-clk-microchip-fixes-v3-0-a02190705e47@redhat.com> In-Reply-To: <20251205-clk-microchip-fixes-v3-0-a02190705e47@redhat.com> To: Michael Turquette , Stephen Boyd , Maxime Ripard , Claudiu Beznea , Conor Dooley , Dan Carpenter Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Brian Masney X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2718; i=bmasney@redhat.com; s=20250903; h=from:subject:message-id; bh=KPcvmdhFm9HlslOyuHv2lYXxtXtxadeQa7HuDvwARJc=; b=owGbwMvMwCW2/dJd9di6A+2Mp9WSGDKNzZaE29yyi489dtTVc0XbdPOjIi93X/Jck5Xi5BoRm qFUK1reUcrCIMbFICumyLIk16ggInWV7b07miwwc1iZQIYwcHEKwETsShj+CuwuOK7ntu5AUuqm kFs/c3K5L1z/2f1DuSMgWNmOdeHyXwz/7OO9ElP/30p6KxG0MGD5oWt50/N9Xuz+vDecfWtmQbw qNwA= X-Developer-Key: i=bmasney@redhat.com; a=openpgp; fpr=A46D32705865AA3DDEDC2904B7D2DD275D7EC087 This driver currently only supports builds against a PIC32 target. To avoid future breakage in the future, let's update the Kconfig and the driver so that it can be built with CONFIG_COMPILE_TEST enabled. Note that with the existing asm calls is not how I'd want to do this today if this was a new driver, however I don't have access to this hardware. To avoid any breakage, let's keep the existing behavior. Signed-off-by: Brian Masney --- drivers/clk/microchip/Kconfig | 2 +- drivers/clk/microchip/clk-core.c | 32 +++++++++++++++++++++++--------- 2 files changed, 24 insertions(+), 10 deletions(-) diff --git a/drivers/clk/microchip/Kconfig b/drivers/clk/microchip/Kconfig index 1b9e43eb54976b219a0277cc971f353fd6af226a..1e56a057319d97e20440fe4e107= d26fa85c95ab1 100644 --- a/drivers/clk/microchip/Kconfig +++ b/drivers/clk/microchip/Kconfig @@ -1,7 +1,7 @@ # SPDX-License-Identifier: GPL-2.0 =20 config COMMON_CLK_PIC32 - def_bool COMMON_CLK && MACH_PIC32 + def_bool (COMMON_CLK && MACH_PIC32) || COMPILE_TEST =20 config MCHP_CLK_MPFS bool "Clk driver for PolarFire SoC" diff --git a/drivers/clk/microchip/clk-core.c b/drivers/clk/microchip/clk-c= ore.c index f467d7bc28c87a50fb18dc527574f973c4b7e615..fad4b45d908310ffb59e4ed57c5= 5ae4266253444 100644 --- a/drivers/clk/microchip/clk-core.c +++ b/drivers/clk/microchip/clk-core.c @@ -9,7 +9,15 @@ #include #include #include + +#if !defined(CONFIG_MACH_PIC32) && defined(CONFIG_COMPILE_TEST) +#define PIC32_CLR(_reg) ((_reg) + 0x04) +#define PIC32_SET(_reg) ((_reg) + 0x08) +#define PIC32_INV(_reg) ((_reg) + 0x0C) +#define pic32_syskey_unlock() +#else #include +#endif =20 #include "clk-core.h" =20 @@ -74,15 +82,21 @@ /* SoC specific clock needed during SPLL clock rate switch */ static struct clk_hw *pic32_sclk_hw; =20 -/* add instruction pipeline delay while CPU clock is in-transition. */ -#define cpu_nop5() \ -do { \ - __asm__ __volatile__("nop"); \ - __asm__ __volatile__("nop"); \ - __asm__ __volatile__("nop"); \ - __asm__ __volatile__("nop"); \ - __asm__ __volatile__("nop"); \ -} while (0) +#if !defined(CONFIG_MACH_PIC32) && defined(CONFIG_COMPILE_TEST) +#define cpu_nop5() +#else +{ + /* add instruction pipeline delay while CPU clock is in-transition. */ + #define cpu_nop5() \ + do { \ + __asm__ __volatile__("nop"); \ + __asm__ __volatile__("nop"); \ + __asm__ __volatile__("nop"); \ + __asm__ __volatile__("nop"); \ + __asm__ __volatile__("nop"); \ + } while (0) +} +#endif =20 /* Perpheral bus clocks */ struct pic32_periph_clk { --=20 2.52.0