power: supply: bq27xxx: fix wrong errno when bus ops are unsupported

[PATCH] power: supply: bq27xxx: fix wrong errno when bus ops are unsupported

Posted by Haotian Zhang 2 weeks, 1 day ago

bq27xxx_write(), bq27xxx_read_block(), and bq27xxx_write_block()
return -EPERM when the bus callback pointer is NULL. A NULL callback
indicates the operation is not supported by the bus/driver,
not that permission is denied.

Return -EOPNOTSUPP instead of -EPERM when di->bus.write/
read_bulk/write_bulk is NULL.

Fixes: 14073f6614f6 ("power: supply: bq27xxx: Add bulk transfer bus methods")
Signed-off-by: Haotian Zhang <vulab@iscas.ac.cn>
---
 drivers/power/supply/bq27xxx_battery.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/power/supply/bq27xxx_battery.c b/drivers/power/supply/bq27xxx_battery.c
index ad2d9ecf32a5..1d7aa240126a 100644
--- a/drivers/power/supply/bq27xxx_battery.c
+++ b/drivers/power/supply/bq27xxx_battery.c
@@ -1172,7 +1172,7 @@ static inline int bq27xxx_write(struct bq27xxx_device_info *di, int reg_index,
 		return -EINVAL;
 
 	if (!di->bus.write)
-		return -EPERM;
+		return -EOPNOTSUPP;
 
 	ret = di->bus.write(di, di->regs[reg_index], value, single);
 	if (ret < 0)
@@ -1191,7 +1191,7 @@ static inline int bq27xxx_read_block(struct bq27xxx_device_info *di, int reg_ind
 		return -EINVAL;
 
 	if (!di->bus.read_bulk)
-		return -EPERM;
+		return -EOPNOTSUPP;
 
 	ret = di->bus.read_bulk(di, di->regs[reg_index], data, len);
 	if (ret < 0)
@@ -1210,7 +1210,7 @@ static inline int bq27xxx_write_block(struct bq27xxx_device_info *di, int reg_in
 		return -EINVAL;
 
 	if (!di->bus.write_bulk)
-		return -EPERM;
+		return -EOPNOTSUPP;
 
 	ret = di->bus.write_bulk(di, di->regs[reg_index], data, len);
 	if (ret < 0)
-- 
2.50.1.windows.1

Re: [PATCH] power: supply: bq27xxx: fix wrong errno when bus ops are unsupported

Posted by Matt Ranostay 2 weeks, 1 day ago

Seems reasonable enough..
Only possible concern is breaking ABI if some application is wrongly expecting -EPERM for an error condition, but seems unlikely enough to not correct this.

Reviewed-by: Matt Ranostay <matt@ranostay.sg>

Sent with Proton Mail secure email.

On Thursday, December 4th, 2025 at 16:35, Haotian Zhang <vulab@iscas.ac.cn> wrote:

> bq27xxx_write(), bq27xxx_read_block(), and bq27xxx_write_block()
> return -EPERM when the bus callback pointer is NULL. A NULL callback
> indicates the operation is not supported by the bus/driver,
> not that permission is denied.
> 
> Return -EOPNOTSUPP instead of -EPERM when di->bus.write/
> 
> read_bulk/write_bulk is NULL.
> 
> Fixes: 14073f6614f6 ("power: supply: bq27xxx: Add bulk transfer bus methods")
> Signed-off-by: Haotian Zhang vulab@iscas.ac.cn
> 
> ---
> drivers/power/supply/bq27xxx_battery.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/power/supply/bq27xxx_battery.c b/drivers/power/supply/bq27xxx_battery.c
> index ad2d9ecf32a5..1d7aa240126a 100644
> --- a/drivers/power/supply/bq27xxx_battery.c
> +++ b/drivers/power/supply/bq27xxx_battery.c
> @@ -1172,7 +1172,7 @@ static inline int bq27xxx_write(struct bq27xxx_device_info *di, int reg_index,
> return -EINVAL;
> 
> if (!di->bus.write)
> 
> - return -EPERM;
> + return -EOPNOTSUPP;
> 
> ret = di->bus.write(di, di->regs[reg_index], value, single);
> 
> if (ret < 0)
> @@ -1191,7 +1191,7 @@ static inline int bq27xxx_read_block(struct bq27xxx_device_info *di, int reg_ind
> return -EINVAL;
> 
> if (!di->bus.read_bulk)
> 
> - return -EPERM;
> + return -EOPNOTSUPP;
> 
> ret = di->bus.read_bulk(di, di->regs[reg_index], data, len);
> 
> if (ret < 0)
> @@ -1210,7 +1210,7 @@ static inline int bq27xxx_write_block(struct bq27xxx_device_info *di, int reg_in
> return -EINVAL;
> 
> if (!di->bus.write_bulk)
> 
> - return -EPERM;
> + return -EOPNOTSUPP;
> 
> ret = di->bus.write_bulk(di, di->regs[reg_index], data, len);
> 
> if (ret < 0)
> --
> 2.50.1.windows.1