From nobody Fri Dec 19 18:41:50 2025 Received: from cstnet.cn (smtp84.cstnet.cn [159.226.251.84]) (using TLSv1.2 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BB10217993; Thu, 4 Dec 2025 08:34:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=159.226.251.84 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764837298; cv=none; b=mUGid5xVdBddpeK4POhpZDW6BdJ6gEXOXuEhAcFUVMQZfU8OeeV6rdHdmzCc4b85BGYDoX3NoehW1wDZZPXF3uFMMJ1BpRLctLRh2yz8firtu4hmN0D2vIX4FTjluGpiNo2h6fcGiORDBp3sZtdF3xkB/wb7AwmeXSs5E36G1FE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764837298; c=relaxed/simple; bh=5cJi0X3cBWt+UP1IIKfA+AWewLB6AgujppvVU5bDc7c=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=UFhZcv8ytOdXIUjDfOPZpOD/oUA9QRHccE3JUTW69bA2WV9iPti8/Zc+0rO/iwCmjsfuh38kkRb55zmgcn4J7aNnoIxkNbLTE425bbnlCGY4vf5zgWWGcVTp6MmDu97OUxtUUCZ/ivPISDC/8mdHRPI6XulBOxPkHgGuizQg9I8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn; spf=pass smtp.mailfrom=iscas.ac.cn; arc=none smtp.client-ip=159.226.251.84 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=iscas.ac.cn Received: from DESKTOP-L0HPE2S (unknown [124.16.141.245]) by APP-05 (Coremail) with SMTP id zQCowAC3uWqsRzFp7g8tAw--.9953S2; Thu, 04 Dec 2025 16:34:53 +0800 (CST) From: Haotian Zhang To: sre@kernel.org Cc: matt@ranostay.sg, pali@kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Haotian Zhang Subject: [PATCH] power: supply: bq27xxx: fix wrong errno when bus ops are unsupported Date: Thu, 4 Dec 2025 16:34:36 +0800 Message-ID: <20251204083436.1367-1-vulab@iscas.ac.cn> X-Mailer: git-send-email 2.50.1.windows.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: zQCowAC3uWqsRzFp7g8tAw--.9953S2 X-Coremail-Antispam: 1UD129KBjvJXoW7tryDCr48ZF45Cw4Dtry7KFg_yoW8WFWrpa y5A34jkr12qa43CF4DC3WFkFyj9a9xKFWxCr9xGw15ZF1xtFZxta45Kr98Wr40yayxC3WF vFZ8ta1Uu3WfJFDanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUvm14x267AKxVWUJVW8JwAFc2x0x2IEx4CE42xK8VAvwI8IcIk0 rVWrJVCq3wAFIxvE14AKwVWUJVWUGwA2ocxC64kIII0Yj41l84x0c7CEw4AK67xGY2AK02 1l84ACjcxK6xIIjxv20xvE14v26ryj6F1UM28EF7xvwVC0I7IYx2IY6xkF7I0E14v26F4j 6r4UJwA2z4x0Y4vEx4A2jsIE14v26F4UJVW0owA2z4x0Y4vEx4A2jsIEc7CjxVAFwI0_Gc CE3s1le2I262IYc4CY6c8Ij28IcVAaY2xG8wAqx4xG64xvF2IEw4CE5I8CrVC2j2WlYx0E 2Ix0cI8IcVAFwI0_JrI_JrylYx0Ex4A2jsIE14v26r4j6F4UMcvjeVCFs4IE7xkEbVWUJV W8JwACjcxG0xvY0x0EwIxGrwACjI8F5VA0II8E6IAqYI8I648v4I1lc7CjxVAaw2AFwI0_ JF0_Jw1lc2xSY4AK67AK6r43MxAIw28IcxkI7VAKI48JMxC20s026xCaFVCjc4AY6r1j6r 4UMI8I3I0E5I8CrVAFwI0_Jr0_Jr4lx2IqxVCjr7xvwVAFwI0_JrI_JrWlx4CE17CEb7AF 67AKxVWUAVWUtwCIc40Y0x0EwIxGrwCI42IY6xIIjxv20xvE14v26r1j6r1xMIIF0xvE2I x0cI8IcVCY1x0267AKxVWUJVW8JwCI42IY6xAIw20EY4v20xvaj40_Jr0_JF4lIxAIcVC2 z280aVAFwI0_Jr0_Gr1lIxAIcVC2z280aVCY1x0267AKxVW8JVW8JrUvcSsGvfC2KfnxnU UI43ZEXa7VUUKhF3UUUUU== X-CM-SenderInfo: pyxotu46lvutnvoduhdfq/1tbiCREGA2kxGVa4PwAAsN Content-Type: text/plain; charset="utf-8" bq27xxx_write(), bq27xxx_read_block(), and bq27xxx_write_block() return -EPERM when the bus callback pointer is NULL. A NULL callback indicates the operation is not supported by the bus/driver, not that permission is denied. Return -EOPNOTSUPP instead of -EPERM when di->bus.write/ read_bulk/write_bulk is NULL. Fixes: 14073f6614f6 ("power: supply: bq27xxx: Add bulk transfer bus methods= ") Signed-off-by: Haotian Zhang Reviewed-by: Matt Ranostay --- drivers/power/supply/bq27xxx_battery.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/power/supply/bq27xxx_battery.c b/drivers/power/supply/= bq27xxx_battery.c index ad2d9ecf32a5..1d7aa240126a 100644 --- a/drivers/power/supply/bq27xxx_battery.c +++ b/drivers/power/supply/bq27xxx_battery.c @@ -1172,7 +1172,7 @@ static inline int bq27xxx_write(struct bq27xxx_device= _info *di, int reg_index, return -EINVAL; =20 if (!di->bus.write) - return -EPERM; + return -EOPNOTSUPP; =20 ret =3D di->bus.write(di, di->regs[reg_index], value, single); if (ret < 0) @@ -1191,7 +1191,7 @@ static inline int bq27xxx_read_block(struct bq27xxx_d= evice_info *di, int reg_ind return -EINVAL; =20 if (!di->bus.read_bulk) - return -EPERM; + return -EOPNOTSUPP; =20 ret =3D di->bus.read_bulk(di, di->regs[reg_index], data, len); if (ret < 0) @@ -1210,7 +1210,7 @@ static inline int bq27xxx_write_block(struct bq27xxx_= device_info *di, int reg_in return -EINVAL; =20 if (!di->bus.write_bulk) - return -EPERM; + return -EOPNOTSUPP; =20 ret =3D di->bus.write_bulk(di, di->regs[reg_index], data, len); if (ret < 0) --=20 2.50.1.windows.1