On 11/29/25 1:17 PM, Krzysztof Kozlowski wrote:
> Please, please stop ending cleanup.h patches for very simple code like:
>
> foo = kzalloc();
> kfree(foo);
> return;
>
> ... *if you do not intend to read cleanup.h*. These changes are making
> simple code not necessarily simpler. But worse, if you do not read
> cleanup.h then you introduce actually undesired, error-prone and wrong
> style of having constructors with redundant values (= NULL).
>
> This is actually worse code.
>
> If you do not agree in declaration-in-place-of-use (fair!), then do not
> use cleanup.h. If you want to use cleanup.h, then please read cleanup.h
> before.
>
> This is second mixup I see recently around Qualcomm files.
>
> Best regards,
> Krzysztof
>
> ---
> Krzysztof Kozlowski (6):
> ASoC: qcom: q6prm: Fix confusing cleanup.h syntax
> ASoC: qcom: q6asm: Fix confusing cleanup.h syntax
> ASoC: qcom: q6apm: Fix confusing cleanup.h syntax
> ASoC: qcom: q6afe: Fix confusing cleanup.h syntax
> ASoC: qcom: audioreach: Fix confusing cleanup.h syntax
> ASoC: qcom: Minor readability improve with new lines
>
Thanks Krzysztof for fixing the confusing parts, I do agree with you.
there are alteast 100+ such instances in just sound/*
Reviewed-by: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>
--srini
> sound/soc/qcom/qdsp6/audioreach.c | 28 +++++++++++++++++-----------
> sound/soc/qcom/qdsp6/q6adm.c | 2 ++
> sound/soc/qcom/qdsp6/q6afe.c | 10 ++++++----
> sound/soc/qcom/qdsp6/q6apm.c | 9 ++++++---
> sound/soc/qcom/qdsp6/q6asm.c | 19 +++++++++++++++----
> sound/soc/qcom/qdsp6/q6prm.c | 16 ++++++++--------
> 6 files changed, 54 insertions(+), 30 deletions(-)
> ---
> base-commit: 92fd6e84175befa1775e5c0ab682938eca27c0b2
> change-id: 20251129-asoc-wrong-cleanup-h-can-people-stop-sending-this-without-reading-docs-ebe8abad6e55
>
> Best regards,