From nobody Mon Dec 1 22:36:21 2025 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6368E30F7FB for ; Sat, 29 Nov 2025 13:18:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764422296; cv=none; b=Xt1JsQtgp8Qqz5TdxDM7cFFfVBEAEGUXqObGVVyL3NWiP9WwVCoAqvON9/IYuerdelv9+2LkqpahSUuRp3VuYaCeMosCDbAaUuE2J6jCuRqIItNDHhuPJMwtlsQwJ7aQOqStPRJ9siVvJmSJuuY24iFpWD093WJIlFz4ozoJsvs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764422296; c=relaxed/simple; bh=4tP20X4JE/X1M+a1qcu2Sp7p+7XlYzP88ouU3+KHMk4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=k4CEu4MMMH0y7cWF85zQuk576x9NoBC0ji1RqaSAyR2rE9ZXhbt7T/IfqgmExNh4NijHry6ON84lie8u24ZwBCVLRLrbYxXst8kKZWJiABDZOiYaRG6ckrGirGiiYOmWDycQxlq/888wkAu5g/js1mueeqtbFJzFF9afxCZBhus= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=T/XhvJ7l; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=EEPALHLM; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="T/XhvJ7l"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="EEPALHLM" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5ATC99V92307187 for ; Sat, 29 Nov 2025 13:18:08 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 8cbthdZNrXFWsLhrsZsdx/l3lBDTGHaz6pZq9MgKjzc=; b=T/XhvJ7lx2Tc/2oK +26zu+xACxuq9j2pHiBUOtFFWOpsme4k6S5t+xfj5nZC4BGMWvyV/PwR987DMCJ5 dIY/QBm6YFJl53NJOV1DdZ8VFuYW/hVApGT253hZ0Gx8c75InjcVJvy/vootbtiI WtIbBYz1N+S540KZzhc9YX45MYJptkGnFp2lNOuBHaepOMr0FXPAkitun4G7SefA WIiOnVzeejXqkGH/NcGVM6GvY87gtzcwl795qIGSrF516Iq63N9/eZy7edFQ5zbT syHYWxWjaCdi9OP7Y43ezG6M+xANMx2GP6+xNjYbI8e6IQepwigdA7OWGphlVyV/ hjThRQ== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4aqt468m81-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sat, 29 Nov 2025 13:18:07 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-8b23a64f334so521323385a.2 for ; Sat, 29 Nov 2025 05:18:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1764422287; x=1765027087; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=8cbthdZNrXFWsLhrsZsdx/l3lBDTGHaz6pZq9MgKjzc=; b=EEPALHLM+iE4J+n1gMljso8vhtqZ8zyE3rUNfTzztOq7sPbZEENdbd0J8OkphVyM3m pI7fsCTdggNiu3Y1B2zgoQdlvNgcaN0GXcqomPpiKJ9N+2+YuuWI1FRNMbtPZsZgdYj5 XU2d5VDTEgof3cHeIuJyzqKOn8sPhr94RdOsplO0OJQFKvuBZE/K2DmkanyfqxaBA2A9 4G0xqrvgnNq7dk1J038yXS0j9T89evfQp+AHm+d2Z0fFHJofOo/hFuUcOJzAWVxeeaTP gNGbzwDapaw/JI9H7Ev04KXThbpj2AkhBkmoPXwnvGPDQuFN6+DSc3HV3GO6ho0FRxYI DUeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764422287; x=1765027087; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=8cbthdZNrXFWsLhrsZsdx/l3lBDTGHaz6pZq9MgKjzc=; b=Vbzq8MhBg+COO9Dtlp3Z+V1QhOJll1JWRpEbjI47L0pERl/dFiPk8Q/QHh5stPLJEg XLsuK+c7UJ4i04YgO+vdtDML6xVuD5JNxwPlCNh3dqvavQMop9HPV/PP0HCIsghyRPlW HTv1pVXGMlYJLYqluxwL+Tw4dh/fa97nVnGzOWBBLYhZXR1dcWikzBLCqAv1X08j3i75 D/4BYPs9TmehA3t/bF/k9BjCAq8RzI/6mcm8h6F9DWmFujw0XZYgdphM6N7s0mWjB6qG i6qXQVigl2zVfpMXdCrOvCCKQSKp7Ubt7dzEru1fdPaIG70NOiJGQLoglJPlwCkpRLkK GuSw== X-Forwarded-Encrypted: i=1; AJvYcCUvN9gxc0VYhohuCJjBGAgqHg22LytorjiXAVnynsQVi7JPHvvHifthMtHrUv3XjUHS//3Y6HqnCSH9oUw=@vger.kernel.org X-Gm-Message-State: AOJu0YyEAh+nLksnJxWOSshm2BVIFBKt6XiYlu/v6Wx9nbzHjkmlua1w bGS9y4458/DNNRgqAxwV4CW3g+PqAhXDeTCXodSC78lWVH54jerVuSmhkXOiFExOuMo1q5WrW+j JQjbr7rnrk5nQj1AwiIO1dVnyRx7DcjWxdVI+wZhn86BvZof8rb+OPfLuMqmEICH7rxc= X-Gm-Gg: ASbGncsHuMBmw+saMK0CtwaV3B8s84E0EtiXEFhdtKbJYVU/rd42/T1l2XeGFmFDerW Zc45tsZ7EWaDOqpRutl0je91UVKbb4AY/7UVZs/u7lZPPwA05pn3FhT0Fzgqv6VRAPQI4CWxssh lwlsQ96/89iYtKWfq2f3YND0tOclXpkSvQoohU2Q1hRacolWkVlNKeHRpgZl4dyJPQ9jebo+Jea C8JOtMQutXdMQFyRMk+w6rDQ5Tn+qIQzAQxredXdDeB4U8nmBeCTyWbUdo/hxMPB6x0mCrG2iKY ag+iWtQ5wH81mwf1rPV6j93VtkC5JhlvK9FZ2yboLf/MN5kG/uZmLMmOB/XjJCKOaWkQpRxKUoY xhGycP/LTG9Eo4mzKsnt0uCYNk8x8Ixmjlg== X-Received: by 2002:a05:620a:45ab:b0:890:2419:d6d9 with SMTP id af79cd13be357-8b33d46974dmr3938478985a.57.1764422286899; Sat, 29 Nov 2025 05:18:06 -0800 (PST) X-Google-Smtp-Source: AGHT+IFYM57l60GAmVKeTAWPzcoREO+EjPDS5tiqd9ImbPTfr1osrjKj/E9eSTlrKMeDkmWlgAV+5A== X-Received: by 2002:a05:620a:45ab:b0:890:2419:d6d9 with SMTP id af79cd13be357-8b33d46974dmr3938474585a.57.1764422286454; Sat, 29 Nov 2025 05:18:06 -0800 (PST) Received: from [127.0.1.1] ([178.197.195.159]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b76f5163903sm723233866b.7.2025.11.29.05.18.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 29 Nov 2025 05:18:05 -0800 (PST) From: Krzysztof Kozlowski Date: Sat, 29 Nov 2025 14:17:53 +0100 Subject: [PATCH 1/6] ASoC: qcom: q6prm: Fix confusing cleanup.h syntax Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251129-asoc-wrong-cleanup-h-can-people-stop-sending-this-without-reading-docs-v1-1-c38b06884e39@oss.qualcomm.com> References: <20251129-asoc-wrong-cleanup-h-can-people-stop-sending-this-without-reading-docs-v1-0-c38b06884e39@oss.qualcomm.com> In-Reply-To: <20251129-asoc-wrong-cleanup-h-can-people-stop-sending-this-without-reading-docs-v1-0-c38b06884e39@oss.qualcomm.com> To: Srinivas Kandagatla , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=3209; i=krzysztof.kozlowski@oss.qualcomm.com; h=from:subject:message-id; bh=4tP20X4JE/X1M+a1qcu2Sp7p+7XlYzP88ouU3+KHMk4=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBpKvKGIUYvporfOfRuCmpz74ach1rJTk3sjEnBH URtH6FNhdKJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCaSryhgAKCRDBN2bmhouD 11+HD/45xpdzC4pD31u6j2/8H2wXpVwiAVrbQzYCQOsTTuL+2Fr1noDKul2/osJmJSTW3tcqEep cb0Ld1fdFCidrNlcWXGksdwRz5eM5TZtDacZ9pjGLHfTMHwzTvIifMK8/ghLW3KB9tQ7sGMtUSe OGTIijHy2ExNvXNNO4p1DTvlvYyqbA8YGzAx+VT5Pem3hmh6Zyqwy2hcfZrmt93cgjMB0OL5Z7e JI/VuZ5bgv62dI6gyxHvigTFqZm2pZJQOkUu6Vm8kTzX+sAzpD+JHBYhJI6iRaSm0Ilkv0rUAjl tlkrkxvASIIrLEq6hVXqbn6jOxSwdDbcrA7aYgqTpqFTMHFF3MULIod8tiz0vIWh+4y0O/tBGQB 6efuxSu8bE1Y3QwPF0Nq1h/P96Ek6HMKPUqUaKQDF+she8Wis1E2/gQ3cIhT8kBonRJZewJXvWK zzP1xXsmdVYyMR98xmjGo4crqQ3Jr22nsTzpGX9U1w8Zs7DIW4JPEWr8Nxf9i8kWZqVtMf2HbV6 7H3Z25s08Vm9tdQGHgQyyGOuLjeIDu4i7wuhYH7ech0Q5bpMrudQ3pAg3zZFEfNGzusfnwBRfOk X7zFcqefnqTq86l/SQFXVPHKx+3PG6oUeb0SoCVspDob3dZalj96KkPLjfOgHsU9wsX8wsbdCBy e00iQKMXYh/Rqww== X-Developer-Key: i=krzysztof.kozlowski@oss.qualcomm.com; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMTI5MDEwNiBTYWx0ZWRfXwKDPpefJFHlx zydu83QNjD52iWkdsrqysgdivpQr7uoIl9cow7/ZHfeZTCXZsHawuCY9VW5K7hysllxwxyl2eHH jchs4NEhsAOpzEcbg0gc6Hez4ISSBTA6z/iKGxa+C2N5444J2Alxv3eT2yaAjgXkoWgjahOwaPB 480oS0mBO9VYyEwZB8pZCkhkGBu8MfPnXcLBVnKRGxsVcYcesKM+v1JOfnexsd5WhmQinq0chN+ aCaKc9XQ6ax95dAxzai498ZWqHS+kURNHCBK1OqKCEOx8Kx7Ye9lAhNQdEbYUFH6jC6d1bAg8cS AtDtXM4qyXNpZ24iCDLHYXS2NVE71EUwKVAAt/W+XkofMp8t5fK6zLkmlLExS04k2DKV6Ea8Ai9 dcit3K1eaPr7i1a8nLAaLUJXQxNGfg== X-Proofpoint-ORIG-GUID: CBkyewLVcsB7vVW8clbTy-4GOCqQvNli X-Authority-Analysis: v=2.4 cv=aO79aL9m c=1 sm=1 tr=0 ts=692af290 cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=FPK7cjBCgYbqzSTDLBmM0Q==:17 a=IkcTkHD0fZMA:10 a=6UeiqGixMTsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=In8TF76piAPFrmgoFOgA:9 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 X-Proofpoint-GUID: CBkyewLVcsB7vVW8clbTy-4GOCqQvNli X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-11-28_08,2025-11-27_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 suspectscore=0 spamscore=0 priorityscore=1501 bulkscore=0 phishscore=0 malwarescore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2511290106 Commit de8e95773c48 ("ASoc: qcom: q6prm: Use automatic cleanup of kfree()") did not make the code simpler but more complicated. Already simple code of allocation and free, without any error paths, got now declaration with one constructor followed by another allocation, which is in contrary to explicit coding rules guiding cleanup.h: "Given that the "__free(...) =3D NULL" pattern for variables defined at the top of the function poses this potential interdependency problem the recommendation is to always define and assign variables in one statement and not group variable definitions at the top of the function when __free() is used." Code does not have a bug, but is less readable and uses discouraged coding practice, so fix that by moving declaration to the place of assignment. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Srinivas Kandagatla --- Can we pleas stop sending these cleanup.h patches when people do not bother to read cleanup.h? --- sound/soc/qcom/qdsp6/q6prm.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/sound/soc/qcom/qdsp6/q6prm.c b/sound/soc/qcom/qdsp6/q6prm.c index 0b8fad0bc832..2544c4519b26 100644 --- a/sound/soc/qcom/qdsp6/q6prm.c +++ b/sound/soc/qcom/qdsp6/q6prm.c @@ -62,7 +62,6 @@ static int q6prm_set_hw_core_req(struct device *dev, uint= 32_t hw_block_id, bool struct prm_cmd_request_hw_core *req; gpr_device_t *gdev =3D prm->gdev; uint32_t opcode, rsp_opcode; - struct gpr_pkt *pkt __free(kfree) =3D NULL; =20 if (enable) { opcode =3D PRM_CMD_REQUEST_HW_RSC; @@ -72,7 +71,8 @@ static int q6prm_set_hw_core_req(struct device *dev, uint= 32_t hw_block_id, bool rsp_opcode =3D PRM_CMD_RSP_RELEASE_HW_RSC; } =20 - pkt =3D audioreach_alloc_cmd_pkt(sizeof(*req), opcode, 0, gdev->svc.id, G= PR_PRM_MODULE_IID); + struct gpr_pkt *pkt __free(kfree) =3D + audioreach_alloc_cmd_pkt(sizeof(*req), opcode, 0, gdev->svc.id, GPR_PRM_= MODULE_IID); if (IS_ERR(pkt)) return PTR_ERR(pkt); =20 @@ -111,10 +111,10 @@ static int q6prm_request_lpass_clock(struct device *d= ev, int clk_id, int clk_att struct apm_module_param_data *param_data; struct prm_cmd_request_rsc *req; gpr_device_t *gdev =3D prm->gdev; - struct gpr_pkt *pkt __free(kfree) =3D NULL; =20 - pkt =3D audioreach_alloc_cmd_pkt(sizeof(*req), PRM_CMD_REQUEST_HW_RSC, 0,= gdev->svc.id, - GPR_PRM_MODULE_IID); + struct gpr_pkt *pkt __free(kfree) =3D + audioreach_alloc_cmd_pkt(sizeof(*req), PRM_CMD_REQUEST_HW_RSC, 0, + gdev->svc.id, GPR_PRM_MODULE_IID); if (IS_ERR(pkt)) return PTR_ERR(pkt); =20 @@ -143,10 +143,10 @@ static int q6prm_release_lpass_clock(struct device *d= ev, int clk_id, int clk_att struct apm_module_param_data *param_data; struct prm_cmd_release_rsc *rel; gpr_device_t *gdev =3D prm->gdev; - struct gpr_pkt *pkt __free(kfree) =3D NULL; =20 - pkt =3D audioreach_alloc_cmd_pkt(sizeof(*rel), PRM_CMD_RELEASE_HW_RSC, 0,= gdev->svc.id, - GPR_PRM_MODULE_IID); + struct gpr_pkt *pkt __free(kfree) =3D + audioreach_alloc_cmd_pkt(sizeof(*rel), PRM_CMD_RELEASE_HW_RSC, 0, + gdev->svc.id, GPR_PRM_MODULE_IID); if (IS_ERR(pkt)) return PTR_ERR(pkt); =20 --=20 2.48.1 From nobody Mon Dec 1 22:36:21 2025 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7C8EF30F929 for ; Sat, 29 Nov 2025 13:18:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764422297; cv=none; b=G2YmlVa0bYk6Aqx3BtcmrTKngmxLSX+lToVp1bsD2T0LbcW+SX123zcXyrMzt2vequ/fbv5Wmx2Qu0dvM5sw21+3IKLeV+utOUo0tVQPKFpSDpGVkZ4xTM2yk1hn+qwfBiKcWg41Ek402SuKVUbqg8lw0o6JMPCwOJf1xGN5gUQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764422297; c=relaxed/simple; bh=x9vtLXfXzdPDIM01j+riInZ7EHgzllLsAHPJN+4rMdk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=X7LYjzt9AXZmjy9AAELFqxlBXWe3Yf/7CCqUIaP0Yy88gUMc1CHM3CXYfZhRd4MWyjFJdrRBbT6T9cden/Cr+dtNnM53dwvEOyA8+6RmI3ymVbapoM27YLWDtGisMLqom/EVjHJrduiDEopAEd9chB4uROAnsnyxANIMyyhTZD0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ZhFb6lKn; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=ACKHnII2; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ZhFb6lKn"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="ACKHnII2" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5AT28bqc1634761 for ; Sat, 29 Nov 2025 13:18:09 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= tZdI4KwvA+/rcyU/a5Z2diTmh95gzReC/grImFy8oOU=; b=ZhFb6lKnzkGiLDuh XvDj2B6Z5JPDtS1n0msQiSSrhCAT9wGEcCHDn7I6TsJNEHFDwtksye2Yv7pkAdR+ XvOun3nQ1pBZI3LDwdnxaSdJp7wqYNthRwXK+EIhESQ6SKJ2AvU8hVoGTWuBitTO e8GOxqetdZWHvQT3rrH2ZUyM01ZhlvD5m3v4ROHhg08pzxDLFE0Usw9D/YbLmNHx zMGtxw5pG1Pd7v6saZhijtQgZpUfka4cXFkli7N55B5Y9MFY4NRo6duac0Mz26h6 UCdekOy/sOvlqqkMHmPQgAgr4kr9Jqm8sjQfxg9tiO9Pl1CYHQOzhcMCEvBMNbuC 2JzQPA== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4aqqsqgtdv-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sat, 29 Nov 2025 13:18:09 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-8b245c49d0cso540707985a.3 for ; Sat, 29 Nov 2025 05:18:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1764422288; x=1765027088; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=tZdI4KwvA+/rcyU/a5Z2diTmh95gzReC/grImFy8oOU=; b=ACKHnII2lUf2LgHxdv52HC8XbvD/UVlFyqcCnCMVVeCLC/neVrXoYNo+6wzm71tWfK jdU8f3Gh0I+sdcfBTc2G63uN3mqWmzCQUL1eCWA3PiBSekTPIk/GzvvFeK7jUyElLye4 aJeqFOLD8+6lrJsdRFhoBPfQjyG+f8ps5MXv6NpitM720szzQ0AmhHJI6oQcjtHSK7ff 0lOol4c8VeQPvooytxmSZnwcxMEOcsaajz6qVQNeFoRSez2VXzaCYz+NDnSaFprCd7wb +xAh9MPKamSRXfOU7Cj3Eu4xWXVN/MFJ6xQMh4RPGIW1zv4jEGLkPVeb+EzvBdR+nMgg ko0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764422288; x=1765027088; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=tZdI4KwvA+/rcyU/a5Z2diTmh95gzReC/grImFy8oOU=; b=jDhstT6+fZq270DenRyI/MJBTjjis1QXq4bN6TU8v2g9XxHsEhlA7fZCKJORbgtuav TRmv/PX/rJGLUG2E88AdjOrtMHfaj1gJilPA1B0H9FZPYc8j1o/A4gQp3+B4p1bOG4q4 Cvaqu9QIztJQTwss4pouOnwsych9t7K7YGS9iUBb5ZVCAyPGAauW1yDAS5Aov9xtzc0m lBZ58Fkwrf/uVUB23z/6xInSB95VvISX0bXLMF5B0ymUOBBLbPrHHDjSFwUdd3DGniGc cX2G+CGrEwImnbuHOQ2ReThmuDRaQIGBazDWczhO7x1z8p5XjYsm7jlmRIAw89QbhGQ7 5Wsg== X-Forwarded-Encrypted: i=1; AJvYcCXInrBACCLYih2p/ilbKN0w3DXGSYqOTU1P0P0C5R3foJjRvYlq/yWuoTc9TOKvUgS89HcZ5Cl3rFVuWUs=@vger.kernel.org X-Gm-Message-State: AOJu0YyiYVD2LmK8tQnr9CukA4b91lSC+yW4FunMYGvtTivFppITgnGW T010UnITyGCWg01wJrmfwEZKmsZ1qnkxCwN7jOvCy3B7zJDgrBtIYEN0ZFJ9u7OzxRp1HiQVCvC Vw2igEypYSUOeMH/CvmT1y6UDEKPe6g+TaZbNFYWP9bFOmYNnJyZLh/ckkogodpovD0w= X-Gm-Gg: ASbGncuKoU/XTGkapeI5qLNgm3aJ4nflKuTQLj6uKEhHeVM7zJHOxDj1nab3prF5LeP jK/lisan/NlQcM0FreeyjXAvLWRRbTAM6tRpQ39XvDaUk2F7GINh1VlxYk0N6oU2loITtzs1M9Y 9vi5kfLFQrCihpaCyUB7apf592R08nBmANAd1g0Ymosdx5wpFSAD27RdKIuzonK+Xn431n+Giu7 2K51kbtG1LvsDs2lPah/30cNI6lS9Ugea3a/E6lohwluAIdncZi7wpMZ9/gfMy8UAWaBx0C304E TyPpkTPliORWNyWg4p/MtQ7Pdi5O/mDWE3/R0YnObY5KYo+JLcuGa/tB7RuaDtLwUkOwiVX3pRY OzBl4JKi6KoJ1ElbAJpI/HwGBWCzTMvM8Aw== X-Received: by 2002:a05:620a:40c3:b0:892:ce2b:f84d with SMTP id af79cd13be357-8b33d1f05c4mr4102207485a.33.1764422288368; Sat, 29 Nov 2025 05:18:08 -0800 (PST) X-Google-Smtp-Source: AGHT+IH5tY6ebmJtGqCyfgXdxSwaxTDwXXKyfw+fj/QGY6k18f5MfeED2Tz9aIlMysPzC/z/UAqkmg== X-Received: by 2002:a05:620a:40c3:b0:892:ce2b:f84d with SMTP id af79cd13be357-8b33d1f05c4mr4102201085a.33.1764422287827; Sat, 29 Nov 2025 05:18:07 -0800 (PST) Received: from [127.0.1.1] ([178.197.195.159]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b76f5163903sm723233866b.7.2025.11.29.05.18.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 29 Nov 2025 05:18:07 -0800 (PST) From: Krzysztof Kozlowski Date: Sat, 29 Nov 2025 14:17:54 +0100 Subject: [PATCH 2/6] ASoC: qcom: q6asm: Fix confusing cleanup.h syntax Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251129-asoc-wrong-cleanup-h-can-people-stop-sending-this-without-reading-docs-v1-2-c38b06884e39@oss.qualcomm.com> References: <20251129-asoc-wrong-cleanup-h-can-people-stop-sending-this-without-reading-docs-v1-0-c38b06884e39@oss.qualcomm.com> In-Reply-To: <20251129-asoc-wrong-cleanup-h-can-people-stop-sending-this-without-reading-docs-v1-0-c38b06884e39@oss.qualcomm.com> To: Srinivas Kandagatla , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=2363; i=krzysztof.kozlowski@oss.qualcomm.com; h=from:subject:message-id; bh=x9vtLXfXzdPDIM01j+riInZ7EHgzllLsAHPJN+4rMdk=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBpKvKHOGB7XVrfrOoQU0ZIGpIbWVAtgd3UgWUV3 0lxoSPPWlqJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCaSryhwAKCRDBN2bmhouD 1/gHD/4mhpePBUHZKY/6cj/Xw/wgxSk9sxiAromZPPkzhJdObb4LNusWmshHJ5rTJkknLqj2joA 1tq8bIYVHRqBOHn6VgMQrYGWp1rj+lk1FXFEV5xx6R8DJEMuZJXnweVZtwjQMzqWCg2HxI+BCjM Te/czUYchFWcYho5G28gw0Gt+Qchz9E/yhOGFXfLqTsDYtAT8eqyuxzwNwpM8WkBB1THmVJCmGC w9+X6TA60e4BZKdIa3YteLolWCD2Ns+xZ5h+aOMsipAawkogiO09BTAcXWOF1KNvyN0qLhy5ejA MIYdmG2D60knDSzNmgrv9/paPzFlITdq6LlDhSM+QrGX8qXj/9+RXgJEVmY7sSeuvVx+0NaefxD iG2G4vtuh6HvaYNd6GlRdiwbniauwgcEdJiROcWXjU0IQ+JjWWgn9PAz2UfksqZ+gT8p3GUrI6R f0HhtdYbynsanZOdfUd2xJxRWmKh37JFalp6KZqgb+bZh2eZZEGwb/N1kHOEk00rIFyXAtRJuRX m5RHae6ieuAwF6HYkw9e+OQKz0PK30A0w4VhIq7x8GjFvM1ORHvToquG5OVo2XHeQEpwYNGhyMt SptKAEofoxw2Ii33y5EK4CxCiNcuiQUbJ2nbufc0jdKHUGK0UL8KHFJQFocmUkitnIEOJ1r4K0o 5JoKNPbTk098BRQ== X-Developer-Key: i=krzysztof.kozlowski@oss.qualcomm.com; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B X-Authority-Analysis: v=2.4 cv=UqVu9uwB c=1 sm=1 tr=0 ts=692af291 cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=FPK7cjBCgYbqzSTDLBmM0Q==:17 a=IkcTkHD0fZMA:10 a=6UeiqGixMTsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=4IEakBAXEm9B9VIJy2sA:9 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 X-Proofpoint-ORIG-GUID: Y9tbrvDGombm0U4zLI25xXKdJ-RVMWSa X-Proofpoint-GUID: Y9tbrvDGombm0U4zLI25xXKdJ-RVMWSa X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMTI5MDEwNiBTYWx0ZWRfXzR31kXx+BquG 4Rb6T9gmyvHudIuz+1ByXSOMZz/KSiE9tsKseDC19782ifpZ0vAUpwbs1ZHviXrqrze2JlItvpC THMqjgMl9O2fyHQTUL9LxmRmgYu1WFK6nPEirGKDRPLEr06MlY+SerRvPtOxkckBbhc/4dFekJL sVZscUBaZigE8L+xhbKgSwOtgdNGqeEn4wmcGKCRpazLM+TBThvxSJU/+ahS8NPJWO4urUlTvDv +c9Dy08ZxeQ+JzLewmJWFFESArd+twFl1jUUojkM7jtAodeI8sooaquvxrT0eGrEUOVba9WIx41 vemORnSSfIgfbKr3SQ/CGlcoClD092H1NyzvNUDCQQ8R1lPAo8Yc5+xN3WLbmhWoygByAMPweTA H8DpeEE7KWjZWuN8+uPO57tKZ018Zw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-11-28_08,2025-11-27_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 spamscore=0 impostorscore=0 phishscore=0 adultscore=0 malwarescore=0 suspectscore=0 clxscore=1015 lowpriorityscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2511290106 Commit 6e00112d31c8 ("ASoc: qcom: q6asm: Use automatic cleanup of kfree()") did not make the code simpler but more complicated. Already simple code of allocation and free, without any error paths, got now declaration with one constructor followed by another allocation, which is in contrary to explicit coding rules guiding cleanup.h: "Given that the "__free(...) =3D NULL" pattern for variables defined at the top of the function poses this potential interdependency problem the recommendation is to always define and assign variables in one statement and not group variable definitions at the top of the function when __free() is used." Code does not have a bug, but is less readable and uses discouraged coding practice, so fix that by moving declaration to the place of assignment. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Srinivas Kandagatla --- sound/soc/qcom/qdsp6/q6asm.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/sound/soc/qcom/qdsp6/q6asm.c b/sound/soc/qcom/qdsp6/q6asm.c index e7295b7b2461..890a1f786627 100644 --- a/sound/soc/qcom/qdsp6/q6asm.c +++ b/sound/soc/qcom/qdsp6/q6asm.c @@ -335,7 +335,6 @@ static int __q6asm_memory_unmap(struct audio_client *ac, struct q6asm *a =3D dev_get_drvdata(ac->dev->parent); struct apr_pkt *pkt; int rc, pkt_size; - void *p __free(kfree) =3D NULL; =20 if (ac->port[dir].mem_map_handle =3D=3D 0) { dev_err(ac->dev, "invalid mem handle\n"); @@ -343,7 +342,7 @@ static int __q6asm_memory_unmap(struct audio_client *ac, } =20 pkt_size =3D APR_HDR_SIZE + sizeof(*mem_unmap); - p =3D kzalloc(pkt_size, GFP_KERNEL); + void *p __free(kfree) =3D kzalloc(pkt_size, GFP_KERNEL); if (!p) return -ENOMEM; =20 @@ -428,7 +427,6 @@ static int __q6asm_memory_map_regions(struct audio_clie= nt *ac, int dir, struct audio_port_data *port =3D NULL; struct audio_buffer *ab =3D NULL; struct apr_pkt *pkt; - void *p __free(kfree) =3D NULL; unsigned long flags; uint32_t num_regions, buf_sz; int i, pkt_size; @@ -447,7 +445,7 @@ static int __q6asm_memory_map_regions(struct audio_clie= nt *ac, int dir, pkt_size =3D APR_HDR_SIZE + sizeof(*cmd) + (sizeof(*mregions) * num_regions); =20 - p =3D kzalloc(pkt_size, GFP_KERNEL); + void *p __free(kfree) =3D kzalloc(pkt_size, GFP_KERNEL); if (!p) return -ENOMEM; =20 --=20 2.48.1 From nobody Mon Dec 1 22:36:21 2025 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 465D530FC0A for ; Sat, 29 Nov 2025 13:18:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764422299; cv=none; b=YQ4wveTwNDLFcOb0RdLrMSd67cby4sDDemPjtucMisaBYdBaSR7D1LVdo+6Yo890EmJ5eB/6bfTut/JhJ5leZWMe7mIW3TDS203xA7IDcHvkUPHV6wRUbQdEx2pUkMC26+6Ic+pKi2FainiDf6hUd5BpzoL5SDGltky1msZjsoo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764422299; c=relaxed/simple; bh=exQ/yW6W3oFPrfMP4HI+spVKk10NGLuEbCbL4D1Pc5I=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=jcb5lM3JlqwHdQ4Q5IcSwSHc2OR9OoZ/RqfiAeyNKMotOfbCDTH9ipY94pwZB7QpoCXaipwqppDQBuvtb4No33ACxIsR5A/fLMCRiuBxfUQMMPpGqU0meRanQoW+0YjHpHr6Vh0w4mO7wMHNvkcuBrQAn4jTz+X10fDAx+6jU6o= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=fNP+TS5t; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=NcWl0ZUC; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="fNP+TS5t"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="NcWl0ZUC" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5ATCeIe92794425 for ; Sat, 29 Nov 2025 13:18:11 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= uqOWIv7cuGi+zf6ysvS9UOkW7C7nCr+feFlHqhg/kcc=; b=fNP+TS5tkR2tGdXw VrmGtDkE8izfleAbFKWeYAmBDPvDopa+1maDpAga1AYOdWj02JH1xCyh4jHAN6H4 UEh+p8vCCUelOdCeR22X/3sH9/vYnZVM+ErCxH3pXHET3Nk0ccGWUwmHD1VIhPbC MGMkCoZdCE+qqLuOZSTOBrvajjpDNR+e6zIU2c7eJkrumAoc9CqzVqbtK1j/HD1L vaCwfCYI/fuQPAJiAHGrctQFCLOrveCSAgZA+8B7H1JOMb9YvhezzIRRZ+Ri/ois arDNtARUJ1KoMgIOhcGdGHZVSmm4mUl3ZiTkLg0dNpjQwj84FLLwBb7rmylYUTxZ R2c9Bw== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4aqs20rpps-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sat, 29 Nov 2025 13:18:11 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-8b52a20367fso522742285a.1 for ; Sat, 29 Nov 2025 05:18:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1764422290; x=1765027090; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=uqOWIv7cuGi+zf6ysvS9UOkW7C7nCr+feFlHqhg/kcc=; b=NcWl0ZUCmAokNlhV9ffjNrG6XGSlc8oR5tRhu/dNQHT0LrL7DkGSs1BZYOXLj89uOM jqX52r7KXwNQkqjh20HR1kX91FVYSe/kjk817d16t2srmqTnrhIa6cKPBxj7sccvGqOj k2VO5CCS3O+UDmI/HwyH8/vGeNCivQjgQi6XShHGo0+7gBwpWYf+j8X/q9oaVP7tVnOy KhN+SjBOF+F6DYbJfK2JeoKQKH/7uHABfmro9fIIB/yjGN6SV3Cd2zFurNpJgBnzWZGG 5xhq8yuVaSndttZK3leFyBAqDrDJkiGT2IbIBsMfT9KpAUXM9YS0q+z1+0pjPf7WriZQ s5vg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764422290; x=1765027090; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=uqOWIv7cuGi+zf6ysvS9UOkW7C7nCr+feFlHqhg/kcc=; b=fgLArTchlm/nMiDfW943+RluOgEvDI54W3Z3QDf6etts8xNq8b+IWyPza7iV8Dswow IskMLi9IZddQYGhGCfrAcmyaklgfajHzy0K01/3+RVsi9cP7nNv1WrQ8C4tVqGhr3oXJ W/rjcGq0IHmZM+9u1RKiBYk7jEfMl5ocof1ftw4NomXzKH6CQVF9H83CnHDeWat1+JXJ +3Yx8mHafCmiOP2shdkpGt4f8Bjt6yyzCf5OLbjUmmJXfR6Zsk9Rr9xaa+dyoLtoyyoe TE+KreZmBQntu9rmHZYdtf5mo+xm42nrLS1+TtvUzg2nbCOIBevn8t1arYuU5D+QyTbY SUiQ== X-Forwarded-Encrypted: i=1; AJvYcCXef7aKVn0AZhnXL2yIGso4Tko8JBBMFB0ypHnqUCQLPIFygRnMkXhXX+v9W90UiIKM//Nf7u7zSPLd240=@vger.kernel.org X-Gm-Message-State: AOJu0Yx7cNqJCpPMGMoh3mCbrtM7iAvVkOimQEu4QA98ys1sPpIvITay Ml2j59la0h1s1q5kZ6VR9LGB+vRoqErzQlruidpslNXhLurPF/fMeKhZlZXdMsWo13sjz3cMVk0 SB2f649k07C55ZL6qjUf/1ptm2KWYxBW2TAkmCKjN6vX/77J1y/OcKpWLK+KhPR/Aqb8= X-Gm-Gg: ASbGncvpkx5kKKi78hpy7rkkNuJjG965ClQvk6c6D05ztkjpHwB1qJNpvZFFPyFFRM3 0FIjtbVLdWCNf23n+gNceQRNyp1Sgkgv+xjsdNI6m7SR035QK3xR3lfe/Lasy1lFNF07Siq0jxW cinyowI90ORV10dUdD6rypt/K2EgZDRLWF1yzVRcblmUXJ1LeZYRDEkDlGbS6b3pwM5PZo0gyuV WehlLhxGbHaZggeThHJ/E+KK+2qMWnXpVuh3XeWc0UxLVATAiVQfwez5x4TdpKAxHuytyN1fxt0 CdrJx3ajoY5FQg9PsBT7z2H95i4EFpBWk9TZY9tVTHVlWbpwEmWGTY6ypNUS+4NaYQ7epq+gGrX sEBfcyv8FKKtC4N28uqCGnBG9m2NFKr74zA== X-Received: by 2002:a05:620a:2a03:b0:828:faae:b444 with SMTP id af79cd13be357-8b32ad1083bmr4884678785a.20.1764422289978; Sat, 29 Nov 2025 05:18:09 -0800 (PST) X-Google-Smtp-Source: AGHT+IG4lkIqGig4+ZGnJmui4QrJUzGkERmpZnJO5dkx5PRWlptxsWG94htFC/N53bln4MHSvlgMOA== X-Received: by 2002:a05:620a:2a03:b0:828:faae:b444 with SMTP id af79cd13be357-8b32ad1083bmr4884672185a.20.1764422289418; Sat, 29 Nov 2025 05:18:09 -0800 (PST) Received: from [127.0.1.1] ([178.197.195.159]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b76f5163903sm723233866b.7.2025.11.29.05.18.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 29 Nov 2025 05:18:08 -0800 (PST) From: Krzysztof Kozlowski Date: Sat, 29 Nov 2025 14:17:55 +0100 Subject: [PATCH 3/6] ASoC: qcom: q6apm: Fix confusing cleanup.h syntax Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251129-asoc-wrong-cleanup-h-can-people-stop-sending-this-without-reading-docs-v1-3-c38b06884e39@oss.qualcomm.com> References: <20251129-asoc-wrong-cleanup-h-can-people-stop-sending-this-without-reading-docs-v1-0-c38b06884e39@oss.qualcomm.com> In-Reply-To: <20251129-asoc-wrong-cleanup-h-can-people-stop-sending-this-without-reading-docs-v1-0-c38b06884e39@oss.qualcomm.com> To: Srinivas Kandagatla , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1924; i=krzysztof.kozlowski@oss.qualcomm.com; h=from:subject:message-id; bh=exQ/yW6W3oFPrfMP4HI+spVKk10NGLuEbCbL4D1Pc5I=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBpKvKIMZsFaLBHAEasSphZnnag2VVGDy+bICMru B1tmp5FYI2JAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCaSryiAAKCRDBN2bmhouD 18sCEACRaKsEHFkmdS5a27kd2Q2I6Wl4PYVLFz9ZU6hmzMWHMRExBbZHVx/R+9LDqGWhW0ou/RD uu3rlm200VJ15DtesrM/DGnttq2WCm17gQEI0a0r5o35WLn56W5d73eatxm527w0iEWLZTrklGg qSZ0frlRI2Ljhh1cg5GpR0hCAqLXS1hEBvSRYRrNWn4kU/NZUKpozqz3Is8r3XZNBJR0f9lqlIF o6QdmtTU9RQj7h7N9j0K+zG0kSym3GtGAh7DKu5dU5jWxWrLPkdtYf67c0S3xo/qyijy1ixqC19 k/wv/lwBK3jL3NB8pAZjbEqdzwlwlM+2e62CLTOu3NULHpGyguAs9aPAoqhmKEDb7w2Vm7kvaVn tm9W4M86Bj9bgnxueGAaM+1goahU1G/7CoiM2PD/iSHcSZdwBkb7sojsjfIJduU+T7igm5KKZiQ iJBvJuNNOABQDOiyF1vWUx22fjmcabe+lBz5FrSDdwoU5+RVohBCpBNWu48mzxJg6Ft31iildGE YaXhK/yqDcZQ6Sp9evxPjdY/i3uAt0J1Zrs1YvZSU0tg62w44yffpuIgybTeppEyLS/MPMRG4C5 35QjvGExapOOFxJo+m9mZ6g3ohrybypJny0pxvRTXesdK/y4IKVW+HcPMvi1dnAo8FXiuGCtko0 fvbThPM4e61rP5w== X-Developer-Key: i=krzysztof.kozlowski@oss.qualcomm.com; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B X-Proofpoint-ORIG-GUID: uFW4hG2YgqsW17BwVEPcsvBg-Kb3IDCs X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMTI5MDEwNiBTYWx0ZWRfX6qMaifSKAakw p3twRK2XNoAvOulkUU+Er/CqYSFVDY+ov7MHyuFMM5Xgfu3b9bbIQVT7Unfj2sCwR4N+2C6x55o 6h39Msa9Ir4Ex+UToxJhQP2FcQ47eJMbnDfUaO9anjRQk8ugJFGsVccWr+g/7eldc07OKTcHsgw feJbX85Ud/pokrVRrXfCikUTa+VlTTfPhRakDPAtNdDEja5dz2A56rTmb/AMzd41aaqKY0xMOui GkU/sxwDsda/gpesZnY1fAFvATSVRTUMt+UtpB2O/i7tvk2JyjbHOHIeB7EH9OeZI+2XdNSeI8Z 37trnkXz5UaTr9lsFJBH9pTFXvQkFSu+pRF9zcFcUXDSEdN9732rj+XLF9Ag3hvYRBj8CJDNUuS stC2f1/OUhHGMfH2jcYIA+MF8S0hpw== X-Proofpoint-GUID: uFW4hG2YgqsW17BwVEPcsvBg-Kb3IDCs X-Authority-Analysis: v=2.4 cv=EqXfbCcA c=1 sm=1 tr=0 ts=692af293 cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=FPK7cjBCgYbqzSTDLBmM0Q==:17 a=IkcTkHD0fZMA:10 a=6UeiqGixMTsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=ioz4TsFobKP2bM_RzkUA:9 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-11-28_08,2025-11-27_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 priorityscore=1501 suspectscore=0 bulkscore=0 lowpriorityscore=0 adultscore=0 spamscore=0 phishscore=0 malwarescore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2511290106 Commit 89cf2223ee7b ("ASoc: qcom: q6apm: Use automatic cleanup of kfree()") did not make the code simpler but more complicated. Already simple code of allocation and free, without any error paths, got now declaration with one constructor followed by another allocation, which is in contrary to explicit coding rules guiding cleanup.h: "Given that the "__free(...) =3D NULL" pattern for variables defined at the top of the function poses this potential interdependency problem the recommendation is to always define and assign variables in one statement and not group variable definitions at the top of the function when __free() is used." Code does not have a bug, but is less readable and uses discouraged coding practice, so fix that by moving declaration to the place of assignment. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Srinivas Kandagatla --- sound/soc/qcom/qdsp6/q6apm.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/sound/soc/qcom/qdsp6/q6apm.c b/sound/soc/qcom/qdsp6/q6apm.c index 94cc6376a367..4e5ad04ece50 100644 --- a/sound/soc/qcom/qdsp6/q6apm.c +++ b/sound/soc/qcom/qdsp6/q6apm.c @@ -259,7 +259,6 @@ int q6apm_unmap_memory_regions(struct q6apm_graph *grap= h, unsigned int dir) { struct apm_cmd_shared_mem_unmap_regions *cmd; struct audioreach_graph_data *data; - struct gpr_pkt *pkt __free(kfree) =3D NULL; int rc; =20 if (dir =3D=3D SNDRV_PCM_STREAM_PLAYBACK) @@ -270,8 +269,9 @@ int q6apm_unmap_memory_regions(struct q6apm_graph *grap= h, unsigned int dir) if (!data->mem_map_handle) return 0; =20 - pkt =3D audioreach_alloc_apm_pkt(sizeof(*cmd), APM_CMD_SHARED_MEM_UNMAP_R= EGIONS, dir, - graph->port->id); + struct gpr_pkt *pkt __free(kfree) =3D + audioreach_alloc_apm_pkt(sizeof(*cmd), APM_CMD_SHARED_MEM_UNMAP_REGIONS, + dir, graph->port->id); if (IS_ERR(pkt)) return PTR_ERR(pkt); =20 --=20 2.48.1 From nobody Mon Dec 1 22:36:21 2025 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3A3E127464F for ; Sat, 29 Nov 2025 13:18:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764422294; cv=none; b=AV9ZWQ7n9tBnO65dwLwzzBsAiFhn1rLEGT1eIUctUWGat72CeH3m1BRw988fj+r8B8Mk3wwgkq5Ao3vb7SyrfLfAs3KjGh9T6djz1yDVRuwLzh071xLdNvC1CaJSYyPuc/vjJ+5CRGqZo88h/2lagoR0m43Au+aUfmcuN6TDyn0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764422294; c=relaxed/simple; bh=rFxrLG6iFK7DhIqNwVyLA6RFcipWa+9ielcQ0jNpcW8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=UiuoYel2Glfl8MVzPrFF/2PvDsOT/FXQqC7LelGthMtCq3RiGfi3wY1PPrYztc7QlSgpQUza7itBIchqx7ybmxB5p2J/WIWuVTlagN2eN6j2vgPaKG1ZyADd6ajCF9EIzuHsKsaNCIxh0EH/leBwu4WC+WEL/TzeRP3ALM9h0J4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ezhJxcfs; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=HT5bar6r; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ezhJxcfs"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="HT5bar6r" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5AT4enlJ1267170 for ; Sat, 29 Nov 2025 13:18:12 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= WRdTU43px+9dnjQpkvdch/AXAnGzM7VVwsbwnmdMUAM=; b=ezhJxcfs8xdJTJwq 3j/p1xuLBzs4hlIijvw9/D3/7jOt8ky6h9jnRYZ1LKv0rnMZpEs7IfE6n9KYmy2D Ntc0GLOc/58gn0nX5coJyINXoXzqDyt95Tj76JTBYWmhS0wOHmegGeWxh4VByJkQ BXVIEoGjSccPBnOy+0EmYiIqHLxyi+f0Z9WodoKoChrrp38yzx4js0+edkPrgfd4 Mz6C6nDyWDDDsiM15CpcC8H90nF6LjQyA0e2vKeFYm3OhPbBgzRXqYcp1P2t2n3y QNX8aj6+ZosjiIwNHSJ5EILh8RNA7kZekVgHMamKTtRCRpkR0uP63kuY0yOFi49M vrQoIQ== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4aqt0j0kxp-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sat, 29 Nov 2025 13:18:12 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-8b26bc4984bso779401485a.1 for ; Sat, 29 Nov 2025 05:18:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1764422291; x=1765027091; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=WRdTU43px+9dnjQpkvdch/AXAnGzM7VVwsbwnmdMUAM=; b=HT5bar6raqcn31kqmKESH8dZrH9A9zl/kbygRHy0PI/WmTIC//exHghBQqWCjkenAv dEbh1d/H3DffbkR7EW/tlMGMDQYPxZ7+M6ihfYTE90n/PDp3EKOp73w+i2Pdh4/EtYNJ KdJVmxD6V9+eBcXj83PFvU0WvM7MjtpBR0mZJlzDD66UdVYut9PQVQCcOx7wxYb6U34N e7N6INcYuGR5K9uEcRJ5bR895gpiC0qVwdnBwjyj7IqQ4M1fVqhh39BzTzy7ffdgTIA5 NPzw6b+fwJCWr5BODAc53xp5yxbOVPzysE9Y5gUd95SG3SMaIloASyT6sCwB1fdwBXbv MWDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764422291; x=1765027091; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=WRdTU43px+9dnjQpkvdch/AXAnGzM7VVwsbwnmdMUAM=; b=EWmTXZoJBZhFPw8qWf8jSmR+uLSLWF1ZA4Cp8XjDiEkBnx2BHceh0NDKkSmu71UVYp GkVNWE0lpBVRWaIedIUcmUKRTP4teA8APLFtrAA2CP2x4hfwmWRXvf0BUW6BzPT/ag9k YVR/GlF8JMt2CT1CcyFfSGfmQn51ylkYq84W3m6ZM9dtByDzgA95nhDbvpt42W9yA50g rm01s5Ys3eeEZkNVhQUX4BKVU9CeS0w8eSQQRxUL6RyvuNVYhI345TcIAifQgwO4Nvl6 RGcADeKM1/hes0fr1l3e/pEiPr7xrjbvVVjBW22C8lY6PUYL00C3T98DRqj6+1a6e6K4 K45A== X-Forwarded-Encrypted: i=1; AJvYcCXdlvDEwOy4vu/G3tWCFTG76/y6q0r2j47wizmfuJsfwomfFuZa9SNHQOZ2ZfciLuAVdPY/cfHQA+DOdtQ=@vger.kernel.org X-Gm-Message-State: AOJu0YzlSUfv3w+bpMmD17hU8/j3eipQ77L/c8/DjcZNswt6iJ5ZsOfP JPavViec/f3eBIGOd5wA79KHa6XQXd4XBMD04JgsPqRW2CqvAj9DNvf55QnuOqb4Q3nFOs45Nd+ Z35NrWOO9UiGFdhnwqoWlBrkGrOAivFeg2HwbagwHuEMasN0cOrzBtH/FnVNdMeTNWXA= X-Gm-Gg: ASbGnctJmO76GLJJqnjZeeTNRfc1mzf60/e9n/AnoZctDdrrLDAge+weJuQhUUbWeKA XEa9dPm0P8v8Zsp5WxnOUZ/X/DCnSo0By0fUU/AviXKmHzoug5LCbBt8HUcD3rCr47zBio9ZiRU UtKxeWalDaZz74Q+bmSYtpUa83sxP1oCyJEUJguw//i8SvSurGMXXO3E1WMF6h2dv5IA/urBQRL y2FVeorQpXaGsr5TcyFJHBp4JVNJ1MkJydx8s2E26mijDBBIaAX0mVSNSdSKnw1cReLwHVLt/gM 578LgqdFMxwCgnTmJqm1SHl61dA+6mg9fKuE1DTPT1AISEGH9MU2Ii1iRFEQsA+87TvkapniWRV CXG3c8lnoRUHXg34bnOmctmo9w1EKM3KNpw== X-Received: by 2002:a05:620a:179f:b0:8a1:b435:984a with SMTP id af79cd13be357-8b33d4ccf48mr3896154585a.69.1764422291432; Sat, 29 Nov 2025 05:18:11 -0800 (PST) X-Google-Smtp-Source: AGHT+IEN5WjeSaw/et52cC/POlt9tqBhJcGDS2ZYifyqsF2haY8nXfZ5eGR+ClgfmHNWFxVc9rF87A== X-Received: by 2002:a05:620a:179f:b0:8a1:b435:984a with SMTP id af79cd13be357-8b33d4ccf48mr3896151185a.69.1764422291023; Sat, 29 Nov 2025 05:18:11 -0800 (PST) Received: from [127.0.1.1] ([178.197.195.159]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b76f5163903sm723233866b.7.2025.11.29.05.18.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 29 Nov 2025 05:18:10 -0800 (PST) From: Krzysztof Kozlowski Date: Sat, 29 Nov 2025 14:17:56 +0100 Subject: [PATCH 4/6] ASoC: qcom: q6afe: Fix confusing cleanup.h syntax Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251129-asoc-wrong-cleanup-h-can-people-stop-sending-this-without-reading-docs-v1-4-c38b06884e39@oss.qualcomm.com> References: <20251129-asoc-wrong-cleanup-h-can-people-stop-sending-this-without-reading-docs-v1-0-c38b06884e39@oss.qualcomm.com> In-Reply-To: <20251129-asoc-wrong-cleanup-h-can-people-stop-sending-this-without-reading-docs-v1-0-c38b06884e39@oss.qualcomm.com> To: Srinivas Kandagatla , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=2219; i=krzysztof.kozlowski@oss.qualcomm.com; h=from:subject:message-id; bh=rFxrLG6iFK7DhIqNwVyLA6RFcipWa+9ielcQ0jNpcW8=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBpKvKIqVWoM7pPky84XR61xbxactJGJ+7aWo4UZ j8itDkFWfuJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCaSryiAAKCRDBN2bmhouD 18PVEACLxagZMgDxiT/r/NQQytM3sDdCluOz35+qCRhmnWmummLyjxzohBsaFWg9FQJfwbMuJHa NnPHOPFFceF+i2iXAiI4RTiAa7EyLx+rUhbWmnp1S8MfO6ymShCxmEk9RZq9ny5QuxHghST6Ke/ 1EW97h/bPCgZ+BcmbnVIXP/Z+BV6rpI4KeVKFONUsNd4fVW+ZY3sz8k8LsmYoKuk7MoajWWYbgo WqF5z7rXvnNuoZDb2ulGNykJidQhmF/ZAUBShCzu8Lwv0IxVL3UipHfltm1HcYM5XGbFaBDE86L 15Ep5Mr96HIMJxT1MRXaDAq0peyS9Hq0383oNS/XakSJ4xKpOoY4ayJHnFJUGM4oCI2A06xJdm5 /agFjJdAx+zRDtVd5psjpJZf76YyX3JmgE6kUfx2LWKXNKS6q6yIqgYhDgpFflsBQbZIwwitgii qz5ygsItnJXma3DWX9GPcdlOUxb75VUThvGDL1vm852KqeqD9nnlm2h15RmE9bQsBt0U/Fj4ZSL 1PcIGQfcf6ChC2dMsIosRZR7lmcgNMCUF3Wd1sGT0YDQs5/HuyFjWaNWmaQTH9WAHl1xkd+wm69 3Bgt8ITddrcR9Qg+Gmc70lIzqydXy0U9eidVd0DIdkMrEp9TPeDAmEj5sNuCWaQ6uL+P0OijyoW zw3YW0T2ny3mneQ== X-Developer-Key: i=krzysztof.kozlowski@oss.qualcomm.com; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B X-Proofpoint-GUID: wEkTgtXr_b7cu6NOEUPSuHDd9fb4cfoL X-Authority-Analysis: v=2.4 cv=WpYm8Nfv c=1 sm=1 tr=0 ts=692af294 cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=FPK7cjBCgYbqzSTDLBmM0Q==:17 a=IkcTkHD0fZMA:10 a=6UeiqGixMTsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=5W2fhO5o7LvhZa0qPfoA:9 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 X-Proofpoint-ORIG-GUID: wEkTgtXr_b7cu6NOEUPSuHDd9fb4cfoL X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMTI5MDEwNiBTYWx0ZWRfX0h4/JW59/SQD Gst5sESBh9xohfG9+RUqGqVlajXvWvRWE1b7vuMrP+I+WwZ3tJultAQZQDYcY5zaBgK6g4kfBV4 6tgg9OOGgY597hIkp5VrymS2SvSW+6uX7DSi3wPgqn8f3bWD4ASv+LMMt9RCVkFWUqoDVVG0AiK DdKcn4hkTfsG5hvfhubxJac+8bUQwCAvEEciNXcLQwXfr2CgmrNMtMyEkJhKyms4yj4ESliczLv PZWQLMJyyU4LMDSM8PHefO8UhYJXYAtQCwGFBRnRB+op/6pcO4KE4pfb1jcCR8z2V4LE+QNOHl9 p9OppmOTx+kiHGdJwD++MxA21+gI/qPwJOTwXAgKUEWeuhejsRx+RKMtcZk6XdUvWRMIvDPa7XR Eleqw2VlQbA7XrnkQ8th8mjJVbJ86Q== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-11-28_08,2025-11-27_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 adultscore=0 phishscore=0 malwarescore=0 bulkscore=0 spamscore=0 impostorscore=0 lowpriorityscore=0 suspectscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2511290106 Commit 55094e55ae36 ("ASoc: qcom: q6afe: Use automatic cleanup of kfree()") did not make the code simpler but more complicated. Already simple code of allocation and free, without any error paths, got now declaration with one constructor followed by another allocation, which is in contrary to explicit coding rules guiding cleanup.h: "Given that the "__free(...) =3D NULL" pattern for variables defined at the top of the function poses this potential interdependency problem the recommendation is to always define and assign variables in one statement and not group variable definitions at the top of the function when __free() is used." Code does not have a bug, but is less readable and uses discouraged coding practice, so fix that by moving declaration to the place of assignment. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Srinivas Kandagatla --- sound/soc/qcom/qdsp6/q6afe.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/sound/soc/qcom/qdsp6/q6afe.c b/sound/soc/qcom/qdsp6/q6afe.c index 980851a12976..c9fdd53492e0 100644 --- a/sound/soc/qcom/qdsp6/q6afe.c +++ b/sound/soc/qcom/qdsp6/q6afe.c @@ -1277,7 +1277,6 @@ int q6afe_port_stop(struct q6afe_port *port) int port_id =3D port->id; int ret =3D 0; int index, pkt_size; - void *p __free(kfree) =3D NULL; =20 index =3D port->token; if (index < 0 || index >=3D AFE_PORT_MAX) { @@ -1286,7 +1285,7 @@ int q6afe_port_stop(struct q6afe_port *port) } =20 pkt_size =3D APR_HDR_SIZE + sizeof(*stop); - p =3D kzalloc(pkt_size, GFP_KERNEL); + void *p __free(kfree) =3D kzalloc(pkt_size, GFP_KERNEL); if (!p) return -ENOMEM; =20 @@ -1667,7 +1666,6 @@ int q6afe_port_start(struct q6afe_port *port) int ret, param_id =3D port->cfg_type; struct apr_pkt *pkt; int pkt_size; - void *p __free(kfree) =3D NULL; =20 ret =3D q6afe_port_set_param_v2(port, &port->port_cfg, param_id, AFE_MODULE_AUDIO_DEV_INTERFACE, @@ -1690,7 +1688,7 @@ int q6afe_port_start(struct q6afe_port *port) } =20 pkt_size =3D APR_HDR_SIZE + sizeof(*start); - p =3D kzalloc(pkt_size, GFP_KERNEL); + void *p __free(kfree) =3D kzalloc(pkt_size, GFP_KERNEL); if (!p) return -ENOMEM; =20 --=20 2.48.1 From nobody Mon Dec 1 22:36:21 2025 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 29DA030F81F for ; Sat, 29 Nov 2025 13:18:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764422296; cv=none; b=dKPMgs3aGTNIFzXa+50asbVAptcdazs622mTDn82dTtbYMaCmKxEBvsFmnCIOH1ovqSNNj521Q+CJQn+15e9Vgb7wUPFPQEVmiXEZHjAZt8p9tDQT8tw0wmJ9pUVmaPCAJqvXcAoxowiXcUzvxqcHYWv1hJPkljN9z+1Kne/wFE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764422296; c=relaxed/simple; bh=K42eh0RgaQ7SkV6aLlbnaArKT2lLyhObgyt79d/hoyo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=bVx6vR+KXwCGq/Mt+ZN4czcirrPmgBmXA8+aXRT1bNUDqcGmFfCipFypDh/oUSzhlY3lx7am+ZC45wrg9cEJFYUNkovqefwIGWXdPw7Dcomwk0dTSnMfeptOJIYBUlUMJuLTQP4FIm1jDn4phL+icj09/AbmR7t5AEMs4EiqJgg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=dd+I8FQq; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=GQ3Bz/BO; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="dd+I8FQq"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="GQ3Bz/BO" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5ATAtV742523740 for ; Sat, 29 Nov 2025 13:18:14 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= ay8cTpgGplkj5cCus4XuGSNhbbp+i2Dv1oJU3OIxNtU=; b=dd+I8FQqD9ZhR3/T wVldqEfZpUSJ8BM6fHasr+RIkg4TCZ+8BGVCtr3dMsZXd4jSK0rwsyCAIzx2nR3r OisaeVgypxC96iJ2e+Q/zcZFTTfnHEdmLhJSwy7wa9DzzGL5aKCZP7HdFfMNcT90 StVKjubnEiV3liSqM/jTLYXJw52r+Z9xg6G9M2uAWtawsFapVRd9poxdmQXB4J4y G4/SIQEaGEekXi3CscJUo4hxuiB3B/25yoM4PU2YJ4ZPWJgzpOGox224ddBPdmnF m3arCvNEPg0w0KifwLr04RjOaGUnq1Hz6A2YMcJLK5O7PJBzjh0IkqcpyFoT1Rxo FQ4zmw== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4aqphf8wx5-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sat, 29 Nov 2025 13:18:14 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-8b286006ffaso475096885a.2 for ; Sat, 29 Nov 2025 05:18:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1764422293; x=1765027093; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=ay8cTpgGplkj5cCus4XuGSNhbbp+i2Dv1oJU3OIxNtU=; b=GQ3Bz/BO0w76VTDfFCqhh04zYrm+RSB68TJl+moPICBlRdjWhFs9paVNxyk2pMMDtk jtDrdpxQORtc0j4Yra7812MPIQc8+pAWOB66/HkE6ahZLxmvAp5ULzhjV1+NXO+jgYHi I2iuTDFLpv0ADCYS51KtRVaMa811w9JlayP5m6V8F9+UTIznwwCBnp6QLJ3tq9dEoD29 tCR9BLDFkU7qLGmjPBJJIEOsvXuB+XJVj8kLVOU0JthOSS0pEODNejJifdZwYoH43WKg WrFMAP21EXsrbIp9BSbGBueX6R0UBn0C9dmRfEfV+ZMT53B4n0LQ0+974KeAdlhU/mb/ IgCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764422293; x=1765027093; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=ay8cTpgGplkj5cCus4XuGSNhbbp+i2Dv1oJU3OIxNtU=; b=Fw6GfXUXuYNPN3AoQ47GLoZzQgApQhraZZWEH/qX/ISHycsU2V0Hes8zGjh+0Ovvcg 9SdPvqpx2NERxxO+r9U1DkuFctqjEqRRlVJLyG3vcrKbjxixygVxYpTA822uiJSmpzFd RvfZU00U+Lyl1u0hhFYdnDmIaE3lRhzqO9zUKWcpgFLOvvAvwnwYZSk064n3z9yCnPno ma+IpozXEOgiddv0KeuRsOyz3YVhYvnR1tf/nr0SDe26cZeMRwHr+vNAJkb33ET8iitd Jmt7qhA7ELfq4NN0SYeKFmy/qqn0MMOAwQni2fHnlnbvPeNdqvqLCpfBzwiKnJY5R3/f LxLA== X-Forwarded-Encrypted: i=1; AJvYcCUNApvC1cJVrsIy3oCfr9G6pkUe73PZihQK8fwSgfG2WLupkIegBlut0PiH5NukEAmtwTh7PayegqfEVrI=@vger.kernel.org X-Gm-Message-State: AOJu0Yw+5rZaq9+uFB0LvgoR1zLn28BS3pFie9I7gbhL7hwiRd+5OuOI MwQxBKGnctmrUg0gzyOclVQ+Q62Zh+lNhc89I/8syAphCjF0KNaImQkFfmUMU/qeNIiYxfmj3tO 72lKm89LYJvxGrnpfzmnL35Q3dN9HoHgcEVlCxCnS4i9jkLpryLFK9uMZIYMLls/nMtI= X-Gm-Gg: ASbGnctMtEOy9QRF2kD/1CRj1VgbH+VCOQYUFxsggJZJu3CXp8sAQTms9SYilgym4Bc jaxbxFniptfYVlpDiS2OT+7J9yBfhgTLOqr5GC2r2rxRokpWeanxjt2HN696yQWMZcrtP1nGQ7M xmQdzvT4v+yTU63bV0wvE+nFK7fdq4mPQk7krzEBvyFYe6nfySMdeYOdrwXTTwgzEN1c/uTOWVA BVWQ3HOG4t70/F69r1oJLdHiKlWuMWepf0hGWeq9FGaaf+TPIrCGZvNOcwVP72CtB2AWtQAslLw FkwjH393PdgstjGhJkhP6mcyXj/+Uu3PY/ZxNO5ZP79O5j+VZIE25d5tuF5Fr8cyORSctmLU1km RHTo/vwG6HDRrxRs1TtUb8OxhAbGxZLZZkw== X-Received: by 2002:a05:620a:1a2a:b0:8b2:d72d:e41b with SMTP id af79cd13be357-8b33d264190mr4143715485a.44.1764422293070; Sat, 29 Nov 2025 05:18:13 -0800 (PST) X-Google-Smtp-Source: AGHT+IEcLqw0fi2RGuk5nN2M4NnxKzhuzY+4reV3PrURPNdhTmtrfADCkI5j0oYE/bLnP7F+gaFR6w== X-Received: by 2002:a05:620a:1a2a:b0:8b2:d72d:e41b with SMTP id af79cd13be357-8b33d264190mr4143710885a.44.1764422292612; Sat, 29 Nov 2025 05:18:12 -0800 (PST) Received: from [127.0.1.1] ([178.197.195.159]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b76f5163903sm723233866b.7.2025.11.29.05.18.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 29 Nov 2025 05:18:11 -0800 (PST) From: Krzysztof Kozlowski Date: Sat, 29 Nov 2025 14:17:57 +0100 Subject: [PATCH 5/6] ASoC: qcom: audioreach: Fix confusing cleanup.h syntax Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251129-asoc-wrong-cleanup-h-can-people-stop-sending-this-without-reading-docs-v1-5-c38b06884e39@oss.qualcomm.com> References: <20251129-asoc-wrong-cleanup-h-can-people-stop-sending-this-without-reading-docs-v1-0-c38b06884e39@oss.qualcomm.com> In-Reply-To: <20251129-asoc-wrong-cleanup-h-can-people-stop-sending-this-without-reading-docs-v1-0-c38b06884e39@oss.qualcomm.com> To: Srinivas Kandagatla , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=3530; i=krzysztof.kozlowski@oss.qualcomm.com; h=from:subject:message-id; bh=K42eh0RgaQ7SkV6aLlbnaArKT2lLyhObgyt79d/hoyo=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBpKvKJhChddCBLhBKRSbGNkgZlGuVg4nlKETf1C 7mTifJ2ZgKJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCaSryiQAKCRDBN2bmhouD 11G/D/0cnEfCYwNasGSmG7h8qz2GmH3oCG7miSOIKZ9GkZtg2wdL1VibC/VUQD9GnBli6J8YUJQ FbNkGcE5PVp7BWr6VrTiciIqTVCEz5D3q570QdEpuxF3kb6aPYsQTN7JZKJfeYRmCB+7oCiUVzJ C8yeGmHkPs9Z9WXgYiIXFFAfJaayTZWmrmuuzuyutzbwqqlvI8Lunj1bfBPO6eW5Jo4/r86NQdV //G2Z+nbz2D8VsUZOii+BWFIsXfpzjN91v79SSjuN8ILd1lYAEIu0RdZZ5p3DSpOiIo54zh2Upr A9iG7r/fHRfu3WqRK7uYsgEp4NxAbm7HtjEKohhSzsDaBKx6ruE5rA8DLq22/WKc2FUawIGVrq7 AOhO6boenwaa+w/O4j2dbGu9ddNCNzPKPMeXKCRh2ZIRArvdk7lABaeF4xSKbGOowi2vt6BS+T6 IWBCE1fczZW4V4Js/RzX6Tnx0XRMhpiVrbwRI2QsJmrgsWUcsB8j/MWYkyp1wei3mKFXCibzIQa UY/PDom4sNfMN2d6urgo61FSdzdS4vUXHlWYJaCL5gVQEhxwhljeBBTJ7u1U3MomWr5BOpcUcWd /Rm6gD+blGmzqjAfYeQY12kW8keAtYOeFAYf5kLf4Xo/NWIDzRnVLB2hV66vE0qpH/T6n5M7hmH fQLQsvjRVnqViSQ== X-Developer-Key: i=krzysztof.kozlowski@oss.qualcomm.com; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B X-Proofpoint-ORIG-GUID: TuovN0uX0ftviGatP3wl75U6rPElClvR X-Authority-Analysis: v=2.4 cv=FvwIPmrq c=1 sm=1 tr=0 ts=692af296 cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=FPK7cjBCgYbqzSTDLBmM0Q==:17 a=IkcTkHD0fZMA:10 a=6UeiqGixMTsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=C9bQe94teVNSW6X4EGsA:9 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMTI5MDEwNiBTYWx0ZWRfX+pElTNMhDjld yb41zQXJmi6IqgOS3WMJsoBvA53cDkkIe/ufqR0vWTsLEov4afYMZaAFxkqcsYDJsCV/Tv8VpFU HDn7VYyl8Twd/8abR4PcG45cFUXJz0cgJRqLS/BSrW3LIlK713h6pZI7dI5mmyvg854yYXNPB/A 0upA4WYxSpaCpfN3BYqsN5sjf0aS9IfFzsDvoP3r+BvhFEiHWNXKtTeo/lXJ3kbwA4Bwr2CH1wp 163AHvTW5xyDrMyLi/gD7jFeF4wJN0fMvIm2LEUBAahICjhhBKzGQevnEgcnPXwRDLR4VoVvg9a NAHJFN8TPCXlpPjaBhxU/yPgkUv/dquxFcpKp6yBb01XKKBPyOXl7Kb2A6a8NFAPtNC2X+4eY+D dbxc44fISFbabTvZK64jF/KkkdhORA== X-Proofpoint-GUID: TuovN0uX0ftviGatP3wl75U6rPElClvR X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-11-28_08,2025-11-27_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 adultscore=0 bulkscore=0 phishscore=0 lowpriorityscore=0 impostorscore=0 clxscore=1015 suspectscore=0 malwarescore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2511290106 Commit 88a5f8e628ef ("ASoc: qcom: audioreach: Use automatic cleanup of kfree()") did not make the code simpler but more complicated. Already simple code of allocation and free, without any error paths, got now declaration with one constructor followed by another allocation, which is in contrary to explicit coding rules guiding cleanup.h: "Given that the "__free(...) =3D NULL" pattern for variables defined at the top of the function poses this potential interdependency problem the recommendation is to always define and assign variables in one statement and not group variable definitions at the top of the function when __free() is used." Code does not have a bug, but is less readable and uses discouraged coding practice, so fix that by moving declaration to the place of assignment. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Srinivas Kandagatla --- sound/soc/qcom/qdsp6/audioreach.c | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/sound/soc/qcom/qdsp6/audioreach.c b/sound/soc/qcom/qdsp6/audio= reach.c index ded49124581b..329d916779f0 100644 --- a/sound/soc/qcom/qdsp6/audioreach.c +++ b/sound/soc/qcom/qdsp6/audioreach.c @@ -730,15 +730,15 @@ int audioreach_send_u32_param(struct q6apm_graph *gra= ph, struct audioreach_modul uint32_t param_id, uint32_t param_val) { struct apm_module_param_data *param_data; - struct gpr_pkt *pkt __free(kfree) =3D NULL; uint32_t *param; int payload_size =3D sizeof(uint32_t) + APM_MODULE_PARAM_DATA_SIZE; - void *p =3D audioreach_alloc_apm_cmd_pkt(payload_size, APM_CMD_SET_CFG, 0= ); - if (IS_ERR(p)) + void *p; + + struct gpr_pkt *pkt __free(kfree) =3D audioreach_alloc_apm_cmd_pkt(payloa= d_size, APM_CMD_SET_CFG, 0); + if (IS_ERR(pkt)) return -ENOMEM; =20 - pkt =3D p; - p =3D p + GPR_HDR_SIZE + APM_CMD_HDR_SIZE; + p =3D (void *)pkt + GPR_HDR_SIZE + APM_CMD_HDR_SIZE; =20 param_data =3D p; param_data->module_instance_id =3D module->instance_id; @@ -1043,7 +1043,6 @@ static int audioreach_pcm_set_media_format(struct q6a= pm_graph *graph, struct apm_pcm_module_media_fmt_cmd *cfg; struct apm_module_param_data *param_data; int payload_size; - struct gpr_pkt *pkt __free(kfree) =3D NULL; =20 if (num_channels > 4) { dev_err(graph->dev, "Error: Invalid channels (%d)!\n", num_channels); @@ -1052,7 +1051,8 @@ static int audioreach_pcm_set_media_format(struct q6a= pm_graph *graph, =20 payload_size =3D APM_PCM_MODULE_FMT_CMD_PSIZE(num_channels); =20 - pkt =3D audioreach_alloc_apm_cmd_pkt(payload_size, APM_CMD_SET_CFG, 0); + struct gpr_pkt *pkt __free(kfree) =3D + audioreach_alloc_apm_cmd_pkt(payload_size, APM_CMD_SET_CFG, 0); if (IS_ERR(pkt)) return PTR_ERR(pkt); =20 @@ -1090,7 +1090,6 @@ static int audioreach_shmem_set_media_format(struct q= 6apm_graph *graph, struct payload_media_fmt_pcm *cfg; struct media_format *header; int rc, payload_size; - struct gpr_pkt *pkt __free(kfree) =3D NULL; void *p; =20 if (num_channels > 4) { @@ -1100,8 +1099,9 @@ static int audioreach_shmem_set_media_format(struct q= 6apm_graph *graph, =20 payload_size =3D APM_SHMEM_FMT_CFG_PSIZE(num_channels) + APM_MODULE_PARAM= _DATA_SIZE; =20 - pkt =3D audioreach_alloc_cmd_pkt(payload_size, APM_CMD_SET_CFG, 0, - graph->port->id, module->instance_id); + struct gpr_pkt *pkt __free(kfree) =3D + audioreach_alloc_cmd_pkt(payload_size, APM_CMD_SET_CFG, 0, + graph->port->id, module->instance_id); if (IS_ERR(pkt)) return PTR_ERR(pkt); =20 --=20 2.48.1 From nobody Mon Dec 1 22:36:21 2025 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9932A30F948 for ; Sat, 29 Nov 2025 13:18:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764422298; cv=none; b=h/QTUKgRtxprE0Qm2UueJej9iN6izc2+Jc612EbRlx96t5UIq+VBPLHJIHfZxcvAi9dokyQ64pVkgPFqfjif8FkYdIrV0VXX7NdEidwm+vIXzyuwJMKdfiyhy/Gbleu9YKkVD1c1k2+LGKNhUK64I54sRKfrEZgV7PdVb/dCUwU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764422298; c=relaxed/simple; bh=lEl5AfceBGZX+HxER57Uao6Udayu95QrQVSkcBG5i/Y=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=cBYoCBEB00FXu9giTq7QwjKzuLneYEXSyW1Ch3FN2iVqh2xfd8nn3mw5MVhlFIr77Q9yoWX/QpPqZPr13imIMwODBOXtFblHB6qdkIkp2r6IHJ0MjpR69KqeQpzBviL7kp1Ar+miWfxPScZ45PDqjNWp0BokH8nKMdanFMnrbZY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=aednJi4g; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=VTKLaMAn; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="aednJi4g"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="VTKLaMAn" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5ATBQGYu2222104 for ; Sat, 29 Nov 2025 13:18:16 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= YmoBoyPDVfYZ6/7/pVrq1G/5Jf2az1Lc/3dLpCPK8mg=; b=aednJi4gxhF1Opti oYz8rsrW+OCNKbF6XC1RseZoZSHRHM6XrsxFHJxIym7QXBkpTXDmYDxZ4pI3yeeE Yr0bft1e1wTVPOo8Ahkz4lxqN4TX86F1befICXtMqOC10WvYGWv5Xu4WIJbGVad9 IkqFLljAMp6W2iUdp6/Op7DpG9aLJsl0h9XagefUrXS8yipcSIc5cdKV/eOTO6vD 9gt3AVr3JQwu6klk7KnG2XTJCx1ShHormqQXyR/LwxH2l1MMoU5UlE3Are4avGTN MBl6Z+k6xdZ8UDH2GiunjiIG3HPr+bw9MoaJ9gEn/llCK0YPnyE+rLnONplZcpKE QEK/sg== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4aqt468m8b-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sat, 29 Nov 2025 13:18:15 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-8b225760181so300144585a.2 for ; Sat, 29 Nov 2025 05:18:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1764422295; x=1765027095; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=YmoBoyPDVfYZ6/7/pVrq1G/5Jf2az1Lc/3dLpCPK8mg=; b=VTKLaMAnNcEiOKLSTaWILnnRS5ipLYUZ3iBqIaavu0C1x1KZA4UcGQs9aNTanZ31e/ elfYKybQ9nAT5hM6rqTueQ1J+cKepg098b378+xf4GoOWa15Zq7fAXWn6/hXoZoVwDQG WVG57bK1yysh4cLlMXJmA/hQKktHO8mILDnYK761++OVfr1C0iVCAu9NZIrhqa9RCTId kOeaK+KmixJ/d46rf91qACXNz+KeP7TWYTKAK94izYnvKhjzwNwTIvCDBWmrsiRs3xb6 iL/vvp+oPT7kGBh6F9wUfAJ9JftP67s6EoTF7DljLWE+a0aFk7nZvEy3hW46ksVois0b 6a2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764422295; x=1765027095; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=YmoBoyPDVfYZ6/7/pVrq1G/5Jf2az1Lc/3dLpCPK8mg=; b=BLs6SeyH8ppNro+gb4IlFfMUh/SjU89PWXOJvQfVRIJXcXO3Y3p7Fn67hPr663x15S Cb6eW90eT5XC3Bjk5b+G9mCsBDTLXyu3oB1JG3nBES+4Hl6GQNGZBKwmERTzyoNXUi5A ZlF+cuiVjlK6Q/bBZ0fUHOSQjBnYxMy5cB7UfPXpWdbdrVIlt2tfzSmI4EiySp57lbzc aDdULbvhillVueDJ8Dvn3UmXd+u5GL6ag7larn/zgene2xb10LwKJHpGnzbW4yWFbeKx SsrizA+cXYh4r0H2T/M/YqHOMgqYwayvT++kfL9Va8/+njONz7aklMKeKKQtOQipPDc2 A2Dw== X-Forwarded-Encrypted: i=1; AJvYcCVxLA6J7M42QdppaeIe3ECpHk+PJts3F+5OHnHr3llplFT++dVGuL7K2V+rNvabEwt3haqfXRZK4jbJTbo=@vger.kernel.org X-Gm-Message-State: AOJu0YxsoOPutVpXNLnD/eAZxrTuXU3uS89+1C7hQcs6lNMbeyQYNYi8 12F4H/suX8UveaHHshMbdiPdNK7OztEa8TJ/o5K8pnnRe5OcVt89GiHqLOZeAQ3k4Klf/9+wfje 6F9ET2mzMOdVHNE0b/I5NInK0gHZtYhdEjY17Dqq2Gbo3/3XbXAe+FEhYl29Zak0dQq0= X-Gm-Gg: ASbGncubBpmD2DwgFa0GjklLp5Jom31DuibCLulJEiWgmg6YILrj297AGwR3gLPMhh8 oNkWoA+MLJ1RgS+UhbakWx2oW+2RL/pBeWR6wNonVR3CkIOD+LhC+HmksOcnU2bWSEpjEwGy7Js gByIsOUYMlSWLoq3+84y4B+FT7i519yuPocsO5jLAGheGRF9pRhc1fbX81TUdvHgkAiSpmhcyAq hXu1GfAGY58CosT3nUv7KWhhHD67P9Mgc/V9LUAhgZgunv+Gmb+8msbmfGyhq+2GA5ShPzxJqXl rJpeduKnz3xy8nEmnReN5+yCt+Bo1tnQd99jMuaLG08xa0RfzOT401J9SJ7GTjSlNnVBYURNgbc WL18LP3luSbH6IJkp81HPMOKbR93pIMhpWQ== X-Received: by 2002:a05:620a:f13:b0:890:2e24:a543 with SMTP id af79cd13be357-8b4ebd5222amr2597672685a.34.1764422294689; Sat, 29 Nov 2025 05:18:14 -0800 (PST) X-Google-Smtp-Source: AGHT+IHwB2ZsqjrZ1cg/dSMojh3TNaKk7rHGvIc2Ok6VnMYy75j6yUens7DnZyaeusqapfrrEtEXpg== X-Received: by 2002:a05:620a:f13:b0:890:2e24:a543 with SMTP id af79cd13be357-8b4ebd5222amr2597667685a.34.1764422294171; Sat, 29 Nov 2025 05:18:14 -0800 (PST) Received: from [127.0.1.1] ([178.197.195.159]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b76f5163903sm723233866b.7.2025.11.29.05.18.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 29 Nov 2025 05:18:13 -0800 (PST) From: Krzysztof Kozlowski Date: Sat, 29 Nov 2025 14:17:58 +0100 Subject: [PATCH 6/6] ASoC: qcom: Minor readability improve with new lines Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251129-asoc-wrong-cleanup-h-can-people-stop-sending-this-without-reading-docs-v1-6-c38b06884e39@oss.qualcomm.com> References: <20251129-asoc-wrong-cleanup-h-can-people-stop-sending-this-without-reading-docs-v1-0-c38b06884e39@oss.qualcomm.com> In-Reply-To: <20251129-asoc-wrong-cleanup-h-can-people-stop-sending-this-without-reading-docs-v1-0-c38b06884e39@oss.qualcomm.com> To: Srinivas Kandagatla , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=11019; i=krzysztof.kozlowski@oss.qualcomm.com; h=from:subject:message-id; bh=lEl5AfceBGZX+HxER57Uao6Udayu95QrQVSkcBG5i/Y=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBpKvKKZ9xsIEG5D5JNvWwceDCjBVXr5ypcnmOGY zldZ2wrvRCJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCaSryigAKCRDBN2bmhouD 19O/D/43cb2Iiw5c5+5yDUqrdsED4Ro5IfM+1bIItJtmp1lBQ4eYcAp0wD9WtLmP+ZY6Yj7qvNg PGYYfF7Q1xPz3J5Zp0qFMVRj8abxzinbJaG2/DBFGOXl4igFE1PVIPm0MpibJUw4lf05ExaQbWd BkFd56kSy6BV3aVGlkwxzQXxEhUGKhZDB9Coam8jQSNo8CSApfaZBifos/aexAyPRcVY4Y09mGg tOZ0gM8AHnW1RMikqERul3bk0ZqsRKkaTjr5LQbFuBvpb7OEKGUVCJoIL6CZ18uVAQuQiba2tF8 HeD1S0+pocwckIyosYV5hvXP9qLyU6iBgQJqJnGgE+VZykFYF945SAdnVTEfu0cFPSqr/FJxvLR B8wpz1Nl/5LbvUIEAiYbA7zeprtNWVwy2uFi9LQPpcvDBzDjo/Oqa6iNMMHPbaNf45hRrNqk+ME VWXOtNZNFPzUcjaqbnh6e5MDi6nUN1kW5wQkt6ozl6HJ6W13P1XEjNFmZUkdEtfC86HDWalpkUD Aa7hEW90jA0jQfp5OIjseJQR9HAa96Y9WQDJJZwXcaKBEjBDZY+Lx/bDUFevZEq51NTT3srdWoj 7O5oHPQIRy1esuc08dR4gyEL/riyhLQVBUabS8B2tXRG4qYD7I82+ljOFfH2US13CnfSS0s5GH5 346Cf6DSinZGyhw== X-Developer-Key: i=krzysztof.kozlowski@oss.qualcomm.com; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMTI5MDEwNiBTYWx0ZWRfXwsOQGjc1we9F M5gqNYnFVrnSVe+6okCK9NBKlY11jCGJITYtXcx5pQeVHvM9y68PclbXVX5ueN0Y3i3K7dg6GH6 ucYaoNUj+Pix/vSZ6LVnBw6UCv3pelV4lWzqCNfbLAtQLdzkLf85MM02f70kSMrrKKI/IfyQSUW VeueIbyd37hKFYapLOpbgFFXurkXo0xfoOD/FGBP5QYxcDn7zYAeMTfD3hZQbT1Fp5S5MTVOBD4 ARC+2N3W1pI4VNO5s3BV6/ygCewyrLdjKp0RnNfICk+374nqkK+PJojc4KyIrLYFLFIZkcws5xz 0JdkN/VYfd/9nHaLVF88PZys+fiex9K0q2cR/kIFTY5w5zxcjgz9XaUvZV/KSXgYZM/TCeGaFKD DD78OqflK6KfvQOGi4Px5quwOnyHuQ== X-Proofpoint-ORIG-GUID: yT6BgElAvielBVx65rTeqc2B-fSd3VTu X-Authority-Analysis: v=2.4 cv=aO79aL9m c=1 sm=1 tr=0 ts=692af297 cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=FPK7cjBCgYbqzSTDLBmM0Q==:17 a=IkcTkHD0fZMA:10 a=6UeiqGixMTsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=91d8KASzpMfN8u1-4qoA:9 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 X-Proofpoint-GUID: yT6BgElAvielBVx65rTeqc2B-fSd3VTu X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-11-28_08,2025-11-27_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 suspectscore=0 spamscore=0 priorityscore=1501 bulkscore=0 phishscore=0 malwarescore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2511290106 Variables with automatic cleanup are special because they do not follow standard rules of declaration at top of function (see cleanup.h), but on the other hand we always expect line break between top-function declarations and first instructions. Don't pretend automatic cleanup variables are part of top-level declaration to improve readability when variable is followed by nun-NULL check. No functional impact, only style. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Srinivas Kandagatla --- sound/soc/qcom/qdsp6/audioreach.c | 8 +++++++- sound/soc/qcom/qdsp6/q6adm.c | 2 ++ sound/soc/qcom/qdsp6/q6afe.c | 4 ++++ sound/soc/qcom/qdsp6/q6apm.c | 3 +++ sound/soc/qcom/qdsp6/q6asm.c | 13 +++++++++++++ 5 files changed, 29 insertions(+), 1 deletion(-) diff --git a/sound/soc/qcom/qdsp6/audioreach.c b/sound/soc/qcom/qdsp6/audio= reach.c index 329d916779f0..f3fa0a5b4095 100644 --- a/sound/soc/qcom/qdsp6/audioreach.c +++ b/sound/soc/qcom/qdsp6/audioreach.c @@ -617,6 +617,7 @@ static int audioreach_display_port_set_media_format(str= uct q6apm_graph *graph, int fs_sz =3D APM_FS_CFG_PSIZE; int size =3D ic_sz + ep_sz + fs_sz; void *p; + struct gpr_pkt *pkt __free(kfree) =3D audioreach_alloc_apm_cmd_pkt(size, = APM_CMD_SET_CFG, 0); if (IS_ERR(pkt)) return PTR_ERR(pkt); @@ -675,6 +676,7 @@ static int audioreach_codec_dma_set_media_format(struct= q6apm_graph *graph, int pm_sz =3D APM_HW_EP_PMODE_CFG_PSIZE; int size =3D ic_sz + ep_sz + fs_sz + pm_sz; void *p; + struct gpr_pkt *pkt __free(kfree) =3D audioreach_alloc_apm_cmd_pkt(size, = APM_CMD_SET_CFG, 0); if (IS_ERR(pkt)) return PTR_ERR(pkt); @@ -788,6 +790,7 @@ static int audioreach_set_module_config(struct q6apm_gr= aph *graph, { int size =3D le32_to_cpu(module->data->size); void *p; + struct gpr_pkt *pkt __free(kfree) =3D audioreach_alloc_apm_cmd_pkt(size, = APM_CMD_SET_CFG, 0); if (IS_ERR(pkt)) return PTR_ERR(pkt); @@ -810,6 +813,7 @@ static int audioreach_mfc_set_media_format(struct q6apm= _graph *graph, APM_MODULE_PARAM_DATA_SIZE; int i; void *p; + struct gpr_pkt *pkt __free(kfree) =3D audioreach_alloc_apm_cmd_pkt(payloa= d_size, APM_CMD_SET_CFG, 0); if (IS_ERR(pkt)) return PTR_ERR(pkt); @@ -922,13 +926,13 @@ int audioreach_compr_set_param(struct q6apm_graph *gr= aph, struct audioreach_modu void *p; int iid =3D q6apm_graph_get_rx_shmem_module_iid(graph); int payload_size =3D sizeof(struct apm_sh_module_media_fmt_cmd); + struct gpr_pkt *pkt __free(kfree) =3D audioreach_alloc_cmd_pkt(payload_si= ze, DATA_CMD_WR_SH_MEM_EP_MEDIA_FORMAT, 0, graph->port->id, iid); if (IS_ERR(pkt)) return -ENOMEM; =20 - p =3D (void *)pkt + GPR_HDR_SIZE; header =3D p; rc =3D audioreach_set_compr_media_format(header, p, mcfg); @@ -952,6 +956,7 @@ static int audioreach_i2s_set_media_format(struct q6apm= _graph *graph, int fs_sz =3D APM_FS_CFG_PSIZE; int size =3D ic_sz + ep_sz + fs_sz; void *p; + struct gpr_pkt *pkt __free(kfree) =3D audioreach_alloc_apm_cmd_pkt(size, = APM_CMD_SET_CFG, 0); if (IS_ERR(pkt)) return PTR_ERR(pkt); @@ -1013,6 +1018,7 @@ static int audioreach_logging_set_media_format(struct= q6apm_graph *graph, struct data_logging_config *cfg; int size =3D sizeof(*cfg) + APM_MODULE_PARAM_DATA_SIZE; void *p; + struct gpr_pkt *pkt __free(kfree) =3D audioreach_alloc_apm_cmd_pkt(size, = APM_CMD_SET_CFG, 0); if (IS_ERR(pkt)) return PTR_ERR(pkt); diff --git a/sound/soc/qcom/qdsp6/q6adm.c b/sound/soc/qcom/qdsp6/q6adm.c index 0b8d06ec8b26..bbe986293ec3 100644 --- a/sound/soc/qcom/qdsp6/q6adm.c +++ b/sound/soc/qcom/qdsp6/q6adm.c @@ -331,6 +331,7 @@ static int q6adm_device_open(struct q6adm *adm, struct = q6copp *copp, int afe_port =3D q6afe_get_port_id(port_id); struct apr_pkt *pkt; int ret, pkt_size =3D APR_HDR_SIZE + sizeof(*open); + void *p __free(kfree) =3D kzalloc(pkt_size, GFP_KERNEL); if (!p) return -ENOMEM; @@ -466,6 +467,7 @@ int q6adm_matrix_map(struct device *dev, int path, struct q6copp *copp; int pkt_size =3D (APR_HDR_SIZE + sizeof(*route) + sizeof(*node) + (sizeof(uint32_t) * payload_map.num_copps)); + void *matrix_map __free(kfree) =3D kzalloc(pkt_size, GFP_KERNEL); if (!matrix_map) return -ENOMEM; diff --git a/sound/soc/qcom/qdsp6/q6afe.c b/sound/soc/qcom/qdsp6/q6afe.c index c9fdd53492e0..0cf6aebe498c 100644 --- a/sound/soc/qcom/qdsp6/q6afe.c +++ b/sound/soc/qcom/qdsp6/q6afe.c @@ -1077,6 +1077,7 @@ static int q6afe_set_param(struct q6afe *afe, struct = q6afe_port *port, struct apr_pkt *pkt; int ret, pkt_size =3D APR_HDR_SIZE + sizeof(*param) + sizeof(*pdata) + ps= ize; void *pl; + void *p __free(kfree) =3D kzalloc(pkt_size, GFP_KERNEL); if (!p) return -ENOMEM; @@ -1128,6 +1129,7 @@ static int q6afe_port_set_param_v2(struct q6afe_port = *port, void *data, u16 port_id =3D port->id; int ret, pkt_size =3D APR_HDR_SIZE + sizeof(*param) + sizeof(*pdata) + ps= ize; void *pl; + void *p __free(kfree) =3D kzalloc(pkt_size, GFP_KERNEL); if (!p) return -ENOMEM; @@ -1832,6 +1834,7 @@ int q6afe_unvote_lpass_core_hw(struct device *dev, ui= nt32_t hw_block_id, struct apr_pkt *pkt; int ret =3D 0; int pkt_size =3D APR_HDR_SIZE + sizeof(*vote_cfg); + void *p __free(kfree) =3D kzalloc(pkt_size, GFP_KERNEL); if (!p) return -ENOMEM; @@ -1866,6 +1869,7 @@ int q6afe_vote_lpass_core_hw(struct device *dev, uint= 32_t hw_block_id, struct apr_pkt *pkt; int ret =3D 0; int pkt_size =3D APR_HDR_SIZE + sizeof(*vote_cfg); + void *p __free(kfree) =3D kzalloc(pkt_size, GFP_KERNEL); if (!p) return -ENOMEM; diff --git a/sound/soc/qcom/qdsp6/q6apm.c b/sound/soc/qcom/qdsp6/q6apm.c index 4e5ad04ece50..e30f8648ae15 100644 --- a/sound/soc/qcom/qdsp6/q6apm.c +++ b/sound/soc/qcom/qdsp6/q6apm.c @@ -100,6 +100,7 @@ static int audioreach_graph_mgmt_cmd(struct audioreach_= graph *graph, uint32_t op struct audioreach_sub_graph *sg; struct q6apm *apm =3D graph->apm; int i =3D 0, payload_size =3D APM_GRAPH_MGMT_PSIZE(mgmt_cmd, num_sub_grap= hs); + struct gpr_pkt *pkt __free(kfree) =3D audioreach_alloc_apm_cmd_pkt(payloa= d_size, opcode, 0); if (IS_ERR(pkt)) return PTR_ERR(pkt); @@ -409,6 +410,7 @@ int q6apm_write_async(struct q6apm_graph *graph, uint32= _t len, uint32_t msw_ts, struct apm_data_cmd_wr_sh_mem_ep_data_buffer_v2 *write_buffer; struct audio_buffer *ab; int iid =3D q6apm_graph_get_rx_shmem_module_iid(graph); + struct gpr_pkt *pkt __free(kfree) =3D audioreach_alloc_pkt(sizeof(*write_= buffer), DATA_CMD_WR_SH_MEM_EP_DATA_BUFFER_V2, graph->rx_data.dsp_buf | (len << APM_WRITE_TOKEN_LEN_SHIFT), @@ -446,6 +448,7 @@ int q6apm_read(struct q6apm_graph *graph) struct audioreach_graph_data *port; struct audio_buffer *ab; int iid =3D q6apm_graph_get_tx_shmem_module_iid(graph); + struct gpr_pkt *pkt __free(kfree) =3D audioreach_alloc_pkt(sizeof(*read_b= uffer), DATA_CMD_RD_SH_MEM_EP_DATA_BUFFER_V2, graph->tx_data.dsp_buf, graph->port->id, iid); diff --git a/sound/soc/qcom/qdsp6/q6asm.c b/sound/soc/qcom/qdsp6/q6asm.c index 890a1f786627..420176f80ffe 100644 --- a/sound/soc/qcom/qdsp6/q6asm.c +++ b/sound/soc/qcom/qdsp6/q6asm.c @@ -928,6 +928,7 @@ int q6asm_open_write(struct audio_client *ac, uint32_t = stream_id, struct asm_stream_cmd_open_write_v3 *open; struct apr_pkt *pkt; int rc, pkt_size =3D APR_HDR_SIZE + sizeof(*open); + void *p __free(kfree) =3D kzalloc(pkt_size, GFP_KERNEL); if (!p) return -ENOMEM; @@ -1005,6 +1006,7 @@ static int __q6asm_run(struct audio_client *ac, uint3= 2_t stream_id, struct asm_session_cmd_run_v2 *run; struct apr_pkt *pkt; int rc, pkt_size =3D APR_HDR_SIZE + sizeof(*run); + void *p __free(kfree) =3D kzalloc(pkt_size, GFP_ATOMIC); if (!p) return -ENOMEM; @@ -1087,6 +1089,7 @@ int q6asm_media_format_block_multi_ch_pcm(struct audi= o_client *ac, struct apr_pkt *pkt; u8 *channel_mapping; int pkt_size =3D APR_HDR_SIZE + sizeof(*fmt); + void *p __free(kfree) =3D kzalloc(pkt_size, GFP_KERNEL); if (!p) return -ENOMEM; @@ -1125,6 +1128,7 @@ int q6asm_stream_media_format_block_flac(struct audio= _client *ac, struct asm_flac_fmt_blk_v2 *fmt; struct apr_pkt *pkt; int pkt_size =3D APR_HDR_SIZE + sizeof(*fmt); + void *p __free(kfree) =3D kzalloc(pkt_size, GFP_KERNEL); if (!p) return -ENOMEM; @@ -1156,6 +1160,7 @@ int q6asm_stream_media_format_block_wma_v9(struct aud= io_client *ac, struct asm_wmastdv9_fmt_blk_v2 *fmt; struct apr_pkt *pkt; int pkt_size =3D APR_HDR_SIZE + sizeof(*fmt); + void *p __free(kfree) =3D kzalloc(pkt_size, GFP_KERNEL); if (!p) return -ENOMEM; @@ -1188,6 +1193,7 @@ int q6asm_stream_media_format_block_wma_v10(struct au= dio_client *ac, struct asm_wmaprov10_fmt_blk_v2 *fmt; struct apr_pkt *pkt; int pkt_size =3D APR_HDR_SIZE + sizeof(*fmt); + void *p __free(kfree) =3D kzalloc(pkt_size, GFP_KERNEL); if (!p) return -ENOMEM; @@ -1221,6 +1227,7 @@ int q6asm_stream_media_format_block_alac(struct audio= _client *ac, struct asm_alac_fmt_blk_v2 *fmt; struct apr_pkt *pkt; int pkt_size =3D APR_HDR_SIZE + sizeof(*fmt); + void *p __free(kfree) =3D kzalloc(pkt_size, GFP_KERNEL); if (!p) return -ENOMEM; @@ -1257,6 +1264,7 @@ int q6asm_stream_media_format_block_ape(struct audio_= client *ac, struct asm_ape_fmt_blk_v2 *fmt; struct apr_pkt *pkt; int pkt_size =3D APR_HDR_SIZE + sizeof(*fmt); + void *p __free(kfree) =3D kzalloc(pkt_size, GFP_KERNEL); if (!p) return -ENOMEM; @@ -1291,6 +1299,7 @@ static int q6asm_stream_remove_silence(struct audio_c= lient *ac, uint32_t stream_ uint32_t *samples; struct apr_pkt *pkt; int rc, pkt_size =3D APR_HDR_SIZE + sizeof(uint32_t); + void *p __free(kfree) =3D kzalloc(pkt_size, GFP_ATOMIC); if (!p) return -ENOMEM; @@ -1349,6 +1358,7 @@ int q6asm_enc_cfg_blk_pcm_format_support(struct audio= _client *ac, u8 *channel_mapping; u32 frames_per_buf =3D 0; int pkt_size =3D APR_HDR_SIZE + sizeof(*enc_cfg); + void *p __free(kfree) =3D kzalloc(pkt_size, GFP_KERNEL); if (!p) return -ENOMEM; @@ -1395,6 +1405,7 @@ int q6asm_read(struct audio_client *ac, uint32_t stre= am_id) unsigned long flags; int pkt_size =3D APR_HDR_SIZE + sizeof(*read); int rc =3D 0; + void *p __free(kfree) =3D kzalloc(pkt_size, GFP_ATOMIC); if (!p) return -ENOMEM; @@ -1437,6 +1448,7 @@ static int __q6asm_open_read(struct audio_client *ac,= uint32_t stream_id, struct asm_stream_cmd_open_read_v3 *open; struct apr_pkt *pkt; int pkt_size =3D APR_HDR_SIZE + sizeof(*open); + void *p __free(kfree) =3D kzalloc(pkt_size, GFP_KERNEL); if (!p) return -ENOMEM; @@ -1507,6 +1519,7 @@ int q6asm_write_async(struct audio_client *ac, uint32= _t stream_id, uint32_t len, struct apr_pkt *pkt; int pkt_size =3D APR_HDR_SIZE + sizeof(*write); int rc =3D 0; + void *p __free(kfree) =3D kzalloc(pkt_size, GFP_ATOMIC); if (!p) return -ENOMEM; --=20 2.48.1