> You did not specify a description of why the patch is needed, or
> possibly, any description at all, in the email body. [...]

Thanks, the commit message now includes a proper description.
The patch itself has not changed.

I also realized that the previous subject line might have been incorrect.
The correct subject should be:

    staging: gpib: eastwood: use kzalloc instead of kmalloc + memset

Use kzalloc() instead of kmalloc() + memset() to simplify memory allocation.

Also use sizeof(*board->private_data) instead of repeating the struct name.
This avoids duplication and keeps the code correct if the struct name
changes in the future.

Signed-off-by: Tomasz Sadowski <tsdwski@gmail.com>
---
 drivers/staging/gpib/eastwood/fluke_gpib.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/staging/gpib/eastwood/fluke_gpib.c b/drivers/staging/gpib/eastwood/fluke_gpib.c
index 3ae848e3f738..2b6ba7882dba 100644
--- a/drivers/staging/gpib/eastwood/fluke_gpib.c
+++ b/drivers/staging/gpib/eastwood/fluke_gpib.c
@@ -853,11 +853,10 @@ static int fluke_allocate_private(struct gpib_board *board)
 {
 	struct fluke_priv *priv;
 
-	board->private_data = kmalloc(sizeof(struct fluke_priv), GFP_KERNEL);
+	board->private_data = kzalloc(sizeof(*board->private_data), GFP_KERNEL);
 	if (!board->private_data)
 		return -ENOMEM;
 	priv = board->private_data;
-	memset(priv, 0, sizeof(struct fluke_priv));
 	init_nec7210_private(&priv->nec7210_priv);
 	priv->dma_buffer_size = 0x7ff;
 	priv->dma_buffer = kmalloc(priv->dma_buffer_size, GFP_KERNEL);
-- 
2.52.0

On Wed, Nov 26, 2025 at 04:48:52PM +0100, Tomasz Sadowski wrote:
> > You did not specify a description of why the patch is needed, or
> > possibly, any description at all, in the email body. [...]
> 
> Thanks, the commit message now includes a proper description.
> The patch itself has not changed.
> 
> I also realized that the previous subject line might have been incorrect.
> The correct subject should be:
> 
>     staging: gpib: eastwood: use kzalloc instead of kmalloc + memset
> 

All this is weird commentary to put into a patch...


> Use kzalloc() instead of kmalloc() + memset() to simplify memory allocation.
> 
> Also use sizeof(*board->private_data) instead of repeating the struct name.
> This avoids duplication and keeps the code correct if the struct name
> changes in the future.
> 
> Signed-off-by: Tomasz Sadowski <tsdwski@gmail.com>
> ---

This isn't how to send a v2 patch.

https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/

regards,
dan carpenter