From nobody Mon Dec 1 22:41:52 2025 Received: from mail-ej1-f41.google.com (mail-ej1-f41.google.com [209.85.218.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B1B933019B1 for ; Wed, 26 Nov 2025 15:55:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764172520; cv=none; b=jXv9DZ5pPvSiUVhU3mkcdvxNUGo75PwZ/AdFkar/CTOZvyvixDjMV3qayWPC7XWlGSNKKa8eD/LOHomBD03xSa0MorkTAO9zibhCYqv9n5iQGqWHW3nABf+GXlk8iAOnpFDYiK3lNtxFokxg4cDXfyOBCUCCzjYnDx9aR26kPr0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764172520; c=relaxed/simple; bh=oIc6d2LlQO3UfiYzLsgNESi2ksb3+2Dq7FBVlE4XtEY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=O/aIH0O2SPUYY/najYBukmDaITWDDhO5B6k8Y/cHsoL+zyJn5aIQSL+VBm1TiTttkXMy0r1lW03eyGCoIadEJ3kT2Mr7Z0BEJXAg1AcDq+zd19st+r1+kbZIwALY7y3PoVIG09D+PJXjKuv4fs2iZ+L9BF5FYxeGslDsWeIJtMg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=LELDBOvq; arc=none smtp.client-ip=209.85.218.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LELDBOvq" Received: by mail-ej1-f41.google.com with SMTP id a640c23a62f3a-b713c7096f9so1067534866b.3 for ; Wed, 26 Nov 2025 07:55:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764172517; x=1764777317; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=X6ymbr1nGlfuDVt8qf0Mxub6qmg5Zen1rYczCu9krm4=; b=LELDBOvq10wM7UKLtqd70Ffv4tmVOaABvzFre4rxDaf/ajxhXPC20wztUTC5bTt8FB jaVAmcvGywu149gO/A5L+glAiCfIb2B/HtFoJb9wprVwLsvT+QDg2N4ROF88mpQZW+Uc KxsfCsFeswTdSQHRWYPrG7xqwmS6AW2LxXQtIkEluqu+Hoe2g6s0wxIRRRqpEQhpwWYb sS6pfZq4bE7XqfgrsY2ALQ2GUyEBG3K3j6o7oMRZRwbyEDJJcEgQ/UppS4sznLq7bfIp sbvyt4JSJomABamgHGfE02LKxYjrnCe01CaAhB7fJVKrDQhI7yLl0hOKGH9VlPx5aeSa 5lgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764172517; x=1764777317; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=X6ymbr1nGlfuDVt8qf0Mxub6qmg5Zen1rYczCu9krm4=; b=q0dhwGivN5dYOpetxC/lvdZVROqd32fwhGlDLCm06qSBgIalB2CyNZiFZheJ9GyxLm 5ww02ujJoTfRB/XHutzKKkdyW7Uh5DesvkJmTCoWmwgxTpAHtp/U6GPD0KQZpTIkHV0e nNx+t0W+Mou7lOnceCs8h7WRm3bA+OLCiEff2HOmGwmja2u3AzTZKadj3cXMK+9aHCf4 qoxN5bMUSnjvxafgrUehuwo36Do+dGiJ9i6uENkf/AaZsh9fAz6VPY4zfLZXFkxgDHm2 b0zN4joutqSOcVVuHEXMBRLqEMWo135LbWa3ExI42w6c1hz+XvjuN/d45tvqtqfEMO/x dYIg== X-Forwarded-Encrypted: i=1; AJvYcCUjMS+H9wtECQP9hzkNsiS126tVyZnrzmSMyxyiGfy/Q1Dvux9nkpW6XL6FWvA/9BkYQE3Cu7ONIi9mTlY=@vger.kernel.org X-Gm-Message-State: AOJu0YwfdFhCgfgt1IQkmBdKSB12+k/49xDoTxFYEQ873RT7YUhMiD0i n75rHPWDMeHXHJTt7n6uFrAk4K+WIWdZt5zaCuVpt0PZ8HrCySjaSu4tOfg1bQ7Iju8= X-Gm-Gg: ASbGnctoc0J5RsOkdbL1Z/V+PSyZvhLCi3zOP2JtUkBCmiDTIDFtobJv80DVWPz85sv 5YEB+xFQ5HJuHnq6bfbWqHIN2N+2fjWPG+GGuCTqshmCRwlxjTg/EPqEsKA7Bbd92cCPswzqXut yCL9zY71qnQo/VnVfGSEW9w9yKYGQ3EPUv3pKb4HvS7539pNS65iLzLnBbBtEQEpl+zaQYZbpW6 py4FyDFkgWXQOSVawIDjj7Abcrs2nckGV6Uw9zOM/vhphQq6p0sKjWH6tdHEz3MFKLPJ7DMAKPZ ryNZ1nAp1/shHePM/UcFx773hCjZXuR6PlfS8dKQEwYTduiwkvUEOgKgtijsf7h2Gvbihn2TqjZ hFQcjDUJ93kRRcJVzjONPteZUKDyg2iulZ79f6I4Oxj1hp2YzMHsfeybAfgqfvffQ/vzLTnFrua MNfSLa14NvSvF2aZaDkbqb0BQ547t2iS5fSZ54rA== X-Google-Smtp-Source: AGHT+IGM6F/j3/Ul1lTRLpDEuj3a+kx6uuXA8Z1zCQBsx5UcvlajM9BABOfT9EMpGFoqsRpglxqJhA== X-Received: by 2002:a17:907:d8c:b0:b3b:5fe6:577a with SMTP id a640c23a62f3a-b7671549d93mr1926058666b.8.1764172516966; Wed, 26 Nov 2025 07:55:16 -0800 (PST) Received: from arch-linux (178.42.50.207.ipv4.supernova.orange.pl. [178.42.50.207]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b7654fd4e8esm1905950666b.41.2025.11.26.07.55.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Nov 2025 07:55:16 -0800 (PST) From: Tomasz Sadowski To: Dave Penkler Cc: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Tomasz Sadowski Subject: [PATCH] staging: fluke_gpib: use kzalloc instead of kmalloc + memset Date: Wed, 26 Nov 2025 16:48:52 +0100 Message-ID: <20251126155453.45178-1-tsdwski@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <2025112636-planner-straw-a530@gregkh> References: <2025112636-planner-straw-a530@gregkh> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" > You did not specify a description of why the patch is needed, or > possibly, any description at all, in the email body. [...] Thanks, the commit message now includes a proper description. The patch itself has not changed. I also realized that the previous subject line might have been incorrect. The correct subject should be: staging: gpib: eastwood: use kzalloc instead of kmalloc + memset Use kzalloc() instead of kmalloc() + memset() to simplify memory allocation. Also use sizeof(*board->private_data) instead of repeating the struct name. This avoids duplication and keeps the code correct if the struct name changes in the future. Signed-off-by: Tomasz Sadowski --- drivers/staging/gpib/eastwood/fluke_gpib.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/gpib/eastwood/fluke_gpib.c b/drivers/staging/g= pib/eastwood/fluke_gpib.c index 3ae848e3f738..2b6ba7882dba 100644 --- a/drivers/staging/gpib/eastwood/fluke_gpib.c +++ b/drivers/staging/gpib/eastwood/fluke_gpib.c @@ -853,11 +853,10 @@ static int fluke_allocate_private(struct gpib_board *= board) { struct fluke_priv *priv; =20 - board->private_data =3D kmalloc(sizeof(struct fluke_priv), GFP_KERNEL); + board->private_data =3D kzalloc(sizeof(*board->private_data), GFP_KERNEL); if (!board->private_data) return -ENOMEM; priv =3D board->private_data; - memset(priv, 0, sizeof(struct fluke_priv)); init_nec7210_private(&priv->nec7210_priv); priv->dma_buffer_size =3D 0x7ff; priv->dma_buffer =3D kmalloc(priv->dma_buffer_size, GFP_KERNEL); --=20 2.52.0