arch/um/kernel/kmsg_dump.c | 2 +- drivers/tty/serial/kgdboc.c | 1 - drivers/tty/tty_io.c | 2 +- kernel/printk/printk.c | 17 +++++++---------- 4 files changed, 9 insertions(+), 13 deletions(-)
The first part can be found here[1]. The proposed changes do not
change the functionality of printk, but were suggestions made by
Petr Mladek. I already have more patches for a part 3 ,but I would like
to see these ones merged first.
I did the testing with VMs, checking suspend and resume cycles, and it worked
as expected.
Thanks for reviewing!
[1]: https://lore.kernel.org/lkml/20250226-printk-renaming-v1-0-0b878577f2e6@suse.com/
Signed-off-by: Marcos Paulo de Souza <mpdesouza@suse.com>
---
Changes in v2:
- Squashed patches 1 and 3 (CON_SUSPEND usage) and now is the last patch
of the series, suggested by Petr Mladek
- Moved commit 4 as the first one in the series, and it was changed to
use console_is_usable helper, suggested by Petr Mladek
- Moved commit 5 as the second commit in the series, and adjusted to use
console_is_usable helper, suggested by Petr Mladek
- The patch 6 was dropped, since it was implemented in a different patchset
(https://lore.kernel.org/lkml/20250902-nbcon-kgdboc-v3-0-cd30a8106f1c@suse.com/)
- Patch 7 was moved as third patch, and is using the console_is_usable,
suggested by Petr Mladek
- Patch 2 was dropped from this patchset, and will be included in the
next cleanup patchset.
- Link to v1: https://lore.kernel.org/r/20250606-printk-cleanup-part2-v1-0-f427c743dda0@suse.com
---
Marcos Paulo de Souza (4):
drivers: serial: kgdboc: Drop checks for CON_ENABLED and CON_BOOT
arch: um: kmsg_dump: Use console_is_usable
printk: Use console_is_usable on console_unblank
printk: Make console_{suspend,resume} handle CON_SUSPENDED
arch/um/kernel/kmsg_dump.c | 2 +-
drivers/tty/serial/kgdboc.c | 1 -
drivers/tty/tty_io.c | 2 +-
kernel/printk/printk.c | 17 +++++++----------
4 files changed, 9 insertions(+), 13 deletions(-)
---
base-commit: 887c7f05d40eb51ba3f38fd71d5e6b4aff4bb8a2
change-id: 20250601-printk-cleanup-part2-38f8d5108099
Best regards,
--
Marcos Paulo de Souza <mpdesouza@suse.com>
On Fri 2025-11-21 15:50:32, Marcos Paulo de Souza wrote:
> The first part can be found here[1]. The proposed changes do not
> change the functionality of printk, but were suggestions made by
> Petr Mladek. I already have more patches for a part 3 ,but I would like
> to see these ones merged first.
>
> I did the testing with VMs, checking suspend and resume cycles, and it worked
> as expected.
>
> Thanks for reviewing!
> Marcos Paulo de Souza (4):
> drivers: serial: kgdboc: Drop checks for CON_ENABLED and CON_BOOT
> arch: um: kmsg_dump: Use console_is_usable
> printk: Use console_is_usable on console_unblank
These three patches were simple, straightforward, and ready for linux
next.
I have comitted them into printk/linux.git, branch rework/nbcon-in-kdb.
I am going to push them for 6.19.
> printk: Make console_{suspend,resume} handle CON_SUSPENDED
This patch still need some love and v3.
Best Regards,
Petr
On Thu, Nov 27, 2025 at 04:18:40PM +0100, Petr Mladek wrote: > On Fri 2025-11-21 15:50:32, Marcos Paulo de Souza wrote: > > The first part can be found here[1]. The proposed changes do not > > change the functionality of printk, but were suggestions made by > > Petr Mladek. I already have more patches for a part 3 ,but I would like > > to see these ones merged first. > > > > I did the testing with VMs, checking suspend and resume cycles, and it worked > > as expected. > > > > Thanks for reviewing! > > > Marcos Paulo de Souza (4): > > drivers: serial: kgdboc: Drop checks for CON_ENABLED and CON_BOOT > > arch: um: kmsg_dump: Use console_is_usable > > printk: Use console_is_usable on console_unblank > > These three patches were simple, straightforward, and ready for linux > next. > > I have comitted them into printk/linux.git, branch rework/nbcon-in-kdb. > I am going to push them for 6.19. I pointed the kgdb test suite at this branch (as I did for the earlier part of the patchset, although I think I forgot to post about it). The console coverage is fairly modest (I think just 8250 and PL011 drivers, with and without earlycon) and the suite exercises features rather than crash resilience. Nevertheless and FWIW, the tests didn't pick up any regressions. Yay! Daniel.
On Fri, 2025-11-28 at 09:52 +0000, Daniel Thompson wrote: > On Thu, Nov 27, 2025 at 04:18:40PM +0100, Petr Mladek wrote: > > On Fri 2025-11-21 15:50:32, Marcos Paulo de Souza wrote: > > > The first part can be found here[1]. The proposed changes do not > > > change the functionality of printk, but were suggestions made by > > > Petr Mladek. I already have more patches for a part 3 ,but I > > > would like > > > to see these ones merged first. > > > > > > I did the testing with VMs, checking suspend and resume cycles, > > > and it worked > > > as expected. > > > > > > Thanks for reviewing! > > > > > Marcos Paulo de Souza (4): > > > drivers: serial: kgdboc: Drop checks for CON_ENABLED and > > > CON_BOOT > > > arch: um: kmsg_dump: Use console_is_usable > > > printk: Use console_is_usable on console_unblank > > > > These three patches were simple, straightforward, and ready for > > linux > > next. > > > > I have comitted them into printk/linux.git, branch rework/nbcon-in- > > kdb. > > I am going to push them for 6.19. > > I pointed the kgdb test suite at this branch (as I did for the > earlier > part of the patchset, although I think I forgot to post about it). > > The console coverage is fairly modest (I think just 8250 and PL011 > drivers, with and without earlycon) and the suite exercises features > rather than crash resilience. Nevertheless and FWIW, the tests didn't > pick up any regressions. Yay! Thanks Daniel! I remember that you said that you would run the testsuite in the previous patchset, but didn't want to bother asking you (I believe that if you found anything you would point it out either way :) ). > > > Daniel.
On Fri 2025-11-28 09:52:24, Daniel Thompson wrote: > On Thu, Nov 27, 2025 at 04:18:40PM +0100, Petr Mladek wrote: > > On Fri 2025-11-21 15:50:32, Marcos Paulo de Souza wrote: > > > The first part can be found here[1]. The proposed changes do not > > > change the functionality of printk, but were suggestions made by > > > Petr Mladek. I already have more patches for a part 3 ,but I would like > > > to see these ones merged first. > > > > > > I did the testing with VMs, checking suspend and resume cycles, and it worked > > > as expected. > > > > > > Thanks for reviewing! > > > > > Marcos Paulo de Souza (4): > > > drivers: serial: kgdboc: Drop checks for CON_ENABLED and CON_BOOT > > > arch: um: kmsg_dump: Use console_is_usable > > > printk: Use console_is_usable on console_unblank > > > > These three patches were simple, straightforward, and ready for linux > > next. > > > > I have comitted them into printk/linux.git, branch rework/nbcon-in-kdb. > > I am going to push them for 6.19. > > I pointed the kgdb test suite at this branch (as I did for the earlier > part of the patchset, although I think I forgot to post about it). > > The console coverage is fairly modest (I think just 8250 and PL011 > drivers, with and without earlycon) and the suite exercises features > rather than crash resilience. Nevertheless and FWIW, the tests didn't > pick up any regressions. Yay! Great news! Thanks a lot for doing the test and sharing results. Best Regards, Petr
© 2016 - 2025 Red Hat, Inc.