From nobody Tue Dec 2 01:04:49 2025 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 87F292D8367 for ; Fri, 21 Nov 2025 18:51:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763751067; cv=none; b=iRoO4KvlUr4ieYvn9GSEqkyhnzcvgFtlrH5Uey0tRkHt1fZamfIYG6sG2ZsKgG9SbDR/fOYzpCRWyO3vClEWvfzW4NPn0w9822ICwheTeDEu09+Up3TkTb7oko/wv1xOLAB6nCV3e7e7kZyW/KB8rUuGsPkbWJUJMDXi7vq6VW8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763751067; c=relaxed/simple; bh=TNAGn41MV021H2aUeZwKlB7H00LNs29SUKDaNMAUfzg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=hxwI0XysgiEBgmPZPkOnKcLUcfPqIg54J26aV5icVaZHa+85F6pb4h0FHe3XZDyyyFIyqnW30Bt4WBMh23irFIEtGvAblf4+qAaF0l85Y67kTQT1hFlRkOYi4KLkDwxxnBaAtVgqbQH8Ts3TsjMkP5y9o2DmPZvMvj9wftJdNXs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=DNE/n8hd; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="DNE/n8hd" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-477632b0621so16528515e9.2 for ; Fri, 21 Nov 2025 10:51:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1763751060; x=1764355860; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=IKpU+JVEo8jImM4RsWriqSa3YyacHuZk4xRkxS0guks=; b=DNE/n8hdGlb9F0alx6lX9Ixlwirw3r1xBm1Tiz2sQPiUMbCukFaPVLtHhQoM4zXi2v ZFvSIIPs3TU2H6RW0DuL49ckFNGdrEUiXbP1sk2zlzKRiqHXupgFOJqeq0PDeio0TYz9 uHOVngmkuzHq3Ut4f2zQD5aEcKwabBtRiK6VgO0Sa+jHO3AAx3ZSoNOQEAD0dzhs/s/D eD+HHNdk0krzpxmKStRvy6qD3YpmHv2e8+KyYlqPYLl3GOMCumhgf4THHyRZDnBuwD0s nOuYk5SltpZQhsxqdAA6ckKLxDhWXXdGIQRtX/qcRXr56FX7x4rYKNfoofoy3xnFEI/L CsBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763751060; x=1764355860; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=IKpU+JVEo8jImM4RsWriqSa3YyacHuZk4xRkxS0guks=; b=mfSBcbzMaNzx4eYK2PLVRlIkTqS9A+0ruD14A7NlPcrYei1fH4MiOB1eoEW7QEliIi LVeZ+oJYInMD4/1Jl8TGvwwRoHxqMIWD8VNv8Oh4t7tnOmnYmXFLPjsiYnEdsBBWDhN9 FR1ULWn5wSm7OuNSvx3dzQjyZzdTZ4yiS44zWdjbXGaDmZA4KjVdvHxYmF7hXAWSw6Nf 4Znj+/5dj/B2xIT700teNkvETS/SMeNb1vgoxbbG9PVU92s8NelvC3frhqB3wgIVkXJu 6Tktb3ThFBvEJ8V0x9XPUrz7eHbh/BiThKgzPEcbYsMBTpHRAEIfD/iIOZx5ma9tU+k0 NOuw== X-Gm-Message-State: AOJu0YzTwGMDQNqnyQK7v9LIO7/+jkTldTLzZzEzXhiHSka6qScYmrHA +OYgBAg4imBLjtUwvl2ER4rOz/DwFSHaq+b/ouXppFV+5pg5m3MS2gAG6xuPv/FoWUg= X-Gm-Gg: ASbGnct5VKYyKh8yV71mExLJ40KxzpJKvGCzYDiXW2T2bRpb047cfKKrg660tBwAI/o VcIggHTlU3EbkU2a0hD1KS0GIgsiFTQQfgyN2sGLBF3FenLlgei/tAb8t70HWplNrclCpm+3EZa zRFS/sKfIi9PJXrF8X9vQoVmbJOksftHXniFnfq6+UDiCKIvSyG2H1w5A1zP/j3p0Bf5/vT4QoJ 8nN+NUoclyX3YLRbDky54pBFIV1xc54WqwF8/X9KKB5mcqk0gey3wIg8LaUoSC6uGj9Us4zWKT5 c14z+/jJixOXJSS9pY7jqODXQPJqRzYWcFf6djPsQ4ElZpBgxI4byqpPZ3jfT0up8LTLX8w8ZNh 6lbrCBOb7A5X/gDyYmVzK5C0JF3rMTyDJTcaOj2iZV9dmBr91eqW8VVG4BhYnYGL0agQXY4uUEj gujaxVkUmkVqf1N9qzz2RZfCoSZ16fkDUj8HdFU4udVWjJVQ== X-Google-Smtp-Source: AGHT+IEp7w0ciNVkPyG6KJveUGftNTpGrWBeH1bxscHmBcc3IXgFsFDEhjsS1npeT4GimD56otbUpA== X-Received: by 2002:a05:6000:1a8f:b0:42b:3c25:cd06 with SMTP id ffacd0b85a97d-42cc1cee419mr3544639f8f.22.1763751059776; Fri, 21 Nov 2025 10:50:59 -0800 (PST) Received: from [127.0.0.1] (99.36.160.45.gramnet.com.br. [45.160.36.99]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42cb7fd8baesm12473639f8f.39.2025.11.21.10.50.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Nov 2025 10:50:59 -0800 (PST) From: Marcos Paulo de Souza Date: Fri, 21 Nov 2025 15:50:33 -0300 Subject: [PATCH v2 1/4] drivers: serial: kgdboc: Drop checks for CON_ENABLED and CON_BOOT Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251121-printk-cleanup-part2-v2-1-57b8b78647f4@suse.com> References: <20251121-printk-cleanup-part2-v2-0-57b8b78647f4@suse.com> In-Reply-To: <20251121-printk-cleanup-part2-v2-0-57b8b78647f4@suse.com> To: Petr Mladek , Steven Rostedt , John Ogness , Sergey Senozhatsky , Greg Kroah-Hartman , Jiri Slaby , Jason Wessel , Daniel Thompson , Douglas Anderson , Richard Weinberger , Anton Ivanov , Johannes Berg Cc: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, kgdb-bugreport@lists.sourceforge.net, linux-um@lists.infradead.org, Marcos Paulo de Souza X-Mailer: b4 0.15-dev X-Developer-Signature: v=1; a=ed25519-sha256; t=1763751050; l=1305; i=mpdesouza@suse.com; s=20231031; h=from:subject:message-id; bh=TNAGn41MV021H2aUeZwKlB7H00LNs29SUKDaNMAUfzg=; b=44EC1mGND1ysTRERb+Is2jw0ncg0VNA7gddxT3UyAFKxKAz8occNwGH/6zo30HTuKMjRMAhop twSzNFMCXkUByZW8HmxONIKjpn1N/Dp+wJcwjrr3eEm01IAp44DV16a X-Developer-Key: i=mpdesouza@suse.com; a=ed25519; pk=/Ni/TsKkr69EOmdZXkp1Q/BlzDonbOBRsfPa18ySIwU= The original code tried to find a console that has CON_BOOT _or_ CON_ENABLED flag set. The flag CON_ENABLED is set to all registered consoles, so in this case this check is always true, even for the CON_BOOT consoles. The initial intent of the kgdboc_earlycon_init was to get a console early (CON_BOOT) or later on in the process (CON_ENABLED). The code was using for_each_console macro, meaning that all console structs were previously registered on the printk() machinery. At this point, any console found on for_each_console is safe for kgdboc_earlycon_init to use. Dropping the check makes the code cleaner, and avoids further confusion by future readers of the code. Signed-off-by: Marcos Paulo de Souza Reviewed-by: Petr Mladek --- drivers/tty/serial/kgdboc.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/tty/serial/kgdboc.c b/drivers/tty/serial/kgdboc.c index 85f6c5a76e0f..5a955c80a853 100644 --- a/drivers/tty/serial/kgdboc.c +++ b/drivers/tty/serial/kgdboc.c @@ -577,7 +577,6 @@ static int __init kgdboc_earlycon_init(char *opt) console_list_lock(); for_each_console(con) { if (con->write && con->read && - (con->flags & (CON_BOOT | CON_ENABLED)) && (!opt || !opt[0] || strcmp(con->name, opt) =3D=3D 0)) break; } --=20 2.51.1 From nobody Tue Dec 2 01:04:49 2025 Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1CD1A3A1C9 for ; Fri, 21 Nov 2025 18:51:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763751068; cv=none; b=SAt2Qtzw5d2BbGFPN7Ovu9z2co2JlhU5CaU0qvMLWW26ouRw3OwtGWrD9XLjPzd7s5EjgQstH8u+sklXEbHijJmfddVs28dlsNHComcVTHI63TGYAcrr+8Vp182K8OXTOmSLWU+bbURWlZMPZp7Qkna/lNhW2rXzD/KSjJ5K/Go= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763751068; c=relaxed/simple; bh=OUGnBzAKcXkW36Da9OkzDufBeFjxJOoOBfhwdvnkuOI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=PoMOCcSvdBUf0a8gEJWkztPjQ46ayLmpEoabNn1E7meczU/gfgckBTOpYWJ6pMree/CTYE0Fa6F6rTUD2ST+pIzUaXOu0gFW2O56yQwzS23lQIfV4FP6JHpj7PEtpZySnML36g9R0wyk+MtoBEiwSajxxqj9BLzyvB3td6xhv7A= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=Nbjv2Um9; arc=none smtp.client-ip=209.85.221.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="Nbjv2Um9" Received: by mail-wr1-f51.google.com with SMTP id ffacd0b85a97d-429c82bf86bso1456344f8f.1 for ; Fri, 21 Nov 2025 10:51:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1763751064; x=1764355864; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=OLWRSgS8p73WSC4ZXf7/hoyNCz/96zbrBiHTXVpyk3k=; b=Nbjv2Um92AUUggOxj2VY37XfUnBXytLv69xITDVHw/I9SHSy7pqc+pK8YRBUGjaawN S+OzOu6peGGmsUYFR8s4RW/UYxaxD7aQ15RO8V/KFG4Tt38FeSSN6SYdyj6QEsSqFvL6 yLiaQ5mkT7yK1BWOYzP9UQv/CyRYcCtFqo/dmjWBBMO9CFMPrlIwEEdMKicNE6uw0Kzg Gh3rTZXQDc+Ke21WKYhXhEUdmsW5Vcvn9ifgYdfMKN6UPco7hVoP+8ioU33TwgwyLdzp PpfcwiC34DMPvgYUoVSPSWkkqwqT+z814SB6bAbHSYnzuBVwgMzTiORKQJS8/vGgUhEY 3T3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763751064; x=1764355864; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=OLWRSgS8p73WSC4ZXf7/hoyNCz/96zbrBiHTXVpyk3k=; b=kB7ERfgdev0eud4ednZHLuPGzPGsklDYqHaDEUCRD2Rsi61PEHA6Dj0vKMEoLqEZHJ tXSXTZho99YbUfRxjkf9Y3n/SBrXe7YNtmP35zNqfQP816J8GedA5ZR2A0+j+fvAIrFW G803XA48Se/5mEYr9+zYW3Lb5TP9AZO4+AM0fCvhHdihkdcPUQ8xzKH60MW3BhRn0xWf /kCyeZs1IRPQgwX3u+dwdxg6AfzS4ZJvlP5344gQtjMaTxaE4GDdXnnNiQTbRleNv6Au aRinGXxW68Zf4wluw/DZfX+AEUmMu8+Yqx0/P6NeMFUwb+02tEaByYolyEdtzT99aSec d1qw== X-Gm-Message-State: AOJu0YyfpF0k39aY5YzYuHPRKrFC4JG1Rq8vWPLS3h4oCCkineMAq7AF 8c83XBfD3Uz4Cu40yG0srBFgSZec2CXJ8/KjYpDpAwsERLztJzdaclfX5EsC6Pl7YTs= X-Gm-Gg: ASbGncuzT0iw1QxgDuPmzmSx3aMhj53V43h3PGiuMu6IlDxV4B9LM5GKeitNgTWkox7 pwKoUONuA1Yh2FrKFk7GVeVXmzxsRNUyKsVZ5VvDXefK90t15A3e4EScY2HN5BqOV/+oQ/BmL1+ x810gOO4MGBfIqbqphHn7nLTddR+wzgb3cgqt25l8BjTuP8yXyRzhECQNLicCNhHUgjpCMgYplh E9LCQt4kLR6GjYRiLFKHBilG4GR9/Cb3bB9GAPJk2A+8susEhAN6nAt2fz2dvR+8I4ctMaPD+63 RCNzNYqkO0qv0jO13GfosCEbdTkjlmHx77yZXrW/I69PlFEgLBlewu8zujIwETucLcqoNmjMRAd RAHVNPROHR89rpZfUPP8u8wtpLdIlgbk3C+L4qUCGAEXV1SYHugulM8qhFUdOaW6PpdNWruGhYD EAPXL2VbGP/tCaUPQabz+x+OSx0z1MABtObjc= X-Google-Smtp-Source: AGHT+IGFg2pBnIYtz+jUx29u1lZD8eVRjQQpeMqBKI00tlwv+iTZw9tV5Wu13Zv6ZTnAW9KrThP7uQ== X-Received: by 2002:a05:6000:230c:b0:429:dde3:659d with SMTP id ffacd0b85a97d-42cc1d0ce1dmr3746531f8f.47.1763751064299; Fri, 21 Nov 2025 10:51:04 -0800 (PST) Received: from [127.0.0.1] (99.36.160.45.gramnet.com.br. [45.160.36.99]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42cb7fd8baesm12473639f8f.39.2025.11.21.10.51.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Nov 2025 10:51:04 -0800 (PST) From: Marcos Paulo de Souza Date: Fri, 21 Nov 2025 15:50:34 -0300 Subject: [PATCH v2 2/4] arch: um: kmsg_dump: Use console_is_usable Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251121-printk-cleanup-part2-v2-2-57b8b78647f4@suse.com> References: <20251121-printk-cleanup-part2-v2-0-57b8b78647f4@suse.com> In-Reply-To: <20251121-printk-cleanup-part2-v2-0-57b8b78647f4@suse.com> To: Petr Mladek , Steven Rostedt , John Ogness , Sergey Senozhatsky , Greg Kroah-Hartman , Jiri Slaby , Jason Wessel , Daniel Thompson , Douglas Anderson , Richard Weinberger , Anton Ivanov , Johannes Berg Cc: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, kgdb-bugreport@lists.sourceforge.net, linux-um@lists.infradead.org, Marcos Paulo de Souza X-Mailer: b4 0.15-dev X-Developer-Signature: v=1; a=ed25519-sha256; t=1763751050; l=947; i=mpdesouza@suse.com; s=20231031; h=from:subject:message-id; bh=OUGnBzAKcXkW36Da9OkzDufBeFjxJOoOBfhwdvnkuOI=; b=NhgxbcLWcMIXgHoLmIkuyir16mphjDmcWSS+twRF1KgkvMiTNw7Q71Y6gddQptkBeT/ZV7ybA 7aK6FXimEBMB8iP+Lld4HVVYCnfUvIZlIMUIC+Vdjx4lrgmiiIWXdaA X-Developer-Key: i=mpdesouza@suse.com; a=ed25519; pk=/Ni/TsKkr69EOmdZXkp1Q/BlzDonbOBRsfPa18ySIwU= All consoles found on for_each_console are registered, meaning that all of them have the CON_ENABLED flag set. Since NBCON was introduced it's important to check if a given console also implements the NBCON callbacks. The function console_is_usable does exactly that. Signed-off-by: Marcos Paulo de Souza Reviewed-by: Petr Mladek --- arch/um/kernel/kmsg_dump.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/um/kernel/kmsg_dump.c b/arch/um/kernel/kmsg_dump.c index 419021175272..fc0f543d1d8e 100644 --- a/arch/um/kernel/kmsg_dump.c +++ b/arch/um/kernel/kmsg_dump.c @@ -31,7 +31,7 @@ static void kmsg_dumper_stdout(struct kmsg_dumper *dumper, * expected to output the crash information. */ if (strcmp(con->name, "ttynull") !=3D 0 && - (console_srcu_read_flags(con) & CON_ENABLED)) { + console_is_usable(con, console_srcu_read_flags(con), true)) { break; } } --=20 2.51.1 From nobody Tue Dec 2 01:04:49 2025 Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A8A052F3620 for ; Fri, 21 Nov 2025 18:51:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763751072; cv=none; b=Y48dfp4y1P2JvHyxLuJZ2K4YqaP3YqRv7bU/WFGQVHXRd1K6XGgk29h9AsEHH+VkygjHTphQGchDxdabifGrgEvn2HxeZGaGaNTlKyC5ScgF9Gb7ciaYfD9N7GG31eNxEATThOfbT6stquiUo9drXk9OoaE1hFAOaTeIamhFtyk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763751072; c=relaxed/simple; bh=NKFHmcfiCk2EwIkTHkKYjnx6rN1uKn1am+sBKF+oi8Q=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Dzz6XDy4KgDTMqjd9/46YO8nHZI+CG5w5z2tAY1DAigDlF8nmsUaQfqgheVGpOJJgjXx/JHRvVPfcbaLbsegoOiTmo0LsUD5KxCC2VaS4OeS1XWF74Rf6UUt7TPwTPJzz6MNKRJmHV6eSNt3O4StSDTPSW4S40w+RmPXz4XPvUU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=gnToBzky; arc=none smtp.client-ip=209.85.221.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="gnToBzky" Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-42b3ac40ae4so1378487f8f.0 for ; Fri, 21 Nov 2025 10:51:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1763751069; x=1764355869; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=UFSdbuEHlkMgMI9LKgp25jd/vaPmbZhF8IKFWk4+qQQ=; b=gnToBzkyuSErRs5sXo3yPsyaP6GkPTMAlDlDR3BKdtIRiSlrx0F+4yroi7MSEMS08C J9xfVwc6cXq2gePZRdz3OZJas8v9elkzFlbWF+QbCrZfQCvuRWJngkwrfAgFGMXwUsDY lSRMl5lyg55fXG2Vpu2J07WLl1CbrrVsqAMbhW480aTqkNTEUNEsolybH3HtGTpYoJDq 9BjNX/9Nt9egBNryHUdm0BXG4AEtg82DXnDEbT9+TwumglkSj80DMpdaS7lvkwTCdp8U N/UPTo14yoavNB9SFBDH6lHwDVVW+dqtjrm3cVyvH4yVSSKddhn0eqlAb/y/3MGCLQe7 pv2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763751069; x=1764355869; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=UFSdbuEHlkMgMI9LKgp25jd/vaPmbZhF8IKFWk4+qQQ=; b=tUn5EGRg1dCyBlCQkmWFKd9msNZOHpOkU3tXYJfQO0bwPZfWkGbwY8ExcUjdcls8sF 0jJk0FYXsqS8WU99y2nK5T8QbMkc084midq/8fckJ1Z3d3tzI7FDi19Krv9IKYhqVX8R HQ8XJHVbDvG+fU8j4o4P2Q416Z3cUU21Uh1uSejbnvMhwf7lqedb/Ac/8N2bplN8Md2g gmgmcVvDr4cDzeDK/nqtCLU6w2YmBlLjYbMT8lLNkDvmaUW5tMA9/dK/paJkjlwVPozG YvdAq7GCxpA292GzrkrrcaEXcEcv7/SN7As5v2+90ppC972uUWuL3eeaaxy/UXIJV/mn gyUw== X-Gm-Message-State: AOJu0YwssC1fxZdXdwscKWCpQnmkNJMPoXgnvxCrc+CcVvjboBIPnuLT D7XwRuVUIzPCv3e+kNc8H8Shoyl0SO+zT3p9vSgUKv925rkuOeEQQmR0ZUGquz78ltI= X-Gm-Gg: ASbGncsRpPKF+1Fx/+X5qaEOHvzLd/dnkxBZ3wqyMsF2Li8flTuh2A0f4LbGt/ce9B/ V4DVS8HJWWkRL8vHd+iNT+/z5Fnafo+2axT5n2FyNYcmc1uv7Q5BrieuL033jTmsylfJVrinane qV9+RKvgVCOCqLOGd5RnDUrELIPW7OaUpLBrW2TkzvY4KJPryPZg+MQlGRUkqvAcRan1OJ1Zlbz uf6xsQ18km2w9KdVvFc2rHsWCzV9SMhOnOi6XfSfh0sb41NraiGK5stv5sKJzQ4BUzE+OgBiSTh FQY9AVYto8VO37rOIAamlufVAVl6PuwJgxpux2qBrXZEc1Kbgl/0Z6BAZ4lr3b77GNGxqY1dv+N W/GWHsdi02vKByZ4HaU7CPvtcRCn4kMo0gBsVV09rzwNyBWTKPTpeSROTa2g7v3X/3Vt6/MKTsX f4vrnY24W8SgslJCtXDlhGf7bJl/r4sCiPY/s= X-Google-Smtp-Source: AGHT+IE3ueb1gfvZpdP1O8B6KsMhh0NreYclj90YAJqPRO3t3jMYj6PAYTHfKHARsU3VdjyGtVHkhA== X-Received: by 2002:a05:6000:601:b0:42b:4219:269 with SMTP id ffacd0b85a97d-42cc1d0cf4amr3499114f8f.41.1763751068837; Fri, 21 Nov 2025 10:51:08 -0800 (PST) Received: from [127.0.0.1] (99.36.160.45.gramnet.com.br. [45.160.36.99]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42cb7fd8baesm12473639f8f.39.2025.11.21.10.51.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Nov 2025 10:51:08 -0800 (PST) From: Marcos Paulo de Souza Date: Fri, 21 Nov 2025 15:50:35 -0300 Subject: [PATCH v2 3/4] printk: Use console_is_usable on console_unblank Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251121-printk-cleanup-part2-v2-3-57b8b78647f4@suse.com> References: <20251121-printk-cleanup-part2-v2-0-57b8b78647f4@suse.com> In-Reply-To: <20251121-printk-cleanup-part2-v2-0-57b8b78647f4@suse.com> To: Petr Mladek , Steven Rostedt , John Ogness , Sergey Senozhatsky , Greg Kroah-Hartman , Jiri Slaby , Jason Wessel , Daniel Thompson , Douglas Anderson , Richard Weinberger , Anton Ivanov , Johannes Berg Cc: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, kgdb-bugreport@lists.sourceforge.net, linux-um@lists.infradead.org, Marcos Paulo de Souza X-Mailer: b4 0.15-dev X-Developer-Signature: v=1; a=ed25519-sha256; t=1763751050; l=1461; i=mpdesouza@suse.com; s=20231031; h=from:subject:message-id; bh=NKFHmcfiCk2EwIkTHkKYjnx6rN1uKn1am+sBKF+oi8Q=; b=t+kTGkkizl6U6aR6PW2Gu87Sum27bEEzl8ibey1pJbKk6zu1jVjEcA/kU+oc6YLo7Px6+PkCp QGPAFvKM1ClA+rzBQGG0BnUK0kRud59IVkxx67TxhQX137mqpi913XJ X-Developer-Key: i=mpdesouza@suse.com; a=ed25519; pk=/Ni/TsKkr69EOmdZXkp1Q/BlzDonbOBRsfPa18ySIwU= The macro for_each_console_srcu iterates over all registered consoles. It's implied that all registered consoles have CON_ENABLED flag set, making the check for the flag unnecessary. Call console_is_usable function to fully verify if the given console is usable before calling the ->unblank callback. Signed-off-by: Marcos Paulo de Souza Reviewed-by: Petr Mladek --- kernel/printk/printk.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c index cb79d1d2e6e5..fed98a18e830 100644 --- a/kernel/printk/printk.c +++ b/kernel/printk/printk.c @@ -3374,12 +3374,10 @@ void console_unblank(void) */ cookie =3D console_srcu_read_lock(); for_each_console_srcu(c) { - short flags =3D console_srcu_read_flags(c); - - if (flags & CON_SUSPENDED) + if (!console_is_usable(c, console_srcu_read_flags(c), true)) continue; =20 - if ((flags & CON_ENABLED) && c->unblank) { + if (c->unblank) { found_unblank =3D true; break; } @@ -3416,12 +3414,10 @@ void console_unblank(void) =20 cookie =3D console_srcu_read_lock(); for_each_console_srcu(c) { - short flags =3D console_srcu_read_flags(c); - - if (flags & CON_SUSPENDED) + if (!console_is_usable(c, console_srcu_read_flags(c), true)) continue; =20 - if ((flags & CON_ENABLED) && c->unblank) + if (c->unblank) c->unblank(); } console_srcu_read_unlock(cookie); --=20 2.51.1 From nobody Tue Dec 2 01:04:49 2025 Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2CD1F2459F7 for ; Fri, 21 Nov 2025 18:51:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763751077; cv=none; b=SUQjmwRE/gdMJTI12uWQkvuPzSLDIPil4y5WjO6ApENznOi9zboAU/WXnXL5ZMZNsZBKHbfunqNnVNIN3il3Miau6TnrXMNvBfMjyAMpuaLV4ZoSHT9OWnxMg1MJV7q9No96tigT5BDoGusOgeFhj+fAeSs4iv9dnz1h+TkQTZo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763751077; c=relaxed/simple; bh=Me+FmgCVuipIeMGIOmW7VyWb0ioSCEd8yB49PjrkFbM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Y4ZI/3ZFCH5iN9kOIkrD9C04w0unLwHRBX1YTyKOEWXa+FqgHhWO/ICALcB3HBqLKIZh0OuMU5qoRxYeyOaHmVADIwGOQPX89AjGcUbOBUcTlN+itbl3rcjvY0qBlbrLk5A9gFIsT71MqeS6j9M5yoptz+voGKRt//2fwNv1P+w= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=DrtNs5Is; arc=none smtp.client-ip=209.85.221.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="DrtNs5Is" Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-429c48e05aeso1592675f8f.1 for ; Fri, 21 Nov 2025 10:51:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1763751073; x=1764355873; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=zeiJZSVEGGN00WPtN6lgqyU6XWLEKHbZMZ9rjX+7HGY=; b=DrtNs5IscZvUGr6jWbsf2bJgA3AeuT8c3OToH+se8gsIp0DYziPVQpSqikQ70nO/9l BPTzl+9o2UAKNzKYzUkHhuT9fPecCdy4UBKX1/e2P011F4P2rewhUKEEL+oczyySR7rn FTKk6/r5OFBbNJi4D8IFrViybQkTJLgfwpXIPTpOwpjtqpVXZ5nh6XaMJCDHtYUIpVlu LkAPh9ufpfcLyJmRxtITxnBjxXorr0Z4f+34/SMvs0xMvW7DGydqIOYVQ9g33kEgxJST PVzWfjwkqZAQAR24IKczF9/4MuQuM+HnuD9rL3yXxL/fQN50Kq3RxTmabrhxwNLpyUsU E7lA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763751073; x=1764355873; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=zeiJZSVEGGN00WPtN6lgqyU6XWLEKHbZMZ9rjX+7HGY=; b=R0BIRw2eWOXBrJmbnyQxUWatgThzoilzHY+C/NGEQj9PJ6lA5V/LB/L3eO5F0JVUEY F+fgeJjXFlTjbPEy3V4FpdmGe107wLkvEIkCUhIowvZ8pwzh9qKv2I0saJKKH/oQKbui rlTGNIDeA19m1Cxx5aiReaOJOljyE86aAI8Jk1i6QcjDRMQf0bF3t+djiFcKl5f8bVPL SqFnASD4aDGfTDtBZpaYfT37P4rH4aGCtmq7X7cufZPRiMc4ca0S0oaJL9P5Y6G4cRSO T5n2qs/JT5ErOcBDrWCIoFj/Dm9YJnMCEAHBqrUj77WgVXzs5ZuAHRe7CuD6VtR1/Q6l KHyg== X-Gm-Message-State: AOJu0YwcFjLn/zcWv8YIaBuZ0Ans6110k69oXJSRkoyd4yCPKXd0YLt2 8Diltcoa6NKVTYdmUDTOkvDfvf/VeUQZdXRt8qhzT4wTlkiEo3+jwy9njDuNXZmymnc= X-Gm-Gg: ASbGncvaG3f+Pwyw59/40xoiIh+mNmnrSxxA6r9ZftEsYKbBfrQblHTLxyxwpqEgMFe o0/1oarDsvLJy9cq4DErvJGHCSBi9IBi9X8xnGsA5nwPmGlxlJEsY0f8HfPP4U+0owy8/UG43o5 Fn0BMXc84vHM2blaBRFDjeQtPeWZ7CEdTa47mfjyPRPjPjy4BPSGHUu8bwplJ8jZG7wdEQGTRxW kZ8jhAhAFLroE4xQnpL9Ja//UD10+WCOqTf2n16Z6usQrN8DsKPswDN02pHPA02sI7GJQfriRXa TiOKS+vy/rrfFTbPrTKNlk+9ewltZSdfykr0paG8Oj54f6e0NB0025g2yiPSZa2VsCk0GSR3JQM Lq0czkpk/m6Z5VAv036mf900TRM06oOw4Ar2JEm8nKCn8m6dIybWk2g2CGTH2VZDX2jum+loIG/ a/xN/WP2fIiGhMADlSvCcxtKrwxiirn5l552E= X-Google-Smtp-Source: AGHT+IENN61/obhbDbsiWgswns0YOtLZMBMlnpiskqZW9+NCINqWoGwYz+8q1vTBc1WOclyJO+Metw== X-Received: by 2002:a05:6000:4210:b0:429:eb05:1c69 with SMTP id ffacd0b85a97d-42cba63b646mr8898226f8f.2.1763751073426; Fri, 21 Nov 2025 10:51:13 -0800 (PST) Received: from [127.0.0.1] (99.36.160.45.gramnet.com.br. [45.160.36.99]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42cb7fd8baesm12473639f8f.39.2025.11.21.10.51.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Nov 2025 10:51:13 -0800 (PST) From: Marcos Paulo de Souza Date: Fri, 21 Nov 2025 15:50:36 -0300 Subject: [PATCH v2 4/4] printk: Make console_{suspend,resume} handle CON_SUSPENDED Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251121-printk-cleanup-part2-v2-4-57b8b78647f4@suse.com> References: <20251121-printk-cleanup-part2-v2-0-57b8b78647f4@suse.com> In-Reply-To: <20251121-printk-cleanup-part2-v2-0-57b8b78647f4@suse.com> To: Petr Mladek , Steven Rostedt , John Ogness , Sergey Senozhatsky , Greg Kroah-Hartman , Jiri Slaby , Jason Wessel , Daniel Thompson , Douglas Anderson , Richard Weinberger , Anton Ivanov , Johannes Berg Cc: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, kgdb-bugreport@lists.sourceforge.net, linux-um@lists.infradead.org, Marcos Paulo de Souza X-Mailer: b4 0.15-dev X-Developer-Signature: v=1; a=ed25519-sha256; t=1763751050; l=1998; i=mpdesouza@suse.com; s=20231031; h=from:subject:message-id; bh=Me+FmgCVuipIeMGIOmW7VyWb0ioSCEd8yB49PjrkFbM=; b=1f1XQPksSyg2y3pXUnelAzKyzaedaVrzMjIzV4D5cPN+kduYUUNr7nIbIGu3SdlK+vY1dppDR WrcjcRwmPvCAZWS/IHHAlVNhq/wnrv4ph6Y5HplOAbeUOE6cjJPPdGD X-Developer-Key: i=mpdesouza@suse.com; a=ed25519; pk=/Ni/TsKkr69EOmdZXkp1Q/BlzDonbOBRsfPa18ySIwU= Since commit 9e70a5e109a4 ("printk: Add per-console suspended state") the CON_SUSPENDED flag was introced, and this flag was being checked on console_is_usable function, which returns false if the console is suspended. To make the behavior consistent, change show_cons_active to look for consoles that are not suspended, instead of checking CON_ENABLED. Signed-off-by: Marcos Paulo de Souza --- drivers/tty/tty_io.c | 2 +- kernel/printk/printk.c | 5 +++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/tty/tty_io.c b/drivers/tty/tty_io.c index e2d92cf70eb7..1b2ce0f36010 100644 --- a/drivers/tty/tty_io.c +++ b/drivers/tty/tty_io.c @@ -3554,7 +3554,7 @@ static ssize_t show_cons_active(struct device *dev, continue; if (!(c->flags & CON_NBCON) && !c->write) continue; - if ((c->flags & CON_ENABLED) =3D=3D 0) + if (c->flags & CON_SUSPENDED) continue; cs[i++] =3D c; if (i >=3D ARRAY_SIZE(cs)) diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c index fed98a18e830..fe7c956f73bd 100644 --- a/kernel/printk/printk.c +++ b/kernel/printk/printk.c @@ -3542,7 +3542,7 @@ void console_suspend(struct console *console) { __pr_flush(console, 1000, true); console_list_lock(); - console_srcu_write_flags(console, console->flags & ~CON_ENABLED); + console_srcu_write_flags(console, console->flags | CON_SUSPENDED); console_list_unlock(); =20 /* @@ -3555,13 +3555,14 @@ void console_suspend(struct console *console) } EXPORT_SYMBOL(console_suspend); =20 +/* Unset CON_SUSPENDED flag so the console can start printing again. */ void console_resume(struct console *console) { struct console_flush_type ft; bool is_nbcon; =20 console_list_lock(); - console_srcu_write_flags(console, console->flags | CON_ENABLED); + console_srcu_write_flags(console, console->flags & ~CON_SUSPENDED); is_nbcon =3D console->flags & CON_NBCON; console_list_unlock(); =20 --=20 2.51.1