[PATCH v3 00/12] Make Samsung SOFEF00 DDIC and panel work

David Heidelberg via B4 Relay posted 12 patches 1 week, 5 days ago
.../bindings/display/panel/panel-simple-dsi.yaml   |  25 +----
.../bindings/display/panel/samsung,sofef00.yaml    |  79 ++++++++++++++++
MAINTAINERS                                        |   7 ++
.../boot/dts/qcom/sdm845-oneplus-enchilada.dts     |   4 +-
drivers/gpu/drm/panel/Kconfig                      |   7 +-
drivers/gpu/drm/panel/panel-samsung-sofef00.c      | 105 +++++++++++++--------
6 files changed, 163 insertions(+), 64 deletions(-)
[PATCH v3 00/12] Make Samsung SOFEF00 DDIC and panel work
Posted by David Heidelberg via B4 Relay 1 week, 5 days ago
This DDIC is essential for panels used in OnePlus 6 and Pixel 3a XL
(SDC variant). With proper support, all downstream patches in
sdm845-mainline and sdm670-mainline can be dropped.

The mainline driver was broken so far, and with my recent introduction
of S6E3FC2X01 driver, I had to "break it even more" due to OnePlus 6
common device-tree changes which defined all the regulators and
corrected properties.

At this moment the first version of the patchset will not include
Pixel 3a XL (SDC) as no testers yet volunteered.

The code, including the Pixel 3a XL enhancement can be found at
  https://gitlab.com/sdm845/sdm845-next/-/commits/b4%252Fsofef00-rebuild

Signed-off-by: David Heidelberg <david@ixit.cz>
---
Changes in v3:
- Drop arch prefix from the commit. (Bjorn)
- Added Casey into MAINTAINERS file. (Casey)
- Moved compatible legacy comment inline.
- Link to v2: https://lore.kernel.org/r/20251113-sofef00-rebuild-v2-0-e175053061ec@ixit.cz

Changes in v2:
- General fixes to device-tree binding (Krzysztof)
- Add myself as a maintainer
- Updated commits wording
- Link to v1: https://lore.kernel.org/r/20251104-sofef00-rebuild-v1-0-dfcfa17eb176@ixit.cz

---
Casey Connolly (2):
      drm/panel: sofef00: Add prepare_prev_first flag to drm_panel
      drm/panel: sofef00: Initialise at 50% brightness

David Heidelberg (10):
      dt-bindings: panel: Convert Samsung SOFEF00 DDIC into standalone yaml
      arm64: qcom: sdm845-enchilada: Specify panel name within the compatible
      drm/panel: sofef00: Clean up panel description after s6e3fc2x01 removal
      drm/panel: sofef00: Handle all regulators
      drm/panel: sofef00: Split sending commands to the enable/disable functions
      drm/panel: sofef00: Introduce page macro
      drm/panel: sofef00: Introduce compatible which includes the panel name
      drm/panel: sofef00: Simplify get_modes
      drm/panel: sofef00: Mark the LPM mode always-on
      drm/panel: sofef00: Non-continuous mode and video burst are supported

 .../bindings/display/panel/panel-simple-dsi.yaml   |  25 +----
 .../bindings/display/panel/samsung,sofef00.yaml    |  79 ++++++++++++++++
 MAINTAINERS                                        |   7 ++
 .../boot/dts/qcom/sdm845-oneplus-enchilada.dts     |   4 +-
 drivers/gpu/drm/panel/Kconfig                      |   7 +-
 drivers/gpu/drm/panel/panel-samsung-sofef00.c      | 105 +++++++++++++--------
 6 files changed, 163 insertions(+), 64 deletions(-)
---
base-commit: fe4d0dea039f2befb93f27569593ec209843b0f5
change-id: 20251104-sofef00-rebuild-04cfc6e68e71

Best regards,
-- 
David Heidelberg <david@ixit.cz>
Re: [PATCH v3 00/12] Make Samsung SOFEF00 DDIC and panel work
Posted by Neil Armstrong 1 week, 5 days ago
On 11/19/25 15:21, David Heidelberg via B4 Relay wrote:
> This DDIC is essential for panels used in OnePlus 6 and Pixel 3a XL
> (SDC variant). With proper support, all downstream patches in
> sdm845-mainline and sdm670-mainline can be dropped.
> 
> The mainline driver was broken so far, and with my recent introduction
> of S6E3FC2X01 driver, I had to "break it even more" due to OnePlus 6
> common device-tree changes which defined all the regulators and
> corrected properties.
> 
> At this moment the first version of the patchset will not include
> Pixel 3a XL (SDC) as no testers yet volunteered.
> 
> The code, including the Pixel 3a XL enhancement can be found at
>    https://gitlab.com/sdm845/sdm845-next/-/commits/b4%252Fsofef00-rebuild
> 
> Signed-off-by: David Heidelberg <david@ixit.cz>
> ---
> Changes in v3:
> - Drop arch prefix from the commit. (Bjorn)
> - Added Casey into MAINTAINERS file. (Casey)
> - Moved compatible legacy comment inline.
> - Link to v2: https://lore.kernel.org/r/20251113-sofef00-rebuild-v2-0-e175053061ec@ixit.cz
> 
> Changes in v2:
> - General fixes to device-tree binding (Krzysztof)
> - Add myself as a maintainer
> - Updated commits wording
> - Link to v1: https://lore.kernel.org/r/20251104-sofef00-rebuild-v1-0-dfcfa17eb176@ixit.cz
> 
> ---
> Casey Connolly (2):
>        drm/panel: sofef00: Add prepare_prev_first flag to drm_panel
>        drm/panel: sofef00: Initialise at 50% brightness
> 
> David Heidelberg (10):
>        dt-bindings: panel: Convert Samsung SOFEF00 DDIC into standalone yaml
>        arm64: qcom: sdm845-enchilada: Specify panel name within the compatible
>        drm/panel: sofef00: Clean up panel description after s6e3fc2x01 removal
>        drm/panel: sofef00: Handle all regulators
>        drm/panel: sofef00: Split sending commands to the enable/disable functions
>        drm/panel: sofef00: Introduce page macro
>        drm/panel: sofef00: Introduce compatible which includes the panel name
>        drm/panel: sofef00: Simplify get_modes
>        drm/panel: sofef00: Mark the LPM mode always-on
>        drm/panel: sofef00: Non-continuous mode and video burst are supported
> 
>   .../bindings/display/panel/panel-simple-dsi.yaml   |  25 +----
>   .../bindings/display/panel/samsung,sofef00.yaml    |  79 ++++++++++++++++
>   MAINTAINERS                                        |   7 ++
>   .../boot/dts/qcom/sdm845-oneplus-enchilada.dts     |   4 +-
>   drivers/gpu/drm/panel/Kconfig                      |   7 +-
>   drivers/gpu/drm/panel/panel-samsung-sofef00.c      | 105 +++++++++++++--------
>   6 files changed, 163 insertions(+), 64 deletions(-)
> ---
> base-commit: fe4d0dea039f2befb93f27569593ec209843b0f5
> change-id: 20251104-sofef00-rebuild-04cfc6e68e71
> 
> Best regards,

For the serie:
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>

Thanks,
Neil
Re: (subset) [PATCH v3 00/12] Make Samsung SOFEF00 DDIC and panel work
Posted by Neil Armstrong 1 week, 5 days ago
Hi,

On Wed, 19 Nov 2025 15:21:25 +0100, David Heidelberg wrote:
> This DDIC is essential for panels used in OnePlus 6 and Pixel 3a XL
> (SDC variant). With proper support, all downstream patches in
> sdm845-mainline and sdm670-mainline can be dropped.
> 
> The mainline driver was broken so far, and with my recent introduction
> of S6E3FC2X01 driver, I had to "break it even more" due to OnePlus 6
> common device-tree changes which defined all the regulators and
> corrected properties.
> 
> [...]

Thanks, Applied to https://gitlab.freedesktop.org/drm/misc/kernel.git (drm-misc-next)

[01/12] dt-bindings: panel: Convert Samsung SOFEF00 DDIC into standalone yaml
        https://gitlab.freedesktop.org/drm/misc/kernel/-/commit/1388c08c84a2b1f37abae656c1f88d18ecb1364e
[03/12] drm/panel: sofef00: Clean up panel description after s6e3fc2x01 removal
        https://gitlab.freedesktop.org/drm/misc/kernel/-/commit/05aeb5bb4b699b51f88d9f5585005b6eb66a496b
[04/12] drm/panel: sofef00: Handle all regulators
        https://gitlab.freedesktop.org/drm/misc/kernel/-/commit/dfc7e0859e05991b0920bd249434e44866a11bd1
[05/12] drm/panel: sofef00: Split sending commands to the enable/disable functions
        https://gitlab.freedesktop.org/drm/misc/kernel/-/commit/18642542ac4916807fc0925cdcb9356f5802e2ae
[06/12] drm/panel: sofef00: Introduce page macro
        https://gitlab.freedesktop.org/drm/misc/kernel/-/commit/9f1ba273f55f93759cfd1098e0682b03eb115bb4
[07/12] drm/panel: sofef00: Add prepare_prev_first flag to drm_panel
        https://gitlab.freedesktop.org/drm/misc/kernel/-/commit/1e534a56578bbea59165c3507d2b967f29771792
[08/12] drm/panel: sofef00: Initialise at 50% brightness
        https://gitlab.freedesktop.org/drm/misc/kernel/-/commit/e2e94464cf44f91c92eb631d609f812c7aef8840
[09/12] drm/panel: sofef00: Introduce compatible which includes the panel name
        https://gitlab.freedesktop.org/drm/misc/kernel/-/commit/6a353661e7058795a800de3535e4e1448d125676
[10/12] drm/panel: sofef00: Simplify get_modes
        https://gitlab.freedesktop.org/drm/misc/kernel/-/commit/940c451981ebd0901f39675c9ff3b3e1c9760571
[11/12] drm/panel: sofef00: Mark the LPM mode always-on
        https://gitlab.freedesktop.org/drm/misc/kernel/-/commit/73540e5e7c52264633c66aad681e53f7e2f54c57
[12/12] drm/panel: sofef00: Non-continuous mode and video burst are supported
        https://gitlab.freedesktop.org/drm/misc/kernel/-/commit/8bff3a2bf7c50bf45766edcd5440329d6b5cdf96

-- 
Neil