From nobody Tue Dec 2 02:19:48 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AE7632652AC; Wed, 19 Nov 2025 14:21:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763562101; cv=none; b=g5CXlVGofV9Tne1SMnKwjTbV75OyyZ5NSagpb16NYaOhbRCSNPV1AEhDCrZJBc17/ovHv+eXiGasNO2mqTOisUH1E5sWW4Orcw7eEV/nw2ZaE+eIfMnt9igtB2AbMw342CdEuxclT9yG7FSln/OXGK1qfne6Ev5XyV4uTtEP+BY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763562101; c=relaxed/simple; bh=Tb+w/XbxOriNJgYQFbC8+hCQCLxQbYZDylDn4vEl52Y=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=FU7K4IONYwOag9Fwg3XRnLZ2LnFklSjSZhePDQ95/q8vHY5lgIn/RsGCFV2a/4mItXNB356q74LvPw9V+M0f9CmV5Te7l5bC8AjYfD6gvNRFPuivgT4ypd5SmblLmrXM/I8chjcNuyr5Ku5DMhQcD0nNoFnq7pPOT1ziIeSxgxQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=LE+l582E; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="LE+l582E" Received: by smtp.kernel.org (Postfix) with ESMTPS id CCC5EC4AF09; Wed, 19 Nov 2025 14:21:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1763562101; bh=Tb+w/XbxOriNJgYQFbC8+hCQCLxQbYZDylDn4vEl52Y=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=LE+l582E+DJEHXsHAf+dLt+/AGwJuTYRa9MKQY9PHfkepu92glus8JSYwyVrN+4rZ 7QLUb1mDVC1VhtOoc/6+PeXVYKvfFwIrnft/vvnhsGPjh012NuK1q/8TcxJ4CYBtYE CzgEhFr1KUzcFJrREMh3BgcS/NRX9cdS5f1LESq25w8+ro8DYsk7vFecIhBFcFCwd1 tu2hOYO1mUyVa6DfIQ3W7TEPnxkUqs0UBhXFReFTo/CpoZo0S77v7BraQlekToFUp7 bQQVxF5CjubM+THvmoCZLap6Gu1r6Wy0GWygqhEbEhx2Gw11XxuWLhcqrwH3yHy4sn kA1RjOFG4jwSA== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E8C6CF34AD; Wed, 19 Nov 2025 14:21:40 +0000 (UTC) From: David Heidelberg via B4 Relay Date: Wed, 19 Nov 2025 15:21:26 +0100 Subject: [PATCH v3 01/12] dt-bindings: panel: Convert Samsung SOFEF00 DDIC into standalone yaml Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251119-sofef00-rebuild-v3-1-6cd55471e84e@ixit.cz> References: <20251119-sofef00-rebuild-v3-0-6cd55471e84e@ixit.cz> In-Reply-To: <20251119-sofef00-rebuild-v3-0-6cd55471e84e@ixit.cz> To: Neil Armstrong , Jessica Zhang , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Thierry Reding , Sam Ravnborg , Bjorn Andersson , Konrad Dybcio , Casey Connolly , Jessica Zhang Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, phone-devel@vger.kernel.org, David Heidelberg , Krzysztof Kozlowski X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=5338; i=david@ixit.cz; h=from:subject:message-id; bh=Ci3WVsbLezRICGGBNkNcuK4J529ZhFEeGZtioYqJtVk=; b=owEBbQKS/ZANAwAIAWACP8TTSSByAcsmYgBpHdJxE5Znoy6cf8rgB8XRZ3ZAtj+ovz/aOZDmk AsIngOQO2+JAjMEAAEIAB0WIQTXegnP7twrvVOnBHRgAj/E00kgcgUCaR3ScQAKCRBgAj/E00kg crGlD/9ZptNDbEgTSfUag9/iY4Y7PuQ0z7V19gwhFARYrYkYm54b8ZiGauBTgZUtoQyYHHq5YFw oLXdgPm26/flE0n7fJ2oH0TSe2X+SVVvbVIj/jO1iLYIkb+i7wRXAFlClwWdrWrcRPMv5f2xAWg UzmZxO0ny2QNm8pYiGXyJTD2SIFIGWvYTYK4wLoe0ElQ/u2wddYVEs3tsN0/KNOLACPzY8gm6DI nnt47AMqkHeRyTjb9I3AK7WR+iI4OCWDmwJ4rufh15CEhUt51hmtMseDRc9l0RI6SXyzjdjrkVE 1n7cYNdbXWfBVNt8bzv72hIEVmYddSZllZiqKM0FFA5xmGDkD/P3AsYJdpsygcN0fBZjU+6ZChR YmUJu8fel86ChtLojvjwpO46FtLWz4rnSiKB8UfdFM50KeMxECxOgbAN5KYCBBGgHglcSBfGaAV v+iDjoyR5339kHrHoMnMkhZh8RoctRJLxhi6sKrqqMx9ttvILnb2dpWzCqWyoW3fXRjg3ct4NKc OtGPEXXlHI2jd4I/JMr8ydkjBMXp9i6Wo0Hq7fGqYYCQtvbe+8vRncN0e6lfyvaeIUnyZbPOzKe Py2roLSmZ2p7Wy8FP7vu2VC7qEkE0LNz7DnYWdAcF4tREEUuh12TDo7VhE3sinWLtoMdPa6KIdq qyphhVVQXZMU8kA== X-Developer-Key: i=david@ixit.cz; a=openpgp; fpr=D77A09CFEEDC2BBD53A7047460023FC4D3492072 X-Endpoint-Received: by B4 Relay for david@ixit.cz/default with auth_id=355 X-Original-From: David Heidelberg Reply-To: david@ixit.cz From: David Heidelberg Reason for moving from simple panel is this DDIC has three supplies, while panel-simple-dsi is limited to one. Previous compatible only described the DDIC, but didn't include panel connected to it. Let's fix it, and offer bindings authors two compatibles to distinguish the connected panel. Basic description for SOFEF00 DDIC with attached panels - Samsung AMS601NT22 6.01 inch, 1080x2160 pixels, 18:9 ratio - Samsung AMS628NW01 6.28 inch, 1080x2280 pixels, 19:9 ratio There is only one user which uses samsung,sofef00 and it's updated to comply within this patch series. Reviewed-by: Krzysztof Kozlowski Signed-off-by: David Heidelberg Reviewed-by: Neil Armstrong --- .../bindings/display/panel/panel-simple-dsi.yaml | 25 ++----- .../bindings/display/panel/samsung,sofef00.yaml | 79 ++++++++++++++++++= ++++ MAINTAINERS | 7 ++ 3 files changed, 90 insertions(+), 21 deletions(-) diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple-d= si.yaml b/Documentation/devicetree/bindings/display/panel/panel-simple-dsi.= yaml index ac2db8cf5eb76..464d7c8a7665e 100644 --- a/Documentation/devicetree/bindings/display/panel/panel-simple-dsi.yaml +++ b/Documentation/devicetree/bindings/display/panel/panel-simple-dsi.yaml @@ -19,6 +19,9 @@ description: | =20 If the panel is more advanced a dedicated binding file is required. =20 +allOf: + - $ref: panel-common.yaml# + properties: =20 compatible: @@ -56,8 +59,6 @@ properties: - panasonic,vvx10f034n00 # Samsung s6e3fa7 1080x2220 based AMS559NK06 AMOLED panel - samsung,s6e3fa7-ams559nk06 - # Samsung sofef00 1080x2280 AMOLED panel - - samsung,sofef00 # Shangai Top Display Optoelectronics 7" TL070WSH30 1024x600 TFT L= CD panel - tdo,tl070wsh30 =20 @@ -70,30 +71,12 @@ properties: reset-gpios: true port: true power-supply: true - vddio-supply: true - -allOf: - - $ref: panel-common.yaml# - - if: - properties: - compatible: - enum: - - samsung,sofef00 - then: - properties: - power-supply: false - required: - - vddio-supply - else: - properties: - vddio-supply: false - required: - - power-supply =20 additionalProperties: false =20 required: - compatible + - power-supply - reg =20 examples: diff --git a/Documentation/devicetree/bindings/display/panel/samsung,sofef0= 0.yaml b/Documentation/devicetree/bindings/display/panel/samsung,sofef00.ya= ml new file mode 100644 index 0000000000000..eeee3cac72e31 --- /dev/null +++ b/Documentation/devicetree/bindings/display/panel/samsung,sofef00.yaml @@ -0,0 +1,79 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/display/panel/samsung,sofef00.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Samsung SOFEF00 AMOLED DDIC + +description: The SOFEF00 is display driver IC with connected panel. + +maintainers: + - David Heidelberg + +allOf: + - $ref: panel-common.yaml# + +properties: + compatible: + items: + - enum: + # Samsung 6.01 inch, 1080x2160 pixels, 18:9 ratio + - samsung,sofef00-ams601nt22 + # Samsung 6.28 inch, 1080x2280 pixels, 19:9 ratio + - samsung,sofef00-ams628nw01 + - const: samsung,sofef00 + + reg: + maxItems: 1 + + poc-supply: + description: POC regulator + + vci-supply: + description: VCI regulator + + vddio-supply: + description: VDD regulator + +required: + - compatible + - reset-gpios + - poc-supply + - vci-supply + - vddio-supply + +unevaluatedProperties: false + +examples: + - | + #include + + dsi { + #address-cells =3D <1>; + #size-cells =3D <0>; + + panel@0 { + compatible =3D "samsung,sofef00-ams628nw01", "samsung,sofef00"; + reg =3D <0>; + + vddio-supply =3D <&vreg_l14a_1p88>; + vci-supply =3D <&s2dos05_buck1>; + poc-supply =3D <&s2dos05_ldo1>; + + te-gpios =3D <&tlmm 10 GPIO_ACTIVE_HIGH>; + reset-gpios =3D <&tlmm 6 GPIO_ACTIVE_HIGH>; + + pinctrl-0 =3D <&panel_active>; + pinctrl-1 =3D <&panel_suspend>; + pinctrl-names =3D "default", "sleep"; + + port { + panel_in: endpoint { + remote-endpoint =3D <&mdss_dsi0_out>; + }; + }; + }; + }; + +... diff --git a/MAINTAINERS b/MAINTAINERS index 59b145dde215f..7b158ea607b4a 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -8140,6 +8140,13 @@ S: Maintained F: Documentation/devicetree/bindings/display/panel/samsung,s6e3ha8.yaml F: drivers/gpu/drm/panel/panel-samsung-s6e3ha8.c =20 +DRM DRIVER FOR SAMSUNG SOFEF00 DDIC +M: David Heidelberg +M: Casey Connolly +S: Maintained +F: Documentation/devicetree/bindings/display/panel/samsung,sofef00.yaml +F: drivers/gpu/drm/panel/panel-samsung-sofef00.c + DRM DRIVER FOR SHARP MEMORY LCD M: Alex Lanzano S: Maintained --=20 2.51.0 From nobody Tue Dec 2 02:19:48 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AE7D5274B27; Wed, 19 Nov 2025 14:21:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763562101; cv=none; b=eibUGwtWMNfNvdqaXFYA8pfcPR8BwPLVJhRMPuKGK+uvrnGczelJB5LNM/Z+/b9U1P5oLiTNK3YVsuLlIcuD7h6ahVfisF0jlcJf1WgKMt0Uj15xsemSNzodzHTAtCWvgfabXuIxKXsx5iPFaWT9O7nH/+KNehW6rVBhcb2ROw8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763562101; c=relaxed/simple; bh=RCFsjUix1XQ76jxISlR0S+cS2leVOmgzdskYmMSCvic=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ZiT7PHOqo8pbDZAB95VPn9Ila3E0n4EeXVL7HAGhs9n4HCE4kwY7jZy2UTCIpM1bBqU2xJLdCyky5v4b0C7YX44tSxC4ylPyQNq6KdRy3ZjLbk74qe5y2myJSqBRlkBK8TNRltESaSDRUpND7wUa2TKz+psJFwFHJA2kfVUVmjQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=e7QffQcE; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="e7QffQcE" Received: by smtp.kernel.org (Postfix) with ESMTPS id AC0E8C2BC86; Wed, 19 Nov 2025 14:21:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1763562101; bh=RCFsjUix1XQ76jxISlR0S+cS2leVOmgzdskYmMSCvic=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=e7QffQcE+JMWYhRcrEiwmchzpWC90OmKhd1Pjtx30iSp0b3LApmnXSmNLkvDgVvk5 vpx4mNmHSpNWamUfYBcgz/JwHyLQ3EsgFJnz3TJZvPb3FscsWY+z9vj0pza2cUjOIs cUZb9MLLIe5XNXpwjxNzM6kmihfExmDEpiWBA3rjhj2sCF+OUR0pXqV45AKGawkR11 wNxPYeQpf82MNPsL6Ws3EN0QhB2hnjAzVAeGIUKBIQM227HmhFGRL/MXw8pyze2a4b WJUiUMPjEhG/mgv65PYpXmcMY4F93axlV0zRoVQt3nbbWY51szsxzkGJ7TSdH/PUQV UX2hyyvu4n0AQ== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80094CF34B6; Wed, 19 Nov 2025 14:21:40 +0000 (UTC) From: David Heidelberg via B4 Relay Date: Wed, 19 Nov 2025 15:21:27 +0100 Subject: [PATCH v3 02/12] arm64: qcom: sdm845-enchilada: Specify panel name within the compatible Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251119-sofef00-rebuild-v3-2-6cd55471e84e@ixit.cz> References: <20251119-sofef00-rebuild-v3-0-6cd55471e84e@ixit.cz> In-Reply-To: <20251119-sofef00-rebuild-v3-0-6cd55471e84e@ixit.cz> To: Neil Armstrong , Jessica Zhang , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Thierry Reding , Sam Ravnborg , Bjorn Andersson , Konrad Dybcio , Casey Connolly , Jessica Zhang Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, phone-devel@vger.kernel.org, David Heidelberg X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=978; i=david@ixit.cz; h=from:subject:message-id; bh=XdEJMzUlqHmVFvRkb119Ya6neFS+DHA5Y7GV7B5h8w4=; b=owEBbQKS/ZANAwAIAWACP8TTSSByAcsmYgBpHdJyMXGU0SPjy59reJxJwEVMCdZvJTNqQQBvk 4S+oxbaH9uJAjMEAAEIAB0WIQTXegnP7twrvVOnBHRgAj/E00kgcgUCaR3ScgAKCRBgAj/E00kg coTLD/4lKOUmsMD5Xn+6M9R8x4QoYPWL8BjkBYsn36pMAtB+fo0UXsLK07Cg+Cq7PcruRm9WbkH XRk7G6jYdM15pdTJnJnlPnwhfoIZ/S0WnaN3ADeh6zfX4+IbXPVT0wj17u7wxkaZrSkAAnllVS0 QVxn0v3/v+YmXqA4lK/dhtlfi5wo1VLLnJnCsKJ3Q5fRdJldEoCO5EZQx2QDuHtNk0ar6N6niFN Mfkoi3Y0CjecGmejwCDyu1gWTzcGJiMacRGGaT6OhA551GYnk76QbmW6uUPOggu+dwrLprXu4kw Xw3eiXNvdTSHtUwME5GL1Y9eUtTsAxhj1WBsqAo68tR7Ecz1OjK7RzVpGtUG8LKx/xIGwbXEwnF r0aoNGtHJ41Gv2mybmDsXnVL/P0MQgkKnk8Mam9jeCPi0+VXcuYZXUQkhdXeJqrY1I2bL2MY6As SRlx2zb244gXIw43Bmv3BgCq2ByJlholZg5aseRxHRxUJEygdMnh8wDmjghUzOQ693MEjZpBc4G dgXo94bX0bXBp+rOIIp5au7Rk6tm1D27inCiO15gN5Zu/A3mE91UsYMOVqohIbrI1E56kvu5oAA z7yQCVF2V401x3EXWgCmHyprBj3U3VuzVvd6/IXJVpA27JlDe2OyspLLR9Of4pNYkFbddY/BKJE 8RQ+I6ntAE0v/LQ== X-Developer-Key: i=david@ixit.cz; a=openpgp; fpr=D77A09CFEEDC2BBD53A7047460023FC4D3492072 X-Endpoint-Received: by B4 Relay for david@ixit.cz/default with auth_id=355 X-Original-From: David Heidelberg Reply-To: david@ixit.cz From: David Heidelberg sofef00 is name of the DDIC, it doesn't contain name of the panel used. The DDIC is also paired with other panels, so make clear which panel is used. New device-tree will work with old driver as expected, due to secondary compatible. cosmetic: sort the node. Signed-off-by: David Heidelberg Reviewed-by: Neil Armstrong --- arch/arm64/boot/dts/qcom/sdm845-oneplus-enchilada.dts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sdm845-oneplus-enchilada.dts b/arch/a= rm64/boot/dts/qcom/sdm845-oneplus-enchilada.dts index a259eb9d45ae0..8aead6dc25e00 100644 --- a/arch/arm64/boot/dts/qcom/sdm845-oneplus-enchilada.dts +++ b/arch/arm64/boot/dts/qcom/sdm845-oneplus-enchilada.dts @@ -31,9 +31,9 @@ battery: battery { }; =20 &display_panel { - status =3D "okay"; + compatible =3D "samsung,sofef00-ams628nw01", "samsung,sofef00"; =20 - compatible =3D "samsung,sofef00"; + status =3D "okay"; }; =20 &bq27441_fg { --=20 2.51.0 From nobody Tue Dec 2 02:19:48 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B134F2749F2; Wed, 19 Nov 2025 14:21:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763562102; cv=none; b=jfuz77mDkhQUpOZizKOI8QIm/0DiW6rftY0RorO+u1FfolnDIYBV8NCV1w05AmEy/wQjBuPEy7Rf1waM6VD4fWKdLAOGuh/H6hhWyMiUyjzPHNZLnFQjw1qeOdXjmW+rTn6iTBpuiOLYjNV4BK4cYBmHIQWiKeAEoTs8/voKzYk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763562102; c=relaxed/simple; bh=GVLBLculdCKnhAiFJ2ef4yLpdlinMTlal7/JRCLg0f0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=LCc2G1FMYJCA33qm23SL5EQeFKWxVEQsQS4G4oi0gRU58eOXy204eg7pLv+RWBpB8NRjmp6di8noxfbXnOQU2qum3hvGb5zxqEwXMXeSBJ6/1a4Fpkn5xiRZ4MPzinaOVxhJdH78mK7br2oKniwu06W+LPwYFHUhr4WSsS34KpI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=kKJbEeMo; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="kKJbEeMo" Received: by smtp.kernel.org (Postfix) with ESMTPS id 3AF85C4CEF5; Wed, 19 Nov 2025 14:21:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1763562101; bh=GVLBLculdCKnhAiFJ2ef4yLpdlinMTlal7/JRCLg0f0=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=kKJbEeMok/XcZxgmDFRbs2KqBhT12CurirfxbcECcHTn/P0cWY28W/KBDguEnX2fz uFbm+aso9nyKB6a1vqa7MG8rRAeBDYAqsglJlUoHg5tfVvcN3F/CJmIVbaHoxun0St /Lep877OREMm8Ow+8k9jku+/HBDW4yfNIRjXY0DhySIKQzodzRbDTCYCVgP9o5FoJK ZjreqV47VukHubQMRuD+c6anv9H4exLbFVTWI6RERwDjeJ2eYm4+/ZLwZLdvHx0JPs G3N2YMhsfdH6I3JP4sR2bByFv+/AbCGlb2xC63pA1Rvn0tXiTmFoWFRDvhALvfv3H/ Aly6CW5sn1NyA== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91BF6CF34B5; Wed, 19 Nov 2025 14:21:40 +0000 (UTC) From: David Heidelberg via B4 Relay Date: Wed, 19 Nov 2025 15:21:28 +0100 Subject: [PATCH v3 03/12] drm/panel: sofef00: Clean up panel description after s6e3fc2x01 removal Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251119-sofef00-rebuild-v3-3-6cd55471e84e@ixit.cz> References: <20251119-sofef00-rebuild-v3-0-6cd55471e84e@ixit.cz> In-Reply-To: <20251119-sofef00-rebuild-v3-0-6cd55471e84e@ixit.cz> To: Neil Armstrong , Jessica Zhang , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Thierry Reding , Sam Ravnborg , Bjorn Andersson , Konrad Dybcio , Casey Connolly , Jessica Zhang Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, phone-devel@vger.kernel.org, David Heidelberg X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=2398; i=david@ixit.cz; h=from:subject:message-id; bh=bCUObjPE6sND+pIgM/wutRNG+EBQRl07BHTzasDZhH4=; b=owEBbQKS/ZANAwAIAWACP8TTSSByAcsmYgBpHdJyyre2YbJbCWgb/t9aDqoEt/8YTa5GBezgU ro/WdhEc/WJAjMEAAEIAB0WIQTXegnP7twrvVOnBHRgAj/E00kgcgUCaR3ScgAKCRBgAj/E00kg cmUoD/9wPQvQ4yOEbaf4EQ6WJDuk2dQEMVA0cR9bovkgOZseBZDUlFFIUNjxEU+WNi+fVKjJ4ME de1tnYUW3io2mifxkIn4U7OTL2R5H+yXGazhF8LyaJSVEc4Wm3N0bU1gieo5i36J7W/r2aeJYLU qt49I+/ykCLZzIidWT1HUvH5UxJYAdrl3O7I6SjcoWSj0zBKeabXD4TNamhe5YAxpfVMndS4Trg a5L9guVqcpQN8ltSAZuyh70D+/f52m4dreg7MRsdP6146buSrlIeI0BX5DE83IS4/+LBoAljkKE Q5XAaUJWMj2ERh4CiM9Wn0tKxEe6FlECaE87wX17JynDlNQ7P/oQqdjFc8cW0mN63O+GnKXUV+b 1qDw3Pckn6v16Anb/rDSPSto7q9AkcmEThcdayq6NtNxv4I5SRqr5FnGz3adkqFo2bJ1J4jxW9f 0JlYcAlE2b6l29l/ufy0b+SlKZLmSrgv+b++rZb/z1hs3YxaBhXFRq24Vnxm3B7tMaHVGD+32Up VqojuhTr1S1Nm+aloXbX8FB6hH6UblmbAQUU1z5tlvbVekUnXDPIhQ/aRX/5UfzlXBRFwrAca2I PbS9Qhg3MSLIyywHFABzqrHQpCCAK3F3ipE2KEUc/WFumIU6q3OHc+ogMzc42zaL6578vj6gqxH /mZX7RxbKUAJv8Q== X-Developer-Key: i=david@ixit.cz; a=openpgp; fpr=D77A09CFEEDC2BBD53A7047460023FC4D3492072 X-Endpoint-Received: by B4 Relay for david@ixit.cz/default with auth_id=355 X-Original-From: David Heidelberg Reply-To: david@ixit.cz From: David Heidelberg Remove leftover from s6e3fc2x01 support drop and clarify supported panel. The Samsung SOFEF00 DDIC is used in multiple phones, so describe it properly and generalize. Fixes: e1eb7293ab41 ("drm/panel: samsung-sofef00: Drop s6e3fc2x01 support") Signed-off-by: David Heidelberg Reviewed-by: Neil Armstrong --- drivers/gpu/drm/panel/Kconfig | 7 ++++--- drivers/gpu/drm/panel/panel-samsung-sofef00.c | 4 ++-- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig index ad54537d914a4..4a0b4da0fea46 100644 --- a/drivers/gpu/drm/panel/Kconfig +++ b/drivers/gpu/drm/panel/Kconfig @@ -881,16 +881,17 @@ config DRM_PANEL_SAMSUNG_S6E8AA5X01_AMS561RA01 DSI protocol with 4 lanes. =20 config DRM_PANEL_SAMSUNG_SOFEF00 - tristate "Samsung sofef00/s6e3fc2x01 OnePlus 6/6T DSI cmd mode panels" + tristate "Samsung SOFEF00 DSI panel controller" depends on OF depends on DRM_MIPI_DSI depends on BACKLIGHT_CLASS_DEVICE select VIDEOMODE_HELPERS help Say Y or M here if you want to enable support for the Samsung AMOLED - command mode panels found in the OnePlus 6/6T smartphones. + panel SOFEF00 DDIC and connected panel. + Currently supported panels: =20 - The panels are 2280x1080@60Hz and 2340x1080@60Hz respectively + Samsung AMS628NW01 (found in OnePlus 6, 1080x2280@60Hz) =20 config DRM_PANEL_SEIKO_43WVF1G tristate "Seiko 43WVF1G panel" diff --git a/drivers/gpu/drm/panel/panel-samsung-sofef00.c b/drivers/gpu/dr= m/panel/panel-samsung-sofef00.c index 064258217d50a..c88574ea66e1c 100644 --- a/drivers/gpu/drm/panel/panel-samsung-sofef00.c +++ b/drivers/gpu/drm/panel/panel-samsung-sofef00.c @@ -252,7 +252,7 @@ static struct mipi_dsi_driver sofef00_panel_driver =3D { .probe =3D sofef00_panel_probe, .remove =3D sofef00_panel_remove, .driver =3D { - .name =3D "panel-oneplus6", + .name =3D "panel-samsung-sofef00", .of_match_table =3D sofef00_panel_of_match, }, }; @@ -260,5 +260,5 @@ static struct mipi_dsi_driver sofef00_panel_driver =3D { module_mipi_dsi_driver(sofef00_panel_driver); =20 MODULE_AUTHOR("Casey Connolly "); -MODULE_DESCRIPTION("DRM driver for Samsung AMOLED DSI panels found in OneP= lus 6/6T phones"); +MODULE_DESCRIPTION("DRM driver for Samsung SOFEF00 DDIC"); MODULE_LICENSE("GPL v2"); --=20 2.51.0 From nobody Tue Dec 2 02:19:48 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C06CD274B5F; Wed, 19 Nov 2025 14:21:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763562101; cv=none; b=YqJr0MODHmTi/ALzcloRy3oNfTlxcHdSI3o1fjiBtwnchDrPhF/WruTVq3We3DzIezjFsO7NW3dF3z0hM5PpjARieiTk9Bsf3KREIkbZ9WvxLPCNyRHK5N5/wBkQdeNd7rw+WqfYVRgSlv0HMzpvXSsFNOjy+wzxCCQlFfXQxhs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763562101; c=relaxed/simple; bh=W8AFvq4nPlynSNPii3uZ58RgvdVO7lLIvRxVluTsVZY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=r+oA3cphiBXyswMJoXPvLBIPL8GRVKDz8SWR6jPQO4Hsb/88x8ciQsGqD+ipZmjR/b4138q71gqVY0+3kOh96ILutNMdoS1qaUq3eUWkd9VyS0IVolNQSRckgVOqV+bvHdwpggDnj7fdi0rYQWWnP9p4IskX6cW4dRP0O+10egE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=eNEBUWlj; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="eNEBUWlj" Received: by smtp.kernel.org (Postfix) with ESMTPS id D2189C4AF0B; Wed, 19 Nov 2025 14:21:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1763562101; bh=W8AFvq4nPlynSNPii3uZ58RgvdVO7lLIvRxVluTsVZY=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=eNEBUWlj7cKXQAmn6BRhEPvy9hmojwCXj/jDVUxxAyYNLHsyRsQsakGIYxKnwyc8M ntRWMC+vUQqmA95q1IFeFwq+EIMvs2wCDTssWJP72Mv9lW/GL1Dq3b0uVnjS1M6fVD EbmpE5+YJ3bPxgBGksDwKN6skDEsNQPPa+LjscRjDx+z2PeY2mIFDZrtFq6ftMCHGp 8eMwBt5RQ4DKsGS7PuqCR16NYo9voijVAO8Ube4BDShWNvxxYYGGMNWLechEs50qI2 h14OFKgT+YdxKcYvLbcINmHF3+0j1kQWVJ1XHqNPqmpcraV3SmsRmr5g62bq0Iktwy ZE/cyKthJtEkA== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1D85CF34BA; Wed, 19 Nov 2025 14:21:40 +0000 (UTC) From: David Heidelberg via B4 Relay Date: Wed, 19 Nov 2025 15:21:29 +0100 Subject: [PATCH v3 04/12] drm/panel: sofef00: Handle all regulators Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251119-sofef00-rebuild-v3-4-6cd55471e84e@ixit.cz> References: <20251119-sofef00-rebuild-v3-0-6cd55471e84e@ixit.cz> In-Reply-To: <20251119-sofef00-rebuild-v3-0-6cd55471e84e@ixit.cz> To: Neil Armstrong , Jessica Zhang , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Thierry Reding , Sam Ravnborg , Bjorn Andersson , Konrad Dybcio , Casey Connolly , Jessica Zhang Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, phone-devel@vger.kernel.org, David Heidelberg X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=2667; i=david@ixit.cz; h=from:subject:message-id; bh=mwo54CYnw7MO3Xycn85wubPyOShFMxI9iCM2JhaFHcY=; b=owEBbQKS/ZANAwAIAWACP8TTSSByAcsmYgBpHdJyykQQjBPv/D6e3UV4rkYUeeOAS1ybhrMlJ 37M8wKsmZaJAjMEAAEIAB0WIQTXegnP7twrvVOnBHRgAj/E00kgcgUCaR3ScgAKCRBgAj/E00kg cp3SD/4kVvwnsf4KPZEdZ0I+Tq4vfMsljqvPEQkD7U6imv9aaIBzs1GLrLqdDvaEHhaNfkNUEv5 pW9Y8V1Z05iFkRt74VKl8sD5vSL8hK6/WQLzElQAjBYc7PFihMmbS8JntFa8XVVqlfS71JNo6p5 kn4+3OOKOcy+HIVqHEq62tFVZ9v2x9eZxCmZNsGTZq9IZ5EiC6zJ8gwjFkTFCaacq6B0e1J1My6 y63S1QliRT5eHgdyZd5TwPI/oLzWIJCtCjPpfcdc/LQoWh9fOI05gT05XzvyjVgRuuMEPk9NJj1 wRq0qo64isIAp4GCRV2q8mgIFqTWMKu8a2tjjwA+r1LAYhnnX6UD5xvHNZTelA2IbSTH7Uadycg Q8BRg78HK17Ss1JIE7HYDtDVhjnb5SkpfCE4qjgI3WW3erLazI5y7wszT0PrC0qBgiTEy44lmFW 7gGG8Xr+t6vZD8V14EotaUZg+9/cFs25Ht4v3PJXaV3GdwzJutPDZqiYLaeVEDRQO2iGSbDyOBI xLjmnW23s/8phTns4YhhA2uGtUmAu1ZtOhHlevTx08jBmNXgbWW0kiC/GBQBo4B/gPv1agaBM4x yglKS5Wldkms26ex6fjW0JkoVAoWyPM1340zxemoAx6eZyFnvfgZQ+3qaYIdkaShtbEmvfGZOyO SwmQSo9Ozwj+PZQ== X-Developer-Key: i=david@ixit.cz; a=openpgp; fpr=D77A09CFEEDC2BBD53A7047460023FC4D3492072 X-Endpoint-Received: by B4 Relay for david@ixit.cz/default with auth_id=355 X-Original-From: David Heidelberg Reply-To: david@ixit.cz From: David Heidelberg Recently we documented, there is more than vddio regulator, adapt the driver to work with VCI and POC regulator. Signed-off-by: David Heidelberg Reviewed-by: Neil Armstrong --- drivers/gpu/drm/panel/panel-samsung-sofef00.c | 28 ++++++++++++++++-------= ---- 1 file changed, 17 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-samsung-sofef00.c b/drivers/gpu/dr= m/panel/panel-samsung-sofef00.c index c88574ea66e1c..3097040e6bfa0 100644 --- a/drivers/gpu/drm/panel/panel-samsung-sofef00.c +++ b/drivers/gpu/drm/panel/panel-samsung-sofef00.c @@ -20,10 +20,16 @@ struct sofef00_panel { struct drm_panel panel; struct mipi_dsi_device *dsi; - struct regulator *supply; + struct regulator_bulk_data *supplies; struct gpio_desc *reset_gpio; }; =20 +static const struct regulator_bulk_data sofef00_supplies[] =3D { + { .supply =3D "vddio" }, + { .supply =3D "vci" }, + { .supply =3D "poc" }, +}; + static inline struct sofef00_panel *to_sofef00_panel(struct drm_panel *panel) { @@ -86,20 +92,18 @@ static int sofef00_panel_off(struct sofef00_panel *ctx) static int sofef00_panel_prepare(struct drm_panel *panel) { struct sofef00_panel *ctx =3D to_sofef00_panel(panel); - struct device *dev =3D &ctx->dsi->dev; int ret; =20 - ret =3D regulator_enable(ctx->supply); - if (ret < 0) { - dev_err(dev, "Failed to enable regulator: %d\n", ret); + ret =3D regulator_bulk_enable(ARRAY_SIZE(sofef00_supplies), ctx->supplies= ); + if (ret < 0) return ret; - } =20 sofef00_panel_reset(ctx); =20 ret =3D sofef00_panel_on(ctx); if (ret < 0) { gpiod_set_value_cansleep(ctx->reset_gpio, 1); + regulator_bulk_disable(ARRAY_SIZE(sofef00_supplies), ctx->supplies); return ret; } =20 @@ -111,7 +115,7 @@ static int sofef00_panel_unprepare(struct drm_panel *pa= nel) struct sofef00_panel *ctx =3D to_sofef00_panel(panel); =20 sofef00_panel_off(ctx); - regulator_disable(ctx->supply); + regulator_bulk_disable(ARRAY_SIZE(sofef00_supplies), ctx->supplies); =20 return 0; } @@ -197,10 +201,12 @@ static int sofef00_panel_probe(struct mipi_dsi_device= *dsi) if (IS_ERR(ctx)) return PTR_ERR(ctx); =20 - ctx->supply =3D devm_regulator_get(dev, "vddio"); - if (IS_ERR(ctx->supply)) - return dev_err_probe(dev, PTR_ERR(ctx->supply), - "Failed to get vddio regulator\n"); + ret =3D devm_regulator_bulk_get_const(dev, + ARRAY_SIZE(sofef00_supplies), + sofef00_supplies, + &ctx->supplies); + if (ret) + return dev_err_probe(dev, ret, "Failed to get regulators\n"); =20 ctx->reset_gpio =3D devm_gpiod_get(dev, "reset", GPIOD_OUT_HIGH); if (IS_ERR(ctx->reset_gpio)) --=20 2.51.0 From nobody Tue Dec 2 02:19:48 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CC91D365A09; Wed, 19 Nov 2025 14:21:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763562103; cv=none; b=LzMU9gH5cbfIuWn88mGX83prz/y1rS0agbguYovc7DWA3yZ0918Dn+vNm91mtutSMRDMS7rAGUAcwJn2/PxfqtFgdsbeooxou25xLymHQIQ75WzEvoc5KJagoYZhapd2kTDWUmsfOT4dD3NGcnuHwEA+VLlHlmFsS2kpMeNMWwE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763562103; c=relaxed/simple; bh=h8mvhLF2NQpOEhwrwGAXO5y7raG5Pj5KKGwO1xu0Ls4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=r/Rezl+jd70sR/tsXpcep5ir3TMcyDnGbUDNoxDGF+4O4k6i7jlTxmsBw8y3zh04TOsPACUaDmbVyvLosEvw1/GdsQjYNOZIt3X35j5g7hOx1HU+hb8ZW+WEJB7zgany8N7Ayiq4Y7x149QjsmBo36oeLKNvzZgl9s2INQjbi0g= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Rk8r7nfn; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Rk8r7nfn" Received: by smtp.kernel.org (Postfix) with ESMTPS id 8A3F3C4AF12; Wed, 19 Nov 2025 14:21:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1763562102; bh=h8mvhLF2NQpOEhwrwGAXO5y7raG5Pj5KKGwO1xu0Ls4=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=Rk8r7nfnExBOLXlHcSwwW1GzD01CFs01Izo9ju/Fs4ZNjpFX0IR60CJVQloLHPSKc q5B5cwoeZwVloaZbQfM0p5bPXjJJ0dDtlN/WEDWQQCd8EbckzPmfVj49LCULpcm6GQ ZKgfLfmXS/nCYYStW6pm/1ExBe7f1ba2RyS3I07hFkkz8Hq5dg+U858UPe6GL+rtaY sU+lS+S5WX9W0mgyF/G7GTI8rG/f3k0xCvG4gGyJg2gUDCTvRPvUfdBI3zkLj4TovE H5F0zAOa3ydUTKKrCIG8/oKMSGM+SgthmePgvHlj5b88o2xaAxBJAirSXTjdcSCdHG ihu+D+Onj1Jvg== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id B15A7CF34B7; Wed, 19 Nov 2025 14:21:40 +0000 (UTC) From: David Heidelberg via B4 Relay Date: Wed, 19 Nov 2025 15:21:30 +0100 Subject: [PATCH v3 05/12] drm/panel: sofef00: Split sending commands to the enable/disable functions Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251119-sofef00-rebuild-v3-5-6cd55471e84e@ixit.cz> References: <20251119-sofef00-rebuild-v3-0-6cd55471e84e@ixit.cz> In-Reply-To: <20251119-sofef00-rebuild-v3-0-6cd55471e84e@ixit.cz> To: Neil Armstrong , Jessica Zhang , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Thierry Reding , Sam Ravnborg , Bjorn Andersson , Konrad Dybcio , Casey Connolly , Jessica Zhang Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, phone-devel@vger.kernel.org, David Heidelberg X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=2045; i=david@ixit.cz; h=from:subject:message-id; bh=xfG4W9ai59WdRLt2V9HKjqKsc6sEspLbINOP0a9yxjE=; b=owEBbQKS/ZANAwAIAWACP8TTSSByAcsmYgBpHdJySBNowOWWHwzh/85WA2arsosXKiFd8KulS VtAKVAfMgCJAjMEAAEIAB0WIQTXegnP7twrvVOnBHRgAj/E00kgcgUCaR3ScgAKCRBgAj/E00kg cqp7D/9Rk0id/wx8xVwQZpjz1cpc0Esto+GMDs9DNsKLPzrV9jrQ9EygsxglDlkICE9PcVtwxin 4DveLXfymwQPd9sQ7kykNkZEfly2vPUy5/WprZ8YWbFsIEKdmXIkCOZTDV0R2qTNFk2KUMJ2h14 fbZkgpr3LNdHZkviqf4UC22D+Sgbqurbv0ogY9nwnxrMVW30LFpYF3XKA7GpMZr/pIQpNrnAa3H I9OP6mkzevkxvMT1cIMtMObrUxl+SwGp2lo7nQPIyl2mPVNrFTpb35uiKC8y5X3QtZ2VRjxMGDe xCgHIlY9cLTloOIbdVoV7jogP11hk49FM93c51O9i9HGCzOPBtK7Gd9vL5gEgxeN9DZgPyGVoLH MCABSvftIMB/6bhkbNOp1EGmx76f5k1HH6qMebfEASEZKua5+ke2Lac/ysGTe+eNFunn9Oh7hSK cgWs/hHeDbw82akmcM/5c1yzzfoH+Qy6lulkXCR9R87Gh2P+9Uy+ep+ASwzj3ftH5XFG1JMgePu /t1tJ9gFrVE0hcA3O3ukwL6WkAgoGceo+8tMyegAmra+xsGdczs6GEpKWH79Uu2oLzW/pesWy43 sfS+wCR5wocOjMXOicX4IhLflaVLvisE+EX1s+IS+QMWGGvFCozyV24NAxwL+hLZnEU9yuHotRF tVa16LfkZLb4Z3A== X-Developer-Key: i=david@ixit.cz; a=openpgp; fpr=D77A09CFEEDC2BBD53A7047460023FC4D3492072 X-Endpoint-Received: by B4 Relay for david@ixit.cz/default with auth_id=355 X-Original-From: David Heidelberg Reply-To: david@ixit.cz From: David Heidelberg It's not possible to send DSI panel commands in the .unprepare. Move it to .disable and do similar for prepare, where we move the display on to the .enable. Signed-off-by: David Heidelberg Reviewed-by: Neil Armstrong --- drivers/gpu/drm/panel/panel-samsung-sofef00.c | 20 +++++++++++++++++++- 1 file changed, 19 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/panel/panel-samsung-sofef00.c b/drivers/gpu/dr= m/panel/panel-samsung-sofef00.c index 3097040e6bfa0..a3651f0060bde 100644 --- a/drivers/gpu/drm/panel/panel-samsung-sofef00.c +++ b/drivers/gpu/drm/panel/panel-samsung-sofef00.c @@ -68,6 +68,14 @@ static int sofef00_panel_on(struct sofef00_panel *ctx) mipi_dsi_dcs_write_seq_multi(&dsi_ctx, MIPI_DCS_WRITE_CONTROL_DISPLAY, 0x= 20); mipi_dsi_dcs_write_seq_multi(&dsi_ctx, MIPI_DCS_WRITE_POWER_SAVE, 0x00); =20 + return dsi_ctx.accum_err; +} + +static int sofef00_enable(struct drm_panel *panel) +{ + struct sofef00_panel *ctx =3D to_sofef00_panel(panel); + struct mipi_dsi_multi_context dsi_ctx =3D { .dsi =3D ctx->dsi }; + mipi_dsi_dcs_set_display_on_multi(&dsi_ctx); =20 return dsi_ctx.accum_err; @@ -110,11 +118,19 @@ static int sofef00_panel_prepare(struct drm_panel *pa= nel) return 0; } =20 -static int sofef00_panel_unprepare(struct drm_panel *panel) +static int sofef00_disable(struct drm_panel *panel) { struct sofef00_panel *ctx =3D to_sofef00_panel(panel); =20 sofef00_panel_off(ctx); + + return 0; +} + +static int sofef00_panel_unprepare(struct drm_panel *panel) +{ + struct sofef00_panel *ctx =3D to_sofef00_panel(panel); + regulator_bulk_disable(ARRAY_SIZE(sofef00_supplies), ctx->supplies); =20 return 0; @@ -154,6 +170,8 @@ static int sofef00_panel_get_modes(struct drm_panel *pa= nel, struct drm_connector =20 static const struct drm_panel_funcs sofef00_panel_panel_funcs =3D { .prepare =3D sofef00_panel_prepare, + .enable =3D sofef00_enable, + .disable =3D sofef00_disable, .unprepare =3D sofef00_panel_unprepare, .get_modes =3D sofef00_panel_get_modes, }; --=20 2.51.0 From nobody Tue Dec 2 02:19:48 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6726C363C79; Wed, 19 Nov 2025 14:21:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763562103; cv=none; b=eMgUWirgYOPmLKoVi+g7GFrSvZcrFW6Ow8qzA+hK8c0sAFQhqZfxkvNONy4VtYeXTXF5wBItNtzh2fz5GbMCyo6MlBpyvKcsUqdY2n87ys0ejq4r6AaCxdmmp5qZpgH5dC6l1tiBjctoCb4WZITf4SwVgmRb1xj8ij+lYvdfGrE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763562103; c=relaxed/simple; bh=38ck5RCR0LO2rWCNSIq2uzpHXbhEGR1CpmwmHrfKicM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=qTZe9crcVkdlDfwHpH7Ik1nq9kRQPkD4G5NvXCCdOz2LiQuTRktsajLZf7awVe7H/0BPYnsILufogub4q8M5QlEHiZTvbMcxg5vWNC++N48aFuUy6fnOtrhrURcBjHVa/VvihLp7hf2HtcmHQkbO0DykvXempFxAn9UKRQSsNkY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=UqvW3Nsw; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="UqvW3Nsw" Received: by smtp.kernel.org (Postfix) with ESMTPS id 79824C2BCB7; Wed, 19 Nov 2025 14:21:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1763562101; bh=38ck5RCR0LO2rWCNSIq2uzpHXbhEGR1CpmwmHrfKicM=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=UqvW3NswLhglaOKqLDCEsvEBHRPzWQAkAE7ZykQXdxFAXMztzgHyJvOjkpuCFt7B/ FkXR5CdJ8cmtFJsjAY10MDktLGUlDYBTBiqUfb696Tyyvtx327m/wGLH5qFUAvI9mG Bbdvy1UqkxX+BCQJBhDQjgxlWzjt0QH1Sf3dmG1578u4wzC/Zrv68tWNxPBkJPCxlC ufwvhpYhjKgBdHM05OsCvEyYtLkJZlM3iOS9Wrc6MDBXlr9lwzx3klcCen9iEeYgiK hR1IT7sduz3+VaNs/4eCFWXOhf6vLAYx4gkYg0BIHiD8M+TI7h5lV9MQIhMBST7MoZ Ag7K+omHPpaRQ== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF900CF34BD; Wed, 19 Nov 2025 14:21:40 +0000 (UTC) From: David Heidelberg via B4 Relay Date: Wed, 19 Nov 2025 15:21:31 +0100 Subject: [PATCH v3 06/12] drm/panel: sofef00: Introduce page macro Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251119-sofef00-rebuild-v3-6-6cd55471e84e@ixit.cz> References: <20251119-sofef00-rebuild-v3-0-6cd55471e84e@ixit.cz> In-Reply-To: <20251119-sofef00-rebuild-v3-0-6cd55471e84e@ixit.cz> To: Neil Armstrong , Jessica Zhang , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Thierry Reding , Sam Ravnborg , Bjorn Andersson , Konrad Dybcio , Casey Connolly , Jessica Zhang Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, phone-devel@vger.kernel.org, David Heidelberg X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=2024; i=david@ixit.cz; h=from:subject:message-id; bh=KFWwy/+TPv3o+Pr2om1zoaTzQ1nmZjY1fcOyZY+O5S8=; b=owEBbQKS/ZANAwAIAWACP8TTSSByAcsmYgBpHdJyK/hdCZdPZFToA5nTpcR1hiHEfTPn0MaQ3 ciLexMismGJAjMEAAEIAB0WIQTXegnP7twrvVOnBHRgAj/E00kgcgUCaR3ScgAKCRBgAj/E00kg ciRdEACTym6WmNnWVr4BPWPPzLj/0/6noYmFZiRlw2pz0OY3RH5blui4w/LPmwPEXLv3L9U1Qhc QNnQiycijTlbfMrcdivJxjd5U6Jgfa3LidhpmTa1mUUrAmfiPTNFYN7VBQjRFXYg6cHE5Yjn7ph mFWj7p8E0ox2ihq+umAvgO3tDg+Dyj89+IspXinSEoT04F/SjJ8YWZ9Y9WfjrQ064tlJcgGqIbS VF6lh1Ogb63u2RGuuhQCmErrq6OTmZBXEqRnsIqVtTkKOx8rLxTgbzRi2QVksusHcsfT3p1by4S M6VuLoljtb807fKrb3fHDwuj3KD4mdbnsz3/MV2RP6ScehScNIx0wpsfrfF7DsGa6gO6fJRIv+N stCxpl5+LtgwaBI+lajA+lsXRC4NWzhZEZJRlVvBXK854Bx3wLGMaFW6ZorljHyDim2hmj1RsyI cJzqcgs5mtFeck3IIAqQycCE86ZlvX7BCukhumZsavsAoAJhgm7i4GHHwQ6e3SJpLsvw/GwZ3V8 4CkLA+8tN2cFqejajnRPxefq9uo/qFMUCMW5FSZYWfHsWoXMCrwR8PO9leUl/hcRWktiMJ8JDWe Z25zr8J1xo/Zdm2B9cIPHculPSDJE/FU+cjoCFHL9gTsmDUCZwgL+byi1i7T6qOxN0YQ1ZNY4Cc pMIhJBgrMKV215Q== X-Developer-Key: i=david@ixit.cz; a=openpgp; fpr=D77A09CFEEDC2BBD53A7047460023FC4D3492072 X-Endpoint-Received: by B4 Relay for david@ixit.cz/default with auth_id=355 X-Original-From: David Heidelberg Reply-To: david@ixit.cz From: David Heidelberg Introducing the macro make the code a bit clearer. Looking at other Samsung drivers, I assume it's lvl2, thou due to not available documentation it's only educated guess. Signed-off-by: David Heidelberg Reviewed-by: Neil Armstrong --- drivers/gpu/drm/panel/panel-samsung-sofef00.c | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-samsung-sofef00.c b/drivers/gpu/dr= m/panel/panel-samsung-sofef00.c index a3651f0060bde..97122ec8872a1 100644 --- a/drivers/gpu/drm/panel/panel-samsung-sofef00.c +++ b/drivers/gpu/drm/panel/panel-samsung-sofef00.c @@ -36,6 +36,11 @@ struct sofef00_panel *to_sofef00_panel(struct drm_panel = *panel) return container_of(panel, struct sofef00_panel, panel); } =20 +#define sofef00_test_key_on_lvl2(ctx) \ + mipi_dsi_dcs_write_seq_multi(ctx, 0xf0, 0x5a, 0x5a) +#define sofef00_test_key_off_lvl2(ctx) \ + mipi_dsi_dcs_write_seq_multi(ctx, 0xf0, 0xa5, 0xa5) + static void sofef00_panel_reset(struct sofef00_panel *ctx) { gpiod_set_value_cansleep(ctx->reset_gpio, 0); @@ -56,15 +61,15 @@ static int sofef00_panel_on(struct sofef00_panel *ctx) mipi_dsi_dcs_exit_sleep_mode_multi(&dsi_ctx); mipi_dsi_usleep_range(&dsi_ctx, 10000, 11000); =20 - mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xf0, 0x5a, 0x5a); - + sofef00_test_key_on_lvl2(&dsi_ctx); mipi_dsi_dcs_set_tear_on_multi(&dsi_ctx, MIPI_DSI_DCS_TEAR_MODE_VBLANK); + sofef00_test_key_off_lvl2(&dsi_ctx); =20 - mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xf0, 0xa5, 0xa5); - mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xf0, 0x5a, 0x5a); + sofef00_test_key_on_lvl2(&dsi_ctx); mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xb0, 0x07); mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xb6, 0x12); - mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xf0, 0xa5, 0xa5); + sofef00_test_key_off_lvl2(&dsi_ctx); + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, MIPI_DCS_WRITE_CONTROL_DISPLAY, 0x= 20); mipi_dsi_dcs_write_seq_multi(&dsi_ctx, MIPI_DCS_WRITE_POWER_SAVE, 0x00); =20 --=20 2.51.0 From nobody Tue Dec 2 02:19:48 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 04FB035B15E; Wed, 19 Nov 2025 14:21:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763562103; cv=none; b=tYDusG16Vkt8DUlC3vWFEl0qRFJpRMedO0lPktjfi7OWAo2Voy8RNcLA/v33hyZHBM++EqD7ft4qQrWJrzdO5ylVRYq5k8QnZtovpNoY0yM9k7uXb+BWoRxlVaVr534hATobz1W/8U3m4eTvsmLy5e9gcqNYYVYhfGTKCm+XIs8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763562103; c=relaxed/simple; bh=Bx37k0L1IbjcU9mqRIdk43KBpDeg4zmaNkPRXHOD9Wg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Ol9v8vJazSFZeTdSwOVk7RTrCwrRdZ6uBEDh9UZov3diI3cJXb9JcQa+8zlSNHCt50afLhLGaA+sd8GF8MfvflNNmCh0oCVl/b/+1N+9hnZAvDrk182l04omxNqwDi5uAngg2/lj/PYyhrP3muI6Ek2NO8HpyZU8ytH17UflUto= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=gImJQhbV; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="gImJQhbV" Received: by smtp.kernel.org (Postfix) with ESMTPS id 67966C2BCB9; Wed, 19 Nov 2025 14:21:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1763562101; bh=Bx37k0L1IbjcU9mqRIdk43KBpDeg4zmaNkPRXHOD9Wg=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=gImJQhbVk+TL5NlI9VBSbvx6wnUy+Q0IuULfGuhzcRezPPwm7cupl4ZIbjSeO6dSU 9ZIc/BLrLELLtMhYXzcqGC1YiAauf6+mkr40BGWHePQA58bPb+LjdlwzbdJHd/87Yl e9K3Q6DlasiI5aA6GkqeFmJEMUPfjwAQc60zoytPPMXEUct7iqk5ZoSlqSBaBJfzIb n56xCx1eOleviqn6csBqwpVVPvVCYWVwqPVkwy6Bd+IsQG9LkiMGG0nwsjn+9xjnlN Z85pF7NcfyXVBWRi4/58BHeZCqSYXUbUW26nZOwPntVLbGfHQ8CS3CN4g0lgWewt52 pyU1cRhUk5Wbw== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3ACACF34C0; Wed, 19 Nov 2025 14:21:40 +0000 (UTC) From: David Heidelberg via B4 Relay Date: Wed, 19 Nov 2025 15:21:32 +0100 Subject: [PATCH v3 07/12] drm/panel: sofef00: Add prepare_prev_first flag to drm_panel Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251119-sofef00-rebuild-v3-7-6cd55471e84e@ixit.cz> References: <20251119-sofef00-rebuild-v3-0-6cd55471e84e@ixit.cz> In-Reply-To: <20251119-sofef00-rebuild-v3-0-6cd55471e84e@ixit.cz> To: Neil Armstrong , Jessica Zhang , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Thierry Reding , Sam Ravnborg , Bjorn Andersson , Konrad Dybcio , Casey Connolly , Jessica Zhang Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, phone-devel@vger.kernel.org, David Heidelberg X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=918; i=david@ixit.cz; h=from:subject:message-id; bh=4SM9hcft9HxR/OcdKpSF5Ee1W0Jyu8dLyBp//WZCcbk=; b=owEBbQKS/ZANAwAIAWACP8TTSSByAcsmYgBpHdJyMun4lNvyG7GRsKltaopxelO91qC/BKWF7 XZjYMU/nECJAjMEAAEIAB0WIQTXegnP7twrvVOnBHRgAj/E00kgcgUCaR3ScgAKCRBgAj/E00kg cnlrD/9gFTsd14LOIw9T+8inMsalraoeodlg5dehVIpOfJa1FxQQ8jTMjIMBV2ilXPwbW3giTFz +kZ9i3Qf9RcI38mjiG5K1pzKVSZG1bNrP6CLkN6zvFpsky/XYzMByjvKAYF+W0ermUwW+nxB5NE 9rT5oLfHlBw2HLNsR4ki26mMAMHnvrh4gmJM1hLO5FUcgMP6AK/zUEN2zj4Q1WjwDpxvdOE6M1V lj54oU+FALXbSBCs24ehZqIEz9YtJP0Zxp7r/bRuq7dBVtBrUS8H/IB1t6NpR99dtD925WTmtJ+ 4IAt5DC3VPIcrVsdu2eZxWLKBhGQbQRPBKb/NICmYdc+NCUwONZj6vNVh2JmJzgBYLfgbTyJV9P v17W51KnfF/TXG13P6ZF3e+xaABqCJfe1O5FIw53B/VxvwvTk715YPlhV2vaNwBI+xV6BeUSfYu PiFcmGFm4iVSQTGO1eCwPPUEyu3d5A/36jk3mGo0yekd5rgSDC01y44kjdE7mQ/+RnWuGDuDEMC RUn9H2+yS1TlSbKGiYpYXIGyjAXGffYjiY1DrNtp84Szh0YzzW2MYekwsvby+ch9Boc1tET83x1 gW/H626SKJhnK0OGApSyu6f9yPLs1P9lvt1A4Gq6L/aVX+AqAnMN18uZgevj6dPVf1LUEohDDEr pFMWAlgPT69xTjQ== X-Developer-Key: i=david@ixit.cz; a=openpgp; fpr=D77A09CFEEDC2BBD53A7047460023FC4D3492072 X-Endpoint-Received: by B4 Relay for david@ixit.cz/default with auth_id=355 X-Original-From: David Heidelberg Reply-To: david@ixit.cz From: Casey Connolly This corrects the host initialisation sequence so that we can send DSI/DCS commands in prepare(). Signed-off-by: Casey Connolly Signed-off-by: David Heidelberg Reviewed-by: Neil Armstrong --- drivers/gpu/drm/panel/panel-samsung-sofef00.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/panel/panel-samsung-sofef00.c b/drivers/gpu/dr= m/panel/panel-samsung-sofef00.c index 97122ec8872a1..0d3ae0689a19b 100644 --- a/drivers/gpu/drm/panel/panel-samsung-sofef00.c +++ b/drivers/gpu/drm/panel/panel-samsung-sofef00.c @@ -242,6 +242,8 @@ static int sofef00_panel_probe(struct mipi_dsi_device *= dsi) dsi->lanes =3D 4; dsi->format =3D MIPI_DSI_FMT_RGB888; =20 + ctx->panel.prepare_prev_first =3D true; + ctx->panel.backlight =3D sofef00_create_backlight(dsi); if (IS_ERR(ctx->panel.backlight)) return dev_err_probe(dev, PTR_ERR(ctx->panel.backlight), --=20 2.51.0 From nobody Tue Dec 2 02:19:48 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B656A364EB2; Wed, 19 Nov 2025 14:21:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763562103; cv=none; b=kXhFy20fDF2T7mRVMh42LpYhmO58I/ZjkIH7206WXPAfyzpfAMBLJxkZSL5FWL+dbEafJW8g5a2pO+zU8HIie3Hu+stLjlL8tqj/HbmCvV7D9kzx0yL2tcy9ONYLFZOWT4PnN3wj4q3DRuOxP26/mi50QPLcUigtM1XPw/WcvSk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763562103; c=relaxed/simple; bh=f6GfQjehkKWl/LGMGUh9JdpxtbOydSanZ93bKCsBU8c=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=HCq84pyiYXZLLwKIS73s1cQ4A7/yC3j67fvkz5P5qotTv8lDDd/LGmvgqe5HrSiiQgWgA00u3lDMSI+hpOpPwuuUewSFEA+VLiQf9YeT3dc+4051OGYvfAn+16AwZi2Q+I8woFyV2kZv+7b66ts5deSQV0CEbXSIN/RCU4q6PWE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=YuQl08ku; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="YuQl08ku" Received: by smtp.kernel.org (Postfix) with ESMTPS id 9075CC2BCF6; Wed, 19 Nov 2025 14:21:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1763562102; bh=f6GfQjehkKWl/LGMGUh9JdpxtbOydSanZ93bKCsBU8c=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=YuQl08kulOyYsMF3NQ6YA5F/j5dVhv859AW0GgR6we5w5T8/LENuyU+EcTVklqHrL zQxHgcX69o/EC3QXH/wl9Cva9/o88FUL1KYEwixxmXNvpavu59b0Cq05pQNVUE7IVn rRVN/zFsrFyvOUuJh8uJCMV79qb+9ab1lo6h/FFl3xnW6nDeezqGWWS3lheBTziEB4 CP86e2epTgq2smAJ5NMbEBnJYQaGMZt7puF7p3d9bNTtzoJZAmGwGoMS2rvkMT67Y7 moTzu/lbZSmQ8KD8UeY1xuSkukU4pXvVXBikAcPfna5mmR0hC7hXzQyW21RWTPbQeu Wm+PfYxl9Oa9w== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5C7BCF34C1; Wed, 19 Nov 2025 14:21:40 +0000 (UTC) From: David Heidelberg via B4 Relay Date: Wed, 19 Nov 2025 15:21:33 +0100 Subject: [PATCH v3 08/12] drm/panel: sofef00: Initialise at 50% brightness Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251119-sofef00-rebuild-v3-8-6cd55471e84e@ixit.cz> References: <20251119-sofef00-rebuild-v3-0-6cd55471e84e@ixit.cz> In-Reply-To: <20251119-sofef00-rebuild-v3-0-6cd55471e84e@ixit.cz> To: Neil Armstrong , Jessica Zhang , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Thierry Reding , Sam Ravnborg , Bjorn Andersson , Konrad Dybcio , Casey Connolly , Jessica Zhang Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, phone-devel@vger.kernel.org, David Heidelberg X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=858; i=david@ixit.cz; h=from:subject:message-id; bh=vjrHJH4EY6FJhDpprnzSkcksIGyeb+RoENa3mCki5mI=; b=owEBbQKS/ZANAwAIAWACP8TTSSByAcsmYgBpHdJycAIUQJO6bD234ZrR/h/NB7vOojf2vplRl PAgiirYhvKJAjMEAAEIAB0WIQTXegnP7twrvVOnBHRgAj/E00kgcgUCaR3ScgAKCRBgAj/E00kg cnckD/46GCXgYsqFV8C49iM5nrbVA72lwvKuHMFuWOtab2kV8MZ5DHFUybrXDC0fAy67KE2/MzI pK3XNS9LUEDEgj+AeI/TLPUHJVRd6PfGgch84M8laVBvt8s0/QALq42FbLors7adT4bk0QnNbPA /NDC8btbDp14EQmuRQQNcEf8lhdOct/1WeDIDc2YeUkROifgGeEhcJ9Tiuq7oX5sM8eQoSHPY3q KM2wq/y/Ar7WeLsMPktbcHbf/5tke6vjpGmXUshezjAO/Dgh17Tw8+v/ExUCG9PGn6XMaAJhjs/ A2Nd4NPslOPcKFNlNw/vBR/OIUzfWlazu1RaOnnBjtXYdjmQ1zTQOjZSlBch5m0xZTOQF59fK+z XyMJ8kUsg8e8qg46FnATAinMbeDOOMz5uyrFdKWQTOGpd9FqZSezdtl5DeZ/Zeu4s7az9q89hNP cuW125TtHQrFjuY/aHbj/nuOLdHyg91RLD7m97PLAMFqHCZGnfgduXE6HH6rD8VWIvx+HyObhgZ qhnR3f/pqRodAD7kbmpyIWutCP9m9GgDrTPkEBoJPEo0oB/IftaMnf2Mn6Ct4KAKbMWdkVSsQaR r7q5MUb5gW7y/F1ueOSELI7TuMINOK311TI96eV9FYtVa8xeTkOjL0blraduAvzGPGyOQeuOUae FTcNzym0O8kMbuQ== X-Developer-Key: i=david@ixit.cz; a=openpgp; fpr=D77A09CFEEDC2BBD53A7047460023FC4D3492072 X-Endpoint-Received: by B4 Relay for david@ixit.cz/default with auth_id=355 X-Original-From: David Heidelberg Reply-To: david@ixit.cz From: Casey Connolly Initialising at max brightness is not necessary. Half brightness is much more comfortable. Signed-off-by: Casey Connolly Signed-off-by: David Heidelberg Reviewed-by: Neil Armstrong --- drivers/gpu/drm/panel/panel-samsung-sofef00.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/panel/panel-samsung-sofef00.c b/drivers/gpu/dr= m/panel/panel-samsung-sofef00.c index 0d3ae0689a19b..d1e5340d7e337 100644 --- a/drivers/gpu/drm/panel/panel-samsung-sofef00.c +++ b/drivers/gpu/drm/panel/panel-samsung-sofef00.c @@ -204,7 +204,7 @@ sofef00_create_backlight(struct mipi_dsi_device *dsi) struct device *dev =3D &dsi->dev; const struct backlight_properties props =3D { .type =3D BACKLIGHT_PLATFORM, - .brightness =3D 1023, + .brightness =3D 512, .max_brightness =3D 1023, }; =20 --=20 2.51.0 From nobody Tue Dec 2 02:19:48 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9178B364058; Wed, 19 Nov 2025 14:21:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763562103; cv=none; b=jTFqeRbSqPErZJmTSqvMyImG/1srf1v1+mMOILLnkLdAK6FyiY26fVhe9Yo49Pkbb9HyF4CP9MD7Kv9nOhMuvu77Uq9QGWRF5UEvpD1dKXAEZBpsbeC2hBnD/FuPYN2pd4Fel9sjRQ2RC9fLCtN47KU7sDC0GUDwJznuPXNlcvg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763562103; c=relaxed/simple; bh=+vN9i6hkDYH07rTuHLCdDYvotY6UX7pwnmerlFATOVU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=nLd7T4Vgf0EtcPBcgom3Prwlvow6nepmQL4P9fYafdWjDtwdF8Z1cN4UgjkB4Uadclc5968Bt+9DUulAE2h8lHCp9Liw6dw3X7EXyF9sPsUNmECmCes3aDHU76aIF7hyos+RY5hDd/wTuQTv6TX+JF+WOv35BRjN8x77F/LXLmo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=C+eBw700; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="C+eBw700" Received: by smtp.kernel.org (Postfix) with ESMTPS id E9AE5C4AF1B; Wed, 19 Nov 2025 14:21:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1763562102; bh=+vN9i6hkDYH07rTuHLCdDYvotY6UX7pwnmerlFATOVU=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=C+eBw700b/FQDhMbSSxKN9HY7ZTdYjXlxuDHtgbGxAlIIQTDZ0USj0SkF5DlOop/b F0P2CFaLCiLanFiUO1W74etVZG580FF7bUb65UJLSTDS/lCEy+HZjV6FGzEJOmRbg6 f8ANdaj0h/ayw00eSvslgrH/abNyrEJZ6EpRgWjyInM8grrLZ0U0L+95vxFyFk//SA xEmUsU8ofs/0RmaGMjqsvFm5oH+2DavbsXswjyqLRgCTBkocjVd83QW1n3zcZukTGd XSQohGkbNXs/UWh8wOinTs1TjTuBgo7FMiYS9Nw1l5gyubfPpiqlDRbr8Ed7MCGK7S L9GccgzTFTppA== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02824CF34C3; Wed, 19 Nov 2025 14:21:41 +0000 (UTC) From: David Heidelberg via B4 Relay Date: Wed, 19 Nov 2025 15:21:34 +0100 Subject: [PATCH v3 09/12] drm/panel: sofef00: Introduce compatible which includes the panel name Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251119-sofef00-rebuild-v3-9-6cd55471e84e@ixit.cz> References: <20251119-sofef00-rebuild-v3-0-6cd55471e84e@ixit.cz> In-Reply-To: <20251119-sofef00-rebuild-v3-0-6cd55471e84e@ixit.cz> To: Neil Armstrong , Jessica Zhang , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Thierry Reding , Sam Ravnborg , Bjorn Andersson , Konrad Dybcio , Casey Connolly , Jessica Zhang Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, phone-devel@vger.kernel.org, David Heidelberg X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1754; i=david@ixit.cz; h=from:subject:message-id; bh=P0KIvmsjpu/GWMlI4xRr9BftnVEaKH9jmqWZeoZaE+o=; b=owEBbQKS/ZANAwAIAWACP8TTSSByAcsmYgBpHdJyDdkZ1dEYA7cSJjMj0hi5SZJtdieQo1zH8 OUiuQgGWg6JAjMEAAEIAB0WIQTXegnP7twrvVOnBHRgAj/E00kgcgUCaR3ScgAKCRBgAj/E00kg clXaEADNKwuBmStKGfsh+h+OK2PQP+yZXa0WJEoWH6Qg5AwLC9bwI4Mr7iO3wYgwWEASDGL9p+A vm691Nzgl8UpQCIgIJbCNZkeQB3RmL9Bt0NjP6t3OtiBrKTE5wjb9BwOlIcXpGwAA1KVW+rgCvL qS422FqiRWXjnJ2U+TxU5h85AGIAYHtFA0JIS5ULcpNHkSyE18O70XWNN2GjgMedH5wZm2BpADy mGgTjVt5w7PqMue0iSNBGnsNP/36kKWyqDHOjfhO9+6p37yWx0LKPTnHsFGCpuL+cSH3R8+uaSL 4RKaHMA+rMZA8jE7YczNs7GB7MkRd4fUI+QREwkcd0IHda/Uh5jlMVR0kQVUrLJb6HtQgZoi1cx 05CjK7wjOasbwZK6V0buaDxyUneAuLuATF/kbPRdJzxn+jgziTFOtodZpT7jtQFXkwjD0RVu6Dt 5Cdhpv0/8e52O1mIzqdNqisDq68WimwLFnKbaDC9/Z7njqnhKRMaqss11a0E5uV82axkdwBlvGO lGzpWh1+ZruDm/I7weozNtttI6XLBtcEBJYPqVjpvnk7DpY4yOWmOsaaKRF4wFXki5sutCztU/H PqIozS8EfHqneoZFH6OBG6dFtPTSs9oICmY+2JG/zBl7Cspheu+LfItnelfEGxTGDxU7dPmcfiD Hzx9olMhPW40gAA== X-Developer-Key: i=david@ixit.cz; a=openpgp; fpr=D77A09CFEEDC2BBD53A7047460023FC4D3492072 X-Endpoint-Received: by B4 Relay for david@ixit.cz/default with auth_id=355 X-Original-From: David Heidelberg Reply-To: david@ixit.cz From: David Heidelberg Compatible should correspond to the panel used and the driver currently supports only AMS628NW01 panel. Adapt the internal driver structures to reflect the name. Original, not very descriptive, compatible is kept to ensure compatibility with older device-trees. Signed-off-by: David Heidelberg Reviewed-by: Neil Armstrong --- drivers/gpu/drm/panel/panel-samsung-sofef00.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-samsung-sofef00.c b/drivers/gpu/dr= m/panel/panel-samsung-sofef00.c index d1e5340d7e337..c2cb85997e4f3 100644 --- a/drivers/gpu/drm/panel/panel-samsung-sofef00.c +++ b/drivers/gpu/drm/panel/panel-samsung-sofef00.c @@ -141,7 +141,7 @@ static int sofef00_panel_unprepare(struct drm_panel *pa= nel) return 0; } =20 -static const struct drm_display_mode enchilada_panel_mode =3D { +static const struct drm_display_mode ams628nw01_panel_mode =3D { .clock =3D (1080 + 112 + 16 + 36) * (2280 + 36 + 8 + 12) * 60 / 1000, .hdisplay =3D 1080, .hsync_start =3D 1080 + 112, @@ -159,7 +159,7 @@ static int sofef00_panel_get_modes(struct drm_panel *pa= nel, struct drm_connector { struct drm_display_mode *mode; =20 - mode =3D drm_mode_duplicate(connector->dev, &enchilada_panel_mode); + mode =3D drm_mode_duplicate(connector->dev, &ams628nw01_panel_mode); if (!mode) return -ENOMEM; =20 @@ -274,7 +274,8 @@ static void sofef00_panel_remove(struct mipi_dsi_device= *dsi) } =20 static const struct of_device_id sofef00_panel_of_match[] =3D { - { .compatible =3D "samsung,sofef00" }, + { .compatible =3D "samsung,sofef00" }, /* legacy */ + { .compatible =3D "samsung,sofef00-ams628nw01" }, { /* sentinel */ } }; MODULE_DEVICE_TABLE(of, sofef00_panel_of_match); --=20 2.51.0 From nobody Tue Dec 2 02:19:48 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 69682364021; Wed, 19 Nov 2025 14:21:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763562103; cv=none; b=ftv3wZtvi/hpRjzMe5Gu8pbj15w4DuWpD5yE2XXrEX4GWb37Yfmx9ewG1KpTYQg931j6L9ONN3ljRDP6tUIJ1ypWQo0OyNGsRvGO6ur5lNAwwgt/l/8HqQwji5ey2OYVWEoOxEXlMKnrldMmcs1CkavtmE2vFHLSXw9N5TaBhz0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763562103; c=relaxed/simple; bh=tORkO5c9uzVr8jR8W8QLeUA++T/SajydWlGSRg+0MBI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=L51fECsC7AAbV4q5H/3smDV3dMFC2j815UktPV91+3zgFIOGXakK/CalYoA/SHvlKEg3puDHO6rwqqYWR2oylz5dOwpptuwBVx8DJ/L2rFaua7UU4E3l+BJpoUwX2oNBOwHEg2/yI3Z1xIFaj5AQn4eHYWvmXhJfXufCyIdPovQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=pEME1tZl; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="pEME1tZl" Received: by smtp.kernel.org (Postfix) with ESMTPS id D6F5DC2BCB0; Wed, 19 Nov 2025 14:21:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1763562102; bh=tORkO5c9uzVr8jR8W8QLeUA++T/SajydWlGSRg+0MBI=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=pEME1tZlTSCaqb9Gbux/lpu52/8SA9ZdMJNImqBDETlRk3QYgZa1lVPp3P+GOAmAP M4Z4xt54ncsrBp12dnWTFUb8e2M9WFd2kITTzmqyH05gqCXwifcsQmpOiGdLKQwKYL XW1A6BkltWnL8jbgN//i4PBNOxirC3JQviX7cobxlnbDFuZA3jq02nnpdivVILnk61 Zu8OTmoa86xX3/92KpqjxpgMwmqjgpvk3o1Yfm82FFpsbnufPUwsjuwz/GjdibY+Q8 gYkI+0Z6cyELL9jM0OQaOt62L3fU3Pj/PxZTXTdmSb7EZLS5WCR0hp6rBBInXRPZqd T/bi1sTkG116A== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14227CF34C4; Wed, 19 Nov 2025 14:21:41 +0000 (UTC) From: David Heidelberg via B4 Relay Date: Wed, 19 Nov 2025 15:21:35 +0100 Subject: [PATCH v3 10/12] drm/panel: sofef00: Simplify get_modes Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251119-sofef00-rebuild-v3-10-6cd55471e84e@ixit.cz> References: <20251119-sofef00-rebuild-v3-0-6cd55471e84e@ixit.cz> In-Reply-To: <20251119-sofef00-rebuild-v3-0-6cd55471e84e@ixit.cz> To: Neil Armstrong , Jessica Zhang , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Thierry Reding , Sam Ravnborg , Bjorn Andersson , Konrad Dybcio , Casey Connolly , Jessica Zhang Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, phone-devel@vger.kernel.org, David Heidelberg X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1958; i=david@ixit.cz; h=from:subject:message-id; bh=t7Ham4KLGv7LXKlYHbza6Ihf3qcaU4uzq3IWHkZmI8s=; b=owEBbQKS/ZANAwAIAWACP8TTSSByAcsmYgBpHdJytotmCbEIhNbMBr/c4FHlWH9+HbBvj1Q/A t3ypVKh/RWJAjMEAAEIAB0WIQTXegnP7twrvVOnBHRgAj/E00kgcgUCaR3ScgAKCRBgAj/E00kg ck4YD/9sd/ZVgWPo/UW05hluFXuojHouqw0eWVPDrW4KTdGswP273ZwMrd71jKdx7DBczSfVs4U T+6Gp/2wCCrSefms0774lAEWdSyEtf+akci2vPIahew5JUygOl4cMwLN5n8iuORArZXzxLTZLiU O6fD4vl5Ac84Vcdb/ieDUXGrsAtjmlQGMw1BJXAexK88/+20hhJYMOh6aMzb7MIqWgDSfFhw5nf 0kug5QYgVfbfrAVBTcQqjYO/0D+M6X6xLVRqbV4+E4yK83jWmnkcEMyKhcT0NOwboNgNLkgFPu9 Lkob/pyTAxMwzvI5E2ZwfDqP8Sd/nJyfDp0U21N1XJ3hfa/if6+ArNRGfSG1boUQmXzmN3Yl82Q l3qIgRG0Otogy+29y4PLYPhfUhls7NlCC6jrRRRHkgx1MJArx0WJFYdJJwVmIDHmkOsasl8Jg5R uv5XmAH82jNFiafxaU3dStm8EnG+UfyMaX8o5wC0lmqwty+1FA9hABCU5DbIivXB/aDgX01RIRA uzvXXh5aq8qSmItEAIZB58Ett+YGG4dGkzbyF0jMvAL402Wlc6yi01xeJ/9outhimgugHOrmQpy kxPP0kKTVh+iapqHqDrtbrzOT1GGVHrvl1hES+lPO2cQGfr2dkPqI1aese2eyr/rYWhN9QMLfuI P7qCVKKjlcjHKsw== X-Developer-Key: i=david@ixit.cz; a=openpgp; fpr=D77A09CFEEDC2BBD53A7047460023FC4D3492072 X-Endpoint-Received: by B4 Relay for david@ixit.cz/default with auth_id=355 X-Original-From: David Heidelberg Reply-To: david@ixit.cz From: David Heidelberg Levearage drm_connector_helper_get_modes_fixed helper function. Signed-off-by: David Heidelberg Reviewed-by: Neil Armstrong --- drivers/gpu/drm/panel/panel-samsung-sofef00.c | 21 +++++++-------------- 1 file changed, 7 insertions(+), 14 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-samsung-sofef00.c b/drivers/gpu/dr= m/panel/panel-samsung-sofef00.c index c2cb85997e4f3..0e857abda5964 100644 --- a/drivers/gpu/drm/panel/panel-samsung-sofef00.c +++ b/drivers/gpu/drm/panel/panel-samsung-sofef00.c @@ -16,6 +16,7 @@ #include #include #include +#include =20 struct sofef00_panel { struct drm_panel panel; @@ -143,34 +144,26 @@ static int sofef00_panel_unprepare(struct drm_panel *= panel) =20 static const struct drm_display_mode ams628nw01_panel_mode =3D { .clock =3D (1080 + 112 + 16 + 36) * (2280 + 36 + 8 + 12) * 60 / 1000, + .hdisplay =3D 1080, .hsync_start =3D 1080 + 112, .hsync_end =3D 1080 + 112 + 16, .htotal =3D 1080 + 112 + 16 + 36, + .vdisplay =3D 2280, .vsync_start =3D 2280 + 36, .vsync_end =3D 2280 + 36 + 8, .vtotal =3D 2280 + 36 + 8 + 12, + .width_mm =3D 68, .height_mm =3D 145, + + .type =3D DRM_MODE_TYPE_DRIVER | DRM_MODE_TYPE_PREFERRED, }; =20 static int sofef00_panel_get_modes(struct drm_panel *panel, struct drm_con= nector *connector) { - struct drm_display_mode *mode; - - mode =3D drm_mode_duplicate(connector->dev, &ams628nw01_panel_mode); - if (!mode) - return -ENOMEM; - - drm_mode_set_name(mode); - - mode->type =3D DRM_MODE_TYPE_DRIVER | DRM_MODE_TYPE_PREFERRED; - connector->display_info.width_mm =3D mode->width_mm; - connector->display_info.height_mm =3D mode->height_mm; - drm_mode_probed_add(connector, mode); - - return 1; + return drm_connector_helper_get_modes_fixed(connector, &ams628nw01_panel_= mode); } =20 static const struct drm_panel_funcs sofef00_panel_panel_funcs =3D { --=20 2.51.0 From nobody Tue Dec 2 02:19:48 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9BAAB368268; Wed, 19 Nov 2025 14:21:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763562104; cv=none; b=W7uZdYi6yer1pJcv0KTvpN5QGip6Rpj1V+yh+x1FnNXvFxry9hl4ypvPtz+rdMSk30Uv9lPrEqPwbEu7L9jA0HeA+CDv1YTwQ7AlqKZQPyU7mTF9f6f/ED3fO3Y3kEJOPvzzfao6hMKjRzkg5IM06jJK671ljvcQ3BF6vMV9mJU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763562104; c=relaxed/simple; bh=8P+oEugwPDNniFX9jpbpGjr3Q7WMxpS+rZBZ/vMYm2I=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=KFXUnqdPj7uEjDMnuolWO5E4MdUkfQkI5M2KeTa/Jk0qbJHEMsnaK5AEcMyGic+gVKBmCFMVcHuIkkD8NmxEtvmb/3hwoFUnusG/Feleq4IP7jcpGT0/mWGdR3elom+ouvQ1f3ap+nZg1qU+4C/vH1TXVeEY87g5/OxROtMT7J8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=fHsiJ8Ar; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="fHsiJ8Ar" Received: by smtp.kernel.org (Postfix) with ESMTPS id 6A7EEC4AF0E; Wed, 19 Nov 2025 14:21:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1763562102; bh=8P+oEugwPDNniFX9jpbpGjr3Q7WMxpS+rZBZ/vMYm2I=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=fHsiJ8ArhC+APU7eHM2VfMs237bdT28BgNO+bW1UCAkhUKRDPGq9oVOUMjsSVn6FF 0cnnB4NcJeJ/jRTTxXEic2OV5f1EwvTM9rtNEFJzlrorx+08KgTBLv0m+DchLqgIAb baonZrliofbwwt7FVK8QCVFB/xeCwLWtfaP/ZWwxTbhuu7waT1LL0VLM4WqJVuifz/ A8f0F6bzh+WH1/2Ipv1xc+4zfT8A7BikHbEJ2f4BaVrTgIyMU+FScdWS5Q7dYe5qLD BBaiyK+x7RguVURjd4zyNoaXbTSlahc0TrSlWq+6j13ulUVANfVmMZpWvdrjvcY0NC sIIciNICAStcA== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25061CF34C2; Wed, 19 Nov 2025 14:21:41 +0000 (UTC) From: David Heidelberg via B4 Relay Date: Wed, 19 Nov 2025 15:21:36 +0100 Subject: [PATCH v3 11/12] drm/panel: sofef00: Mark the LPM mode always-on Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251119-sofef00-rebuild-v3-11-6cd55471e84e@ixit.cz> References: <20251119-sofef00-rebuild-v3-0-6cd55471e84e@ixit.cz> In-Reply-To: <20251119-sofef00-rebuild-v3-0-6cd55471e84e@ixit.cz> To: Neil Armstrong , Jessica Zhang , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Thierry Reding , Sam Ravnborg , Bjorn Andersson , Konrad Dybcio , Casey Connolly , Jessica Zhang Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, phone-devel@vger.kernel.org, David Heidelberg X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1446; i=david@ixit.cz; h=from:subject:message-id; bh=oJUn+PKpj5llEIJZZEJFyisMkk6yg/4H6PZ4hxEEiTc=; b=owEBbQKS/ZANAwAIAWACP8TTSSByAcsmYgBpHdJyb9N0LOagPPMjYmh9CRKV+Ca80ELfGUFkO f8Zr+VLariJAjMEAAEIAB0WIQTXegnP7twrvVOnBHRgAj/E00kgcgUCaR3ScgAKCRBgAj/E00kg ckmID/4mnB+PJW1yJTLvCBaXnUg0TbiINpx+ISXuKICjRxNDgEpaScZBrH7TfCH65YAu7Mf9si+ ol7GzI35mHuJvpJbwSldjdUiAPpdHlb579BNxgqldXuCH/JGAaYx/BCIZ5xUV8n4nd9g26njhjE QMxOl1XrX//8m6SmXRbfX9+2gLCXkQxjeG9LHvpqKoqUqYnsM8lqyt2/z7J3hpT5SPWH2xif+N2 bE0vVzmgxS7+SJtD9fLoMzZVmnAlPfouT0R966vPxyY1VcPxilmxomEmgM1e0zW+PrvC+8ELRCn ZA7DT3IlIwJiPF5bPIPfnBwiL95FzkEsSaRXWLhINSftY6jHABgqCDarBxzfo438HXlTHksikUR plzdTUdipWBMQilZNIgfL94s7fTMkz7x3qi9O5Yk4qqLcFV4GJm0zuU6OKVRpWP/Do4K/0ZJ+75 aiYgsoEf78KWQESdlp0Bc51misvLmDBixNX+VjAqFyHdOWNN2D6k0OON10h2ClWDv6VZbtpwaX5 UFlG7PNMC3EJlmivrtwHga7C3WLs8IPO6m915IfSNd+XbKTu0T3zdFa+obAGi8KyIY8q9Sux1Ce uxtV+TWUoWYOqGHnebdTdYk1CdE/AnAZfbJrN52dAykqvEr+Zb8QZBYQ3P+tzaJpk5q7p0Y5H5X bhVnj4q3HQ+GQYw== X-Developer-Key: i=david@ixit.cz; a=openpgp; fpr=D77A09CFEEDC2BBD53A7047460023FC4D3492072 X-Endpoint-Received: by B4 Relay for david@ixit.cz/default with auth_id=355 X-Original-From: David Heidelberg Reply-To: david@ixit.cz From: David Heidelberg The panel operated in low-power mode, with exception of changing the brightness levels. Signed-off-by: David Heidelberg Reviewed-by: Neil Armstrong --- drivers/gpu/drm/panel/panel-samsung-sofef00.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-samsung-sofef00.c b/drivers/gpu/dr= m/panel/panel-samsung-sofef00.c index 0e857abda5964..db9c181695f1d 100644 --- a/drivers/gpu/drm/panel/panel-samsung-sofef00.c +++ b/drivers/gpu/drm/panel/panel-samsung-sofef00.c @@ -92,8 +92,6 @@ static int sofef00_panel_off(struct sofef00_panel *ctx) struct mipi_dsi_device *dsi =3D ctx->dsi; struct mipi_dsi_multi_context dsi_ctx =3D { .dsi =3D dsi }; =20 - dsi->mode_flags &=3D ~MIPI_DSI_MODE_LPM; - mipi_dsi_dcs_set_display_off_multi(&dsi_ctx); mipi_dsi_msleep(&dsi_ctx, 40); =20 @@ -180,10 +178,14 @@ static int sofef00_panel_bl_update_status(struct back= light_device *bl) int err; u16 brightness =3D (u16)backlight_get_brightness(bl); =20 + dsi->mode_flags &=3D ~MIPI_DSI_MODE_LPM; + err =3D mipi_dsi_dcs_set_display_brightness_large(dsi, brightness); if (err < 0) return err; =20 + dsi->mode_flags |=3D MIPI_DSI_MODE_LPM; + return 0; } =20 @@ -234,6 +236,7 @@ static int sofef00_panel_probe(struct mipi_dsi_device *= dsi) =20 dsi->lanes =3D 4; dsi->format =3D MIPI_DSI_FMT_RGB888; + dsi->mode_flags =3D MIPI_DSI_MODE_LPM; =20 ctx->panel.prepare_prev_first =3D true; =20 --=20 2.51.0 From nobody Tue Dec 2 02:19:48 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5766036920F; Wed, 19 Nov 2025 14:21:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763562105; cv=none; b=LitsqMqbbv71+CQQGnora3lrlyPBfAXkm1dUoii4+YA9CMj9u/kj7q4ramFHgHXcQq3txLblsma+2hE0ozfhskQgD0KP0WgNo0+s2awL1UAg16cbEUSBngo7G9s4fgS2qRxUPtPglua8etl0yvhCc3wvBED39pELh0+t7yJjbnw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763562105; c=relaxed/simple; bh=n+MbHJLuqiHoMoKEy+fupno4fvWaPOq/2PFTInr0Jy0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=bsMM8UYvtV1hYM0Glyo2o4Gb77DLxmqs/9j9dQwZNTMp8Y8jpKzf+3VBKMM/jTUzFvzKsMqPSmfYZLB4MkbWUMvmjPBm60WiIuUtT1cHxqPERXjlBwV/BtYql2pCwR3YomjMrjrtHeZSt5K7fuaDXOJ0vflzovio/i/D/WWBptE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=gwCLXods; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="gwCLXods" Received: by smtp.kernel.org (Postfix) with ESMTPS id 7E63EC2BCF5; Wed, 19 Nov 2025 14:21:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1763562103; bh=n+MbHJLuqiHoMoKEy+fupno4fvWaPOq/2PFTInr0Jy0=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=gwCLXodsyHfmtNp7eq1yhZUMKBugmKMftla83ywsBspR6VBMXRv1+AINc4tkzKFOn Jzl7KrbkXvhpitTDxyn0TQeZjbtZT2k4TSW3fVtWu7MOanxKPUkie9v/Iphf3TUHnx F1UghfDBWVN6zHAHiVf2tkPmJJuMhO7cIvB/teViPp+7s0dUV7jijqEipOWK0b+fNJ apYkmdnjmLUBuTE2qCRkrkrj8znBbL4B6BIvCaIb5G6rEpVove3pPN1nPuoZ798p/E xDQohpy+I1E5WFA+U3coDHuiNK5cGM12ZGNg053DsXHXWOwff+5qg9H2eC/SIjW4m0 BQcA0AZtIqKDw== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34101CF34C6; Wed, 19 Nov 2025 14:21:41 +0000 (UTC) From: David Heidelberg via B4 Relay Date: Wed, 19 Nov 2025 15:21:37 +0100 Subject: [PATCH v3 12/12] drm/panel: sofef00: Non-continuous mode and video burst are supported Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251119-sofef00-rebuild-v3-12-6cd55471e84e@ixit.cz> References: <20251119-sofef00-rebuild-v3-0-6cd55471e84e@ixit.cz> In-Reply-To: <20251119-sofef00-rebuild-v3-0-6cd55471e84e@ixit.cz> To: Neil Armstrong , Jessica Zhang , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Thierry Reding , Sam Ravnborg , Bjorn Andersson , Konrad Dybcio , Casey Connolly , Jessica Zhang Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, phone-devel@vger.kernel.org, David Heidelberg X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=802; i=david@ixit.cz; h=from:subject:message-id; bh=aJ/EglBDysKAXREtcXVh/z+Zh6bgaROjs/Vk7ZuGVZs=; b=owEBbQKS/ZANAwAIAWACP8TTSSByAcsmYgBpHdJyUgxKl+tyy/rxnd3ByE1L+Mfe9B9bTkPee MJVkwSsUUKJAjMEAAEIAB0WIQTXegnP7twrvVOnBHRgAj/E00kgcgUCaR3ScgAKCRBgAj/E00kg clwyD/9fUWuyonL8WuG+fTSZT85ZATR6y9QZJHZTGC0Dz0k587dKkHXiq1iJClfNO7LBAWWvjhZ UmiHaDU1mM0KZIxo97E301s/ocIacaSvbsGMLx69Z6VPOy00IGZmVVJmrX2708XBfaCWwMJNAXi rbynfoy99gZnH/Edzv8cad2wyicOZR2nJHmAvqYYxk61AEc/uBqfwlWLbcfnCqa/TxWWXI7wiYB f58nO9XAbsDDNdR/yd7bNW3d17eFwQ3ce0QAINiPzWZvOb/R5JRrHL8rkFtTxxDLcrB8Uk3akSJ xR1RB2Wl0eRplxbbwnIT+QyhxiiP5Qkk/75uw/SJ3GG2UswmLTqnFRr4jsdCGI6zxVLLmjguNuT yUijUGf7fx45zsdMaraxPq4UqL5tV+Wo+9DL4NEq0FRqxzHM0L8mmiKxkPUVSfSD+08A1Gv5gpb lxHifHWXE/Nl7/7oa6GfWZI/5WvoiwcSXsxlFf0BGeRL4HXbXogJpT0/01FpDoudFDPF4DOYa1d edFsioFRXFPvCdcW28TphGT60ghR2ObbSWN5yR87ctg2q0xPrysBbWVqg3jWj80bNRK76+NODUV 8TdyoNJML4CR8ZefQ75Ulh1JF6YESUuu7nP/W/BCViEywHAejH9nazcKGKgE8m7J6b5scRun+I3 TubsItsGLoGMzxw== X-Developer-Key: i=david@ixit.cz; a=openpgp; fpr=D77A09CFEEDC2BBD53A7047460023FC4D3492072 X-Endpoint-Received: by B4 Relay for david@ixit.cz/default with auth_id=355 X-Original-From: David Heidelberg Reply-To: david@ixit.cz From: David Heidelberg The panel supports both modes. Signed-off-by: David Heidelberg Reviewed-by: Neil Armstrong --- drivers/gpu/drm/panel/panel-samsung-sofef00.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/panel/panel-samsung-sofef00.c b/drivers/gpu/dr= m/panel/panel-samsung-sofef00.c index db9c181695f1d..e00a497a7c961 100644 --- a/drivers/gpu/drm/panel/panel-samsung-sofef00.c +++ b/drivers/gpu/drm/panel/panel-samsung-sofef00.c @@ -236,7 +236,8 @@ static int sofef00_panel_probe(struct mipi_dsi_device *= dsi) =20 dsi->lanes =3D 4; dsi->format =3D MIPI_DSI_FMT_RGB888; - dsi->mode_flags =3D MIPI_DSI_MODE_LPM; + dsi->mode_flags =3D MIPI_DSI_MODE_VIDEO_BURST | + MIPI_DSI_CLOCK_NON_CONTINUOUS | MIPI_DSI_MODE_LPM; =20 ctx->panel.prepare_prev_first =3D true; =20 --=20 2.51.0