[v1] ethernet: intel: fix freeing uninitialized pointers with __free

[PATCH RFT net-next 0/2] ethernet: intel: fix freeing uninitialized pointers with __free

Ally Heev posted 2 patches 2 months, 3 weeks ago

Diff against v1
Download series mbox

There is a newer version of this series

drivers/net/ethernet/intel/ice/ice_flow.c       |  6 ++++--
drivers/net/ethernet/intel/idpf/idpf_virtchnl.c | 28 +++++++++++++++++--------
2 files changed, 23 insertions(+), 11 deletions(-)

Expand all Fold all

[PATCH RFT net-next 0/2] ethernet: intel: fix freeing uninitialized pointers with __free

Posted by Ally Heev 2 months, 3 weeks ago

Uninitialized pointers with `__free` attribute can cause undefined
behavior as the memory assigned randomly to the pointer is freed
automatically when the pointer goes out of scope.

We could just fix it by initializing the pointer to NULL, but, as usage of
cleanup attributes is discouraged in net [1], trying to achieve cleanup
using goto

[1] https://docs.kernel.org/process/maintainer-netdev.html#using-device-managed-and-cleanup-h-constructs

Signed-off-by: Ally Heev <allyheev@gmail.com>
---
Ally Heev (2):
      ice: remove __free usage in ice_flow
      idpf: remove __free usage in idpf_virtchnl

 drivers/net/ethernet/intel/ice/ice_flow.c       |  6 ++++--
 drivers/net/ethernet/intel/idpf/idpf_virtchnl.c | 28 +++++++++++++++++--------
 2 files changed, 23 insertions(+), 11 deletions(-)
---
base-commit: 24598358a1b4ca1d596b8e7b34a7bc76f54e630f
change-id: 20251113-aheev-fix-free-uninitialized-ptrs-ethernet-intel-abc0cc9278d8

Best regards,
-- 
Ally Heev <allyheev@gmail.com>