From nobody Mon Feb 9 04:07:45 2026 Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0F9C430C60E for ; Sun, 16 Nov 2025 15:57:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763308627; cv=none; b=osfHoMpCMKq0O3EPoyxvnw/2A6nDfe1S6FwEHA531iRRnvOAmbEe63zSC+Yzjr6QdPYDPSybF/C8S8osdVF1JzLa8qhiUA0cP56Kho8ufUON1PtSyjGABF5sEBtrp5ZrrZ+7G/ymsryZffQoSYFkQ5xVagL/d1RgqQ9LKUfA2a8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763308627; c=relaxed/simple; bh=ufCbvxIRBVQHCzUSRhXUdWL2YVW5ycqhQc1EXb99qW8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=YRNCA+UI3EfuvMYrqRO/ATg+F6ZtFSXjxqBdcTRq34tXmM9sM70dJg3rEjPTZ8JOTDDZxgSbKwlUJLFVRQ3zneBqzwhKCNBUaSVp0fWXcpX/wZozOl1qg1R6ov6KON8eHQpX75RlOpAMRJCQuhFAByr5IJXpI/8+Vszro7SX8CA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=JQJ8AMob; arc=none smtp.client-ip=209.85.210.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JQJ8AMob" Received: by mail-pf1-f178.google.com with SMTP id d2e1a72fcca58-7b8eff36e3bso4477712b3a.2 for ; Sun, 16 Nov 2025 07:57:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763308624; x=1763913424; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=R+K9MAxb4ZBBa8U7x004Sm9bCoWfglzoRMNcWRH1ZAc=; b=JQJ8AMobBU7f8PU3aj6iVS2Cqyoi/eAX6SxA7yabzfcqg/6Y+zjHPN7RDEI6V+RCCH dyT0ync1+AiDIDrvFk+ymgfCbYxoNkwQ3LtmL4iQ9y78yuXqYcD3lztNevdt16QTuDdP D5BuvlU+1M4cgrZC2XO79fx3h9fFFljD3qtOwoViXpFFfQU5JCxbrlzOmfNHKBPbbaD6 JJHI2XBDDXruOpDYgjjYXAd6yHULeFca7jk9168joIepezt9SZyhW0pmzhwK2soSKbUk /PjyxBCU3GV+08U/qQNEG4fgZ/UNsW7v4BDIbM8VPFzbpi/JogcaRPLbh1YfdrzlCA1i itKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763308624; x=1763913424; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=R+K9MAxb4ZBBa8U7x004Sm9bCoWfglzoRMNcWRH1ZAc=; b=VrBcVmx7v01VrlWFsSdNXJps5cdDnYB+cjNYmxmpRikuzS6xbYP891FIS/MlZEB7OI 1o1UaCytuGbg2hIhBp11lGsD1G//I10bgp+mKyacdOdwpHdFrnEbFGc3gvI/vqmFQU8q AYWZc5Wh3JAeYJ/qMbkDRUi1pP23feSR8osxzWHDATAUvWz876K/UD9PjYuDtboDmvJl pOmgvsCUXcJ7wFaQPNLlMTEpLNJasngJd58sz8BZs0+f5nvQRG84Z+rkygT1BgkkAl3g 5h2Cj6miHwo9+mHZOpzQZ/jCEatOwr088/1g5OwVsTi0B7afpUF6RZ3V4vsjsG09iBma 67CQ== X-Forwarded-Encrypted: i=1; AJvYcCXyLc4V3toUDe3SqWVRjGzwXC3gZu3B/kDUxapYnu7Svlcij4fOmX/lToOGUBuPoxA/ZluDknSNJ1WJazI=@vger.kernel.org X-Gm-Message-State: AOJu0YyTD7eTvQwb2IzqhomBtYHF/np4JvfDvmWRHJb3oD9xGOjz5tPZ v+CX0O5PWD8S+8VzMozTlVK30TsBUOJ6Qe4Iw4zz98CZ6j9WhSvY9mKc X-Gm-Gg: ASbGncvm6gYqCJQKuCuBftAo3Tf/SUNm/iyPKdHo4GvknIIc9sWx77POKPg8LMajF5s V2SzQ9tmAkFRPdl2Qqj4MXYUAzPGiwR8BmReRawpeeyKcbWSKDwMW3ywCCRVakjUN+xaHc8raSi rg2Ngs8PTnMw07DHwVMNRiY4WL6DmeZCbBNaGE7BIpO61FT8s3Us2u/oIf0cdyvmFrqe4wGbjMo V12FCpgu2V0V7q2l97aAij/rtFf2d1HlZzON1Q0qu0eVLqgKsN33RtaDpXPWmj3BZV0hFo64p0T v9pwlkE+AMaOofGh9/wAE6vkW7/EsGtErC+EiPjJRqU4eSln44/NgNJFox8AOZOZ4XJAB/9tXKl wYhSFiwBeUoUA1euDiLkeDwzRe/vUVkTxe0g945SCamYGLFIw6R/umQldGVq7EexJa2B2l68OTP jpX2UDE9JnHW9rFbFxT9w= X-Google-Smtp-Source: AGHT+IEBONigJXUH6CJN+6b8wVtJBo3FEOVEJ//SL5EdSu5yo0atK7Q9DdGnua5zoxWDyWpCtDj7FQ== X-Received: by 2002:a05:6a00:4fcf:b0:7b9:d7c2:fdf6 with SMTP id d2e1a72fcca58-7ba3b89ed15mr12770157b3a.24.1763308624240; Sun, 16 Nov 2025 07:57:04 -0800 (PST) Received: from aheev.home ([106.215.173.137]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7b924ae6943sm10677038b3a.6.2025.11.16.07.56.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 16 Nov 2025 07:57:03 -0800 (PST) From: Ally Heev Date: Sun, 16 Nov 2025 21:26:48 +0530 Subject: [PATCH RFT net-next 1/2] ice: remove __free usage in ice_flow Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251116-aheev-fix-free-uninitialized-ptrs-ethernet-intel-v1-1-0ddc81be6a4c@gmail.com> References: <20251116-aheev-fix-free-uninitialized-ptrs-ethernet-intel-v1-0-0ddc81be6a4c@gmail.com> In-Reply-To: <20251116-aheev-fix-free-uninitialized-ptrs-ethernet-intel-v1-0-0ddc81be6a4c@gmail.com> To: Tony Nguyen , Przemek Kitszel , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Ally Heev , Simon Horman , Dan Carpenter X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1688; i=allyheev@gmail.com; h=from:subject:message-id; bh=ufCbvxIRBVQHCzUSRhXUdWL2YVW5ycqhQc1EXb99qW8=; b=owGbwMvMwCU2zXbRFfvr1TKMp9WSGDIlv7hsWbJ8z5+NfBeCFsRmXr8eKFP1Xzd55veX3yav9 t7w19WitqOUhUGMi0FWTJGFUVTKT2+T1IS4w0nfYOawMoEMYeDiFICJ2DYxMnzIq9Ey0A2copeu KZkZxzi7rnD2sfVTnplmCtxcGMTTdZrhfxJnvwKX7/75Hl9XnLUtd+Jec07pl2Lk1zT1tjWibC6 FDAA= X-Developer-Key: i=allyheev@gmail.com; a=openpgp; fpr=01151A4E2EB21A905EC362F6963DA2D43FD77B1C usage of cleanup attributes is discouraged in net [1], achieve cleanup using goto Suggested-by: Simon Horman Reported-by: Dan Carpenter Closes: https://lore.kernel.org/all/aPiG_F5EBQUjZqsl@stanley.mountain/ Signed-off-by: Ally Heev [1] https://docs.kernel.org/process/maintainer-netdev.html#using-device-man= aged-and-cleanup-h-constructs Signed-off-by: Ally Heev --- drivers/net/ethernet/intel/ice/ice_flow.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/intel/ice/ice_flow.c b/drivers/net/ethern= et/intel/ice/ice_flow.c index 6d5c939dc8a515c252cd2b77d155b69fa264ee92..dd62f5f14d60401d6a24cb9f866= 64425db1532d0 100644 --- a/drivers/net/ethernet/intel/ice/ice_flow.c +++ b/drivers/net/ethernet/intel/ice/ice_flow.c @@ -1573,7 +1573,7 @@ ice_flow_set_parser_prof(struct ice_hw *hw, u16 dest_= vsi, u16 fdir_vsi, struct ice_parser_profile *prof, enum ice_block blk) { u64 id =3D find_first_bit(prof->ptypes, ICE_FLOW_PTYPE_MAX); - struct ice_flow_prof_params *params __free(kfree); + struct ice_flow_prof_params *params =3D NULL; u8 fv_words =3D hw->blk[blk].es.fvw; int status; int i, idx; @@ -1621,12 +1621,14 @@ ice_flow_set_parser_prof(struct ice_hw *hw, u16 des= t_vsi, u16 fdir_vsi, params->attr, params->attr_cnt, params->es, params->mask, false, false); if (status) - return status; + goto out; =20 status =3D ice_flow_assoc_fdir_prof(hw, blk, dest_vsi, fdir_vsi, id); if (status) ice_rem_prof(hw, blk, id); =20 +out: + kfree(params); return status; } =20 --=20 2.47.3 From nobody Mon Feb 9 04:07:45 2026 Received: from mail-pf1-f175.google.com (mail-pf1-f175.google.com [209.85.210.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4736A30CDB6 for ; Sun, 16 Nov 2025 15:57:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763308632; cv=none; b=Dq21IRPwTGxJo50T1NjZ/aamAILGMgwdpfdcPTjBGKWMYVJ5zTrHWCq8psNJ+gQU+5sKtI28B8AbjLefmlOHfLvqv51JThhkVwyj6yZi51JVSIPk3zHVaaPo8GBw5I7oEp1yogMzfq5/YR834k9GFCbXxIuWpOaEnSDbSFvJXrk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763308632; c=relaxed/simple; bh=Usqx83ivKY4w0KNMbSY7X0Z+d+La037+pNfmug8W6AY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ok+OO5YTDOsXfwFbJNuzxxwuKlqMgszE2zc51GGUuhBdKhiydCDV2bhttOYKbz1YrGJGeSvSn5Ac2BR/AuNqndO9aHSB9zErzc/oTcOndJf6/wN9fWDOKLp+nYgOw/R843slDWA3yT0s0VxNKk7nrrUJh1PN+5XnfVRozCGWOjU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=hq80fUw8; arc=none smtp.client-ip=209.85.210.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hq80fUw8" Received: by mail-pf1-f175.google.com with SMTP id d2e1a72fcca58-7aad4823079so3080752b3a.0 for ; Sun, 16 Nov 2025 07:57:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763308630; x=1763913430; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=I1gxk1DsHCEeyciyJk4Gm3Xoh1TUbmw4WS4h5BWbH44=; b=hq80fUw8PfSCSFLH+N69BcSS1hnZGek4jZrmWdC+bn3I6SbeWuPCsAX21TPNC0pgRU zqQ5VS4kQXS/jWrPVSjBYWPWz47msMHazcsWud+vQcVWVxgYPDSniihp4EwZOPuIKzkI u3XfxfHGBNroVYBb3RQTkzAaK3+Onjf1PpwkE1MiiuuwLOSG/hzSVmi6peVy0G2wAi5M rx5uLuyeCg7CciwQi66YFBe2xtvaVWKsdMCrymMnBJ8zp4g1Wy8fQ50Et+h+Jsc4esHF JUvlQhQ4gDIyuuxCuwZAg/xsCNIxpjY37tdPnlHq7ZooGB05WoWVRXZTXFZEAgjAdSGR z/tA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763308630; x=1763913430; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=I1gxk1DsHCEeyciyJk4Gm3Xoh1TUbmw4WS4h5BWbH44=; b=KQE9ldczBx97ICcqPUCnUgWbjZBaEol9Gx1z0moB+cuFynYBFHKkKTS7R/eLyozh9z +EmREucpc7nfoNYTSESd6OYwvbEC8yNIly8u78WIkp5T2QYAZ0dh0v3wwnLifRKZisUD zeKqn2nQ+3QMwiw9U1n/ZW78HYDO0MLa5YXOBlH/cJ9p2WQCGU/wlZ5YYt+KH3WWSrDV IfBmN7szPsDNikJxtIWXCa+39VUU+qrJYxAvgqvsztlB7/ib4wMRH0dl+xklizP6If2g 5ftk0vkot1y0jVUW7K2/ACbZkOVyrCfIVezOTrOMzYJu1jielBh+hn0WbRO8MImxfMp8 U1dg== X-Forwarded-Encrypted: i=1; AJvYcCUzxhnbHWfkuN1+LcblyasmYewxIrZvscrv7lvq/WqFf1KSGXPWgIyP5rAJaBFnBi+DKxOfLi7vjeZins4=@vger.kernel.org X-Gm-Message-State: AOJu0YxPOqgMCQcQZeCUwPz9SdflTznbd7IDe5UJ82fM4VYm0KOSklHu 9xSn0Zna5a4pUR3A6hAGwqFQOsda6jVoanMRMqQyp5poxl52sSu0CstO X-Gm-Gg: ASbGnctNM8aJooyQqDvn7XatgzbG8vHT4Mo8SLtOTtAVZGYAYeZIGW56rM4eg3goTH8 iIp/LkTIsOUYSnieBzKIRJwxzgeoyBomd5+Uozx0rdGx6NxteKuaiAq7/v4rBrwSdOqheKGB4mt FG1NjqKJnb2Sf+OD6pugwSwKYfSXVZo3h576SiAUtIAvQZylxkwwSGmjL1/OjKM+IEL/Ff8rOW+ Kq68LnW4Qjs7l+q/Yx3FITOLFXukapP4p4rgKeArGQsiv3QrYKNtbzzygVl5a1jG+alJvdCUNji X3Bb0NxHfzWOfiYv50aHK8493iSnQKXYD6IHrDaoWB5FItfqo4XTfBNhqNlZMv2Wfdyf9C3yA7B 5FkG8D/27iPsPyOFrzQlnxGGifMCWeAsY2Hlf5KsmksiRHtMASyRgRaJSOsqqw3yxalFx4MWhx9 iDfxhjlLTS X-Google-Smtp-Source: AGHT+IFqBdx4R6YTOp0JDgvcZZT5ZiiWX5oMnR2HQmFdpl5m0+SbCTbe9kbJBhTtWt3ynBIXX091MQ== X-Received: by 2002:a05:6a00:a95:b0:7b9:df65:93a9 with SMTP id d2e1a72fcca58-7ba3ce6b3a7mr11792143b3a.32.1763308630509; Sun, 16 Nov 2025 07:57:10 -0800 (PST) Received: from aheev.home ([106.215.173.137]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7b924ae6943sm10677038b3a.6.2025.11.16.07.57.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 16 Nov 2025 07:57:10 -0800 (PST) From: Ally Heev Date: Sun, 16 Nov 2025 21:26:49 +0530 Subject: [PATCH RFT net-next 2/2] idpf: remove __free usage in idpf_virtchnl Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251116-aheev-fix-free-uninitialized-ptrs-ethernet-intel-v1-2-0ddc81be6a4c@gmail.com> References: <20251116-aheev-fix-free-uninitialized-ptrs-ethernet-intel-v1-0-0ddc81be6a4c@gmail.com> In-Reply-To: <20251116-aheev-fix-free-uninitialized-ptrs-ethernet-intel-v1-0-0ddc81be6a4c@gmail.com> To: Tony Nguyen , Przemek Kitszel , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Ally Heev , Simon Horman , Dan Carpenter X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2680; i=allyheev@gmail.com; h=from:subject:message-id; bh=Usqx83ivKY4w0KNMbSY7X0Z+d+La037+pNfmug8W6AY=; b=owGbwMvMwCU2zXbRFfvr1TKMp9WSGDIlv7jmnYv3fraqfI7mvJ7YxevY13mlb7vk3NBbuq3tv cqLjFO5HaUsDGJcDLJiiiyMolJ+epukJsQdTvoGM4eVCWQIAxenAEyk7SXDH44Jk9c4TXmmyRQY 2fS1qcYz4M4bR/t5J77N2vFm8n3GuAyGv9JqC4K+3/BbHjM1+scGjinaW0XXVbn+WteXqrXTMev 9Jm4A X-Developer-Key: i=allyheev@gmail.com; a=openpgp; fpr=01151A4E2EB21A905EC362F6963DA2D43FD77B1C usage of cleanup attributes is discouraged in net [1], achieve cleanup using goto. In this patch though, only uninitialized pointers with __free attribute are cleaned as they can cause undefined behavior when they go out of scope Suggested-by: Simon Horman Reported-by: Dan Carpenter Closes: https://lore.kernel.org/all/aPiG_F5EBQUjZqsl@stanley.mountain/ Signed-off-by: Ally Heev [1] https://docs.kernel.org/process/maintainer-netdev.html#using-device-man= aged-and-cleanup-h-constructs Signed-off-by: Ally Heev --- drivers/net/ethernet/intel/idpf/idpf_virtchnl.c | 28 +++++++++++++++++----= ---- 1 file changed, 19 insertions(+), 9 deletions(-) diff --git a/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c b/drivers/net/= ethernet/intel/idpf/idpf_virtchnl.c index cbb5fa30f5a0ec778c1ee30470da3ca21cc1af24..5b2bf8c3205bc1ea0746f78afa2= a24f3f8ad2a8c 100644 --- a/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c +++ b/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c @@ -1012,7 +1012,7 @@ static int idpf_send_get_caps_msg(struct idpf_adapter= *adapter) */ static int idpf_send_get_lan_memory_regions(struct idpf_adapter *adapter) { - struct virtchnl2_get_lan_memory_regions *rcvd_regions __free(kfree); + struct virtchnl2_get_lan_memory_regions *rcvd_regions =3D NULL; struct idpf_vc_xn_params xn_params =3D { .vc_op =3D VIRTCHNL2_OP_GET_LAN_MEMORY_REGIONS, .recv_buf.iov_len =3D IDPF_CTLQ_MAX_BUF_LEN, @@ -1029,21 +1029,29 @@ static int idpf_send_get_lan_memory_regions(struct = idpf_adapter *adapter) =20 xn_params.recv_buf.iov_base =3D rcvd_regions; reply_sz =3D idpf_vc_xn_exec(adapter, &xn_params); - if (reply_sz < 0) - return reply_sz; + if (reply_sz < 0) { + err =3D reply_sz; + goto out; + } =20 num_regions =3D le16_to_cpu(rcvd_regions->num_memory_regions); size =3D struct_size(rcvd_regions, mem_reg, num_regions); - if (reply_sz < size) - return -EIO; + if (reply_sz < size) { + err =3D -EIO; + goto out; + } =20 - if (size > IDPF_CTLQ_MAX_BUF_LEN) - return -EINVAL; + if (size > IDPF_CTLQ_MAX_BUF_LEN) { + err =3D -EINVAL; + goto out; + } =20 hw =3D &adapter->hw; hw->lan_regs =3D kcalloc(num_regions, sizeof(*hw->lan_regs), GFP_KERNEL); - if (!hw->lan_regs) - return -ENOMEM; + if (!hw->lan_regs) { + err =3D -ENOMEM; + goto out; + } =20 for (int i =3D 0; i < num_regions; i++) { hw->lan_regs[i].addr_len =3D @@ -1053,6 +1061,8 @@ static int idpf_send_get_lan_memory_regions(struct id= pf_adapter *adapter) } hw->num_lan_regs =3D num_regions; =20 +out: + kfree(rcvd_regions); return err; } =20 --=20 2.47.3