[PATCH v1 0/2] gpiolib: legacy: Allow *gpio_request_one() to die independently

Andy Shevchenko posted 2 patches 2 months, 3 weeks ago
drivers/gpio/gpiolib-legacy.c | 44 +++++++++++++----------------------
1 file changed, 16 insertions(+), 28 deletions(-)
[PATCH v1 0/2] gpiolib: legacy: Allow *gpio_request_one() to die independently
Posted by Andy Shevchenko 2 months, 3 weeks ago
Allow *gpio_request_one() to die independently and make sure
the gpio_request_one() gone first (before gpio_request() removal).
Currently the devm_gpio_request_one() depends on gpio_request_one().
Open code the latter in the former to break the dependency. Also
convert the latter to use legacy APIs, so we can kill it first
as it's not only the logical move, but an easier task due to less
amount of the leftover users in the kernel.

Besides that, we gain a few LoCs with this small refactoring, which
I consider a positive change alone.

Andy Shevchenko (2):
  gpiolib: legacy: Make sure we kill gpio_request_one() first
  gpiolib: legacy: Allow to kill devm_gpio_request_one() independently

 drivers/gpio/gpiolib-legacy.c | 44 +++++++++++++----------------------
 1 file changed, 16 insertions(+), 28 deletions(-)

-- 
2.50.1
Re: [PATCH v1 0/2] gpiolib: legacy: Allow *gpio_request_one() to die independently
Posted by Bartosz Golaszewski 2 months, 3 weeks ago
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>


On Wed, 12 Nov 2025 10:32:00 +0100, Andy Shevchenko wrote:
> Allow *gpio_request_one() to die independently and make sure
> the gpio_request_one() gone first (before gpio_request() removal).
> Currently the devm_gpio_request_one() depends on gpio_request_one().
> Open code the latter in the former to break the dependency. Also
> convert the latter to use legacy APIs, so we can kill it first
> as it's not only the logical move, but an easier task due to less
> amount of the leftover users in the kernel.
> 
> [...]

Applied, thanks!

[1/2] gpiolib: legacy: Make sure we kill gpio_request_one() first
      https://git.kernel.org/brgl/linux/c/61e1fd2abca4c551fb40afcb733a31de1991c656
[2/2] gpiolib: legacy: Allow to kill devm_gpio_request_one() independently
      https://git.kernel.org/brgl/linux/c/ade570c138a509c11b5d016a227009f2f399fd4a

Best regards,
-- 
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>