From nobody Sat Feb 7 08:44:34 2026 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.21]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D4A882FD7DD; Wed, 12 Nov 2025 09:36:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.21 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762940174; cv=none; b=Ht89eu14NLJ7TOp5yQl2zNNIsYF/mp0hT4jA61leRcdOKwDVQup16MGUqDDmxsHo4U8RLFGodDDU/SKBc1VRa17OVI1ebP/e/KikATVTN5rHg+WeUaQhoT+etVPthZgsPEXx7PKNY61xzTsL4dMwfcV8v0ILG14mVf3PTDrR5E4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762940174; c=relaxed/simple; bh=mx9Ima/B0ec4E66CNMxCBK3p897o94WEvlWdsmCWLao=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=KLyrXCdZ1AExbwSStEkMdwCd/1Ydpu5n50r6lLFU3TN/cJs5ON9Zv4gxuI4Pgz6Vnp5/Aeau9dUKu551h9z3shLI/gyIlyREbAlL0HynaOpbptf5uNb0Q9jI6gFTlymK7k4PjyiGBP/GbnpCh2nY7Uyf9wc8xukU24PwrW3RyxU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=M6wHqnH2; arc=none smtp.client-ip=198.175.65.21 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="M6wHqnH2" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1762940172; x=1794476172; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=mx9Ima/B0ec4E66CNMxCBK3p897o94WEvlWdsmCWLao=; b=M6wHqnH2wMmzMC84QHIgX7ekkbQQJMKCNvPhoPMf7A/ZKmX5UVdpKQpG 70ao/NzeR+8VctC/EA31mW5tpQS6W6n+zqgU+16DQIXGWm/qZcfF18gUj W6FEfzQWj4sso+cAMpjxq1nCsLWZ8QN+A0NsrQIXB01YRKPyDhrZDfDCp VQB00vNIuZIjnJLoFUMgy8r/7ievV4nrpI+F3mHDl/T89l/vmb3OGPZgz Yr1azrFSIbjn2k6Mj74GbKg0xMXWEpn9I0eRi/C+Rv9kgxWewHBXDexIa p/De6R/KHy9wMEix03ui6maEXQXlZMq6fn2D3B/CQiRA2HF4OkMRsoeCh A==; X-CSE-ConnectionGUID: yZuUKak2TBeAgrZyEQL90Q== X-CSE-MsgGUID: xOw3DCt7Q7GYXHtsMWvYog== X-IronPort-AV: E=McAfee;i="6800,10657,11531"; a="64922912" X-IronPort-AV: E=Sophos;i="6.17,312,1747724400"; d="scan'208";a="64922912" Received: from fmviesa002.fm.intel.com ([10.60.135.142]) by orvoesa113.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Nov 2025 01:36:12 -0800 X-CSE-ConnectionGUID: 2Lc3ZthHR16brQuspgv1jw== X-CSE-MsgGUID: GLMjDXAYT3mx6nDyRk5oew== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.19,299,1754982000"; d="scan'208";a="212574063" Received: from black.igk.intel.com ([10.91.253.5]) by fmviesa002.fm.intel.com with ESMTP; 12 Nov 2025 01:36:10 -0800 Received: by black.igk.intel.com (Postfix, from userid 1003) id DC56096; Wed, 12 Nov 2025 10:36:08 +0100 (CET) From: Andy Shevchenko To: Andy Shevchenko , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Linus Walleij , Bartosz Golaszewski Subject: [PATCH v1 1/2] gpiolib: legacy: Make sure we kill gpio_request_one() first Date: Wed, 12 Nov 2025 10:32:01 +0100 Message-ID: <20251112093608.1481030-2-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20251112093608.1481030-1-andriy.shevchenko@linux.intel.com> References: <20251112093608.1481030-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Make sure we kill gpio_request_one() first by converting it to use legacy APIs that will be alive a bit longer. In particular, this also shows the code we will use in another function to make it die independently. Signed-off-by: Andy Shevchenko --- drivers/gpio/gpiolib-legacy.c | 18 ++++-------------- 1 file changed, 4 insertions(+), 14 deletions(-) diff --git a/drivers/gpio/gpiolib-legacy.c b/drivers/gpio/gpiolib-legacy.c index 3bc93ccadb5b..35cb7fca634e 100644 --- a/drivers/gpio/gpiolib-legacy.c +++ b/drivers/gpio/gpiolib-legacy.c @@ -34,30 +34,20 @@ EXPORT_SYMBOL_GPL(gpio_free); */ int gpio_request_one(unsigned gpio, unsigned long flags, const char *label) { - struct gpio_desc *desc; int err; =20 - /* Compatibility: assume unavailable "valid" GPIOs will appear later */ - desc =3D gpio_to_desc(gpio); - if (!desc) - return -EPROBE_DEFER; - - err =3D gpiod_request(desc, label); + err =3D gpio_request(gpio, label); if (err) return err; =20 if (flags & GPIOF_IN) - err =3D gpiod_direction_input(desc); + err =3D gpio_direction_input(gpio); else - err =3D gpiod_direction_output_raw(desc, !!(flags & GPIOF_OUT_INIT_HIGH)= ); + err =3D gpio_direction_output(gpio, !!(flags & GPIOF_OUT_INIT_HIGH)); =20 if (err) - goto free_gpio; + gpio_free(gpio); =20 - return 0; - - free_gpio: - gpiod_free(desc); return err; } EXPORT_SYMBOL_GPL(gpio_request_one); --=20 2.50.1 From nobody Sat Feb 7 08:44:34 2026 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 04B0B2FD692; Wed, 12 Nov 2025 09:36:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.18 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762940175; cv=none; b=bK+E21sOLiYCVKXrMOSDQfvWl7SUkxIZNuJcWneEvKJ30Kt+7/FheimZB4vt+f0FXtx+rwbspVFgWPrlzgvyQLukJU59h8mUH6m1Xk0cvB19eSkOPncUmDL0MHzQtSMX21xItVXOesZGnAUxxjauwh9ByzbZsqrt6QTaiMPVKlc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762940175; c=relaxed/simple; bh=3aC01PxJT6hpXIP2xTp42MaqEjs7pHBi/ivGasZ7OVQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=DbZQ6iYXm6bkUw//LGPOJ1+dn0nqDNt6bxLX/CpFpgQXkcds6IPz4qthgXiNpn5dWLne429CKrFhr2eMuyAfH4pnNAgRl2qx0c7vi2i9FmXO8HcJvYdcB5kOUwq0pN7gu9QpFnouI49DsUUE9bLwlJSowOGPwUZ97t5g2EnlZWo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=hsgiZB22; arc=none smtp.client-ip=192.198.163.18 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="hsgiZB22" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1762940174; x=1794476174; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=3aC01PxJT6hpXIP2xTp42MaqEjs7pHBi/ivGasZ7OVQ=; b=hsgiZB22fXfTBcKJMa8ikniILPz/UpIQw7gl8tI0omZYJySbVcbbjw4i dUQ8fv7aTKyRVkV1XBGxc88SAVvypfFrvt2t0yjXuJ2WkLEIJjaDxA3Ed aFzjNzkjOc057OvkjvjN0OV3u199dA0CHcvrH+r0g7u6g15bUe/40AbXA y1H8k7opumzMlMDJH6fxPfsoeY+c69K+zjr+JjrHTaH8RKiYvfTqr0buZ F+O1ssFP1H+n2p6YOsh2e5LheZd862gQt05aX6uxCg/wG50J2JrXtlsnx IMQt086kg/2kO/bv1JNjRI6Hf8XKtpjlz6pqof9XvqFHX2K2m1kPmvS24 Q==; X-CSE-ConnectionGUID: YgTitz7xSVq4am9T6tOl+A== X-CSE-MsgGUID: xNMWjZjBSTOUdKj9gM9ymQ== X-IronPort-AV: E=McAfee;i="6800,10657,11610"; a="64202978" X-IronPort-AV: E=Sophos;i="6.19,299,1754982000"; d="scan'208";a="64202978" Received: from fmviesa007.fm.intel.com ([10.60.135.147]) by fmvoesa112.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Nov 2025 01:36:11 -0800 X-CSE-ConnectionGUID: 422QwXH6SKiyW95bX4XhtQ== X-CSE-MsgGUID: zMYP91TZSN6waAmAcoRJbg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.19,299,1754982000"; d="scan'208";a="188811926" Received: from black.igk.intel.com ([10.91.253.5]) by fmviesa007.fm.intel.com with ESMTP; 12 Nov 2025 01:36:10 -0800 Received: by black.igk.intel.com (Postfix, from userid 1003) id E060497; Wed, 12 Nov 2025 10:36:08 +0100 (CET) From: Andy Shevchenko To: Andy Shevchenko , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Linus Walleij , Bartosz Golaszewski Subject: [PATCH v1 2/2] gpiolib: legacy: Allow to kill devm_gpio_request_one() independently Date: Wed, 12 Nov 2025 10:32:02 +0100 Message-ID: <20251112093608.1481030-3-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20251112093608.1481030-1-andriy.shevchenko@linux.intel.com> References: <20251112093608.1481030-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Allow to kill devm_gpio_request_one() independently by converting it to use legacy APIs that will be alive a bit longer. Signed-off-by: Andy Shevchenko --- drivers/gpio/gpiolib-legacy.c | 26 ++++++++++++-------------- 1 file changed, 12 insertions(+), 14 deletions(-) diff --git a/drivers/gpio/gpiolib-legacy.c b/drivers/gpio/gpiolib-legacy.c index 35cb7fca634e..ef3f2ef30cf2 100644 --- a/drivers/gpio/gpiolib-legacy.c +++ b/drivers/gpio/gpiolib-legacy.c @@ -68,11 +68,9 @@ int gpio_request(unsigned gpio, const char *label) } EXPORT_SYMBOL_GPL(gpio_request); =20 -static void devm_gpio_release(struct device *dev, void *res) +static void devm_gpio_release(void *gpio) { - unsigned *gpio =3D res; - - gpio_free(*gpio); + gpio_free((unsigned)(unsigned long)gpio); } =20 /** @@ -90,22 +88,22 @@ static void devm_gpio_release(struct device *dev, void = *res) int devm_gpio_request_one(struct device *dev, unsigned gpio, unsigned long flags, const char *label) { - unsigned *dr; int rc; =20 - dr =3D devres_alloc(devm_gpio_release, sizeof(unsigned), GFP_KERNEL); - if (!dr) - return -ENOMEM; + rc =3D gpio_request(gpio, label); + if (rc) + return rc; + + if (flags & GPIOF_IN) + rc =3D gpio_direction_input(gpio); + else + rc =3D gpio_direction_output(gpio, !!(flags & GPIOF_OUT_INIT_HIGH)); =20 - rc =3D gpio_request_one(gpio, flags, label); if (rc) { - devres_free(dr); + gpio_free(gpio); return rc; } =20 - *dr =3D gpio; - devres_add(dev, dr); - - return 0; + return devm_add_action_or_reset(dev, devm_gpio_release, (void *)(unsigned= long)gpio); } EXPORT_SYMBOL_GPL(devm_gpio_request_one); --=20 2.50.1