Document support for Airoha AN7583 clock based on the EN7523
clock schema.
Add additional binding for additional clock and reset lines.
Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
---
.../bindings/clock/airoha,en7523-scu.yaml | 5 +-
include/dt-bindings/clock/en7523-clk.h | 3 +
.../dt-bindings/reset/airoha,an7583-reset.h | 62 +++++++++++++++++++
3 files changed, 69 insertions(+), 1 deletion(-)
create mode 100644 include/dt-bindings/reset/airoha,an7583-reset.h
diff --git a/Documentation/devicetree/bindings/clock/airoha,en7523-scu.yaml b/Documentation/devicetree/bindings/clock/airoha,en7523-scu.yaml
index fe2c5c1baf43..2d53b96356c5 100644
--- a/Documentation/devicetree/bindings/clock/airoha,en7523-scu.yaml
+++ b/Documentation/devicetree/bindings/clock/airoha,en7523-scu.yaml
@@ -30,6 +30,7 @@ properties:
compatible:
items:
- enum:
+ - airoha,an7583-scu
- airoha,en7523-scu
- airoha,en7581-scu
@@ -69,7 +70,9 @@ allOf:
- if:
properties:
compatible:
- const: airoha,en7581-scu
+ enum:
+ - airoha,an7583-scu
+ - airoha,en7581-scu
then:
properties:
reg:
diff --git a/include/dt-bindings/clock/en7523-clk.h b/include/dt-bindings/clock/en7523-clk.h
index edfa64045f52..0fbbcb7b1b25 100644
--- a/include/dt-bindings/clock/en7523-clk.h
+++ b/include/dt-bindings/clock/en7523-clk.h
@@ -14,4 +14,7 @@
#define EN7581_CLK_EMMC 8
+#define AN7583_CLK_MDIO0 9
+#define AN7583_CLK_MDIO1 10
+
#endif /* _DT_BINDINGS_CLOCK_AIROHA_EN7523_H_ */
diff --git a/include/dt-bindings/reset/airoha,an7583-reset.h b/include/dt-bindings/reset/airoha,an7583-reset.h
new file mode 100644
index 000000000000..7ff07986f8ba
--- /dev/null
+++ b/include/dt-bindings/reset/airoha,an7583-reset.h
@@ -0,0 +1,62 @@
+/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */
+/*
+ * Copyright (c) 2024 AIROHA Inc
+ * Author: Christian Marangi <ansuelsmth@gmail.com>
+ */
+
+#ifndef __DT_BINDINGS_RESET_CONTROLLER_AIROHA_AN7583_H_
+#define __DT_BINDINGS_RESET_CONTROLLER_AIROHA_AN7583_H_
+
+/* RST_CTRL2 */
+#define AN7583_XPON_PHY_RST 0
+#define AN7583_GPON_OLT_RST 1
+#define AN7583_CPU_TIMER2_RST 2
+#define AN7583_HSUART_RST 3
+#define AN7583_UART4_RST 4
+#define AN7583_UART5_RST 5
+#define AN7583_I2C2_RST 6
+#define AN7583_XSI_MAC_RST 7
+#define AN7583_XSI_PHY_RST 8
+#define AN7583_NPU_RST 9
+#define AN7583_TRNG_MSTART_RST 10
+#define AN7583_DUAL_HSI0_RST 11
+#define AN7583_DUAL_HSI1_RST 12
+#define AN7583_DUAL_HSI0_MAC_RST 13
+#define AN7583_DUAL_HSI1_MAC_RST 14
+#define AN7583_XPON_XFI_RST 15
+#define AN7583_WDMA_RST 16
+#define AN7583_WOE0_RST 17
+#define AN7583_HSDMA_RST 18
+#define AN7583_TDMA_RST 19
+#define AN7583_EMMC_RST 20
+#define AN7583_SOE_RST 21
+#define AN7583_XFP_MAC_RST 22
+#define AN7583_MDIO0 23
+#define AN7583_MDIO1 24
+/* RST_CTRL1 */
+#define AN7583_PCM1_ZSI_ISI_RST 25
+#define AN7583_FE_PDMA_RST 26
+#define AN7583_FE_QDMA_RST 27
+#define AN7583_PCM_SPIWP_RST 28
+#define AN7583_CRYPTO_RST 29
+#define AN7583_TIMER_RST 30
+#define AN7583_PCM1_RST 31
+#define AN7583_UART_RST 32
+#define AN7583_GPIO_RST 33
+#define AN7583_GDMA_RST 34
+#define AN7583_I2C_MASTER_RST 35
+#define AN7583_PCM2_ZSI_ISI_RST 36
+#define AN7583_SFC_RST 37
+#define AN7583_UART2_RST 38
+#define AN7583_GDMP_RST 39
+#define AN7583_FE_RST 40
+#define AN7583_USB_HOST_P0_RST 41
+#define AN7583_GSW_RST 42
+#define AN7583_SFC2_PCM_RST 43
+#define AN7583_PCIE0_RST 44
+#define AN7583_PCIE1_RST 45
+#define AN7583_CPU_TIMER_RST 46
+#define AN7583_PCIE_HB_RST 47
+#define AN7583_XPON_MAC_RST 48
+
+#endif /* __DT_BINDINGS_RESET_CONTROLLER_AIROHA_AN7583_H_ */
--
2.51.0On 06/11/2025 20:59, Christian Marangi wrote: > Document support for Airoha AN7583 clock based on the EN7523 > clock schema. > > Add additional binding for additional clock and reset lines. > > Signed-off-by: Christian Marangi <ansuelsmth@gmail.com> > --- Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On Thu, Nov 06, 2025 at 08:59:31PM +0100, Christian Marangi wrote: > Document support for Airoha AN7583 clock based on the EN7523 > clock schema. > > Add additional binding for additional clock and reset lines. > > Signed-off-by: Christian Marangi <ansuelsmth@gmail.com> > --- > .../bindings/clock/airoha,en7523-scu.yaml | 5 +- > include/dt-bindings/clock/en7523-clk.h | 3 + > .../dt-bindings/reset/airoha,an7583-reset.h | 62 +++++++++++++++++++ > 3 files changed, 69 insertions(+), 1 deletion(-) > create mode 100644 include/dt-bindings/reset/airoha,an7583-reset.h > > diff --git a/Documentation/devicetree/bindings/clock/airoha,en7523-scu.yaml b/Documentation/devicetree/bindings/clock/airoha,en7523-scu.yaml > index fe2c5c1baf43..2d53b96356c5 100644 > --- a/Documentation/devicetree/bindings/clock/airoha,en7523-scu.yaml > +++ b/Documentation/devicetree/bindings/clock/airoha,en7523-scu.yaml > @@ -30,6 +30,7 @@ properties: > compatible: > items: > - enum: > + - airoha,an7583-scu That's random order. Keep it sorted. Best regards, Krzysztof
On Fri, Nov 07, 2025 at 08:42:15AM +0100, Krzysztof Kozlowski wrote: > On Thu, Nov 06, 2025 at 08:59:31PM +0100, Christian Marangi wrote: > > Document support for Airoha AN7583 clock based on the EN7523 > > clock schema. > > > > Add additional binding for additional clock and reset lines. > > > > Signed-off-by: Christian Marangi <ansuelsmth@gmail.com> > > --- > > .../bindings/clock/airoha,en7523-scu.yaml | 5 +- > > include/dt-bindings/clock/en7523-clk.h | 3 + > > .../dt-bindings/reset/airoha,an7583-reset.h | 62 +++++++++++++++++++ > > 3 files changed, 69 insertions(+), 1 deletion(-) > > create mode 100644 include/dt-bindings/reset/airoha,an7583-reset.h > > > > diff --git a/Documentation/devicetree/bindings/clock/airoha,en7523-scu.yaml b/Documentation/devicetree/bindings/clock/airoha,en7523-scu.yaml > > index fe2c5c1baf43..2d53b96356c5 100644 > > --- a/Documentation/devicetree/bindings/clock/airoha,en7523-scu.yaml > > +++ b/Documentation/devicetree/bindings/clock/airoha,en7523-scu.yaml > > @@ -30,6 +30,7 @@ properties: > > compatible: > > items: > > - enum: > > + - airoha,an7583-scu > > That's random order. Keep it sorted. > > Best regards, > Krzysztof > Hi Krzysztof, I was also not cetrain on the correct order. We have En7523 and en7581 and then An7583. So should I put it at last following the number order or the alphabetical order? -- Ansuel
On 07/11/2025 08:45, Christian Marangi wrote: > On Fri, Nov 07, 2025 at 08:42:15AM +0100, Krzysztof Kozlowski wrote: >> On Thu, Nov 06, 2025 at 08:59:31PM +0100, Christian Marangi wrote: >>> Document support for Airoha AN7583 clock based on the EN7523 >>> clock schema. >>> >>> Add additional binding for additional clock and reset lines. >>> >>> Signed-off-by: Christian Marangi <ansuelsmth@gmail.com> >>> --- >>> .../bindings/clock/airoha,en7523-scu.yaml | 5 +- >>> include/dt-bindings/clock/en7523-clk.h | 3 + >>> .../dt-bindings/reset/airoha,an7583-reset.h | 62 +++++++++++++++++++ >>> 3 files changed, 69 insertions(+), 1 deletion(-) >>> create mode 100644 include/dt-bindings/reset/airoha,an7583-reset.h >>> >>> diff --git a/Documentation/devicetree/bindings/clock/airoha,en7523-scu.yaml b/Documentation/devicetree/bindings/clock/airoha,en7523-scu.yaml >>> index fe2c5c1baf43..2d53b96356c5 100644 >>> --- a/Documentation/devicetree/bindings/clock/airoha,en7523-scu.yaml >>> +++ b/Documentation/devicetree/bindings/clock/airoha,en7523-scu.yaml >>> @@ -30,6 +30,7 @@ properties: >>> compatible: >>> items: >>> - enum: >>> + - airoha,an7583-scu >> >> That's random order. Keep it sorted. >> >> Best regards, >> Krzysztof >> > > Hi Krzysztof, > > I was also not cetrain on the correct order. Why? The rule was expressed on mailing list many, many times and only Sunxi or maybe one more SoC does it differently. > > We have En7523 and en7581 and then An7583. > > So should I put it at last following the number order or the > alphabetical order? All such lists or enumerations are ordered alphanumerically. Best regards, Krzysztof
On Fri, Nov 07, 2025 at 09:12:48AM +0100, Krzysztof Kozlowski wrote:
> On 07/11/2025 08:45, Christian Marangi wrote:
> > On Fri, Nov 07, 2025 at 08:42:15AM +0100, Krzysztof Kozlowski wrote:
> >> On Thu, Nov 06, 2025 at 08:59:31PM +0100, Christian Marangi wrote:
> >>> Document support for Airoha AN7583 clock based on the EN7523
> >>> clock schema.
> >>>
> >>> Add additional binding for additional clock and reset lines.
> >>>
> >>> Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
> >>> ---
> >>> .../bindings/clock/airoha,en7523-scu.yaml | 5 +-
> >>> include/dt-bindings/clock/en7523-clk.h | 3 +
> >>> .../dt-bindings/reset/airoha,an7583-reset.h | 62 +++++++++++++++++++
> >>> 3 files changed, 69 insertions(+), 1 deletion(-)
> >>> create mode 100644 include/dt-bindings/reset/airoha,an7583-reset.h
> >>>
> >>> diff --git a/Documentation/devicetree/bindings/clock/airoha,en7523-scu.yaml b/Documentation/devicetree/bindings/clock/airoha,en7523-scu.yaml
> >>> index fe2c5c1baf43..2d53b96356c5 100644
> >>> --- a/Documentation/devicetree/bindings/clock/airoha,en7523-scu.yaml
> >>> +++ b/Documentation/devicetree/bindings/clock/airoha,en7523-scu.yaml
> >>> @@ -30,6 +30,7 @@ properties:
> >>> compatible:
> >>> items:
> >>> - enum:
> >>> + - airoha,an7583-scu
> >>
> >> That's random order. Keep it sorted.
> >>
> >> Best regards,
> >> Krzysztof
> >>
> >
> > Hi Krzysztof,
> >
> > I was also not cetrain on the correct order.
>
> Why? The rule was expressed on mailing list many, many times and only
> Sunxi or maybe one more SoC does it differently.
>
> >
> > We have En7523 and en7581 and then An7583.
> >
> > So should I put it at last following the number order or the
> > alphabetical order?
> All such lists or enumerations are ordered alphanumerically.
>
Ok so I think the proposed order follows alphanumerically order.
- airoha,An7583-scu
- airoha,En7523-scu
- airoha,En7581-scu
Maybe the A vs E was confusing?
The confusion was if I should have ordered for the number
so
- en7523
- en7581
- an7583
or the normaly way
- an7583
- en7523
- en7581
But since it's alphanumerically, it should be correct.
--
Ansuel
On 07/11/2025 09:20, Christian Marangi wrote: > On Fri, Nov 07, 2025 at 09:12:48AM +0100, Krzysztof Kozlowski wrote: >> On 07/11/2025 08:45, Christian Marangi wrote: >>> On Fri, Nov 07, 2025 at 08:42:15AM +0100, Krzysztof Kozlowski wrote: >>>> On Thu, Nov 06, 2025 at 08:59:31PM +0100, Christian Marangi wrote: >>>>> Document support for Airoha AN7583 clock based on the EN7523 >>>>> clock schema. >>>>> >>>>> Add additional binding for additional clock and reset lines. >>>>> >>>>> Signed-off-by: Christian Marangi <ansuelsmth@gmail.com> >>>>> --- >>>>> .../bindings/clock/airoha,en7523-scu.yaml | 5 +- >>>>> include/dt-bindings/clock/en7523-clk.h | 3 + >>>>> .../dt-bindings/reset/airoha,an7583-reset.h | 62 +++++++++++++++++++ >>>>> 3 files changed, 69 insertions(+), 1 deletion(-) >>>>> create mode 100644 include/dt-bindings/reset/airoha,an7583-reset.h >>>>> >>>>> diff --git a/Documentation/devicetree/bindings/clock/airoha,en7523-scu.yaml b/Documentation/devicetree/bindings/clock/airoha,en7523-scu.yaml >>>>> index fe2c5c1baf43..2d53b96356c5 100644 >>>>> --- a/Documentation/devicetree/bindings/clock/airoha,en7523-scu.yaml >>>>> +++ b/Documentation/devicetree/bindings/clock/airoha,en7523-scu.yaml >>>>> @@ -30,6 +30,7 @@ properties: >>>>> compatible: >>>>> items: >>>>> - enum: >>>>> + - airoha,an7583-scu >>>> >>>> That's random order. Keep it sorted. >>>> >>>> Best regards, >>>> Krzysztof >>>> >>> >>> Hi Krzysztof, >>> >>> I was also not cetrain on the correct order. >> >> Why? The rule was expressed on mailing list many, many times and only >> Sunxi or maybe one more SoC does it differently. >> >>> >>> We have En7523 and en7581 and then An7583. >>> >>> So should I put it at last following the number order or the >>> alphabetical order? >> All such lists or enumerations are ordered alphanumerically. >> > > Ok so I think the proposed order follows alphanumerically order. > > - airoha,An7583-scu > - airoha,En7523-scu > - airoha,En7581-scu > > Maybe the A vs E was confusing? Yes, my bad, I missed the a/e. The list is correct, sorry. Best regards, Krzysztof
© 2016 - 2025 Red Hat, Inc.