The driver calls reset_control_get_optional_exclusive() but never calls
reset_control_put() in error paths or in the remove function. This causes
a resource leak when probe fails after successfully acquiring the reset
control, or when the driver is unloaded.

Switch to devm_reset_control_get_optional_exclusive() to automatically
manage the reset control resource.

Fixes: a4b80242d046 ("media: st-rc: explicitly request exclusive reset control")
Signed-off-by: Haotian Zhang <vulab@iscas.ac.cn>
---
 drivers/media/rc/st_rc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/rc/st_rc.c b/drivers/media/rc/st_rc.c
index 6539fa0a6e79..6b70bac5f45d 100644
--- a/drivers/media/rc/st_rc.c
+++ b/drivers/media/rc/st_rc.c
@@ -284,7 +284,7 @@ static int st_rc_probe(struct platform_device *pdev)
 	else
 		rc_dev->rx_base = rc_dev->base;
 
-	rc_dev->rstc = reset_control_get_optional_exclusive(dev, NULL);
+	rc_dev->rstc = devm_reset_control_get_optional_exclusive(dev, NULL);
 	if (IS_ERR(rc_dev->rstc)) {
 		ret = PTR_ERR(rc_dev->rstc);
 		goto err;
-- 
2.50.1.windows.1

On 10/31/25 07:03, Haotian Zhang wrote:
> The driver calls reset_control_get_optional_exclusive() but never calls
> reset_control_put() in error paths or in the remove function. This causes
> a resource leak when probe fails after successfully acquiring the reset
> control, or when the driver is unloaded.
> 
> Switch to devm_reset_control_get_optional_exclusive() to automatically
> manage the reset control resource.
> 
> Fixes: a4b80242d046 ("media: st-rc: explicitly request exclusive reset control")
> Signed-off-by: Haotian Zhang <vulab@iscas.ac.cn>
> ---
>  drivers/media/rc/st_rc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/rc/st_rc.c b/drivers/media/rc/st_rc.c
> index 6539fa0a6e79..6b70bac5f45d 100644
> --- a/drivers/media/rc/st_rc.c
> +++ b/drivers/media/rc/st_rc.c
> @@ -284,7 +284,7 @@ static int st_rc_probe(struct platform_device *pdev)
>  	else
>  		rc_dev->rx_base = rc_dev->base;
>  
> -	rc_dev->rstc = reset_control_get_optional_exclusive(dev, NULL);
> +	rc_dev->rstc = devm_reset_control_get_optional_exclusive(dev, NULL);
>  	if (IS_ERR(rc_dev->rstc)) {
>  		ret = PTR_ERR(rc_dev->rstc);
>  		goto err;


Reviewed-by: Patrice Chotard <patrice.chotard@foss.st.com>

Thanks
Patrice