From nobody Sun Feb 8 09:07:41 2026 Received: from cstnet.cn (smtp21.cstnet.cn [159.226.251.21]) (using TLSv1.2 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 654DD2DE6EE; Fri, 31 Oct 2025 06:04:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=159.226.251.21 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761890646; cv=none; b=hjlEoW10WDAlRpJwsj9m8Iniha/XlROmHwpGPy7LEPgOfL9EIpXOYtcaLZ1hAEuni5JUU/3lPyJw2Inq7inwK0cQogiTNnwaZh/d8uyFt05+l9ctkYSgQRHRPB+WPfsU7f74d9wS6a6Rs9Bw4fdjx14upS5u/htKYq1NZRdLMGo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761890646; c=relaxed/simple; bh=YakhmeId4QZTvK2xVgWzZ222AWTQGU95Klbx+8fP3Pc=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=V8kCEAwvgvdPfQmvQV0kKAgEFUiAd4oj7Uwa3RRYQnP2Sy4/Nu9RkzxE2FJmYaUz6I6Tsa1x3fObDNruqI6mSgCsHXRujZ8IS+1j5qwoTmB1YMy4PptlOaCWtiIu767i2R9Tu8BPnh5/MgROAUE4Y9b68GOwyXriKoLyRwcv5dM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn; spf=pass smtp.mailfrom=iscas.ac.cn; arc=none smtp.client-ip=159.226.251.21 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=iscas.ac.cn Received: from DESKTOP-L0HPE2S (unknown [124.16.141.245]) by APP-01 (Coremail) with SMTP id qwCowADXQGtDUQRp8+G6AA--.2437S2; Fri, 31 Oct 2025 14:03:49 +0800 (CST) From: Haotian Zhang To: patrice.chotard@foss.st.com, sean@mess.org, mchehab@kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Haotian Zhang Subject: [PATCH] media: rc: st_rc: fix reset control resource leak Date: Fri, 31 Oct 2025 14:03:32 +0800 Message-ID: <20251031060332.1470-1-vulab@iscas.ac.cn> X-Mailer: git-send-email 2.50.1.windows.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: qwCowADXQGtDUQRp8+G6AA--.2437S2 X-Coremail-Antispam: 1UD129KBjvdXoWrtrW5urWfZrWfCF1xZr45trb_yoWkZrX_ur 47ZFy29r4xKryYkr1Dtr4IvayakFZ0y3W8XFZ3tFZIgFWqqF4UZryqvryjvr17ur47ur9r CayUXFWS934xAjkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUb4kFF20E14v26r4j6ryUM7CY07I20VC2zVCF04k26cxKx2IYs7xG 6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48ve4kI8w A2z4x0Y4vE2Ix0cI8IcVAFwI0_Jr0_JF4l84ACjcxK6xIIjxv20xvEc7CjxVAFwI0_Jr0_ Gr1l84ACjcxK6I8E87Iv67AKxVW8Jr0_Cr1UM28EF7xvwVC2z280aVCY1x0267AKxVWxJr 0_GcWle2I262IYc4CY6c8Ij28IcVAaY2xG8wAqx4xG64xvF2IEw4CE5I8CrVC2j2WlYx0E 2Ix0cI8IcVAFwI0_Jr0_Jr4lYx0Ex4A2jsIE14v26r1j6r4UMcvjeVCFs4IE7xkEbVWUJV W8JwACjcxG0xvY0x0EwIxGrwACjI8F5VA0II8E6IAqYI8I648v4I1lc7CjxVAaw2AFwI0_ JF0_Jw1l42xK82IYc2Ij64vIr41l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr1lx2IqxVAqx4xG67 AKxVWUJVWUGwC20s026x8GjcxK67AKxVWUGVWUWwC2zVAF1VAY17CE14v26r126r1DMIIY rxkI7VAKI48JMIIF0xvE2Ix0cI8IcVAFwI0_Jr0_JF4lIxAIcVC0I7IYx2IY6xkF7I0E14 v26r1j6r4UMIIF0xvE42xK8VAvwI8IcIk0rVWUJVWUCwCI42IY6I8E87Iv67AKxVWUJVW8 JwCI42IY6I8E87Iv6xkF7I0E14v26r4j6r4UJbIYCTnIWIevJa73UjIFyTuYvjfUYCJmUU UUU X-CM-SenderInfo: pyxotu46lvutnvoduhdfq/1tbiBgwMA2kEG5m3wQAAsc Content-Type: text/plain; charset="utf-8" The driver calls reset_control_get_optional_exclusive() but never calls reset_control_put() in error paths or in the remove function. This causes a resource leak when probe fails after successfully acquiring the reset control, or when the driver is unloaded. Switch to devm_reset_control_get_optional_exclusive() to automatically manage the reset control resource. Fixes: a4b80242d046 ("media: st-rc: explicitly request exclusive reset cont= rol") Signed-off-by: Haotian Zhang Reviewed-by: Patrice Chotard --- drivers/media/rc/st_rc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/rc/st_rc.c b/drivers/media/rc/st_rc.c index 6539fa0a6e79..6b70bac5f45d 100644 --- a/drivers/media/rc/st_rc.c +++ b/drivers/media/rc/st_rc.c @@ -284,7 +284,7 @@ static int st_rc_probe(struct platform_device *pdev) else rc_dev->rx_base =3D rc_dev->base; =20 - rc_dev->rstc =3D reset_control_get_optional_exclusive(dev, NULL); + rc_dev->rstc =3D devm_reset_control_get_optional_exclusive(dev, NULL); if (IS_ERR(rc_dev->rstc)) { ret =3D PTR_ERR(rc_dev->rstc); goto err; --=20 2.50.1.windows.1