dpll: spec: add missing module-name and clock-id to pin-get reply

[PATCH net] dpll: spec: add missing module-name and clock-id to pin-get reply

Posted by Petr Oros 3 months, 2 weeks ago

The dpll.yaml spec incorrectly omitted module-name and clock-id from the
pin-get operation reply specification, even though the kernel DPLL
implementation has always included these attributes in pin-get responses
since the initial implementation.

This spec inconsistency caused issues with the C YNL code generator.
The generated dpll_pin_get_rsp structure was missing these fields.

Fix the spec by adding module-name and clock-id to the pin-attrs reply
specification to match the actual kernel behavior.

Fixes: 3badff3a25d8 ("dpll: spec: Add Netlink spec in YAML")
Signed-off-by: Petr Oros <poros@redhat.com>
---
 Documentation/netlink/specs/dpll.yaml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/netlink/specs/dpll.yaml b/Documentation/netlink/specs/dpll.yaml
index cafb4ec20447e1..80728f6f9bc876 100644
--- a/Documentation/netlink/specs/dpll.yaml
+++ b/Documentation/netlink/specs/dpll.yaml
@@ -605,6 +605,8 @@ operations:
         reply: &pin-attrs
           attributes:
             - id
+            - module-name
+            - clock-id
             - board-label
             - panel-label
             - package-label
-- 
2.51.0

Re: [PATCH net] dpll: spec: add missing module-name and clock-id to pin-get reply

Posted by Ivan Vecera 3 months, 1 week ago


On 10/24/25 8:55 PM, Petr Oros wrote:
> The dpll.yaml spec incorrectly omitted module-name and clock-id from the
> pin-get operation reply specification, even though the kernel DPLL
> implementation has always included these attributes in pin-get responses
> since the initial implementation.
> 
> This spec inconsistency caused issues with the C YNL code generator.
> The generated dpll_pin_get_rsp structure was missing these fields.
> 
> Fix the spec by adding module-name and clock-id to the pin-attrs reply
> specification to match the actual kernel behavior.
> 
> Fixes: 3badff3a25d8 ("dpll: spec: Add Netlink spec in YAML")
> Signed-off-by: Petr Oros <poros@redhat.com>
> ---
>   Documentation/netlink/specs/dpll.yaml | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/netlink/specs/dpll.yaml b/Documentation/netlink/specs/dpll.yaml
> index cafb4ec20447e1..80728f6f9bc876 100644
> --- a/Documentation/netlink/specs/dpll.yaml
> +++ b/Documentation/netlink/specs/dpll.yaml
> @@ -605,6 +605,8 @@ operations:
>           reply: &pin-attrs
>             attributes:
>               - id
> +            - module-name
> +            - clock-id
>               - board-label
>               - panel-label
>               - package-label

Reviewed-by: Ivan Vecera <ivecera@redhat.com>