[PATCH v1 03/22] perf metricgroup: Missed free on error path

Ian Rogers posted 22 patches 3 months, 2 weeks ago
There is a newer version of this series
[PATCH v1 03/22] perf metricgroup: Missed free on error path
Posted by Ian Rogers 3 months, 2 weeks ago
If an out-of-memory occurs the expr also needs freeing.

Signed-off-by: Ian Rogers <irogers@google.com>
---
 tools/perf/util/metricgroup.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/perf/util/metricgroup.c b/tools/perf/util/metricgroup.c
index 595b83142d2c..c822cf5da53b 100644
--- a/tools/perf/util/metricgroup.c
+++ b/tools/perf/util/metricgroup.c
@@ -1455,6 +1455,7 @@ static int parse_groups(struct evlist *perf_evlist,
 
 		if (!expr->metric_name) {
 			ret = -ENOMEM;
+			free(expr);
 			free(metric_events);
 			goto out;
 		}
-- 
2.51.1.821.gb6fe4d2222-goog