From nobody Sun Feb 8 21:33:59 2026 Received: from mail-pl1-f202.google.com (mail-pl1-f202.google.com [209.85.214.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AD66E346E70 for ; Fri, 24 Oct 2025 17:59:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.202 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761328749; cv=none; b=LK/o9pIQ1b/+pf6tD5GYvao+g4EkQykdVLFmBktaDb4G8HIxX1WWmAjLg6/p65gyWl9ZZHAUzFUb5VZlf28QNxj14wpzemI3iAyuNmSkl+q07umQJaDLun613fDSYBiIOQr8f8ZAkMgzL8MaNxNk75fr2XXKu6rAhW5BB0KD+OE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761328749; c=relaxed/simple; bh=rFnvrhJrQ7j7hkJ82kWWbtJZ3FFEl0AVotLlFTPUNLs=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Content-Type; b=rKWFMxQ7/9tzZ/FsUOTXXEZs3GeuSjCvxjLXoMkHCVSA03/5GbbntoP3Uucu24n698PUKQC5RNT3v0ImEin8DaX1USwcuLYEthPz9vBHU8jZ7umoDbg6xyfDzxDJjCLXR4YTuVDV5OiiRp19CHNiME1qPbOeXWSUNLrlHp+6i34= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=OeoonKfU; arc=none smtp.client-ip=209.85.214.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="OeoonKfU" Received: by mail-pl1-f202.google.com with SMTP id d9443c01a7336-290992f9693so28427595ad.1 for ; Fri, 24 Oct 2025 10:59:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1761328747; x=1761933547; darn=vger.kernel.org; h=to:from:subject:message-id:references:mime-version:in-reply-to:date :from:to:cc:subject:date:message-id:reply-to; bh=e/orE7Kl2T5+FMrzRJXD3kZQQJ5k2gk8t41KGFSxw6I=; b=OeoonKfUrJzc8h6T6Bo83j1pKLTKnl0sXNUuDbFCz8GnRzvmOQWG1YN1malGFP3kn3 KtMdbHn4t7cb6/WtfLSJJ+LOcDyOG/fSTyPNOgxNfxYPrmdSvtXaIAgsa+4v1gJEC4sl BYazjc7G66z+mmH56LDroOTjYQAHPGKLvp66DJokNjHg1IOLNBjV9rps4JJAlDGSvHJj +DJTj+xEkkyDH21909rMiVAgGgHDPZDb+sUodq/R2cpK14F++KVVH9kVSdwpO40yAWDA WG+M09eA180uE+hKnZSVtdal6BLywjF96kRpjkUiClD1SHdL7yT+PAZlT5PyE/plfJgw FC7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761328747; x=1761933547; h=to:from:subject:message-id:references:mime-version:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=e/orE7Kl2T5+FMrzRJXD3kZQQJ5k2gk8t41KGFSxw6I=; b=k9RxCAbQ/TWu3gY/FKmHw11Ru7dvymwmzvtJSkc4ad3UAh/yVMO0DjT28gtC9aKNGj 3mVy3pQphbPrcGJeb78EZ/2dIm0BtnNwebqIbXL8ZBNmLKEH0SiBAqH0yOrKzVFL/S8M BTyMt1rfLs3mKwCwsg9Y2k5/owIrriiHXw7kfrtfno5tuXE1g/lOGYLAfzk6A5IyGG0z zv7b/4UVAuHZYlvrRJjX7ggD5obEN7bCxetTA39eoVr+t8bw/5G1/qMDxSEzwGeAVZlP pUurEzfFSg3Y5mzcuj4Vyl90AuVRhNclwJOqKRbMyr3FQpyN5vlnfdk6f5QrzS4k17CS 5H7g== X-Forwarded-Encrypted: i=1; AJvYcCUyOjfyYSDlf4g8CpGtVuHEYzoOehNy3THmM7EvcCCcj3AiULzfKEY0VrlFNKjsNd/Owp4XSDxIMluLF1I=@vger.kernel.org X-Gm-Message-State: AOJu0YzpY1KbaVl8DpwOoDbXvScVB1u95PsfbEuQiWpeemt5PJf8WadD M1K/1m1lVyctg4c0XbdVqWwnCVHNwvYqjzuz6kXg/62omyorv6YV7okx95GfYrW9tIKGodGZc+A Ssw28ZW2+Lw== X-Google-Smtp-Source: AGHT+IEiuNrfkGll/jw9TGPgzbkCABGR+L/ughckv4/H2YorryoqXMAe9/saT1zEWVT6iUHw7By6llK3W7B/ X-Received: from pjuq16.prod.google.com ([2002:a17:90a:d390:b0:334:1843:ee45]) (user=irogers job=prod-delivery.src-stubby-dispatcher) by 2002:a17:902:f64b:b0:274:506d:7fcc with SMTP id d9443c01a7336-29489d71137mr45832845ad.6.1761328746916; Fri, 24 Oct 2025 10:59:06 -0700 (PDT) Date: Fri, 24 Oct 2025 10:58:38 -0700 In-Reply-To: <20251024175857.808401-1-irogers@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20251024175857.808401-1-irogers@google.com> X-Mailer: git-send-email 2.51.1.821.gb6fe4d2222-goog Message-ID: <20251024175857.808401-4-irogers@google.com> Subject: [PATCH v1 03/22] perf metricgroup: Missed free on error path From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , James Clark , Xu Yang , Chun-Tse Shao , Thomas Richter , Sumanth Korikkar , Collin Funk , Thomas Falcon , Howard Chu , Dapeng Mi , Levi Yun , Yang Li , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" If an out-of-memory occurs the expr also needs freeing. Signed-off-by: Ian Rogers --- tools/perf/util/metricgroup.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/perf/util/metricgroup.c b/tools/perf/util/metricgroup.c index 595b83142d2c..c822cf5da53b 100644 --- a/tools/perf/util/metricgroup.c +++ b/tools/perf/util/metricgroup.c @@ -1455,6 +1455,7 @@ static int parse_groups(struct evlist *perf_evlist, =20 if (!expr->metric_name) { ret =3D -ENOMEM; + free(expr); free(metric_events); goto out; } --=20 2.51.1.821.gb6fe4d2222-goog