[PATCH 0/7] can: m_can: various cleanups

Marc Kleine-Budde posted 7 patches 2 months, 1 week ago
drivers/net/can/m_can/m_can.c | 116 ++++++++++++++++++++----------------------
drivers/net/can/m_can/m_can.h |   1 -
2 files changed, 56 insertions(+), 61 deletions(-)
[PATCH 0/7] can: m_can: various cleanups
Posted by Marc Kleine-Budde 2 months, 1 week ago
While working on the m_can driver, I created several cleanups commits, make
m_can_init_ram() static, rename hrtimer function, convert debugging and
error output to netdev_(), replace open coded register write by
m_can_write(), remove not needed error messages and sanity checks and don't
wake up hte controller during m_can_get_berr_counter() if the interface is
down.

Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
---
Marc Kleine-Budde (7):
      can: m_can: m_can_init_ram(): make static
      can: m_can: hrtimer_callback(): rename to m_can_polling_timer()
      net: m_can: convert dev_{dbg,info,err} -> netdev_{dbg,info,err}
      can: m_can: m_can_interrupt_enable(): use m_can_write() instead of open coding it
      can: m_can: m_can_class_register(): remove error message in case devm_kzalloc() fails
      can: m_can: m_can_tx_submit(): remove unneeded sanity checks
      can: m_can: m_can_get_berr_counter(): don't wake up controller if interface is down

 drivers/net/can/m_can/m_can.c | 116 ++++++++++++++++++++----------------------
 drivers/net/can/m_can/m_can.h |   1 -
 2 files changed, 56 insertions(+), 61 deletions(-)
---
base-commit: 07fdad3a93756b872da7b53647715c48d0f4a2d0
change-id: 20250923-m_can-cleanups-d0436cd311a5

Best regards,
--  
Marc Kleine-Budde <mkl@pengutronix.de>
Re: [PATCH 0/7] can: m_can: various cleanups
Posted by Marc Kleine-Budde 2 months ago
On 08.10.2025 21:07:35, Marc Kleine-Budde wrote:
> While working on the m_can driver, I created several cleanups commits, make
> m_can_init_ram() static, rename hrtimer function, convert debugging and
> error output to netdev_(), replace open coded register write by
> m_can_write(), remove not needed error messages and sanity checks and don't
> wake up hte controller during m_can_get_berr_counter() if the interface is
> down.
> 
> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>

Applied to linux-can-next.

Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde          |
Embedded Linux                   | https://www.pengutronix.de |
Vertretung Nürnberg              | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-9   |
Re: [PATCH 0/7] can: m_can: various cleanups
Posted by Markus Schneider-Pargmann 1 month, 4 weeks ago
On Fri Oct 17, 2025 at 4:22 PM CEST, Marc Kleine-Budde wrote:
> On 08.10.2025 21:07:35, Marc Kleine-Budde wrote:
>> While working on the m_can driver, I created several cleanups commits, make
>> m_can_init_ram() static, rename hrtimer function, convert debugging and
>> error output to netdev_(), replace open coded register write by
>> m_can_write(), remove not needed error messages and sanity checks and don't
>> wake up hte controller during m_can_get_berr_counter() if the interface is
>> down.
>> 
>> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
>
> Applied to linux-can-next.
>
> Marc

Sorry, a bit late due to vacation. The patches look good to me.

Reviewed-by: Markus Schneider-Pargmann <msp@baylibre.com>

Best
Markus
Re: [PATCH 0/7] can: m_can: various cleanups
Posted by Marc Kleine-Budde 1 month, 4 weeks ago
On 21.10.2025 20:56:01, Markus Schneider-Pargmann wrote:
> On Fri Oct 17, 2025 at 4:22 PM CEST, Marc Kleine-Budde wrote:
> > On 08.10.2025 21:07:35, Marc Kleine-Budde wrote:
> >> While working on the m_can driver, I created several cleanups commits, make
> >> m_can_init_ram() static, rename hrtimer function, convert debugging and
> >> error output to netdev_(), replace open coded register write by
> >> m_can_write(), remove not needed error messages and sanity checks and don't
> >> wake up hte controller during m_can_get_berr_counter() if the interface is
> >> down.
> >> 
> >> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
> >
> > Applied to linux-can-next.
> >
> > Marc
> 
> Sorry, a bit late due to vacation. The patches look good to me.

Hope you all had a good vacation!

> Reviewed-by: Markus Schneider-Pargmann <msp@baylibre.com>

Thanks, it's already in net-next :)
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde          |
Embedded Linux                   | https://www.pengutronix.de |
Vertretung Nürnberg              | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-9   |