From nobody Fri Dec 19 08:56:31 2025 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7942D2C08C4 for ; Wed, 8 Oct 2025 19:08:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759950493; cv=none; b=dagBYM4g40BTZ3keZZIWg3GiTUJmE1evVqleoflaeHWXmv5ZqmnQk89sitlc4It8eA3oJzhXPomEpJ0lXgygpPFvJ+sj1u+nquP8dnF7lsJhyA5oKiLrwpo+5wOXDrQSg/lxOwlmTUM6m20laksYxVyOJAtSTtyLeyC9WOddBQ0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759950493; c=relaxed/simple; bh=vP4s1Ig2LIoMVqDjv/SxxsVEZ/CtWQv643jJiKhNioU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=FohEhWWTrwIkZcnRKOMJXs1+DzYnDdmart8XN93yCByshLVCXag052W4NYROzqRXxDuLIp/O6/FA37ImJI30iU43hMdv0sIgf82Aal25FtU10uf9/B9l46LPncq53YAWTTUNHSm+l4Q2HJiZyp5uHtWEeXwhBfV0nDE26HI5Gys= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1v6ZW4-0003RM-3P; Wed, 08 Oct 2025 21:08:00 +0200 Received: from moin.white.stw.pengutronix.de ([2a0a:edc0:0:b01:1d::7b] helo=bjornoya.blackshift.org) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1v6ZW3-002cDD-0P; Wed, 08 Oct 2025 21:07:59 +0200 Received: from hardanger.blackshift.org (p54b152ce.dip0.t-ipconnect.de [84.177.82.206]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: mkl-all@blackshift.org) by smtp.blackshift.org (Postfix) with ESMTPSA id C06BB4821F5; Wed, 08 Oct 2025 19:07:58 +0000 (UTC) From: Marc Kleine-Budde Date: Wed, 08 Oct 2025 21:07:36 +0200 Subject: [PATCH 1/7] can: m_can: m_can_init_ram(): make static Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251008-m_can-cleanups-v1-1-1784a18eaa84@pengutronix.de> References: <20251008-m_can-cleanups-v1-0-1784a18eaa84@pengutronix.de> In-Reply-To: <20251008-m_can-cleanups-v1-0-1784a18eaa84@pengutronix.de> To: Chandrasekar Ramakrishnan , Vincent Mailhol , Markus Schneider-Pargmann Cc: linux-can@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de, Marc Kleine-Budde X-Mailer: b4 0.15-dev-92513 X-Developer-Signature: v=1; a=openpgp-sha256; l=2773; i=mkl@pengutronix.de; h=from:subject:message-id; bh=vP4s1Ig2LIoMVqDjv/SxxsVEZ/CtWQv643jJiKhNioU=; b=owEBbQGS/pANAwAKAQx0Zd/5kJGcAcsmYgBo5raBb5T2wvfQ1oCBqI0RfW+fUyS8pY6lV7ltb fRAAHfW4yqJATMEAAEKAB0WIQSf+wzYr2eoX/wVbPMMdGXf+ZCRnAUCaOa2gQAKCRAMdGXf+ZCR nB79B/4rLZrI/61hb2gupzZRRmrliKS6LhPg5KEwq2qDewIb5ZM6JDXVGwdHM2hkvcYoPEG4lFm 8iMxOzBtCLswHuGb8qrfj4BBf7RZvxRANBPFs6vKKrUW/fOT3+rAQMpzeS0uSwV7I8PnRFAumYo uMBn/+UmGM+i3BLYh8BiX4vQf9LxHeDyPMBQc2MbP0pAsXMojbKs1eRrPvly2ArTOTHx8UgCYSe 6fBdZ11mg/6nJBez0SzP4qSdkmOBJc5zLQGj2xsoWrjETX/ZX6gZtF1R/UebkXzWfhzQYapjjwr 0sVB2jouLTuY4sj0vZVg7AoM7oleVB3LV5fKl4Ebus79PYxP X-Developer-Key: i=mkl@pengutronix.de; a=openpgp; fpr=C1400BA0B3989E6FBC7D5B5C2B5EE211C58AEA54 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: mkl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Since commit eaacfeaca7ad ("can: m_can: Call the RAM init directly from m_can_chip_config") m_can_init_ram() is not used outside of m_can.c. Mark as static and remove the EXPORT_SYMBOL_GPL(). Signed-off-by: Marc Kleine-Budde Reviewed-by: Markus Schneider-Pargmann --- drivers/net/can/m_can/m_can.c | 43 +++++++++++++++++++++------------------= ---- drivers/net/can/m_can/m_can.h | 1 - 2 files changed, 21 insertions(+), 23 deletions(-) diff --git a/drivers/net/can/m_can/m_can.c b/drivers/net/can/m_can/m_can.c index e1d725979685..03e2c431ffab 100644 --- a/drivers/net/can/m_can/m_can.c +++ b/drivers/net/can/m_can/m_can.c @@ -1368,6 +1368,27 @@ static const struct can_bittiming_const m_can_data_b= ittiming_const_31X =3D { .brp_inc =3D 1, }; =20 +static int m_can_init_ram(struct m_can_classdev *cdev) +{ + int end, i, start; + int err =3D 0; + + /* initialize the entire Message RAM in use to avoid possible + * ECC/parity checksum errors when reading an uninitialized buffer + */ + start =3D cdev->mcfg[MRAM_SIDF].off; + end =3D cdev->mcfg[MRAM_TXB].off + + cdev->mcfg[MRAM_TXB].num * TXB_ELEMENT_SIZE; + + for (i =3D start; i < end; i +=3D 4) { + err =3D m_can_fifo_write_no_off(cdev, i, 0x0); + if (err) + break; + } + + return err; +} + static int m_can_set_bittiming(struct net_device *dev) { struct m_can_classdev *cdev =3D netdev_priv(dev); @@ -2303,28 +2324,6 @@ static void m_can_of_parse_mram(struct m_can_classde= v *cdev, cdev->mcfg[MRAM_TXB].off, cdev->mcfg[MRAM_TXB].num); } =20 -int m_can_init_ram(struct m_can_classdev *cdev) -{ - int end, i, start; - int err =3D 0; - - /* initialize the entire Message RAM in use to avoid possible - * ECC/parity checksum errors when reading an uninitialized buffer - */ - start =3D cdev->mcfg[MRAM_SIDF].off; - end =3D cdev->mcfg[MRAM_TXB].off + - cdev->mcfg[MRAM_TXB].num * TXB_ELEMENT_SIZE; - - for (i =3D start; i < end; i +=3D 4) { - err =3D m_can_fifo_write_no_off(cdev, i, 0x0); - if (err) - break; - } - - return err; -} -EXPORT_SYMBOL_GPL(m_can_init_ram); - int m_can_class_get_clocks(struct m_can_classdev *cdev) { int ret =3D 0; diff --git a/drivers/net/can/m_can/m_can.h b/drivers/net/can/m_can/m_can.h index bd4746c63af3..46948c46d980 100644 --- a/drivers/net/can/m_can/m_can.h +++ b/drivers/net/can/m_can/m_can.h @@ -135,7 +135,6 @@ void m_can_class_free_dev(struct net_device *net); int m_can_class_register(struct m_can_classdev *cdev); void m_can_class_unregister(struct m_can_classdev *cdev); int m_can_class_get_clocks(struct m_can_classdev *cdev); -int m_can_init_ram(struct m_can_classdev *priv); int m_can_check_mram_cfg(struct m_can_classdev *cdev, u32 mram_max_size); =20 int m_can_class_suspend(struct device *dev); --=20 2.51.0 From nobody Fri Dec 19 08:56:31 2025 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C0D5D2C0F8C for ; Wed, 8 Oct 2025 19:08:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759950491; cv=none; b=AKraVo4hO78xDVyY4+1T8k9Ei7f932Z5uasmj8Xbtyb/tVO/wU4+JNcUxY19lxXGcdEb74Y+nwwb80h956QbLj64WGVY1+BZATBkM3d6Do8vnbIx4hQaPtu9ckvdp9AMF45AF2KpaMiIbz2Rxf1YJOvd3M2RzjUWd2iJyaUP55A= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759950491; c=relaxed/simple; bh=hqi5JhCiVO5Imio5JsBDzf7vDICuUe3IlNASWp18oaU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=id5dz1D2JZ408QyqmR2jnxdiw3AN5VWeXogdZlQM7q5mhMEM+xeWXSKHJO7x3xQhfUkT5GbWFw7V0Ag5fN4MAMwDTqxJl4iSMVitUTffoUURxWJ9nKT2O4tYWnFUWSXjFOV8y+zLkrDY5FMzybalmZZk/zxLvurNcUrzf7z7gmo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1v6ZW4-0003RN-3P; Wed, 08 Oct 2025 21:08:00 +0200 Received: from moin.white.stw.pengutronix.de ([2a0a:edc0:0:b01:1d::7b] helo=bjornoya.blackshift.org) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1v6ZW3-002cDE-0h; Wed, 08 Oct 2025 21:07:59 +0200 Received: from hardanger.blackshift.org (p54b152ce.dip0.t-ipconnect.de [84.177.82.206]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: mkl-all@blackshift.org) by smtp.blackshift.org (Postfix) with ESMTPSA id CCBA14821F6; Wed, 08 Oct 2025 19:07:58 +0000 (UTC) From: Marc Kleine-Budde Date: Wed, 08 Oct 2025 21:07:37 +0200 Subject: [PATCH 2/7] can: m_can: hrtimer_callback(): rename to m_can_polling_timer() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251008-m_can-cleanups-v1-2-1784a18eaa84@pengutronix.de> References: <20251008-m_can-cleanups-v1-0-1784a18eaa84@pengutronix.de> In-Reply-To: <20251008-m_can-cleanups-v1-0-1784a18eaa84@pengutronix.de> To: Chandrasekar Ramakrishnan , Vincent Mailhol , Markus Schneider-Pargmann Cc: linux-can@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de, Marc Kleine-Budde X-Mailer: b4 0.15-dev-92513 X-Developer-Signature: v=1; a=openpgp-sha256; l=1618; i=mkl@pengutronix.de; h=from:subject:message-id; bh=hqi5JhCiVO5Imio5JsBDzf7vDICuUe3IlNASWp18oaU=; b=owEBbQGS/pANAwAKAQx0Zd/5kJGcAcsmYgBo5raDR3E+j+0HDVBxRhTJiiBkDNHcdwF5uNQuo uzxaqjgREyJATMEAAEKAB0WIQSf+wzYr2eoX/wVbPMMdGXf+ZCRnAUCaOa2gwAKCRAMdGXf+ZCR nOLPCACaNY+xH357bLjeWSwLcA2n+QTXPlB7eaFMcXmipw3waqxeUbfQA2KNsLFsmrb1VKfUo5l isdrIdgCIYb9M2wN+/OPjsJKLiwKpTsJosryiOWHLqYgwxzzNnYZXzKH1jUiM6/UmY+usUNc1aC 4EJcqhk5PQZLFCwiohZtvofeawVGOjTtnKyxUlXfxJeW3Pez/eSwK/jMD9ywNQBDnqOWeHV9YdU yrXhlWSPILPzu3f5RjfY6w0EBUNU0IVqgTrU2jmblSy0W25TFsjINQGwHTniUUnE928puhdKwa0 +Jj+mh+RT+EPsf4GvQCApri4/RjjLUgymXeIuBvu/0rF/PFY X-Developer-Key: i=mkl@pengutronix.de; a=openpgp; fpr=C1400BA0B3989E6FBC7D5B5C2B5EE211C58AEA54 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: mkl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org The original use of struct m_can_classdev::hrtimer was to support polling for devices without IRQ, with the timer function called hrtimer_callback(). Commit 07f25091ca02 ("can: m_can: Implement receive coalescing") uses the hrtimer for software-supported IRQ coalescence, with the timer function called m_can_coalescing_timer(). To improve the readability of the driver, rename hrtimer_callback() to m_can_polling_timer(), which better describes the functionality. Signed-off-by: Marc Kleine-Budde Reviewed-by: Markus Schneider-Pargmann --- drivers/net/can/m_can/m_can.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/can/m_can/m_can.c b/drivers/net/can/m_can/m_can.c index 03e2c431ffab..d4aa46b236ea 100644 --- a/drivers/net/can/m_can/m_can.c +++ b/drivers/net/can/m_can/m_can.c @@ -2045,7 +2045,7 @@ static netdev_tx_t m_can_start_xmit(struct sk_buff *s= kb, return ret; } =20 -static enum hrtimer_restart hrtimer_callback(struct hrtimer *timer) +static enum hrtimer_restart m_can_polling_timer(struct hrtimer *timer) { struct m_can_classdev *cdev =3D container_of(timer, struct m_can_classdev, hrtimer); @@ -2418,7 +2418,7 @@ int m_can_class_register(struct m_can_classdev *cdev) =20 if (!cdev->net->irq) { dev_dbg(cdev->dev, "Polling enabled, initialize hrtimer"); - hrtimer_setup(&cdev->hrtimer, &hrtimer_callback, CLOCK_MONOTONIC, + hrtimer_setup(&cdev->hrtimer, m_can_polling_timer, CLOCK_MONOTONIC, HRTIMER_MODE_REL_PINNED); } else { hrtimer_setup(&cdev->hrtimer, m_can_coalescing_timer, CLOCK_MONOTONIC, --=20 2.51.0 From nobody Fri Dec 19 08:56:31 2025 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7B4912C11E2 for ; Wed, 8 Oct 2025 19:08:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759950492; cv=none; b=S1WwWUiDMk9fsuObF/iCEu6VCfm0CasWBoNE6V9szoAW4/MhvoZyGA2F/7mcURpgF1KYibhuCdg5kZa7ma9n4IODiNLw49J+KGcA+QC5UuORGhNZAjGNAyj2TRtskS3ilA79GE/DU2bRcYF3Pqr4hsJfyLul81JuGPEVzNPvgso= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759950492; c=relaxed/simple; bh=bBKRrEXx8JJJK8wlE7K+f3tK2jXUQ6RCR6KNQGtJDFs=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=nHGdEWFPhB2M2QvpcwGVTi3GwbIp3HECtEmmUj9/i72lpToa8CYKUQDGIAcLQU9Fy0XL29NczBMEUZfX5AlE9qOY83pNwPKNzBay/pxfwQZc5NwcTuLhL6aHggxK4xsursD9Jk4cNhsk0w3LShtxcTgG38pPP9ncqCGVktxcRh0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1v6ZW4-0003RO-3Q; Wed, 08 Oct 2025 21:08:00 +0200 Received: from moin.white.stw.pengutronix.de ([2a0a:edc0:0:b01:1d::7b] helo=bjornoya.blackshift.org) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1v6ZW3-002cDH-0v; Wed, 08 Oct 2025 21:07:59 +0200 Received: from hardanger.blackshift.org (p54b152ce.dip0.t-ipconnect.de [84.177.82.206]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: mkl-all@blackshift.org) by smtp.blackshift.org (Postfix) with ESMTPSA id D80794821F7; Wed, 08 Oct 2025 19:07:58 +0000 (UTC) From: Marc Kleine-Budde Date: Wed, 08 Oct 2025 21:07:38 +0200 Subject: [PATCH 3/7] net: m_can: convert dev_{dbg,info,err} -> netdev_{dbg,info,err} Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251008-m_can-cleanups-v1-3-1784a18eaa84@pengutronix.de> References: <20251008-m_can-cleanups-v1-0-1784a18eaa84@pengutronix.de> In-Reply-To: <20251008-m_can-cleanups-v1-0-1784a18eaa84@pengutronix.de> To: Chandrasekar Ramakrishnan , Vincent Mailhol , Markus Schneider-Pargmann Cc: linux-can@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de, Marc Kleine-Budde X-Mailer: b4 0.15-dev-92513 X-Developer-Signature: v=1; a=openpgp-sha256; l=6136; i=mkl@pengutronix.de; h=from:subject:message-id; bh=bBKRrEXx8JJJK8wlE7K+f3tK2jXUQ6RCR6KNQGtJDFs=; b=owEBbQGS/pANAwAKAQx0Zd/5kJGcAcsmYgBo5raFUKqQVuUoN2ac3mD3SI5wJ9jHVVUEKGWNj gR7HIcT8m6JATMEAAEKAB0WIQSf+wzYr2eoX/wVbPMMdGXf+ZCRnAUCaOa2hQAKCRAMdGXf+ZCR nLImCACCJMg+rxiEUcDeXu5hDgZnACQOaEqMFQ1vf3iHS3s43aQr5W7yBHn30AhycyTIXZUfvbh JX4j3PWnnjaMoLmNTFtXNj7njOYWR+Rfyj8OXfXz8jJj0cvy93NzQ3nYGPExOEp3vwX1ISrVPWW PrnaKJ06jX8o4xeXYmxFp4LiYkMlUzLv/HfIaot3yLPb13lA4h+u7nkU6Fr0HVjmSPLpyS8bJYy h0K7axWeYZJO+dRjzDpCVdiahyvgDsIyu5FrE9wBRhaw5X6KNqR1Cobg/andDQcUB311R47qwPQ 0YsquORm7PRsOXaCv+VAcOYFJwEQZJPQb0cQYYX9mMsBuaoI X-Developer-Key: i=mkl@pengutronix.de; a=openpgp; fpr=C1400BA0B3989E6FBC7D5B5C2B5EE211C58AEA54 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: mkl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org To ease debugging use the netdev_{dbg,info,err}() functions instead of dev_{dbg,info,err}. Signed-off-by: Marc Kleine-Budde Reviewed-by: Markus Schneider-Pargmann --- drivers/net/can/m_can/m_can.c | 54 +++++++++++++++++++++------------------= ---- 1 file changed, 27 insertions(+), 27 deletions(-) diff --git a/drivers/net/can/m_can/m_can.c b/drivers/net/can/m_can/m_can.c index d4aa46b236ea..4ca84f9a2734 100644 --- a/drivers/net/can/m_can/m_can.c +++ b/drivers/net/can/m_can/m_can.c @@ -386,8 +386,8 @@ static int m_can_cccr_update_bits(struct m_can_classdev= *cdev, u32 mask, u32 val size_t tries =3D 10; =20 if (!(mask & CCCR_INIT) && !(val_before & CCCR_INIT)) { - dev_err(cdev->dev, - "refusing to configure device when in normal mode\n"); + netdev_err(cdev->net, + "refusing to configure device when in normal mode\n"); return -EBUSY; } =20 @@ -469,7 +469,7 @@ static void m_can_coalescing_disable(struct m_can_class= dev *cdev) static inline void m_can_enable_all_interrupts(struct m_can_classdev *cdev) { if (!cdev->net->irq) { - dev_dbg(cdev->dev, "Start hrtimer\n"); + netdev_dbg(cdev->net, "Start hrtimer\n"); hrtimer_start(&cdev->hrtimer, ms_to_ktime(HRTIMER_POLL_INTERVAL_MS), HRTIMER_MODE_REL_PINNED); @@ -485,7 +485,7 @@ static inline void m_can_disable_all_interrupts(struct = m_can_classdev *cdev) m_can_write(cdev, M_CAN_ILE, 0x0); =20 if (!cdev->net->irq) { - dev_dbg(cdev->dev, "Stop hrtimer\n"); + netdev_dbg(cdev->net, "Stop hrtimer\n"); hrtimer_try_to_cancel(&cdev->hrtimer); } } @@ -1474,7 +1474,7 @@ static int m_can_chip_config(struct net_device *dev) =20 err =3D m_can_init_ram(cdev); if (err) { - dev_err(cdev->dev, "Message RAM configuration failed\n"); + netdev_err(dev, "Message RAM configuration failed\n"); return err; } =20 @@ -1704,7 +1704,7 @@ static int m_can_niso_supported(struct m_can_classdev= *cdev) /* Then clear the it again. */ ret =3D m_can_cccr_update_bits(cdev, CCCR_NISO, 0); if (ret) { - dev_err(cdev->dev, "failed to revert the NON-ISO bit in CCCR\n"); + netdev_err(cdev->net, "failed to revert the NON-ISO bit in CCCR\n"); return ret; } =20 @@ -1723,8 +1723,8 @@ static int m_can_dev_setup(struct m_can_classdev *cde= v) m_can_version =3D m_can_check_core_release(cdev); /* return if unsupported version */ if (!m_can_version) { - dev_err(cdev->dev, "Unsupported version number: %2d", - m_can_version); + netdev_err(cdev->net, "Unsupported version number: %2d", + m_can_version); return -EINVAL; } =20 @@ -1782,8 +1782,8 @@ static int m_can_dev_setup(struct m_can_classdev *cde= v) cdev->can.ctrlmode_supported |=3D CAN_CTRLMODE_FD_NON_ISO; break; default: - dev_err(cdev->dev, "Unsupported version number: %2d", - cdev->version); + netdev_err(cdev->net, "Unsupported version number: %2d", + cdev->version); return -EINVAL; } =20 @@ -2277,8 +2277,8 @@ int m_can_check_mram_cfg(struct m_can_classdev *cdev,= u32 mram_max_size) total_size =3D cdev->mcfg[MRAM_TXB].off - cdev->mcfg[MRAM_SIDF].off + cdev->mcfg[MRAM_TXB].num * TXB_ELEMENT_SIZE; if (total_size > mram_max_size) { - dev_err(cdev->dev, "Total size of mram config(%u) exceeds mram(%u)\n", - total_size, mram_max_size); + netdev_err(cdev->net, "Total size of mram config(%u) exceeds mram(%u)\n", + total_size, mram_max_size); return -EINVAL; } =20 @@ -2313,15 +2313,15 @@ static void m_can_of_parse_mram(struct m_can_classd= ev *cdev, cdev->mcfg[MRAM_TXB].num =3D mram_config_vals[7] & FIELD_MAX(TXBC_NDTB_MASK); =20 - dev_dbg(cdev->dev, - "sidf 0x%x %d xidf 0x%x %d rxf0 0x%x %d rxf1 0x%x %d rxb 0x%x %d txe 0x%= x %d txb 0x%x %d\n", - cdev->mcfg[MRAM_SIDF].off, cdev->mcfg[MRAM_SIDF].num, - cdev->mcfg[MRAM_XIDF].off, cdev->mcfg[MRAM_XIDF].num, - cdev->mcfg[MRAM_RXF0].off, cdev->mcfg[MRAM_RXF0].num, - cdev->mcfg[MRAM_RXF1].off, cdev->mcfg[MRAM_RXF1].num, - cdev->mcfg[MRAM_RXB].off, cdev->mcfg[MRAM_RXB].num, - cdev->mcfg[MRAM_TXE].off, cdev->mcfg[MRAM_TXE].num, - cdev->mcfg[MRAM_TXB].off, cdev->mcfg[MRAM_TXB].num); + netdev_dbg(cdev->net, + "sidf 0x%x %d xidf 0x%x %d rxf0 0x%x %d rxf1 0x%x %d rxb 0x%x %d txe = 0x%x %d txb 0x%x %d\n", + cdev->mcfg[MRAM_SIDF].off, cdev->mcfg[MRAM_SIDF].num, + cdev->mcfg[MRAM_XIDF].off, cdev->mcfg[MRAM_XIDF].num, + cdev->mcfg[MRAM_RXF0].off, cdev->mcfg[MRAM_RXF0].num, + cdev->mcfg[MRAM_RXF1].off, cdev->mcfg[MRAM_RXF1].num, + cdev->mcfg[MRAM_RXB].off, cdev->mcfg[MRAM_RXB].num, + cdev->mcfg[MRAM_TXE].off, cdev->mcfg[MRAM_TXE].num, + cdev->mcfg[MRAM_TXB].off, cdev->mcfg[MRAM_TXB].num); } =20 int m_can_class_get_clocks(struct m_can_classdev *cdev) @@ -2332,7 +2332,7 @@ int m_can_class_get_clocks(struct m_can_classdev *cde= v) cdev->cclk =3D devm_clk_get(cdev->dev, "cclk"); =20 if (IS_ERR(cdev->hclk) || IS_ERR(cdev->cclk)) { - dev_err(cdev->dev, "no clock found\n"); + netdev_err(cdev->net, "no clock found\n"); ret =3D -ENODEV; } =20 @@ -2417,7 +2417,7 @@ int m_can_class_register(struct m_can_classdev *cdev) } =20 if (!cdev->net->irq) { - dev_dbg(cdev->dev, "Polling enabled, initialize hrtimer"); + netdev_dbg(cdev->net, "Polling enabled, initialize hrtimer"); hrtimer_setup(&cdev->hrtimer, m_can_polling_timer, CLOCK_MONOTONIC, HRTIMER_MODE_REL_PINNED); } else { @@ -2431,15 +2431,15 @@ int m_can_class_register(struct m_can_classdev *cde= v) =20 ret =3D register_m_can_dev(cdev); if (ret) { - dev_err(cdev->dev, "registering %s failed (err=3D%d)\n", - cdev->net->name, ret); + netdev_err(cdev->net, "registering %s failed (err=3D%d)\n", + cdev->net->name, ret); goto rx_offload_del; } =20 of_can_transceiver(cdev->net); =20 - dev_info(cdev->dev, "%s device registered (irq=3D%d, version=3D%d)\n", - KBUILD_MODNAME, cdev->net->irq, cdev->version); + netdev_info(cdev->net, "device registered (irq=3D%d, version=3D%d)\n", + cdev->net->irq, cdev->version); =20 /* Probe finished * Stop clocks. They will be reactivated once the M_CAN device is opened --=20 2.51.0 From nobody Fri Dec 19 08:56:31 2025 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6B9462C11D0 for ; Wed, 8 Oct 2025 19:08:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759950493; cv=none; b=Wld1Z+khrBNsPLqqnZCXbjDUZmYx7IBunH/2Hg9VwzQa378EbIVbdanlYwiUguDQBLbI4pm3awtxddrm0q2wYqsIW1PdmUTNnoBygYOkvhgShIfc9nDfHZbZHUViyaISvVaH+ID5LbcOHrKUmh5/edl6sUwLV/KZKLp7GuV6BHw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759950493; c=relaxed/simple; bh=QBGzxRQ1kuWEuxxcTY9fXeD4sD1cfK6LM5d4L2J0Cc8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Fo/rthvQp9aLVbcS8zIy6qv3Go+U4E4AEkmi3zUePhxO+ByVANovI3N0iwP09ztZAAzYYar/knO7/YDfrAiQ+pOq/GM9tTpwJKEaLay8EYRwwaDnSuDNRvRbe3giNGrw+B2jvbOdXaoTtUf0fn8+RVOrWkrd9FXIYLbG6T+tres= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1v6ZW4-0003RP-3Q; Wed, 08 Oct 2025 21:08:00 +0200 Received: from moin.white.stw.pengutronix.de ([2a0a:edc0:0:b01:1d::7b] helo=bjornoya.blackshift.org) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1v6ZW3-002cDI-15; Wed, 08 Oct 2025 21:07:59 +0200 Received: from hardanger.blackshift.org (p54b152ce.dip0.t-ipconnect.de [84.177.82.206]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: mkl-all@blackshift.org) by smtp.blackshift.org (Postfix) with ESMTPSA id E49324821F8; Wed, 08 Oct 2025 19:07:58 +0000 (UTC) From: Marc Kleine-Budde Date: Wed, 08 Oct 2025 21:07:39 +0200 Subject: [PATCH 4/7] can: m_can: m_can_interrupt_enable(): use m_can_write() instead of open coding it Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251008-m_can-cleanups-v1-4-1784a18eaa84@pengutronix.de> References: <20251008-m_can-cleanups-v1-0-1784a18eaa84@pengutronix.de> In-Reply-To: <20251008-m_can-cleanups-v1-0-1784a18eaa84@pengutronix.de> To: Chandrasekar Ramakrishnan , Vincent Mailhol , Markus Schneider-Pargmann Cc: linux-can@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de, Marc Kleine-Budde X-Mailer: b4 0.15-dev-92513 X-Developer-Signature: v=1; a=openpgp-sha256; l=746; i=mkl@pengutronix.de; h=from:subject:message-id; bh=QBGzxRQ1kuWEuxxcTY9fXeD4sD1cfK6LM5d4L2J0Cc8=; b=owEBbQGS/pANAwAKAQx0Zd/5kJGcAcsmYgBo5raHCjOtH30KrpSIx3wMjdkOYa6Cc3BMiz8XR 67qrDimY5CJATMEAAEKAB0WIQSf+wzYr2eoX/wVbPMMdGXf+ZCRnAUCaOa2hwAKCRAMdGXf+ZCR nM34B/9Kc1JXb6+rle+Ey9GsFUBnfzrZ6DLQo9QsafynnD5FO5CdVZ8qaF/R/Y6j4/mF7/fAenH O8FA4GKT7SvCEX1A95BAQrsim32BPhtyI8FmYWSC2DGa7MhbqRUzsq9OVSWuJ1znQRNEtQf7lCm 1V3hq+RQZ9IDpxTHXzNrM1/0cAVpRe02w1i7OiS4uB2kLrPT/kgx8Ci2ASUwW+IwT+gOPp2lTSy 9IwKnR0onKLpS6Ch0C247suP37u1BvDNh/VdrDW7QEI/hcfwdaEjx7pUhXZ1oKTmSFohDY/i9iK Yxajb5eDu02hzYT8P/Nt3RQLPekptjkdkODQ1T572sHehPID X-Developer-Key: i=mkl@pengutronix.de; a=openpgp; fpr=C1400BA0B3989E6FBC7D5B5C2B5EE211C58AEA54 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: mkl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org As everywhere else in the driver, use m_can_write() instead of open coding it. Signed-off-by: Marc Kleine-Budde Reviewed-by: Markus Schneider-Pargmann --- drivers/net/can/m_can/m_can.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/can/m_can/m_can.c b/drivers/net/can/m_can/m_can.c index 4ca84f9a2734..4cb4eee3602a 100644 --- a/drivers/net/can/m_can/m_can.c +++ b/drivers/net/can/m_can/m_can.c @@ -451,7 +451,7 @@ static void m_can_interrupt_enable(struct m_can_classde= v *cdev, u32 interrupts) { if (cdev->active_interrupts =3D=3D interrupts) return; - cdev->ops->write_reg(cdev, M_CAN_IE, interrupts); + m_can_write(cdev, M_CAN_IE, interrupts); cdev->active_interrupts =3D interrupts; } =20 --=20 2.51.0 From nobody Fri Dec 19 08:56:31 2025 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C25582C0F8F for ; Wed, 8 Oct 2025 19:08:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759950490; cv=none; b=mRnKAkr+kGQwbQmAVdRp7106Gj+l0unlB9+OWtKbjvaxEEGXo7v4xaSvwPCAVjymt419a9iHlCqLYrTouKcSU+fUpo1cBEFxrOICkA5YAsBiWGp+AqGdi/eVIlg/kbNuCnJ2Y4tgPZCy9eSHlVq21NOfwuztMQCRt33LHNsNrwA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759950490; c=relaxed/simple; bh=o4Y8rgbRUuDMvNZrs1nSGq+Y96elsEU9l3xfUMYO850=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=RAnRosvXlvFdnGdbDS8dSE+bTBZaPEfqIB2qMQnDsmRoHJFyZpLIIsDeUOQgVhHyElh+pRabkg8rXrx//5t8dGBkp+EpHs2NzGsqUIlNIitaeXAEbececmx4ei4sPhOuFV+JCFNjAYydDj1ZZD/hRNscM1tkUzu0ZZc2yMxwZhc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1v6ZW4-0003RQ-3Q; Wed, 08 Oct 2025 21:08:00 +0200 Received: from moin.white.stw.pengutronix.de ([2a0a:edc0:0:b01:1d::7b] helo=bjornoya.blackshift.org) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1v6ZW3-002cDL-1I; Wed, 08 Oct 2025 21:07:59 +0200 Received: from hardanger.blackshift.org (p54b152ce.dip0.t-ipconnect.de [84.177.82.206]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: mkl-all@blackshift.org) by smtp.blackshift.org (Postfix) with ESMTPSA id F30444821F9; Wed, 08 Oct 2025 19:07:58 +0000 (UTC) From: Marc Kleine-Budde Date: Wed, 08 Oct 2025 21:07:40 +0200 Subject: [PATCH 5/7] can: m_can: m_can_class_register(): remove error message in case devm_kzalloc() fails Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251008-m_can-cleanups-v1-5-1784a18eaa84@pengutronix.de> References: <20251008-m_can-cleanups-v1-0-1784a18eaa84@pengutronix.de> In-Reply-To: <20251008-m_can-cleanups-v1-0-1784a18eaa84@pengutronix.de> To: Chandrasekar Ramakrishnan , Vincent Mailhol , Markus Schneider-Pargmann Cc: linux-can@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de, Marc Kleine-Budde X-Mailer: b4 0.15-dev-92513 X-Developer-Signature: v=1; a=openpgp-sha256; l=861; i=mkl@pengutronix.de; h=from:subject:message-id; bh=o4Y8rgbRUuDMvNZrs1nSGq+Y96elsEU9l3xfUMYO850=; b=owEBbQGS/pANAwAKAQx0Zd/5kJGcAcsmYgBo5raJI4S0e2shCK90HajW+PRixqOmB2tDH6f/q 4RJS8qdSiKJATMEAAEKAB0WIQSf+wzYr2eoX/wVbPMMdGXf+ZCRnAUCaOa2iQAKCRAMdGXf+ZCR nAmnB/9Qbg9EF9iG/4cC9DBtFbsRK6r9QtaYeNVgNU17juoAHeHNgkgw2WsQc21h4oaj7a6gUIX pDUKRkSoLQAwfYfWLB69KW4kMOVxp+hEN64+WoLBSvPVV63ZQ4OefwrmhckVViXzaAaNzyeyq2k 8UG2n/Ig/Qn+NJ0BMNLtX8YcWPuOhNrWdS0D7Go9+QS4oi1c3g/PMKDk2UwCTdPA9udwzjbSi03 9mHwTGwBeMCvw1z4RAYzSR1tVjogUSQMytVY7wytzF9BSDGkt3tZNdTwMioQQRdA083VTljAptM gWrpd9gxqFy+8e3sX9PTwNgyKY/aX5g/1fxbeN5P3DrSZq1Y X-Developer-Key: i=mkl@pengutronix.de; a=openpgp; fpr=C1400BA0B3989E6FBC7D5B5C2B5EE211C58AEA54 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: mkl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org If devm_kzalloc() fails, it already outputs an error message. Remove the error message from m_can_class_register() accordingly. Signed-off-by: Marc Kleine-Budde Reviewed-by: Markus Schneider-Pargmann --- drivers/net/can/m_can/m_can.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net/can/m_can/m_can.c b/drivers/net/can/m_can/m_can.c index 4cb4eee3602a..92a4feec4174 100644 --- a/drivers/net/can/m_can/m_can.c +++ b/drivers/net/can/m_can/m_can.c @@ -2399,10 +2399,8 @@ int m_can_class_register(struct m_can_classdev *cdev) devm_kzalloc(cdev->dev, cdev->tx_fifo_size * sizeof(*cdev->tx_ops), GFP_KERNEL); - if (!cdev->tx_ops) { - dev_err(cdev->dev, "Failed to allocate tx_ops for workqueue\n"); + if (!cdev->tx_ops) return -ENOMEM; - } } =20 ret =3D m_can_clk_start(cdev); --=20 2.51.0 From nobody Fri Dec 19 08:56:31 2025 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1C6332C0F96 for ; Wed, 8 Oct 2025 19:08:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759950491; cv=none; b=k9JLqiNI5ttBSkwZavPNDdcckt7gDAu4Zx03dQfxaGjGFHdxf+RnP4WY38zqc/DxtEcoHcmtYxva8pEQTUe6QdsH9ZkVYcG8lwOYnuihjpZLIalktKklEAsLv7JdhI0MoVe59W7z7CicIG4qkrtHAwQrqrC3yWzM2xe+x4G3He8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759950491; c=relaxed/simple; bh=RlNuKAoeu17R9ejquc+WYmEScR18yCzwYNcv7iVDAyg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=i4hyyd24ZhqvXDBq344+9ERaEdIbyfyXfHP4yFHVAYgGg5rP+yEAUadHVnRPriUaBdHTfOpwiSE+GMkGv6ZTFhP/O6zMtFjIN20GayY/YJL/I/GbtAuzDE9urK4S89LwslK7qk+Rr5Sxk41mODy7VWQj1DCTlxfy1MWZUinpD9o= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1v6ZW4-0003RR-3P; Wed, 08 Oct 2025 21:08:00 +0200 Received: from moin.white.stw.pengutronix.de ([2a0a:edc0:0:b01:1d::7b] helo=bjornoya.blackshift.org) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1v6ZW3-002cDM-1L; Wed, 08 Oct 2025 21:07:59 +0200 Received: from hardanger.blackshift.org (p54b152ce.dip0.t-ipconnect.de [84.177.82.206]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: mkl-all@blackshift.org) by smtp.blackshift.org (Postfix) with ESMTPSA id 0F5164821FA; Wed, 08 Oct 2025 19:07:59 +0000 (UTC) From: Marc Kleine-Budde Date: Wed, 08 Oct 2025 21:07:41 +0200 Subject: [PATCH 6/7] can: m_can: m_can_tx_submit(): remove unneeded sanity checks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251008-m_can-cleanups-v1-6-1784a18eaa84@pengutronix.de> References: <20251008-m_can-cleanups-v1-0-1784a18eaa84@pengutronix.de> In-Reply-To: <20251008-m_can-cleanups-v1-0-1784a18eaa84@pengutronix.de> To: Chandrasekar Ramakrishnan , Vincent Mailhol , Markus Schneider-Pargmann Cc: linux-can@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de, Marc Kleine-Budde X-Mailer: b4 0.15-dev-92513 X-Developer-Signature: v=1; a=openpgp-sha256; l=773; i=mkl@pengutronix.de; h=from:subject:message-id; bh=RlNuKAoeu17R9ejquc+WYmEScR18yCzwYNcv7iVDAyg=; b=owEBbQGS/pANAwAKAQx0Zd/5kJGcAcsmYgBo5raKLuCCiJLnkdusfwK/8PDZvqtR3TN671csa 5IoIdRtUV6JATMEAAEKAB0WIQSf+wzYr2eoX/wVbPMMdGXf+ZCRnAUCaOa2igAKCRAMdGXf+ZCR nCDHB/9jYDnguJAFGqln3U6/2Bd0V1SwzZUWJ+ahZGXN1RcxrVT4kZwQEy74SjWZxYa+eYP50aQ 03ttLkCGvwU62qc661dnSiB0Qi55YaenFJ1ZBke9Lv6rhB0J6CB8ze7g7aM9DE9kH12v7GjybjW wNrWDT2pHZgK5bjphGkNTOkwEoAL6ucX+Pe/eeFy/YqYKfE1gNkPTia6uWuy1E0UXhu7ugwy52E 8n3XI4FuRN0ylL7BP+3VK7p1p2m4GskeBV/ckBYvD3y3WY8njszupxglF07Y4C4Q8lwTyyIuYVZ VId7k1M8BjIf3CWczYdJTctQWXZi5QnhCtbsxtzdtt13l1+5 X-Developer-Key: i=mkl@pengutronix.de; a=openpgp; fpr=C1400BA0B3989E6FBC7D5B5C2B5EE211C58AEA54 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: mkl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org m_can_tx_submit() is only called for peripheral devices. So remove the sanity check. Signed-off-by: Marc Kleine-Budde Reviewed-by: Markus Schneider-Pargmann --- drivers/net/can/m_can/m_can.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/net/can/m_can/m_can.c b/drivers/net/can/m_can/m_can.c index 92a4feec4174..4451ea750b74 100644 --- a/drivers/net/can/m_can/m_can.c +++ b/drivers/net/can/m_can/m_can.c @@ -1960,11 +1960,6 @@ static netdev_tx_t m_can_tx_handler(struct m_can_cla= ssdev *cdev, =20 static void m_can_tx_submit(struct m_can_classdev *cdev) { - if (cdev->version =3D=3D 30) - return; - if (!cdev->is_peripheral) - return; - m_can_write(cdev, M_CAN_TXBAR, cdev->tx_peripheral_submit); cdev->tx_peripheral_submit =3D 0; } --=20 2.51.0 From nobody Fri Dec 19 08:56:31 2025 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A8B7B2C1580 for ; Wed, 8 Oct 2025 19:08:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759950492; cv=none; b=Si0CdfT7E0qcbCtRw2iicHeZxGdqDf/jQsntfhFcwPyfmCWGCapXyV7woWZQG9EyZt1vRTVNT9T3H44DZNppWBtjOgMSbgQOToxWI3ZRNDLFBR9suVr4aGyn395j803auaMya+mzqC4eYXQeXCJF5LcY09XyfbUQ6/xwL8ymuh4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759950492; c=relaxed/simple; bh=pSIg4w43P6DHspql22I5oY6RYYzVHVSRk26zpHsOzzs=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=oNVfkfXJXeX5S99YjF8EcRrS2AJUtOeH1q37lXYf1ghjfNBornYqzEUyQxVnulD4QvyfXZq1VZCZ3oy4YijBEZrvdSdg1miC2Q7/xQ1223y5bSeUDAv5RoodR9akKs8ypCGA0WNWByPd2gUfcYz+yktn4Jd5BfgEiAwks6C9wWM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1v6ZW4-0003RS-3P; Wed, 08 Oct 2025 21:08:00 +0200 Received: from moin.white.stw.pengutronix.de ([2a0a:edc0:0:b01:1d::7b] helo=bjornoya.blackshift.org) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1v6ZW3-002cDO-1S; Wed, 08 Oct 2025 21:07:59 +0200 Received: from hardanger.blackshift.org (p54b152ce.dip0.t-ipconnect.de [84.177.82.206]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: mkl-all@blackshift.org) by smtp.blackshift.org (Postfix) with ESMTPSA id 1C3EE4821FB; Wed, 08 Oct 2025 19:07:59 +0000 (UTC) From: Marc Kleine-Budde Date: Wed, 08 Oct 2025 21:07:42 +0200 Subject: [PATCH 7/7] can: m_can: m_can_get_berr_counter(): don't wake up controller if interface is down Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251008-m_can-cleanups-v1-7-1784a18eaa84@pengutronix.de> References: <20251008-m_can-cleanups-v1-0-1784a18eaa84@pengutronix.de> In-Reply-To: <20251008-m_can-cleanups-v1-0-1784a18eaa84@pengutronix.de> To: Chandrasekar Ramakrishnan , Vincent Mailhol , Markus Schneider-Pargmann Cc: linux-can@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de, Marc Kleine-Budde X-Mailer: b4 0.15-dev-92513 X-Developer-Signature: v=1; a=openpgp-sha256; l=951; i=mkl@pengutronix.de; h=from:subject:message-id; bh=pSIg4w43P6DHspql22I5oY6RYYzVHVSRk26zpHsOzzs=; b=owEBbQGS/pANAwAKAQx0Zd/5kJGcAcsmYgBo5raMPX96GJKRD76fHRQ79PrAoU4fLmz4zBZXS NTytYnnMrKJATMEAAEKAB0WIQSf+wzYr2eoX/wVbPMMdGXf+ZCRnAUCaOa2jAAKCRAMdGXf+ZCR nHNiCACZv/pgKj5utZB5oUUW+J4a3g+ye8cwvOLN+eIomr7xKH8ur+N0oQHXJgxRnpySZM0FsYO YJz+1VA3ekASBxO5HEUo/PnZmryLchOjY7IMSOZOR0+q1YAwE7ym4CTzLAuzRofptfSqXtPHOaR JL3+16DWurdTpJhLJxsvV1HD+KkAOHn7IB1AhNyANY1dKF9Er6HQxazia6i3ZlQ9w4Ul0qhdoyp d4lIPVk7BWuU/c05IU8VXDTJ5RVKfFPOMRUgIArXnaUpErK1o0h6qySiI2wlItovn/IWe1tbXwK /fN5JUpyZYHcdVbR4a/Je5OFKxyWNOTZg8ECpceun9pE8DRr X-Developer-Key: i=mkl@pengutronix.de; a=openpgp; fpr=C1400BA0B3989E6FBC7D5B5C2B5EE211C58AEA54 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: mkl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org If the interface is down, the CAN controller might be powered down, the clock disabled, and/or it's external reset asserted. Don't wake up the controller to read the CAN bus error counters, if the interface is down. Reviewed-by: Markus Schneider-Pargmann Signed-off-by: Marc Kleine-Budde --- drivers/net/can/m_can/m_can.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/can/m_can/m_can.c b/drivers/net/can/m_can/m_can.c index 4451ea750b74..0b622248e229 100644 --- a/drivers/net/can/m_can/m_can.c +++ b/drivers/net/can/m_can/m_can.c @@ -790,6 +790,10 @@ static int m_can_get_berr_counter(const struct net_dev= ice *dev, struct m_can_classdev *cdev =3D netdev_priv(dev); int err; =20 + /* Avoid waking up the controller if the interface is down */ + if (!(dev->flags & IFF_UP)) + return 0; + err =3D m_can_clk_start(cdev); if (err) return err; --=20 2.51.0