Fix to EOPNOTSUPP double conversion in ioctl_setflags()

[PATCH 0/2] Fix to EOPNOTSUPP double conversion in ioctl_setflags()

Posted by Andrey Albershteyn 4 months ago

Revert original double conversion patch from ENOIOCTLCMD to EOPNOSUPP for
vfs_fileattr_get and vfs_fileattr_set. Instead, convert ENOIOCTLCMD only
where necessary.

To: linux-api@vger.kernel.org
To: linux-fsdevel@vger.kernel.org
To: linux-kernel@vger.kernel.org
To: linux-xfs@vger.kernel.org,
Cc: "Jan Kara" <jack@suse.cz>
Cc: "Jiri Slaby" <jirislaby@kernel.org>
Cc: "Christian Brauner" <brauner@kernel.org>
Cc: "Arnd Bergmann" <arnd@arndb.de>

Signed-off-by: Andrey Albershteyn <aalbersh@kernel.org>
---
Andrey Albershteyn (2):
      Revert "fs: make vfs_fileattr_[get|set] return -EOPNOTSUPP"
      fs: return EOPNOTSUPP from file_setattr/file_getattr syscalls

 fs/file_attr.c         | 16 ++++++----------
 fs/fuse/ioctl.c        |  4 ----
 fs/overlayfs/copy_up.c |  2 +-
 fs/overlayfs/inode.c   |  5 ++++-
 4 files changed, 11 insertions(+), 16 deletions(-)
---
base-commit: e5f0a698b34ed76002dc5cff3804a61c80233a7a
change-id: 20251007-eopnosupp-fix-d2f30fd7d873

Best regards,
--  
Andrey Albershteyn <aalbersh@kernel.org>

Re: [PATCH 0/2] Fix to EOPNOTSUPP double conversion in ioctl_setflags()

Posted by Christian Brauner 4 months ago

On Wed, 08 Oct 2025 14:44:16 +0200, Andrey Albershteyn wrote:
> Revert original double conversion patch from ENOIOCTLCMD to EOPNOSUPP for
> vfs_fileattr_get and vfs_fileattr_set. Instead, convert ENOIOCTLCMD only
> where necessary.
> 
> To: linux-api@vger.kernel.org
> To: linux-fsdevel@vger.kernel.org
> To: linux-kernel@vger.kernel.org
> To: linux-xfs@vger.kernel.org,
> Cc: "Jan Kara" <jack@suse.cz>
> Cc: "Jiri Slaby" <jirislaby@kernel.org>
> Cc: "Christian Brauner" <brauner@kernel.org>
> Cc: "Arnd Bergmann" <arnd@arndb.de>
> 
> [...]

Applied to the vfs.fixes branch of the vfs/vfs.git tree.
Patches in the vfs.fixes branch should appear in linux-next soon.

Please report any outstanding bugs that were missed during review in a
new review to the original patch series allowing us to drop it.

It's encouraged to provide Acked-bys and Reviewed-bys even though the
patch has now been applied. If possible patch trailers will be updated.

Note that commit hashes shown below are subject to change due to rebase,
trailer updates or similar. If in doubt, please check the listed branch.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git
branch: vfs.fixes

[1/2] Revert "fs: make vfs_fileattr_[get|set] return -EOPNOTSUPP"
      https://git.kernel.org/vfs/vfs/c/4dd5b5ac089b
[2/2] fs: return EOPNOTSUPP from file_setattr/file_getattr syscalls
      https://git.kernel.org/vfs/vfs/c/d90ad28e8aa4