From nobody Sun Feb 8 02:22:18 2026 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 84024256C9F for ; Wed, 8 Oct 2025 12:44:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759927470; cv=none; b=fwjuEm0KWfwKEHH6tjKAKeA4ujg/oN4/VdUKs+ylW/+XDPNTW1V/UvA/ldmKklbgHeFQu7pMkQkk3n8LOB+YmqSqFnvxzapISqbyFshUNuJsRkwZr7zRSmB0sckaqHSz+iICU+f/Obbzia26gzwqDDaN6WGc8hS0KPV3/U0/KvM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759927470; c=relaxed/simple; bh=Rm08DYj+mslMBXfYK22sr3gFPY8mTjkKzp5uV40xej8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=gEocdt/u1WYb9f1ljSZlZ8bu9AgfmjqydSqZmYiiV7BIBb6appPnQxbvseAc25F3rblK0tj3kh9DFYnXNMMASfdEC4m/J9IrL4meeyTvFhNTzHbWJ3fdWOC3SEI7IISCpeNdOYHbMfhiImWQqWkORqXFalGpUZT1k91SO3nkZfA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=VA1F+bAI; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="VA1F+bAI" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1759927467; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KJHcjC4e0kTTUJxfi1ENkUBMalkao76BFoBvjc28PQw=; b=VA1F+bAIzBU0LF1kwk5BIWcV9I9DXqV6DZnn15yQN0b8d6S0V3CjqmLEQ4pyKEQoa3+nVE MzhbRO4dOUrZfMXuZZfJmc/Er4IDLqt2Wde1/gu+FvGGgN5vC7ZPtX8XtdYnMRxITq/IMp hu1jwLJ0sJIuxK0dsrbW6E1aMmOwXUA= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-121-cZ7jrFIlMlCRXfyltrIQ6g-1; Wed, 08 Oct 2025 08:44:25 -0400 X-MC-Unique: cZ7jrFIlMlCRXfyltrIQ6g-1 X-Mimecast-MFC-AGG-ID: cZ7jrFIlMlCRXfyltrIQ6g_1759927464 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-46e377d8c80so26730915e9.3 for ; Wed, 08 Oct 2025 05:44:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759927464; x=1760532264; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KJHcjC4e0kTTUJxfi1ENkUBMalkao76BFoBvjc28PQw=; b=va2crShvWEJd4Tc9vaI5L3SIbK99K9yGCo3oYcE59zS+Yc0VnYfosvV0SuO/IhyGQz 9dXCk2gPhc/skfwwX3V3lusOm4C+R5hIITRGLHwSVWS0zXMyu6jyDM6bpEMSwWdkBF5z pywaxr/eCQsfa9DWmCjOYYqBpt6cbb7LyduKEIn+HxREYKC1Gz46U93i8EriIP4JyJCS Y6ka6qNj3ttD1D/SAFfMBBLRyafByT1dG6HGoq9m+UnGLTrA79XCIHQqq7sLY55Di7Bz f3DL6Y4bXGLBkqnj6FI28TrbtpNfNBjsmr0cltUKu80jVN9QCbAxh8lEXGMwylaWedGu /1FA== X-Forwarded-Encrypted: i=1; AJvYcCX/ybFpY07tTF+KaBOrmFhfDKXcNEVGjk5p+nqzTYEM/iRDMQp6yfkAm3IBwGshtynwSNklycU2R2Ovj2Y=@vger.kernel.org X-Gm-Message-State: AOJu0Yzl6raPvqO5xrh9kNyU7bOWwoVsoPWLfd8JeR09nknXKpMeCRIL Ke0QR1AcoWlYybJKtCNOoRnUn9R9KRstkRuCe5liI/PejZE6hIQlbGw2tTJHahPnQpg6G/kSHtq Jc8TvYVXGZkCpuSxpu7yWgNbIcleYo6mDYG44d1AWSLV4b6418GWZDztmVliLtl/Q X-Gm-Gg: ASbGncssmqxeLv2zO0F1gEdWaFxaJM7T2PurgWQXcnOay1kLAPndEvRPsYmMZdScM0z ovjVlrUw7cmzXWzEkKstUyge4xMb91xE4gbvIqTGoXpBo79f3z19dQGmnBRIMLGcm3KWlj0rHzk pfDXAlcwU514maOsOCJ+5VAhPaQQ7cZ4Gg94U4I9ikTJe4JptpZlZo09bjRnwZMkXZC3rsV2tyx G4P1ai5gaLnKRAUO36ZEPlGqaWSnhf5umevLr0sMNDKmehL6ym4431gLgvKCs7mVUWwuGXN7fof B3F12HCL10d9bvgmiaxV82cN8iFoqd5DoAw+/kXGfqW8TdmplGCgPhx6LPIRWomtZ2pockWf X-Received: by 2002:a05:600c:c162:b0:46e:5a5b:db60 with SMTP id 5b1f17b1804b1-46fa9affbe0mr27133225e9.31.1759927463753; Wed, 08 Oct 2025 05:44:23 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEIehDZZgMkQNeYi+w3tuRSVQUqwra7bvm5DmMYJ0xx+K2Mzbu8NI1V3CwLhhi423n/xgnFLQ== X-Received: by 2002:a05:600c:c162:b0:46e:5a5b:db60 with SMTP id 5b1f17b1804b1-46fa9affbe0mr27132925e9.31.1759927463345; Wed, 08 Oct 2025 05:44:23 -0700 (PDT) Received: from [127.0.0.2] (ip-217-030-074-039.aim-net.cz. [217.30.74.39]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-46fab3d438fsm13918765e9.2.2025.10.08.05.44.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Oct 2025 05:44:22 -0700 (PDT) From: Andrey Albershteyn X-Google-Original-From: Andrey Albershteyn Date: Wed, 08 Oct 2025 14:44:17 +0200 Subject: [PATCH 1/2] Revert "fs: make vfs_fileattr_[get|set] return -EOPNOTSUPP" Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251008-eopnosupp-fix-v1-1-5990de009c9f@kernel.org> References: <20251008-eopnosupp-fix-v1-0-5990de009c9f@kernel.org> In-Reply-To: <20251008-eopnosupp-fix-v1-0-5990de009c9f@kernel.org> To: linux-api@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org Cc: Jan Kara , Jiri Slaby , Christian Brauner , Arnd Bergmann , Andrey Albershteyn X-Mailer: b4 0.15-dev X-Developer-Signature: v=1; a=openpgp-sha256; l=4039; i=aalbersh@kernel.org; h=from:subject:message-id; bh=Rm08DYj+mslMBXfYK22sr3gFPY8mTjkKzp5uV40xej8=; b=owJ4nJvAy8zAJea2/JXEGuOHHIyn1ZIYMp7FLJXoUW//v2RJxbqtIkttvx86eT2kqCbxbsts1 eS7B36nN57oKGVhEONikBVTZFknrTU1qUgq/4hBjTzMHFYmkCEMXJwCMJEeM4b/CZav9j8/+Nyw Zt4FL8PI6T9dvf+o7j8uYxEattZIyXmbJcMvplKDfcHbUj3839zbJp/l4hL6qP+CiMYZ9prJj+5 oBbZwAAAe2UsJ X-Developer-Key: i=aalbersh@kernel.org; a=openpgp; fpr=AE1B2A9562721A6FC4307C1F46A7EA18AC33E108 This reverts commit 474b155adf3927d2c944423045757b54aa1ca4de. This patch caused regression in ioctl_setflags(). Underlying filesystems use EOPNOTSUPP to indicate that flag is not supported. This error is also gets converted in ioctl_setflags(). Therefore, for unsupported flags error changed from EOPNOSUPP to ENOIOCTLCMD. Link: https://lore.kernel.org/linux-xfs/a622643f-1585-40b0-9441-cf7ece176e8= 3@kernel.org/ Signed-off-by: Andrey Albershteyn --- fs/file_attr.c | 12 ++---------- fs/fuse/ioctl.c | 4 ---- fs/overlayfs/copy_up.c | 2 +- fs/overlayfs/inode.c | 5 ++++- 4 files changed, 7 insertions(+), 16 deletions(-) diff --git a/fs/file_attr.c b/fs/file_attr.c index 12424d4945d0..460b2dd21a85 100644 --- a/fs/file_attr.c +++ b/fs/file_attr.c @@ -84,7 +84,7 @@ int vfs_fileattr_get(struct dentry *dentry, struct file_k= attr *fa) int error; =20 if (!inode->i_op->fileattr_get) - return -EOPNOTSUPP; + return -ENOIOCTLCMD; =20 error =3D security_inode_file_getattr(dentry, fa); if (error) @@ -270,7 +270,7 @@ int vfs_fileattr_set(struct mnt_idmap *idmap, struct de= ntry *dentry, int err; =20 if (!inode->i_op->fileattr_set) - return -EOPNOTSUPP; + return -ENOIOCTLCMD; =20 if (!inode_owner_or_capable(idmap, inode)) return -EPERM; @@ -312,8 +312,6 @@ int ioctl_getflags(struct file *file, unsigned int __us= er *argp) int err; =20 err =3D vfs_fileattr_get(file->f_path.dentry, &fa); - if (err =3D=3D -EOPNOTSUPP) - err =3D -ENOIOCTLCMD; if (!err) err =3D put_user(fa.flags, argp); return err; @@ -335,8 +333,6 @@ int ioctl_setflags(struct file *file, unsigned int __us= er *argp) fileattr_fill_flags(&fa, flags); err =3D vfs_fileattr_set(idmap, dentry, &fa); mnt_drop_write_file(file); - if (err =3D=3D -EOPNOTSUPP) - err =3D -ENOIOCTLCMD; } } return err; @@ -349,8 +345,6 @@ int ioctl_fsgetxattr(struct file *file, void __user *ar= gp) int err; =20 err =3D vfs_fileattr_get(file->f_path.dentry, &fa); - if (err =3D=3D -EOPNOTSUPP) - err =3D -ENOIOCTLCMD; if (!err) err =3D copy_fsxattr_to_user(&fa, argp); =20 @@ -371,8 +365,6 @@ int ioctl_fssetxattr(struct file *file, void __user *ar= gp) if (!err) { err =3D vfs_fileattr_set(idmap, dentry, &fa); mnt_drop_write_file(file); - if (err =3D=3D -EOPNOTSUPP) - err =3D -ENOIOCTLCMD; } } return err; diff --git a/fs/fuse/ioctl.c b/fs/fuse/ioctl.c index 57032eadca6c..fdc175e93f74 100644 --- a/fs/fuse/ioctl.c +++ b/fs/fuse/ioctl.c @@ -536,8 +536,6 @@ int fuse_fileattr_get(struct dentry *dentry, struct fil= e_kattr *fa) cleanup: fuse_priv_ioctl_cleanup(inode, ff); =20 - if (err =3D=3D -ENOTTY) - err =3D -EOPNOTSUPP; return err; } =20 @@ -574,7 +572,5 @@ int fuse_fileattr_set(struct mnt_idmap *idmap, cleanup: fuse_priv_ioctl_cleanup(inode, ff); =20 - if (err =3D=3D -ENOTTY) - err =3D -EOPNOTSUPP; return err; } diff --git a/fs/overlayfs/copy_up.c b/fs/overlayfs/copy_up.c index 27396fe63f6d..20c92ea58093 100644 --- a/fs/overlayfs/copy_up.c +++ b/fs/overlayfs/copy_up.c @@ -178,7 +178,7 @@ static int ovl_copy_fileattr(struct inode *inode, const= struct path *old, err =3D ovl_real_fileattr_get(old, &oldfa); if (err) { /* Ntfs-3g returns -EINVAL for "no fileattr support" */ - if (err =3D=3D -EOPNOTSUPP || err =3D=3D -EINVAL) + if (err =3D=3D -ENOTTY || err =3D=3D -EINVAL) return 0; pr_warn("failed to retrieve lower fileattr (%pd2, err=3D%i)\n", old->dentry, err); diff --git a/fs/overlayfs/inode.c b/fs/overlayfs/inode.c index ecb9f2019395..d4722e1b83bc 100644 --- a/fs/overlayfs/inode.c +++ b/fs/overlayfs/inode.c @@ -720,7 +720,10 @@ int ovl_real_fileattr_get(const struct path *realpath,= struct file_kattr *fa) if (err) return err; =20 - return vfs_fileattr_get(realpath->dentry, fa); + err =3D vfs_fileattr_get(realpath->dentry, fa); + if (err =3D=3D -ENOIOCTLCMD) + err =3D -ENOTTY; + return err; } =20 int ovl_fileattr_get(struct dentry *dentry, struct file_kattr *fa) --=20 2.51.0 From nobody Sun Feb 8 02:22:18 2026 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C3DEB253B59 for ; Wed, 8 Oct 2025 12:44:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759927474; cv=none; b=TS+OQdYnARlDxyv0CzbBG6SkSIsw/g8bQpP5IvwaBC3dvim8jDyGwBGcbSVj6kAMKHYPR/eyTSKL29FSGcDkiEC4dQSvctJP3qFwHzKpmxkvHYXORaOzp4HaXXxAxHyIpK2q7owCaV59hE1f9DBx2EksTRlg2D/f7yrTgUAPDT8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759927474; c=relaxed/simple; bh=0FQzczq+XvPIcLSgmN3fW8/Mf+a99S5LM/p3VLvLUUI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=d9OOM2V4I+sxZSKz6DUowsWa3ygf5cxHFAnzqmVTwuJ1RFkj7LBIL8aqaURx6sgNf1elk76LEkjGVLUq8Tln0fFwAtvtVctJ9wxsMfgdNKdqBs2hXPnTO1PF9Jor2vSB6YIyEWWfljVbqbMJrHO++DeBpzNCfeC1ocRtqqGcZlY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=HpTP8yIZ; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="HpTP8yIZ" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1759927470; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gTuvQMGGyHVj/GABY47oNzO2RJy8snMcE51C98ebSFA=; b=HpTP8yIZWcjqQI2KKV95aoP7teZ7uYi+Mt6IH60k5JUUgbvukdGgCs1Of8hCI8mGKNnvwe Kqizn8GI32rrXT1MgAtI2peVvbniX46PHCrLk9ctyVTObEu+gwplUnz9kgjihEeic1+6jC BBDzMGJMPzQK1vnGZF/X+8O5eGCGyUI= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-398-4cwMgPUFM26cIQE9EsOP6g-1; Wed, 08 Oct 2025 08:44:28 -0400 X-MC-Unique: 4cwMgPUFM26cIQE9EsOP6g-1 X-Mimecast-MFC-AGG-ID: 4cwMgPUFM26cIQE9EsOP6g_1759927467 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-46e473e577eso38798165e9.0 for ; Wed, 08 Oct 2025 05:44:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759927467; x=1760532267; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gTuvQMGGyHVj/GABY47oNzO2RJy8snMcE51C98ebSFA=; b=iBWiBO/Um07wZPYuWhR8QH6GEBp9tMXO7Y637H/JGo1nGOOWp1Gb1/UECwwwq3SReO bQ21W37LtE7lZD7lUn4dW8OMPLOVQQMHZ1wbaTO3YQ+nxYBUiNi1/hDH5UL4Y9FOkChU Ewmh6LzCC6e3WI3NVXlKbubM3tWgH9Jjo6aleN0Hc3frtWfSFzPvfqwuYR3r+IHgLB4w uitiz42wLcu0DHtx9hVuR5heO/Db8sZPqn4Ykj2/JPI9Sf2YIPjv7pmFwOZlpj8HXoiE icV/GngSm/BzFurPpQ6ftYF67bVMjzalTwH6fjPm5A7V61mqazHrq866VcCiqAoelEb+ b+0A== X-Forwarded-Encrypted: i=1; AJvYcCUyHC9B0umvytjqDUqGWa50GEGErvbtijWu043N6Hb2pY+PsVB6Q6yVByDm3GAEqbQ2Tk1kodwpm/v9DXU=@vger.kernel.org X-Gm-Message-State: AOJu0Yw/T6zVl8VAJY3acv7c6nEa6A/jHIz6bprPRxjfXJwVg4t5bP0i RTH8kzhPSwnjV7d9d76SuY0DnmyYuNBiuRA/m8Ltus4onf5Kl4XOeJOgYx9V9ENzEeL513kKTqd B6LS47WI1Z9QU38LVu/a78/hLWDRFXVth/EVnbBKLOEh6XTk2or5xunxaddR+5pX4 X-Gm-Gg: ASbGncti5VaCAZB0YkJeZDE6EB6gfWRhCi5sivpy1NUep+7zmquT222aWYhmP+e59M2 wSZ3i69eUbiy7ijn5a3ToEYXi3dIK/shabznYSkIbiDC/Ebd03tqtSgQLN/jyPOARUkKQXu0h4M hgGXBLEwdGAjtbvajksydW/qZRhxsQMMcUeAFV6BeFaF7BMUzf07x4ZYjiL9W/mXx6DabaaDqLA DhOU4Z/N1Jcd/D0APrmPS5nt5TVGXk6N7vIEFomsUVJqTmAU3imJcD6SimPisKxTx6L4OXCO7bw S/0FxMRvwb2o4elAz5/rqxqQ04sR7lL/3n/KfiRKO9MoPj3ZwOBi1uJyaiLHWkgHG1EYj8JY X-Received: by 2002:a05:600c:4753:b0:46e:1d8d:cfb6 with SMTP id 5b1f17b1804b1-46fa9af0621mr20360705e9.19.1759927467228; Wed, 08 Oct 2025 05:44:27 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEUOOWjGZbNdj8gMQY80gtaJEpiEmEfUTkvwjILGRLj8xEez7HmT/bGwpHIikuJuXE2VGR3WQ== X-Received: by 2002:a05:600c:4753:b0:46e:1d8d:cfb6 with SMTP id 5b1f17b1804b1-46fa9af0621mr20360455e9.19.1759927466628; Wed, 08 Oct 2025 05:44:26 -0700 (PDT) Received: from [127.0.0.2] (ip-217-030-074-039.aim-net.cz. [217.30.74.39]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-46fab3d438fsm13918765e9.2.2025.10.08.05.44.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Oct 2025 05:44:23 -0700 (PDT) From: Andrey Albershteyn X-Google-Original-From: Andrey Albershteyn Date: Wed, 08 Oct 2025 14:44:18 +0200 Subject: [PATCH 2/2] fs: return EOPNOTSUPP from file_setattr/file_getattr syscalls Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251008-eopnosupp-fix-v1-2-5990de009c9f@kernel.org> References: <20251008-eopnosupp-fix-v1-0-5990de009c9f@kernel.org> In-Reply-To: <20251008-eopnosupp-fix-v1-0-5990de009c9f@kernel.org> To: linux-api@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org Cc: Jan Kara , Jiri Slaby , Christian Brauner , Arnd Bergmann , Andrey Albershteyn X-Mailer: b4 0.15-dev X-Developer-Signature: v=1; a=openpgp-sha256; l=1018; i=aalbersh@kernel.org; h=from:subject:message-id; bh=0FQzczq+XvPIcLSgmN3fW8/Mf+a99S5LM/p3VLvLUUI=; b=owJ4nJvAy8zAJea2/JXEGuOHHIyn1ZIYMp7FLGXrP8A6vbUxj0FJYk7QpN39id7xEkWd89QkI zpFkg//d+woZWEQ42KQFVNkWSetNTWpSCr/iEGNPMwcViaQIQxcnAIwkdJChv81zi23ZYUvSooz rV8jnbo2JlSBw+6ARlfjho/CMi9lDOQZ/unft+y8uohbU15J7LPhvrUve3LPuzVyGeXnnAn6cq/ 9HjcAeUxC6A== X-Developer-Key: i=aalbersh@kernel.org; a=openpgp; fpr=AE1B2A9562721A6FC4307C1F46A7EA18AC33E108 These syscalls call to vfs_fileattr_get/set functions which return ENOIOCTLCMD if filesystem doesn't support setting file attribute on an inode. For syscalls EOPNOTSUPP would be more appropriate return error. Signed-off-by: Andrey Albershteyn Reviewed-by: Arnd Bergmann Reviewed-by: Jan Kara --- fs/file_attr.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/fs/file_attr.c b/fs/file_attr.c index 460b2dd21a85..5e3e2aba97b5 100644 --- a/fs/file_attr.c +++ b/fs/file_attr.c @@ -416,6 +416,8 @@ SYSCALL_DEFINE5(file_getattr, int, dfd, const char __us= er *, filename, } =20 error =3D vfs_fileattr_get(filepath.dentry, &fa); + if (error =3D=3D -ENOIOCTLCMD) + error =3D -EOPNOTSUPP; if (error) return error; =20 @@ -483,6 +485,8 @@ SYSCALL_DEFINE5(file_setattr, int, dfd, const char __us= er *, filename, if (!error) { error =3D vfs_fileattr_set(mnt_idmap(filepath.mnt), filepath.dentry, &fa); + if (error =3D=3D -ENOIOCTLCMD) + error =3D -EOPNOTSUPP; mnt_drop_write(filepath.mnt); } =20 --=20 2.51.0