[PATCH v1 0/4] Add Google Tensor SoC USB support

Roy Luo posted 4 patches 2 months, 1 week ago
There is a newer version of this series
.../bindings/phy/google,usb-phy.yaml          |  91 +++
.../bindings/usb/google,snps-dwc3.yaml        | 144 +++++
drivers/phy/Kconfig                           |   1 +
drivers/phy/Makefile                          |   1 +
drivers/phy/google/Kconfig                    |  15 +
drivers/phy/google/Makefile                   |   2 +
drivers/phy/google/phy-google-usb.c           | 286 +++++++++
drivers/usb/dwc3/Kconfig                      |   8 +
drivers/usb/dwc3/Makefile                     |   1 +
drivers/usb/dwc3/dwc3-google.c                | 597 ++++++++++++++++++
10 files changed, 1146 insertions(+)
create mode 100644 Documentation/devicetree/bindings/phy/google,usb-phy.yaml
create mode 100644 Documentation/devicetree/bindings/usb/google,snps-dwc3.yaml
create mode 100644 drivers/phy/google/Kconfig
create mode 100644 drivers/phy/google/Makefile
create mode 100644 drivers/phy/google/phy-google-usb.c
create mode 100644 drivers/usb/dwc3/dwc3-google.c
[PATCH v1 0/4] Add Google Tensor SoC USB support
Posted by Roy Luo 2 months, 1 week ago
This series introduces support for the USB controller and PHY found on
Google Tensor SoCs (G5 and newer). This includes:

1.  DWC3 Glue Driver: A new glue layer for the Synopsys DesignWare USB 3.0
    controller (DWC3) as integrated into Google Tensor SoCs, including
    hibernation support.
2.  DWC3 DT Bindings: Device Tree binding documentation for the Google
    Tensor SoC DWC3 controller.
3.  USB PHY Driver: A new driver for the Google Tensor SoC USB PHY,
    initially supporting high-speed operations.
4.  USB PHY DT Bindings: Device Tree binding documentation for the Google
    Tensor SoC USB PHY.

Co-developed-by: Joy Chakraborty <joychakr@google.com>
Signed-off-by: Joy Chakraborty <joychakr@google.com>
Co-developed-by: Naveen Kumar <mnkumar@google.com>
Signed-off-by: Naveen Kumar <mnkumar@google.com>
Signed-off-by: Roy Luo <royluo@google.com>
---
Roy Luo (4):
  usb: dwc3: Add Google SoC DWC3 glue driver
  dt-bindings: usb: dwc3: Add Google SoC DWC3 USB
  usb: dwc3: Add Google SoC USB PHY driver
  dt-bindings: phy: google: Add Google SoC USB PHY

 .../bindings/phy/google,usb-phy.yaml          |  91 +++
 .../bindings/usb/google,snps-dwc3.yaml        | 144 +++++
 drivers/phy/Kconfig                           |   1 +
 drivers/phy/Makefile                          |   1 +
 drivers/phy/google/Kconfig                    |  15 +
 drivers/phy/google/Makefile                   |   2 +
 drivers/phy/google/phy-google-usb.c           | 286 +++++++++
 drivers/usb/dwc3/Kconfig                      |   8 +
 drivers/usb/dwc3/Makefile                     |   1 +
 drivers/usb/dwc3/dwc3-google.c                | 597 ++++++++++++++++++
 10 files changed, 1146 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/phy/google,usb-phy.yaml
 create mode 100644 Documentation/devicetree/bindings/usb/google,snps-dwc3.yaml
 create mode 100644 drivers/phy/google/Kconfig
 create mode 100644 drivers/phy/google/Makefile
 create mode 100644 drivers/phy/google/phy-google-usb.c
 create mode 100644 drivers/usb/dwc3/dwc3-google.c


base-commit: e5f0a698b34ed76002dc5cff3804a61c80233a7a
-- 
2.51.0.618.g983fd99d29-goog
Re: [PATCH v1 0/4] Add Google Tensor SoC USB support
Posted by Krzysztof Kozlowski 2 months, 1 week ago
On 07/10/2025 08:21, Roy Luo wrote:
> This series introduces support for the USB controller and PHY found on
> Google Tensor SoCs (G5 and newer). This includes:
> 
> 1.  DWC3 Glue Driver: A new glue layer for the Synopsys DesignWare USB 3.0
>     controller (DWC3) as integrated into Google Tensor SoCs, including
>     hibernation support.
> 2.  DWC3 DT Bindings: Device Tree binding documentation for the Google
>     Tensor SoC DWC3 controller.
> 3.  USB PHY Driver: A new driver for the Google Tensor SoC USB PHY,
>     initially supporting high-speed operations.
> 4.  USB PHY DT Bindings: Device Tree binding documentation for the Google
>     Tensor SoC USB PHY.

This is useless message in the cover letter. We see what patches do from
the patches.

What you are supposed to explain here and in the bindings patches, is
why we want this driver and what is Tensor SoC, considering we already
have one Tensor SoC... IOW, explain everything which is not obvious -
and duplicating SoCs with some generic name is for sure not obvious.

Best regards,
Krzysztof
Re: [PATCH v1 0/4] Add Google Tensor SoC USB support
Posted by Roy Luo 2 months, 1 week ago
On Mon, Oct 6, 2025 at 6:06 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> On 07/10/2025 08:21, Roy Luo wrote:
> > This series introduces support for the USB controller and PHY found on
> > Google Tensor SoCs (G5 and newer). This includes:
> >
> > 1.  DWC3 Glue Driver: A new glue layer for the Synopsys DesignWare USB 3.0
> >     controller (DWC3) as integrated into Google Tensor SoCs, including
> >     hibernation support.
> > 2.  DWC3 DT Bindings: Device Tree binding documentation for the Google
> >     Tensor SoC DWC3 controller.
> > 3.  USB PHY Driver: A new driver for the Google Tensor SoC USB PHY,
> >     initially supporting high-speed operations.
> > 4.  USB PHY DT Bindings: Device Tree binding documentation for the Google
> >     Tensor SoC USB PHY.
>
> This is useless message in the cover letter. We see what patches do from
> the patches.
>
> What you are supposed to explain here and in the bindings patches, is
> why we want this driver and what is Tensor SoC, considering we already
> have one Tensor SoC... IOW, explain everything which is not obvious -
> and duplicating SoCs with some generic name is for sure not obvious.
>
> Best regards,
> Krzysztof

Thanks for the review. Will remove the redundant info and ensure the next
cover letter provides the necessary context on the Google Tensor G5 SoC
this series intends to support.

Regards,
Roy Luo