[PATCH RFC 0/3] coresight: replace the void pointer with coresight_path pointer

Jie Gan posted 3 patches 1 week, 2 days ago
drivers/hwtracing/coresight/coresight-catu.c      | 10 ++++----
drivers/hwtracing/coresight/coresight-core.c      | 30 +++++++++++++----------
drivers/hwtracing/coresight/coresight-ctcu-core.c |  9 +++----
drivers/hwtracing/coresight/coresight-cti-core.c  |  5 ++--
drivers/hwtracing/coresight/coresight-cti.h       |  5 ++--
drivers/hwtracing/coresight/coresight-dummy.c     |  2 +-
drivers/hwtracing/coresight/coresight-etb10.c     |  8 +++---
drivers/hwtracing/coresight/coresight-etm-perf.c  |  3 ++-
drivers/hwtracing/coresight/coresight-priv.h      |  3 +--
drivers/hwtracing/coresight/coresight-sysfs.c     |  2 +-
drivers/hwtracing/coresight/coresight-tmc-etf.c   | 10 +++++---
drivers/hwtracing/coresight/coresight-tmc-etr.c   | 15 +++++++-----
drivers/hwtracing/coresight/coresight-tmc.h       |  3 ++-
drivers/hwtracing/coresight/coresight-tpiu.c      |  2 +-
drivers/hwtracing/coresight/coresight-trbe.c      |  4 +--
drivers/hwtracing/coresight/ultrasoc-smb.c        |  9 ++++---
include/linux/coresight.h                         | 17 +++++++------
17 files changed, 75 insertions(+), 62 deletions(-)
[PATCH RFC 0/3] coresight: replace the void pointer with coresight_path pointer
Posted by Jie Gan 1 week, 2 days ago
Hi Carl Worth,

I just created a patch series as an example to fix the reported issues.
Please feel free to check it and let me know if you have any queries.

I think it's better to explain my ideas with codes, so I directly created the
patch series for sharing my solution. Please let me know if it's offend you.

Thanks,

Patch 1:
Fix the issue that the catu cannot correctly read the handle of the AUX
event which is caused by the commit[1].

[1] 080ee83cc361 ("Coresight: Change functions to accept the coresight_path")

Patch 2 - 3:
Change the sink_enable and help_enable/disable to accept coresight_path.

Signed-off-by: Jie Gan <jie.gan@oss.qualcomm.com>
---
Carl Worth (1):
      coresight: tmc: add the handle of the event to the path

Jie Gan (2):
      coresight: change helper_ops to accept coresight_path
      coresight: change the sink_ops to accept coresight_path

 drivers/hwtracing/coresight/coresight-catu.c      | 10 ++++----
 drivers/hwtracing/coresight/coresight-core.c      | 30 +++++++++++++----------
 drivers/hwtracing/coresight/coresight-ctcu-core.c |  9 +++----
 drivers/hwtracing/coresight/coresight-cti-core.c  |  5 ++--
 drivers/hwtracing/coresight/coresight-cti.h       |  5 ++--
 drivers/hwtracing/coresight/coresight-dummy.c     |  2 +-
 drivers/hwtracing/coresight/coresight-etb10.c     |  8 +++---
 drivers/hwtracing/coresight/coresight-etm-perf.c  |  3 ++-
 drivers/hwtracing/coresight/coresight-priv.h      |  3 +--
 drivers/hwtracing/coresight/coresight-sysfs.c     |  2 +-
 drivers/hwtracing/coresight/coresight-tmc-etf.c   | 10 +++++---
 drivers/hwtracing/coresight/coresight-tmc-etr.c   | 15 +++++++-----
 drivers/hwtracing/coresight/coresight-tmc.h       |  3 ++-
 drivers/hwtracing/coresight/coresight-tpiu.c      |  2 +-
 drivers/hwtracing/coresight/coresight-trbe.c      |  4 +--
 drivers/hwtracing/coresight/ultrasoc-smb.c        |  9 ++++---
 include/linux/coresight.h                         | 17 +++++++------
 17 files changed, 75 insertions(+), 62 deletions(-)
---
base-commit: 846bd2225ec3cfa8be046655e02b9457ed41973e
change-id: 20250922-fix_helper_data-f56018fc966f

Best regards,
-- 
Jie Gan <jie.gan@oss.qualcomm.com>
Re: [PATCH RFC 0/3] coresight: replace the void pointer with coresight_path pointer
Posted by Carl Worth 1 week, 2 days ago
Jie Gan <jie.gan@oss.qualcomm.com> writes:
> I think it's better to explain my ideas with codes, so I directly created the
> patch series for sharing my solution. Please let me know if it's
> offend you.

Thanks, Jie! I'm not offended at all. My primary goal is the improvement
of our shared code base, and this is helpful for that. And I agree with
you that code can bring a lot of clarity to the discussion.

I've tested the series and it works and fixes the bug. I'll comment
specifically on each patch separately.

-Carl