[PATCH iproute2-next 0/3] iplink_can: fix checkpatch.pl warnings

Vincent Mailhol posted 3 patches 1 week, 3 days ago
ip/iplink_can.c | 12 +++++-------
1 file changed, 5 insertions(+), 7 deletions(-)
[PATCH iproute2-next 0/3] iplink_can: fix checkpatch.pl warnings
Posted by Vincent Mailhol 1 week, 3 days ago
This is a clean up series which goes through all the checkpatch
warnings on ip/iplink_can.c and fixes them one by one. By the end on
this series, there is only one warning left:

  WARNING: Prefer __printf(2, 0) over __attribute__((format(printf, 2, 0)))
  #320: FILE: ip/iplink_can.c:320:
  +static void __attribute__((format(printf, 2, 0)))

Because iproute2 does not declare the __printf() macro, that last one
can not be fixed.

Signed-off-by: Vincent Mailhol <mailhol@kernel.org>

---
Vincent Mailhol (3):
      iplink_can: fix coding style for pointer format
      iplink_can: fix SPDX-License-Identifier tag format
      iplink_can: factorise the calls to usage()

 ip/iplink_can.c | 12 +++++-------
 1 file changed, 5 insertions(+), 7 deletions(-)
---
base-commit: afceddf61037440628a5612f15a6eaefd28d9fd3
change-id: 20250921-iplink_can-checkpatch-fixes-1ca804bd4fa4

Best regards,
-- 
Vincent Mailhol <mailhol@kernel.org>
Re: [PATCH iproute2-next 0/3] iplink_can: fix checkpatch.pl warnings
Posted by Marc Kleine-Budde 1 week, 2 days ago
On 21.09.2025 16:32:29, Vincent Mailhol wrote:
> This is a clean up series which goes through all the checkpatch
> warnings on ip/iplink_can.c and fixes them one by one. By the end on
> this series, there is only one warning left:
> 
>   WARNING: Prefer __printf(2, 0) over __attribute__((format(printf, 2, 0)))
>   #320: FILE: ip/iplink_can.c:320:
>   +static void __attribute__((format(printf, 2, 0)))
> 
> Because iproute2 does not declare the __printf() macro, that last one
> can not be fixed.
> 
> Signed-off-by: Vincent Mailhol <mailhol@kernel.org>

For the whole series:

Acked-by: Marc Kleine-Budde <mkl@pengutronix.de>

regards,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde          |
Embedded Linux                   | https://www.pengutronix.de |
Vertretung Nürnberg              | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-9   |