From nobody Thu Oct 2 06:14:42 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3B7362D249D; Sun, 21 Sep 2025 07:33:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758439990; cv=none; b=nO+cmndyg5q9ccCIQJvtrMrB3AEb5qTI4asTU+j0F9abV81HOkbU05twFjWfvCP8uM6L00+mjbiyKXWEcqF+QDQcFI+MRrCPapg7AzRaozPMEcMPGMM7rqLaDrsl8bJxaKp+AXQqeQQlmkTGZnbzQWbdlN2nrNU8PrhPuYtV/Tc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758439990; c=relaxed/simple; bh=eXD1/uAXZPU4hdZy7YBqqH2R/cekJAyMpjS9zHYrNZY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=CrwCB6khn6ADVI6YIbliYU1LYy2Argpq6G1JHerWJloygWPF/LhdiJ0mudgR+KS2F+orq4wf/f9py9Z8M6TQxqguxDx/JlRn1OVVzYc08dUhm14MAvCGTV5/zZovw0FHyRIZNjY6mddB2EFOjyr9914keMmOpOEdgSCEaPYw558= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=fX6xxtlq; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="fX6xxtlq" Received: by smtp.kernel.org (Postfix) with ESMTPSA id AE7EAC116B1; Sun, 21 Sep 2025 07:33:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1758439989; bh=eXD1/uAXZPU4hdZy7YBqqH2R/cekJAyMpjS9zHYrNZY=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=fX6xxtlqrEiGPu2hkafYZXgsoBymPhdH+KDThVueqhTUKO7HP9CHyOiQvF1XXMTPi TWjYhXvWOsOSpooVi6QXTG9YM50V5uQx8GbKImbqX7zeBxQTMrLY4JErY5bd4ULT8Q CkzMKPaE+rJswI19GyhIuBQCZDt2ARZX8F6BSXL53CNx1m7SxictgveDuPGUAm9IXc HwOM5PhT6/aWu1TQztoR+EIwL4P6aNKpUzUvbM3Dymk5r+qcBAogeiFMEuOwEnrpvf C1kXe2G9MrALb5cEssACIk9ICiJJ6YXOvns85Mks67Qh6irG6aiJr1mjzqi9bDNLNG UM3ouLkkRs6bQ== From: Vincent Mailhol Date: Sun, 21 Sep 2025 16:32:30 +0900 Subject: [PATCH iproute2-next 1/3] iplink_can: fix coding style for pointer format Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250921-iplink_can-checkpatch-fixes-v1-1-1ddab98560cd@kernel.org> References: <20250921-iplink_can-checkpatch-fixes-v1-0-1ddab98560cd@kernel.org> In-Reply-To: <20250921-iplink_can-checkpatch-fixes-v1-0-1ddab98560cd@kernel.org> To: netdev@vger.kernel.org, Stephen Hemminger , David Ahern Cc: Marc Kleine-Budde , Oliver Hartkopp , linux-kernel@vger.kernel.org, linux-can@vger.kernel.org, Vincent Mailhol X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1304; i=mailhol@kernel.org; h=from:subject:message-id; bh=eXD1/uAXZPU4hdZy7YBqqH2R/cekJAyMpjS9zHYrNZY=; b=owGbwMvMwCV2McXO4Xp97WbG02pJDBnnV+lMEracfVB6z0+rhMaKjUv2Sr1zbHl5f9HlxoWZE kUX3qjM6ChlYRDjYpAVU2RZVs7JrdBR6B126K8lzBxWJpAhDFycAjCRLB1GhhMO07d9krt37GIN /9WjmjlVmxv8Z53c8pRFOGr6Sg/n2wcY/hl38Z46zJ/wV+YY97ona6c0Vn2dvWFlbGzvqvKDsuG aX/kA X-Developer-Key: i=mailhol@kernel.org; a=openpgp; fpr=ED8F700574E67F20E574E8E2AB5FEB886DBB99C2 checkpatch.pl complains about the pointer symbol * being attached to the type instead of being attached to the variable: ERROR: "foo* bar" should be "foo *bar" #85: FILE: ip/iplink_can.c:85: + const char* name) ERROR: "foo* bar" should be "foo *bar" #93: FILE: ip/iplink_can.c:93: +static void print_ctrlmode(enum output_type t, __u32 flags, const char* = key) Fix those two warnings. Signed-off-by: Vincent Mailhol Acked-by: Marc Kleine-Budde --- ip/iplink_can.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ip/iplink_can.c b/ip/iplink_can.c index 9f6084e63986bd05d25a050176f4640c30596b85..1afdf08825f3d9cbbb0454592d2= ed7dc1388a6de 100644 --- a/ip/iplink_can.c +++ b/ip/iplink_can.c @@ -82,7 +82,7 @@ static void set_ctrlmode(char *name, char *arg, } =20 static void print_flag(enum output_type t, __u32 *flags, __u32 flag, - const char* name) + const char *name) { if (*flags & flag) { *flags &=3D ~flag; @@ -90,7 +90,7 @@ static void print_flag(enum output_type t, __u32 *flags, = __u32 flag, } } =20 -static void print_ctrlmode(enum output_type t, __u32 flags, const char* ke= y) +static void print_ctrlmode(enum output_type t, __u32 flags, const char *ke= y) { if (!flags) return; --=20 2.49.1 From nobody Thu Oct 2 06:14:42 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A22FF2D3ED8; Sun, 21 Sep 2025 07:33:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758439992; cv=none; b=E4+SLjb4hKG05Fsf+za1TWD0PYmN2QkFzgZ8DOc2SIGO0H/uYsheGWCiwcQKUgReN25j1pVvT68AamLD3lKx/2sZOeA3eEd9aK6oz8albEbUjZcbiXhjNmFiJm4eOQwVeEkmERZ96GlaCvP9Sufmheq4ERYuup6AS8eMZkLQQBA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758439992; c=relaxed/simple; bh=Bk4FJR21WL13RpJ+hnlFO1KeNGZZtOL+Fwo4hy7IXiM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=RiU8Y1YOBDZbnXhMsiUGDYxWH6gWj8D7XvdDhriTWDeOkQSWz9TKExJ2My/XILHVNrYLT/x9L4Y8qFExKXnguANM+IYY6QQsj1l918Zv5DM/JTDCXbjp94GM822BhuYhhGQHko7FaekwWcbx/3W/1pH5lIkEOT1cnW7hRwcs+y4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=UDuSGgdh; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="UDuSGgdh" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1E38EC4CEF7; Sun, 21 Sep 2025 07:33:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1758439991; bh=Bk4FJR21WL13RpJ+hnlFO1KeNGZZtOL+Fwo4hy7IXiM=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=UDuSGgdhaY8gAC+ATuLeGKC1tvVC3zdA7ZV6/DD8hv8Ubf4HNazbNboSncwxsIFac 0vVvUq+Lx92LGLPm25kF6iWYLMoq1au2TgvRCR6PBIGyc65l2ijmKwEttoMjBL7XIn EzCcdljJUMPE3lWBDI+TGzfDfX/1g+vyZ2KkErLs8D1tyY7CivzeKNEEf9QnuANos+ 98Z1PJQRgzKSB7nZArn/TaVvbabSl1VW2IGxTLGr6ivJlBd2eXwnBtASl3Bny0QP6G uasz62ucDmUadgcXWHow8yELO9PEpEJzd9U8GeqWzizhmEn2sl4RFa6/MALuJHiTC6 hIiG9rXOuEt7Q== From: Vincent Mailhol Date: Sun, 21 Sep 2025 16:32:31 +0900 Subject: [PATCH iproute2-next 2/3] iplink_can: fix SPDX-License-Identifier tag format Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250921-iplink_can-checkpatch-fixes-v1-2-1ddab98560cd@kernel.org> References: <20250921-iplink_can-checkpatch-fixes-v1-0-1ddab98560cd@kernel.org> In-Reply-To: <20250921-iplink_can-checkpatch-fixes-v1-0-1ddab98560cd@kernel.org> To: netdev@vger.kernel.org, Stephen Hemminger , David Ahern Cc: Marc Kleine-Budde , Oliver Hartkopp , linux-kernel@vger.kernel.org, linux-can@vger.kernel.org, Vincent Mailhol X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=923; i=mailhol@kernel.org; h=from:subject:message-id; bh=Bk4FJR21WL13RpJ+hnlFO1KeNGZZtOL+Fwo4hy7IXiM=; b=owGbwMvMwCV2McXO4Xp97WbG02pJDBnnV+l1RsTO+vFW6M2L+jThvQxxub7RHBHye467blbdu 0OXw8qko5SFQYyLQVZMkWVZOSe3Qkehd9ihv5Ywc1iZQIYwcHEKwETuXGdkePzWIffu1QudJ/6u jvafUL3G+NMZQcfO46m8AmJsUf1R2xj+Svi9C0plZ/zd+pa3S4mzZIfbBbP2tEThV9/uh+Qmy+T zAgA= X-Developer-Key: i=mailhol@kernel.org; a=openpgp; fpr=ED8F700574E67F20E574E8E2AB5FEB886DBB99C2 In .c files, the SPDX tag uses the C++ comment style. Fix below checkpatch.pl warning: WARNING: Improper SPDX comment style for 'ip/iplink_can.c', please use '/= /' instead #1: FILE: ip/iplink_can.c:1: +/* SPDX-License-Identifier: GPL-2.0-or-later */ WARNING: Missing or malformed SPDX-License-Identifier tag in line 1 #1: FILE: ip/iplink_can.c:1: +/* SPDX-License-Identifier: GPL-2.0-or-later */ Signed-off-by: Vincent Mailhol Acked-by: Marc Kleine-Budde --- ip/iplink_can.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ip/iplink_can.c b/ip/iplink_can.c index 1afdf08825f3d9cbbb0454592d2ed7dc1388a6de..56c258b023ef57e37574f44981b= 76086a0a140db 100644 --- a/ip/iplink_can.c +++ b/ip/iplink_can.c @@ -1,4 +1,4 @@ -/* SPDX-License-Identifier: GPL-2.0-or-later */ +// SPDX-License-Identifier: GPL-2.0-or-later /* * iplink_can.c CAN device support * --=20 2.49.1 From nobody Thu Oct 2 06:14:42 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B1F7B2D3ED9; Sun, 21 Sep 2025 07:33:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758439992; cv=none; b=a05OZeBm9dh3VqDFeDx49hCDfWfnLexZPRq7ml2GCtLNJbR9J/99yFI1BOwxvNqKDG2BDZJb2sSIBo7joCqjRmCia0MyZQ90+wuX+MMBR5AvMCOl9wMc7WKhlUeChFEXxyf/Fv/WAoM/94b6QtoIqeJQODiohWUH43Rx9MMPvuA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758439992; c=relaxed/simple; bh=Nqudqrf3D+5OMMoK0N9TzqYnz2Lpyj+QgiQ/X8KM1WE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=R6uSDnzj0Ohlgb8FDA7xlRAvts8Zg9IP/etE4zSBL0NblUiuFo3U+tbc9gmz/AzPaG4s4410088JqvY+FFwk0W4lcvhRDvNAKSRe3rR2rMpYBFHH4fzpCP1oAl1uMAcFpaVk60E7f+RUmEsk3sM4ywgkpsxmvRz/hQrjmeQHFCA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ML/YSRdL; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ML/YSRdL" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 81C6DC4CEE7; Sun, 21 Sep 2025 07:33:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1758439992; bh=Nqudqrf3D+5OMMoK0N9TzqYnz2Lpyj+QgiQ/X8KM1WE=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=ML/YSRdLydC35KtaNa/kuFNEI9zeDZIHR06zAh2Ns2zQy/ZlFeheOdE9DPEe3F5Ef gBuyucEUbLp46feEVuXFkLVKnq1+LzyxLXxbgmdv7fq+KZ0LZuTjKpi6KoWQwWEHHI PYaICDQil/l6p0PMIjVj9KhP5lXdVXt1JMAkorFU3gB5454g/t0VEITBcBdxpCXMVG sZjoxoUmbtTPJ+IoSWtXyfdpI61z1vu4j8X/R8LV8WmhUvLbuo+H11W1neA9NIsZTr L25jKR1KHqdHNa0mQaJRRJICmI1tjUerfpBjxJVYMYPnNY17cnnHxxiPxkyxvpsIEY HENM3JUNmKaMw== From: Vincent Mailhol Date: Sun, 21 Sep 2025 16:32:32 +0900 Subject: [PATCH iproute2-next 3/3] iplink_can: factorise the calls to usage() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250921-iplink_can-checkpatch-fixes-v1-3-1ddab98560cd@kernel.org> References: <20250921-iplink_can-checkpatch-fixes-v1-0-1ddab98560cd@kernel.org> In-Reply-To: <20250921-iplink_can-checkpatch-fixes-v1-0-1ddab98560cd@kernel.org> To: netdev@vger.kernel.org, Stephen Hemminger , David Ahern Cc: Marc Kleine-Budde , Oliver Hartkopp , linux-kernel@vger.kernel.org, linux-can@vger.kernel.org, Vincent Mailhol X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1162; i=mailhol@kernel.org; h=from:subject:message-id; bh=Nqudqrf3D+5OMMoK0N9TzqYnz2Lpyj+QgiQ/X8KM1WE=; b=owGbwMvMwCV2McXO4Xp97WbG02pJDBnnVxl4ZfNemS8Q5rux7/zysh/si3ItbgvOzN7clfntP Hv3LNsrHaUsDGJcDLJiiizLyjm5FToKvcMO/bWEmcPKBDKEgYtTACYiyMbIsIWdzz1Mu6P9QfTB z/mGK/+qHg8L8be5m6STbl1ygCvKj5Fh/tTzmovUfaIbXdeGNVlw609o09S68LPunVH/nGt7gxk 4AA== X-Developer-Key: i=mailhol@kernel.org; a=openpgp; fpr=ED8F700574E67F20E574E8E2AB5FEB886DBB99C2 usage() is called either if the user passes the "help" argument or passes an invalid argument. Factorise those two cases together. This silences below checkpatch.pl warning: WARNING: else is not generally useful after a break or return #274: FILE: ip/iplink_can.c:274: + return -1; + } else { Signed-off-by: Vincent Mailhol Acked-by: Marc Kleine-Budde --- ip/iplink_can.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/ip/iplink_can.c b/ip/iplink_can.c index 56c258b023ef57e37574f44981b76086a0a140db..2a13df7bcf6d404e17cf747f29c= 682fa80e4f6fc 100644 --- a/ip/iplink_can.c +++ b/ip/iplink_can.c @@ -268,11 +268,9 @@ static int can_parse_opt(struct link_util *lu, int arg= c, char **argv, invarg("invalid \"termination\" value", *argv); addattr16(n, 1024, IFLA_CAN_TERMINATION, val); - } else if (matches(*argv, "help") =3D=3D 0) { - usage(); - return -1; } else { - fprintf(stderr, "can: unknown option \"%s\"\n", *argv); + if (matches(*argv, "help") !=3D 0) + fprintf(stderr, "can: unknown option \"%s\"\n", *argv); usage(); return -1; } --=20 2.49.1