.../bindings/mmc/mmc-controller-common.yaml | 8 ++++++++ arch/arm64/boot/dts/qcom/sm8550.dtsi | 1 + drivers/mmc/core/host.c | 2 ++ drivers/mmc/core/sd.c | 2 +- drivers/mmc/host/sdhci-msm.c | 15 +++++++++++++++ include/linux/mmc/host.h | 1 + 6 files changed, 28 insertions(+), 1 deletion(-)
Add level shifter support for qualcomm SOC's.
- Changed from v5
- As suggested by Krzysztof Kozlowski reintroduced minimum/maximum
in dt bindings and avoid repeating constraints in free form
text.
- As suggested by Krzysztof Kozlowski/Konrad Dybcio update commit
message reflecting discussions and previous disagreements.
- Changed from v4
- As suggested by Krzysztof Kozlowski Renamed the property from
`max-sd-hs-frequency` to `max-sd-hs-hz` for clarity.
- As suggested by Krzysztof Kozlowski remove min/max constraints
and add default: 50000000 in dt-bindings.
- As suggested by Konrad Dybcio moved max-sd-hs-hz property in the
SoC dtsi.
- Retained sdhci-caps-mask in sm8550.dtsi for now and will revisit
its removal for future targets after thorough validation and testing
from the beginning.
- Changed from v3
- As suggested by Krzysztof Kozlowski moved the property from the
SoC-level DTS to the board-level DTS.
- Revised the commit messages to clearly explain its board-specific.
- Changed from v2
- As suggested by Konrad Dybcio and Ulf Hansson redesigned logic
to introduce a new DT property max-sd-hs-frequency and override
the hs_max_dtr accordingly in sd.c file.
- Changed from v1
- As suggested by Krzysztof Kozlowski redesigned logic to use
compatible property for adding this level shifter support.
- Addressed Adrian Hunter comments on V1 with resepect to
checkpatch.
- Cleared the bits first and then set bits in
sdhci_msm_execute_tuning as suggested by Adrian Hunter.
- Upated the if condition logic in msm_set_clock_rate_for_bus_mode
as suggested by Adrian Hunter.
Sarthak Garg (4):
mmc: sdhci-msm: Enable tuning for SDR50 mode for SD card
dt-bindings: mmc: controller: Add max-sd-hs-hz property
mmc: core: Introduce a new flag max-sd-hs-hz
arm64: dts: qcom: sm8550: Limit max SD HS mode frequency by default
.../bindings/mmc/mmc-controller-common.yaml | 8 ++++++++
arch/arm64/boot/dts/qcom/sm8550.dtsi | 1 +
drivers/mmc/core/host.c | 2 ++
drivers/mmc/core/sd.c | 2 +-
drivers/mmc/host/sdhci-msm.c | 15 +++++++++++++++
include/linux/mmc/host.h | 1 +
6 files changed, 28 insertions(+), 1 deletion(-)
--
2.34.1
On Mon, 8 Sept 2025 at 12:41, Sarthak Garg <quic_sartgarg@quicinc.com> wrote: > > Add level shifter support for qualcomm SOC's. > > - Changed from v5 > - As suggested by Krzysztof Kozlowski reintroduced minimum/maximum > in dt bindings and avoid repeating constraints in free form > text. > - As suggested by Krzysztof Kozlowski/Konrad Dybcio update commit > message reflecting discussions and previous disagreements. > > - Changed from v4 > - As suggested by Krzysztof Kozlowski Renamed the property from > `max-sd-hs-frequency` to `max-sd-hs-hz` for clarity. > - As suggested by Krzysztof Kozlowski remove min/max constraints > and add default: 50000000 in dt-bindings. > - As suggested by Konrad Dybcio moved max-sd-hs-hz property in the > SoC dtsi. > - Retained sdhci-caps-mask in sm8550.dtsi for now and will revisit > its removal for future targets after thorough validation and testing > from the beginning. > > - Changed from v3 > - As suggested by Krzysztof Kozlowski moved the property from the > SoC-level DTS to the board-level DTS. > - Revised the commit messages to clearly explain its board-specific. > > - Changed from v2 > - As suggested by Konrad Dybcio and Ulf Hansson redesigned logic > to introduce a new DT property max-sd-hs-frequency and override > the hs_max_dtr accordingly in sd.c file. > > - Changed from v1 > - As suggested by Krzysztof Kozlowski redesigned logic to use > compatible property for adding this level shifter support. > - Addressed Adrian Hunter comments on V1 with resepect to > checkpatch. > - Cleared the bits first and then set bits in > sdhci_msm_execute_tuning as suggested by Adrian Hunter. > - Upated the if condition logic in msm_set_clock_rate_for_bus_mode > as suggested by Adrian Hunter. > > Sarthak Garg (4): > mmc: sdhci-msm: Enable tuning for SDR50 mode for SD card > dt-bindings: mmc: controller: Add max-sd-hs-hz property > mmc: core: Introduce a new flag max-sd-hs-hz > arm64: dts: qcom: sm8550: Limit max SD HS mode frequency by default > > .../bindings/mmc/mmc-controller-common.yaml | 8 ++++++++ > arch/arm64/boot/dts/qcom/sm8550.dtsi | 1 + > drivers/mmc/core/host.c | 2 ++ > drivers/mmc/core/sd.c | 2 +- > drivers/mmc/host/sdhci-msm.c | 15 +++++++++++++++ > include/linux/mmc/host.h | 1 + > 6 files changed, 28 insertions(+), 1 deletion(-) > > -- > 2.34.1 > Patch 1 -> 3, applied for next, thanks! Note that, I took the liberty of amending patch3 to change the declaration of "max_sd_hs_hz" to an u32, rather than an unsigned int. Kind regards Uffe
On Mon, 08 Sep 2025 16:11:18 +0530, Sarthak Garg wrote:
> Add level shifter support for qualcomm SOC's.
>
> - Changed from v5
> - As suggested by Krzysztof Kozlowski reintroduced minimum/maximum
> in dt bindings and avoid repeating constraints in free form
> text.
> - As suggested by Krzysztof Kozlowski/Konrad Dybcio update commit
> message reflecting discussions and previous disagreements.
>
> [...]
Applied, thanks!
[4/4] arm64: dts: qcom: sm8550: Limit max SD HS mode frequency by default
commit: c3398456f6f6121e79f6c3d9bff00076cf7a3521
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
© 2016 - 2026 Red Hat, Inc.