drivers/spi/spi-cadence-quadspi.c | 34 +++++++++++++++++++------------ 1 file changed, 21 insertions(+), 13 deletions(-)
This series introduces some small but important fixes and cleanups in the Cadence QSPI Controller. Changes in v2: - Use max_t() instead of if case - Add a logic to return failure if there are no flash device declared. - Convert all the open coded bit shifts to BIT() macro - Link to v1: https://lore.kernel.org/linux-spi/20250904133130.3105736-1-s-k6@ti.com/T/#m2a5b6024ae6f147615e54e12688d8ceb5acc6228 Tested on TI's AM62A SK and AM62P SK: Logs: https://gist.github.com/santhosh21/0d25767b58d9a1d9624f2c502dd8f36b Signed-off-by: Santhosh Kumar K s-k6@ti.com Pratyush Yadav (2): spi: cadence-quadspi: Flush posted register writes before INDAC access spi: cadence-quadspi: Flush posted register writes before DAC access Santhosh Kumar K (1): spi: cadence-quadspi: Fix cqspi_setup_flash() Vignesh Raghavendra (1): spi: cadence-quadspi: Use BIT() macros where possible drivers/spi/spi-cadence-quadspi.c | 34 +++++++++++++++++++------------ 1 file changed, 21 insertions(+), 13 deletions(-) -- 2.34.1
Hello, On 06/09/25 00:29, Santhosh Kumar K wrote: > This series introduces some small but important fixes and cleanups in > the Cadence QSPI Controller. > > Changes in v2: > - Use max_t() instead of if case > - Add a logic to return failure if there are no flash device declared. > - Convert all the open coded bit shifts to BIT() macro > - Link to v1: https://lore.kernel.org/linux-spi/20250904133130.3105736-1-s-k6@ti.com/T/#m2a5b6024ae6f147615e54e12688d8ceb5acc6228 > > Tested on TI's AM62A SK and AM62P SK: > Logs: https://gist.github.com/santhosh21/0d25767b58d9a1d9624f2c502dd8f36b > > Signed-off-by: Santhosh Kumar K s-k6@ti.com Gentle ping on this! Regards, Santhosh. > > Pratyush Yadav (2): > spi: cadence-quadspi: Flush posted register writes before INDAC access > spi: cadence-quadspi: Flush posted register writes before DAC access > > Santhosh Kumar K (1): > spi: cadence-quadspi: Fix cqspi_setup_flash() > > Vignesh Raghavendra (1): > spi: cadence-quadspi: Use BIT() macros where possible > > drivers/spi/spi-cadence-quadspi.c | 34 +++++++++++++++++++------------ > 1 file changed, 21 insertions(+), 13 deletions(-) >
On Thu, Sep 11, 2025 at 11:57:05AM +0530, Santhosh Kumar K wrote: > Gentle ping on this! Please don't send content free pings and please allow a reasonable time for review. People get busy, go on holiday, attend conferences and so on so unless there is some reason for urgency (like critical bug fixes) please allow at least a couple of weeks for review. If there have been review comments then people may be waiting for those to be addressed. Sending content free pings adds to the mail volume (if they are seen at all) which is often the problem and since they can't be reviewed directly if something has gone wrong you'll have to resend the patches anyway, so sending again is generally a better approach though there are some other maintainers who like them - if in doubt look at how patches for the subsystem are normally handled.
Hello Mark, On 11/09/25 16:46, Mark Brown wrote: > On Thu, Sep 11, 2025 at 11:57:05AM +0530, Santhosh Kumar K wrote: > >> Gentle ping on this! > > Please don't send content free pings and please allow a reasonable time > for review. People get busy, go on holiday, attend conferences and so > on so unless there is some reason for urgency (like critical bug fixes) > please allow at least a couple of weeks for review. If there have been > review comments then people may be waiting for those to be addressed. > > Sending content free pings adds to the mail volume (if they are seen at > all) which is often the problem and since they can't be reviewed > directly if something has gone wrong you'll have to resend the patches > anyway, so sending again is generally a better approach though there are > some other maintainers who like them - if in doubt look at how patches > for the subsystem are normally handled. I understand the concern, and apologies for the follow-up. The first three patches already carry reviewed-by, and the fourth is only a macro changes with no functional impact. Given that the merge window is approaching, I thought it would be reasonable to send a gentle reminder. Regards, Santhosh.
© 2016 - 2026 Red Hat, Inc.