[PATCH 0/6] Improve cs42l43 suspend/IRQ interactions

Charles Keepax posted 6 patches 4 weeks, 1 day ago
drivers/mfd/cs42l43.c           |  32 +---------
sound/soc/codecs/cs42l43-jack.c |   8 ++-
sound/soc/codecs/cs42l43.c      | 109 +++++++++++++++++++++++---------
sound/soc/codecs/cs42l43.h      |   3 +
4 files changed, 89 insertions(+), 63 deletions(-)
[PATCH 0/6] Improve cs42l43 suspend/IRQ interactions
Posted by Charles Keepax 4 weeks, 1 day ago
cs42l43 uses pm_runtime_force_suspend() during system suspend, however
this means care must be taken that IRQ handler code isn't running when
entering system suspend as force suspend will ignore that the handler
is holding a pm reference. Typically the result of this is just a few
error messages, but better to improve the handling and ensure that all
IRQ processing is synchronised in before system suspend.

Note the ASoC and MFD bits of this series have no build dependencies,
so could go through their seperate trees, however, it would be nice if
all the patches could land in the same kernel version to avoid the IRQ
handling being in a transitional state.

Thanks,
Charles

Charles Keepax (6):
  ASoC: cs42l43: Rename system suspend callback and fix debug print
  ASoC: cs42l43: Store IRQ domain in codec private data
  ASoC: cs42l43: Disable IRQs in system suspend
  ASoC: cs42l43: Shutdown jack detection on suspend
  mfd: cs42l43: Move IRQ enable/disable to encompass force suspend
  mfd: cs42l43: Remove IRQ masking in suspend

 drivers/mfd/cs42l43.c           |  32 +---------
 sound/soc/codecs/cs42l43-jack.c |   8 ++-
 sound/soc/codecs/cs42l43.c      | 109 +++++++++++++++++++++++---------
 sound/soc/codecs/cs42l43.h      |   3 +
 4 files changed, 89 insertions(+), 63 deletions(-)

-- 
2.47.2
Re: (subset) [PATCH 0/6] Improve cs42l43 suspend/IRQ interactions
Posted by Lee Jones 3 weeks ago
On Wed, 03 Sep 2025 10:45:43 +0100, Charles Keepax wrote:
> cs42l43 uses pm_runtime_force_suspend() during system suspend, however
> this means care must be taken that IRQ handler code isn't running when
> entering system suspend as force suspend will ignore that the handler
> is holding a pm reference. Typically the result of this is just a few
> error messages, but better to improve the handling and ensure that all
> IRQ processing is synchronised in before system suspend.
> 
> [...]

Applied, thanks!

[5/6] mfd: cs42l43: Move IRQ enable/disable to encompass force suspend
      commit: b3f893e969b6e8bb80bb2307c509ef1619e1c3fa
[6/6] mfd: cs42l43: Remove IRQ masking in suspend
      commit: d614c669a205f39ca8be545d5d829a6b9f3cf61c

--
Lee Jones [李琼斯]

Re: (subset) [PATCH 0/6] Improve cs42l43 suspend/IRQ interactions
Posted by Mark Brown 4 weeks ago
On Wed, 03 Sep 2025 10:45:43 +0100, Charles Keepax wrote:
> cs42l43 uses pm_runtime_force_suspend() during system suspend, however
> this means care must be taken that IRQ handler code isn't running when
> entering system suspend as force suspend will ignore that the handler
> is holding a pm reference. Typically the result of this is just a few
> error messages, but better to improve the handling and ensure that all
> IRQ processing is synchronised in before system suspend.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/6] ASoC: cs42l43: Rename system suspend callback and fix debug print
      commit: 638ca7601f41a3f8368811f3185b06e2547b7a0f
[2/6] ASoC: cs42l43: Store IRQ domain in codec private data
      commit: 149dda5f42a8fa6dacf2cff1d16952de28622d30
[3/6] ASoC: cs42l43: Disable IRQs in system suspend
      commit: a69b4ba19a07896e7e4246446bad002f5fc0dae1
[4/6] ASoC: cs42l43: Shutdown jack detection on suspend
      commit: dd7ae5b8b3c291c0206f127a564ae1e316705ca0

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark