From nobody Fri Oct 3 08:49:13 2025 Received: from mx0b-001ae601.pphosted.com (mx0a-001ae601.pphosted.com [67.231.149.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C0D6B2E6CD2; Wed, 3 Sep 2025 09:46:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=67.231.149.25 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756892778; cv=fail; b=jLnkDtW/83VVjXmR+NwUjJakbQqHIkzWJy3kyFPAiTXRfLjpXodGNqrQ+iDMDCe0v5CzLVQj6SMuA+zZBsdn6MOXsRLxdwS06zqlLmdNuKR97oyDSPDFK4qb/HntAZpPZbRLTc3aX9DenTpZ7DmP7s+zD90x+9mlv26O0Klxq00= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756892778; c=relaxed/simple; bh=uMDA6twjeHSetU41kw//nHyImZuVu5PFerZWkdhalcQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=DixzPl+ZCLb5fpeW00Bg98N63OUTyHLrTEXcG6FRwlIM5mFnos+hIRWc+7X1rNnNKo9Cg8y89RjUCWJqFiliGblXRjLJ08T2lK8Z7fUidGtjdWADDSS7+DQP6mdRWn0cZP3m1rg+VvTtCnvF8Q2M5pbYC9SQARDZuy4u5Zf92jk= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com; spf=pass smtp.mailfrom=opensource.cirrus.com; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b=YZ3/c7i1; dkim=pass (1024-bit key) header.d=cirrus4.onmicrosoft.com header.i=@cirrus4.onmicrosoft.com header.b=RcJxNvVt; arc=fail smtp.client-ip=67.231.149.25 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=opensource.cirrus.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b="YZ3/c7i1"; dkim=pass (1024-bit key) header.d=cirrus4.onmicrosoft.com header.i=@cirrus4.onmicrosoft.com header.b="RcJxNvVt" Received: from pps.filterd (m0077473.ppops.net [127.0.0.1]) by mx0a-001ae601.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 582MFqVu232307; Wed, 3 Sep 2025 04:46:08 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= PODMain02222019; bh=vQkZDihrgrO2B/NifV687co5tvKi7bV3BW0ZaHlmm7o=; b= YZ3/c7i1RNjuMp2reeZMMuMQ9aekQdJjtq0cTyUN6qQnstZOwA7s05mpZdcBMXOT Sx8hR2Ysf1yJFS44+/bHtMaGSAHNZ+ssierp+bgjnJal64FbyCktXDxIDVMHy5Y6 uyKplQ9jGq2YthqX2yUabP8h+9suZY94fBMBV4b5wpRcK1hTODbcLIvM1m7WE4cz E6WMvJIHpYhmkiYmxQm6A9MbvojB8CtIhEdvFhLZkaUxQNUimx/diuL7wflldkon XmcW8uhF4EdwzxxT95v5DH3h0LaIcjYF1sKCde4j+QSDCmxRcfTb4KqPNEeStCxS f0rEyJoYy+/fwsN/PQwmqg== Received: from nam11-co1-obe.outbound.protection.outlook.com (mail-co1nam11hn2223.outbound.protection.outlook.com [52.100.173.223]) by mx0a-001ae601.pphosted.com (PPS) with ESMTPS id 48vensc6d6-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 03 Sep 2025 04:46:08 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=RuqdewU7TrLYcetvwHtikCdOCbMHMNgnjKzBzqVJTQL7bmtytAm86qk/rOdWY5JRhDeY87+fftAAKC7a2yVGqgFOgwuPHsQbRkGuAOvFTqMcB/j1JCx5vG+f0pX7Zyst7dE3z+kTUjJXQeMjj+llTYA6U0vfHK3qO1JrhByyRR8cdtBGc9TnDZxl2CvKVY4R32w9kF6vdn5e0ZqTGnQlQwZxCrOLYvg4a8WWSdRdF7uJMr5taTBC3gR3O/AIqx2izJ9xNgtI0DHUrGj1LyFuwaN/FX0r1lPlgUZL9c8VwC0+dsF4oe4Mt9xIgVD3qdMee/ywVgso61QE6FUYzfzb0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vQkZDihrgrO2B/NifV687co5tvKi7bV3BW0ZaHlmm7o=; b=XmgbrIr6yiOQ+OUAb7GNsRoe+EoXu4kcpS0muyGbAxZls+QlOMnPmrpVCfpVZxp0zfDgjkJsRJ3RNa3HJSNswWxUD+wLKE4OlR18abIQg53kNAHY9EppDC5jo+btVyPgKHQ0jFd0qYuxg1CYtTJJpeWTrWctqANrOAtJimIZzz6o82088OUveIwmu/PGgq+junwrwL/4Sujhq8DI6eNEyXBpQmM+eXGzNP4B/+XcZJ5a1AT1yc0C7V0ZcNMdrvTYvmqps1NIR+yA/gOErPJuNTxo0ENd3NT5aHyZV4MR3PxSCBM0Hf8sdFM5FTFtS4rBW9UpqOFHxqOqkpUHarO0kg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=fail (sender ip is 84.19.233.75) smtp.rcpttodomain=cirrus.com smtp.mailfrom=opensource.cirrus.com; dmarc=fail (p=reject sp=reject pct=100) action=oreject header.from=opensource.cirrus.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus4.onmicrosoft.com; s=selector2-cirrus4-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vQkZDihrgrO2B/NifV687co5tvKi7bV3BW0ZaHlmm7o=; b=RcJxNvVt8YdPwc0xYdQyjgkJeUX1+1fjTbvjLZeYFBF/lEJhCHyDf0YCgJM58n6YxKBi5QPGvLsifa0FF1XoI3GsXKEGuHzxGCCA4mNe8mx/Ng1YS2yrUrYcLy56fOjfqbBf7niFU3tBHGCV/R1C+ZnZYX7ICPHt/Xm8/GsemNk= Received: from CH2PR15CA0013.namprd15.prod.outlook.com (2603:10b6:610:51::23) by LV3PR19MB8645.namprd19.prod.outlook.com (2603:10b6:408:277::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9073.27; Wed, 3 Sep 2025 09:45:55 +0000 Received: from CH2PEPF00000099.namprd02.prod.outlook.com (2603:10b6:610:51:cafe::8f) by CH2PR15CA0013.outlook.office365.com (2603:10b6:610:51::23) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9094.17 via Frontend Transport; Wed, 3 Sep 2025 09:45:53 +0000 X-MS-Exchange-Authentication-Results: spf=fail (sender IP is 84.19.233.75) smtp.mailfrom=opensource.cirrus.com; dkim=none (message not signed) header.d=none;dmarc=fail action=oreject header.from=opensource.cirrus.com; Received-SPF: Fail (protection.outlook.com: domain of opensource.cirrus.com does not designate 84.19.233.75 as permitted sender) receiver=protection.outlook.com; client-ip=84.19.233.75; helo=edirelay1.ad.cirrus.com; Received: from edirelay1.ad.cirrus.com (84.19.233.75) by CH2PEPF00000099.mail.protection.outlook.com (10.167.244.20) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9052.8 via Frontend Transport; Wed, 3 Sep 2025 09:45:54 +0000 Received: from ediswmail9.ad.cirrus.com (ediswmail9.ad.cirrus.com [198.61.86.93]) by edirelay1.ad.cirrus.com (Postfix) with ESMTPS id 2DA3A406541; Wed, 3 Sep 2025 09:45:53 +0000 (UTC) Received: from ediswws07.ad.cirrus.com (ediswws07.ad.cirrus.com [198.90.208.14]) by ediswmail9.ad.cirrus.com (Postfix) with ESMTPSA id 19DB982025A; Wed, 3 Sep 2025 09:45:53 +0000 (UTC) From: Charles Keepax To: broonie@kernel.org, lee@kernel.org Cc: lgirdwood@gmail.com, linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, patches@opensource.cirrus.com Subject: [PATCH 1/6] ASoC: cs42l43: Rename system suspend callback and fix debug print Date: Wed, 3 Sep 2025 10:45:44 +0100 Message-ID: <20250903094549.271068-2-ckeepax@opensource.cirrus.com> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250903094549.271068-1-ckeepax@opensource.cirrus.com> References: <20250903094549.271068-1-ckeepax@opensource.cirrus.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PEPF00000099:EE_|LV3PR19MB8645:EE_ X-MS-Office365-Filtering-Correlation-Id: e6080817-4088-4a88-a4a5-08ddeacead01 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|376014|36860700013|34020700016|61400799027|12100799063; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?V1plhToI5L9Ul4cekcNO87a/Dj40UcEst5y3OtATXS8oAZeksWSlJmAYM9LL?= =?us-ascii?Q?kMmQQKSxad0aO7Tycoex+YxUJqsYFdrFxufvf6qXuCa3C1f3PjrgkJFrh863?= =?us-ascii?Q?T4uXJPNnh06mrrMqk7kZ24KZLmPn3EAuHBoPt2R3jREoxpVPNwfuH9P97Gvf?= =?us-ascii?Q?TEs6//0XkoQ1+yKdydF9INcBC1DxetNZhDuPnrfzvFFwa6SAef4p78WRMJd6?= =?us-ascii?Q?0FVMgRXJzDJCgBudXaZ04Ux2yZox5tLX7ceVLa5dfel0hwk+4aA4WD9uEgRc?= =?us-ascii?Q?XYO1I+2S4mI63/uUSAkQJLSVute51nSK3SQw3Um8wf8CAUr4dIt2ZHnt6IfV?= =?us-ascii?Q?Z8JAaPH5oz3A7bGpD8Y5yAeTd7WAFTvUdvU6aOQzHSQdhV/5Rih1uVHvnQjK?= =?us-ascii?Q?lWtdnwvoZpJbu1iqE/N0ZYFPs/moztmgY6KizVGoSrz0dCSdpdx5ZThVTaks?= =?us-ascii?Q?M7APW966Waf1xHC94TPVifg+3w/MSyNI6AnIjuVkbnOFgGRx2S38gjROZ1KF?= =?us-ascii?Q?BBByLLJmH8sDEyHjLEDk7txoLRbrzN9n98wCp5qqjAqZnMwZYptsdpZTHaP3?= =?us-ascii?Q?RO8gx1gWWQ6YEO0zLojCKsbRyaQbJUtyOD4AAuG8CMlUbwiBbHF7yY7wa4K8?= =?us-ascii?Q?JmuNvB5W2Jti55zVEtOGP3Ul0ktQPADJglvX/36amvqFyFDJzpe4ofNv6Tpt?= =?us-ascii?Q?UyTydfkXUsGVX3bTEOmA4tfnpbSCzeBXdthrpPZqONeyH0eKzcBLYhsyzizG?= =?us-ascii?Q?J9a7KNEeB0eqyb5U4LzexwR18VK0T9IzfGw50XepBV5AN+NrkqsIL1+Vm1ql?= =?us-ascii?Q?STUe43Kv1c41fAaJUcJwZLBalGiALl0rc/S2AOkfqgrVaNHyoUVOpuFpzdku?= =?us-ascii?Q?nGXzm7PkDNCokJNvM5sRWoYFGnZau1iW0k6OkgoFGpZp7wsOiwZaQo6E9kLj?= =?us-ascii?Q?+W+thkB2+7jOmWuTQi3YqLNfJr8mFKq2INISH2d8VGn4uZowGJvBTJlmB5MA?= =?us-ascii?Q?MQSd1CaNfGN5UjwpwwYHU8hdJzbo7rSFFHaWLs+9TT/NIdGTipR7pSDoxK7X?= =?us-ascii?Q?CtM1Vr5OiZZcUczTHHYyTTuKr1VfJMz9U/Wy/5NsR7WF8L6bqZFIj9QEZKlN?= =?us-ascii?Q?R6r4WfJ6WCJfaSznmi/xya0MNLVtMW5ik22P0uVAUo6fZrn6vjzPdqBut1Dw?= =?us-ascii?Q?9tqLRoryx4j461NVQCm5Zso0SQyc70rpsEYg7vU99Rxx8n3FBJQjQytvokNe?= =?us-ascii?Q?U20xTXiE9bTyrnA0CL49VcMV6FssN6Kow1sHUZxnpV1tioKbUWW06D+SySxD?= =?us-ascii?Q?UufBKAhu7ftBHjt10WBskj/ddgCDy0A+tjkSHbneomWcpxlkHZOoOezXVSxR?= =?us-ascii?Q?3j2KrY4sm/ulSXOP4+y66MGl77Si4qtxcbSd5L/5LnQHeqOp1DZEpL8jpFUF?= =?us-ascii?Q?j3OzIAn5Fr42DgXK4JFEnCCnlw12ZB6NXANZYrG+lEXMA0UkNqAonxqlaaha?= =?us-ascii?Q?7dKkxiI3XVZSIWHTLh5lhVnHPRXrF3IPuRO0?= X-Forefront-Antispam-Report: CIP:84.19.233.75;CTRY:GB;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:edirelay1.ad.cirrus.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(82310400026)(376014)(36860700013)(34020700016)(61400799027)(12100799063);DIR:OUT;SFP:1501; X-OriginatorOrg: opensource.cirrus.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Sep 2025 09:45:54.0897 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e6080817-4088-4a88-a4a5-08ddeacead01 X-MS-Exchange-CrossTenant-Id: bec09025-e5bc-40d1-a355-8e955c307de8 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=bec09025-e5bc-40d1-a355-8e955c307de8;Ip=[84.19.233.75];Helo=[edirelay1.ad.cirrus.com] X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TreatMessagesAsInternal-CH2PEPF00000099.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV3PR19MB8645 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwOTAzMDA5NyBTYWx0ZWRfX6bYfemJlterl N5xoY2lKCjDh1KiukrdoPFKQ9Ag6VA6oCsc+U10aGLKasQ4a/FVcd9IpKJ3UgoPy27j+gwu8bYj LFKqor0H5sBsoZeVHe++DGJJCKjSsbPg2v2lJX+LWF2FqRkIs4Mk/N2iTkYo+ewbj6gDLifdPGi tTJ6Htz72IRSXGz6cClNABjvQBaHITyUoyZ41mgmQCoS0vhrOpxyS2jW2hVSC12WWXUdQiXVYet J5Q7QqRMQTN8+OnwadVDgagwNXbRu2DF9jeV8GmtL9Z3VMwcavcQYfdQAtl3NtzJ/bVX2TgAKeC PvwyDnJK4fRBN9BHTmnUNQQTPQLkqzsuKqyntZVwWzGIWaURDXVeyeb57eN45A= X-Authority-Analysis: v=2.4 cv=BY/Y0qt2 c=1 sm=1 tr=0 ts=68b80e60 cx=c_pps a=6sg/H9X2hAOIoUO5KNDVHw==:117 a=h1hSm8JtM9GN1ddwPAif2w==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=yJojWOMRYYMA:10 a=s63m1ICgrNkA:10 a=RWc_ulEos4gA:10 a=w1d2syhTAAAA:8 a=6Bu7agoeOIQKrqNxcLoA:9 a=jZz-an6Pvt0H8_Yc_ROU:22 X-Proofpoint-GUID: I_OgjCgrAoAZ92jA1Rs2FqK4BFVTLYFe X-Proofpoint-ORIG-GUID: I_OgjCgrAoAZ92jA1Rs2FqK4BFVTLYFe X-Proofpoint-Spam-Reason: safe Content-Type: text/plain; charset="utf-8" There is some confusion around cs42l43_codec_runtime_force_suspend(). This function is the system suspend callback, however the name and the debug print both use the words runtime. Rename the function to the simpler cs42l43_codec_suspend() and correct the debug print. Signed-off-by: Charles Keepax --- sound/soc/codecs/cs42l43.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/sound/soc/codecs/cs42l43.c b/sound/soc/codecs/cs42l43.c index b0c27d696c58a..4d17799415817 100644 --- a/sound/soc/codecs/cs42l43.c +++ b/sound/soc/codecs/cs42l43.c @@ -2386,11 +2386,11 @@ static int cs42l43_codec_runtime_resume(struct devi= ce *dev) return 0; } =20 -static int cs42l43_codec_runtime_force_suspend(struct device *dev) +static int cs42l43_codec_suspend(struct device *dev) { struct cs42l43_codec *priv =3D dev_get_drvdata(dev); =20 - dev_dbg(priv->dev, "Runtime suspend\n"); + dev_dbg(priv->dev, "System suspend\n"); =20 priv->suspend_jack_debounce =3D true; =20 @@ -2401,7 +2401,7 @@ static int cs42l43_codec_runtime_force_suspend(struct= device *dev) =20 static const struct dev_pm_ops cs42l43_codec_pm_ops =3D { RUNTIME_PM_OPS(NULL, cs42l43_codec_runtime_resume, NULL) - SYSTEM_SLEEP_PM_OPS(cs42l43_codec_runtime_force_suspend, pm_runtime_force= _resume) + SYSTEM_SLEEP_PM_OPS(cs42l43_codec_suspend, pm_runtime_force_resume) }; =20 static const struct platform_device_id cs42l43_codec_id_table[] =3D { --=20 2.47.2 From nobody Fri Oct 3 08:49:13 2025 Received: from mx0b-001ae601.pphosted.com (mx0a-001ae601.pphosted.com [67.231.149.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7C952270EC1; Wed, 3 Sep 2025 09:46:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=67.231.149.25 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756892777; cv=fail; b=TFYij2DVMKTsraWyAxhUtFY0aD4/8OXDK6j2huo4k/LhpbgaV2uW6Ct/0q51/2q8adCwRlxFjDcI2ldEl7o22tzwVKRHq7rxHNG9jecfgYE0PAd5EvvIT4lTJ0pUWSkwHXMFH31Ua3Mmf8iqO5hRzuOk/wzrdwqVNivAQCw/+pQ= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756892777; c=relaxed/simple; bh=9JZhAuTTx1sNL1ggSSyCc4Hrs2ZSZNawsID1fcWN4Z0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=UzmmmU/n4ToERGYK1mEuWJw+R4cdQyDhTwT3PfPM5lp7+aRhIcQAENT0sz6pzRVBQ6i54pHF96wynKYoAZNizHflAMHr6ZLq9DtH+zF5RTgNcyvB7FsLzAvRrXrVBdI5w7jMsBpfxD7yujG4iUck5cXhQP7MCb3IiL5YsPlRUy8= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com; spf=pass smtp.mailfrom=opensource.cirrus.com; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b=TC2s5bBH; dkim=pass (1024-bit key) header.d=cirrus4.onmicrosoft.com header.i=@cirrus4.onmicrosoft.com header.b=B/cCUrYj; arc=fail smtp.client-ip=67.231.149.25 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=opensource.cirrus.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b="TC2s5bBH"; dkim=pass (1024-bit key) header.d=cirrus4.onmicrosoft.com header.i=@cirrus4.onmicrosoft.com header.b="B/cCUrYj" Received: from pps.filterd (m0077473.ppops.net [127.0.0.1]) by mx0a-001ae601.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 582JWgRB2223743; Wed, 3 Sep 2025 04:46:01 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= PODMain02222019; bh=8lKjWFsLa+KCgupoKtYv6MeRMyfqv/iP9ishrotg+dA=; b= TC2s5bBHQIZUdCfIpBsisVWMNqNOWpQd/i+mCWVaJ5LDa4Lx/MsiiK7CSJ8iq4/r OpE+JgwD9yJ9aYp5UNORObtIrzSjM11loIw2jMgJWcAAFDZqfbpzX0x1ZdIbNy9m i0PaumKkPUTolFHtycGMMJIWFVIu0DrNYWCa7r4HEeo7nCyCF2Jj+QVHhXNeaxyE hv8xn+c/EMc8jmuD5c6R3Re18qWMQV8FLqwUaPmZz6BXd4pUJQ/vs50T5jjvf2Pk hGRU5w2kVvPPhlDTJUudhjf3+Ol3KlFoebWudhudfdylM/LTad+5PdOkDUVmama3 VECj3drDWnt6O/+bM6GVXQ== Received: from nam12-mw2-obe.outbound.protection.outlook.com (mail-mw2nam12hn2202.outbound.protection.outlook.com [52.100.167.202]) by mx0a-001ae601.pphosted.com (PPS) with ESMTPS id 48vensc6d3-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 03 Sep 2025 04:46:00 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=HLEt8IKIJJtYAylYBg14gaLF1BUhzP8d93gfkFP6RgIci/RszTbLG0LS6vKhVx3uXtFddcnkpjbLCB/bHmEabXaGn1BxYil4XABL+GVW2O1ZsqcYBrVhi6StP5XDCZjLuVpgiPPXcZNglb937RhXSVQmUnx9L3r0D/1F648cAWLq/bzrHkspKTBf2qtdTjhFtwhCnJmecanhGI2aWontLoVK4h0qdQgGJfA0kqPlbbqCj0CXyo3s+OElS5W5QM59TD0dsb7qK0BtK+QQq61afNjwENfqwOQpB6pO/nALKBcFHqjTQKqW4wmzvlOaXXTD0t4TF0uQGeM4X3aiEPGHaQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8lKjWFsLa+KCgupoKtYv6MeRMyfqv/iP9ishrotg+dA=; b=JWFUQo4DS3ZSJWGAnvYjRSLUBEnXZ/cVxD/0TkSZv/yOLp3bQSUdhQA3QewwUdLp0U3nSfbXyKLSjDYfCHZzemrlELUAvKYHIhTcwn4Tv1MFf17Fj1sX4d2wcPn/GIeaeyoDAULeCOQCE2VsMlrLBoWCeBUhE+wC4sSPicOCCXsXskaaIhAE6D6GGhNLmsZ2sVou8RnESgA2iYT/XsBUVjtx2iyX3Xs0ncOwAh9OW7PUChdTZniThu5yLLvjKULKEfODl62Pfmxx/zYWD9CyxhhF6VejV0acvBCUdjJTiENmSVvhgivziEWzoz34yW3h4Oi7P+zT5aGQKF45GS/Fww== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=fail (sender ip is 84.19.233.75) smtp.rcpttodomain=cirrus.com smtp.mailfrom=opensource.cirrus.com; dmarc=fail (p=reject sp=reject pct=100) action=oreject header.from=opensource.cirrus.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus4.onmicrosoft.com; s=selector2-cirrus4-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8lKjWFsLa+KCgupoKtYv6MeRMyfqv/iP9ishrotg+dA=; b=B/cCUrYjbG1Vk35XdiYGPtoF27T7fRUSrYztT+Zf1ieHNOBRIjt0vuB2VKGQqJos3bHIfN4CMJJArJkQSuQickpB08RVe9NIhm64cTFCehNN9dduHK/7pQLDS+CelqkZd8dzijPB5NZnxKin1R2zEEZxdfhvrqB845fIstPQuvY= Received: from BN9PR03CA0639.namprd03.prod.outlook.com (2603:10b6:408:13b::14) by SJ1PR19MB6355.namprd19.prod.outlook.com (2603:10b6:a03:456::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9073.27; Wed, 3 Sep 2025 09:45:55 +0000 Received: from BN3PEPF0000B06B.namprd21.prod.outlook.com (2603:10b6:408:13b:cafe::f5) by BN9PR03CA0639.outlook.office365.com (2603:10b6:408:13b::14) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9073.27 via Frontend Transport; Wed, 3 Sep 2025 09:45:54 +0000 X-MS-Exchange-Authentication-Results: spf=fail (sender IP is 84.19.233.75) smtp.mailfrom=opensource.cirrus.com; dkim=none (message not signed) header.d=none;dmarc=fail action=oreject header.from=opensource.cirrus.com; Received-SPF: Fail (protection.outlook.com: domain of opensource.cirrus.com does not designate 84.19.233.75 as permitted sender) receiver=protection.outlook.com; client-ip=84.19.233.75; helo=edirelay1.ad.cirrus.com; Received: from edirelay1.ad.cirrus.com (84.19.233.75) by BN3PEPF0000B06B.mail.protection.outlook.com (10.167.243.70) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9115.0 via Frontend Transport; Wed, 3 Sep 2025 09:45:54 +0000 Received: from ediswmail9.ad.cirrus.com (ediswmail9.ad.cirrus.com [198.61.86.93]) by edirelay1.ad.cirrus.com (Postfix) with ESMTPS id 3EFFB406542; Wed, 3 Sep 2025 09:45:53 +0000 (UTC) Received: from ediswws07.ad.cirrus.com (ediswws07.ad.cirrus.com [198.90.208.14]) by ediswmail9.ad.cirrus.com (Postfix) with ESMTPSA id 27B14820247; Wed, 3 Sep 2025 09:45:53 +0000 (UTC) From: Charles Keepax To: broonie@kernel.org, lee@kernel.org Cc: lgirdwood@gmail.com, linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, patches@opensource.cirrus.com Subject: [PATCH 2/6] ASoC: cs42l43: Store IRQ domain in codec private data Date: Wed, 3 Sep 2025 10:45:45 +0100 Message-ID: <20250903094549.271068-3-ckeepax@opensource.cirrus.com> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250903094549.271068-1-ckeepax@opensource.cirrus.com> References: <20250903094549.271068-1-ckeepax@opensource.cirrus.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN3PEPF0000B06B:EE_|SJ1PR19MB6355:EE_ X-MS-Office365-Filtering-Correlation-Id: 321278db-673d-4933-622c-08ddeaceacff X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|82310400026|61400799027|34020700016|36860700013|12100799063; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?8PWO9VpxBcuxdiQmIIfu0+RAPUCRTDU+dJHvJnE7K8FAXFsaBEAM6Cgp762b?= =?us-ascii?Q?3S7FbhDSDFbeWUbmmeG6DFva7Nj2MAHM/Qp1TLnIR2XmGTLlmIKRIucONjt9?= =?us-ascii?Q?0yBXZmJWzEOH+pbCUGlFAK7dThm/P3v4iRnkxCjyrpkWZsymd4GdPnCkfz6S?= =?us-ascii?Q?wcDFH1wg08EKMS+dYU+ZkfNH6PKgh4lhEALLhOwRChIoRE7xCT5mjDPlYe+R?= =?us-ascii?Q?j+wAXkZfVnDDk1jZ9CjGmSOiEk28FjM9sTDr9BYzdvCaVi5Pbpxx7bC4jVHJ?= =?us-ascii?Q?LUVbRs5IJZ9tWBKHF7JtnRvBML0pNP/scYgTzhHK+BSuXlpcEKevxSSNvFkp?= =?us-ascii?Q?tvWwhiGgZwMrA9GaI1sZlxL2ur2gEVCM89djD4Z9ShmlfLN0aGGWAV7JWQC+?= =?us-ascii?Q?D5zIVdQqLudy1qF9OYp5FVslZK6DxaWbpl7fb/xo0C8TThqJuBDjaR6/wEm8?= =?us-ascii?Q?kGrO3tDchlLyhpyYQvV99/cVZzfmYZM4DTGek39raH3uRbP2uVI1AoN2Ex44?= =?us-ascii?Q?HfuJiizQxVac93AcWyfgCXbXJSyKaF2QEHHSYh8YRWg/ZkJ34P4FlRL/K99V?= =?us-ascii?Q?KYsohW3n6QV4m1UrlvV8BVuAoNt98b0DQzGYCuuzR5YXOzAJsqt+oq+3htF0?= =?us-ascii?Q?Uhbbj7cEFdXnYmzws3S55Rtm6Z0ncQ7/QK1/LVqYzisFYDnYdW6tBCdJHdp/?= =?us-ascii?Q?aaa8kSYdDdmezS593md5MILI4aXH9gcTQUmRqqc15m9Bz+x9zvWoA1voiunW?= =?us-ascii?Q?uO8NU3gbXyMbmP4mt3WFaWDmOxrg2R17i/qI5NWwm3Yb9JwoSLq7aNb5Exvn?= =?us-ascii?Q?YhCHFf0cGhVywpHDySqSYXa4GMs5VnPUbGwC5n8F+ktTg3gzWJ2FAPp8GI4F?= =?us-ascii?Q?vzK7Ikx8Hb6uZT8w76w6L+z2Q5dBxQBsglGlRu+Q1SJTX2XhzFOvaFdhKKJJ?= =?us-ascii?Q?fdquZqXlzv3T7f3Btp9LJPJuSfa9KBHZ/Gz5I1kAj5Y+NcAzt0X0YP2aodgC?= =?us-ascii?Q?nTEU2c+NRT5+W9x2UxhL9Ko8Nipqg6OAU99zwe2xLmEQN6uE3F69mF184BHq?= =?us-ascii?Q?+FS0qtlP5LpE708QlQVu0fA4lLNe+jfXt9TlC0d2oFKflXC3LqHARcjYOmUw?= =?us-ascii?Q?3ZLc0jPwcDkp/CNtr2lIE7adNtQCiYHBbDmWisokQFOmHnflqGaQIu9ocJ9V?= =?us-ascii?Q?YLn4MQ2pftHUDm+mOs1MGR2MPSMY1c9Sxe5uvfCMGBRDo2hpM5C2VYg9Qykc?= =?us-ascii?Q?s3Qf7hA72hk81rl2JDD7YDNFUoKX3W4ILe0ncOyzQAF50YDrKzarKSwjl8SA?= =?us-ascii?Q?swPNsI5keOn+qM0jmXIYHxoWcWd1rMSyMk8Wqk0BuuhQeZ8o1ottx13ox3zB?= =?us-ascii?Q?kocAlCk0oSTROjfFGStTuOzoHoMoaWNnMxH55/6zLPVsQ9v6OWnw2P6iV1et?= =?us-ascii?Q?tGGyTM2NiPzh0uFW0td5duBwRTKKLPIUgABeMXv1bZlYEkTOiCcUgTJc+rLU?= =?us-ascii?Q?zar3QIA63XSbpFUexQ4fMeB/N7YKu3dW69Dt?= X-Forefront-Antispam-Report: CIP:84.19.233.75;CTRY:GB;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:edirelay1.ad.cirrus.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(376014)(82310400026)(61400799027)(34020700016)(36860700013)(12100799063);DIR:OUT;SFP:1501; X-OriginatorOrg: opensource.cirrus.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Sep 2025 09:45:54.0857 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 321278db-673d-4933-622c-08ddeaceacff X-MS-Exchange-CrossTenant-Id: bec09025-e5bc-40d1-a355-8e955c307de8 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=bec09025-e5bc-40d1-a355-8e955c307de8;Ip=[84.19.233.75];Helo=[edirelay1.ad.cirrus.com] X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TreatMessagesAsInternal-BN3PEPF0000B06B.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR19MB6355 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwOTAzMDA5NyBTYWx0ZWRfX0/Y79HlYKB7f VxU/zHpRjgF2gsq9m1RNIJYqsjoyivDAJHd3J0rUkEHnltU/dRdWIW4NCi0oo9Gzrycrxl5HoGH rDfqIlDIEWdnx117HJzOcjX7+gzWt91MoOwtmcLhVeX1UgzLKxtr7QVANbKez646lmpQN69TqwJ fmOgz916vFnnE5xDf85Rbb2zFW3zlA370VhCNBomOzb5NdFAuYH8eBJ0yM4EK+NoPH7Zu8+zwAX vNbtEoIPIVz/Igfb7NME55eTzzI209zX/hXDGc1wH60nvbbRukHrLq91Sa6GUO/Dhu4GeYjA0yU 5RU9IGg3tb5TNxh0go6L6Lg7SPdPP1qZ/+SGPAcUlRk/oqjElSJ/e4BeZY2n8o= X-Authority-Analysis: v=2.4 cv=BY/Y0qt2 c=1 sm=1 tr=0 ts=68b80e58 cx=c_pps a=8hBjwRI3TeAgKlFXmFed3w==:117 a=h1hSm8JtM9GN1ddwPAif2w==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=yJojWOMRYYMA:10 a=s63m1ICgrNkA:10 a=RWc_ulEos4gA:10 a=w1d2syhTAAAA:8 a=ISzjgLl2UIzaD__TBtgA:9 a=jZz-an6Pvt0H8_Yc_ROU:22 X-Proofpoint-GUID: JWle6MO9jzMtoI3rKRf8gj1bswekTYZK X-Proofpoint-ORIG-GUID: JWle6MO9jzMtoI3rKRf8gj1bswekTYZK X-Proofpoint-Spam-Reason: safe Content-Type: text/plain; charset="utf-8" To support future refactoring store a pointer to the IRQ domain in the codec private data allowing easier access to it outside of probe. Signed-off-by: Charles Keepax --- sound/soc/codecs/cs42l43.c | 29 +++++++++++++---------------- sound/soc/codecs/cs42l43.h | 1 + 2 files changed, 14 insertions(+), 16 deletions(-) diff --git a/sound/soc/codecs/cs42l43.c b/sound/soc/codecs/cs42l43.c index 4d17799415817..241f7d013189c 100644 --- a/sound/soc/codecs/cs42l43.c +++ b/sound/soc/codecs/cs42l43.c @@ -2210,13 +2210,12 @@ static const struct cs42l43_irq cs42l43_irqs[] =3D { }; =20 static int cs42l43_request_irq(struct cs42l43_codec *priv, - struct irq_domain *dom, const char * const name, - unsigned int irq, irq_handler_t handler, - unsigned long flags) + const char * const name, unsigned int irq, + irq_handler_t handler, unsigned long flags) { int ret; =20 - ret =3D irq_create_mapping(dom, irq); + ret =3D irq_create_mapping(priv->dom, irq); if (ret < 0) return dev_err_probe(priv->dev, ret, "Failed to map IRQ %s\n", name); =20 @@ -2230,8 +2229,7 @@ static int cs42l43_request_irq(struct cs42l43_codec *= priv, return 0; } =20 -static int cs42l43_shutter_irq(struct cs42l43_codec *priv, - struct irq_domain *dom, unsigned int shutter, +static int cs42l43_shutter_irq(struct cs42l43_codec *priv, unsigned int sh= utter, const char * const open_name, const char * const close_name, irq_handler_t handler) @@ -2259,25 +2257,20 @@ static int cs42l43_shutter_irq(struct cs42l43_codec= *priv, return 0; } =20 - ret =3D cs42l43_request_irq(priv, dom, close_name, close_irq, handler, IR= QF_SHARED); + ret =3D cs42l43_request_irq(priv, close_name, close_irq, handler, IRQF_SH= ARED); if (ret) return ret; =20 - return cs42l43_request_irq(priv, dom, open_name, open_irq, handler, IRQF_= SHARED); + return cs42l43_request_irq(priv, open_name, open_irq, handler, IRQF_SHARE= D); } =20 static int cs42l43_codec_probe(struct platform_device *pdev) { struct cs42l43 *cs42l43 =3D dev_get_drvdata(pdev->dev.parent); struct cs42l43_codec *priv; - struct irq_domain *dom; unsigned int val; int i, ret; =20 - dom =3D irq_find_matching_fwnode(dev_fwnode(cs42l43->dev), DOMAIN_BUS_ANY= ); - if (!dom) - return -EPROBE_DEFER; - priv =3D devm_kzalloc(&pdev->dev, sizeof(*priv), GFP_KERNEL); if (!priv) return -ENOMEM; @@ -2285,6 +2278,10 @@ static int cs42l43_codec_probe(struct platform_devic= e *pdev) priv->dev =3D &pdev->dev; priv->core =3D cs42l43; =20 + priv->dom =3D irq_find_matching_fwnode(dev_fwnode(cs42l43->dev), DOMAIN_B= US_ANY); + if (!priv->dom) + return -EPROBE_DEFER; + platform_set_drvdata(pdev, priv); =20 mutex_init(&priv->jack_lock); @@ -2314,7 +2311,7 @@ static int cs42l43_codec_probe(struct platform_device= *pdev) goto err_pm; =20 for (i =3D 0; i < ARRAY_SIZE(cs42l43_irqs); i++) { - ret =3D cs42l43_request_irq(priv, dom, cs42l43_irqs[i].name, + ret =3D cs42l43_request_irq(priv, cs42l43_irqs[i].name, cs42l43_irqs[i].irq, cs42l43_irqs[i].handler, 0); if (ret) @@ -2327,13 +2324,13 @@ static int cs42l43_codec_probe(struct platform_devi= ce *pdev) goto err_pm; } =20 - ret =3D cs42l43_shutter_irq(priv, dom, val & CS42L43_MIC_SHUTTER_CFG_MASK, + ret =3D cs42l43_shutter_irq(priv, val & CS42L43_MIC_SHUTTER_CFG_MASK, "mic shutter open", "mic shutter close", cs42l43_mic_shutter); if (ret) goto err_pm; =20 - ret =3D cs42l43_shutter_irq(priv, dom, (val & CS42L43_SPK_SHUTTER_CFG_MAS= K) >> + ret =3D cs42l43_shutter_irq(priv, (val & CS42L43_SPK_SHUTTER_CFG_MASK) >> CS42L43_SPK_SHUTTER_CFG_SHIFT, "spk shutter open", "spk shutter close", cs42l43_spk_shutter); diff --git a/sound/soc/codecs/cs42l43.h b/sound/soc/codecs/cs42l43.h index 3ea36362b11a4..f4ef93d1fc2a4 100644 --- a/sound/soc/codecs/cs42l43.h +++ b/sound/soc/codecs/cs42l43.h @@ -44,6 +44,7 @@ struct cs42l43_codec { struct device *dev; struct cs42l43 *core; struct snd_soc_component *component; + struct irq_domain *dom; =20 struct clk *mclk; =20 --=20 2.47.2 From nobody Fri Oct 3 08:49:13 2025 Received: from mx0b-001ae601.pphosted.com (mx0a-001ae601.pphosted.com [67.231.149.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7C8A3270EA5; Wed, 3 Sep 2025 09:46:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=67.231.149.25 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756892778; cv=fail; b=aPLblXHjeNU16rNQw9MtUISnEV0BN9R3D+1vFKsUATJ/Pu+Ak7XvfBKKFLbJknUla9lYUGpz8g+EtN7mkobfXm3zUtr9SlysPHtg88A6FDlCxiPnImb1wNpsMo4mIHf/MScevSkC5/ipsbElpZtRHJm8VmC0TWsJl0JAc11WfMs= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756892778; c=relaxed/simple; bh=TcpV9lrrpkaZ5LwlTkwpFEKvF1H6c3ZsjKNSoEweLAQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=lnWAlyaLB8UTjW59zEUL/740q4smrlk0tvTXiNJgJsxrjkOzNhip+vbAXZ7PGUu9TF8zGiP0uMudF9Z3nzjxZo8rB3PDU2LIIcLU2N14VWPvUcauq8m/SiEtXOcz3nYRniw5cG30Ak3NHnEj61WsXUIR1CBzS9Kk8AlCYEoiybM= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com; spf=pass smtp.mailfrom=opensource.cirrus.com; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b=bFWXAnCN; dkim=pass (1024-bit key) header.d=cirrus4.onmicrosoft.com header.i=@cirrus4.onmicrosoft.com header.b=lpoEDt/H; arc=fail smtp.client-ip=67.231.149.25 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=opensource.cirrus.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b="bFWXAnCN"; dkim=pass (1024-bit key) header.d=cirrus4.onmicrosoft.com header.i=@cirrus4.onmicrosoft.com header.b="lpoEDt/H" Received: from pps.filterd (m0077473.ppops.net [127.0.0.1]) by mx0a-001ae601.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5834oIup858992; Wed, 3 Sep 2025 04:46:01 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= PODMain02222019; bh=1JS2GqWAEBa5huokXYLwTrGnM7JThX4/T5SOpoCCYDw=; b= bFWXAnCNMfSQNSBsoiOjBM3yr88T77Si03tk7IZStvPFejuoMoZDYG/IiUHkbeaZ vp/3Zb/HqOdp1PIp+wCF0E6w/FNKPvoILBLxKdE7sbYcLULDWGq6lESiCHlo2D1o jUEXvq3JEMFOUUf2QfhJwmMnRzRGvxpXzwK/tiuS8OOtsx4/5NUZfiQVcVUVTr5A vsmc885pGqFfHmhH/qg4BrUvO55xrYXsfJcqfnnejcEBmQ/WN26l/LKsULc9lU79 dc8qBxYDwpYlIhTU5y4iG9L4+hAHr/jMRTCBiN101pphe9cRixc84MaxYBN2lG5h d9W0PrEma3bIGeSNN7myNw== Received: from nam10-dm6-obe.outbound.protection.outlook.com (mail-dm6nam10hn2213.outbound.protection.outlook.com [52.100.156.213]) by mx0a-001ae601.pphosted.com (PPS) with ESMTPS id 48vensc6d4-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 03 Sep 2025 04:46:01 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=sejGN86CZozrovixuVM4xP16W5Z8ioo57kzqT0x54hJpNOFAGvpdmVjEbwOYBYy7sw41P+ExEMXk/rpEEML6XvkmvbTLoQs6zqkeGakULWj36mYUSGToAzvfEYqZCoKL/miHRELuP4HBu08KkhWCFuz0WJFE4ftJcn7YoH6V+XSik/hG3yZrgXPsjIlk/75QOt1AIIQCL6wROoPkZXThEtmq9KUEoFNagBsItR2WKcsLYH8B4bqN2bizO5CAoQigBxo5QXs18WS7YTGQfGXX3oiRq90x3UlAit0DbllMg5TggCXjii/9hx4klDB+QAGdCvu5hlSagtYftUcF6P8k/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1JS2GqWAEBa5huokXYLwTrGnM7JThX4/T5SOpoCCYDw=; b=CD+QqhZq6vbVtERImGV6m0Xk9zm01YuWEPDaU75yAIWZb0Ruy1YmM31JJ+aYBU0WC70DmF4HEeIjzdohw66OnYrI01EAMMy/gNPOYXZ08Kdjk5ckoylgNgrt0zEvUoDhwz0SE43olKB0ld+KUCHHw/aiYdsCjps7a3lor6XGGTG2Aqr9ts0fwiLEz5UbqaZp0wXoJMnsV9zBTcCyhj/vMH7BmY9PoyQ25VrkU/ivSFvkxxiqvYpEa4LQu1ngEU1wU00DCOxv5l+VLWoeYjKziZ6Yy/DxsfpdWHUrTE4k3S+hatAsJq9OE+ZD+wVrJNgp32tS+BAGb8L4ujY4Y241bQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=fail (sender ip is 84.19.233.75) smtp.rcpttodomain=cirrus.com smtp.mailfrom=opensource.cirrus.com; dmarc=fail (p=reject sp=reject pct=100) action=oreject header.from=opensource.cirrus.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus4.onmicrosoft.com; s=selector2-cirrus4-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1JS2GqWAEBa5huokXYLwTrGnM7JThX4/T5SOpoCCYDw=; b=lpoEDt/Hydg1o5S+LUs4+ydC0e4Z7Pv89DIqA2R9ZHD7ziWn0+uBhZM34V7AtVcVMtU2NtR04hdfXVz1tmMmCR/NRB5AKoYdcAGd/wM3/s9ckVZkFzuRuF7A7VnnaDiMYIwhSKDysBxFEW+cR0PtqWdzOW88EwK5U+Q06rMfG1I= Received: from BN0PR04CA0136.namprd04.prod.outlook.com (2603:10b6:408:ed::21) by SA6PR19MB8676.namprd19.prod.outlook.com (2603:10b6:806:41b::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9073.27; Wed, 3 Sep 2025 09:45:57 +0000 Received: from BN3PEPF0000B06D.namprd21.prod.outlook.com (2603:10b6:408:ed:cafe::2) by BN0PR04CA0136.outlook.office365.com (2603:10b6:408:ed::21) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9073.27 via Frontend Transport; Wed, 3 Sep 2025 09:45:57 +0000 X-MS-Exchange-Authentication-Results: spf=fail (sender IP is 84.19.233.75) smtp.mailfrom=opensource.cirrus.com; dkim=none (message not signed) header.d=none;dmarc=fail action=oreject header.from=opensource.cirrus.com; Received-SPF: Fail (protection.outlook.com: domain of opensource.cirrus.com does not designate 84.19.233.75 as permitted sender) receiver=protection.outlook.com; client-ip=84.19.233.75; helo=edirelay1.ad.cirrus.com; Received: from edirelay1.ad.cirrus.com (84.19.233.75) by BN3PEPF0000B06D.mail.protection.outlook.com (10.167.243.72) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9115.0 via Frontend Transport; Wed, 3 Sep 2025 09:45:56 +0000 Received: from ediswmail9.ad.cirrus.com (ediswmail9.ad.cirrus.com [198.61.86.93]) by edirelay1.ad.cirrus.com (Postfix) with ESMTPS id 42EAA406545; Wed, 3 Sep 2025 09:45:53 +0000 (UTC) Received: from ediswws07.ad.cirrus.com (ediswws07.ad.cirrus.com [198.90.208.14]) by ediswmail9.ad.cirrus.com (Postfix) with ESMTPSA id 2B4BB82026B; Wed, 3 Sep 2025 09:45:53 +0000 (UTC) From: Charles Keepax To: broonie@kernel.org, lee@kernel.org Cc: lgirdwood@gmail.com, linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, patches@opensource.cirrus.com Subject: [PATCH 3/6] ASoC: cs42l43: Disable IRQs in system suspend Date: Wed, 3 Sep 2025 10:45:46 +0100 Message-ID: <20250903094549.271068-4-ckeepax@opensource.cirrus.com> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250903094549.271068-1-ckeepax@opensource.cirrus.com> References: <20250903094549.271068-1-ckeepax@opensource.cirrus.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN3PEPF0000B06D:EE_|SA6PR19MB8676:EE_ X-MS-Office365-Filtering-Correlation-Id: baf3eb52-acff-46b7-1967-08ddeaceae52 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|61400799027|34020700016|82310400026|36860700013|376014|12100799063; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?oPkHJ8KBTekqGvITdNVx9bCfNFDQ2FoZFIPq+8wwu33KoO4/Kcfcz+V7oPMu?= =?us-ascii?Q?osxYtMM8Xj/n11guxkCeK/6gJm/o/SB2qw9EnhjSB9MThMJQgJD5/S4E+sDW?= =?us-ascii?Q?QW0izHivmBAaJ2Y8WDm0wuEsBFvCF7Cd+UftaZPfWvXCH1KsL8IYO7A6KMpH?= =?us-ascii?Q?wpwynqjqZ9vGmlIfsX/CSGPydvmziDDi5PT6EYgq64b4Kk8L6phbWLvsTop6?= =?us-ascii?Q?0bTr1/AEO/YBtilw8EKcAwNUf2rMhyKRHhQSodkrcKcbunO255jYw9ngAU8c?= =?us-ascii?Q?eBgkz/c0c5U6+Bmbdu+tXDquUy579eVrk545udmtW9Y0NeSCogRQIebchu8c?= =?us-ascii?Q?MJv1mDVCotP9MhkJvJ/4n8hZRxOMm6LFZc97/09QBG2UckYyw/IOCtPcP+IT?= =?us-ascii?Q?7iO8gsxwSxZoqiIPQ7hk5ol21OuOB6qM0yERGvUqMl2gMWjP60mTv5KkFZij?= =?us-ascii?Q?9VKFjB3xv4GFCYcX3zED757iQ3bEzalMzSOM1toKHvHQ6zkJUIcSlbsAa5vA?= =?us-ascii?Q?ik9nq2TKiNd2wUZepXqHHQQ0kjvk+mB9pshZpWQ/ozGGA3o6eHx8+SQUj4/5?= =?us-ascii?Q?cXl0mtB74I/tEphTENcplvpCKESEaSekW/DzFgTI4V3EvlgB0qX0RH9LcQti?= =?us-ascii?Q?LDlHB3xTfhfTWP3JOdN9bq+u7JCoRH9n15hj+bf1fuY8syK8yNGcCgx1bQE9?= =?us-ascii?Q?gjQbgAJd1MFSN8qSDCZ4ut9za0sNsoThKsRtzK8gWmVK5HGrnFUb/Jq6Bdp/?= =?us-ascii?Q?EDQMMwv16KD15wP7PQ0hSHYnfbONgoTxpREDiqVS5ROT2KkkZ6x9lmfQbT9B?= =?us-ascii?Q?F6l+hlJ8J0kM6bdvYBWwBdcCI+oHVvpPPXTIy+JpQ2AEEKDeLpokUmqbCve9?= =?us-ascii?Q?/Kyo2Obr/ud/c02lDaRfs4BeGIa3/3usXcnrd99m73B6mgbvNHA9+6i38qEP?= =?us-ascii?Q?6iyLbyVJT42GkzKk0VXa0HwA95wT9mm4L+F4jmoUopoVIZTM0EDyP5FGkEwv?= =?us-ascii?Q?kgEGMKFAGCqtOqOeL3z/746djWHprBmYkynLRKCP0tkw2JSy6vjej/Mp9W/m?= =?us-ascii?Q?zACcphqAvBTwpDU72iartALYW4RZ8Gu9M8/3zEOprJLlCjx4c/a+LBh6qBah?= =?us-ascii?Q?fcfuNEHAAovHdpcRSQVloEUlQrUlIFWR2ZfHiuV+YxB4fLRvoGSLk71ZgXcV?= =?us-ascii?Q?pb1EK0hJpBJoRAe5reDvEkmcmSZyF3JtGRe/WUq8zfLhzWVOT1m8XJuzCM01?= =?us-ascii?Q?dtwXMSiYEQEaZVpSuyBsk46JQronkM8DXHEPrJPvSS42dATjtLSRSIJrjnOl?= =?us-ascii?Q?Kvc3Q9x1b+8vY5+ZgmmuqIYZxxppVHKG4QV0rZVk82mgBRMFeBJMr+3VP1CS?= =?us-ascii?Q?CVeICSZ8iDqB16MdqCYXrzaM+WIe/yddg0AX5P8p+C0SBD2xy+HESBFIgg/G?= =?us-ascii?Q?aDMEFzi3EB81llmHNfTlCrPTS9nmD/TpXTJzZ3MlCKbYq6iSCqQBq/Uqh1Be?= =?us-ascii?Q?yggmFyyF+D1e4bV3lEN5+LwJkcsYrP4e5YPh?= X-Forefront-Antispam-Report: CIP:84.19.233.75;CTRY:GB;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:edirelay1.ad.cirrus.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(61400799027)(34020700016)(82310400026)(36860700013)(376014)(12100799063);DIR:OUT;SFP:1501; X-OriginatorOrg: opensource.cirrus.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Sep 2025 09:45:56.3097 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: baf3eb52-acff-46b7-1967-08ddeaceae52 X-MS-Exchange-CrossTenant-Id: bec09025-e5bc-40d1-a355-8e955c307de8 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=bec09025-e5bc-40d1-a355-8e955c307de8;Ip=[84.19.233.75];Helo=[edirelay1.ad.cirrus.com] X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TreatMessagesAsInternal-BN3PEPF0000B06D.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA6PR19MB8676 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwOTAzMDA5NyBTYWx0ZWRfX2zxxFE5Vcv6g 2JtRrdhfdcJB0dWO8WJ8Tg1hyvUw+iDo2qiM1RnGElSf2oU4DQAhL4c0quj/f7hfJEpzb4tS7FA gsRMobGoQs/6B4nBhK9hBlW8pYjRFpPeu5X5yZlkrH0h6xRlgnfsFJtIVHPM9RVLCmS8Gd5JXAw +c57xSW6Sz2rcH6S1Vj8lmJjard9NDGDVLdKQYy2ebOS/ZOuI3lpdMezE/UwBakR6epsAtTDY0/ jcFRxkd45MaPKPDOHMyi1olwUSGb6p/WoitGhXN0kwIjjMLHZxsrKYm2XKzNPf7c6o8m+AuIz1+ 66Pnqj5jDjjNtVzxJZ22X2aHv4k0em6r/agjpCrlHBguDjXH241x0hWIu7xF58= X-Authority-Analysis: v=2.4 cv=BY/Y0qt2 c=1 sm=1 tr=0 ts=68b80e59 cx=c_pps a=iNF5YVRtssmCLvDReD0Rxg==:117 a=h1hSm8JtM9GN1ddwPAif2w==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=yJojWOMRYYMA:10 a=s63m1ICgrNkA:10 a=RWc_ulEos4gA:10 a=w1d2syhTAAAA:8 a=WGF-i4tbfY4VCuSaCLUA:9 a=jZz-an6Pvt0H8_Yc_ROU:22 X-Proofpoint-GUID: FXqVLiCypbHdKkkrx05kEiurPLCGYide X-Proofpoint-ORIG-GUID: FXqVLiCypbHdKkkrx05kEiurPLCGYide X-Proofpoint-Spam-Reason: safe Content-Type: text/plain; charset="utf-8" Currently the MFD driver disables all the IRQs upon entering system suspend, however there are some issues with this approach. As this device uses runtime force suspend. The regmap IRQ handler can run, claim a PM runtime reference and get scheduled, the MFD can then force suspend. When the IRQ thread gets rescheduled it will try to access volatile registers on the suspended device. Furthermore, this race also applies to work queue items scheduled by the IRQ handlers. As the MFD code doesn't know about the individual work queue items, the end drivers must mask their own IRQs and sync in any work queues as part of entering system suspend. Update the code here to do so. Signed-off-by: Charles Keepax --- sound/soc/codecs/cs42l43.c | 78 ++++++++++++++++++++++++++++++-------- sound/soc/codecs/cs42l43.h | 1 + 2 files changed, 64 insertions(+), 15 deletions(-) diff --git a/sound/soc/codecs/cs42l43.c b/sound/soc/codecs/cs42l43.c index 241f7d013189c..405926149a137 100644 --- a/sound/soc/codecs/cs42l43.c +++ b/sound/soc/codecs/cs42l43.c @@ -2229,12 +2229,29 @@ static int cs42l43_request_irq(struct cs42l43_codec= *priv, return 0; } =20 +static void cs42l43_disable_irq(struct cs42l43_codec *priv, unsigned int i= rq) +{ + int ret; + + ret =3D irq_find_mapping(priv->dom, irq); + if (ret > 0) + disable_irq(ret); +} + +static void cs42l43_enable_irq(struct cs42l43_codec *priv, unsigned int ir= q) +{ + int ret; + + ret =3D irq_find_mapping(priv->dom, irq); + if (ret > 0) + enable_irq(ret); +} + static int cs42l43_shutter_irq(struct cs42l43_codec *priv, unsigned int sh= utter, - const char * const open_name, - const char * const close_name, + const char * const open_name, unsigned int *open_irq, + const char * const close_name, unsigned int *close_irq, irq_handler_t handler) { - unsigned int open_irq, close_irq; int ret; =20 switch (shutter) { @@ -2242,26 +2259,26 @@ static int cs42l43_shutter_irq(struct cs42l43_codec= *priv, unsigned int shutter, dev_warn(priv->dev, "Manual shutters, notifications not available\n"); return 0; case 0x2: - open_irq =3D CS42L43_GPIO1_RISE; - close_irq =3D CS42L43_GPIO1_FALL; + *open_irq =3D CS42L43_GPIO1_RISE; + *close_irq =3D CS42L43_GPIO1_FALL; break; case 0x4: - open_irq =3D CS42L43_GPIO2_RISE; - close_irq =3D CS42L43_GPIO2_FALL; + *open_irq =3D CS42L43_GPIO2_RISE; + *close_irq =3D CS42L43_GPIO2_FALL; break; case 0x8: - open_irq =3D CS42L43_GPIO3_RISE; - close_irq =3D CS42L43_GPIO3_FALL; + *open_irq =3D CS42L43_GPIO3_RISE; + *close_irq =3D CS42L43_GPIO3_FALL; break; default: return 0; } =20 - ret =3D cs42l43_request_irq(priv, close_name, close_irq, handler, IRQF_SH= ARED); + ret =3D cs42l43_request_irq(priv, close_name, *close_irq, handler, IRQF_S= HARED); if (ret) return ret; =20 - return cs42l43_request_irq(priv, open_name, open_irq, handler, IRQF_SHARE= D); + return cs42l43_request_irq(priv, open_name, *open_irq, handler, IRQF_SHAR= ED); } =20 static int cs42l43_codec_probe(struct platform_device *pdev) @@ -2325,14 +2342,16 @@ static int cs42l43_codec_probe(struct platform_devi= ce *pdev) } =20 ret =3D cs42l43_shutter_irq(priv, val & CS42L43_MIC_SHUTTER_CFG_MASK, - "mic shutter open", "mic shutter close", + "mic shutter open", &priv->shutter_irqs[0], + "mic shutter close", &priv->shutter_irqs[1], cs42l43_mic_shutter); if (ret) goto err_pm; =20 ret =3D cs42l43_shutter_irq(priv, (val & CS42L43_SPK_SHUTTER_CFG_MASK) >> CS42L43_SPK_SHUTTER_CFG_SHIFT, - "spk shutter open", "spk shutter close", + "spk shutter open", &priv->shutter_irqs[2], + "spk shutter close", &priv->shutter_irqs[3], cs42l43_spk_shutter); if (ret) goto err_pm; @@ -2386,19 +2405,48 @@ static int cs42l43_codec_runtime_resume(struct devi= ce *dev) static int cs42l43_codec_suspend(struct device *dev) { struct cs42l43_codec *priv =3D dev_get_drvdata(dev); + int i; =20 dev_dbg(priv->dev, "System suspend\n"); =20 priv->suspend_jack_debounce =3D true; =20 - pm_runtime_force_suspend(dev); + for (i =3D 0; i < ARRAY_SIZE(cs42l43_irqs); i++) + cs42l43_disable_irq(priv, cs42l43_irqs[i].irq); + + for (i =3D 0; i < ARRAY_SIZE(priv->shutter_irqs); i++) + if (priv->shutter_irqs[i]) + cs42l43_disable_irq(priv, priv->shutter_irqs[i]); + + cancel_delayed_work_sync(&priv->bias_sense_timeout); + cancel_delayed_work_sync(&priv->tip_sense_work); + cancel_delayed_work_sync(&priv->hp_ilimit_clear_work); + + return pm_runtime_force_suspend(dev); +} + +static int cs42l43_codec_resume(struct device *dev) +{ + struct cs42l43_codec *priv =3D dev_get_drvdata(dev); + int ret, i; + + ret =3D pm_runtime_force_resume(dev); + if (ret) + return ret; + + for (i =3D 0; i < ARRAY_SIZE(cs42l43_irqs); i++) + cs42l43_enable_irq(priv, cs42l43_irqs[i].irq); + + for (i =3D 0; i < ARRAY_SIZE(priv->shutter_irqs); i++) + if (priv->shutter_irqs[i]) + cs42l43_enable_irq(priv, priv->shutter_irqs[i]); =20 return 0; } =20 static const struct dev_pm_ops cs42l43_codec_pm_ops =3D { RUNTIME_PM_OPS(NULL, cs42l43_codec_runtime_resume, NULL) - SYSTEM_SLEEP_PM_OPS(cs42l43_codec_suspend, pm_runtime_force_resume) + SYSTEM_SLEEP_PM_OPS(cs42l43_codec_suspend, cs42l43_codec_resume) }; =20 static const struct platform_device_id cs42l43_codec_id_table[] =3D { diff --git a/sound/soc/codecs/cs42l43.h b/sound/soc/codecs/cs42l43.h index f4ef93d1fc2a4..0951ad3525efe 100644 --- a/sound/soc/codecs/cs42l43.h +++ b/sound/soc/codecs/cs42l43.h @@ -45,6 +45,7 @@ struct cs42l43_codec { struct cs42l43 *core; struct snd_soc_component *component; struct irq_domain *dom; + unsigned int shutter_irqs[4]; =20 struct clk *mclk; =20 --=20 2.47.2 From nobody Fri Oct 3 08:49:13 2025 Received: from mx0b-001ae601.pphosted.com (mx0a-001ae601.pphosted.com [67.231.149.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A25F81922F6; Wed, 3 Sep 2025 09:46:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=67.231.149.25 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756892776; cv=fail; b=LQVF4GHDVOOQ6/N76A+8kxqiEZ8oHBBGqN0gq8ccdOdaw/aNTBbiVDCSdPhIiigkg25lQJODCJPYUzcHYQk7RePjXW9j3+Hj65X1rqNnfZdPu9NPj5mcQLd60cld9zh5kmkwaw/o1Ob93K2c65Jc1Xc5/ej7rcFlK2Yn/BsP0F4= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756892776; c=relaxed/simple; bh=IyzUE1/0wYPpEP7wGfJAgUMe+dATxs2xHVYIJFSM4L4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=dlv3W0C6rfvpuC8KiUKaf6kT66+i6USzG2Ung0dYf+fHFXdRL1f6RIlGm1MbZwa7/0qwnpph6nxvCjeoHOlw0wHjPTlVtZyId3BVVswZ7+teZwUWZevCxOpbozH3LKgL9u+FPIQfu8LFYmMpBpyDQbjt3ucUfTNt8YXZdQ0uiVE= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com; spf=pass smtp.mailfrom=opensource.cirrus.com; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b=Zc1MzSIU; dkim=pass (1024-bit key) header.d=cirrus4.onmicrosoft.com header.i=@cirrus4.onmicrosoft.com header.b=Dh4tzCCs; arc=fail smtp.client-ip=67.231.149.25 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=opensource.cirrus.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b="Zc1MzSIU"; dkim=pass (1024-bit key) header.d=cirrus4.onmicrosoft.com header.i=@cirrus4.onmicrosoft.com header.b="Dh4tzCCs" Received: from pps.filterd (m0077473.ppops.net [127.0.0.1]) by mx0a-001ae601.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 582IRcuR1987260; Wed, 3 Sep 2025 04:46:00 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= PODMain02222019; bh=/2k2z2JGOB1TkxhT9PeQH/FC7bHLo9usvB1q+EbVfJo=; b= Zc1MzSIUbNgZ5gQOL7sfC0Z3rUFoLUue1i+xEKSVouy5woFWyqMVDdk87yO/QFle G0nxZnfIfhKEIeGtncpuK849E1f2Ai327tIC8FR8BeofH/pVrk4MvUkZRXwV8NwH WnyIjDHsaRsb1lKThM1vtqVssh2/HX5ORJqPXx5FyvMb290D4UBXMreMdr8UnZaW 9XZl3HntK6vbqar3G+/hIVewxmG/64hVn3+n74MbBbkvapv0IBgdifHeW+JuuD9f wKRbslM8vCTAf7olZWzxmgtRayzk6PSY3mSZjvRahdLVXU1kGNGlHqRuxw+TRI2h cJBtnAjRoBCYpIFXohhr+A== Received: from nam02-sn1-obe.outbound.protection.outlook.com (mail-sn1nam02hn2245.outbound.protection.outlook.com [52.100.159.245]) by mx0a-001ae601.pphosted.com (PPS) with ESMTPS id 48vensc6d1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 03 Sep 2025 04:45:59 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=L5k5QCn8VrFG32qYDzS+yE6foOBh6HVzPC+s3KtoMqA5zsBBGD9QgPMRhcwGPJMvDdaHVcoE3+QvnIoupNhs4DONdbiHMFL1bpyXTe4KQEU8KVKaA7EJeBP8lnYPQk7MR8YJ9UShS4OC1BT8jVZqOKHJZpl8VfYpSJQOCFsw8fNbBG8XXg3i6KaKiDd43/0ZLxawD3tO63MU1PAZ05InhR+yflEBADZ4YUq0NpYd7hCRuAOO6QVvxWFuxsvW2KUNRBoMA5oCNcERbG+dd0Hc1jjVBHtlZAvVAhREQMdFuhZM+L09Rb8epWK4ZSuZxx1ysxuge59RkhN0WrwDTFvZKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/2k2z2JGOB1TkxhT9PeQH/FC7bHLo9usvB1q+EbVfJo=; b=yajtYlq9h4vmakhvQ5CGnoGuOPT5GhvCKrGslLKTHJQvqHkVPlmYqKE7h8HC4sDys8brM9PCbhrmO6cenyr2/cqtlljAS++SyuALt2r8YrPSlb7WRyB++TtsyPB9rQ6fnAXPAUXP63S11pTj6c/e0NBbzB3qt3VosVJO8yErapeFeQ/++Ta9o/M2Q3gpqTFdQCOZVfKI0LKEHGBayGaVqNDNUdVBPi9NBb/Ywn87AZB+mK6UCESonu5IhGeym07CnuMvpr2XhZ5i1CD4f0NnORxTok6BgLRYlNPfzsXhrtF5liBctmhstyFxqDW9ov/y0rzHKKNiC2GvEVvNrcXM/A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=fail (sender ip is 84.19.233.75) smtp.rcpttodomain=cirrus.com smtp.mailfrom=opensource.cirrus.com; dmarc=fail (p=reject sp=reject pct=100) action=oreject header.from=opensource.cirrus.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus4.onmicrosoft.com; s=selector2-cirrus4-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/2k2z2JGOB1TkxhT9PeQH/FC7bHLo9usvB1q+EbVfJo=; b=Dh4tzCCsjn5CiXqXjO9eLKXIGxDN5oDFCUxSY9PXpt9rgf7pI/y6jJrSWBgY9LINlBDdl7K1B5z0O6dH37wwcXl/xqWIvw7qomZtfXbImIZYMKz0Iw+toGD4duJTHNsFerhN+PMIYv7/KNoK9EtY68crAaC35WP6RVI91HKPwK4= Received: from CH0PR07CA0001.namprd07.prod.outlook.com (2603:10b6:610:32::6) by CO6PR19MB4737.namprd19.prod.outlook.com (2603:10b6:5:351::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9073.27; Wed, 3 Sep 2025 09:45:56 +0000 Received: from CH2PEPF0000009A.namprd02.prod.outlook.com (2603:10b6:610:32:cafe::df) by CH0PR07CA0001.outlook.office365.com (2603:10b6:610:32::6) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9094.16 via Frontend Transport; Wed, 3 Sep 2025 09:45:55 +0000 X-MS-Exchange-Authentication-Results: spf=fail (sender IP is 84.19.233.75) smtp.mailfrom=opensource.cirrus.com; dkim=none (message not signed) header.d=none;dmarc=fail action=oreject header.from=opensource.cirrus.com; Received-SPF: Fail (protection.outlook.com: domain of opensource.cirrus.com does not designate 84.19.233.75 as permitted sender) receiver=protection.outlook.com; client-ip=84.19.233.75; helo=edirelay1.ad.cirrus.com; Received: from edirelay1.ad.cirrus.com (84.19.233.75) by CH2PEPF0000009A.mail.protection.outlook.com (10.167.244.22) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9052.8 via Frontend Transport; Wed, 3 Sep 2025 09:45:54 +0000 Received: from ediswmail9.ad.cirrus.com (ediswmail9.ad.cirrus.com [198.61.86.93]) by edirelay1.ad.cirrus.com (Postfix) with ESMTPS id 43AEB40654E; Wed, 3 Sep 2025 09:45:53 +0000 (UTC) Received: from ediswws07.ad.cirrus.com (ediswws07.ad.cirrus.com [198.90.208.14]) by ediswmail9.ad.cirrus.com (Postfix) with ESMTPSA id 2E61682026C; Wed, 3 Sep 2025 09:45:53 +0000 (UTC) From: Charles Keepax To: broonie@kernel.org, lee@kernel.org Cc: lgirdwood@gmail.com, linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, patches@opensource.cirrus.com Subject: [PATCH 4/6] ASoC: cs42l43: Shutdown jack detection on suspend Date: Wed, 3 Sep 2025 10:45:47 +0100 Message-ID: <20250903094549.271068-5-ckeepax@opensource.cirrus.com> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250903094549.271068-1-ckeepax@opensource.cirrus.com> References: <20250903094549.271068-1-ckeepax@opensource.cirrus.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PEPF0000009A:EE_|CO6PR19MB4737:EE_ X-MS-Office365-Filtering-Correlation-Id: 6d532ca1-7804-4775-ac86-08ddeacead2d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|61400799027|82310400026|36860700013|34020700016|12100799063; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?LAu3Iur+Sw3iZgr1p1LjfxP+/QoIqQYJyizzMmZP41FiVCAHigPtU6eGeA7y?= =?us-ascii?Q?q8ak0DiPqAdFce4JQNGrQGcO4UAxIWbD6JL3/qKb1+mTzSX28rEbOgg65zO/?= =?us-ascii?Q?GSriNo6YP4oZLzyMqhYGuRZWvsBHm9N2eAyQGCXFO3HPyKJBwiSu/wZuSyIU?= =?us-ascii?Q?30JYIRPSLxw2xrfdaMxZJTFEAlDj3HtLe6MlUTMNlCzS/ZWi1luJsDNWSnYH?= =?us-ascii?Q?mrCBpfiF3/rQzLfphWCSXMskukvJECY+cW0Do13ItukUcIQF12po9Hyb/+he?= =?us-ascii?Q?DYsSCfm8xrhRLFa62iBsb7G4iMmUxGkLlNjmYTGYTWnaK/gCUBLmP8rCFNuX?= =?us-ascii?Q?0GfIYz0SrVDYIzm5la16ko5UJzhRHsOiUts8ys0IopHhZCaBc2DA1aRaCbc3?= =?us-ascii?Q?3OlXjJ85JHvGym1wVkZySZidJvUe8ZtUaXwcftBNMHQm+2Zm1y/Cxbf7IGun?= =?us-ascii?Q?fVR4PXDLdsEDafwBZCnxGmWbb/eqSOMZ+h5aOQ9tVuXXYA7e9s48toziDKEu?= =?us-ascii?Q?DhEpyoXtXmzkFHG2S5GtOchnFASpuyQIXpeuGYq0xb9+rVRBA1Fdo52f7qeU?= =?us-ascii?Q?34iBuVrTpPxGEpRhUNnk3Kf9Y6DCmmtTJQKmsf9isVyT90NmOjZNp9x1ItR5?= =?us-ascii?Q?7YobKT2acDZwR1Pttlw+6I2m6TKUiRMoWY7OG4Pgbz1v9J7IWl5ObnpaoU/k?= =?us-ascii?Q?msQE1TmS16NqMoXPJ9EyKi4hVixCA7VjKNLDI8+zfjMzfgdzAaB0Wi84X5NQ?= =?us-ascii?Q?v4pUAqWukV/E6EpqpNA8kRVkeC3Mrtf6moFeXOh/adwqznV6qlJjTdUmz5Lw?= =?us-ascii?Q?TZJ4jgHmMlNexClDRQENoAzmn7r2kkR6KOwiWeHR8nTmnkhELa0ggynH8Vuv?= =?us-ascii?Q?/uc+3tJ7BjuLgofwJde76GYw3AFyfLtgxjbCNQgq/AqLTRTJH6rMmAls2dbX?= =?us-ascii?Q?4/Qh1NslZPCNIPDgPfBT4MHXvGycUczLz1HK2DHAevteQNM+RkYATSV7gfMx?= =?us-ascii?Q?wS0uZeXCHxW6j6rZUdHfG67QjAxES/qCl/Dlv7te+1jLf2Y6o6Kz4u5yWhM6?= =?us-ascii?Q?Di8BFq2Orr7IMl91kdLY2iOCc+gIiH5cG8b/OX1V25IZs+vExOjZ3q6BPnZ5?= =?us-ascii?Q?GhF3+6qnDNUoq1m2XgUKbqIi0EIPiSEx7BRg4gTD8wfCTRw97yTt2fTAa/fq?= =?us-ascii?Q?YZsLDEvmqIPpNOsrd3G2SsS1okZZsUCQ4J6bzMXIhl7CidxJwGaVssfJTz+f?= =?us-ascii?Q?3dOuUA3LmgLNWbhvD4uuL6Hsbv3JoW7Kj1g2/orPAwhf/n+WZaRV99Me2hbv?= =?us-ascii?Q?NmhDszuxMXzCK8igM22YdDch/UVveTlDDZeTl1w/RhZBuv1fsrQO52K+eY8t?= =?us-ascii?Q?qSB/5vAz+tpaY99BvTlVHPWu0SobiUXQLUE1OuFHkPOIaNhIpG8XNAAkHNF3?= =?us-ascii?Q?KvOWdzIJd0q7XnWMlFSzVFjRtc+/b5ypBX0rYMhuWK43ozRszzHGasvjhdko?= =?us-ascii?Q?O0e7T/fc8LXGw67WuXJ0oL9etIrDoZzd1fFG?= X-Forefront-Antispam-Report: CIP:84.19.233.75;CTRY:GB;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:edirelay1.ad.cirrus.com;PTR:ErrorRetry;CAT:NONE;SFS:(13230040)(376014)(61400799027)(82310400026)(36860700013)(34020700016)(12100799063);DIR:OUT;SFP:1501; X-OriginatorOrg: opensource.cirrus.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Sep 2025 09:45:54.3782 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6d532ca1-7804-4775-ac86-08ddeacead2d X-MS-Exchange-CrossTenant-Id: bec09025-e5bc-40d1-a355-8e955c307de8 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=bec09025-e5bc-40d1-a355-8e955c307de8;Ip=[84.19.233.75];Helo=[edirelay1.ad.cirrus.com] X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TreatMessagesAsInternal-CH2PEPF0000009A.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR19MB4737 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwOTAzMDA5NyBTYWx0ZWRfX2rctihLzn1ji JPVlUnfxLXEWckMlThM97rt8aMB7TpE19bdnpfwpTgJ6g0Ne5xJ4Idz9OsGrF/pLcm+gLRiXAcr MsPZiVXDhGahwlE4mC5nOfmwGF3lMrBaljMbVNovqseAWozBFo7sWf6MwKgDmokBLVyizHEU7Zm dYjFADPUD33czrmxoP36uBJHOMVJcGu0jrezcTxQxWSHclr96HO1bamkM+tcg1lOxWfAI4tLaot Q5T/DhXnvO2e5AYHfrHeS3vulQoyaGl0fwjUudA5rYMVudaWpgs5rKmRMcLfa5SfLcskjwbDKIa +LlIBJsqdxGZPhVXc3vDO7K+qJhDe6CdZJnXkcmV+/r7HvAgQZs+B50jDwordo= X-Authority-Analysis: v=2.4 cv=BY/Y0qt2 c=1 sm=1 tr=0 ts=68b80e57 cx=c_pps a=eVRsmZEBXFlQPGjYG4AgSQ==:117 a=h1hSm8JtM9GN1ddwPAif2w==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=yJojWOMRYYMA:10 a=RWc_ulEos4gA:10 a=w1d2syhTAAAA:8 a=mz1aAddHEDVMvu6kbNAA:9 a=jZz-an6Pvt0H8_Yc_ROU:22 X-Proofpoint-GUID: vuNik4BLczY0Oa3oC67VkBAg6YHAef4X X-Proofpoint-ORIG-GUID: vuNik4BLczY0Oa3oC67VkBAg6YHAef4X X-Proofpoint-Spam-Reason: safe Content-Type: text/plain; charset="utf-8" Fully power down the jack detection on system suspend since the device will not be powered up during. Signed-off-by: Charles Keepax --- sound/soc/codecs/cs42l43-jack.c | 8 +++++--- sound/soc/codecs/cs42l43.c | 2 ++ sound/soc/codecs/cs42l43.h | 1 + 3 files changed, 8 insertions(+), 3 deletions(-) diff --git a/sound/soc/codecs/cs42l43-jack.c b/sound/soc/codecs/cs42l43-jac= k.c index 2a0a4986a9ce8..867e23d4fb8d8 100644 --- a/sound/soc/codecs/cs42l43-jack.c +++ b/sound/soc/codecs/cs42l43-jack.c @@ -684,7 +684,7 @@ static int cs42l43_run_type_detect(struct cs42l43_codec= *priv) } } =20 -static void cs42l43_clear_jack(struct cs42l43_codec *priv) +void cs42l43_clear_jack(struct cs42l43_codec *priv) { struct cs42l43 *cs42l43 =3D priv->core; =20 @@ -703,8 +703,6 @@ static void cs42l43_clear_jack(struct cs42l43_codec *pr= iv) regmap_update_bits(cs42l43->regmap, CS42L43_HS2, CS42L43_HSDET_MODE_MASK | CS42L43_HSDET_MANUAL_MODE_MASK, 0x2 << CS42L43_HSDET_MODE_SHIFT); - - snd_soc_jack_report(priv->jack_hp, 0, 0xFFFF); } =20 void cs42l43_tip_sense_work(struct work_struct *work) @@ -753,6 +751,8 @@ void cs42l43_tip_sense_work(struct work_struct *work) =20 cs42l43_clear_jack(priv); =20 + snd_soc_jack_report(priv->jack_hp, 0, 0xFFFF); + if (cs42l43->sdw && priv->jack_present) { pm_runtime_put(priv->dev); priv->jack_present =3D false; @@ -903,6 +903,8 @@ int cs42l43_jack_put(struct snd_kcontrol *kcontrol, str= uct snd_ctl_elem_value *u =20 cs42l43_clear_jack(priv); =20 + snd_soc_jack_report(priv->jack_hp, 0, 0xFFFF); + if (!override) { queue_delayed_work(system_long_wq, &priv->tip_sense_work, 0); } else { diff --git a/sound/soc/codecs/cs42l43.c b/sound/soc/codecs/cs42l43.c index 405926149a137..b61df09f20cf4 100644 --- a/sound/soc/codecs/cs42l43.c +++ b/sound/soc/codecs/cs42l43.c @@ -2422,6 +2422,8 @@ static int cs42l43_codec_suspend(struct device *dev) cancel_delayed_work_sync(&priv->tip_sense_work); cancel_delayed_work_sync(&priv->hp_ilimit_clear_work); =20 + cs42l43_clear_jack(priv); + return pm_runtime_force_suspend(dev); } =20 diff --git a/sound/soc/codecs/cs42l43.h b/sound/soc/codecs/cs42l43.h index 0951ad3525efe..b2fa2cd1d99f8 100644 --- a/sound/soc/codecs/cs42l43.h +++ b/sound/soc/codecs/cs42l43.h @@ -132,6 +132,7 @@ static inline int cs42l43_sdw_add_peripheral(struct snd= _pcm_substream *substream int cs42l43_set_jack(struct snd_soc_component *component, struct snd_soc_jack *jack, void *d); void cs42l43_bias_sense_timeout(struct work_struct *work); +void cs42l43_clear_jack(struct cs42l43_codec *priv); void cs42l43_tip_sense_work(struct work_struct *work); irqreturn_t cs42l43_bias_detect_clamp(int irq, void *data); irqreturn_t cs42l43_button_press(int irq, void *data); --=20 2.47.2 From nobody Fri Oct 3 08:49:13 2025 Received: from mx0b-001ae601.pphosted.com (mx0a-001ae601.pphosted.com [67.231.149.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A2684252292; Wed, 3 Sep 2025 09:46:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=67.231.149.25 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756892777; cv=fail; b=pkgFkZZvvsVYQEA/+C8LhRlSH+VbPBwK6CCq8kx9yceCUiZuDzq//7+Oxr2IaoW407FKlZH8pdvdd7tVMIx6RN6E8amz+E+5DB+3IIDiFMy2RXVdGDAOjksrBC8Z+clNjyfiZkyw1OKXnMOQbYkY3ViUP2OA6POrLRMv2mcbyHw= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756892777; c=relaxed/simple; bh=Z+KdqWHXtXtqNVgpC4GhAwpKd/hEFegvXkRKFdmTa3s=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=DEYIzbNgLDFDIHPn/Co+r5pcm115ImfYkrRuwKxIPZNX+2/wp/emHJj2y8O/FrUxPFYeMctXVkp6/FlCiqiVEQWwmg5eAasfP66TcVlrcJNtBXJ2q/u6u8CEwaY+w5bmSjnHqJ6xZ+SEecGhuOHvVnaNHNo6U9jdJqyudpY1Iz0= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com; spf=pass smtp.mailfrom=opensource.cirrus.com; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b=UX+EK02E; dkim=pass (1024-bit key) header.d=cirrus4.onmicrosoft.com header.i=@cirrus4.onmicrosoft.com header.b=ANxXmczd; arc=fail smtp.client-ip=67.231.149.25 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=opensource.cirrus.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b="UX+EK02E"; dkim=pass (1024-bit key) header.d=cirrus4.onmicrosoft.com header.i=@cirrus4.onmicrosoft.com header.b="ANxXmczd" Received: from pps.filterd (m0077473.ppops.net [127.0.0.1]) by mx0a-001ae601.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 582MFqVt232307; Wed, 3 Sep 2025 04:46:00 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= PODMain02222019; bh=psW01e4wDzFTCB9A5z+yLmYM5K3NyfZcEMKebOfYkAo=; b= UX+EK02E8/YICLN1kIwElnkEikNihNwZKFsrZtdyCnX0x91WOkETj0JDaVCrd1mM 2LKMJZtqyVD2goSwmQ+OnsudSmqB5rbJsouA0S6RtpE1+gdqBDCXRPGQFEGZm2s7 hx/uZTRif1FlJ2FV1tk7fupo9obSvvlmmN6jGqWSBwStZuo4yFlthXSNLWS6ljNt 76vHuB2qYvbotv24gLmqHCxyqXK29c8r0XYvwOcGK5BW9+9JtRcUfmWwB1a6Mzup 16kYoWNOigNwuPJxW9K/kE50qzItLhclKdMsM7kKCinBlcefxJAPhoawW3wiDcRY UQ8+Rk3xmh+aGW/wgaQ1pQ== Received: from nam10-bn7-obe.outbound.protection.outlook.com (mail-bn7nam10hn2233.outbound.protection.outlook.com [52.100.155.233]) by mx0a-001ae601.pphosted.com (PPS) with ESMTPS id 48vensc6d2-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 03 Sep 2025 04:46:00 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=yt8Dtoz5JIsSstvC9hmiEUMlN2Z3iVGXieJvHadBhANfuuNrcDk7hXf3IHCsq2kWuohALo+hMOna+ey14U8DYkBiUW7z/6j79iqVY7rBW9h4njg/WzkWGWxiqLVxeCcTgyaoekW/X22pn2T7UEy2T2Zm9mFaklKjMNRqzqz1UAIaG5j6R8+3wJUxpypn1pxqGoxutHMbfAr9oXfrI9bB+P1LKCwLR9wTr8tPcdurWJ54oJ+USSJ3KW1lmR6ocDkaZDtlgtJ6ZXRgojOmRCm5i8MTT5B6JJzCCJLZq+extsdbrBrQbNQI0zI+ghiuE6cwgKUM4v1wLSiPNRi/Kv7amA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=psW01e4wDzFTCB9A5z+yLmYM5K3NyfZcEMKebOfYkAo=; b=lw3UshU60MjoRjJbAdbw//rqxTBHZjk+yvn4obHZ7MdWHs70X4u1gLQfhnoamt9+9JTmPoiKIIN11ZWddm+TB+nF98iKkCsgUzyUYSkiltEwSMNR8zcMpmwEyUaXSL7UIJmTNBk0OyPJ9lFndYn3D/lLhxYZsoirdtNO85QdNqeJkUsQICWXQQpLIZJ/TVBDkv0qxe5YPITUTc9lq6AVnVbeRhi/E1OYooUARDQjk1zk4QkMwHouHVGHg7bcwUyb0im2QO+pjhN/y8b0u/9BVX3IU3uMrIh0v993B+vU/0FnDISXZ7EvNyz/EoRIsUWAWZOVEUsbd4afj/AVXcizcA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=fail (sender ip is 84.19.233.75) smtp.rcpttodomain=cirrus.com smtp.mailfrom=opensource.cirrus.com; dmarc=fail (p=reject sp=reject pct=100) action=oreject header.from=opensource.cirrus.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus4.onmicrosoft.com; s=selector2-cirrus4-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=psW01e4wDzFTCB9A5z+yLmYM5K3NyfZcEMKebOfYkAo=; b=ANxXmczdxK24CSzrIpjPFu7psZvhSRQEfpE0J4Eoh07WAkqZnpeaU3jK6POU5KPKHaagVvEVzKf59uDJpg5TVHXQ73Jc4EeFJD26bQgiTTkqjQlMqFd8E/PyFi0i1Pmr6qD4Jc1ZPHQ9HkMRv6SCk0XmFTtefKuJYttbgJov2lk= Received: from BN9PR03CA0286.namprd03.prod.outlook.com (2603:10b6:408:f5::21) by DM3PPF7901E5E8B.namprd19.prod.outlook.com (2603:10b6:f:fc00::739) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9073.21; Wed, 3 Sep 2025 09:45:55 +0000 Received: from BN2PEPF000055DF.namprd21.prod.outlook.com (2603:10b6:408:f5:cafe::b6) by BN9PR03CA0286.outlook.office365.com (2603:10b6:408:f5::21) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9073.26 via Frontend Transport; Wed, 3 Sep 2025 09:45:55 +0000 X-MS-Exchange-Authentication-Results: spf=fail (sender IP is 84.19.233.75) smtp.mailfrom=opensource.cirrus.com; dkim=none (message not signed) header.d=none;dmarc=fail action=oreject header.from=opensource.cirrus.com; Received-SPF: Fail (protection.outlook.com: domain of opensource.cirrus.com does not designate 84.19.233.75 as permitted sender) receiver=protection.outlook.com; client-ip=84.19.233.75; helo=edirelay1.ad.cirrus.com; Received: from edirelay1.ad.cirrus.com (84.19.233.75) by BN2PEPF000055DF.mail.protection.outlook.com (10.167.245.9) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9115.0 via Frontend Transport; Wed, 3 Sep 2025 09:45:54 +0000 Received: from ediswmail9.ad.cirrus.com (ediswmail9.ad.cirrus.com [198.61.86.93]) by edirelay1.ad.cirrus.com (Postfix) with ESMTPS id 47A2D40654F; Wed, 3 Sep 2025 09:45:53 +0000 (UTC) Received: from ediswws07.ad.cirrus.com (ediswws07.ad.cirrus.com [198.90.208.14]) by ediswmail9.ad.cirrus.com (Postfix) with ESMTPSA id 30E7A82025A; Wed, 3 Sep 2025 09:45:53 +0000 (UTC) From: Charles Keepax To: broonie@kernel.org, lee@kernel.org Cc: lgirdwood@gmail.com, linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, patches@opensource.cirrus.com Subject: [PATCH 5/6] mfd: cs42l43: Move IRQ enable/disable to encompass force suspend Date: Wed, 3 Sep 2025 10:45:48 +0100 Message-ID: <20250903094549.271068-6-ckeepax@opensource.cirrus.com> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250903094549.271068-1-ckeepax@opensource.cirrus.com> References: <20250903094549.271068-1-ckeepax@opensource.cirrus.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN2PEPF000055DF:EE_|DM3PPF7901E5E8B:EE_ X-MS-Office365-Filtering-Correlation-Id: d8ad9441-618f-4f86-30dc-08ddeacead06 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|82310400026|61400799027|34020700016|36860700013|12100799063; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?5lNu+r9cxFIc+wgeJ0r5flHjr78Fzl66rF5ayJHRiqDPqAynsSxUMUOWig34?= =?us-ascii?Q?rCziM/9mjtTlZRKqQz/a252ykdv8vbFlpDkUBJT26dN8a7wPanN7u6YBnrio?= =?us-ascii?Q?Gn40jxSMxeIu+Bmti6SjEx82gBBtAPLNRHA/a99dAMPYbuJ6ofUzM0+W1pfg?= =?us-ascii?Q?CO0Joaemdjq3gS32DylgrErDMbEVrlIzZMHk9yZtvCEIW1NPnkSXw5qi61if?= =?us-ascii?Q?chIii+mVykwIoA1l/l0E7at3L7CeQtDplD6yer4xAaiUnGE6Se+wHsFPgCTL?= =?us-ascii?Q?EpjNo1fuLzVN2rs6jnQGPC5V/uajm5Uv1BMh+MqTgR68RyeIiF8UUkf+hF0q?= =?us-ascii?Q?81VlhocMRblHUgx6agAPT8kq9rV06iVtcOkJa5sHvQUhU+YkbGE1Qr2kE7zL?= =?us-ascii?Q?4lBTfYGaic5R7wxN2mrpX3BRmyqXlQ2xvNpUREBWutv3lhueI5NVladMGDzw?= =?us-ascii?Q?iNi3EGJxDi3GBsuWERlK92W1jKSGcytC/qUEANNaqskwub92f/bitBKsErth?= =?us-ascii?Q?2YZHfb1jeSVMao8s1UepIMuZSlzrcAfR3ypLFW3VzJML7aeFl7KrjoFymyuG?= =?us-ascii?Q?+4h8ng5FQwAtExKeIKUtU6bf88UkjP5VSr6cXD5mrzVXoYX052x1Hnr2UciS?= =?us-ascii?Q?+zALi7LRUjsZsyDSZ7PTgZPGWQAjd1nLEl01ZjZYmNEJewxGncvHZ29ZsDlw?= =?us-ascii?Q?Ik4a4UG0xaA0uBWPgJpOKuJphVLeq9A+ZtBlBi4r9lxC6rHDEFKJlVhSeBWM?= =?us-ascii?Q?dZLVZ1g94LxJg/7Nxbj9NFRFLsOOw0ACy58/6ZwnmGhlmhn/+PDBp2sIYRxp?= =?us-ascii?Q?Kvv3m7RaERiCohKJbdmtzBFsqMbIEBSxj0XDxlX3yzVhqkrV/2DNxEKNl0TL?= =?us-ascii?Q?7qU+mNKyfWs5bs9GRv2fwFvCe6D/axi0MgAvmpGmrjviAc6y67yHYTV1Zobq?= =?us-ascii?Q?eFAty7A9/0OAHD+Xhd1sWGgFzusDBuoBc4bfqGFr/tPb+Mw3rYSME1uuCeRt?= =?us-ascii?Q?u3GxKorJ78M/J3mBNFU8MvH64ts1YAMHdbR1DgmRPFxlWb8V08tIOt+sEpQg?= =?us-ascii?Q?L7hVNpp72Hcu3oYbYoMErm09tgnt7tyD6PvgLXC6oYM48wNHJyI3eHHYAqwc?= =?us-ascii?Q?LtiHsAGDhQz04yvB3uIdS0mtkzVHalIE2iee6xPeDEjLvxNqtsGeKEOlx+ne?= =?us-ascii?Q?Qdih7B+jlE/1yqnGxLttQ1lMfIPA6i4QFLH/0/1RIhDvmtjk9QZicu41YImb?= =?us-ascii?Q?XRvgZMljQE4JZ0jIrSR+LW0aszgjoh155/vXVomZlPBk7T2mElYZlaEQsjyK?= =?us-ascii?Q?BtIAqQjNBEv6Y5EY9cpkeDAcmCG1YU4H40tB2+T1H+tJh/yIspn5ZzkRjqxN?= =?us-ascii?Q?iAdFyKb6rE7SD9ppOqycnNGFLCHAQMiDClPTbYd3uEkyAfbE46fBS4tyXULQ?= =?us-ascii?Q?+o1tWg0hOT5JGEJDQG+uexrIC0Rh1b8/wy0vX0mLHY57TL1K3gpB98mCkDwQ?= =?us-ascii?Q?tkl0Xs8sElGzQ4VMqnSdeTKKN/f2AIbPmkaY?= X-Forefront-Antispam-Report: CIP:84.19.233.75;CTRY:GB;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:edirelay1.ad.cirrus.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(376014)(82310400026)(61400799027)(34020700016)(36860700013)(12100799063);DIR:OUT;SFP:1501; X-OriginatorOrg: opensource.cirrus.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Sep 2025 09:45:54.1309 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d8ad9441-618f-4f86-30dc-08ddeacead06 X-MS-Exchange-CrossTenant-Id: bec09025-e5bc-40d1-a355-8e955c307de8 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=bec09025-e5bc-40d1-a355-8e955c307de8;Ip=[84.19.233.75];Helo=[edirelay1.ad.cirrus.com] X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TreatMessagesAsInternal-BN2PEPF000055DF.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM3PPF7901E5E8B X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwOTAzMDA5NyBTYWx0ZWRfX20wGAVcmn4Mn YFY19q2DYrPYGDW529sIoDOe8jblgYWWWbGxcSPgu1M5sdeWRve0kWO8vOIrGUdo7VXEzPAqVpK jLr/9Z5rsJA1QxP18uL7TJi0Wy2mxQyIwI/5cvygdHoq99N43ATmPJT5KYmGMogzhmPhfzSj3Qm SCqKxq+nmFGP1AU6TLefolqeYXll3HcFLVMmR93LsqMUaBxuWd7EL6dQy6OcM3DKTO98zoL952z +X1zCcHPvLEnlvvFpeNCHx2jH+jiKF5KVIpR++Y5hr4pmNyHHVsTlTm/SAyBTe/KxDv1LCvOkr9 L4bAygVjVbI/rZFHZpaxYPf0aTvsnBjc+sNWWe7K2S0SX1gX1/msIWB8SFnHxk= X-Authority-Analysis: v=2.4 cv=BY/Y0qt2 c=1 sm=1 tr=0 ts=68b80e58 cx=c_pps a=CfqBWRf4+9e7MFo2XvKxkw==:117 a=h1hSm8JtM9GN1ddwPAif2w==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=yJojWOMRYYMA:10 a=s63m1ICgrNkA:10 a=RWc_ulEos4gA:10 a=w1d2syhTAAAA:8 a=VsvriT7Q5KnHRFWTihsA:9 a=jZz-an6Pvt0H8_Yc_ROU:22 X-Proofpoint-GUID: 8QdrX3IgLAXVmHWdkguTPcAr91_7z44W X-Proofpoint-ORIG-GUID: 8QdrX3IgLAXVmHWdkguTPcAr91_7z44W X-Proofpoint-Spam-Reason: safe Content-Type: text/plain; charset="utf-8" As pm_runtime_force_suspend() will force the device state to suspend, the driver needs to ensure no IRQ handlers are currently running. If not those handlers may find they are now running on suspended hardware despite holding a PM runtime reference. disable_irq() will sync any currently running handlers, so move the IRQ disabling to cover the whole of the forced suspend state to avoid such race conditions. Signed-off-by: Charles Keepax --- drivers/mfd/cs42l43.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/mfd/cs42l43.c b/drivers/mfd/cs42l43.c index 07c8f1b8183ee..959298c8232f4 100644 --- a/drivers/mfd/cs42l43.c +++ b/drivers/mfd/cs42l43.c @@ -1151,6 +1151,8 @@ static int cs42l43_suspend(struct device *dev) return ret; } =20 + disable_irq(cs42l43->irq); + ret =3D pm_runtime_force_suspend(dev); if (ret) { dev_err(cs42l43->dev, "Failed to force suspend: %d\n", ret); @@ -1164,8 +1166,6 @@ static int cs42l43_suspend(struct device *dev) if (ret) return ret; =20 - disable_irq(cs42l43->irq); - return 0; } =20 @@ -1196,14 +1196,14 @@ static int cs42l43_resume(struct device *dev) if (ret) return ret; =20 - enable_irq(cs42l43->irq); - ret =3D pm_runtime_force_resume(dev); if (ret) { dev_err(cs42l43->dev, "Failed to force resume: %d\n", ret); return ret; } =20 + enable_irq(cs42l43->irq); + return 0; } =20 --=20 2.47.2 From nobody Fri Oct 3 08:49:13 2025 Received: from mx0b-001ae601.pphosted.com (mx0b-001ae601.pphosted.com [67.231.152.168]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 008A4272802; Wed, 3 Sep 2025 09:46:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=67.231.152.168 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756892777; cv=fail; b=BUU5AEUpFH2LvPsTS9XIsX3IwvEojfkMFq6iYUczVgShfIrIuLB3cz9fq9MfS9LJjZEgjEmiE+qX4Koo7lEKGmBNI7DI5di+nxezPwOyBeyoZ87jQcgVhUHU3Ps2f5x3SsJRnjLtNC7tJQnaqG7iYWE1TrfI7uyxUN9D4g1Sz0c= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756892777; c=relaxed/simple; bh=o6LFQclfA99Y63Xj2n835Bfjmv47PbvzpJh5dnjaD6s=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Zm6fd0Jmxm5WdM5I3ZWF9IOizAGEbJ/V7FPNNPX94MtKkCoiJxOlf0XnNST+zbguTo5ci+Z5HQJdK65h6Ap3e8uf+di7XwIXvTvBBO2X5rdDjcZsvI3GzKhzogMW0X88zB9Bza1Gcg8Kkjxe3nUt+YO2zd0b7UCv/G8/0Yr/Q/g= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com; spf=pass smtp.mailfrom=opensource.cirrus.com; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b=MZIac0Av; dkim=pass (1024-bit key) header.d=cirrus4.onmicrosoft.com header.i=@cirrus4.onmicrosoft.com header.b=jlEHBvZV; arc=fail smtp.client-ip=67.231.152.168 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=opensource.cirrus.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b="MZIac0Av"; dkim=pass (1024-bit key) header.d=cirrus4.onmicrosoft.com header.i=@cirrus4.onmicrosoft.com header.b="jlEHBvZV" Received: from pps.filterd (m0077474.ppops.net [127.0.0.1]) by mx0b-001ae601.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 582GW6sY3194543; Wed, 3 Sep 2025 04:46:01 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= PODMain02222019; bh=WgADcaugluWe61r97qE4GJqpqFwgZGletQOxkU45hIg=; b= MZIac0AvlXZmoB0Tbc37q0uZHLGVKJ2Y1KoywcyexpQNrb2igsF9R4YWZyn2/4N+ NaJRRrn662NSXmYuUs0Nsr3MSMsMWMKHtQuVzuOKitPcKrRrr2jx3TUdgS6sw5MH IN2ngDuYigf/xaNGqyqs4wK9G4Ce4nj13iiQOAMuHiMOzYeluYfH4735OQL/9ke/ GU9LbLra638PzwrtjqoEXAe3o7+Yc0IC2Xx8gVLRDuxMyFz2pdwv8Oy4mDkgYt5m 4n3EyPSBHnpCeybBhPyyTQv04/CKRWaboKif7tFODYPgXeZwKsL5BREAzcB4uwaZ 1ki8pjOEDRPx383bRuHyyg== Received: from nam11-dm6-obe.outbound.protection.outlook.com (mail-dm6nam11hn2228.outbound.protection.outlook.com [52.100.172.228]) by mx0b-001ae601.pphosted.com (PPS) with ESMTPS id 48wce2avdv-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 03 Sep 2025 04:46:00 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ECwjmvgQlC8pF8nGIlHxJ0fOjaqWBDLjiX1p42EXslDhfTjGyUYItjnV/Nie9P4jreFZhwAnlE0pgVKQQ0frZo1MEUM/W1xsFVr8W6Vbi/p9ffvoMVwh5m4IcK85e0QBR7EeKJS4sWEKo2kMmBC5LITFBIhcBXVhjJ4XeDJz/GbN4j6UjNuun6CUVTXTIrTUoye0Wpq1DL+sOjg1gh6mpD4BuAniGEDJk+10aI0niuDLWgkG2e7EHkYBXdaxt/N4H7mSFvZLSOwhCYjwWLdw8CbsC05NY+OtLgGzI3Q7OmkPmqX4oLYxTTg+v6wIDflbamQxmLz0bXJDAGCYS1WK1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WgADcaugluWe61r97qE4GJqpqFwgZGletQOxkU45hIg=; b=CT9a8UpprYSNRSg4Be+sA9r9RftV46VcWV9XlqZ/djEbIsjfRIPSjyGo1tdi0o3LFciI5Ei0HzCNbTlc4UtdWWjYHxVWeAQwXU9smv9MikLRH+LyLELTJmbqZaLLY249TUfiQ8mWR47FzfaZeYi0MC5o9zu95ij8TPGXuFk/X8DNvxVciOORuSVMq83uGII1XIUeuxXWyhrV+pgGjmVKmgbiRBcFtxZzkZCMU4Hxg+VM08VAEAcNtiWnwI+gi9B6vag9MZqz5WICgYxmyYHeBs0dCLVysJt8SXGZMaQvHjiXkc9AXDDmiH+VprJOvZo66hpomAVRuciYk6HFLQQINQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=fail (sender ip is 84.19.233.75) smtp.rcpttodomain=cirrus.com smtp.mailfrom=opensource.cirrus.com; dmarc=fail (p=reject sp=reject pct=100) action=oreject header.from=opensource.cirrus.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus4.onmicrosoft.com; s=selector2-cirrus4-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WgADcaugluWe61r97qE4GJqpqFwgZGletQOxkU45hIg=; b=jlEHBvZVhn+N5HU23/Mka4Ks28WjI6iyiqZa0VDpf0pqi1ixp0HyAVkufJIoez5fYM/fYGNruHwnaKU9eUvP7FyVtSThzbsq1oKTYHypmnNDrscuFsZj68UCmqaikv/geZDE1ejAy8UR3yXsb7+/mS4vCh3TD6CWyCFJLvqPAQE= Received: from BN9PR03CA0640.namprd03.prod.outlook.com (2603:10b6:408:13b::15) by SA0PR19MB4320.namprd19.prod.outlook.com (2603:10b6:806:81::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9073.27; Wed, 3 Sep 2025 09:45:56 +0000 Received: from BN3PEPF0000B06B.namprd21.prod.outlook.com (2603:10b6:408:13b:cafe::af) by BN9PR03CA0640.outlook.office365.com (2603:10b6:408:13b::15) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9073.27 via Frontend Transport; Wed, 3 Sep 2025 09:45:56 +0000 X-MS-Exchange-Authentication-Results: spf=fail (sender IP is 84.19.233.75) smtp.mailfrom=opensource.cirrus.com; dkim=none (message not signed) header.d=none;dmarc=fail action=oreject header.from=opensource.cirrus.com; Received-SPF: Fail (protection.outlook.com: domain of opensource.cirrus.com does not designate 84.19.233.75 as permitted sender) receiver=protection.outlook.com; client-ip=84.19.233.75; helo=edirelay1.ad.cirrus.com; Received: from edirelay1.ad.cirrus.com (84.19.233.75) by BN3PEPF0000B06B.mail.protection.outlook.com (10.167.243.70) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9115.0 via Frontend Transport; Wed, 3 Sep 2025 09:45:56 +0000 Received: from ediswmail9.ad.cirrus.com (ediswmail9.ad.cirrus.com [198.61.86.93]) by edirelay1.ad.cirrus.com (Postfix) with ESMTPS id 49C67406558; Wed, 3 Sep 2025 09:45:53 +0000 (UTC) Received: from ediswws07.ad.cirrus.com (ediswws07.ad.cirrus.com [198.90.208.14]) by ediswmail9.ad.cirrus.com (Postfix) with ESMTPSA id 340AE820273; Wed, 3 Sep 2025 09:45:53 +0000 (UTC) From: Charles Keepax To: broonie@kernel.org, lee@kernel.org Cc: lgirdwood@gmail.com, linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, patches@opensource.cirrus.com Subject: [PATCH 6/6] mfd: cs42l43: Remove IRQ masking in suspend Date: Wed, 3 Sep 2025 10:45:49 +0100 Message-ID: <20250903094549.271068-7-ckeepax@opensource.cirrus.com> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250903094549.271068-1-ckeepax@opensource.cirrus.com> References: <20250903094549.271068-1-ckeepax@opensource.cirrus.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN3PEPF0000B06B:EE_|SA0PR19MB4320:EE_ X-MS-Office365-Filtering-Correlation-Id: 58b680a7-1353-4c61-cd43-08ddeaceae57 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|82310400026|36860700013|34020700016|61400799027|12100799063; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?CsN3Y56TX24LlIAEdfGB/XqCKuJQXSnhS8e3hvMPHFhUJb2SJIMbdfjyjuHP?= =?us-ascii?Q?TDAF4hx6EcELe4sqzFq6qFZRYh+mFSSzwLgB/KpinhOflY99cDwZ3i7i7BWg?= =?us-ascii?Q?fYgXWUCRoqrD70KiYlhbNooaFMYUsGPMwoc4VzQXDwPUBH5XR2vJqmjJ7HyH?= =?us-ascii?Q?HjWzGXZaDrzD5CboPXol6jEZiyGFkqsUHeBhQr36jhVivGr6OfPN+q2epwXi?= =?us-ascii?Q?NHr+4wGWUarR4za2IBKnYU/XFTpvBFWZXlUyXLMhmlRNzjcmZmqFV/+4Tcwx?= =?us-ascii?Q?zN7nd+ZyEDAZ749KMjXIFZZ4vMGwAjhitw3hUEkg22aXwKLRJCrVtEUqSgDd?= =?us-ascii?Q?5FxhYl3CqtknpZzvDfO/LTJcYnP1uGbBqCBem8TNqL+R3ODlflcVxq4RBXsR?= =?us-ascii?Q?Gb+AdFZzI4b8NrG/iPEczyCvmcbUQ0FaeP+A5+Rc4xPAwdQywi1aa6xuBlkM?= =?us-ascii?Q?Tgn5C9HP+UXV8MjemesAQYUzOHl61oSqK9ggncmQjf3fRQvnyVDmQ1f1tfXT?= =?us-ascii?Q?FTAU9SnfiBTIVfngotVKUXajlSUX1kkPyiT1cB0hQ9g2LCVn0icCGQ+FAJh2?= =?us-ascii?Q?Y70nroe5SimXdMTO+msTz/d/6DS6AWF07D+GOwdi/KijiI9m0GlIqn8VGz4r?= =?us-ascii?Q?4gdxg5V5wTq8mk2iBFvWyAW3936vNofCJgBkL73f5SIXkKrGJyO4Frr8JXoZ?= =?us-ascii?Q?Bqd/IF3trGK/Swp2VOjFOY8uqVBesdmcUDeEacbxqP62zu/Md4I7YSbH9wwo?= =?us-ascii?Q?dQK90ka96W2yJNlPWd7jkkigEvZrXPN9UNOO60/YrWhRVfcfQi8rTPTEVncJ?= =?us-ascii?Q?9nI8fR6XH0WLtf+32ihj6pgU/M9D8akqYGl4AhSD77J/BBoOzdUoW4GFaQj0?= =?us-ascii?Q?9MOwyYG+f81i406HqJJSAod+n3o07PWdj5pzb5lUsB5IHtTlQdwNgDjQzO6X?= =?us-ascii?Q?LXcXqTviT3r58g8ev+U3r6b9+fTQGt5FrsAj2Tf3Mb5Ck4zdcRwQkoRbDDtE?= =?us-ascii?Q?tnT8C0NDYIm7VnWNksWJ5H7IA+uHedeqF/x5E9rA7366RBQ+HofxOwFikujq?= =?us-ascii?Q?FG/FtYGepiC5EEt6cDeqNqN92Q1j47YnTCVefCNn2fP8l3QSm96xQiFN6nX6?= =?us-ascii?Q?RcbLR053HH34u9g9UfiuXhj7Uaukbq2/xOBODfB6qzWUry/OmRObuAx0Cujy?= =?us-ascii?Q?LxgK07TptMvuxTRZ6rR0JT3VYJkW9EHzYtb/OwidpY1z2x175LAW1qjUfzyO?= =?us-ascii?Q?dftVuYya90CORT4o9dRaxCosAmbCBrduwtZHatYWqTWcpyM9SkCIu44YhviQ?= =?us-ascii?Q?jSLeeeajYRnh8RNmf+5XO56FU7TUhchC3XS5yqNqJ8DSqhrzCJTqxd/OPr45?= =?us-ascii?Q?flCaH5zcG5rL32VTeeHH0t9X8deVfuXNMFIkqgGNmAYWqBS0ttnxFZWoGKTV?= =?us-ascii?Q?90kqffbTMljk9GSivYO1ej7Xnt/uIFmOUAabRkgD7hSUDObbwJb+wyYJf/Nw?= =?us-ascii?Q?NKsWinsuMfLDAuZh8bVUS4s3gl9PT/9udxLO?= X-Forefront-Antispam-Report: CIP:84.19.233.75;CTRY:GB;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:edirelay1.ad.cirrus.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(376014)(82310400026)(36860700013)(34020700016)(61400799027)(12100799063);DIR:OUT;SFP:1501; X-OriginatorOrg: opensource.cirrus.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Sep 2025 09:45:56.3406 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 58b680a7-1353-4c61-cd43-08ddeaceae57 X-MS-Exchange-CrossTenant-Id: bec09025-e5bc-40d1-a355-8e955c307de8 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=bec09025-e5bc-40d1-a355-8e955c307de8;Ip=[84.19.233.75];Helo=[edirelay1.ad.cirrus.com] X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TreatMessagesAsInternal-BN3PEPF0000B06B.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR19MB4320 X-Proofpoint-ORIG-GUID: r3m9fC0akehJqbnd4xIszINkhVHcyhuH X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwOTAzMDA5NyBTYWx0ZWRfXxDdKMzjejIsI anD+v6tJXkY/9r6OBsi4MKVkpBd0/T3mnGMTJTN75KttRbhhXXI65R6GAXVYaeUNFzlSJpQ7Kem HHgn+Q29YOPP4vBlQjqmIsAwnYPn8QVkI6CtaaniTEWvH9f/hIRqPI8gpMDQ7UVlLTdn71kj9wD WvG6KeMg0yIjvC3XL1MBAfgvm/y49XsUBcMc/zr/uoHih21/UeFWn1bfSIxnbCwJI3HIR6WEphN GWPebzwX5vtOJ7klTQhmbOZ4Fk6YNTpeJrOhgKZZ+J+Nv9tg9yF/v006GMFQerhbRYJXYZWFPv0 T3O6/j54mZ1eAKY0CZG4UPtVzqqw/Q6MQFtGdC4Jxw4SgrH9I/kHmWX+dgUOj8= X-Authority-Analysis: v=2.4 cv=EvfSrTcA c=1 sm=1 tr=0 ts=68b80e58 cx=c_pps a=TfT5oGIBKUOXOh1H16nFbQ==:117 a=h1hSm8JtM9GN1ddwPAif2w==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=yJojWOMRYYMA:10 a=s63m1ICgrNkA:10 a=RWc_ulEos4gA:10 a=w1d2syhTAAAA:8 a=s4LoxV2n_K51Rj4AR4IA:9 a=jZz-an6Pvt0H8_Yc_ROU:22 X-Proofpoint-GUID: r3m9fC0akehJqbnd4xIszINkhVHcyhuH X-Proofpoint-Spam-Reason: safe Content-Type: text/plain; charset="utf-8" Now the individual child drivers mask their own IRQs there is no need for the MFD code to do so anymore. Signed-off-by: Charles Keepax --- drivers/mfd/cs42l43.c | 26 -------------------------- 1 file changed, 26 deletions(-) diff --git a/drivers/mfd/cs42l43.c b/drivers/mfd/cs42l43.c index 959298c8232f4..107cfb983fec4 100644 --- a/drivers/mfd/cs42l43.c +++ b/drivers/mfd/cs42l43.c @@ -1117,24 +1117,6 @@ EXPORT_SYMBOL_NS_GPL(cs42l43_dev_probe, "MFD_CS42L43= "); static int cs42l43_suspend(struct device *dev) { struct cs42l43 *cs42l43 =3D dev_get_drvdata(dev); - static const struct reg_sequence mask_all[] =3D { - { CS42L43_DECIM_MASK, 0xFFFFFFFF, }, - { CS42L43_EQ_MIX_MASK, 0xFFFFFFFF, }, - { CS42L43_ASP_MASK, 0xFFFFFFFF, }, - { CS42L43_PLL_MASK, 0xFFFFFFFF, }, - { CS42L43_SOFT_MASK, 0xFFFFFFFF, }, - { CS42L43_SWIRE_MASK, 0xFFFFFFFF, }, - { CS42L43_MSM_MASK, 0xFFFFFFFF, }, - { CS42L43_ACC_DET_MASK, 0xFFFFFFFF, }, - { CS42L43_I2C_TGT_MASK, 0xFFFFFFFF, }, - { CS42L43_SPI_MSTR_MASK, 0xFFFFFFFF, }, - { CS42L43_SW_TO_SPI_BRIDGE_MASK, 0xFFFFFFFF, }, - { CS42L43_OTP_MASK, 0xFFFFFFFF, }, - { CS42L43_CLASS_D_AMP_MASK, 0xFFFFFFFF, }, - { CS42L43_GPIO_INT_MASK, 0xFFFFFFFF, }, - { CS42L43_ASRC_MASK, 0xFFFFFFFF, }, - { CS42L43_HPOUT_MASK, 0xFFFFFFFF, }, - }; int ret; =20 ret =3D pm_runtime_resume_and_get(dev); @@ -1143,14 +1125,6 @@ static int cs42l43_suspend(struct device *dev) return ret; } =20 - /* The IRQs will be re-enabled on resume by the cache sync */ - ret =3D regmap_multi_reg_write_bypassed(cs42l43->regmap, - mask_all, ARRAY_SIZE(mask_all)); - if (ret) { - dev_err(cs42l43->dev, "Failed to mask IRQs: %d\n", ret); - return ret; - } - disable_irq(cs42l43->irq); =20 ret =3D pm_runtime_force_suspend(dev); --=20 2.47.2