[PATCH V4 0/2] Add regulator load support for QMP UFS PHY

Nitin Rawat posted 2 patches 1 month ago
drivers/phy/qualcomm/phy-qcom-qmp-ufs.c | 159 ++++++++++++++++--------
1 file changed, 108 insertions(+), 51 deletions(-)
[PATCH V4 0/2] Add regulator load support for QMP UFS PHY
Posted by Nitin Rawat 1 month ago
The series improves regulator handling in the QMP UFS PHY driver and
adds load configuration support for all supported platforms.

On some SoCs, regulators are shared between the UFS PHY and other IP
blocks. To maintain stability and power efficiency, the regulator
framework needs to know the UFS PHY's peak load, as it determines the
regulator's operating mode.

The first update replaces devm_regulator_bulk_get() with
devm_regulator_bulk_get_const(), converts the regulator name array to
a bulk data structure, and uses the init_load_uA field to automatically
apply regulator_set_load() before the first enable.

The second update adds platform-specific load settings for all supported
platform to ensure proper power management where regulators are shared.

Changes from V3:
1. Addressed Mani and Dmitry comment to include phy and pll init_load_uA
   for all platform.

Changes from v2:
1. Addressed Dmitry's comment to replace devm_regulator_bulk_get() with
   devm_regulator_bulk_get_const.
2. inline the qmp_ufs_vreg_init() function

Changes from v1:
1. Addressed comments to move load configuration from device tree to
   hardcoded, per-compatible data within the driver.
2. Accordingly updated commit text to reflect the same.
3. Addressed Manivannan's comment to avoid initialization of load.

Nitin Rawat (2):
  phy: qcom-qmp-ufs: Add regulator load voting for UFS QMP PHY
  phy: qcom-qmp-ufs: Add PHY and PLL regulator load

 drivers/phy/qualcomm/phy-qcom-qmp-ufs.c | 159 ++++++++++++++++--------
 1 file changed, 108 insertions(+), 51 deletions(-)

--
2.50.1
Re: [PATCH V4 0/2] Add regulator load support for QMP UFS PHY
Posted by Vinod Koul 1 month ago
On Sat, 30 Aug 2025 12:33:51 +0530, Nitin Rawat wrote:
> The series improves regulator handling in the QMP UFS PHY driver and
> adds load configuration support for all supported platforms.
> 
> On some SoCs, regulators are shared between the UFS PHY and other IP
> blocks. To maintain stability and power efficiency, the regulator
> framework needs to know the UFS PHY's peak load, as it determines the
> regulator's operating mode.
> 
> [...]

Applied, thanks!

[1/2] phy: qcom-qmp-ufs: Add regulator load voting for UFS QMP PHY
      commit: 0c4916aadb8df892399eec99f775655c31049195
[2/2] phy: qcom-qmp-ufs: Add PHY and PLL regulator load
      commit: df4beac9da5f162770c8563d11cda327d748c20b

Best regards,
-- 
~Vinod