[PATCH v2 0/6] genirq/test: Platform/architecture fixes

Brian Norris posted 6 patches 1 month, 1 week ago
kernel/irq/Kconfig    |  2 ++
kernel/irq/irq_test.c | 61 +++++++++++++++++++------------------------
2 files changed, 29 insertions(+), 34 deletions(-)
[PATCH v2 0/6] genirq/test: Platform/architecture fixes
Posted by Brian Norris 1 month, 1 week ago
The new kunit tests at kernel/irq/irq_test.c were primarily tested on
x86_64, with QEMU and with ARCH=um builds. Naturally, there are other
architectures that throw complications in the mix, with various CPU
hotplug and IRQ implementation choices.

Guenter has been dutifully noticing and reporting these errors, in
places like:
https://lore.kernel.org/all/b4cf04ea-d398-473f-bf11-d36643aa50dd@roeck-us.net/

I hope I've addressed all the failures, but it's hard to tell when I
don't have cross-compilers and QEMU setups for all of these
architectures.

I've tested what I could on arm, arm64, m68k, powerpc64, x86_64, and um
ARCH. (Notably, patch 4 ("genirq/test: Depend on SPARSE_IRQ") drops
support for ARCH=um and ARCH=m68k.)

This series is based on David's patch for these tests:

[PATCH] genirq/test: Fix depth tests on architectures with NOREQUEST by default.
https://lore.kernel.org/all/20250816094528.3560222-2-davidgow@google.com/

Changes in v2:
 * Make all tests depend on SPARSE_IRQ, not just a few (resolves
   ARCH=m68k issues)
 * Add David's Reviewed-by on unchanged patches

Brian Norris (6):
  genirq/test: Select IRQ_DOMAIN
  genirq/test: Factor out fake-virq setup
  genirq/test: Fail early if we can't request an IRQ
  genirq/test: Depend on SPARSE_IRQ
  genirq/test: Drop CONFIG_GENERIC_IRQ_MIGRATION assumptions
  genirq/test: Ensure CPU 1 is online for hotplug test

 kernel/irq/Kconfig    |  2 ++
 kernel/irq/irq_test.c | 61 +++++++++++++++++++------------------------
 2 files changed, 29 insertions(+), 34 deletions(-)

-- 
2.51.0.rc2.233.g662b1ed5c5-goog
Re: [PATCH v2 0/6] genirq/test: Platform/architecture fixes
Posted by Guenter Roeck 1 month, 1 week ago
On 8/22/25 11:59, Brian Norris wrote:
> The new kunit tests at kernel/irq/irq_test.c were primarily tested on
> x86_64, with QEMU and with ARCH=um builds. Naturally, there are other
> architectures that throw complications in the mix, with various CPU
> hotplug and IRQ implementation choices.
> 
> Guenter has been dutifully noticing and reporting these errors, in
> places like:
> https://lore.kernel.org/all/b4cf04ea-d398-473f-bf11-d36643aa50dd@roeck-us.net/
> 
> I hope I've addressed all the failures, but it's hard to tell when I
> don't have cross-compilers and QEMU setups for all of these
> architectures.
> 
> I've tested what I could on arm, arm64, m68k, powerpc64, x86_64, and um
> ARCH. (Notably, patch 4 ("genirq/test: Depend on SPARSE_IRQ") drops
> support for ARCH=um and ARCH=m68k.)
> 
> This series is based on David's patch for these tests:
> 
> [PATCH] genirq/test: Fix depth tests on architectures with NOREQUEST by default.
> https://lore.kernel.org/all/20250816094528.3560222-2-davidgow@google.com/
> 
> Changes in v2:
>   * Make all tests depend on SPARSE_IRQ, not just a few (resolves
>     ARCH=m68k issues)
>   * Add David's Reviewed-by on unchanged patches
> 

My test system says:

Qemu test results
	total: 637 pass: 637 fail: 0
Unit tests:
	pass: 640359 fail: 0

I sent Tested-by: tags for all patches of the series.

Guenter
Re: [PATCH v2 0/6] genirq/test: Platform/architecture fixes
Posted by Guenter Roeck 1 month, 1 week ago
On 8/22/25 11:59, Brian Norris wrote:
> The new kunit tests at kernel/irq/irq_test.c were primarily tested on
> x86_64, with QEMU and with ARCH=um builds. Naturally, there are other
> architectures that throw complications in the mix, with various CPU
> hotplug and IRQ implementation choices.
> 
> Guenter has been dutifully noticing and reporting these errors, in
> places like:
> https://lore.kernel.org/all/b4cf04ea-d398-473f-bf11-d36643aa50dd@roeck-us.net/
> 
> I hope I've addressed all the failures, but it's hard to tell when I
> don't have cross-compilers and QEMU setups for all of these
> architectures.
> 
> I've tested what I could on arm, arm64, m68k, powerpc64, x86_64, and um
> ARCH. (Notably, patch 4 ("genirq/test: Depend on SPARSE_IRQ") drops
> support for ARCH=um and ARCH=m68k.)
> 
> This series is based on David's patch for these tests:
> 
> [PATCH] genirq/test: Fix depth tests on architectures with NOREQUEST by default.
> https://lore.kernel.org/all/20250816094528.3560222-2-davidgow@google.com/
> 

I started a round of qemu tests. I'll send out results later tonight or
tomorrow morning (unless PG&E decides that we don't need power for the rest
of the day/night ;-).

Guenter